[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496902#comment-16496902
 ] 

ASF GitHub Bot commented on METRON-1579:


Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/1033


> Stellar should return the expression that failed in the exception
> -
>
> Key: METRON-1579
> URL: https://issues.apache.org/jira/browse/METRON-1579
> Project: Metron
>  Issue Type: Improvement
>Reporter: Casey Stella
>Priority: Major
>
> There are situations where we are not including the expression in the 
> exception. Also, in stellar enrichments, we should include the relevant 
> variable values in the exception to help with diagnosing issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494601#comment-16494601
 ] 

ASF GitHub Bot commented on METRON-1579:


Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/1033
  
+1
I will say, that the exception building facilities and builders should be 
publicly exposed as part of stellar as a follow on.  As part of my own antlr 
work on the syslog stuff, I am kind of fond of being able to allow expansion by 
deriving new listeners and visitors with separate implementations, the 
exception builders would be nice to have with that, if you follow.



> Stellar should return the expression that failed in the exception
> -
>
> Key: METRON-1579
> URL: https://issues.apache.org/jira/browse/METRON-1579
> Project: Metron
>  Issue Type: Improvement
>Reporter: Casey Stella
>Priority: Major
>
> There are situations where we are not including the expression in the 
> exception. Also, in stellar enrichments, we should include the relevant 
> variable values in the exception to help with diagnosing issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494156#comment-16494156
 ] 

ASF GitHub Bot commented on METRON-1579:


GitHub user cestella reopened a pull request:

https://github.com/apache/metron/pull/1033

METRON-1579: Stellar should return the expression that failed in the 
exception

## Contributor Comments
There are situations where we are not including the expression in the 
exception. Also, in stellar enrichments, we should include the relevant 
variable values in the exception to help with diagnosing issues.

You can try this out in the REPL as well as a stellar enrichment.  Use a 
stellar expression which fails (e.g. `num_var / 0` where `num_var` is an 
integer field).

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cestella/incubator-metron 
stellar_enrichment_exception

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/1033.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1033


commit 28bd80f56be14003feb168292ac07ea510fb5943
Author: cstella 
Date:   2018-05-25T15:19:55Z

Updating stellar to generate more helpful exceptions.

commit 6946fdbefb7a3baf80beb0d68b86d64cd271f442
Author: cstella 
Date:   2018-05-25T18:26:05Z

Updating error message for predicates

commit 84f07ec0048c9144eb0dde06f5c3b8dff93dbc02
Author: cstella 
Date:   2018-05-25T18:47:13Z

Missed ordinal test

commit ac97b4f3a4dce0511afaab0875680ec5cd8152b3
Author: cstella 
Date:   2018-05-25T19:39:56Z

missed stats test

commit 167aae0faf745bbc7efe19fa1b1298e5632187d7
Author: cstella 
Date:   2018-05-25T20:14:24Z

another missed test.

commit 44ac3420a4406ed7ddd8524b4bf33c638269b643
Author: cstella 
Date:   2018-05-25T20:50:04Z

And all the profiler tests.

commit 71bc45e72c79efc5ac267e141f896c83ad3acc3d
Author: cstella 
Date:   2018-05-25T21:26:23Z

and assorted other tests

commit 3384124bfdf332c6cf08a837f4ab7f07b4226e33
Author: 

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494155#comment-16494155
 ] 

ASF GitHub Bot commented on METRON-1579:


Github user cestella closed the pull request at:

https://github.com/apache/metron/pull/1033


> Stellar should return the expression that failed in the exception
> -
>
> Key: METRON-1579
> URL: https://issues.apache.org/jira/browse/METRON-1579
> Project: Metron
>  Issue Type: Improvement
>Reporter: Casey Stella
>Priority: Major
>
> There are situations where we are not including the expression in the 
> exception. Also, in stellar enrichments, we should include the relevant 
> variable values in the exception to help with diagnosing issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493939#comment-16493939
 ] 

ASF GitHub Bot commented on METRON-1579:


Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/1033#discussion_r191513907
  
--- Diff: 
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/BaseStellarProcessor.java
 ---
@@ -143,7 +143,11 @@ public T parse(final String rule, final 
VariableResolver variableResolver, final
 try {
   return clazz.cast(expression
   .apply(new StellarCompiler.ExpressionState(context, 
functionResolver, variableResolver)));
-}finally {
+}
--- End diff --

Yeah, agreed.


> Stellar should return the expression that failed in the exception
> -
>
> Key: METRON-1579
> URL: https://issues.apache.org/jira/browse/METRON-1579
> Project: Metron
>  Issue Type: Improvement
>Reporter: Casey Stella
>Priority: Major
>
> There are situations where we are not including the expression in the 
> exception. Also, in stellar enrichments, we should include the relevant 
> variable values in the exception to help with diagnosing issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493935#comment-16493935
 ] 

ASF GitHub Bot commented on METRON-1579:


Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/1033#discussion_r191513381
  
--- Diff: 
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/adapters/stellar/StellarAdapter.java
 ---
@@ -92,6 +96,19 @@ public String getStreamSubGroup(String enrichmentType, 
String field) {
 }
   }
 
--- End diff --

Yeah, I agree.  I'll move that.


> Stellar should return the expression that failed in the exception
> -
>
> Key: METRON-1579
> URL: https://issues.apache.org/jira/browse/METRON-1579
> Project: Metron
>  Issue Type: Improvement
>Reporter: Casey Stella
>Priority: Major
>
> There are situations where we are not including the expression in the 
> exception. Also, in stellar enrichments, we should include the relevant 
> variable values in the exception to help with diagnosing issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492066#comment-16492066
 ] 

ASF GitHub Bot commented on METRON-1579:


Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/1033#discussion_r191080770
  
--- Diff: 
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/adapters/stellar/StellarAdapter.java
 ---
@@ -92,6 +96,19 @@ public String getStreamSubGroup(String enrichmentType, 
String field) {
 }
   }
 
--- End diff --

I think this should be part of stellar itself and not part of enrichment. 


> Stellar should return the expression that failed in the exception
> -
>
> Key: METRON-1579
> URL: https://issues.apache.org/jira/browse/METRON-1579
> Project: Metron
>  Issue Type: Improvement
>Reporter: Casey Stella
>Priority: Major
>
> There are situations where we are not including the expression in the 
> exception. Also, in stellar enrichments, we should include the relevant 
> variable values in the exception to help with diagnosing issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492065#comment-16492065
 ] 

ASF GitHub Bot commented on METRON-1579:


Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/1033#discussion_r191080813
  
--- Diff: 
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/BaseStellarProcessor.java
 ---
@@ -143,7 +143,11 @@ public T parse(final String rule, final 
VariableResolver variableResolver, final
 try {
   return clazz.cast(expression
   .apply(new StellarCompiler.ExpressionState(context, 
functionResolver, variableResolver)));
-}finally {
+}
--- End diff --

Maybe we can have stellar exception builders that provide standard, 
consistent exception building


> Stellar should return the expression that failed in the exception
> -
>
> Key: METRON-1579
> URL: https://issues.apache.org/jira/browse/METRON-1579
> Project: Metron
>  Issue Type: Improvement
>Reporter: Casey Stella
>Priority: Major
>
> There are situations where we are not including the expression in the 
> exception. Also, in stellar enrichments, we should include the relevant 
> variable values in the exception to help with diagnosing issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490863#comment-16490863
 ] 

ASF GitHub Bot commented on METRON-1579:


GitHub user cestella opened a pull request:

https://github.com/apache/metron/pull/1033

METRON-1579: Stellar should return the expression that failed in the 
exception

## Contributor Comments
There are situations where we are not including the expression in the 
exception. Also, in stellar enrichments, we should include the relevant 
variable values in the exception to help with diagnosing issues.

You can try this out in the REPL as well as a stellar enrichment.  Use a 
stellar expression which fails (e.g. `num_var / 0` where `num_var` is an 
integer field).

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cestella/incubator-metron 
stellar_enrichment_exception

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/1033.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1033


commit 28bd80f56be14003feb168292ac07ea510fb5943
Author: cstella 
Date:   2018-05-25T15:19:55Z

Updating stellar to generate more helpful exceptions.




> Stellar should return the expression that failed in the exception
> -
>
> Key: METRON-1579
> URL: https://issues.apache.org/jira/browse/METRON-1579
> Project: Metron
>  Issue Type: Improvement
>Reporter: Casey Stella
>Priority: Major
>
> There are situations where we are not including the expression in the 
> exception. Also, in stellar enrichments, we should include the relevant 
> variable values in the exception to help with diagnosing issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)