[jira] [Updated] (NIFI-2948) AWS DynamoDB Processors Do Not Update Credentials

[James Wing (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Wing updated NIFI-2948:
-
Status: Patch Available  (was: Open)

> AWS DynamoDB Processors Do Not Update Credentials
> -
>
> Key: NIFI-2948
> URL: https://issues.apache.org/jira/browse/NIFI-2948
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 0.7.0, 1.0.0
>Reporter: James Wing
>Priority: Minor
>
> Following a report to the dev email list, there appears to be a bug in the 
> AWS DynamoDB processors where the AWS credentials are cached by the processor 
> once started, and not updated even if the processor is stopped, reconfigured, 
> and started.
> The problem appears to be 
> [AbstractDynamoDBProcessor::getDynamoDB|https://github.com/apache/nifi/blob/rel/nifi-1.0.0/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/AbstractDynamoDBProcessor.java#L218],
>  which assigns the dynamo client object to a class variable only once.
> *Repro Steps*
> # Add GetDynamoDB processor
> # Configure GetDynamoDB required properties but *not* any credential fields
> # Start the processor
> # Run a flowfile through - it should fail with 
> "MissingAuthenticationTokenException" error
> # Stop the GetDynamoDB processor
> # Configure valid AWS credentials
> # Start the processor
> # Run a flowfile through - it should fail again with 
> "MissingAuthenticationTokenException" still using the old credentials



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2948) AWS DynamoDB Processors Do Not Update Credentials

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635279#comment-15635279
 ] 

ASF GitHub Bot commented on NIFI-2948:
--

GitHub user jvwing opened a pull request:

https://github.com/apache/nifi/pull/1182

NIFI-2948 Fix DynamoDB Cached Credentials

This is a minimal change to clear the cached DynamoDB Document Client 
containing credentials when the processor is stopped.

---

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jvwing/nifi NIFI-2948-dynamodb-creds-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1182


commit 619249cf5fd632537e17851177e56ac6989b9707
Author: James Wing 
Date:   2016-11-04T03:24:19Z

NIFI-2948 Fix DynamoDB Cached Credentials




> AWS DynamoDB Processors Do Not Update Credentials
> -
>
> Key: NIFI-2948
> URL: https://issues.apache.org/jira/browse/NIFI-2948
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.0.0, 0.7.0
>Reporter: James Wing
>Priority: Minor
>
> Following a report to the dev email list, there appears to be a bug in the 
> AWS DynamoDB processors where the AWS credentials are cached by the processor 
> once started, and not updated even if the processor is stopped, reconfigured, 
> and started.
> The problem appears to be 
> [AbstractDynamoDBProcessor::getDynamoDB|https://github.com/apache/nifi/blob/rel/nifi-1.0.0/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/AbstractDynamoDBProcessor.java#L218],
>  which assigns the dynamo client object to a class variable only once.
> *Repro Steps*
> # Add GetDynamoDB processor
> # Configure GetDynamoDB required properties but *not* any credential fields
> # Start the processor
> # Run a flowfile through - it should fail with 
> "MissingAuthenticationTokenException" error
> # Stop the GetDynamoDB processor
> # Configure valid AWS credentials
> # Start the processor
> # Run a flowfile through - it should fail again with 
> "MissingAuthenticationTokenException" still using the old credentials



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1182: NIFI-2948 Fix DynamoDB Cached Credentials

[jvwing]

GitHub user jvwing opened a pull request:

https://github.com/apache/nifi/pull/1182

NIFI-2948 Fix DynamoDB Cached Credentials

This is a minimal change to clear the cached DynamoDB Document Client 
containing credentials when the processor is stopped.

---

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jvwing/nifi NIFI-2948-dynamodb-creds-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1182


commit 619249cf5fd632537e17851177e56ac6989b9707
Author: James Wing 
Date:   2016-11-04T03:24:19Z

NIFI-2948 Fix DynamoDB Cached Credentials




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2991) JSON.org license is now CatX

[Sean Busbey (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635243#comment-15635243
 ] 

Sean Busbey commented on NIFI-2991:
---

spoke too soon, the 0.x line(s) are using version 1.10.z of the library, so 
they are in the no good list.

> JSON.org license is now CatX
> 
>
> Key: NIFI-2991
> URL: https://issues.apache.org/jira/browse/NIFI-2991
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Sean Busbey
>Assignee: Joseph Witt
>Priority: Blocker
> Fix For: 1.1.0
>
>
> per [update resolved legal|http://www.apache.org/legal/resolved.html#json]:
> {quote}
> CAN APACHE PRODUCTS INCLUDE WORKS LICENSED UNDER THE JSON LICENSE?
> No. As of 2016-11-03 this has been moved to the 'Category X' license list. 
> Prior to this, use of the JSON Java library was allowed. See Debian's page 
> for a list of alternatives.
> {quote}
> I don't know how many of our versions include stuff under this license, it's 
> definitely currently in master.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2991) JSON.org license is now CatX

[Sean Busbey (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15635230#comment-15635230
 ] 

Sean Busbey commented on NIFI-2991:
---

:good_news: this blurb in the AWS module is just out of date; the AWS Java SDK 
removed JSON.org code in release 1.11 and we use 1.11.8

[NOTICE for nifi-aws-nar as of 
0841f14c|https://github.com/apache/nifi/blob/0841f14c18eb3798ebc798406109bd3f9bdb6643/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-nar/src/main/resources/META-INF/NOTICE#L71]
{code}
  **
  THIRD PARTY COMPONENTS
  **
  This software includes third party software subject to the following 
copyrights:
  - XML parsing and utility functions from JetS3t - Copyright 2006-2009 
James Murty.
  - JSON parsing and utility functions from JSON.org - Copyright 2002 
JSON.org.
  - PKCS#1 PEM encoded private key parsing and utility functions from 
oauth.googlecode.com - Copyright 1998-2010 AOL Inc.
{code}

> JSON.org license is now CatX
> 
>
> Key: NIFI-2991
> URL: https://issues.apache.org/jira/browse/NIFI-2991
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Sean Busbey
>Assignee: Joseph Witt
>Priority: Blocker
> Fix For: 1.1.0
>
>
> per [update resolved legal|http://www.apache.org/legal/resolved.html#json]:
> {quote}
> CAN APACHE PRODUCTS INCLUDE WORKS LICENSED UNDER THE JSON LICENSE?
> No. As of 2016-11-03 this has been moved to the 'Category X' license list. 
> Prior to this, use of the JSON Java library was allowed. See Debian's page 
> for a list of alternatives.
> {quote}
> I don't know how many of our versions include stuff under this license, it's 
> definitely currently in master.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (NIFI-2991) JSON.org license is now CatX

[Joseph Witt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Witt updated NIFI-2991:
--
Fix Version/s: 1.1.0

> JSON.org license is now CatX
> 
>
> Key: NIFI-2991
> URL: https://issues.apache.org/jira/browse/NIFI-2991
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Sean Busbey
>Assignee: Joseph Witt
>Priority: Blocker
> Fix For: 1.1.0
>
>
> per [update resolved legal|http://www.apache.org/legal/resolved.html#json]:
> {quote}
> CAN APACHE PRODUCTS INCLUDE WORKS LICENSED UNDER THE JSON LICENSE?
> No. As of 2016-11-03 this has been moved to the 'Category X' license list. 
> Prior to this, use of the JSON Java library was allowed. See Debian's page 
> for a list of alternatives.
> {quote}
> I don't know how many of our versions include stuff under this license, it's 
> definitely currently in master.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (NIFI-2991) JSON.org license is now CatX

[Sean Busbey (JIRA)]

Sean Busbey created NIFI-2991:
-

 Summary: JSON.org license is now CatX
 Key: NIFI-2991
 URL: https://issues.apache.org/jira/browse/NIFI-2991
 Project: Apache NiFi
  Issue Type: Bug
Reporter: Sean Busbey
Priority: Blocker


per [update resolved legal|http://www.apache.org/legal/resolved.html#json]:

{quote}
CAN APACHE PRODUCTS INCLUDE WORKS LICENSED UNDER THE JSON LICENSE?

No. As of 2016-11-03 this has been moved to the 'Category X' license list. 
Prior to this, use of the JSON Java library was allowed. See Debian's page for 
a list of alternatives.
{quote}

I don't know how many of our versions include stuff under this license, it's 
definitely currently in master.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2116) Translate Documentation Into Spanish

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634934#comment-15634934
 ] 

ASF GitHub Bot commented on NIFI-2116:
--

Github user chagara closed the pull request at:

https://github.com/apache/nifi/pull/587


> Translate Documentation Into Spanish
> 
>
> Key: NIFI-2116
> URL: https://issues.apache.org/jira/browse/NIFI-2116
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Documentation & Website
>Reporter: Chagara
>Assignee: Chagara
>Priority: Minor
>
> Create documentation in Spanish to expand NIFI reach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2116) Translate Documentation Into Spanish

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634935#comment-15634935
 ] 

ASF GitHub Bot commented on NIFI-2116:
--

Github user chagara commented on the issue:

https://github.com/apache/nifi/pull/587
  
I'm going to close this pull request since the documentation changed a lot 
and the changes added here are not needed anymore. I have been trying to 
translate the overview doc and will take some time since the new information 
when translated makes barely any sense so I have to connect everything 
correctly.


> Translate Documentation Into Spanish
> 
>
> Key: NIFI-2116
> URL: https://issues.apache.org/jira/browse/NIFI-2116
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Documentation & Website
>Reporter: Chagara
>Assignee: Chagara
>Priority: Minor
>
> Create documentation in Spanish to expand NIFI reach.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #587: NIFI-2116 Initial Draft for Spanish readme.md

[chagara]

Github user chagara commented on the issue:

https://github.com/apache/nifi/pull/587
  
I'm going to close this pull request since the documentation changed a lot 
and the changes added here are not needed anymore. I have been trying to 
translate the overview doc and will take some time since the new information 
when translated makes barely any sense so I have to connect everything 
correctly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #587: NIFI-2116 Initial Draft for Spanish readme.md

[chagara]

Github user chagara closed the pull request at:

https://github.com/apache/nifi/pull/587


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-1322) Support appending files in PutHDFS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634244#comment-15634244
 ] 

ASF GitHub Bot commented on NIFI-1322:
--

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1181

NIFI-1322 - PutHDFS - allow file append resolution

Two remarks:
- LocalFileSystem object used for unit tests does not implement the append 
method.
- Based on HDFS-4600 (https://issues.apache.org/jira/browse/HDFS-4600), 
appending to a file is only possible if the replication factor is lesser or 
equal than the number of data nodes in the cluster. For live testing with a 
standalone instance, consider changing the replication factor to 1 for the file 
you are appending to.

Also, I considered that it would be up to the user to handle the demarcator 
between two appended messages if such a demarcator is expected.

Finally, if two processors are appending to the same file, errors may be 
raised due to concurrent access to the file. However, if redirecting the 
failure relationship back to the processor, the processors should, in the end, 
be able to append the messages. Obviously, in such a case, message ordering 
shall not be a requirement. Local testing suggests that users should use a 
MergeContent processor as upstream processor in order to ensure acceptable 
bandwidth.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-1322

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1181


commit a42ed1d547762b51dbe27275aa54e0736e7046d4
Author: Pierre Villard 
Date:   2016-11-02T19:38:52Z

PutHDFS - allow file append resolution




> Support appending files in PutHDFS
> --
>
> Key: NIFI-1322
> URL: https://issues.apache.org/jira/browse/NIFI-1322
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Scott
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1181: NIFI-1322 - PutHDFS - allow file append resolution

[pvillard31]

GitHub user pvillard31 opened a pull request:

https://github.com/apache/nifi/pull/1181

NIFI-1322 - PutHDFS - allow file append resolution

Two remarks:
- LocalFileSystem object used for unit tests does not implement the append 
method.
- Based on HDFS-4600 (https://issues.apache.org/jira/browse/HDFS-4600), 
appending to a file is only possible if the replication factor is lesser or 
equal than the number of data nodes in the cluster. For live testing with a 
standalone instance, consider changing the replication factor to 1 for the file 
you are appending to.

Also, I considered that it would be up to the user to handle the demarcator 
between two appended messages if such a demarcator is expected.

Finally, if two processors are appending to the same file, errors may be 
raised due to concurrent access to the file. However, if redirecting the 
failure relationship back to the processor, the processors should, in the end, 
be able to append the messages. Obviously, in such a case, message ordering 
shall not be a requirement. Local testing suggests that users should use a 
MergeContent processor as upstream processor in order to ensure acceptable 
bandwidth.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pvillard31/nifi NIFI-1322

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1181


commit a42ed1d547762b51dbe27275aa54e0736e7046d4
Author: Pierre Villard 
Date:   2016-11-02T19:38:52Z

PutHDFS - allow file append resolution




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2989) UI - Improve Update Policy dialog (Title, Text and Buttons)

[Andrew Lim (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15634107#comment-15634107
 ] 

Andrew Lim commented on NIFI-2989:
--

Looked at the Admin Guide where Policy Inheritance is documented and it has the 
following text:

"Inherited policies and their users can be restored by deleting the replacement 
policy."

So, another take at the additional text could be:   "By deleting this policy, 
the inherited policy will be restored."

> UI - Improve Update Policy dialog (Title, Text and Buttons)
> ---
>
> Key: NIFI-2989
> URL: https://issues.apache.org/jira/browse/NIFI-2989
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Andrew Lim
>Assignee: Matt Gilman
>Priority: Minor
> Attachments: NIFI-2989_UpdatePolicyDialog.png
>
>
> Referencing the attached screenshot:
> 1.  Change the title "Update Policy" to "Delete Policy"
> 2.  After the text "Are you sure you want to delete this policy?" add another 
> paragraph with:
> "By deleting this policy, the inherited policy will be reinstated."
> 3. Change the buttons from "Yes/No" to "Cancel/Delete".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (NIFI-2989) UI - Improve Update Policy dialog (Title, Text and Buttons)

[Matt Gilman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman reassigned NIFI-2989:
-

Assignee: Matt Gilman

> UI - Improve Update Policy dialog (Title, Text and Buttons)
> ---
>
> Key: NIFI-2989
> URL: https://issues.apache.org/jira/browse/NIFI-2989
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Andrew Lim
>Assignee: Matt Gilman
>Priority: Minor
> Attachments: NIFI-2989_UpdatePolicyDialog.png
>
>
> Referencing the attached screenshot:
> 1.  Change the title "Update Policy" to "Delete Policy"
> 2.  After the text "Are you sure you want to delete this policy?" add another 
> paragraph with:
> "By deleting this policy, the inherited policy will be reinstated."
> 3. Change the buttons from "Yes/No" to "Cancel/Delete".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (NIFI-2990) Access Policies: Link for process group should navigate to the Access Policies window for that process group

[Andrew Lim (JIRA)]

Andrew Lim created NIFI-2990:


 Summary: Access Policies:  Link for process group should navigate 
to the Access Policies window for that process group
 Key: NIFI-2990
 URL: https://issues.apache.org/jira/browse/NIFI-2990
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core UI
Affects Versions: 1.1.0
Reporter: Andrew Lim


Currently, the link takes you to that process group being selected in the 
canvas.  So if the user  wants to modify the access policies on that PG, he/she 
has to select the "key" icon in the Operate Palette.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2909) Provide a framework mechanism for loading additional classpath resources

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633855#comment-15633855
 ] 

ASF GitHub Bot commented on NIFI-2909:
--

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1156
  
@bbende thanks, will start looking


> Provide a framework mechanism for loading additional classpath resources
> 
>
> Key: NIFI-2909
> URL: https://issues.apache.org/jira/browse/NIFI-2909
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.1.0
>
>
> We currently have several components with a property for specifying 
> additional classpath resources (DBCP connection pool, scripting processors, 
> JMS). Each of these components is responsible for handling this in its own 
> way. 
> The framework should provide a more integrated solution to make it easier for 
> component developers to deal with this scenario. Some requirements that need 
> to be met by this solution:
> - Multiple instances of the same component with different resources added to 
> the classpath and not interfering with each other (i.e. two DBCP connection 
> pools using different drivers)
> - Ability to modify the actual ClassLoader of the component to deal with 
> frameworks that use Class.forName() without passing in a ClassLoader, meaning 
> if a processor loads class A and class A calls Class.forName(classBName), 
> then class B needs to be available in the ClassLoader that loaded the 
> processor's class which in turn loaded class A
> - A component developer should be able to indicate that a given 
> PropertyDescriptor represents a classpath resource and the framework should 
> take care of the ClassLoader manipulation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

[olegz]

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1156
  
@bbende thanks, will start looking


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2909) Provide a framework mechanism for loading additional classpath resources

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633848#comment-15633848
 ] 

ASF GitHub Bot commented on NIFI-2909:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1156
  
@olegz I pushed up a second commit that with the change that I described 
above, and also some of the changes from your feedback. Unfortunately I had 
already rebased my branch before you had started reviewing, so i ended up 
having to force push, but I left it as two commits where the first one has the 
stuff you already looked at, and the second commit has changes after that.

I think the remaining discussion point is mostly around how restrictive we 
get regarding what happens when one or more resources can't be found. I 
understand the point about what happens if something that is necessary can't be 
loaded, but I also want to give flexibility to the developers using this 
feature. There may be cases where someone wants to provide a couple of 
directories that are common locations for a given library, and if found then 
load whatever is found, but if not then maybe they don't care. One option might 
be to provide a validator that uses ClassLoader.getURLsforClasspath to validate 
everything resolves, and then document that this is available, but not enforce 
that it is always used.


> Provide a framework mechanism for loading additional classpath resources
> 
>
> Key: NIFI-2909
> URL: https://issues.apache.org/jira/browse/NIFI-2909
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.1.0
>
>
> We currently have several components with a property for specifying 
> additional classpath resources (DBCP connection pool, scripting processors, 
> JMS). Each of these components is responsible for handling this in its own 
> way. 
> The framework should provide a more integrated solution to make it easier for 
> component developers to deal with this scenario. Some requirements that need 
> to be met by this solution:
> - Multiple instances of the same component with different resources added to 
> the classpath and not interfering with each other (i.e. two DBCP connection 
> pools using different drivers)
> - Ability to modify the actual ClassLoader of the component to deal with 
> frameworks that use Class.forName() without passing in a ClassLoader, meaning 
> if a processor loads class A and class A calls Class.forName(classBName), 
> then class B needs to be available in the ClassLoader that loaded the 
> processor's class which in turn loaded class A
> - A component developer should be able to indicate that a given 
> PropertyDescriptor represents a classpath resource and the framework should 
> take care of the ClassLoader manipulation



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

[bbende]

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1156
  
@olegz I pushed up a second commit that with the change that I described 
above, and also some of the changes from your feedback. Unfortunately I had 
already rebased my branch before you had started reviewing, so i ended up 
having to force push, but I left it as two commits where the first one has the 
stuff you already looked at, and the second commit has changes after that.

I think the remaining discussion point is mostly around how restrictive we 
get regarding what happens when one or more resources can't be found. I 
understand the point about what happens if something that is necessary can't be 
loaded, but I also want to give flexibility to the developers using this 
feature. There may be cases where someone wants to provide a couple of 
directories that are common locations for a given library, and if found then 
load whatever is found, but if not then maybe they don't care. One option might 
be to provide a validator that uses ClassLoader.getURLsforClasspath to validate 
everything resolves, and then document that this is available, but not enforce 
that it is always used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1180: NIFI-2928: Fixed checkstyle violation in FetchFile

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1180


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633823#comment-15633823
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

Github user brosander commented on the issue:

https://github.com/apache/nifi/pull/1180
  
+1, merged


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1180: NIFI-2928: Fixed checkstyle violation in FetchFile

[brosander]

Github user brosander commented on the issue:

https://github.com/apache/nifi/pull/1180
  
+1, merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633821#comment-15633821
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

Github user brosander commented on the issue:

https://github.com/apache/nifi/pull/1180
  
+1, merging


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1180: NIFI-2928: Fixed checkstyle violation in FetchFile

[brosander]

Github user brosander commented on the issue:

https://github.com/apache/nifi/pull/1180
  
+1, merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633813#comment-15633813
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1180


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633811#comment-15633811
 ] 

ASF subversion and git services commented on NIFI-2928:
---

Commit 0841f14c18eb3798ebc798406109bd3f9bdb6643 in nifi's branch 
refs/heads/master from [~mattyb149]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=0841f14 ]

NIFI-2928: Fixed checkstyle violation in FetchFile

This closes #1180

Signed-off-by: Bryan Rosander 


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1118: NIFI-2716 initial implementation of JMS Broker processor

[olegz]

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1118
  
@brosander all is good now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2716) Allow NiFi to manage embedded JMS Brokers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633804#comment-15633804
 ] 

ASF GitHub Bot commented on NIFI-2716:
--

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1118
  
@brosander all is good now


> Allow NiFi to manage embedded JMS Brokers
> -
>
> Key: NIFI-2716
> URL: https://issues.apache.org/jira/browse/NIFI-2716
> Project: Apache NiFi
>  Issue Type: New Feature
>Affects Versions: 1.0.0
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
>
> Several community members expressed interest in NiFi acting as a JMS Broker 
> to avoid deploying and managing external JMS Brokers. While implementing JMS 
> Broker from scratch would be rather complex, using embedded capabilities of 
> some OS JMS Broker implementations (e.g., ActiveMQ) together with native 
> capabilities of  NiFi (i.e., Processor and/or Controller Service) could prove 
> to be a very valuable feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (NIFI-2989) UI - Improve Update Policy dialog (Title, Text and Buttons)

[Andrew Lim (JIRA)]

Andrew Lim created NIFI-2989:


 Summary: UI - Improve Update Policy dialog (Title, Text and 
Buttons)
 Key: NIFI-2989
 URL: https://issues.apache.org/jira/browse/NIFI-2989
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core UI
Reporter: Andrew Lim
Priority: Minor


Referencing the attached screenshot:

1.  Change the title "Update Policy" to "Delete Policy"
2.  After the text "Are you sure you want to delete this policy?" add another 
paragraph with:

"By deleting this policy, the inherited policy will be reinstated."

3. Change the buttons from "Yes/No" to "Cancel/Delete".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (NIFI-2989) UI - Improve Update Policy dialog (Title, Text and Buttons)

[Andrew Lim (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Lim updated NIFI-2989:
-
Attachment: NIFI-2989_UpdatePolicyDialog.png

> UI - Improve Update Policy dialog (Title, Text and Buttons)
> ---
>
> Key: NIFI-2989
> URL: https://issues.apache.org/jira/browse/NIFI-2989
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Andrew Lim
>Priority: Minor
> Attachments: NIFI-2989_UpdatePolicyDialog.png
>
>
> Referencing the attached screenshot:
> 1.  Change the title "Update Policy" to "Delete Policy"
> 2.  After the text "Are you sure you want to delete this policy?" add another 
> paragraph with:
> "By deleting this policy, the inherited policy will be reinstated."
> 3. Change the buttons from "Yes/No" to "Cancel/Delete".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2989) UI - Improve Update Policy dialog (Title, Text and Buttons)

[Andrew Lim (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633779#comment-15633779
 ] 

Andrew Lim commented on NIFI-2989:
--

The suggested text "By deleting this policy, the inherited policy will be 
reinstated." is just a first stab.  Any feedback would be much appreciated.

> UI - Improve Update Policy dialog (Title, Text and Buttons)
> ---
>
> Key: NIFI-2989
> URL: https://issues.apache.org/jira/browse/NIFI-2989
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Andrew Lim
>Priority: Minor
> Attachments: NIFI-2989_UpdatePolicyDialog.png
>
>
> Referencing the attached screenshot:
> 1.  Change the title "Update Policy" to "Delete Policy"
> 2.  After the text "Are you sure you want to delete this policy?" add another 
> paragraph with:
> "By deleting this policy, the inherited policy will be reinstated."
> 3. Change the buttons from "Yes/No" to "Cancel/Delete".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi-minifi-cpp issue #22: MINIFI-123 Pthreads linker fix

[apiri]

Github user apiri commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/22
  
reviewing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2716) Allow NiFi to manage embedded JMS Brokers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633754#comment-15633754
 ] 

ASF GitHub Bot commented on NIFI-2716:
--

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1118
  
@brosander I'll fix it. Thanks for pointing it out


> Allow NiFi to manage embedded JMS Brokers
> -
>
> Key: NIFI-2716
> URL: https://issues.apache.org/jira/browse/NIFI-2716
> Project: Apache NiFi
>  Issue Type: New Feature
>Affects Versions: 1.0.0
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
>
> Several community members expressed interest in NiFi acting as a JMS Broker 
> to avoid deploying and managing external JMS Brokers. While implementing JMS 
> Broker from scratch would be rather complex, using embedded capabilities of 
> some OS JMS Broker implementations (e.g., ActiveMQ) together with native 
> capabilities of  NiFi (i.e., Processor and/or Controller Service) could prove 
> to be a very valuable feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1118: NIFI-2716 initial implementation of JMS Broker processor

[olegz]

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1118
  
@brosander I'll fix it. Thanks for pointing it out


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633721#comment-15633721
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

GitHub user mattyb149 opened a pull request:

https://github.com/apache/nifi/pull/1180

NIFI-2928: Fixed checkstyle violation in FetchFile

Missed this during review :(


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mattyb149/nifi NIFI-2928

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1180






> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1180: NIFI-2928: Fixed checkstyle violation in FetchFile

[mattyb149]

GitHub user mattyb149 opened a pull request:

https://github.com/apache/nifi/pull/1180

NIFI-2928: Fixed checkstyle violation in FetchFile

Missed this during review :(


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mattyb149/nifi NIFI-2928

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1180






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2960) Remove unused documentation images

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633641#comment-15633641
 ] 

ASF GitHub Bot commented on NIFI-2960:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1169
  
Thanks @andrewmlim! This has been merged to master.


> Remove unused documentation images
> --
>
> Key: NIFI-2960
> URL: https://issues.apache.org/jira/browse/NIFI-2960
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation & Website
>Affects Versions: 1.0.0
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Trivial
> Fix For: 1.1.0
>
>
> There are images that are no longer used in the 1.0 documentation as they 
> reference the 0.x UI:
> anonymous-access.png
> controller-services-edit-buttons2.png
> iconFlowHistory.png
> iconInputPortSmall.png
> iconOutputPortSmall.png
> iconSettings.png
> iconSummary.png
> iconUsers.png
> iconViewDetails.png
> nifi-arch-cluster.png
> nifi-arch.png
> reporting-tasks-edit-buttons.png
> request-access.png
> status-bar.png



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (NIFI-2960) Remove unused documentation images

[Matt Gilman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman resolved NIFI-2960.
---
   Resolution: Fixed
Fix Version/s: 1.1.0

> Remove unused documentation images
> --
>
> Key: NIFI-2960
> URL: https://issues.apache.org/jira/browse/NIFI-2960
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation & Website
>Affects Versions: 1.0.0
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Trivial
> Fix For: 1.1.0
>
>
> There are images that are no longer used in the 1.0 documentation as they 
> reference the 0.x UI:
> anonymous-access.png
> controller-services-edit-buttons2.png
> iconFlowHistory.png
> iconInputPortSmall.png
> iconOutputPortSmall.png
> iconSettings.png
> iconSummary.png
> iconUsers.png
> iconViewDetails.png
> nifi-arch-cluster.png
> nifi-arch.png
> reporting-tasks-edit-buttons.png
> request-access.png
> status-bar.png



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2960) Remove unused documentation images

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633640#comment-15633640
 ] 

ASF GitHub Bot commented on NIFI-2960:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1169


> Remove unused documentation images
> --
>
> Key: NIFI-2960
> URL: https://issues.apache.org/jira/browse/NIFI-2960
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation & Website
>Affects Versions: 1.0.0
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Trivial
> Fix For: 1.1.0
>
>
> There are images that are no longer used in the 1.0 documentation as they 
> reference the 0.x UI:
> anonymous-access.png
> controller-services-edit-buttons2.png
> iconFlowHistory.png
> iconInputPortSmall.png
> iconOutputPortSmall.png
> iconSettings.png
> iconSummary.png
> iconUsers.png
> iconViewDetails.png
> nifi-arch-cluster.png
> nifi-arch.png
> reporting-tasks-edit-buttons.png
> request-access.png
> status-bar.png



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1169: NIFI-2960 Remove unused/outdated doc images

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1169
  
Thanks @andrewmlim! This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1169: NIFI-2960 Remove unused/outdated doc images

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1169


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2960) Remove unused documentation images

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633635#comment-15633635
 ] 

ASF subversion and git services commented on NIFI-2960:
---

Commit b7c63921833974e3b3baad641ec55774228380c9 in nifi's branch 
refs/heads/master from [~andrewmlim]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=b7c6392 ]

NIFI-2960 Remove unused/outdated doc images. This closes #1169


> Remove unused documentation images
> --
>
> Key: NIFI-2960
> URL: https://issues.apache.org/jira/browse/NIFI-2960
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation & Website
>Affects Versions: 1.0.0
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Trivial
>
> There are images that are no longer used in the 1.0 documentation as they 
> reference the 0.x UI:
> anonymous-access.png
> controller-services-edit-buttons2.png
> iconFlowHistory.png
> iconInputPortSmall.png
> iconOutputPortSmall.png
> iconSettings.png
> iconSummary.png
> iconUsers.png
> iconViewDetails.png
> nifi-arch-cluster.png
> nifi-arch.png
> reporting-tasks-edit-buttons.png
> request-access.png
> status-bar.png



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (NIFI-2982) UI - Update label in the Policy Add Users Dialog

[Matt Gilman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-2982:
--
Status: Patch Available  (was: In Progress)

> UI - Update label in the Policy Add Users Dialog
> 
>
> Key: NIFI-2982
> URL: https://issues.apache.org/jira/browse/NIFI-2982
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>Priority: Minor
> Fix For: 1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (NIFI-2565) NiFi processor to parse logs using Grok patterns

[Matt Burgess (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-2565:
---
Assignee: (was: Andre)

> NiFi processor to parse logs using Grok patterns
> 
>
> Key: NIFI-2565
> URL: https://issues.apache.org/jira/browse/NIFI-2565
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andre
> Fix For: 1.1.0
>
>
> Following up on Ryan Ward to create a Grok capable parser
> https://mail-archives.apache.org/mod_mbox/nifi-dev/201606.mbox/%3CCADD=rnPa8nHkJbeM280=PTQ=wurtwhstm5u+7btoo9pcym2...@mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (NIFI-2565) NiFi processor to parse logs using Grok patterns

[Matt Burgess (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-2565:
---
Assignee: Andre

> NiFi processor to parse logs using Grok patterns
> 
>
> Key: NIFI-2565
> URL: https://issues.apache.org/jira/browse/NIFI-2565
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Andre
>Assignee: Andre
> Fix For: 1.1.0
>
>
> Following up on Ryan Ward to create a Grok capable parser
> https://mail-archives.apache.org/mod_mbox/nifi-dev/201606.mbox/%3CCADD=rnPa8nHkJbeM280=PTQ=wurtwhstm5u+7btoo9pcym2...@mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2716) Allow NiFi to manage embedded JMS Brokers

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633398#comment-15633398
 ] 

ASF GitHub Bot commented on NIFI-2716:
--

Github user brosander commented on the issue:

https://github.com/apache/nifi/pull/1118
  
@olegz it looks like this PR has merge issues now


> Allow NiFi to manage embedded JMS Brokers
> -
>
> Key: NIFI-2716
> URL: https://issues.apache.org/jira/browse/NIFI-2716
> Project: Apache NiFi
>  Issue Type: New Feature
>Affects Versions: 1.0.0
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
>
> Several community members expressed interest in NiFi acting as a JMS Broker 
> to avoid deploying and managing external JMS Brokers. While implementing JMS 
> Broker from scratch would be rather complex, using embedded capabilities of 
> some OS JMS Broker implementations (e.g., ActiveMQ) together with native 
> capabilities of  NiFi (i.e., Processor and/or Controller Service) could prove 
> to be a very valuable feature.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1118: NIFI-2716 initial implementation of JMS Broker processor

[brosander]

Github user brosander commented on the issue:

https://github.com/apache/nifi/pull/1118
  
@olegz it looks like this PR has merge issues now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2841) SplitAvro Processor is Broken

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633384#comment-15633384
 ] 

ASF GitHub Bot commented on NIFI-2841:
--

Github user mattyb149 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1088#discussion_r86388099
  
--- Diff: 
nifi-nar-bundles/nifi-avro-bundle/nifi-avro-processors/src/main/java/org/apache/nifi/processors/avro/SplitAvro.java
 ---
@@ -267,7 +267,8 @@ public void process(InputStream rawIn) throws 
IOException {
 }
 
 // while records are left, start a new split by 
spawning a FlowFile
-while (reader.hasNext()) {
+final AtomicReference hasNextHolder = new 
AtomicReference(reader.hasNext());
--- End diff --

If there are no records, then the call to reader.next() [will throw a 
NoSuchElementException](https://avro.apache.org/docs/1.7.7/api/java/org/apache/avro/file/DataFileStream.html#next(D)).
 You could wrap the code in a try/catch, but then it's a little heavier, so the 
AtomicReference is probably fine?


> SplitAvro Processor is Broken
> -
>
> Key: NIFI-2841
> URL: https://issues.apache.org/jira/browse/NIFI-2841
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: David Hicks
>Assignee: Bryan Bende
>Priority: Critical
> Fix For: 1.1.0
>
> Attachments: NIFI-2841.patch
>
>
> This is largely the fault of the Avro DataFileStream reader, but it's making 
> the processor unusable.  The problem appears to occur when you make the 
> following series of calls (which happens because of the splitSize comparison):
> reader.next() -> returns last element
> reader.hasNext() -> returns false
> reader.hasNext() -> returns true
> reader.next() -> EOFException
> org.apache.nifi.processor.exception.ProcessException: IOException thrown from 
> SplitAvro[id=22e03ca4-0151-4474-92fc-040e1fe12ab9]: java.io.EOFException
>   at 
> org.apache.nifi.controller.repository.StandardProcessSession.write(StandardProcessSession.java:2013)
>  ~[na:na]
>   at 
> org.apache.nifi.processors.avro.SplitAvro$RecordSplitter$1.process(SplitAvro.java:250)
>  ~[nifi-avro-processors-0.7.0.jar:0.7.0]
>   at 
> org.apache.nifi.controller.repository.StandardProcessSession.read(StandardProcessSession.java:1851)
>  ~[na:na]
>   at 
> org.apache.nifi.controller.repository.StandardProcessSession.read(StandardProcessSession.java:1822)
>  ~[na:na]
>   at 
> org.apache.nifi.processors.avro.SplitAvro$RecordSplitter.split(SplitAvro.java:236)
>  ~[nifi-avro-processors-0.7.0.jar:0.7.0]
>   at 
> org.apache.nifi.processors.avro.SplitAvro.onTrigger(SplitAvro.java:202) 
> ~[nifi-avro-processors-0.7.0.jar:0.7.0]
>   at 
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
>  [nifi-api-0.7.0.jar:0.7.0]
>   at 
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1054)
>  [nifi-framework-core-0.7.0.jar:0.7.0]
>   at 
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:136)
>  [nifi-framework-core-0.7.0.jar:0.7.0]
>   at 
> org.apache.nifi.controller.tasks.ContinuallyRunProcessorTask.call(ContinuallyRunProcessorTask.java:47)
>  [nifi-framework-core-0.7.0.jar:0.7.0]
>   at 
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:127)
>  [nifi-framework-core-0.7.0.jar:0.7.0]
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
> [na:1.8.0_101]
>   at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) 
> [na:1.8.0_101]
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
>  [na:1.8.0_101]
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
>  [na:1.8.0_101]
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  [na:1.8.0_101]
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  [na:1.8.0_101]
>   at java.lang.Thread.run(Thread.java:745) [na:1.8.0_101]
> Caused by: java.io.EOFException: null
>   at 
> org.apache.avro.io.BinaryDecoder.ensureBounds(BinaryDecoder.java:473) 
> ~[avro-1.7.7.jar:1.7.7]
>   at org.apache.avro.io.BinaryDecoder.readInt(BinaryDecoder.java:128) 
> ~[avro-1.7.7.jar:1.7.7]
>   at org.apache.avro.io.BinaryDecoder.readString(BinaryDecoder.java:259) 
> ~[avro-1.7.7.jar:1.7.7]
>   at 
> org.apache.avro.io.ResolvingDecoder.readString(ResolvingDecoder.java:201) 
> ~[avro-1.7.7.jar:1.7.7]
>   at 
> 

[GitHub] nifi pull request #1088: NIFI-2841 Refactoring logic in SplitAvro RecordSpli...

[mattyb149]

Github user mattyb149 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1088#discussion_r86388099
  
--- Diff: 
nifi-nar-bundles/nifi-avro-bundle/nifi-avro-processors/src/main/java/org/apache/nifi/processors/avro/SplitAvro.java
 ---
@@ -267,7 +267,8 @@ public void process(InputStream rawIn) throws 
IOException {
 }
 
 // while records are left, start a new split by 
spawning a FlowFile
-while (reader.hasNext()) {
+final AtomicReference hasNextHolder = new 
AtomicReference(reader.hasNext());
--- End diff --

If there are no records, then the call to reader.next() [will throw a 
NoSuchElementException](https://avro.apache.org/docs/1.7.7/api/java/org/apache/avro/file/DataFileStream.html#next(D)).
 You could wrap the code in a try/catch, but then it's a little heavier, so the 
AtomicReference is probably fine?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

[Matt Burgess (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-2928:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (NIFI-2915) Replace incorrect images in User Guide

[Matt Gilman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman resolved NIFI-2915.
---
   Resolution: Fixed
Fix Version/s: 1.1.0

> Replace incorrect images in User Guide
> --
>
> Key: NIFI-2915
> URL: https://issues.apache.org/jira/browse/NIFI-2915
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Documentation & Website
>Affects Versions: 1.0.0
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Trivial
> Fix For: 1.1.0
>
>
> In the User Guide "Adding Controller Services for Dataflows" section, in Step 
> #5 the View Details icon image referenced is incorrect (iconViewDetails.png). 
>  It should reference iconDetails.png.
> Also, in the same doc in "Anatomy of a Remote Process Group" the 
> iconSecure.png still references the old UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1566#comment-1566
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1160


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2960) Remove unused documentation images

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1568#comment-1568
 ] 

ASF GitHub Bot commented on NIFI-2960:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1169
  
Reviewing...


> Remove unused documentation images
> --
>
> Key: NIFI-2960
> URL: https://issues.apache.org/jira/browse/NIFI-2960
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation & Website
>Affects Versions: 1.0.0
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Trivial
>
> There are images that are no longer used in the 1.0 documentation as they 
> reference the 0.x UI:
> anonymous-access.png
> controller-services-edit-buttons2.png
> iconFlowHistory.png
> iconInputPortSmall.png
> iconOutputPortSmall.png
> iconSettings.png
> iconSummary.png
> iconUsers.png
> iconViewDetails.png
> nifi-arch-cluster.png
> nifi-arch.png
> reporting-tasks-edit-buttons.png
> request-access.png
> status-bar.png



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1169: NIFI-2960 Remove unused/outdated doc images

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1169
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1564#comment-1564
 ] 

ASF subversion and git services commented on NIFI-2928:
---

Commit ed035f85e38f7c9efe6ac84c8f13c9a455f7014c in nifi's branch 
refs/heads/master from [~ozhurakousky]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ed035f8 ]

NIFI-2928 added support to validate accessibility of the file system

NIFI-2928 polishing

This closes #1160


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1160: NIFI-2928 added support to validate accessibility o...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1160


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2915) Replace incorrect images in User Guide

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633325#comment-15633325
 ] 

ASF GitHub Bot commented on NIFI-2915:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1168
  
Thanks @andrewmlim. This has been merged to master.


> Replace incorrect images in User Guide
> --
>
> Key: NIFI-2915
> URL: https://issues.apache.org/jira/browse/NIFI-2915
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Documentation & Website
>Affects Versions: 1.0.0
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Trivial
>
> In the User Guide "Adding Controller Services for Dataflows" section, in Step 
> #5 the View Details icon image referenced is incorrect (iconViewDetails.png). 
>  It should reference iconDetails.png.
> Also, in the same doc in "Anatomy of a Remote Process Group" the 
> iconSecure.png still references the old UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1563#comment-1563
 ] 

ASF subversion and git services commented on NIFI-2928:
---

Commit ed035f85e38f7c9efe6ac84c8f13c9a455f7014c in nifi's branch 
refs/heads/master from [~ozhurakousky]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ed035f8 ]

NIFI-2928 added support to validate accessibility of the file system

NIFI-2928 polishing

This closes #1160


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2915) Replace incorrect images in User Guide

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633326#comment-15633326
 ] 

ASF GitHub Bot commented on NIFI-2915:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1168


> Replace incorrect images in User Guide
> --
>
> Key: NIFI-2915
> URL: https://issues.apache.org/jira/browse/NIFI-2915
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Documentation & Website
>Affects Versions: 1.0.0
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Trivial
>
> In the User Guide "Adding Controller Services for Dataflows" section, in Step 
> #5 the View Details icon image referenced is incorrect (iconViewDetails.png). 
>  It should reference iconDetails.png.
> Also, in the same doc in "Anatomy of a Remote Process Group" the 
> iconSecure.png still references the old UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2915) Replace incorrect images in User Guide

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633323#comment-15633323
 ] 

ASF subversion and git services commented on NIFI-2915:
---

Commit 60da897e10663275d5fb9373755570a6d403b907 in nifi's branch 
refs/heads/master from [~andrewmlim]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=60da897 ]

NIFI-2915 Updated reference to correct View Details image; Replaced RPG 
secure/not secure images; Changed template Note style to match rest of  
documentation. This closes #1168


> Replace incorrect images in User Guide
> --
>
> Key: NIFI-2915
> URL: https://issues.apache.org/jira/browse/NIFI-2915
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Documentation & Website
>Affects Versions: 1.0.0
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Trivial
>
> In the User Guide "Adding Controller Services for Dataflows" section, in Step 
> #5 the View Details icon image referenced is incorrect (iconViewDetails.png). 
>  It should reference iconDetails.png.
> Also, in the same doc in "Anatomy of a Remote Process Group" the 
> iconSecure.png still references the old UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1168: NIFI-2915 Updated reference to correct View Details image;...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1168
  
Thanks @andrewmlim. This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2615) Add support for GetTCP processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633298#comment-15633298
 ] 

ASF GitHub Bot commented on NIFI-2615:
--

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1177#discussion_r86382011
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetTCP.java
 ---
@@ -0,0 +1,668 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import java.io.IOException;
+import java.net.InetSocketAddress;
+import java.net.Socket;
+import java.net.SocketAddress;
+import java.net.SocketTimeoutException;
+import java.net.StandardSocketOptions;
+import java.nio.ByteBuffer;
+import java.nio.CharBuffer;
+import java.nio.channels.AlreadyConnectedException;
+import java.nio.channels.ConnectionPendingException;
+import java.nio.channels.SocketChannel;
+import java.nio.channels.UnresolvedAddressException;
+import java.nio.channels.UnsupportedAddressTypeException;
+import java.nio.charset.Charset;
+import java.nio.charset.CharsetDecoder;
+import java.nio.charset.StandardCharsets;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+@SupportsBatching
+@SideEffectFree
+@Tags({"get", "fetch", "poll", "tcp", "ingest", "source", "input"})
+@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
+@CapabilityDescription("Connects over TCP to the provided server. When 
receiving data this will writes either the" +
+" full receive buffer or messages based on demarcator to the 
content of a FlowFile. ")
+public class GetTCP extends AbstractProcessor {
--- End diff --

How is this processor different from the existing ListenTCP?


> Add support for GetTCP processor
> 
>
> Key: NIFI-2615
> URL: https://issues.apache.org/jira/browse/NIFI-2615
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.7.0, 0.6.1
>Reporter: Andrew Psaltis
>Assignee: Andrew Psaltis
>
> This processor will allow NiFi to connect to a host via TCP, thus acting as 
> the client and consume data. This should provide the following 

[jira] [Commented] (NIFI-2615) Add support for GetTCP processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633301#comment-15633301
 ] 

ASF GitHub Bot commented on NIFI-2615:
--

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1177#discussion_r86378211
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetTCP.java
 ---
@@ -0,0 +1,668 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import java.io.IOException;
+import java.net.InetSocketAddress;
+import java.net.Socket;
+import java.net.SocketAddress;
+import java.net.SocketTimeoutException;
+import java.net.StandardSocketOptions;
+import java.nio.ByteBuffer;
+import java.nio.CharBuffer;
+import java.nio.channels.AlreadyConnectedException;
+import java.nio.channels.ConnectionPendingException;
+import java.nio.channels.SocketChannel;
+import java.nio.channels.UnresolvedAddressException;
+import java.nio.channels.UnsupportedAddressTypeException;
+import java.nio.charset.Charset;
+import java.nio.charset.CharsetDecoder;
+import java.nio.charset.StandardCharsets;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+@SupportsBatching
+@SideEffectFree
+@Tags({"get", "fetch", "poll", "tcp", "ingest", "source", "input"})
+@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
+@CapabilityDescription("Connects over TCP to the provided server. When 
receiving data this will writes either the" +
+" full receive buffer or messages based on demarcator to the 
content of a FlowFile. ")
+public class GetTCP extends AbstractProcessor {
+
+private static final Validator ENDPOINT_VALIDATOR = new Validator() {
+@Override
+public ValidationResult validate(final String subject, final 
String value, final ValidationContext context) {
+if (null == value || value.isEmpty()) {
+return new 
ValidationResult.Builder().subject(subject).input(value).valid(false).explanation(subject
 + " cannot be empty").build();
+}
+//The format should be :{,:}
+//first split on ,
+final String[] hostPortPairs = value.split(",");
+boolean 

[GitHub] nifi pull request #1177: NIFI-2615 Adding a GetTCP processor

[olegz]

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1177#discussion_r86382011
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetTCP.java
 ---
@@ -0,0 +1,668 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import java.io.IOException;
+import java.net.InetSocketAddress;
+import java.net.Socket;
+import java.net.SocketAddress;
+import java.net.SocketTimeoutException;
+import java.net.StandardSocketOptions;
+import java.nio.ByteBuffer;
+import java.nio.CharBuffer;
+import java.nio.channels.AlreadyConnectedException;
+import java.nio.channels.ConnectionPendingException;
+import java.nio.channels.SocketChannel;
+import java.nio.channels.UnresolvedAddressException;
+import java.nio.channels.UnsupportedAddressTypeException;
+import java.nio.charset.Charset;
+import java.nio.charset.CharsetDecoder;
+import java.nio.charset.StandardCharsets;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+@SupportsBatching
+@SideEffectFree
+@Tags({"get", "fetch", "poll", "tcp", "ingest", "source", "input"})
+@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
+@CapabilityDescription("Connects over TCP to the provided server. When 
receiving data this will writes either the" +
+" full receive buffer or messages based on demarcator to the 
content of a FlowFile. ")
+public class GetTCP extends AbstractProcessor {
--- End diff --

How is this processor different from the existing ListenTCP?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1177: NIFI-2615 Adding a GetTCP processor

[olegz]

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1177#discussion_r86378211
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetTCP.java
 ---
@@ -0,0 +1,668 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import java.io.IOException;
+import java.net.InetSocketAddress;
+import java.net.Socket;
+import java.net.SocketAddress;
+import java.net.SocketTimeoutException;
+import java.net.StandardSocketOptions;
+import java.nio.ByteBuffer;
+import java.nio.CharBuffer;
+import java.nio.channels.AlreadyConnectedException;
+import java.nio.channels.ConnectionPendingException;
+import java.nio.channels.SocketChannel;
+import java.nio.channels.UnresolvedAddressException;
+import java.nio.channels.UnsupportedAddressTypeException;
+import java.nio.charset.Charset;
+import java.nio.charset.CharsetDecoder;
+import java.nio.charset.StandardCharsets;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+@SupportsBatching
+@SideEffectFree
+@Tags({"get", "fetch", "poll", "tcp", "ingest", "source", "input"})
+@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
+@CapabilityDescription("Connects over TCP to the provided server. When 
receiving data this will writes either the" +
+" full receive buffer or messages based on demarcator to the 
content of a FlowFile. ")
+public class GetTCP extends AbstractProcessor {
+
+private static final Validator ENDPOINT_VALIDATOR = new Validator() {
+@Override
+public ValidationResult validate(final String subject, final 
String value, final ValidationContext context) {
+if (null == value || value.isEmpty()) {
+return new 
ValidationResult.Builder().subject(subject).input(value).valid(false).explanation(subject
 + " cannot be empty").build();
+}
+//The format should be :{,:}
+//first split on ,
+final String[] hostPortPairs = value.split(",");
+boolean validHostPortPairs = true;
+String reason = "";
+String offendingSubject = subject;
+
+if(0 == hostPortPairs.length){
+return new 

[GitHub] nifi pull request #1177: NIFI-2615 Adding a GetTCP processor

[olegz]

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1177#discussion_r86380087
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetTCP.java
 ---
@@ -0,0 +1,668 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import java.io.IOException;
+import java.net.InetSocketAddress;
+import java.net.Socket;
+import java.net.SocketAddress;
+import java.net.SocketTimeoutException;
+import java.net.StandardSocketOptions;
+import java.nio.ByteBuffer;
+import java.nio.CharBuffer;
+import java.nio.channels.AlreadyConnectedException;
+import java.nio.channels.ConnectionPendingException;
+import java.nio.channels.SocketChannel;
+import java.nio.channels.UnresolvedAddressException;
+import java.nio.channels.UnsupportedAddressTypeException;
+import java.nio.charset.Charset;
+import java.nio.charset.CharsetDecoder;
+import java.nio.charset.StandardCharsets;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+@SupportsBatching
+@SideEffectFree
+@Tags({"get", "fetch", "poll", "tcp", "ingest", "source", "input"})
+@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
+@CapabilityDescription("Connects over TCP to the provided server. When 
receiving data this will writes either the" +
+" full receive buffer or messages based on demarcator to the 
content of a FlowFile. ")
+public class GetTCP extends AbstractProcessor {
+
+private static final Validator ENDPOINT_VALIDATOR = new Validator() {
+@Override
+public ValidationResult validate(final String subject, final 
String value, final ValidationContext context) {
+if (null == value || value.isEmpty()) {
+return new 
ValidationResult.Builder().subject(subject).input(value).valid(false).explanation(subject
 + " cannot be empty").build();
+}
+//The format should be :{,:}
+//first split on ,
+final String[] hostPortPairs = value.split(",");
+boolean validHostPortPairs = true;
+String reason = "";
+String offendingSubject = subject;
+
+if(0 == hostPortPairs.length){
+return new 

[jira] [Commented] (NIFI-2615) Add support for GetTCP processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633299#comment-15633299
 ] 

ASF GitHub Bot commented on NIFI-2615:
--

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1177#discussion_r86381576
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetTCP.java
 ---
@@ -0,0 +1,668 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import java.io.IOException;
+import java.net.InetSocketAddress;
+import java.net.Socket;
+import java.net.SocketAddress;
+import java.net.SocketTimeoutException;
+import java.net.StandardSocketOptions;
+import java.nio.ByteBuffer;
+import java.nio.CharBuffer;
+import java.nio.channels.AlreadyConnectedException;
+import java.nio.channels.ConnectionPendingException;
+import java.nio.channels.SocketChannel;
+import java.nio.channels.UnresolvedAddressException;
+import java.nio.channels.UnsupportedAddressTypeException;
+import java.nio.charset.Charset;
+import java.nio.charset.CharsetDecoder;
+import java.nio.charset.StandardCharsets;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+@SupportsBatching
+@SideEffectFree
+@Tags({"get", "fetch", "poll", "tcp", "ingest", "source", "input"})
+@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
+@CapabilityDescription("Connects over TCP to the provided server. When 
receiving data this will writes either the" +
+" full receive buffer or messages based on demarcator to the 
content of a FlowFile. ")
+public class GetTCP extends AbstractProcessor {
+
+private static final Validator ENDPOINT_VALIDATOR = new Validator() {
+@Override
+public ValidationResult validate(final String subject, final 
String value, final ValidationContext context) {
+if (null == value || value.isEmpty()) {
+return new 
ValidationResult.Builder().subject(subject).input(value).valid(false).explanation(subject
 + " cannot be empty").build();
+}
+//The format should be :{,:}
+//first split on ,
+final String[] hostPortPairs = value.split(",");
+boolean 

[jira] [Commented] (NIFI-2615) Add support for GetTCP processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633300#comment-15633300
 ] 

ASF GitHub Bot commented on NIFI-2615:
--

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1177#discussion_r86380087
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetTCP.java
 ---
@@ -0,0 +1,668 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import java.io.IOException;
+import java.net.InetSocketAddress;
+import java.net.Socket;
+import java.net.SocketAddress;
+import java.net.SocketTimeoutException;
+import java.net.StandardSocketOptions;
+import java.nio.ByteBuffer;
+import java.nio.CharBuffer;
+import java.nio.channels.AlreadyConnectedException;
+import java.nio.channels.ConnectionPendingException;
+import java.nio.channels.SocketChannel;
+import java.nio.channels.UnresolvedAddressException;
+import java.nio.channels.UnsupportedAddressTypeException;
+import java.nio.charset.Charset;
+import java.nio.charset.CharsetDecoder;
+import java.nio.charset.StandardCharsets;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+@SupportsBatching
+@SideEffectFree
+@Tags({"get", "fetch", "poll", "tcp", "ingest", "source", "input"})
+@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
+@CapabilityDescription("Connects over TCP to the provided server. When 
receiving data this will writes either the" +
+" full receive buffer or messages based on demarcator to the 
content of a FlowFile. ")
+public class GetTCP extends AbstractProcessor {
+
+private static final Validator ENDPOINT_VALIDATOR = new Validator() {
+@Override
+public ValidationResult validate(final String subject, final 
String value, final ValidationContext context) {
+if (null == value || value.isEmpty()) {
+return new 
ValidationResult.Builder().subject(subject).input(value).valid(false).explanation(subject
 + " cannot be empty").build();
+}
+//The format should be :{,:}
+//first split on ,
+final String[] hostPortPairs = value.split(",");
+boolean 

[GitHub] nifi pull request #1177: NIFI-2615 Adding a GetTCP processor

[olegz]

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1177#discussion_r86381576
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetTCP.java
 ---
@@ -0,0 +1,668 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.processors.standard;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import java.io.IOException;
+import java.net.InetSocketAddress;
+import java.net.Socket;
+import java.net.SocketAddress;
+import java.net.SocketTimeoutException;
+import java.net.StandardSocketOptions;
+import java.nio.ByteBuffer;
+import java.nio.CharBuffer;
+import java.nio.channels.AlreadyConnectedException;
+import java.nio.channels.ConnectionPendingException;
+import java.nio.channels.SocketChannel;
+import java.nio.channels.UnresolvedAddressException;
+import java.nio.channels.UnsupportedAddressTypeException;
+import java.nio.charset.Charset;
+import java.nio.charset.CharsetDecoder;
+import java.nio.charset.StandardCharsets;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+@SupportsBatching
+@SideEffectFree
+@Tags({"get", "fetch", "poll", "tcp", "ingest", "source", "input"})
+@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
+@CapabilityDescription("Connects over TCP to the provided server. When 
receiving data this will writes either the" +
+" full receive buffer or messages based on demarcator to the 
content of a FlowFile. ")
+public class GetTCP extends AbstractProcessor {
+
+private static final Validator ENDPOINT_VALIDATOR = new Validator() {
+@Override
+public ValidationResult validate(final String subject, final 
String value, final ValidationContext context) {
+if (null == value || value.isEmpty()) {
+return new 
ValidationResult.Builder().subject(subject).input(value).valid(false).explanation(subject
 + " cannot be empty").build();
+}
+//The format should be :{,:}
+//first split on ,
+final String[] hostPortPairs = value.split(",");
+boolean validHostPortPairs = true;
+String reason = "";
+String offendingSubject = subject;
+
+if(0 == hostPortPairs.length){
+return new 

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633294#comment-15633294
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

Github user mattyb149 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1160#discussion_r86382090
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFetchFile.java
 ---
@@ -48,6 +48,19 @@ public void prepDestDirectory() throws IOException {
 }
 
 @Test
+public void notFound() throws IOException {
+final File sourceFile = new File("notFound");
--- End diff --

Rgr, +1 LGTM merging to master


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1160: NIFI-2928 added support to validate accessibility o...

[mattyb149]

Github user mattyb149 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1160#discussion_r86382090
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFetchFile.java
 ---
@@ -48,6 +48,19 @@ public void prepDestDirectory() throws IOException {
 }
 
 @Test
+public void notFound() throws IOException {
+final File sourceFile = new File("notFound");
--- End diff --

Rgr, +1 LGTM merging to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2915) Replace incorrect images in User Guide

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633280#comment-15633280
 ] 

ASF GitHub Bot commented on NIFI-2915:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1168
  
Reviewing...


> Replace incorrect images in User Guide
> --
>
> Key: NIFI-2915
> URL: https://issues.apache.org/jira/browse/NIFI-2915
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Documentation & Website
>Affects Versions: 1.0.0
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Trivial
>
> In the User Guide "Adding Controller Services for Dataflows" section, in Step 
> #5 the View Details icon image referenced is incorrect (iconViewDetails.png). 
>  It should reference iconDetails.png.
> Also, in the same doc in "Anatomy of a Remote Process Group" the 
> iconSecure.png still references the old UI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2928) FetchFile routes to not.found when it cannot determine whether or not the file exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633278#comment-15633278
 ] 

ASF GitHub Bot commented on NIFI-2928:
--

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1160#discussion_r86380802
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFetchFile.java
 ---
@@ -48,6 +48,19 @@ public void prepDestDirectory() throws IOException {
 }
 
 @Test
+public void notFound() throws IOException {
+final File sourceFile = new File("notFound");
--- End diff --

That is correct. We can only test it in some specially set integration 
environment where you may have a remote share that is known to the OS but 
temporarily unreachable. That is where the new code becomes relevant.


> FetchFile routes to not.found when it cannot determine whether or not the 
> file exists
> -
>
> Key: NIFI-2928
> URL: https://issues.apache.org/jira/browse/NIFI-2928
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 0.7.1
>Reporter: Christopher McDermott
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> I have a flow that reads files from an NFS volume.  To simulate the NFS 
> server being offline/unreachable I am using IP tables to block all TCP 
> traffic between the NFS server and the host running NiFi.
> Trying to read files using FetchFile, I am seeing
> 2016-10-20 20:34:31,789 ERROR [Timer-Driven Process Thread-4] 
> o.a.nifi.processors.standard.FetchFile 
> FetchFile[id=9e642524-0e05-4d58-aabc-d6b49d687917] Could not fetch file 
> /share/st5103/REDACTED from file system for 
> StandardFlowFileRecord[uuid=1f88f322-57a2-4ac5-87df-d53fdd63d52c,claim=StandardContentClaim
>  [resourceClaim=StandardResourceClaim[id=1476995181657-18524, 
> container=default, section=92], offset=569544, 
> length=745],offset=0,name=1248995905448067,size=745] because the file does 
> not exist; routing to not.found
> The file is actually there, but of course it is inaccessible because the 
> network traffic is blocked.
> I see the code is using {{File.exists()}}.
> This [bug|https://bugs.openjdk.java.net/browse/JDK-6191254] report suggest 
> that it should instead use
> {{[File.toPath().checkAccess()|http://download.java.net/jdk7/archive/b123/docs/api/java/nio/file/Path.html#checkAccess(java.nio.file.AccessMode...)]}}
> {{[java.nio.Files.notExists()|http://docs.oracle.com/javase/7docs/api/java/nio/file/Files.html#notExists-java.nio.file.Path-java.nio.file.LinkOption...-]}}
>  uses {{checkAccess()}} and might be a drop-in replacement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1160: NIFI-2928 added support to validate accessibility o...

[olegz]

Github user olegz commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1160#discussion_r86380802
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFetchFile.java
 ---
@@ -48,6 +48,19 @@ public void prepDestDirectory() throws IOException {
 }
 
 @Test
+public void notFound() throws IOException {
+final File sourceFile = new File("notFound");
--- End diff --

That is correct. We can only test it in some specially set integration 
environment where you may have a remote share that is known to the OS but 
temporarily unreachable. That is where the new code becomes relevant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1168: NIFI-2915 Updated reference to correct View Details image;...

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1168
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (NIFI-2988) Decouple S2S Raw protocol from NiFi's web http(s) ports

[Matthew Clarke (JIRA)]

Matthew Clarke created NIFI-2988:


 Summary: Decouple S2S Raw protocol from NiFi's web http(s) ports
 Key: NIFI-2988
 URL: https://issues.apache.org/jira/browse/NIFI-2988
 Project: Apache NiFi
  Issue Type: New Feature
  Components: Core Framework
Affects Versions: 1.0.0
Reporter: Matthew Clarke
Priority: Minor


The mutual authentication and encryption added when S2S is set to secure add 
overhead that may no be necessary in every user environment.  I may want to 
have my NiFi web UI secured with controlled multi-tenancy access, but still 
have my S2S run non-secure.

When using the RAW protocol, I should be able to define different http and 
https connection end-points from the NiFi web UI endpoints and specify which 
hostname/port to run those on.

This will allow me to have my Web UI secured on a public or internal network 
and have my S2S configured independent of that as secure or non-secure on my 
internal network.  That way a user can eliminate the Security overhead when 
using s2S on a closed internal network.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #583: NIFI-2115 Detailed Version Info for About Box

[jvwing]

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/583
  
Thanks for your help, @mcgilman.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2115) Enhanced About Box Version Information

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633182#comment-15633182
 ] 

ASF GitHub Bot commented on NIFI-2115:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/583
  
Thanks for your help, @mcgilman.


> Enhanced About Box Version Information
> --
>
> Key: NIFI-2115
> URL: https://issues.apache.org/jira/browse/NIFI-2115
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI, Tools and Build
>Affects Versions: 1.0.0
>Reporter: James Wing
>Assignee: James Wing
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: screenshot-1-of-4-about-expands.png, 
> screenshot-2-of-4-git-build.png, screenshot-3-of-4-release-build.png, 
> screenshot-4-of-4-source-build.png
>
>
> The UI's About dialog and underlying API provide the version of NiFi, like 
> "0.7.0-SNAPSHOT".  For many bug reports and troubleshooting requests, this is 
> not very precise, especially around rapidly changing code or 
> platform-dependent behavior.  It would help if NiFi captured and displayed 
> additional information:  
> * NiFi build commit hash
> * NiFi build branch
> * NiFi build date/time
> * Java Version
> * Java Vendor (Oracle, OpenJDK)
> * OS
> Then a simple copy/paste from the about box would provide very specific 
> information about a particular NiFi installation and which code it was 
> derived from.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (NIFI-2850) Provide ability for a FlowFile to be migrated from one Process Session to another

[Oleg Zhurakousky (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Zhurakousky updated NIFI-2850:
---
Assignee: Mark Payne  (was: Oleg Zhurakousky)

> Provide ability for a FlowFile to be migrated from one Process Session to 
> another
> -
>
> Key: NIFI-2850
> URL: https://issues.apache.org/jira/browse/NIFI-2850
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Mark Payne
>Assignee: Mark Payne
> Fix For: 1.1.0
>
>
> Currently, the MergeContent processor creates a separate ProcessSession for 
> each FlowFile that it pulls. This is done so that we can ensure that we can 
> commit all Process Sessions when a bin is full. Unfortunately, this means 
> that MergeContent is required to call ProcessSession.get() many times, which 
> adds a lot of contention on the FlowFile Queue. If we allow FlowFiles to be 
> migrated from 1 session to another, we can have a session per bin, and then 
> use ProcessSession.get(100) to greatly reduce lock contention. This will 
> likely have benefits in other processors as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #1115: NIFI-2850: Added a migrate() method to ProcessSession and ...

[olegz]

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1115
  
@markap14 all is good. +1 here but think someone else should give it a look 
as well given its complexity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2850) Provide ability for a FlowFile to be migrated from one Process Session to another

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633092#comment-15633092
 ] 

ASF GitHub Bot commented on NIFI-2850:
--

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1115
  
@markap14 all is good. +1 here but think someone else should give it a look 
as well given its complexity.


> Provide ability for a FlowFile to be migrated from one Process Session to 
> another
> -
>
> Key: NIFI-2850
> URL: https://issues.apache.org/jira/browse/NIFI-2850
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Mark Payne
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> Currently, the MergeContent processor creates a separate ProcessSession for 
> each FlowFile that it pulls. This is done so that we can ensure that we can 
> commit all Process Sessions when a bin is full. Unfortunately, this means 
> that MergeContent is required to call ProcessSession.get() many times, which 
> adds a lot of contention on the FlowFile Queue. If we allow FlowFiles to be 
> migrated from 1 session to another, we can have a session per bin, and then 
> use ProcessSession.get(100) to greatly reduce lock contention. This will 
> likely have benefits in other processors as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (NIFI-2115) Enhanced About Box Version Information

[Matt Gilman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman resolved NIFI-2115.
---
   Resolution: Fixed
Fix Version/s: 1.1.0

> Enhanced About Box Version Information
> --
>
> Key: NIFI-2115
> URL: https://issues.apache.org/jira/browse/NIFI-2115
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI, Tools and Build
>Affects Versions: 1.0.0
>Reporter: James Wing
>Assignee: James Wing
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: screenshot-1-of-4-about-expands.png, 
> screenshot-2-of-4-git-build.png, screenshot-3-of-4-release-build.png, 
> screenshot-4-of-4-source-build.png
>
>
> The UI's About dialog and underlying API provide the version of NiFi, like 
> "0.7.0-SNAPSHOT".  For many bug reports and troubleshooting requests, this is 
> not very precise, especially around rapidly changing code or 
> platform-dependent behavior.  It would help if NiFi captured and displayed 
> additional information:  
> * NiFi build commit hash
> * NiFi build branch
> * NiFi build date/time
> * Java Version
> * Java Vendor (Oracle, OpenJDK)
> * OS
> Then a simple copy/paste from the about box would provide very specific 
> information about a particular NiFi installation and which code it was 
> derived from.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (NIFI-2987) RPG does not do load-balancing well when getting FlowFiles from output ports

[Matthew Clarke (JIRA)]

Matthew Clarke created NIFI-2987:


 Summary: RPG does not do load-balancing well when getting 
FlowFiles from output ports
 Key: NIFI-2987
 URL: https://issues.apache.org/jira/browse/NIFI-2987
 Project: Apache NiFi
  Issue Type: New Feature
  Components: Core Framework
Affects Versions: 1.0.0
Reporter: Matthew Clarke


When a RPG connects to a destination system's output port, it retrieves every 
FlowFile queued at the time of the connection.  If the source system with the 
RPG is a NiFi cluster, only one node in the cluster receives all the FlowFiles 
from that output port.  If there is a steady stream of FlowFiles to the output 
port, there is still no true balanced delivery of data.

We need to be able to limit the number of FlowFiles per connection when the 
source of the FlowFiles is an output port.

When the destination system with the output port is a cluster and the source 
system is a cluster with a RPG, the first node to connect will pull all data 
from the node with the highest queue.  Next node will pull from next highest 
queued destination node and so on. There is also no guarantee that avery node 
in the source cluster will get any data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2115) Enhanced About Box Version Information

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633067#comment-15633067
 ] 

ASF GitHub Bot commented on NIFI-2115:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/583
  
Thanks @jvwing. Looks good! This has been merged to master.


> Enhanced About Box Version Information
> --
>
> Key: NIFI-2115
> URL: https://issues.apache.org/jira/browse/NIFI-2115
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI, Tools and Build
>Affects Versions: 1.0.0
>Reporter: James Wing
>Assignee: James Wing
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: screenshot-1-of-4-about-expands.png, 
> screenshot-2-of-4-git-build.png, screenshot-3-of-4-release-build.png, 
> screenshot-4-of-4-source-build.png
>
>
> The UI's About dialog and underlying API provide the version of NiFi, like 
> "0.7.0-SNAPSHOT".  For many bug reports and troubleshooting requests, this is 
> not very precise, especially around rapidly changing code or 
> platform-dependent behavior.  It would help if NiFi captured and displayed 
> additional information:  
> * NiFi build commit hash
> * NiFi build branch
> * NiFi build date/time
> * Java Version
> * Java Vendor (Oracle, OpenJDK)
> * OS
> Then a simple copy/paste from the about box would provide very specific 
> information about a particular NiFi installation and which code it was 
> derived from.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi issue #583: NIFI-2115 Detailed Version Info for About Box

[mcgilman]

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/583
  
Thanks @jvwing. Looks good! This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2115) Enhanced About Box Version Information

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633062#comment-15633062
 ] 

ASF subversion and git services commented on NIFI-2115:
---

Commit a486fefb1e938532636e9235eaf03ee70dc972aa in nifi's branch 
refs/heads/master from [~jameswing]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=a486fef ]

NIFI-2115 Detailed Version Info in About Box

* Java version and vendor
* OS name and version
* Release Tag
* Build revision (commit SHA), branch, and timestamp
* Handles formal releases, ad-hoc builds, and non-release source builds
* Standalone UI presence in About dialog, Summary -> System Diagnostics
* Cluster UI as Versions tab in Cluster dialog
* Reduce About Dialog Content
* Fix Missing Property Display Bugs
* Marking the build time as type string.
* This closes #583


> Enhanced About Box Version Information
> --
>
> Key: NIFI-2115
> URL: https://issues.apache.org/jira/browse/NIFI-2115
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI, Tools and Build
>Affects Versions: 1.0.0
>Reporter: James Wing
>Assignee: James Wing
>Priority: Minor
> Attachments: screenshot-1-of-4-about-expands.png, 
> screenshot-2-of-4-git-build.png, screenshot-3-of-4-release-build.png, 
> screenshot-4-of-4-source-build.png
>
>
> The UI's About dialog and underlying API provide the version of NiFi, like 
> "0.7.0-SNAPSHOT".  For many bug reports and troubleshooting requests, this is 
> not very precise, especially around rapidly changing code or 
> platform-dependent behavior.  It would help if NiFi captured and displayed 
> additional information:  
> * NiFi build commit hash
> * NiFi build branch
> * NiFi build date/time
> * Java Version
> * Java Vendor (Oracle, OpenJDK)
> * OS
> Then a simple copy/paste from the about box would provide very specific 
> information about a particular NiFi installation and which code it was 
> derived from.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2115) Enhanced About Box Version Information

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15633065#comment-15633065
 ] 

ASF GitHub Bot commented on NIFI-2115:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/583


> Enhanced About Box Version Information
> --
>
> Key: NIFI-2115
> URL: https://issues.apache.org/jira/browse/NIFI-2115
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI, Tools and Build
>Affects Versions: 1.0.0
>Reporter: James Wing
>Assignee: James Wing
>Priority: Minor
> Attachments: screenshot-1-of-4-about-expands.png, 
> screenshot-2-of-4-git-build.png, screenshot-3-of-4-release-build.png, 
> screenshot-4-of-4-source-build.png
>
>
> The UI's About dialog and underlying API provide the version of NiFi, like 
> "0.7.0-SNAPSHOT".  For many bug reports and troubleshooting requests, this is 
> not very precise, especially around rapidly changing code or 
> platform-dependent behavior.  It would help if NiFi captured and displayed 
> additional information:  
> * NiFi build commit hash
> * NiFi build branch
> * NiFi build date/time
> * Java Version
> * Java Vendor (Oracle, OpenJDK)
> * OS
> Then a simple copy/paste from the about box would provide very specific 
> information about a particular NiFi installation and which code it was 
> derived from.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #583: NIFI-2115 Detailed Version Info for About Box

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/583


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (NIFI-2986) When exporting templates users should be able to choose "export as XML" or "export as YAML"

[Matthew Clarke (JIRA)]

Matthew Clarke created NIFI-2986:


 Summary: When exporting templates users should be able to choose 
"export as XML" or "export as YAML"
 Key: NIFI-2986
 URL: https://issues.apache.org/jira/browse/NIFI-2986
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework
Affects Versions: 1.0.0
Reporter: Matthew Clarke
Priority: Minor


When exporting templates users should be able to choose "export as XML" or 
"export as YAML".  This would simplify the process of creating YAML files for 
use in MiNiFi.   Currently, the downloaded template is placed in a local 
directory on your machine where you will need to have the minifi-toolkit so you 
can convert to YAML.  Suggest removing this layer of complexity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (NIFI-969) Add option to use standard JSON or Avro-JSON to ConvertAvroToJSON

[Oleg Zhurakousky (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Zhurakousky updated NIFI-969:
--
Status: Patch Available  (was: Open)

> Add option to use standard JSON or Avro-JSON to ConvertAvroToJSON
> -
>
> Key: NIFI-969
> URL: https://issues.apache.org/jira/browse/NIFI-969
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 0.3.0
>Reporter: Ryan Blue
>Assignee: Oleg Zhurakousky
>
> ConvertAvroToJSON uses {{GenericData#toString(GenericRecord)}} to convert to 
> JSON. This produces 
> [Avro-JSON|https://avro.apache.org/docs/1.7.7/spec.html#json_encoding], which 
> probably isn't what most users want because it adds an unexpected layer for 
> Avro union types:
> bq. the union schema {{["null","string",...]}} ... would encode: the string 
> {{"a"}} as {{{"string": "a"}}} ...
> It would be good to have a conversion that doesn't add those layers as an 
> option.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-969) Add option to use standard JSON or Avro-JSON to ConvertAvroToJSON

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632984#comment-15632984
 ] 

ASF GitHub Bot commented on NIFI-969:
-

GitHub user olegz opened a pull request:

https://github.com/apache/nifi/pull/1179

NIFI-969 Added support for standard JSON

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

polish

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/olegz/nifi NIFI-969

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1179


commit 8821a46c00be7cff788a56da90bd026cd88946cb
Author: Oleg Zhurakousky 
Date:   2016-11-03T13:24:33Z

NIFI-969 Added support for standard JSON

polish




> Add option to use standard JSON or Avro-JSON to ConvertAvroToJSON
> -
>
> Key: NIFI-969
> URL: https://issues.apache.org/jira/browse/NIFI-969
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 0.3.0
>Reporter: Ryan Blue
>Assignee: Oleg Zhurakousky
>
> ConvertAvroToJSON uses {{GenericData#toString(GenericRecord)}} to convert to 
> JSON. This produces 
> [Avro-JSON|https://avro.apache.org/docs/1.7.7/spec.html#json_encoding], which 
> probably isn't what most users want because it adds an unexpected layer for 
> Avro union types:
> bq. the union schema {{["null","string",...]}} ... would encode: the string 
> {{"a"}} as {{{"string": "a"}}} ...
> It would be good to have a conversion that doesn't add those layers as an 
> option.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1179: NIFI-969 Added support for standard JSON

[olegz]

GitHub user olegz opened a pull request:

https://github.com/apache/nifi/pull/1179

NIFI-969 Added support for standard JSON

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

polish

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/olegz/nifi NIFI-969

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1179


commit 8821a46c00be7cff788a56da90bd026cd88946cb
Author: Oleg Zhurakousky 
Date:   2016-11-03T13:24:33Z

NIFI-969 Added support for standard JSON

polish




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (NIFI-2985) Update docs for Backpressure Visual indicator

[Andrew Lim (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Lim reassigned NIFI-2985:


Assignee: Andrew Lim

> Update docs for Backpressure Visual indicator
> -
>
> Key: NIFI-2985
> URL: https://issues.apache.org/jira/browse/NIFI-2985
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Documentation & Website
>Affects Versions: 1.1.0
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>
> In NIFI-766, the Backpressure visual indicator was added to connections in 
> the UI.  This new feature should be captured in the documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (NIFI-2985) Update docs for Backpressure Visual indicator

[Andrew Lim (JIRA)]

Andrew Lim created NIFI-2985:


 Summary: Update docs for Backpressure Visual indicator
 Key: NIFI-2985
 URL: https://issues.apache.org/jira/browse/NIFI-2985
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Documentation & Website
Affects Versions: 1.1.0
Reporter: Andrew Lim


In NIFI-766, the Backpressure visual indicator was added to connections in the 
UI.  This new feature should be captured in the documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2931) UI - Global Policy User Actions Hidden

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632764#comment-15632764
 ] 

ASF GitHub Bot commented on NIFI-2931:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1153


> UI - Global Policy User Actions Hidden
> --
>
> Key: NIFI-2931
> URL: https://issues.apache.org/jira/browse/NIFI-2931
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
> Fix For: 1.1.0
>
>
> The user-based actions in the global policy page are being incorrectly 
> hidden. This was introduced when we disabled modification of inherited 
> policies. The global policies appear to be being interpreted as an inherited 
> component policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (NIFI-2931) UI - Global Policy User Actions Hidden

[Bryan Bende (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Bende updated NIFI-2931:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> UI - Global Policy User Actions Hidden
> --
>
> Key: NIFI-2931
> URL: https://issues.apache.org/jira/browse/NIFI-2931
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
> Fix For: 1.1.0
>
>
> The user-based actions in the global policy page are being incorrectly 
> hidden. This was introduced when we disabled modification of inherited 
> policies. The global policies appear to be being interpreted as an inherited 
> component policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] nifi pull request #1153: NIFI-2931: Global Policy User Actions Hidden

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1153


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2931) UI - Global Policy User Actions Hidden

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632761#comment-15632761
 ] 

ASF subversion and git services commented on NIFI-2931:
---

Commit edb0ebe52b8ade4842cad6b5e3aa489288e18d75 in nifi's branch 
refs/heads/master from [~mcgilman]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=edb0ebe ]

NIFI-2931: - Using the delete button state (which correctly checks if a policy 
is inherited) to drive the presence of the remove user button.

This closes #1153.

Signed-off-by: Bryan Bende 


> UI - Global Policy User Actions Hidden
> --
>
> Key: NIFI-2931
> URL: https://issues.apache.org/jira/browse/NIFI-2931
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
> Fix For: 1.1.0
>
>
> The user-based actions in the global policy page are being incorrectly 
> hidden. This was introduced when we disabled modification of inherited 
> policies. The global policies appear to be being interpreted as an inherited 
> component policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2931) UI - Global Policy User Actions Hidden

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15632693#comment-15632693
 ] 

ASF GitHub Bot commented on NIFI-2931:
--

Github user bbende commented on the issue:

https://github.com/apache/nifi/pull/1153
  
Reviewing...


> UI - Global Policy User Actions Hidden
> --
>
> Key: NIFI-2931
> URL: https://issues.apache.org/jira/browse/NIFI-2931
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
> Fix For: 1.1.0
>
>
> The user-based actions in the global policy page are being incorrectly 
> hidden. This was introduced when we disabled modification of inherited 
> policies. The global policies appear to be being interpreted as an inherited 
> component policy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)