[jira] [Commented] (NIFI-4170) PutWebSocket processor does not support 'Penalty duration' and 'Yield duration' settings

[Koji Kawamura (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079870#comment-16079870
 ] 

Koji Kawamura commented on NIFI-4170:
-

Thanks for sharing a patch [~ywik] 

While there are few situations that PutWebSocket executes 'transferToFailure', 
I think here is the only place we need to yield the processor.
https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-processors/src/main/java/org/apache/nifi/processors/websocket/PutWebSocket.java#L238

Because yielding a processor is good for a situation that, it's most likely 
that the processor will produce the same error if it's executed again, 
regardless what input FlowFile comes, and we want to avoid doing that too 
often. Other places that calls transferToFailure would be caused by an input 
FlowFile, so I don't think we need to yield processor.

FYI, 'Penalty duration' is for delaying a FlowFile to be picked from a queue 
(because it caused some issue and can cause it again), so that other FlowFiles 
can be processed while it's penalized.

How do you think? If you agree, would you update the patch to only 'yield' when 
it catches WebSocketConfigurationException, IllegalStateException or 
IOException?

> PutWebSocket processor does not support 'Penalty duration' and 'Yield 
> duration' settings
> 
>
> Key: NIFI-4170
> URL: https://issues.apache.org/jira/browse/NIFI-4170
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: 1.3.0, 1.4.0
>Reporter: Y Wikander
>Priority: Minor
>  Labels: patch
> Fix For: 1.3.0, 1.4.0
>
> Attachments: 
> 0002-websocket-PutWebSocket-processor-support-Penalty-dur.patch
>
>
> PutWebSocket processor does not support 'Penalty duration' and 'Yield 
> duration' settings.
> I'm assuming that calling content.yield() will also cover 'Penalty duration'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4145) RouteOnAttribute doesn't document the attribute it writes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079818#comment-16079818
 ] 

ASF GitHub Bot commented on NIFI-4145:
--

GitHub user mans2singh opened a pull request:

https://github.com/apache/nifi/pull/1998

NIFI-4145 Added missing write attribute annotation

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mans2singh/nifi NIFI-4145

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1998.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1998


commit 3ecaed5f8f9a10c83d52fd36079b9e7cf9bde261
Author: mans2singh 
Date:   2017-07-10T03:22:41Z

NIFI-4145 Added writes attributes annotation




> RouteOnAttribute doesn't document the attribute it writes
> -
>
> Key: NIFI-4145
> URL: https://issues.apache.org/jira/browse/NIFI-4145
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Documentation & Website
>Reporter: Joseph Percivall
>Assignee: Mans Singh
>Priority: Trivial
>
> RouteOnAttribute writes "RouteOnAttribute.Route" for the relationship it 
> routes the flowfile to[1]. This is not listed as an annotation[2] and it 
> should be.
> [1] 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteOnAttribute.java#L263
> [2] 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteOnAttribute.java#L70



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi pull request #1998: NIFI-4145 Added missing write attribute annotation

[mans2singh]

GitHub user mans2singh opened a pull request:

https://github.com/apache/nifi/pull/1998

NIFI-4145 Added missing write attribute annotation

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mans2singh/nifi NIFI-4145

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1998.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1998


commit 3ecaed5f8f9a10c83d52fd36079b9e7cf9bde261
Author: mans2singh 
Date:   2017-07-10T03:22:41Z

NIFI-4145 Added writes attributes annotation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Assigned] (NIFI-4145) RouteOnAttribute doesn't document the attribute it writes

[Mans Singh (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mans Singh reassigned NIFI-4145:


Assignee: Mans Singh

> RouteOnAttribute doesn't document the attribute it writes
> -
>
> Key: NIFI-4145
> URL: https://issues.apache.org/jira/browse/NIFI-4145
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Documentation & Website
>Reporter: Joseph Percivall
>Assignee: Mans Singh
>Priority: Trivial
>
> RouteOnAttribute writes "RouteOnAttribute.Route" for the relationship it 
> routes the flowfile to[1]. This is not listed as an annotation[2] and it 
> should be.
> [1] 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteOnAttribute.java#L263
> [2] 
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteOnAttribute.java#L70



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-2528) Update ListenHTTP to honor SSLContextService Protocols

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079759#comment-16079759
 ] 

ASF GitHub Bot commented on NIFI-2528:
--

Github user trkurc commented on the issue:

https://github.com/apache/nifi/pull/1986
  
reviewing now


> Update ListenHTTP to honor SSLContextService Protocols
> --
>
> Key: NIFI-2528
> URL: https://issues.apache.org/jira/browse/NIFI-2528
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.8.0, 0.7.1
>Reporter: Joe Skora
>Assignee: Michael Hogue
>
> Update ListenHTTP to honor SSLContextService Protocols as [NIFI-1688] did for 
> PostHTTP.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi issue #1986: NIFI-2528: added support for SSLContextService protocols i...

[trkurc]

Github user trkurc commented on the issue:

https://github.com/apache/nifi/pull/1986
  
reviewing now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4118) Create Nifi RethinkDB Put processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079734#comment-16079734
 ] 

ASF GitHub Bot commented on NIFI-4118:
--

Github user mans2singh commented on the issue:

https://github.com/apache/nifi/pull/1942
  
Thanks @jvwing 


> Create Nifi RethinkDB Put processor
> ---
>
> Key: NIFI-4118
> URL: https://issues.apache.org/jira/browse/NIFI-4118
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.3.0
> Environment: All
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
>  Labels: document, stream,
> Fix For: 1.4.0
>
>
> Create Nifi processor for streaming documents into RethinkDB.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi issue #1942: NIFI-4118 First commit of RethinkDB put processor

[mans2singh]

Github user mans2singh commented on the issue:

https://github.com/apache/nifi/pull/1942
  
Thanks @jvwing 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (NIFI-4154) fix windows line endings in source code

[James Wing (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Wing updated NIFI-4154:
-
   Resolution: Fixed
Fix Version/s: 1.4.0
   Status: Resolved  (was: Patch Available)

> fix windows line endings in source code
> ---
>
> Key: NIFI-4154
> URL: https://issues.apache.org/jira/browse/NIFI-4154
> Project: Apache NiFi
>  Issue Type: Task
>Reporter: Tony Kurc
>Assignee: Tony Kurc
>Priority: Minor
> Fix For: 1.4.0
>
>
> Looks like some windows line endings snuck into the source tree. This task is 
> to correct that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4154) fix windows line endings in source code

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079698#comment-16079698
 ] 

ASF subversion and git services commented on NIFI-4154:
---

Commit 2dc45a4dd74c42f456ed0135fc8c5a04d0036410 in nifi's branch 
refs/heads/master from [~trk...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=2dc45a4 ]

NIFI-4154 Fixing line endings in .java,.html files

Signed-off-by: James Wing 

This closes #1982.


> fix windows line endings in source code
> ---
>
> Key: NIFI-4154
> URL: https://issues.apache.org/jira/browse/NIFI-4154
> Project: Apache NiFi
>  Issue Type: Task
>Reporter: Tony Kurc
>Assignee: Tony Kurc
>Priority: Minor
>
> Looks like some windows line endings snuck into the source tree. This task is 
> to correct that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4154) fix windows line endings in source code

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079699#comment-16079699
 ] 

ASF GitHub Bot commented on NIFI-4154:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1982


> fix windows line endings in source code
> ---
>
> Key: NIFI-4154
> URL: https://issues.apache.org/jira/browse/NIFI-4154
> Project: Apache NiFi
>  Issue Type: Task
>Reporter: Tony Kurc
>Assignee: Tony Kurc
>Priority: Minor
>
> Looks like some windows line endings snuck into the source tree. This task is 
> to correct that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi pull request #1982: NIFI-4154 - fix line endings in source code

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1982


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1982: NIFI-4154 - fix line endings in source code

[jvwing]

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1982
  
Thanks @trkurc, @m-hogue.  I confirmed the whitespace-only changes in the 
diffs, ran full build with contrib-check OK.  I'll merge shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-4154) fix windows line endings in source code

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079697#comment-16079697
 ] 

ASF GitHub Bot commented on NIFI-4154:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1982
  
Thanks @trkurc, @m-hogue.  I confirmed the whitespace-only changes in the 
diffs, ran full build with contrib-check OK.  I'll merge shortly.


> fix windows line endings in source code
> ---
>
> Key: NIFI-4154
> URL: https://issues.apache.org/jira/browse/NIFI-4154
> Project: Apache NiFi
>  Issue Type: Task
>Reporter: Tony Kurc
>Assignee: Tony Kurc
>Priority: Minor
>
> Looks like some windows line endings snuck into the source tree. This task is 
> to correct that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4118) Create Nifi RethinkDB Put processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079685#comment-16079685
 ] 

ASF GitHub Bot commented on NIFI-4118:
--

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1942
  
Thanks @mans2singh!  This has been merged in.


> Create Nifi RethinkDB Put processor
> ---
>
> Key: NIFI-4118
> URL: https://issues.apache.org/jira/browse/NIFI-4118
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.3.0
> Environment: All
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
>  Labels: document, stream,
> Fix For: 1.4.0
>
>
> Create Nifi processor for streaming documents into RethinkDB.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (NIFI-4118) Create Nifi RethinkDB Put processor

[James Wing (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Wing resolved NIFI-4118.
--
Resolution: Fixed

> Create Nifi RethinkDB Put processor
> ---
>
> Key: NIFI-4118
> URL: https://issues.apache.org/jira/browse/NIFI-4118
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.3.0
> Environment: All
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
>  Labels: document, stream,
> Fix For: 1.4.0
>
>
> Create Nifi processor for streaming documents into RethinkDB.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4118) Create Nifi RethinkDB Put processor

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16079684#comment-16079684
 ] 

ASF GitHub Bot commented on NIFI-4118:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1942


> Create Nifi RethinkDB Put processor
> ---
>
> Key: NIFI-4118
> URL: https://issues.apache.org/jira/browse/NIFI-4118
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Extensions
>Affects Versions: 1.3.0
> Environment: All
>Reporter: Mans Singh
>Assignee: Mans Singh
>Priority: Minor
>  Labels: document, stream,
> Fix For: 1.4.0
>
>
> Create Nifi processor for streaming documents into RethinkDB.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] nifi issue #1942: NIFI-4118 First commit of RethinkDB put processor

[jvwing]

Github user jvwing commented on the issue:

https://github.com/apache/nifi/pull/1942
  
Thanks @mans2singh!  This has been merged in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1942: NIFI-4118 First commit of RethinkDB put processor

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1942


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---