[jira] [Commented] (NIFI-5808) MergeRecord doesn't honor "Max Bin Age" property
[
https://issues.apache.org/jira/browse/NIFI-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692782#comment-16692782
]
Davide Sessi commented on NIFI-5808:
Thanks for the clarification, [Koji
Kawamura|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ijokarumawak]
> MergeRecord doesn't honor "Max Bin Age" property
>
>
> Key: NIFI-5808
> URL: https://issues.apache.org/jira/browse/NIFI-5808
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.8.0
> Environment: Both Ubuntu and Windows 10
>Reporter: Davide Sessi
>Priority: Major
> Attachments: Test_MergeRecord_max-bin-age.xml
>
>
> MergeRecord ignores "Max Bin Age" property and does not merge records at all.
> Only NiFi 1.8.0 is affected.
> The attached test case should generate 2 types of CSV files:
> {code:java}
> column1;column2
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> ...and so on for many rows...{code}
> and
> {code:java}
> column1;column2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> ...and so on for many rows...{code}
> It works as expected for NiFi 1.6.0 and 1.7.1.
> But using NiFi 1.8.0 I only get hundreds of files with just 1 record like the
> following:
> {code:java}
> column1;column2
> A1;B1
> {code}
> and
> {code:java}
> column1;column2
> A2;B2
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-679) Improve Const correctness in core, configurable component, and ID
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692562#comment-16692562 ] ASF GitHub Bot commented on MINIFICPP-679: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/444 > Improve Const correctness in core, configurable component, and ID > - > > Key: MINIFICPP-679 > URL: https://issues.apache.org/jira/browse/MINIFICPP-679 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > > Improve Const correctness in core and ID as a way to kick off MINIFICPP-678 . > > This one scares me a tad. anytime we touch base classes , this will have an > impact on release cadence. So this one will require a lot of testing across > platforms, compilers, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-minifi-cpp pull request #444: MINIFICPP-679: Revert changes. We can mak...
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/444 ---
[jira] [Commented] (NIFI-4862) Copy original FlowFile attributes to output FlowFiles at SelectHiveQL processor
[ https://issues.apache.org/jira/browse/NIFI-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692552#comment-16692552 ] Koji Kawamura commented on NIFI-4862: - [~patwhitey2007] I'd do the same if the change is required. You can apply the PR and build the nar locally, replace the hive nar in your NiFi lib dir, then restart NiFi to take the effect. > Copy original FlowFile attributes to output FlowFiles at SelectHiveQL > processor > --- > > Key: NIFI-4862 > URL: https://issues.apache.org/jira/browse/NIFI-4862 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.5.0 >Reporter: Jakub Leś >Assignee: Matt Burgess >Priority: Minor > Fix For: 1.7.0 > > Attachments: > 0001-NIFI-4862-Add-Copy-original-attributtes-to-SelectHiv.patch > > > Hi, > Please add "Copy original attributes" to processor SelectHiveQL. Thanks to > that we can use HttpRequest and HttpResponse to synchronize fetching query > result in webservice. > > UPDATED: > SelectHiveQL creates new FlowFiles from Hive query result sets. When it also > has incoming FlowFiles, it should create new FlowFiles from the input > FlowFile, so that it can copy original FlowFile attributes to output > FlowFiles. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (NIFI-5808) MergeRecord doesn't honor "Max Bin Age" property
[
https://issues.apache.org/jira/browse/NIFI-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Kawamura resolved NIFI-5808.
-
Resolution: Not A Problem
[~d.se...@almaviva.it] As you noticed, NIFI-5514 changed how MergeRecord
processor honors Minimum Number of Records. Please increase the minimum number
of records (up to the value of Maximum Number of Records) to make it work as it
did before 1.8.0.
I will update the Migration Guidance wiki page to note this behavior change.
https://cwiki.apache.org/confluence/display/NIFI/Migration+Guidance
Thanks for reporting! I am closing this JIRA but please feel free to reopen it
if we need more discussion.
> MergeRecord doesn't honor "Max Bin Age" property
>
>
> Key: NIFI-5808
> URL: https://issues.apache.org/jira/browse/NIFI-5808
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.8.0
> Environment: Both Ubuntu and Windows 10
>Reporter: Davide Sessi
>Priority: Major
> Attachments: Test_MergeRecord_max-bin-age.xml
>
>
> MergeRecord ignores "Max Bin Age" property and does not merge records at all.
> Only NiFi 1.8.0 is affected.
> The attached test case should generate 2 types of CSV files:
> {code:java}
> column1;column2
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> ...and so on for many rows...{code}
> and
> {code:java}
> column1;column2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> ...and so on for many rows...{code}
> It works as expected for NiFi 1.6.0 and 1.7.1.
> But using NiFi 1.8.0 I only get hundreds of files with just 1 record like the
> following:
> {code:java}
> column1;column2
> A1;B1
> {code}
> and
> {code:java}
> column1;column2
> A2;B2
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (NIFI-5808) MergeRecord doesn't honor "Max Bin Age" property
[
https://issues.apache.org/jira/browse/NIFI-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Kawamura updated NIFI-5808:
Component/s: (was: Core UI)
(was: Core Framework)
Extensions
Although MergeRecord is a standard processor, it's one of extensions. Changed
component tag.
> MergeRecord doesn't honor "Max Bin Age" property
>
>
> Key: NIFI-5808
> URL: https://issues.apache.org/jira/browse/NIFI-5808
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.8.0
> Environment: Both Ubuntu and Windows 10
>Reporter: Davide Sessi
>Priority: Major
> Attachments: Test_MergeRecord_max-bin-age.xml
>
>
> MergeRecord ignores "Max Bin Age" property and does not merge records at all.
> Only NiFi 1.8.0 is affected.
> The attached test case should generate 2 types of CSV files:
> {code:java}
> column1;column2
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> ...and so on for many rows...{code}
> and
> {code:java}
> column1;column2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> ...and so on for many rows...{code}
> It works as expected for NiFi 1.6.0 and 1.7.1.
> But using NiFi 1.8.0 I only get hundreds of files with just 1 record like the
> following:
> {code:java}
> column1;column2
> A1;B1
> {code}
> and
> {code:java}
> column1;column2
> A2;B2
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MINIFICPP-679) Improve Const correctness in core, configurable component, and ID
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692528#comment-16692528 ] ASF GitHub Bot commented on MINIFICPP-679: -- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/444 verified build and tests on macos and debian. will merge > Improve Const correctness in core, configurable component, and ID > - > > Key: MINIFICPP-679 > URL: https://issues.apache.org/jira/browse/MINIFICPP-679 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > > Improve Const correctness in core and ID as a way to kick off MINIFICPP-678 . > > This one scares me a tad. anytime we touch base classes , this will have an > impact on release cadence. So this one will require a lot of testing across > platforms, compilers, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-minifi-cpp issue #444: MINIFICPP-679: Revert changes. We can make them ...
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/444 verified build and tests on macos and debian. will merge ---
[jira] [Reopened] (MINIFICPP-679) Improve Const correctness in core, configurable component, and ID
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri reopened MINIFICPP-679: --- > Improve Const correctness in core, configurable component, and ID > - > > Key: MINIFICPP-679 > URL: https://issues.apache.org/jira/browse/MINIFICPP-679 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > > Improve Const correctness in core and ID as a way to kick off MINIFICPP-678 . > > This one scares me a tad. anytime we touch base classes , this will have an > impact on release cadence. So this one will require a lot of testing across > platforms, compilers, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-679) Improve Const correctness in core, configurable component, and ID
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692516#comment-16692516 ] ASF GitHub Bot commented on MINIFICPP-679: -- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/444 dropped the ball on the review. will verify the build for this revert > Improve Const correctness in core, configurable component, and ID > - > > Key: MINIFICPP-679 > URL: https://issues.apache.org/jira/browse/MINIFICPP-679 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > > Improve Const correctness in core and ID as a way to kick off MINIFICPP-678 . > > This one scares me a tad. anytime we touch base classes , this will have an > impact on release cadence. So this one will require a lot of testing across > platforms, compilers, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-minifi-cpp issue #444: MINIFICPP-679: Revert changes. We can make them ...
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/444 dropped the ball on the review. will verify the build for this revert ---
[jira] [Commented] (MINIFICPP-679) Improve Const correctness in core, configurable component, and ID
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692510#comment-16692510 ] ASF GitHub Bot commented on MINIFICPP-679: -- Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/444 @apiri Master is broken. We need to revert these two changes. Not sure how I missed it...but the goal was to limit changes to avoid breaking changes. > Improve Const correctness in core, configurable component, and ID > - > > Key: MINIFICPP-679 > URL: https://issues.apache.org/jira/browse/MINIFICPP-679 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > > Improve Const correctness in core and ID as a way to kick off MINIFICPP-678 . > > This one scares me a tad. anytime we touch base classes , this will have an > impact on release cadence. So this one will require a lot of testing across > platforms, compilers, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-679) Improve Const correctness in core, configurable component, and ID
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692509#comment-16692509 ] ASF GitHub Bot commented on MINIFICPP-679: -- GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/444 MINIFICPP-679: Revert changes. We can make them const but we should w… …ait after additional testing before pushing these changes Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-679-b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/444.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #444 commit 7d239c5c449480349852dc40751f163dee62a277 Author: Marc Parisi Date: 2018-11-20T01:05:23Z MINIFICPP-679: Revert changes. We can make them const but we should wait after additional testing before pushing these changes > Improve Const correctness in core, configurable component, and ID > - > > Key: MINIFICPP-679 > URL: https://issues.apache.org/jira/browse/MINIFICPP-679 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > > Improve Const correctness in core and ID as a way to kick off MINIFICPP-678 . > > This one scares me a tad. anytime we touch base classes , this will have an > impact on release cadence. So this one will require a lot of testing across > platforms, compilers, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-minifi-cpp pull request #444: MINIFICPP-679: Revert changes. We can mak...
GitHub user phrocker opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/444 MINIFICPP-679: Revert changes. We can make them const but we should w⦠â¦ait after additional testing before pushing these changes Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-679-b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi-cpp/pull/444.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #444 commit 7d239c5c449480349852dc40751f163dee62a277 Author: Marc Parisi Date: 2018-11-20T01:05:23Z MINIFICPP-679: Revert changes. We can make them const but we should wait after additional testing before pushing these changes ---
[GitHub] nifi-minifi-cpp issue #444: MINIFICPP-679: Revert changes. We can make them ...
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/444 @apiri Master is broken. We need to revert these two changes. Not sure how I missed it...but the goal was to limit changes to avoid breaking changes. ---
[jira] [Commented] (NIFI-4914) Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, PublishPulsarRecord
[ https://issues.apache.org/jira/browse/NIFI-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692506#comment-16692506 ] ASF GitHub Bot commented on NIFI-4914: -- Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2882 Created new PR after rebasing to NiFi 1.9.0-Snapshot branch. https://github.com/apache/nifi/pull/3178 > Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, > PublishPulsarRecord > -- > > Key: NIFI-4914 > URL: https://issues.apache.org/jira/browse/NIFI-4914 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.6.0 >Reporter: David Kjerrumgaard >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > Create record-based processors for Apache Pulsar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4914) Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, PublishPulsarRecord
[ https://issues.apache.org/jira/browse/NIFI-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692505#comment-16692505 ] ASF GitHub Bot commented on NIFI-4914: -- GitHub user david-streamlio opened a pull request: https://github.com/apache/nifi/pull/3178 NIFI-4914: Add Apache Pulsar processors Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/david-streamlio/nifi NIFI-4914 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/3178.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3178 > Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, > PublishPulsarRecord > -- > > Key: NIFI-4914 > URL: https://issues.apache.org/jira/browse/NIFI-4914 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.6.0 >Reporter: David Kjerrumgaard >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > Create record-based processors for Apache Pulsar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2882: NIFI-4914
Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2882 Created new PR after rebasing to NiFi 1.9.0-Snapshot branch. https://github.com/apache/nifi/pull/3178 ---
[GitHub] nifi pull request #3178: NIFI-4914: Add Apache Pulsar processors
GitHub user david-streamlio opened a pull request: https://github.com/apache/nifi/pull/3178 NIFI-4914: Add Apache Pulsar processors Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/david-streamlio/nifi NIFI-4914 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/3178.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3178 ---
[GitHub] nifi pull request #3177: NIFI-5828: Documents behavior of ExecuteSQL attrs w...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3177 ---
[jira] [Commented] (NIFI-5814) GeoEnrichIP processor fails in 1.8.0
[ https://issues.apache.org/jira/browse/NIFI-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692483#comment-16692483 ] ASF GitHub Bot commented on NIFI-5814: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3168 > GeoEnrichIP processor fails in 1.8.0 > > > Key: NIFI-5814 > URL: https://issues.apache.org/jira/browse/NIFI-5814 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.8.0 >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.9.0 > > > As reported on the mailing list by Philippe Peeters, the GeoEnrichIP > processor is failing in 1.8.0. This appears to be a caused by a change in the > version of the maxmind database library. The new version returns JSON objects > to the DatabaseReader class that are read-only, whereas the previous version > allowed the objects to be modified. Interestingly, we are modifying the > object in order to inject in an "ip_address" field in the "Traits" field... > but then we don't use the field. We can instead just avoid ever modifying the > response. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5828) ExecuteSQL executesql.row.count meaning changes when Max Rows Per Flow File > 0
[
https://issues.apache.org/jira/browse/NIFI-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692482#comment-16692482
]
ASF GitHub Bot commented on NIFI-5828:
--
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/3177
> ExecuteSQL executesql.row.count meaning changes when Max Rows Per Flow File > > 0
> ---
>
> Key: NIFI-5828
> URL: https://issues.apache.org/jira/browse/NIFI-5828
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.0.0
> Environment: Linux, MSSQL 2016
>Reporter: Colin Dean
>Assignee: Colin Dean
>Priority: Minor
> Labels: regression
> Fix For: 1.9.0
>
>
> When *Max Rows Per Flow File* ({{esql-max-rows}}) is set greater than 0 to
> enable it, the {{executesql.row.count}} attribute on the resulting FlowFiles
> is not the number of rows in the result set but rather the number of rows in
> the FlowFile.
> This is a deviation from documented behavior, which is "Contains the number
> of rows returned in the select query".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #3168: NIFI-5814: Addressed issue in DatabaseReader class ...
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/3168 ---
[jira] [Commented] (MINIFICPP-679) Improve Const correctness in core, configurable component, and ID
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692481#comment-16692481 ] ASF GitHub Bot commented on MINIFICPP-679: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/442 > Improve Const correctness in core, configurable component, and ID > - > > Key: MINIFICPP-679 > URL: https://issues.apache.org/jira/browse/MINIFICPP-679 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > > Improve Const correctness in core and ID as a way to kick off MINIFICPP-678 . > > This one scares me a tad. anytime we touch base classes , this will have an > impact on release cadence. So this one will require a lot of testing across > platforms, compilers, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-680) Remove XCode 7.3 from travis builds
[ https://issues.apache.org/jira/browse/MINIFICPP-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692480#comment-16692480 ] ASF GitHub Bot commented on MINIFICPP-680: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/443 > Remove XCode 7.3 from travis builds > --- > > Key: MINIFICPP-680 > URL: https://issues.apache.org/jira/browse/MINIFICPP-680 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > > > Per an email exchange with travis support it seems that we may not want to > perform 7.3 builds in travis. Not sure we need to, but it seems that the > software we use for deps is dropping binary support. > "Hey there, Marc! Thanks for writing in today. > So it looks like what happened here is Homebrew no longer has a pre-complied > binary for that version of Xcode- it looks like it was discontinued due to > age. Since it's not finding one, it's trying to compile a new version from > the source, which is what's resulting in that timeout. I've gone ahead and > increased your log silence timeout to 30 minutes, but even that might not be > enough- since this was an upstream change that is unfortunately outside of > our control, the only real option here to avoid it trying to compile a new > binary from the source would be to switch to a newer version of Xcode. > Sorry I"m not able to do more here, but I hope this at least helps. Just let > me know if you have any other questions or concerns I can help you with! > Best, > Grant" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-minifi-cpp pull request #443: MINIFICPP-680: Remove Xcode 7.3
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/443 ---
[GitHub] nifi-minifi-cpp pull request #442: MINIFICPP-679: Make minor changes for con...
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/442 ---
[jira] [Comment Edited] (NIFI-4862) Copy original FlowFile attributes to output FlowFiles at SelectHiveQL processor
[ https://issues.apache.org/jira/browse/NIFI-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692195#comment-16692195 ] patrick white edited comment on NIFI-4862 at 11/19/18 9:29 PM: --- [~mattyb149] [~ijokarumawak] Hi Folks, would like to request your opinion, we're seeing this issue running on 1.6.0, is pulling Matt's PR #2605 into 1.6.0 a good approach? The patch looks pretty clean to cherry-pick, and we're still testing for move to 1.7.0, so thought this approach may be viable until we can update. was (Author: patwhitey2007): [~mattyb149] [~ijokarumawak] Hi Folks, would like to request your opinion, we're seeing this issue running on 1.6.0, is pulling Matt's PR #2605 into 1.6.0 a good approach? The patch looks pretty clean to cherry-pick, and we're still testing for move to 1.7.0, so thought this approach may be viable until update. > Copy original FlowFile attributes to output FlowFiles at SelectHiveQL > processor > --- > > Key: NIFI-4862 > URL: https://issues.apache.org/jira/browse/NIFI-4862 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.5.0 >Reporter: Jakub Leś >Assignee: Matt Burgess >Priority: Minor > Fix For: 1.7.0 > > Attachments: > 0001-NIFI-4862-Add-Copy-original-attributtes-to-SelectHiv.patch > > > Hi, > Please add "Copy original attributes" to processor SelectHiveQL. Thanks to > that we can use HttpRequest and HttpResponse to synchronize fetching query > result in webservice. > > UPDATED: > SelectHiveQL creates new FlowFiles from Hive query result sets. When it also > has incoming FlowFiles, it should create new FlowFiles from the input > FlowFile, so that it can copy original FlowFile attributes to output > FlowFiles. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4914) Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, PublishPulsarRecord
[
https://issues.apache.org/jira/browse/NIFI-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692201#comment-16692201
]
ASF GitHub Bot commented on NIFI-4914:
--
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2882#discussion_r234765596
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java
---
@@ -0,0 +1,285 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.pulsar;
+
+import java.net.MalformedURLException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.annotation.lifecycle.OnShutdown;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.ssl.SSLContextService;
+import org.apache.pulsar.client.api.ClientBuilder;
+import org.apache.pulsar.client.api.PulsarClient;
+import org.apache.pulsar.client.api.PulsarClientException;
+import
org.apache.pulsar.client.api.PulsarClientException.UnsupportedAuthenticationException;
+import org.apache.pulsar.client.impl.auth.AuthenticationTls;
+
+public class StandardPulsarClientService extends AbstractControllerService
implements PulsarClientService {
+
+public static final PropertyDescriptor PULSAR_SERVICE_URL = new
PropertyDescriptor
+.Builder().name("PULSAR_SERVICE_URL")
+.displayName("Pulsar Service URL")
+.description("URL for the Pulsar cluster, e.g localhost:6650")
+.required(true)
+.addValidator(StandardValidators.HOSTNAME_PORT_LIST_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor ALLOW_TLS_INSECURE_CONNECTION =
new PropertyDescriptor.Builder()
--- End diff --
This property should be removed as its meaning is too vague. There are a
lot of ways a TLS connection could be considered or made insecure. If you mean
to allow for untrusted certs, and I really dont understand why we would, then
it should be clear to what it is doing.
> Implement record model processor for Pulsar, i.e. ConsumePulsarRecord,
> PublishPulsarRecord
> --
>
> Key: NIFI-4914
> URL: https://issues.apache.org/jira/browse/NIFI-4914
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
>Affects Versions: 1.6.0
>Reporter: David Kjerrumgaard
>Priority: Minor
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Create record-based processors for Apache Pulsar
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi pull request #2882: NIFI-4914
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2882#discussion_r234765596
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java
---
@@ -0,0 +1,285 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.pulsar;
+
+import java.net.MalformedURLException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.annotation.lifecycle.OnShutdown;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.ssl.SSLContextService;
+import org.apache.pulsar.client.api.ClientBuilder;
+import org.apache.pulsar.client.api.PulsarClient;
+import org.apache.pulsar.client.api.PulsarClientException;
+import
org.apache.pulsar.client.api.PulsarClientException.UnsupportedAuthenticationException;
+import org.apache.pulsar.client.impl.auth.AuthenticationTls;
+
+public class StandardPulsarClientService extends AbstractControllerService
implements PulsarClientService {
+
+public static final PropertyDescriptor PULSAR_SERVICE_URL = new
PropertyDescriptor
+.Builder().name("PULSAR_SERVICE_URL")
+.displayName("Pulsar Service URL")
+.description("URL for the Pulsar cluster, e.g localhost:6650")
+.required(true)
+.addValidator(StandardValidators.HOSTNAME_PORT_LIST_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
+.build();
+
+public static final PropertyDescriptor ALLOW_TLS_INSECURE_CONNECTION =
new PropertyDescriptor.Builder()
--- End diff --
This property should be removed as its meaning is too vague. There are a
lot of ways a TLS connection could be considered or made insecure. If you mean
to allow for untrusted certs, and I really dont understand why we would, then
it should be clear to what it is doing.
---
[jira] [Commented] (NIFI-4914) Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, PublishPulsarRecord
[ https://issues.apache.org/jira/browse/NIFI-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692199#comment-16692199 ] ASF GitHub Bot commented on NIFI-4914: -- Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2882 @david-streamlio its not likely we'll put a feature like this into an already released line. It doesn't fit our semver scheme. Also, on my local branch i have the changes i needed from your last commit so this would actually build against master. However, if I do parallel builds the build gets hung up. Single threaded builds are fine. I cannot tell why yet. If I do a full clean build parallel just on master things are fine. So, i believe there is something in the way these tests run that break parallel builds > Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, > PublishPulsarRecord > -- > > Key: NIFI-4914 > URL: https://issues.apache.org/jira/browse/NIFI-4914 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.6.0 >Reporter: David Kjerrumgaard >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > Create record-based processors for Apache Pulsar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2882: NIFI-4914
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2882 @david-streamlio its not likely we'll put a feature like this into an already released line. It doesn't fit our semver scheme. Also, on my local branch i have the changes i needed from your last commit so this would actually build against master. However, if I do parallel builds the build gets hung up. Single threaded builds are fine. I cannot tell why yet. If I do a full clean build parallel just on master things are fine. So, i believe there is something in the way these tests run that break parallel builds ---
[jira] [Commented] (NIFI-4862) Copy original FlowFile attributes to output FlowFiles at SelectHiveQL processor
[ https://issues.apache.org/jira/browse/NIFI-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692195#comment-16692195 ] patrick white commented on NIFI-4862: - [~mattyb149] [~ijokarumawak] Hi Folks, would like to request your opinion, we're seeing this issue running on 1.6.0, is pulling Matt's PR #2605 into 1.6.0 a good approach? The patch looks pretty clean to cherry-pick, and we're still testing for move to 1.7.0, so thought this approach may be viable until update. > Copy original FlowFile attributes to output FlowFiles at SelectHiveQL > processor > --- > > Key: NIFI-4862 > URL: https://issues.apache.org/jira/browse/NIFI-4862 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.5.0 >Reporter: Jakub Leś >Assignee: Matt Burgess >Priority: Minor > Fix For: 1.7.0 > > Attachments: > 0001-NIFI-4862-Add-Copy-original-attributtes-to-SelectHiv.patch > > > Hi, > Please add "Copy original attributes" to processor SelectHiveQL. Thanks to > that we can use HttpRequest and HttpResponse to synchronize fetching query > result in webservice. > > UPDATED: > SelectHiveQL creates new FlowFiles from Hive query result sets. When it also > has incoming FlowFiles, it should create new FlowFiles from the input > FlowFile, so that it can copy original FlowFile attributes to output > FlowFiles. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MINIFICPP-683) RESTProtocol moves prevent potential elision.
Mr TheSegfault created MINIFICPP-683: Summary: RESTProtocol moves prevent potential elision. Key: MINIFICPP-683 URL: https://issues.apache.org/jira/browse/MINIFICPP-683 Project: NiFi MiNiFi C++ Issue Type: Improvement Reporter: Mr TheSegfault Assignee: Mr TheSegfault -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4914) Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, PublishPulsarRecord
[ https://issues.apache.org/jira/browse/NIFI-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692132#comment-16692132 ] ASF GitHub Bot commented on NIFI-4914: -- Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2882 @rumbin I am going to submit a new PR, it is just easier to create a fresh branch than rebasing to a new version of NiFi. > Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, > PublishPulsarRecord > -- > > Key: NIFI-4914 > URL: https://issues.apache.org/jira/browse/NIFI-4914 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.6.0 >Reporter: David Kjerrumgaard >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > Create record-based processors for Apache Pulsar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2882: NIFI-4914
Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2882 @rumbin I am going to submit a new PR, it is just easier to create a fresh branch than rebasing to a new version of NiFi. ---
[jira] [Commented] (NIFI-4914) Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, PublishPulsarRecord
[ https://issues.apache.org/jira/browse/NIFI-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692107#comment-16692107 ] ASF GitHub Bot commented on NIFI-4914: -- Github user rumbin commented on the issue: https://github.com/apache/nifi/pull/2882 @david-streamlio why did you close it? Will you submit a new PR? > Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, > PublishPulsarRecord > -- > > Key: NIFI-4914 > URL: https://issues.apache.org/jira/browse/NIFI-4914 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.6.0 >Reporter: David Kjerrumgaard >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > Create record-based processors for Apache Pulsar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #2882: NIFI-4914
Github user rumbin commented on the issue: https://github.com/apache/nifi/pull/2882 @david-streamlio why did you close it? Will you submit a new PR? ---
[jira] [Commented] (NIFI-5828) ExecuteSQL executesql.row.count meaning changes when Max Rows Per Flow File > 0
[
https://issues.apache.org/jira/browse/NIFI-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692083#comment-16692083
]
ASF GitHub Bot commented on NIFI-5828:
--
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/3177
@colindean mind closing this PR? Doesn't look like the comment in the
commit caused it to auto-close (maybe the period after the PR number?) Please
and thanks! Also I updated the Fix Version to be 1.9.0 as 1.8.0 was already
released
> ExecuteSQL executesql.row.count meaning changes when Max Rows Per Flow File > > 0
> ---
>
> Key: NIFI-5828
> URL: https://issues.apache.org/jira/browse/NIFI-5828
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.0.0
> Environment: Linux, MSSQL 2016
>Reporter: Colin Dean
>Assignee: Colin Dean
>Priority: Minor
> Labels: regression
> Fix For: 1.9.0
>
>
> When *Max Rows Per Flow File* ({{esql-max-rows}}) is set greater than 0 to
> enable it, the {{executesql.row.count}} attribute on the resulting FlowFiles
> is not the number of rows in the result set but rather the number of rows in
> the FlowFile.
> This is a deviation from documented behavior, which is "Contains the number
> of rows returned in the select query".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] nifi issue #3177: NIFI-5828: Documents behavior of ExecuteSQL attrs when Max...
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/3177 @colindean mind closing this PR? Doesn't look like the comment in the commit caused it to auto-close (maybe the period after the PR number?) Please and thanks! Also I updated the Fix Version to be 1.9.0 as 1.8.0 was already released ---
[jira] [Updated] (NIFI-5828) ExecuteSQL executesql.row.count meaning changes when Max Rows Per Flow File > 0
[
https://issues.apache.org/jira/browse/NIFI-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-5828:
---
Fix Version/s: (was: 1.8.0)
1.9.0
> ExecuteSQL executesql.row.count meaning changes when Max Rows Per Flow File > > 0
> ---
>
> Key: NIFI-5828
> URL: https://issues.apache.org/jira/browse/NIFI-5828
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.0.0
> Environment: Linux, MSSQL 2016
>Reporter: Colin Dean
>Assignee: Colin Dean
>Priority: Minor
> Labels: regression
> Fix For: 1.9.0
>
>
> When *Max Rows Per Flow File* ({{esql-max-rows}}) is set greater than 0 to
> enable it, the {{executesql.row.count}} attribute on the resulting FlowFiles
> is not the number of rows in the result set but rather the number of rows in
> the FlowFile.
> This is a deviation from documented behavior, which is "Contains the number
> of rows returned in the select query".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFI-4914) Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, PublishPulsarRecord
[ https://issues.apache.org/jira/browse/NIFI-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692081#comment-16692081 ] ASF GitHub Bot commented on NIFI-4914: -- Github user david-streamlio closed the pull request at: https://github.com/apache/nifi/pull/2882 > Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, > PublishPulsarRecord > -- > > Key: NIFI-4914 > URL: https://issues.apache.org/jira/browse/NIFI-4914 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Affects Versions: 1.6.0 >Reporter: David Kjerrumgaard >Priority: Minor > Original Estimate: 168h > Remaining Estimate: 168h > > Create record-based processors for Apache Pulsar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi pull request #2882: NIFI-4914
Github user david-streamlio closed the pull request at: https://github.com/apache/nifi/pull/2882 ---
[jira] [Resolved] (MINIFICPP-679) Improve Const correctness in core, configurable component, and ID
[ https://issues.apache.org/jira/browse/MINIFICPP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri resolved MINIFICPP-679. --- Resolution: Fixed > Improve Const correctness in core, configurable component, and ID > - > > Key: MINIFICPP-679 > URL: https://issues.apache.org/jira/browse/MINIFICPP-679 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > > Improve Const correctness in core and ID as a way to kick off MINIFICPP-678 . > > This one scares me a tad. anytime we touch base classes , this will have an > impact on release cadence. So this one will require a lot of testing across > platforms, compilers, etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-680) Remove XCode 7.3 from travis builds
[ https://issues.apache.org/jira/browse/MINIFICPP-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691846#comment-16691846 ] ASF GitHub Bot commented on MINIFICPP-680: -- Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/443 This was merged in https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;a=commit;h=5dffa37d52d52dd8c6c77829f803c5831b3b644e. Seems like the mirroring to GitHub is a little sluggish today. > Remove XCode 7.3 from travis builds > --- > > Key: MINIFICPP-680 > URL: https://issues.apache.org/jira/browse/MINIFICPP-680 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > > > Per an email exchange with travis support it seems that we may not want to > perform 7.3 builds in travis. Not sure we need to, but it seems that the > software we use for deps is dropping binary support. > "Hey there, Marc! Thanks for writing in today. > So it looks like what happened here is Homebrew no longer has a pre-complied > binary for that version of Xcode- it looks like it was discontinued due to > age. Since it's not finding one, it's trying to compile a new version from > the source, which is what's resulting in that timeout. I've gone ahead and > increased your log silence timeout to 30 minutes, but even that might not be > enough- since this was an upstream change that is unfortunately outside of > our control, the only real option here to avoid it trying to compile a new > binary from the source would be to switch to a newer version of Xcode. > Sorry I"m not able to do more here, but I hope this at least helps. Just let > me know if you have any other questions or concerns I can help you with! > Best, > Grant" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi-minifi-cpp issue #443: MINIFICPP-680: Remove Xcode 7.3
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/443 This was merged in https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp.git;a=commit;h=5dffa37d52d52dd8c6c77829f803c5831b3b644e. Seems like the mirroring to GitHub is a little sluggish today. ---
[jira] [Resolved] (MINIFICPP-680) Remove XCode 7.3 from travis builds
[ https://issues.apache.org/jira/browse/MINIFICPP-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri resolved MINIFICPP-680. --- Resolution: Fixed Fix Version/s: 0.6.0 > Remove XCode 7.3 from travis builds > --- > > Key: MINIFICPP-680 > URL: https://issues.apache.org/jira/browse/MINIFICPP-680 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Mr TheSegfault >Assignee: Mr TheSegfault >Priority: Major > Fix For: 0.6.0 > > > > Per an email exchange with travis support it seems that we may not want to > perform 7.3 builds in travis. Not sure we need to, but it seems that the > software we use for deps is dropping binary support. > "Hey there, Marc! Thanks for writing in today. > So it looks like what happened here is Homebrew no longer has a pre-complied > binary for that version of Xcode- it looks like it was discontinued due to > age. Since it's not finding one, it's trying to compile a new version from > the source, which is what's resulting in that timeout. I've gone ahead and > increased your log silence timeout to 30 minutes, but even that might not be > enough- since this was an upstream change that is unfortunately outside of > our control, the only real option here to avoid it trying to compile a new > binary from the source would be to switch to a newer version of Xcode. > Sorry I"m not able to do more here, but I hope this at least helps. Just let > me know if you have any other questions or concerns I can help you with! > Best, > Grant" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MINIFICPP-682) C API: provide functions to create custom processors
[ https://issues.apache.org/jira/browse/MINIFICPP-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691609#comment-16691609 ] Mr TheSegfault commented on MINIFICPP-682: -- [~aboda] I think this is a great start. Zero copy is something to think about ( maybe not necessarily implement yet ) – this may come in the form of using system calls ( something like mmap ) or just transferring pointers where it makes sense ( if it makes sense ). > C API: provide functions to create custom processors > > > Key: MINIFICPP-682 > URL: https://issues.apache.org/jira/browse/MINIFICPP-682 > Project: NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Arpad Boda >Assignee: Arpad Boda >Priority: Major > Labels: CAPI, nanofi > Fix For: 0.6.0 > > > Extend C API to: > -Provide functions that can be used used to implement custom processor. > -Custom processor should be able to read/update both the content and the > attributes of flowfile, route to "failure" and "success" relationships. > -API should support adding these custom processors to flows and invoke them > as standalones, too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MINIFICPP-682) C API: provide functions to create custom processors
Arpad Boda created MINIFICPP-682: Summary: C API: provide functions to create custom processors Key: MINIFICPP-682 URL: https://issues.apache.org/jira/browse/MINIFICPP-682 Project: NiFi MiNiFi C++ Issue Type: Improvement Reporter: Arpad Boda Assignee: Arpad Boda Fix For: 0.6.0 Extend C API to: -Provide functions that can be used used to implement custom processor. -Custom processor should be able to read/update both the content and the attributes of flowfile, route to "failure" and "success" relationships. -API should support adding these custom processors to flows and invoke them as standalones, too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MINIFICPP-681) Add content hash processor
Arpad Boda created MINIFICPP-681: Summary: Add content hash processor Key: MINIFICPP-681 URL: https://issues.apache.org/jira/browse/MINIFICPP-681 Project: NiFi MiNiFi C++ Issue Type: Improvement Reporter: Arpad Boda Assignee: Arpad Boda Fix For: 0.6.0 Add a new processor that supports hashing content and add the checksum to the flowfile as an attribute. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5795) RedisDistributedMapCacheClientService put missing option
[
https://issues.apache.org/jira/browse/NIFI-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691552#comment-16691552
]
ASF GitHub Bot commented on NIFI-5795:
--
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/3135
@zenfenan - did you make progress on this one? I see this change has also
been added in #3176
> RedisDistributedMapCacheClientService put missing option
>
>
> Key: NIFI-5795
> URL: https://issues.apache.org/jira/browse/NIFI-5795
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Alex
>Priority: Major
>
> When you select on *PutDistributedMapCache CACHE_UPDATE_STRATEGY =
> CACHE_UPDATE_REPLACE we execute "cache.put(cacheKey, cacheValue,
> keySerializer, valueSerializer);"*
> [LINK|https://github.com/apache/nifi/blob/ea9b0db2f620526c8dd0db595cf8b44c3ef835be/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDistributedMapCache.java#L202]
> If you use redis as backend service this jumps to:
> RedisDistributedMapCacheClientService.java ->
> redisConnection.set(kv.getKey(), kv.getValue(), Expiration.seconds(ttl),
> null);
> [LINK|https://github.com/apache/nifi/blob/ea9b0db2f620526c8dd0db595cf8b44c3ef835be/nifi-nar-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/RedisDistributedMapCacheClientService.java#L191]
> Calling to spring-data/redis/ library, but we have a bug putting null as
> Option parameter, causing an error "option cannot be null", because according
> to library: "{{option}} - must not be null." [Library
> Link|https://docs.spring.io/spring-data/redis/docs/current/api/org/springframework/data/redis/connection/RedisStringCommands.html#set-byte:A-byte:A-org.springframework.data.redis.core.types.Expiration-org.springframework.data.redis.connection.RedisStringCommands.SetOption-]
> If we want to update strategy we should use:
> [{{RedisStringCommands.SetOption.upsert()}}|https://docs.spring.io/spring-data/redis/docs/current/api/org/springframework/data/redis/connection/RedisStringCommands.SetOption.html#upsert--]
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (NIFI-5814) GeoEnrichIP processor fails in 1.8.0
[ https://issues.apache.org/jira/browse/NIFI-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-5814: - Resolution: Fixed Status: Resolved (was: Patch Available) > GeoEnrichIP processor fails in 1.8.0 > > > Key: NIFI-5814 > URL: https://issues.apache.org/jira/browse/NIFI-5814 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.8.0 >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.9.0 > > > As reported on the mailing list by Philippe Peeters, the GeoEnrichIP > processor is failing in 1.8.0. This appears to be a caused by a change in the > version of the maxmind database library. The new version returns JSON objects > to the DatabaseReader class that are read-only, whereas the previous version > allowed the objects to be modified. Interestingly, we are modifying the > object in order to inject in an "ip_address" field in the "Traits" field... > but then we don't use the field. We can instead just avoid ever modifying the > response. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #3135: [NIFI-5795] RedisDistributedMapCacheClientService put miss...
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/3135 @zenfenan - did you make progress on this one? I see this change has also been added in #3176 ---
[jira] [Commented] (NIFI-5814) GeoEnrichIP processor fails in 1.8.0
[ https://issues.apache.org/jira/browse/NIFI-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691541#comment-16691541 ] ASF GitHub Bot commented on NIFI-5814: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/3168 +1, reproduced the issue and confirmed the fix, merging to master, thanks @markap14 > GeoEnrichIP processor fails in 1.8.0 > > > Key: NIFI-5814 > URL: https://issues.apache.org/jira/browse/NIFI-5814 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.8.0 >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.9.0 > > > As reported on the mailing list by Philippe Peeters, the GeoEnrichIP > processor is failing in 1.8.0. This appears to be a caused by a change in the > version of the maxmind database library. The new version returns JSON objects > to the DatabaseReader class that are read-only, whereas the previous version > allowed the objects to be modified. Interestingly, we are modifying the > object in order to inject in an "ip_address" field in the "Traits" field... > but then we don't use the field. We can instead just avoid ever modifying the > response. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] nifi issue #3168: NIFI-5814: Addressed issue in DatabaseReader class that wa...
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/3168 +1, reproduced the issue and confirmed the fix, merging to master, thanks @markap14 ---
[jira] [Commented] (NIFI-5814) GeoEnrichIP processor fails in 1.8.0
[ https://issues.apache.org/jira/browse/NIFI-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691540#comment-16691540 ] ASF subversion and git services commented on NIFI-5814: --- Commit 7bcf9fcb5da4f9b71a65314dd369d786ad032e69 in nifi's branch refs/heads/master from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=7bcf9fc ] NIFI-5814: Addressed issue in DatabaseReader class that was attempting to set values on the JSON returned by MaxMind. Instead of modifying the object directly, we should use an Injectable in the Reader so that the value read will have the appropriate values but we don't need to modify those objects returned by MaxMind Signed-off-by: Pierre Villard This closes #3168. > GeoEnrichIP processor fails in 1.8.0 > > > Key: NIFI-5814 > URL: https://issues.apache.org/jira/browse/NIFI-5814 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.8.0 >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.9.0 > > > As reported on the mailing list by Philippe Peeters, the GeoEnrichIP > processor is failing in 1.8.0. This appears to be a caused by a change in the > version of the maxmind database library. The new version returns JSON objects > to the DatabaseReader class that are read-only, whereas the previous version > allowed the objects to be modified. Interestingly, we are modifying the > object in order to inject in an "ip_address" field in the "Traits" field... > but then we don't use the field. We can instead just avoid ever modifying the > response. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-5830) RedisConnectionPoolService does not work with Standalone Redis using non-localhost deployment
[
https://issues.apache.org/jira/browse/NIFI-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691491#comment-16691491
]
Alexander Bukarev commented on NIFI-5830:
-
Just to explain more: if you'll check {{spring-data-redis:2.1.0.RELEASE}} code
you can see {code:java}Assert.notNull(option, "Option must not be
null!");{code} at the beggining of each of implementation methods {{Boolean
set(byte[] key, byte[] value, Expiration expiration, SetOption option)}}, I
mean
- JedisStringCommands implements RedisStringCommands
- JedisClusterStringCommands implements RedisStringCommands
- LettuceStringCommands implements RedisStringCommands
So any implementation fails to execute current line
{code:java}redisConnection.set(kv.getKey(), kv.getValue(),
Expiration.seconds(ttl), null);{code}
So I've decided to fix it...
> RedisConnectionPoolService does not work with Standalone Redis using
> non-localhost deployment
> -
>
> Key: NIFI-5830
> URL: https://issues.apache.org/jira/browse/NIFI-5830
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.8.0
> Environment: Ubuntu 16 LTS, NiFi 1.8.0
>Reporter: Alexander Bukarev
>Priority: Major
>
> The controller service {{RedisConnectionPoolService}} does not work with
> Standalone Redis which is deployed on a host other than {{localhost}} (or if
> Redis uses the port other than {{6379}}). So the only way to use
> {{RedisConnectionPoolService}} is to deploy Redis on {{localhost}} and run it
> with default port {{6379}}.
> *Steps*:
> Let's assume our Redis is deployed on host *redis* (not {{localhost}}) and it
> listens port 6379 (I use docker for that)
> # Create a {{PutDistributedMapCache}} processor
> # Configure the processor with {{RedisDistributedMapCacheClientService}}
> # Create a new controller service: {{RedisConnectionPoolService}}
> #* Choose *Standalone* Redis Mode
> #* Use *redis:6379* as a Connection String
> # Connect some incoming flow to the {{PutDistributedMapCache}} processor
> (I've used {{GetFile}} as a producer) and run the whole flow. Allow
> {{GetFile}} to consume some file (if you use {{GetFile}} ro reproduce) and
> wait some time till the {{PutDistributedMapCache}} will be schedulled.
> Result:
> The processor is failed to run. And we can see the error in logs:
> {panel}2018-11-17 06:06:47,572 WARN [Timer-Driven Process Thread-2]
> o.a.n.controller.tasks.ConnectableTask Administratively Yielding PutDistribu
> tedMapCache[id=2041c81f-0167-1000-c82f-d7da2155dfb4] due to uncaught
> Exception: org.springframework.data.redis.RedisConnectionFailureExce
> ption: Cannot get Jedis connection; nested exception is
> redis.clients.jedis.exceptions.JedisConnectionException: Could not get a
> resource
> from the pool
> org.springframework.data.redis.RedisConnectionFailureException: Cannot get
> Jedis connection; nested exception is
> redis.clients.jedis.exceptions.JedisConnectionException: Could not get a
> resource from the pool
> at
> org.springframework.data.redis.connection.jedis.JedisConnectionFactory.fetchJedisConnector(JedisConnectionFactory.java:281)
> at
> org.springframework.data.redis.connection.jedis.JedisConnectionFactory.getConnection(JedisConnectionFactory.java:464)
> at
> org.apache.nifi.redis.service.RedisConnectionPoolService.getConnection(RedisConnectionPoolService.java:89)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:84)
> at com.sun.proxy.$Proxy128.getConnection(Unknown Source)
> at
> org.apache.nifi.redis.service.RedisDistributedMapCacheClientService.withConnection(RedisDistributedMapCacheClientService.java:343)
> at
> org.apache.nifi.redis.service.RedisDistributedMapCacheClientService.put(RedisDistributedMapCacheClientService.java:189)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.nifi.controller.service.StandardControllerServiceInvocationHandler.invoke(StandardControllerServiceInvocationHandler.java:84)
> at
[jira] [Commented] (NIFI-5808) MergeRecord doesn't honor "Max Bin Age" property
[
https://issues.apache.org/jira/browse/NIFI-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691487#comment-16691487
]
Davide Sessi commented on NIFI-5808:
Now I'm a bit confused.
Just noticed issue NIFI-5514 (fix version 1.8.0) and read this [explanation
about MergeContent and the minimum number of
entries|https://community.hortonworks.com/comments/182775/view.html].
Now, should MergeRecord also behave like that?
Does this mean that v1.8.0 is good and previous versions have incorrect
behavior?
Please, let me know :)
> MergeRecord doesn't honor "Max Bin Age" property
>
>
> Key: NIFI-5808
> URL: https://issues.apache.org/jira/browse/NIFI-5808
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework, Core UI
>Affects Versions: 1.8.0
> Environment: Both Ubuntu and Windows 10
>Reporter: Davide Sessi
>Priority: Major
> Attachments: Test_MergeRecord_max-bin-age.xml
>
>
> MergeRecord ignores "Max Bin Age" property and does not merge records at all.
> Only NiFi 1.8.0 is affected.
> The attached test case should generate 2 types of CSV files:
> {code:java}
> column1;column2
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> A1;B1
> ...and so on for many rows...{code}
> and
> {code:java}
> column1;column2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> A2;B2
> ...and so on for many rows...{code}
> It works as expected for NiFi 1.6.0 and 1.7.1.
> But using NiFi 1.8.0 I only get hundreds of files with just 1 record like the
> following:
> {code:java}
> column1;column2
> A1;B1
> {code}
> and
> {code:java}
> column1;column2
> A2;B2
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
