[GitHub] [nifi] SandishKumarHN commented on issue #3611: NIFI-6009 ScanKudu Processor

2019-09-17 Thread GitBox
SandishKumarHN commented on issue #3611: NIFI-6009 ScanKudu Processor
URL: https://github.com/apache/nifi/pull/3611#issuecomment-532502158
 
 
   @pvillard31 did you had a chance to go through the latest changes? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] granthenke commented on a change in pull request #3732: NIFI-6662: Adding Kudu Lookup Service

2019-09-17 Thread GitBox
granthenke commented on a change in pull request #3732: NIFI-6662: Adding Kudu 
Lookup Service
URL: https://github.com/apache/nifi/pull/3732#discussion_r325452193
 
 

 ##
 File path: 
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-controller-service/pom.xml
 ##
 @@ -91,4 +107,18 @@
 test
 
 
+
+
+kudu-windows
 
 Review comment:
   You might need to move the `kudu-binary` dependency into a profile for OSX 
and Linux so that Maven doesn't try to resolve it on Windows, which will result 
in a missing dependency.  ex:
   ```
   
 kudu-linux
 
   
 Unix
   
 
 
   
 org.apache.kudu
 kudu-binary
 ${kudu.version}
 ${os.detected.classifier}
 test
   
 
   
   
 kudu-mac
 
   
 mac
   
 
 
   
 org.apache.kudu
 kudu-binary
 ${kudu.version}
 ${os.detected.classifier}
 test
   
 
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] SamHjelmfelt commented on a change in pull request #3732: NIFI-6662: Adding Kudu Lookup Service

2019-09-17 Thread GitBox
SamHjelmfelt commented on a change in pull request #3732: NIFI-6662: Adding 
Kudu Lookup Service
URL: https://github.com/apache/nifi/pull/3732#discussion_r325420283
 
 

 ##
 File path: 
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-controller-service/src/test/java/org/apache/nifi/controller/kudu/TestKuduLookupService.java
 ##
 @@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.controller.kudu;
+
+import org.apache.kudu.ColumnSchema;
+import org.apache.kudu.Schema;
+import org.apache.kudu.Type;
+import org.apache.kudu.client.CreateTableOptions;
+import org.apache.kudu.client.Insert;
+import org.apache.kudu.client.KuduClient;
+import org.apache.kudu.client.KuduSession;
+import org.apache.kudu.client.KuduTable;
+import org.apache.kudu.client.PartialRow;
+import org.apache.kudu.test.KuduTestHarness;
+import org.apache.nifi.lookup.LookupFailureException;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.serialization.record.Record;
+import org.apache.nifi.util.TestRunner;
+import org.apache.nifi.util.TestRunners;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+
+import java.sql.Timestamp;
+import java.util.ArrayList;
+import java.util.Base64;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+
+public class TestKuduLookupService {
+
+// The KuduTestHarness automatically starts and stops a real Kudu cluster
+// when each test is run. Kudu persists its on-disk state in a temporary
+// directory under a location defined by the environment variable 
TEST_TMPDIR
+// if set, or under /tmp otherwise. That cluster data is deleted on
+// successful exit of the test. The cluster output is logged through slf4j.
+@Rule
+public KuduTestHarness harness = new KuduTestHarness();
+private TestRunner testRunner;
+private long nowMillis = System.currentTimeMillis();
+private KuduLookupService kuduLookupService;
+
+public static class SampleProcessor extends AbstractProcessor {
+@Override
+public void onTrigger(ProcessContext context, ProcessSession session) 
throws ProcessException {
+}
+}
+
+@Before
+public void init() throws Exception {
+testRunner = TestRunners.newTestRunner(SampleProcessor.class);
+testRunner.setValidateExpressionUsage(false);
+final String tableName = "table1";
+
+KuduClient client =  harness.getClient();
+List columns = new ArrayList<>();
+columns.add(new ColumnSchema.ColumnSchemaBuilder("string", 
Type.STRING).key(true).build());
+columns.add(new ColumnSchema.ColumnSchemaBuilder("binary", 
Type.BINARY).build());
+columns.add(new ColumnSchema.ColumnSchemaBuilder("bool", 
Type.BOOL).build());
+//columns.add(new ColumnSchema.ColumnSchemaBuilder("decimal", 
Type.DECIMAL).build());
+columns.add(new ColumnSchema.ColumnSchemaBuilder("double", 
Type.DOUBLE).build());
+columns.add(new ColumnSchema.ColumnSchemaBuilder("float", 
Type.FLOAT).build());
+columns.add(new ColumnSchema.ColumnSchemaBuilder("int8", 
Type.INT8).build());
+columns.add(new ColumnSchema.ColumnSchemaBuilder("int16", 
Type.INT16).build());
+columns.add(new ColumnSchema.ColumnSchemaBuilder("int32", 
Type.INT32).build());
+columns.add(new ColumnSchema.ColumnSchemaBuilder("int64", 
Type.INT64).build());
+columns.add(new ColumnSchema.ColumnSchemaBuilder("unixtime_micros", 
Type.UNIXTIME_MICROS).build());
+Schema schema = new Schema(columns);
+
+CreateTableOptions opts = new 
CreateTableOptions().setRangePartitionColumns(Collections.singletonList("string"));
+client.createTable(tableName, schema, opts);
+
+KuduTable table = client.openTable(tableName);
+KuduSession session = client.newSession();
+
+Insert 

[jira] [Updated] (NIFI-6684) Add more property to Hive3ConnectionPool

2019-09-17 Thread jamescheng (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jamescheng updated NIFI-6684:
-
Attachment: PutHive3 enhance.png

> Add more property to Hive3ConnectionPool
> 
>
> Key: NIFI-6684
> URL: https://issues.apache.org/jira/browse/NIFI-6684
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: jamescheng
>Priority: Minor
> Attachments: PutHive3 enhance.png
>
>
> The Hive3ConnectionPool is similar with DBCPConnectionPool as both of them 
> are using DBCP BasicDataSource. However, Hive3ConnectionPool  doesn't provide 
> some properties of what DBCPConnectionPool  has. Such as "Minimum Idle 
> Connections", "Max Idle Connections", "Max Connection Lifetime", "Time 
> Between Eviction Runs", "Minimum Evictable Idle Time" and "Soft Minimum 
> Evictable Idle Time".
> This improvement is try to provide more properties for developer to set.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (NIFI-6684) Add more property to Hive3ConnectionPool

2019-09-17 Thread jamescheng (Jira)
jamescheng created NIFI-6684:


 Summary: Add more property to Hive3ConnectionPool
 Key: NIFI-6684
 URL: https://issues.apache.org/jira/browse/NIFI-6684
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Extensions
Reporter: jamescheng


The Hive3ConnectionPool is similar with DBCPConnectionPool as both of them are 
using DBCP BasicDataSource. However, Hive3ConnectionPool  doesn't provide some 
properties of what DBCPConnectionPool  has. Such as "Minimum Idle Connections", 
"Max Idle Connections", "Max Connection Lifetime", "Time Between Eviction 
Runs", "Minimum Evictable Idle Time" and "Soft Minimum Evictable Idle Time".

This improvement is try to provide more properties for developer to set.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [nifi] joewitt commented on issue #3670: Cache results from zookeeper when determining the leader

2019-09-17 Thread GitBox
joewitt commented on issue #3670: Cache results from zookeeper when determining 
the leader
URL: https://github.com/apache/nifi/pull/3670#issuecomment-532385265
 
 
   @markap14 i know Nathan has the ZK 3.5.5 PR out there.  We need this and 
that to be aligned.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (NIFI-6683) Per User Flow Layout

2019-09-17 Thread James Srinivasan (Jira)
James Srinivasan created NIFI-6683:
--

 Summary: Per User Flow Layout
 Key: NIFI-6683
 URL: https://issues.apache.org/jira/browse/NIFI-6683
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core UI
Affects Versions: 1.9.2
Reporter: James Srinivasan


Some users prefer vertical flows

Some users prefer horizontal flows

Some users prefer lawnmower pattern flows which may be horizontal or vertical

Some users have high resolution screens

Some users have low resolution screens

 

In each case, the flow functionality is the same; it is just laid out 
differently. Having flow layout customisable per user would be nice to have, 
although editing flows might be awkward.

---

Slack thread below:

 
[James S|https://app.slack.com/team/UFEQVV0N4]  [5 days 
ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568320079227300]
Any thoughts on allowing multiple users to have different layouts of the same 
flow? We seem to have a horizontal vs vertical religious divide!
 
!https://ca.slack-edge.com/T0L9SDNRZ-UM0E0EY5N-e75b7e48499b-48!
[Jeremy Dyer|https://app.slack.com/team/UM0E0EY5N]  [5 days 
ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568320674227400?thread_ts=1568320079.227300=C0L9VCD47]
Gotta ask. why?
 
!https://ca.slack-edge.com/T0L9SDNRZ-UM0E0EY5N-e75b7e48499b-48!
[Jeremy Dyer|https://app.slack.com/team/UM0E0EY5N]  [5 days 
ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568320693227600?thread_ts=1568320079.227300=C0L9VCD47]
See a problem? No. Curious why that would ever be needed. yes
 
!https://ca.slack-edge.com/T0L9SDNRZ-UDFGUQHEF-g5ab642737cc-48!
[Joe Witt|https://app.slack.com/team/UDFGUQHEF]  [5 days 
ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568323662228200?thread_ts=1568320079.227300=C0L9VCD47]
think of the layout as being like a language of communication
 
!https://ca.slack-edge.com/T0L9SDNRZ-UDFGUQHEF-g5ab642737cc-48!
[Joe Witt|https://app.slack.com/team/UDFGUQHEF]  [5 days 
ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568323699228400?thread_ts=1568320079.227300=C0L9VCD47]
it would be really complicated if the same actual flow was presented 
differently to different people - the point is to share this and come to 
understanding on the flow
 
!https://ca.slack-edge.com/T0L9SDNRZ-UDFGUQHEF-g5ab642737cc-48!
[Joe Witt|https://app.slack.com/team/UDFGUQHEF]  [5 days 
ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568323725228600?thread_ts=1568320079.227300=C0L9VCD47]
the location of components is part of the flow definition at this point
 
!https://ca.slack-edge.com/T0L9SDNRZ-UL1L9TMMK-g2f64e7f6e09-48!
[David Snyder|https://app.slack.com/team/UL1L9TMMK]  [4 days 
ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568381729229000?thread_ts=1568320079.227300=C0L9VCD47]
I am not the originator of this thread, but if you are interested in a 
potential use case I have often found myself wishing for an easier way to 
change the layout of flows. For example, I mostly work at my desk and have a 
really wide monitor and generally prefer a horizontal layout, but occasionally 
switch to a notebook at an airport or coffee shop, and find myself only being 
able to see a very small part of the flow where a vertical layout would fit 
much more on the screen. I could see if two people are working on the same 
flows and have different working environments that they might want different 
layouts of the same flow all the time.
 
!https://ca.slack-edge.com/T0L9SDNRZ-UFEQVV0N4-gc70a731d6b9-48!
[James S|https://app.slack.com/team/UFEQVV0N4]  [4 days 
ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568385605234200?thread_ts=1568320079.227300=C0L9VCD47]
Yes, we have some users with multiple 4k screens and some with a 720p laptop. 
We have some who strongly prefer right to left and some who strongly prefer top 
to bottom. So while the functionality of the flow is identical in each case, 
how it is visualised could vary. I don't know his editing the flow itself (Vs 
the layout) could work
 
!https://ca.slack-edge.com/T0L9SDNRZ-UM0E0EY5N-e75b7e48499b-48!
[Jeremy Dyer|https://app.slack.com/team/UM0E0EY5N]  [4 days 
ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568390342239400?thread_ts=1568320079.227300=C0L9VCD47]
I find ^^ interesting and James makes a good point there
 
!https://ca.slack-edge.com/T0L9SDNRZ-UDFGUQHEF-g5ab642737cc-48!
[Joe Witt|https://app.slack.com/team/UDFGUQHEF]  [1 day 
ago|https://apachenifi.slack.com/archives/C0L9VCD47/p1568661718012800?thread_ts=1568320079.227300=C0L9VCD47]
I suspect we could generate automatic 'views' of flows which provide read-only 
vertical or horizontally weighted visualizations
 
!https://ca.slack-edge.com/T0L9SDNRZ-UDFGUQHEF-g5ab642737cc-48!
[Joe Witt|https://app.slack.com/team/UDFGUQHEF]  [1 day 

[jira] [Updated] (NIFI-6620) FDS - Doc for sidenav in webapp has to be updated

2019-09-17 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-6620:
--
Fix Version/s: fds-0.3

> FDS - Doc for sidenav in webapp has to be updated
> -
>
> Key: NIFI-6620
> URL: https://issues.apache.org/jira/browse/NIFI-6620
> Project: Apache NiFi
>  Issue Type: Task
>  Components: FDS
>Reporter: András Kovács
>Priority: Minor
>  Labels: pull-request-available
> Fix For: fds-0.3
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> 
> align is no more a valid attribute
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (NIFI-6453) Support building nifi-fds on Windows

2019-09-17 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-6453:
--
Fix Version/s: fds-0.3

> Support building nifi-fds on Windows
> 
>
> Key: NIFI-6453
> URL: https://issues.apache.org/jira/browse/NIFI-6453
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: FDS
>Reporter: Robert Fellows
>Assignee: Robert Fellows
>Priority: Major
> Fix For: fds-0.3
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> The current build architecture depends on bash scripts, preventing it from 
> being run on Windows systems (without cygwin). The goal would be to make it 
> os-agnostic.
> One potential approach would be to leverage node.js for the pieces that 
> currently require a bash script. This includes things like:
> * copying files (can use [rimraf|https://www.npmjs.com/package/rimraf])
> * creating directories (can use [mkdirp|https://www.npmjs.com/package/mkdirp])



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (NIFI-6620) FDS - Doc for sidenav in webapp has to be updated

2019-09-17 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-6620:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> FDS - Doc for sidenav in webapp has to be updated
> -
>
> Key: NIFI-6620
> URL: https://issues.apache.org/jira/browse/NIFI-6620
> Project: Apache NiFi
>  Issue Type: Task
>  Components: FDS
>Reporter: András Kovács
>Priority: Minor
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> 
> align is no more a valid attribute
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (NIFI-6453) Support building nifi-fds on Windows

2019-09-17 Thread Scott Aslan (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-6453:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Support building nifi-fds on Windows
> 
>
> Key: NIFI-6453
> URL: https://issues.apache.org/jira/browse/NIFI-6453
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: FDS
>Reporter: Robert Fellows
>Assignee: Robert Fellows
>Priority: Major
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> The current build architecture depends on bash scripts, preventing it from 
> being run on Windows systems (without cygwin). The goal would be to make it 
> os-agnostic.
> One potential approach would be to leverage node.js for the pieces that 
> currently require a bash script. This includes things like:
> * copying files (can use [rimraf|https://www.npmjs.com/package/rimraf])
> * creating directories (can use [mkdirp|https://www.npmjs.com/package/mkdirp])



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [nifi-fds] scottyaslan commented on issue #55: [NIFI-6620] Doc for sidenav in webapp updated

2019-09-17 Thread GitBox
scottyaslan commented on issue #55: [NIFI-6620] Doc for sidenav in webapp 
updated
URL: https://github.com/apache/nifi-fds/pull/55#issuecomment-532369808
 
 
   Thanks @elcsiga this has been merged to master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-fds] scottyaslan commented on issue #54: NIFI-6453 - OS agnostic build scripts

2019-09-17 Thread GitBox
scottyaslan commented on issue #54: NIFI-6453 - OS agnostic build scripts
URL: https://github.com/apache/nifi-fds/pull/54#issuecomment-532369472
 
 
   Thanks @rfellows this has been merged to master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-fds] asfgit closed pull request #54: NIFI-6453 - OS agnostic build scripts

2019-09-17 Thread GitBox
asfgit closed pull request #54: NIFI-6453 - OS agnostic build scripts
URL: https://github.com/apache/nifi-fds/pull/54
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-fds] scottyaslan commented on issue #54: NIFI-6453 - OS agnostic build scripts

2019-09-17 Thread GitBox
scottyaslan commented on issue #54: NIFI-6453 - OS agnostic build scripts
URL: https://github.com/apache/nifi-fds/pull/54#issuecomment-53234
 
 
   Reviewing...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-fds] asfgit closed pull request #55: [NIFI-6620] Doc for sidenav in webapp updated

2019-09-17 Thread GitBox
asfgit closed pull request #55: [NIFI-6620] Doc for sidenav in webapp updated
URL: https://github.com/apache/nifi-fds/pull/55
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (NIFI-6682) SplitJson does not work if the input is null

2019-09-17 Thread Joseph Witt (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931750#comment-16931750
 ] 

Joseph Witt commented on NIFI-6682:
---

fix version can be applied once there is a PR and review traction.  thanks

> SplitJson does not work if the input is null 
> -
>
> Key: NIFI-6682
> URL: https://issues.apache.org/jira/browse/NIFI-6682
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.9.2
>Reporter: Frank Chen
>Priority: Major
> Attachments: image-2019-09-17-18-18-19-860.png, 
> image-2019-09-17-18-33-33-708.png
>
>
> When the input is null, the SplitJson processor should output to failure 
> route  rather than report error.As a result, the flowfile is not processed in 
> the queue all the time.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (NIFI-6682) SplitJson does not work if the input is null

2019-09-17 Thread Joseph Witt (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Witt updated NIFI-6682:
--
Fix Version/s: (was: 1.10.0)

> SplitJson does not work if the input is null 
> -
>
> Key: NIFI-6682
> URL: https://issues.apache.org/jira/browse/NIFI-6682
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.9.2
>Reporter: Frank Chen
>Priority: Major
> Attachments: image-2019-09-17-18-18-19-860.png, 
> image-2019-09-17-18-33-33-708.png
>
>
> When the input is null, the SplitJson processor should output to failure 
> route  rather than report error.As a result, the flowfile is not processed in 
> the queue all the time.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [nifi] belugabehr commented on issue #3643: NIFI-6542: Upgrade nifi-hadoop-bundles Hadoop version dependency to 3…

2019-09-17 Thread GitBox
belugabehr commented on issue #3643: NIFI-6542: Upgrade nifi-hadoop-bundles 
Hadoop version dependency to 3…
URL: https://github.com/apache/nifi/pull/3643#issuecomment-532352646
 
 
   @tpalfy Can you please help kick off the CI tests again?  Seems like they 
failed due to a network error.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-fds] scottyaslan commented on issue #55: [NIFI-6620] Doc for sidenav in webapp updated

2019-09-17 Thread GitBox
scottyaslan commented on issue #55: [NIFI-6620] Doc for sidenav in webapp 
updated
URL: https://github.com/apache/nifi-fds/pull/55#issuecomment-532327567
 
 
   Reviewing...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Reopened] (NIFI-6558) Add documentation for Parameters

2019-09-17 Thread Andrew Lim (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Lim reopened NIFI-6558:
--

The "Parameters and Versioned Flows" section can be made clearer. Will add an 
example/screenshots to make it more readable/understandable.

> Add documentation for Parameters
> 
>
> Key: NIFI-6558
> URL: https://issues.apache.org/jira/browse/NIFI-6558
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Documentation  Website
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Major
> Fix For: 1.10.0
>
>  Time Spent: 5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [nifi] mcgilman commented on issue #3725: NIFI-6558 Added Parameters to User Guide and Sys Admin Guide

2019-09-17 Thread GitBox
mcgilman commented on issue #3725: NIFI-6558 Added Parameters to User Guide and 
Sys Admin Guide
URL: https://github.com/apache/nifi/pull/3725#issuecomment-532289668
 
 
   Thanks @andrewmlim! This has been merged to master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (NIFI-6558) Add documentation for Parameters

2019-09-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931602#comment-16931602
 ] 

ASF subversion and git services commented on NIFI-6558:
---

Commit a1b02ec1137025858239e821d5db0c249b92ff45 in nifi's branch 
refs/heads/master from Andrew Lim
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a1b02ec ]

NIFI-6558 Added Parameters to User Guide and Sys Admin Guide
NIFI-6558 Edited/Improved new Parameters Context

This closes #3725


> Add documentation for Parameters
> 
>
> Key: NIFI-6558
> URL: https://issues.apache.org/jira/browse/NIFI-6558
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Documentation  Website
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Major
>  Time Spent: 4h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Resolved] (NIFI-6558) Add documentation for Parameters

2019-09-17 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman resolved NIFI-6558.
---
Fix Version/s: 1.10.0
   Resolution: Fixed

> Add documentation for Parameters
> 
>
> Key: NIFI-6558
> URL: https://issues.apache.org/jira/browse/NIFI-6558
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Documentation  Website
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Major
> Fix For: 1.10.0
>
>  Time Spent: 5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (NIFI-6558) Add documentation for Parameters

2019-09-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-6558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931603#comment-16931603
 ] 

ASF subversion and git services commented on NIFI-6558:
---

Commit a1b02ec1137025858239e821d5db0c249b92ff45 in nifi's branch 
refs/heads/master from Andrew Lim
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a1b02ec ]

NIFI-6558 Added Parameters to User Guide and Sys Admin Guide
NIFI-6558 Edited/Improved new Parameters Context

This closes #3725


> Add documentation for Parameters
> 
>
> Key: NIFI-6558
> URL: https://issues.apache.org/jira/browse/NIFI-6558
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Documentation  Website
>Reporter: Andrew Lim
>Assignee: Andrew Lim
>Priority: Major
>  Time Spent: 4h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [nifi] asfgit closed pull request #3725: NIFI-6558 Added Parameters to User Guide and Sys Admin Guide

2019-09-17 Thread GitBox
asfgit closed pull request #3725: NIFI-6558 Added Parameters to User Guide and 
Sys Admin Guide
URL: https://github.com/apache/nifi/pull/3725
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #646: MINIFICPP-1031 - RemoteProcessorGroupPort::setURL fails in case port …

2019-09-17 Thread GitBox
arpadboda closed pull request #646: MINIFICPP-1031 - 
RemoteProcessorGroupPort::setURL fails in case port …
URL: https://github.com/apache/nifi-minifi-cpp/pull/646
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (MINIFICPP-1032) utils::parse_url should be refactored

2019-09-17 Thread Arpad Boda (Jira)
Arpad Boda created MINIFICPP-1032:
-

 Summary: utils::parse_url should be refactored
 Key: MINIFICPP-1032
 URL: https://issues.apache.org/jira/browse/MINIFICPP-1032
 Project: Apache NiFi MiNiFi C++
  Issue Type: Improvement
Affects Versions: 0.6.0
Reporter: Arpad Boda
Assignee: Arpad Boda
 Fix For: 1.0.0


The function leaves a lot of space for improvements:

-No pointers should be used, but references

-Should either throw excpetion or indicate success in return value

-Usages should be refactored as well to take unsuccessful cases into 
consideration

Scoped for 1.0 as it breaks API. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #646: MINIFICPP-1031 - RemoteProcessorGroupPort::setURL fails in case port …

2019-09-17 Thread GitBox
arpadboda commented on a change in pull request #646: MINIFICPP-1031 - 
RemoteProcessorGroupPort::setURL fails in case port …
URL: https://github.com/apache/nifi-minifi-cpp/pull/646#discussion_r325198639
 
 

 ##
 File path: libminifi/include/RemoteProcessorGroupPort.h
 ##
 @@ -146,7 +146,7 @@ class RemoteProcessorGroupPort : public core::Processor {
 for (auto url : urls) {
   logger_->log_trace("Parsing %s", url);
   std::string host, protocol;
-  int port;
+  int port = -1;
 
 Review comment:
   Sure, created:
   https://issues.apache.org/jira/browse/MINIFICPP-1032


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #646: MINIFICPP-1031 - RemoteProcessorGroupPort::setURL fails in case port …

2019-09-17 Thread GitBox
bakaid commented on a change in pull request #646: MINIFICPP-1031 - 
RemoteProcessorGroupPort::setURL fails in case port …
URL: https://github.com/apache/nifi-minifi-cpp/pull/646#discussion_r325196326
 
 

 ##
 File path: libminifi/include/RemoteProcessorGroupPort.h
 ##
 @@ -146,7 +146,7 @@ class RemoteProcessorGroupPort : public core::Processor {
 for (auto url : urls) {
   logger_->log_trace("Parsing %s", url);
   std::string host, protocol;
-  int port;
+  int port = -1;
 
 Review comment:
   Thanks for the explanation, I agree that this was the better choice in this 
case. Do you think you could create a follow-up task to refactor this part when 
we get the chance?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #646: MINIFICPP-1031 - RemoteProcessorGroupPort::setURL fails in case port …

2019-09-17 Thread GitBox
arpadboda commented on a change in pull request #646: MINIFICPP-1031 - 
RemoteProcessorGroupPort::setURL fails in case port …
URL: https://github.com/apache/nifi-minifi-cpp/pull/646#discussion_r325195183
 
 

 ##
 File path: libminifi/include/RemoteProcessorGroupPort.h
 ##
 @@ -146,7 +146,7 @@ class RemoteProcessorGroupPort : public core::Processor {
 for (auto url : urls) {
   logger_->log_trace("Parsing %s", url);
   std::string host, protocol;
-  int port;
+  int port = -1;
 
 Review comment:
   In case the protocol is nor http neither https (but it's specified) 
parse_util fails, both host and protocol remains empty. 
   Not nice, I would also prefer an exception to be thrown, but that would 
break this API, so I didn't change it. 
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (NIFI-6677) ListHDFS can clear state and re-list everything on Primary Node change if property was modified before Processor started

2019-09-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931486#comment-16931486
 ] 

ASF subversion and git services commented on NIFI-6677:
---

Commit fd3f0707c66b78622ed4e7f5aeaff63580c46d44 in nifi's branch 
refs/heads/master from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=fd3f070 ]

NIFI-6677: Update ListHDFS to clear state (when appropriate) in an @OnScheduled 
method, just as AbstractListProcessor does, instead of doing it in onTrigger. 
Doing it in onTrigger is problematic because in a cluster, the Primary Node may 
run for some period of time, perhaps days or months. Then, when the Primary 
Node chagnes, onTrigger gets called for the first time on the new Primary Node, 
and this triggers the processor to clear state.


> ListHDFS can clear state and re-list everything on Primary Node change if 
> property was modified before Processor started
> 
>
> Key: NIFI-6677
> URL: https://issues.apache.org/jira/browse/NIFI-6677
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.10.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> If the "Directory" or "File Filter" property is changed in ListHDFS, and then 
> the Processor is started, a change in the Primary Node can result in 
> resetting the Processor state.
> To replicate, create a ListHDFS Processor in a cluster. Configure to point to 
> some directory and start the processor running on Primary Node. After the 
> listing has completed, disconnect the Primary Node from the cluster to 
> trigger the Primary Node to change. At this point, the Processor will reset 
> its state and re-list everything.
> Note that once NiFi has been restarted, this behavior will no longer exist 
> until the Processor's Directory or "File Filter" property is changed again. 
> It also will not happen again if the new Primary Node has already reset the 
> state as a result of the property change.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (NIFI-6677) ListHDFS can clear state and re-list everything on Primary Node change if property was modified before Processor started

2019-09-17 Thread Bryan Bende (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Bende updated NIFI-6677:
--
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> ListHDFS can clear state and re-list everything on Primary Node change if 
> property was modified before Processor started
> 
>
> Key: NIFI-6677
> URL: https://issues.apache.org/jira/browse/NIFI-6677
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.10.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> If the "Directory" or "File Filter" property is changed in ListHDFS, and then 
> the Processor is started, a change in the Primary Node can result in 
> resetting the Processor state.
> To replicate, create a ListHDFS Processor in a cluster. Configure to point to 
> some directory and start the processor running on Primary Node. After the 
> listing has completed, disconnect the Primary Node from the cluster to 
> trigger the Primary Node to change. At this point, the Processor will reset 
> its state and re-list everything.
> Note that once NiFi has been restarted, this behavior will no longer exist 
> until the Processor's Directory or "File Filter" property is changed again. 
> It also will not happen again if the new Primary Node has already reset the 
> state as a result of the property change.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [nifi] bbende merged pull request #3743: NIFI-6677: Update ListHDFS to clear state (when appropriate) in an @O…

2019-09-17 Thread GitBox
bbende merged pull request #3743: NIFI-6677: Update ListHDFS to clear state 
(when appropriate) in an @O…
URL: https://github.com/apache/nifi/pull/3743
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi] bbende commented on issue #3743: NIFI-6677: Update ListHDFS to clear state (when appropriate) in an @O…

2019-09-17 Thread GitBox
bbende commented on issue #3743: NIFI-6677: Update ListHDFS to clear state 
(when appropriate) in an @O…
URL: https://github.com/apache/nifi/pull/3743#issuecomment-532234827
 
 
   Looks good, will merge


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #646: MINIFICPP-1031 - RemoteProcessorGroupPort::setURL fails in case port …

2019-09-17 Thread GitBox
bakaid commented on a change in pull request #646: MINIFICPP-1031 - 
RemoteProcessorGroupPort::setURL fails in case port …
URL: https://github.com/apache/nifi-minifi-cpp/pull/646#discussion_r325180604
 
 

 ##
 File path: libminifi/include/RemoteProcessorGroupPort.h
 ##
 @@ -146,7 +146,7 @@ class RemoteProcessorGroupPort : public core::Processor {
 for (auto url : urls) {
   logger_->log_trace("Parsing %s", url);
   std::string host, protocol;
-  int port;
+  int port = -1;
 
 Review comment:
   Nice catch!
   
   I wonder what happens if the input is really messed up and the protocol is 
not http or https. We would add an RPG to nifi_instances_ with a port of -1. Is 
that handled somewhere else?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [nifi-minifi-cpp] arpadboda opened a new pull request #646: MINIFICPP-1031 - RemoteProcessorGroupPort::setURL fails in case port …

2019-09-17 Thread GitBox
arpadboda opened a new pull request #646: MINIFICPP-1031 - 
RemoteProcessorGroupPort::setURL fails in case port …
URL: https://github.com/apache/nifi-minifi-cpp/pull/646
 
 
   …is not specified in URL
   
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (NIFI-6633) Allow user to copy a parameter context

2019-09-17 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-6633:
--
Parent: (was: NIFI-6276)
Issue Type: New Feature  (was: Sub-task)

> Allow user to copy a parameter context
> --
>
> Key: NIFI-6633
> URL: https://issues.apache.org/jira/browse/NIFI-6633
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core UI
>Reporter: Robert Fellows
>Priority: Major
>
> It would be nice to be able to copy/duplicate an existing parameter context.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (NIFI-6635) Allow users the ability to create parameters from existing variables

2019-09-17 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-6635:
--
Parent: (was: NIFI-6276)
Issue Type: New Feature  (was: Sub-task)

> Allow users the ability to create parameters from existing variables
> 
>
> Key: NIFI-6635
> URL: https://issues.apache.org/jira/browse/NIFI-6635
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core UI
>Reporter: Robert Fellows
>Priority: Major
>
> As variables are being deprecated in favor of parameters, it would be very 
> beneficial to provide something to ease the migration. Letting users create 
> parameters for all existing variables would be a huge efficiency gain.
> Possibly add a button on the Variables dialog that would just create 
> parameters named the same as the variables with the value and assign them to 
> the current parameter context.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (NIFI-6631) Add tooltip to Property Configuration dialog that shows fully resolved property values

2019-09-17 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-6631:
--
Parent: (was: NIFI-6276)
Issue Type: Improvement  (was: Sub-task)

> Add tooltip to Property Configuration dialog that shows fully resolved 
> property values
> --
>
> Key: NIFI-6631
> URL: https://issues.apache.org/jira/browse/NIFI-6631
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Mark Payne
>Priority: Major
>
> When a Processor or Controller Service is configured with a Parameter, it can 
> be difficult to understand exactly how the component is configured, because 
> the values for some properties have been externalized. It would be great to 
> have some way to see the fully resolved property value. For example, if a 
> property is set to "Hello #\{name}" and the `name` parameter is set to `John 
> Doe`, I would like to have a way to see that the property value will be 
> resolved to "Hello John Doe". This could be shown as a tooltip when hovering 
> over the property value, perhaps (which currently just shows the currently 
> configured value "Hello #\{name}"). Or it may make more sense to show it when 
> hovering over the "?" help icon for the Property, where we show things like 
> Historical values, Default value, etc.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Updated] (NIFI-6505) Allow parameter contexts to be bound to the controller

2019-09-17 Thread Matt Gilman (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-6505:
--
Parent: (was: NIFI-6276)
Issue Type: New Feature  (was: Sub-task)

> Allow parameter contexts to be bound to the controller
> --
>
> Key: NIFI-6505
> URL: https://issues.apache.org/jira/browse/NIFI-6505
> Project: Apache NiFi
>  Issue Type: New Feature
>  Components: Core Framework, Core UI
>Reporter: Matt Gilman
>Priority: Major
>
> We should allow parameter contexts to be bound at the controller level. This 
> will allow parameters to be referenced in reporting tasks and controller 
> services that support them.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (MINIFICPP-1031) RemoteProcessorGroupPort::setURL fails in case port is not specified in URL.

2019-09-17 Thread Arpad Boda (Jira)
Arpad Boda created MINIFICPP-1031:
-

 Summary: RemoteProcessorGroupPort::setURL fails in case port is 
not specified in URL.
 Key: MINIFICPP-1031
 URL: https://issues.apache.org/jira/browse/MINIFICPP-1031
 Project: Apache NiFi MiNiFi C++
  Issue Type: Bug
Affects Versions: 0.6.0
Reporter: Arpad Boda
Assignee: Arpad Boda
 Fix For: 0.7.0


Found by valgrind:
{code:java}
==19410== Conditional jump or move depends on uninitialised value(s)
==19410==    at 0x2D5123: 
org::apache::nifi::minifi::RemoteProcessorGroupPort::setURL(std::__cxx11::basic_string, std::allocator >) 
(RemoteProcessorGroupPort.h:153)
==19410==    by 0x2E015B: RemoteProcessorGroupPort 
(RemoteProcessorGroupPort.h:97) {code}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #613: Minificpp 927 Nanofi tailfile delimited processor

2019-09-17 Thread GitBox
arpadboda commented on a change in pull request #613: Minificpp 927 Nanofi 
tailfile delimited processor
URL: https://github.com/apache/nifi-minifi-cpp/pull/613#discussion_r325134041
 
 

 ##
 File path: nanofi/ecu/tailfile_delimited.c
 ##
 @@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+*/
+
+#include "api/ecu.h"
+#include "core/flowfiles.h"
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+int main(int argc, char** argv) {
+
+if (argc < 7) {
+printf("Error: must run ./tailfile_delimited   
   \n");
+exit(1);
+}
+
+tailfile_input_params input_params = init_logaggregate_input(argv);
+
+uint64_t intrvl = 0;
+uint64_t port_num = 0;
+if (validate_input_params(_params, , _num) < 0) {
+return 1;
+}
+
+setup_signal_action();
+nifi_proc_params params = setup_nifi_processor(_params, 
"TailFileDelimited", on_trigger_tailfiledelimited);
+
+set_standalone_property(params.processor, "file_path", input_params.file);
+set_standalone_property(params.processor, "delimiter", 
input_params.delimiter);
+
+struct CRawSiteToSiteClient * client = createClient(input_params.instance, 
port_num, input_params.nifi_port_uuid);
+
+char uuid_str[37];
+get_proc_uuid_from_processor(params.processor, uuid_str);
+
+while (!stopped) {
+flow_file_record * new_ff = invoke(params.processor);
+struct processor_params * pp = NULL;
+HASH_FIND_STR(procparams, uuid_str, pp);
+if (pp) {
+transmit_payload(client, pp->ff_list, 1);
+delete_completed_flow_files_from_proc(uuid_str);
 
 Review comment:
   According to valgrind we leak really a **lot** here:
   
   ```
   ==19410== 26,335 (2,640 direct, 23,695 indirect) bytes in 55 blocks are 
definitely lost in loss record 114 of 114
   ==19410==at 0x4C3017F: operator new(unsigned long) (in 
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
   ==19410==by 0x2BE628: create_ff_object_nc (nanofi.cpp:272)
   ==19410==by 0x2C3543: generate_flow (nanofi.cpp:277)
   ==19410==by 0x2BD825: on_trigger_tailfiledelimited (ecu.c:503)
   ==19410==by 0x2EBAC1: operator() (std_function.h:706)
   ==19410==by 0x2EBAC1: 
org::apache::nifi::minifi::processors::CallbackProcessor::onTrigger(org::apache::nifi::minifi::core::ProcessContext*,
 org::apache::nifi::minifi::core::ProcessSession*) (CallbackProcessor.cpp:44)
   ==19410==by 0x2F21CE: ExecutionPlan::runNextProcessor(std::function, 
std::shared_ptr)>, 
std::shared_ptr) (Plan.cpp:183)
   ==19410==by 0x2C22E9: invoke_ff (nanofi.cpp:705)
   ==19410==by 0x2A72F4: main (tailfile_delimited.c:56)
   ```
   
   Could you investigate this before mering? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (NIFI-6681) NIFI PutHbaseRecord

2019-09-17 Thread Amogh (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-6681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amogh updated NIFI-6681:

Attachment: Hbase.PNG
CSVReader.PNG
Conf.PNG

> NIFI PutHbaseRecord
> ---
>
> Key: NIFI-6681
> URL: https://issues.apache.org/jira/browse/NIFI-6681
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Flow Versioning
>Affects Versions: 1.8.0
> Environment: Linux
>Reporter: Amogh
>Priority: Minor
> Attachments: CSVReader.PNG, Conf.PNG, Error.png, Hbase.PNG
>
>
> Hi All,
>  
> I am getting below error while loading a data hbase from nifi, Even though 
> the column is not null data is not loading and i'm getting the error



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (NIFI-6681) NIFI PutHbaseRecord

2019-09-17 Thread Amogh (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-6681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931334#comment-16931334
 ] 

Amogh commented on NIFI-6681:
-

Hi Shawn

 

We are using CDH6.0 

Linux redhate machine(Version 7)

Please find the attached flow file[link title|http://example.com] !Conf.PNG!

 

> NIFI PutHbaseRecord
> ---
>
> Key: NIFI-6681
> URL: https://issues.apache.org/jira/browse/NIFI-6681
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Flow Versioning
>Affects Versions: 1.8.0
> Environment: Linux
>Reporter: Amogh
>Priority: Minor
> Attachments: CSVReader.PNG, Conf.PNG, Error.png, Hbase.PNG
>
>
> Hi All,
>  
> I am getting below error while loading a data hbase from nifi, Even though 
> the column is not null data is not loading and i'm getting the error



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (NIFI-6681) NIFI PutHbaseRecord

2019-09-17 Thread Shawn Weeks (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-6681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931327#comment-16931327
 ] 

Shawn Weeks commented on NIFI-6681:
---

Can you share a screenshot of the contents of the flow file and your processor 
configuration. Thanks

> NIFI PutHbaseRecord
> ---
>
> Key: NIFI-6681
> URL: https://issues.apache.org/jira/browse/NIFI-6681
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Flow Versioning
>Affects Versions: 1.8.0
> Environment: Linux
>Reporter: Amogh
>Priority: Minor
> Attachments: Error.png
>
>
> Hi All,
>  
> I am getting below error while loading a data hbase from nifi, Even though 
> the column is not null data is not loading and i'm getting the error



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (NIFI-6682) SplitJson does not work if the input is null

2019-09-17 Thread Frank Chen (Jira)
Frank Chen created NIFI-6682:


 Summary: SplitJson does not work if the input is null 
 Key: NIFI-6682
 URL: https://issues.apache.org/jira/browse/NIFI-6682
 Project: Apache NiFi
  Issue Type: Bug
  Components: Extensions
Affects Versions: 1.9.2
Reporter: Frank Chen
 Fix For: 1.10.0
 Attachments: image-2019-09-17-18-18-19-860.png, 
image-2019-09-17-18-33-33-708.png

When the input is null, the SplitJson processor should output to failure route  
rather than report error.As a result, the flowfile is not processed in the 
queue all the time.

 

 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (NIFI-6665) NiFi toolkit bind issue with cli.bat file

2019-09-17 Thread Sridhar (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-6665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931178#comment-16931178
 ] 

Sridhar commented on NIFI-6665:
---

Its : java version "1.8.0_221"

> NiFi toolkit bind issue with cli.bat file
> -
>
> Key: NIFI-6665
> URL: https://issues.apache.org/jira/browse/NIFI-6665
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Tools and Build
>Affects Versions: 1.8.0, 1.9.2
>Reporter: Sridhar
>Priority: Critical
>
> When any cli command executed with cli.bat file ( like list bucket in 
> registry etc..) Exception comes with like " class not found"
> Issue is with line : 
> *SET JAVA_PARAMS=-cp %LIB_DIR%\* %JAVA_OPTS% 
> org.apache.nifi.toolkit.cli.CLIMain*
> please make change above  in cli.bat file as below.
> *SET JAVA_PARAMS=-cp %LIB_DIR%\* %JAVA_OPTS% --add-modules=java.xml.bind 
> org.apache.nifi.toolkit.cli.CLIMain*



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Created] (NIFI-6681) NIFI PutHbaseRecord

2019-09-17 Thread Amogh (Jira)
Amogh created NIFI-6681:
---

 Summary: NIFI PutHbaseRecord
 Key: NIFI-6681
 URL: https://issues.apache.org/jira/browse/NIFI-6681
 Project: Apache NiFi
  Issue Type: Bug
  Components: Flow Versioning
Affects Versions: 1.8.0
 Environment: Linux
Reporter: Amogh
 Attachments: Error.png

Hi All,

 

I am getting below error while loading a data hbase from nifi, Even though the 
column is not null data is not loading and i'm getting the error



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [nifi] faizfizy opened a new pull request #3745: Fix syntax error in schema example

2019-09-17 Thread GitBox
faizfizy opened a new pull request #3745: Fix syntax error in schema example
URL: https://github.com/apache/nifi/pull/3745
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services