[GitHub] [nifi] kevdoran commented on pull request #5475: NIFI-830 For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL
kevdoran commented on pull request #5475: URL: https://github.com/apache/nifi/pull/5475#issuecomment-959182309 @ottobackwards my understanding is that the `invokehttp.request|response.url` attributes contain the full url, where as the new filename attribute is just the leaf of the path, correct? ie ``` invokehttp.request.url = https://example.com/path/to/my-file.txt filename = my-file.txt ``` In this case, we are only deciding if that file name should be url encoded, e.g., `filename%20with%20spaces%20and%2Fslashes.txt` or `filename with spaces and/slashes.txt` I think we can make an argument for either approach. Where backward compatibility comes into play is thinking about existing flows and assumptions they may make about the filename attribute. For example: ``` InvokeHTTP >> PutS3 ``` Currently, the filename used for S3 object key will be the flowfile UUID. This PR will change that to be the filename, which if it is url encoded will still work with PutS3, but if it is decoded will break if the filename contains special characters such as `/`. For this reason, I vote leaving filename url encoded in InvokeHTTP, but I don't feel strongly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1188: MINIFICPP-1651: Added DefragmentText processor
szaszm closed pull request #1188: URL: https://github.com/apache/nifi-minifi-cpp/pull/1188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #5380: NIFI-9202 Improve Allowable Values merging to handle cases when different nodes have different set of Allowable Values
mattyb149 commented on pull request #5380: URL: https://github.com/apache/nifi/pull/5380#issuecomment-959844316 +1 LGTM, tested on a 3-node secure cluster with 1 node running Java 11 and 2 nodes running Java 8, verified the MonitorMemory Reporting Task contained the correct options for each type of node. Thanks for the fix! Merging to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] ottobackwards merged pull request #5501: NIFI-9349 - add attribute with request duration in InvokeHTTP
ottobackwards merged pull request #5501: URL: https://github.com/apache/nifi/pull/5501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] timeabarna commented on pull request #5303: NIFI-8677 Add custom endpoint suffix for Azure EventHub Processors
timeabarna commented on pull request #5303: URL: https://github.com/apache/nifi/pull/5303#issuecomment-958821250 @jfrazee Hello Joey, can you please check this PR when you have some time? Thanks in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] tpalfy commented on a change in pull request #5088: NIFI-3320: SendTrapSNMP and ListenTrapSNMP processors added.
tpalfy commented on a change in pull request #5088:
URL: https://github.com/apache/nifi/pull/5088#discussion_r741980742
##
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/GetSNMP.java
##
@@ -134,59 +144,96 @@
REL_FAILURE
)));
+private volatile GetSNMPHandler snmpHandler;
+
+@OnScheduled
+public void init(final ProcessContext context) {
+initSnmpManager(context);
+snmpHandler = new GetSNMPHandler(snmpResourceHandler);
+}
+
@Override
public void onTrigger(final ProcessContext context, final ProcessSession
processSession) {
final SNMPStrategy snmpStrategy =
SNMPStrategy.valueOf(context.getProperty(SNMP_STRATEGY).getValue());
final String oid = context.getProperty(OID).getValue();
+final FlowFile flowfile = processSession.get();
if (SNMPStrategy.GET == snmpStrategy) {
-performSnmpGet(context, processSession, oid);
+performSnmpGet(context, processSession, oid, flowfile);
} else if (SNMPStrategy.WALK == snmpStrategy) {
-performSnmpWalk(context, processSession, oid);
+performSnmpWalk(context, processSession, oid, flowfile);
}
}
-private void performSnmpWalk(final ProcessContext context, final
ProcessSession processSession, final String oid) {
+void performSnmpWalk(final ProcessContext context, final ProcessSession
processSession, final String oid,
+ final FlowFile flowFile) {
+final Optional incomingFlowFile =
Optional.ofNullable(flowFile);
+Map flowFileAttributes =
incomingFlowFile.map(FlowFile::getAttributes).orElse(Collections.emptyMap());
try {
-final SNMPTreeResponse response = snmpRequestHandler.walk(oid);
-response.logErrors(getLogger());
-FlowFile flowFile =
createFlowFileWithTreeEventProperties(response, processSession);
-processSession.getProvenanceReporter().receive(flowFile,
response.getTargetAddress() + "/" + oid);
-processSession.transfer(flowFile, REL_SUCCESS);
+final Optional optionalResponse =
snmpHandler.walk(oid, flowFileAttributes);
+if (optionalResponse.isPresent()) {
+incomingFlowFile.ifPresent(processSession::remove);
+final SNMPTreeResponse response = optionalResponse.get();
+response.logErrors(getLogger());
+FlowFile outgoingFlowFile =
createFlowFileWithTreeEventProperties(response, processSession);
+
processSession.getProvenanceReporter().receive(outgoingFlowFile,
response.getTargetAddress() + "/walk");
+processSession.transfer(outgoingFlowFile, REL_SUCCESS);
+} else {
+getLogger().warn("No SNMP specific attributes found in
flowfile.");
+incomingFlowFile.ifPresent(ff -> processSession.transfer(ff,
REL_SUCCESS));
Review comment:
Shouldn't go to failure instead of success in this case?
##
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/properties/V1TrapProperties.java
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.snmp.processors.properties;
+
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import static
org.apache.nifi.snmp.processors.properties.BasicProperties.SNMP_V1;
+import static
org.apache.nifi.snmp.processors.properties.BasicProperties.SNMP_VERSION;
+
+
+public class V1TrapProperties {
+
+private V1TrapProperties() {
+// Utility class, not needed to instantiate.
+}
+
+private static final AllowableValue GENERIC_TRAP_TYPE_COLD_START = new
AllowableValue("0", "Cold Start",
+"A coldStart trap signifies that the sending protocol entity is
reinitializing itself such that" +
+" the agent's configuration or the protocol
[GitHub] [nifi] ottobackwards commented on pull request #5475: NIFI-830 For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL
ottobackwards commented on pull request #5475: URL: https://github.com/apache/nifi/pull/5475#issuecomment-959812422 I don't feel strongly enough to object. Leaving it encoded is simplest, and users can still fix it up later if they want. As long as it is documented as being encoded I'm OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1168: MINIFICPP-1632 - Implement RouteText processor
szaszm closed pull request #1168: URL: https://github.com/apache/nifi-minifi-cpp/pull/1168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] QCU87Z commented on pull request #5413: NIFI-8676 Added 'Tracking Entities' listing strategy to 'ListS3' and 'ListGCSBucket'
QCU87Z commented on pull request #5413: URL: https://github.com/apache/nifi/pull/5413#issuecomment-960141508 Is the intent to get this merged in for the 1.14.1 release? This would hopefully solve an issue we are seeing in our production environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #5380: NIFI-9202 Improve Allowable Values merging to handle cases when different nodes have different set of Allowable Values
mattyb149 closed pull request #5380: URL: https://github.com/apache/nifi/pull/5380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1170: MINIFICPP-1618 Create the ReplaceText processor
szaszm closed pull request #1170: URL: https://github.com/apache/nifi-minifi-cpp/pull/1170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #5423: NIFI-9260 Making the 'write and rename' behaviour optional for PutHDFS
turcsanyip commented on a change in pull request #5423: URL: https://github.com/apache/nifi/pull/5423#discussion_r742180815 ## File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java ## @@ -133,6 +136,11 @@ protected static final AllowableValue APPEND_RESOLUTION_AV = new AllowableValue(APPEND_RESOLUTION, APPEND_RESOLUTION, "Appends to the existing file if any, creates a new file otherwise."); +protected static final AllowableValue WRITE_AND_RENAME_AV = new AllowableValue(WRITE_AND_RENAME, "Write and rename", +"The processor writes FlowFile data into a temporary file and renames it after completion. This might prevent other processes from reading partially written files."); Review comment: "This prevents..." or "This can prevent..." would describe its purpose/behaviour more exactly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #5505: NIFI-9360 - handle filesystems which do not support getAclStatus()
exceptionfactory closed pull request #5505: URL: https://github.com/apache/nifi/pull/5505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] nandorsoma commented on pull request #5475: NIFI-830 For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL
nandorsoma commented on pull request #5475: URL: https://github.com/apache/nifi/pull/5475#issuecomment-958715427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] timeabarna commented on pull request #5303: NIFI-8677 Add custom endpoint suffix for Azure EventHub Processors
timeabarna commented on pull request #5303: URL: https://github.com/apache/nifi/pull/5303#issuecomment-958821250 @jfrazee Hello Joey, can you please check this PR when you have some time? Thanks in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1168: MINIFICPP-1632 - Implement RouteText processor
szaszm closed pull request #1168: URL: https://github.com/apache/nifi-minifi-cpp/pull/1168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] kevdoran commented on pull request #5475: NIFI-830 For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL
kevdoran commented on pull request #5475: URL: https://github.com/apache/nifi/pull/5475#issuecomment-959182309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1188: MINIFICPP-1651: Added DefragmentText processor
szaszm closed pull request #1188: URL: https://github.com/apache/nifi-minifi-cpp/pull/1188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #5380: NIFI-9202 Improve Allowable Values merging to handle cases when different nodes have different set of Allowable Values
mattyb149 commented on pull request #5380: URL: https://github.com/apache/nifi/pull/5380#issuecomment-959844316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #5423: NIFI-9260 Making the 'write and rename' behaviour optional for PutHDFS
turcsanyip commented on a change in pull request #5423: URL: https://github.com/apache/nifi/pull/5423#discussion_r742180815 ## File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java ## @@ -133,6 +136,11 @@ protected static final AllowableValue APPEND_RESOLUTION_AV = new AllowableValue(APPEND_RESOLUTION, APPEND_RESOLUTION, "Appends to the existing file if any, creates a new file otherwise."); +protected static final AllowableValue WRITE_AND_RENAME_AV = new AllowableValue(WRITE_AND_RENAME, "Write and rename", +"The processor writes FlowFile data into a temporary file and renames it after completion. This might prevent other processes from reading partially written files."); Review comment: "This prevents..." or "This can prevent..." would describe its purpose/behaviour more exactly. ## File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java ## @@ -133,6 +136,11 @@ protected static final AllowableValue APPEND_RESOLUTION_AV = new AllowableValue(APPEND_RESOLUTION, APPEND_RESOLUTION, "Appends to the existing file if any, creates a new file otherwise."); +protected static final AllowableValue WRITE_AND_RENAME_AV = new AllowableValue(WRITE_AND_RENAME, "Write and rename", +"The processor writes FlowFile data into a temporary file and renames it after completion. This might prevent other processes from reading partially written files."); Review comment: "This prevents..." or "This can prevent..." would describe its purpose/behaviour more exactly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] ottobackwards merged pull request #5501: NIFI-9349 - add attribute with request duration in InvokeHTTP
ottobackwards merged pull request #5501: URL: https://github.com/apache/nifi/pull/5501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #5380: NIFI-9202 Improve Allowable Values merging to handle cases when different nodes have different set of Allowable Values
mattyb149 closed pull request #5380: URL: https://github.com/apache/nifi/pull/5380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1170: MINIFICPP-1618 Create the ReplaceText processor
szaszm closed pull request #1170: URL: https://github.com/apache/nifi-minifi-cpp/pull/1170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] tpalfy commented on a change in pull request #5088: NIFI-3320: SendTrapSNMP and ListenTrapSNMP processors added.
tpalfy commented on a change in pull request #5088:
URL: https://github.com/apache/nifi/pull/5088#discussion_r741980742
##
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/GetSNMP.java
##
@@ -134,59 +144,96 @@
REL_FAILURE
)));
+private volatile GetSNMPHandler snmpHandler;
+
+@OnScheduled
+public void init(final ProcessContext context) {
+initSnmpManager(context);
+snmpHandler = new GetSNMPHandler(snmpResourceHandler);
+}
+
@Override
public void onTrigger(final ProcessContext context, final ProcessSession
processSession) {
final SNMPStrategy snmpStrategy =
SNMPStrategy.valueOf(context.getProperty(SNMP_STRATEGY).getValue());
final String oid = context.getProperty(OID).getValue();
+final FlowFile flowfile = processSession.get();
if (SNMPStrategy.GET == snmpStrategy) {
-performSnmpGet(context, processSession, oid);
+performSnmpGet(context, processSession, oid, flowfile);
} else if (SNMPStrategy.WALK == snmpStrategy) {
-performSnmpWalk(context, processSession, oid);
+performSnmpWalk(context, processSession, oid, flowfile);
}
}
-private void performSnmpWalk(final ProcessContext context, final
ProcessSession processSession, final String oid) {
+void performSnmpWalk(final ProcessContext context, final ProcessSession
processSession, final String oid,
+ final FlowFile flowFile) {
+final Optional incomingFlowFile =
Optional.ofNullable(flowFile);
+Map flowFileAttributes =
incomingFlowFile.map(FlowFile::getAttributes).orElse(Collections.emptyMap());
try {
-final SNMPTreeResponse response = snmpRequestHandler.walk(oid);
-response.logErrors(getLogger());
-FlowFile flowFile =
createFlowFileWithTreeEventProperties(response, processSession);
-processSession.getProvenanceReporter().receive(flowFile,
response.getTargetAddress() + "/" + oid);
-processSession.transfer(flowFile, REL_SUCCESS);
+final Optional optionalResponse =
snmpHandler.walk(oid, flowFileAttributes);
+if (optionalResponse.isPresent()) {
+incomingFlowFile.ifPresent(processSession::remove);
+final SNMPTreeResponse response = optionalResponse.get();
+response.logErrors(getLogger());
+FlowFile outgoingFlowFile =
createFlowFileWithTreeEventProperties(response, processSession);
+
processSession.getProvenanceReporter().receive(outgoingFlowFile,
response.getTargetAddress() + "/walk");
+processSession.transfer(outgoingFlowFile, REL_SUCCESS);
+} else {
+getLogger().warn("No SNMP specific attributes found in
flowfile.");
+incomingFlowFile.ifPresent(ff -> processSession.transfer(ff,
REL_SUCCESS));
Review comment:
Shouldn't go to failure instead of success in this case?
##
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/properties/V1TrapProperties.java
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.snmp.processors.properties;
+
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import static
org.apache.nifi.snmp.processors.properties.BasicProperties.SNMP_V1;
+import static
org.apache.nifi.snmp.processors.properties.BasicProperties.SNMP_VERSION;
+
+
+public class V1TrapProperties {
+
+private V1TrapProperties() {
+// Utility class, not needed to instantiate.
+}
+
+private static final AllowableValue GENERIC_TRAP_TYPE_COLD_START = new
AllowableValue("0", "Cold Start",
+"A coldStart trap signifies that the sending protocol entity is
reinitializing itself such that" +
+" the agent's configuration or the protocol
[GitHub] [nifi] QCU87Z commented on pull request #5413: NIFI-8676 Added 'Tracking Entities' listing strategy to 'ListS3' and 'ListGCSBucket'
QCU87Z commented on pull request #5413: URL: https://github.com/apache/nifi/pull/5413#issuecomment-960141508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] ottobackwards commented on pull request #5475: NIFI-830 For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL
ottobackwards commented on pull request #5475: URL: https://github.com/apache/nifi/pull/5475#issuecomment-959812422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1168: MINIFICPP-1632 - Implement RouteText processor
szaszm closed pull request #1168: URL: https://github.com/apache/nifi-minifi-cpp/pull/1168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #5505: NIFI-9360 - handle filesystems which do not support getAclStatus()
exceptionfactory closed pull request #5505: URL: https://github.com/apache/nifi/pull/5505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] nandorsoma commented on pull request #5475: NIFI-830 For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL
nandorsoma commented on pull request #5475: URL: https://github.com/apache/nifi/pull/5475#issuecomment-958715427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] timeabarna commented on pull request #5303: NIFI-8677 Add custom endpoint suffix for Azure EventHub Processors
timeabarna commented on pull request #5303: URL: https://github.com/apache/nifi/pull/5303#issuecomment-958821250 @jfrazee Hello Joey, can you please check this PR when you have some time? Thanks in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-8392) ResultSetRecordSet maps JDBC CHAR type to a RecordFieldType of CHAR instead of STRING
[
https://issues.apache.org/jira/browse/NIFI-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-8392:
---
Status: Patch Available (was: In Progress)
> ResultSetRecordSet maps JDBC CHAR type to a RecordFieldType of CHAR instead
> of STRING
> -
>
> Key: NIFI-8392
> URL: https://issues.apache.org/jira/browse/NIFI-8392
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Lucas Read
>Assignee: Matt Burgess
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> So in {{ResultSetRecordSet}} it looks like we map JDBC CHAR type to a
> RecordFieldType of CHAR:
>
> {code:java}
> case Types.CHAR:
> return RecordFieldType.CHAR;
> {code}
> Needs to be changed so that Types.CHAR maps to RecordFieldType.STRING
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] mattyb149 opened a new pull request #5506: NIFI-8392: Translate JDBC CHAR type to RecordFieldType STRING
mattyb149 opened a new pull request #5506:
URL: https://github.com/apache/nifi/pull/5506
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
The JDBC type CHAR corresponds to a fixed-length string, not a single
character. We should represent this in a NiFi record with a String type.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-8392) ResultSetRecordSet maps JDBC CHAR type to a RecordFieldType of CHAR instead of STRING
[
https://issues.apache.org/jira/browse/NIFI-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438343#comment-17438343
]
Matt Burgess commented on NIFI-8392:
The JDBC CHAR type refers to a fixed-length string (versus VARCHAR), so indeed
it should be a string in the NiFi record
> ResultSetRecordSet maps JDBC CHAR type to a RecordFieldType of CHAR instead
> of STRING
> -
>
> Key: NIFI-8392
> URL: https://issues.apache.org/jira/browse/NIFI-8392
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Lucas Read
>Assignee: Matt Burgess
>Priority: Major
>
> So in {{ResultSetRecordSet}} it looks like we map JDBC CHAR type to a
> RecordFieldType of CHAR:
>
> {code:java}
> case Types.CHAR:
> return RecordFieldType.CHAR;
> {code}
> Needs to be changed so that Types.CHAR maps to RecordFieldType.STRING
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (NIFI-8392) ResultSetRecordSet maps JDBC CHAR type to a RecordFieldType of CHAR instead of STRING
[
https://issues.apache.org/jira/browse/NIFI-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess reassigned NIFI-8392:
--
Assignee: Matt Burgess
> ResultSetRecordSet maps JDBC CHAR type to a RecordFieldType of CHAR instead
> of STRING
> -
>
> Key: NIFI-8392
> URL: https://issues.apache.org/jira/browse/NIFI-8392
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Lucas Read
>Assignee: Matt Burgess
>Priority: Major
>
> So in {{ResultSetRecordSet}} it looks like we map JDBC CHAR type to a
> RecordFieldType of CHAR:
>
> {code:java}
> case Types.CHAR:
> return RecordFieldType.CHAR;
> {code}
> Needs to be changed so that Types.CHAR maps to RecordFieldType.STRING
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-8392) ResultSetRecordSet maps JDBC CHAR type to a RecordFieldType of CHAR instead of STRING
[
https://issues.apache.org/jira/browse/NIFI-8392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-8392:
---
Affects Version/s: (was: 1.12.1)
(was: 1.11.4)
(was: 1.11.0)
> ResultSetRecordSet maps JDBC CHAR type to a RecordFieldType of CHAR instead
> of STRING
> -
>
> Key: NIFI-8392
> URL: https://issues.apache.org/jira/browse/NIFI-8392
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Lucas Read
>Priority: Major
>
> So in {{ResultSetRecordSet}} it looks like we map JDBC CHAR type to a
> RecordFieldType of CHAR:
>
> {code:java}
> case Types.CHAR:
> return RecordFieldType.CHAR;
> {code}
> Needs to be changed so that Types.CHAR maps to RecordFieldType.STRING
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] QCU87Z commented on pull request #5413: NIFI-8676 Added 'Tracking Entities' listing strategy to 'ListS3' and 'ListGCSBucket'
QCU87Z commented on pull request #5413: URL: https://github.com/apache/nifi/pull/5413#issuecomment-960141508 Is the intent to get this merged in for the 1.14.1 release? This would hopefully solve an issue we are seeing in our production environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-9362) ListFTP / ListSFTP may occasionally duplicate files when Primary Node changes
[ https://issues.apache.org/jira/browse/NIFI-9362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-9362: - Status: Patch Available (was: Open) > ListFTP / ListSFTP may occasionally duplicate files when Primary Node changes > - > > Key: NIFI-9362 > URL: https://issues.apache.org/jira/browse/NIFI-9362 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > > Create a ListFTP or ListSFTP processor in a clustered environment. > Run the processor and let it perform the listing. > Then disconnect the primary node so that a new node is elected. > The files that have the latest seen timestamp may now get duplicated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (NIFI-9349) InvokeHTTP - add attribute with call duration
[ https://issues.apache.org/jira/browse/NIFI-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Otto Fowler closed NIFI-9349. - > InvokeHTTP - add attribute with call duration > - > > Key: NIFI-9349 > URL: https://issues.apache.org/jira/browse/NIFI-9349 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.15.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Add an attribute to the FlowFile like "invokehttp.request.duration" to > provide in milliseconds the response time of the remote endpoint. At this > time, this can be retrieved by looking at the Event Duration value of the > corresponding provenance event. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-9349) InvokeHTTP - add attribute with call duration
[ https://issues.apache.org/jira/browse/NIFI-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438266#comment-17438266 ] Otto Fowler commented on NIFI-9349: --- oops, sorry > InvokeHTTP - add attribute with call duration > - > > Key: NIFI-9349 > URL: https://issues.apache.org/jira/browse/NIFI-9349 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.15.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Add an attribute to the FlowFile like "invokehttp.request.duration" to > provide in milliseconds the response time of the remote endpoint. At this > time, this can be retrieved by looking at the Event Duration value of the > corresponding provenance event. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-9202) Improve NiFi merging logic for Allowable Values
[ https://issues.apache.org/jira/browse/NIFI-9202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-9202: --- Fix Version/s: 1.16.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Improve NiFi merging logic for Allowable Values > --- > > Key: NIFI-9202 > URL: https://issues.apache.org/jira/browse/NIFI-9202 > Project: Apache NiFi > Issue Type: Bug >Reporter: Tamas Palfy >Assignee: Tamas Palfy >Priority: Major > Fix For: 1.16.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Allowable values for a given property at runtime can be different between the > nodes in a clustered NiFi. > The current merging logic that attempts to report them to the UI is not > prepared to handle such cases properly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-9202) Improve NiFi merging logic for Allowable Values
[ https://issues.apache.org/jira/browse/NIFI-9202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438265#comment-17438265 ] ASF subversion and git services commented on NIFI-9202: --- Commit 2bd752d868a8f3e36113b078bb576cf054e945e8 in nifi's branch refs/heads/main from Tamas Palfy [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2bd752d ] NIFI-9202 Improve Allowable Values merging to handle cases when different nodes have different set of Allowable Values. Signed-off-by: Matthew Burgess This closes #5380 > Improve NiFi merging logic for Allowable Values > --- > > Key: NIFI-9202 > URL: https://issues.apache.org/jira/browse/NIFI-9202 > Project: Apache NiFi > Issue Type: Bug >Reporter: Tamas Palfy >Assignee: Tamas Palfy >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Allowable values for a given property at runtime can be different between the > nodes in a clustered NiFi. > The current merging logic that attempts to report them to the UI is not > prepared to handle such cases properly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] mattyb149 closed pull request #5380: NIFI-9202 Improve Allowable Values merging to handle cases when different nodes have different set of Allowable Values
mattyb149 closed pull request #5380: URL: https://github.com/apache/nifi/pull/5380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #5380: NIFI-9202 Improve Allowable Values merging to handle cases when different nodes have different set of Allowable Values
mattyb149 commented on pull request #5380: URL: https://github.com/apache/nifi/pull/5380#issuecomment-959844316 +1 LGTM, tested on a 3-node secure cluster with 1 node running Java 11 and 2 nodes running Java 8, verified the MonitorMemory Reporting Task contained the correct options for each type of node. Thanks for the fix! Merging to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-9016) Add BCFKS KeyStoreKeyProvider Example to User Guide
[
https://issues.apache.org/jira/browse/NIFI-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438259#comment-17438259
]
Andrew M. Lim commented on NIFI-9016:
-
(y)
> Add BCFKS KeyStoreKeyProvider Example to User Guide
> ---
>
> Key: NIFI-9016
> URL: https://issues.apache.org/jira/browse/NIFI-9016
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Documentation Website
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Labels: security
> Fix For: 1.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The NiFi User Guide currently includes documentation on the
> {{KeyStoreKeyProvider}} with an example command for PKCS12 Secret Key
> generation and configuration. Using {{keytool}} to generate a Secret Key for
> storage in BCFKS requires additional arguments and reference to a separate
> provider JAR. Adding an example to the documentation would make it easier to
> configure repository encryption using BCFKS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-9362) ListFTP / ListSFTP may occasionally duplicate files when Primary Node changes
[ https://issues.apache.org/jira/browse/NIFI-9362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438254#comment-17438254 ] Mark Payne commented on NIFI-9362: -- This regression appears to have been introduced in NIFI-8136 > ListFTP / ListSFTP may occasionally duplicate files when Primary Node changes > - > > Key: NIFI-9362 > URL: https://issues.apache.org/jira/browse/NIFI-9362 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > > Create a ListFTP or ListSFTP processor in a clustered environment. > Run the processor and let it perform the listing. > Then disconnect the primary node so that a new node is elected. > The files that have the latest seen timestamp may now get duplicated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NIFI-9362) ListFTP / ListSFTP may occasionally duplicate files when Primary Node changes
Mark Payne created NIFI-9362: Summary: ListFTP / ListSFTP may occasionally duplicate files when Primary Node changes Key: NIFI-9362 URL: https://issues.apache.org/jira/browse/NIFI-9362 Project: Apache NiFi Issue Type: Bug Components: Extensions Reporter: Mark Payne Assignee: Mark Payne Create a ListFTP or ListSFTP processor in a clustered environment. Run the processor and let it perform the listing. Then disconnect the primary node so that a new node is elected. The files that have the latest seen timestamp may now get duplicated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-9344) Conduct 1.15 Release
[ https://issues.apache.org/jira/browse/NIFI-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438244#comment-17438244 ] ASF subversion and git services commented on NIFI-9344: --- Commit 7fdc07cccdc0e23d4986557a9314e36859704a3b in nifi's branch refs/heads/NIFI-9344-RC3 from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=7fdc07c ] NIFI-9344-RC3 prepare release nifi-1.15.0-RC3 > Conduct 1.15 Release > > > Key: NIFI-9344 > URL: https://issues.apache.org/jira/browse/NIFI-9344 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-9344) Conduct 1.15 Release
[ https://issues.apache.org/jira/browse/NIFI-9344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438245#comment-17438245 ] ASF subversion and git services commented on NIFI-9344: --- Commit c0558959523cdf8ed28f4ff42594133948bd67f0 in nifi's branch refs/heads/NIFI-9344-RC3 from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c055895 ] NIFI-9344-RC3 prepare for next development iteration > Conduct 1.15 Release > > > Key: NIFI-9344 > URL: https://issues.apache.org/jira/browse/NIFI-9344 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.15.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] ottobackwards commented on pull request #5475: NIFI-830 For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL
ottobackwards commented on pull request #5475: URL: https://github.com/apache/nifi/pull/5475#issuecomment-959812422 I don't feel strongly enough to object. Leaving it encoded is simplest, and users can still fix it up later if they want. As long as it is documented as being encoded I'm OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #5423: NIFI-9260 Making the 'write and rename' behaviour optional for PutHDFS
turcsanyip commented on a change in pull request #5423: URL: https://github.com/apache/nifi/pull/5423#discussion_r742180815 ## File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java ## @@ -133,6 +136,11 @@ protected static final AllowableValue APPEND_RESOLUTION_AV = new AllowableValue(APPEND_RESOLUTION, APPEND_RESOLUTION, "Appends to the existing file if any, creates a new file otherwise."); +protected static final AllowableValue WRITE_AND_RENAME_AV = new AllowableValue(WRITE_AND_RENAME, "Write and rename", +"The processor writes FlowFile data into a temporary file and renames it after completion. This might prevent other processes from reading partially written files."); Review comment: "This prevents..." or "This can prevent..." would describe its purpose/behaviour more exactly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-8922) Nifi wont start on running with LDAP Parameters
[
https://issues.apache.org/jira/browse/NIFI-8922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438164#comment-17438164
]
Alex Willmer commented on NIFI-8922:
Possibly a duplicate of NIFI-8783
> Nifi wont start on running with LDAP Parameters
> ---
>
> Key: NIFI-8922
> URL: https://issues.apache.org/jira/browse/NIFI-8922
> Project: Apache NiFi
> Issue Type: Bug
> Components: Configuration
>Affects Versions: 1.14.0
> Environment: amazon linux2, running on docker build from the official
> github repo
>Reporter: Ricky Berba
>Priority: Major
>
> [https://github.com/apache/nifi/tree/main/nifi-docker/dockerhub]
>
> Nifi Wont start on LDAP Parameters Being passed :
> {{docker run --name nifi \
> -v /User/dreynolds/certs/localhost:/opt/certs \
> -p 8443:8443 \
> -e AUTH=ldap \
> -e KEYSTORE_PATH=/opt/certs/keystore.jks \
> -e KEYSTORE_TYPE=JKS \
> -e KEYSTORE_PASSWORD=QKZv1hSWAFQYZ+WU1jjF5ank+l4igeOfQRp+OSbkkrs \
> -e TRUSTSTORE_PATH=/opt/certs/truststore.jks \
> -e TRUSTSTORE_PASSWORD=rHkWR1gDNW3R9hgbeRsT3OM3Ue0zwGtQqcFKJD2EXWE \
> -e TRUSTSTORE_TYPE=JKS \
> -e INITIAL_ADMIN_IDENTITY='cn=admin,dc=example,dc=org' \
> -e LDAP_AUTHENTICATION_STRATEGY='SIMPLE' \
> -e LDAP_MANAGER_DN='cn=admin,dc=example,dc=org' \
> -e LDAP_MANAGER_PASSWORD='password' \
> -e LDAP_USER_SEARCH_BASE='dc=example,dc=org' \
> -e LDAP_USER_SEARCH_FILTER='cn=\{0}' \
> -e LDAP_IDENTITY_STRATEGY='USE_DN' \
> -e LDAP_URL='ldap://ldap:389' \
> -d \
> apache/nifi:latest}}
> Errors :
> {code:java}
> 2021-07-17 12:39:10,281 ERROR [main] o.s.web.context.ContextLoader Context
> initialization failed2021-07-17 12:39:10,281 ERROR [main]
> o.s.web.context.ContextLoader Context initialization
> failedorg.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name
> 'org.springframework.security.config.annotation.web.configuration.WebSecurityConfiguration':
> Unsatisfied dependency expressed through method
> 'setFilterChainProxySecurityConfigurer' parameter 1; nested exception is
> org.springframework.beans.factory.BeanExpressionException: Expression parsing
> failed; nested exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name
> 'org.apache.nifi.web.NiFiWebApiSecurityConfiguration': Unsatisfied dependency
> expressed through method 'setJwtAuthenticationProvider' parameter 0; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'jwtAuthenticationProvider' defined in class path
> resource [nifi-web-security-context.xml]: Cannot resolve reference to bean
> 'authorizer' while setting constructor argument; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'authorizer': FactoryBean threw exception on object creation;
> nested exception is java.lang.reflect.InvocationTargetException at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredMethodElement.resolveMethodArguments(AutowiredAnnotationBeanPostProcessor.java:768)
> at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredMethodElement.inject(AutowiredAnnotationBeanPostProcessor.java:720)
> at
> org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:119)
> at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessProperties(AutowiredAnnotationBeanPostProcessor.java:399)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1413)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:601)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:524)
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
> at
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
> at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:944)
> at
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
> at
>
[jira] [Created] (NIFI-9361) Node can fail to DELETE connection while others finish if upstream component is funnel
Mark Payne created NIFI-9361: Summary: Node can fail to DELETE connection while others finish if upstream component is funnel Key: NIFI-9361 URL: https://issues.apache.org/jira/browse/NIFI-9361 Project: Apache NiFi Issue Type: Bug Components: Core Framework Reporter: Mark Payne When a Connection is deleted, it verifies 3 things before the deletion can occur: 1. The queue is empty 2. The source either is a Funnel or is stopped 3. The destination either is a Funnel or is stopped This means that if we delete a connection whose source is a Funnel and whose destination is a Processor, we can have an issue where nodes in the cluster verify that the connection can be deleted. Then, when the nodes go to perform the delete, a node can fail to perform the delete because it now has data. To avoid this, if the source is a funnel, we need to look at its upstream components (recursively) until we encounter something other than a funnel or we reach a dead end. Only if all upstream components are stopped should we allow the connection to be deleted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-9349) InvokeHTTP - add attribute with call duration
[ https://issues.apache.org/jira/browse/NIFI-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-9349: --- Fix Version/s: 1.15.0 Resolution: Fixed Status: Resolved (was: Patch Available) > InvokeHTTP - add attribute with call duration > - > > Key: NIFI-9349 > URL: https://issues.apache.org/jira/browse/NIFI-9349 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.15.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Add an attribute to the FlowFile like "invokehttp.request.duration" to > provide in milliseconds the response time of the remote endpoint. At this > time, this can be retrieved by looking at the Event Duration value of the > corresponding provenance event. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-9349) InvokeHTTP - add attribute with call duration
[ https://issues.apache.org/jira/browse/NIFI-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438117#comment-17438117 ] Joe Witt commented on NIFI-9349: [~otto]Please be sure to close the JIRA if you merge a commit. Also please note "This closes #9349" is referencing a JIRA number. It should be closing the github entry #5501. > InvokeHTTP - add attribute with call duration > - > > Key: NIFI-9349 > URL: https://issues.apache.org/jira/browse/NIFI-9349 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Add an attribute to the FlowFile like "invokehttp.request.duration" to > provide in milliseconds the response time of the remote endpoint. At this > time, this can be retrieved by looking at the Event Duration value of the > corresponding provenance event. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] nandorsoma commented on pull request #5475: NIFI-830 For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL
nandorsoma commented on pull request #5475: URL: https://github.com/apache/nifi/pull/5475#issuecomment-959266473 Thank you @kevdoran for the clarification! I would +1 as well on leaving url encoded characters in filename. It's an edge case and it doesn't bring that much value to have the possibility to break existing flows. @ottobackwards I don't have an exact answer why the project wants that feature at all, because I'm too new there. My guess is that this is something that you would naturally expect when you download a content and it should have been the default behavior. And this is the key. If this is something that is not an edge case, then it's logic could belong to the processor itself. But as I said, it's just an assumption from me. @kevdoran, does it make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1170: MINIFICPP-1618 Create the ReplaceText processor
szaszm closed pull request #1170: URL: https://github.com/apache/nifi-minifi-cpp/pull/1170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1168: MINIFICPP-1632 - Implement RouteText processor
szaszm closed pull request #1168: URL: https://github.com/apache/nifi-minifi-cpp/pull/1168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] tpalfy commented on a change in pull request #5088: NIFI-3320: SendTrapSNMP and ListenTrapSNMP processors added.
tpalfy commented on a change in pull request #5088:
URL: https://github.com/apache/nifi/pull/5088#discussion_r741983411
##
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SendTrapSNMP.java
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.snmp.processors;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.snmp.configuration.V1TrapConfiguration;
+import org.apache.nifi.snmp.configuration.V2TrapConfiguration;
+import org.apache.nifi.snmp.factory.trap.V1TrapPDUFactory;
+import org.apache.nifi.snmp.factory.trap.V2TrapPDUFactory;
+import org.apache.nifi.snmp.operations.SendTrapSNMPHandler;
+import org.apache.nifi.snmp.processors.properties.BasicProperties;
+import org.apache.nifi.snmp.processors.properties.V1TrapProperties;
+import org.apache.nifi.snmp.processors.properties.V2TrapProperties;
+import org.apache.nifi.snmp.processors.properties.V3SecurityProperties;
+import org.snmp4j.PDU;
+import org.snmp4j.mp.SnmpConstants;
+
+import java.io.IOException;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.function.Supplier;
+
+/**
+ * Sends data to an SNMP manager which, upon each invocation of
+ * {@link #onTrigger(ProcessContext, ProcessSession)} method, will construct a
+ * {@link FlowFile} containing in its properties the information retrieved.
+ * The output {@link FlowFile} won't have any content.
+ */
+@Tags({"snmp", "send", "trap"})
+@InputRequirement(Requirement.INPUT_ALLOWED)
+@CapabilityDescription("Sends information to SNMP Manager.")
+public class SendTrapSNMP extends AbstractSNMPProcessor {
+
+public static final PropertyDescriptor SNMP_MANAGER_HOST = new
PropertyDescriptor.Builder()
+.name("snmp-trap-manager-host")
+.displayName("SNMP Manager Host")
+.description("The host where the SNMP Manager sends the trap.")
+.required(true)
+.defaultValue("localhost")
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+
+public static final PropertyDescriptor SNMP_MANAGER_PORT = new
PropertyDescriptor.Builder()
+.name("snmp-trap-manager-port")
+.displayName("SNMP Manager Port")
+.description("The port where the SNMP Manager listens to the
incoming traps.")
+.required(true)
+.defaultValue("0")
+.addValidator(StandardValidators.PORT_VALIDATOR)
+.build();
+
+public static final Relationship REL_SUCCESS = new Relationship.Builder()
+.name("success")
+.description("All FlowFiles that have been successfully used to
perform SNMP Set are routed to this relationship")
+.build();
+
+public static final Relationship REL_FAILURE = new Relationship.Builder()
+.name("failure")
+.description("All FlowFiles that cannot received from the SNMP
agent are routed to this relationship")
+.build();
+
+protected static final List PROPERTY_DESCRIPTORS =
Collections.unmodifiableList(Arrays.asList(
+SNMP_MANAGER_HOST,
+SNMP_MANAGER_PORT,
+BasicProperties.SNMP_VERSION,
+BasicProperties.SNMP_COMMUNITY,
+V3SecurityProperties.SNMP_SECURITY_LEVEL,
[GitHub] [nifi] tpalfy commented on a change in pull request #5088: NIFI-3320: SendTrapSNMP and ListenTrapSNMP processors added.
tpalfy commented on a change in pull request #5088:
URL: https://github.com/apache/nifi/pull/5088#discussion_r741980742
##
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/GetSNMP.java
##
@@ -134,59 +144,96 @@
REL_FAILURE
)));
+private volatile GetSNMPHandler snmpHandler;
+
+@OnScheduled
+public void init(final ProcessContext context) {
+initSnmpManager(context);
+snmpHandler = new GetSNMPHandler(snmpResourceHandler);
+}
+
@Override
public void onTrigger(final ProcessContext context, final ProcessSession
processSession) {
final SNMPStrategy snmpStrategy =
SNMPStrategy.valueOf(context.getProperty(SNMP_STRATEGY).getValue());
final String oid = context.getProperty(OID).getValue();
+final FlowFile flowfile = processSession.get();
if (SNMPStrategy.GET == snmpStrategy) {
-performSnmpGet(context, processSession, oid);
+performSnmpGet(context, processSession, oid, flowfile);
} else if (SNMPStrategy.WALK == snmpStrategy) {
-performSnmpWalk(context, processSession, oid);
+performSnmpWalk(context, processSession, oid, flowfile);
}
}
-private void performSnmpWalk(final ProcessContext context, final
ProcessSession processSession, final String oid) {
+void performSnmpWalk(final ProcessContext context, final ProcessSession
processSession, final String oid,
+ final FlowFile flowFile) {
+final Optional incomingFlowFile =
Optional.ofNullable(flowFile);
+Map flowFileAttributes =
incomingFlowFile.map(FlowFile::getAttributes).orElse(Collections.emptyMap());
try {
-final SNMPTreeResponse response = snmpRequestHandler.walk(oid);
-response.logErrors(getLogger());
-FlowFile flowFile =
createFlowFileWithTreeEventProperties(response, processSession);
-processSession.getProvenanceReporter().receive(flowFile,
response.getTargetAddress() + "/" + oid);
-processSession.transfer(flowFile, REL_SUCCESS);
+final Optional optionalResponse =
snmpHandler.walk(oid, flowFileAttributes);
+if (optionalResponse.isPresent()) {
+incomingFlowFile.ifPresent(processSession::remove);
+final SNMPTreeResponse response = optionalResponse.get();
+response.logErrors(getLogger());
+FlowFile outgoingFlowFile =
createFlowFileWithTreeEventProperties(response, processSession);
+
processSession.getProvenanceReporter().receive(outgoingFlowFile,
response.getTargetAddress() + "/walk");
+processSession.transfer(outgoingFlowFile, REL_SUCCESS);
+} else {
+getLogger().warn("No SNMP specific attributes found in
flowfile.");
+incomingFlowFile.ifPresent(ff -> processSession.transfer(ff,
REL_SUCCESS));
Review comment:
Shouldn't go to failure instead of success in this case?
##
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/properties/V1TrapProperties.java
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.snmp.processors.properties;
+
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import static
org.apache.nifi.snmp.processors.properties.BasicProperties.SNMP_V1;
+import static
org.apache.nifi.snmp.processors.properties.BasicProperties.SNMP_VERSION;
+
+
+public class V1TrapProperties {
+
+private V1TrapProperties() {
+// Utility class, not needed to instantiate.
+}
+
+private static final AllowableValue GENERIC_TRAP_TYPE_COLD_START = new
AllowableValue("0", "Cold Start",
+"A coldStart trap signifies that the sending protocol entity is
reinitializing itself such that" +
+" the agent's configuration or the protocol
[GitHub] [nifi] kevdoran commented on pull request #5475: NIFI-830 For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL
kevdoran commented on pull request #5475: URL: https://github.com/apache/nifi/pull/5475#issuecomment-959182309 @ottobackwards my understanding is that the `invokehttp.request|response.url` attributes contain the full url, where as the new filename attribute is just the leaf of the path, correct? ie ``` invokehttp.request.url = https://example.com/path/to/my-file.txt filename = my-file.txt ``` In this case, we are only deciding if that file name should be url encoded, e.g., `filename%20with%20spaces%20and%2Fslashes.txt` or `filename with spaces and/slashes.txt` I think we can make an argument for either approach. Where backward compatibility comes into play is thinking about existing flows and assumptions they may make about the filename attribute. For example: ``` InvokeHTTP >> PutS3 ``` Currently, the filename used for S3 object key will be the flowfile UUID. This PR will change that to be the filename, which if it is url encoded will still work with PutS3, but if it is decoded will break if the filename contains special characters such as `/`. For this reason, I vote leaving filename url encoded in InvokeHTTP, but I don't feel strongly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-5993) NiFi text search improvment
[
https://issues.apache.org/jira/browse/NIFI-5993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438094#comment-17438094
]
Pierre Villard commented on NIFI-5993:
--
{quote}Also, the inability to limit *where* (ie. current process group or
current & below) the search is performed is very frustrating and limiting.
{quote}
[https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#search]
> NiFi text search improvment
> ---
>
> Key: NIFI-5993
> URL: https://issues.apache.org/jira/browse/NIFI-5993
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core UI
>Affects Versions: 1.8.0
>Reporter: Nimrod Avni
>Priority: Minor
> Labels: nifi, search, ui
>
> The NiFi textual search on all the components in the canvas has some big
> issues
> The searching refreshes every time you type in a new letter, since the NiFi
> canvas can get very big quickly, the searching takes up a lot of time and
> resources. I had more then a few times where i typed in 2 letters and made my
> chrome tab crash. I had to resort to typing what i want to search in a
> notepad and copying it to to search box to avoid it searching every time i
> type in a new letter.
> I think it can be resolved by better textual indexing or potentially making
> the search box do an "on demand" search, where the user clicks the search
> button or the enter key to start the search.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-5993) NiFi text search improvment
[ https://issues.apache.org/jira/browse/NIFI-5993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438075#comment-17438075 ] John Wise commented on NIFI-5993: - [~Chris.Metzger] - It's definitely still occurring. If you pause typing for a few seconds, the search mechanism kicks in, which then slows down additional text entry. NiFi search, in general, is fairly utilitarian and not at all useful for finding anything other than text strings in a few places (uuids, titles, attributes & attribute values). Also, the inability to limit *where* (ie. current process group or current & below) the search is performed is very frustrating and limiting. Case-sensitive searching is also needed, as we have had instances where people mistakenly changed case on an attribute name & broke flows. See NIFI-8358 for more details. > NiFi text search improvment > --- > > Key: NIFI-5993 > URL: https://issues.apache.org/jira/browse/NIFI-5993 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.8.0 >Reporter: Nimrod Avni >Priority: Minor > Labels: nifi, search, ui > > The NiFi textual search on all the components in the canvas has some big > issues > The searching refreshes every time you type in a new letter, since the NiFi > canvas can get very big quickly, the searching takes up a lot of time and > resources. I had more then a few times where i typed in 2 letters and made my > chrome tab crash. I had to resort to typing what i want to search in a > notepad and copying it to to search box to avoid it searching every time i > type in a new letter. > I think it can be resolved by better textual indexing or potentially making > the search box do an "on demand" search, where the user clicks the search > button or the enter key to start the search. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-9349) InvokeHTTP - add attribute with call duration
[ https://issues.apache.org/jira/browse/NIFI-9349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438057#comment-17438057 ] ASF subversion and git services commented on NIFI-9349: --- Commit decfad394d3b5fe8e91e9a732966a89a521a in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=decfad3 ] NIFI-9349 - add attribute with request duration in InvokeHTTP (#5501) This closes #9349 Signed-off-by: Otto Fowler > InvokeHTTP - add attribute with call duration > - > > Key: NIFI-9349 > URL: https://issues.apache.org/jira/browse/NIFI-9349 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Add an attribute to the FlowFile like "invokehttp.request.duration" to > provide in milliseconds the response time of the remote endpoint. At this > time, this can be retrieved by looking at the Event Duration value of the > corresponding provenance event. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] ottobackwards merged pull request #5501: NIFI-9349 - add attribute with request duration in InvokeHTTP
ottobackwards merged pull request #5501: URL: https://github.com/apache/nifi/pull/5501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1188: MINIFICPP-1651: Added DefragmentText processor
szaszm closed pull request #1188: URL: https://github.com/apache/nifi-minifi-cpp/pull/1188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] timeabarna commented on pull request #5303: NIFI-8677 Add custom endpoint suffix for Azure EventHub Processors
timeabarna commented on pull request #5303: URL: https://github.com/apache/nifi/pull/5303#issuecomment-958821250 @jfrazee Hello Joey, can you please check this PR when you have some time? Thanks in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] nandorsoma commented on pull request #5475: NIFI-830 For GET requests, InvokeHTTP should set the filename of the 'Response' FlowFile based on the URL
nandorsoma commented on pull request #5475: URL: https://github.com/apache/nifi/pull/5475#issuecomment-958715427 I've added a little note to the documentation that the filename may contain URL encoded characters to avoid future confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
