[jira] [Updated] (NIFI-10158) ListFTP required field can not use Variable Registry.

2022-06-29 Thread Nathan Gough (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nathan Gough updated NIFI-10158:

Fix Version/s: 1.17.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> ListFTP  required field can not use Variable Registry.
> --
>
> Key: NIFI-10158
> URL: https://issues.apache.org/jira/browse/NIFI-10158
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Hadi
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.17.0
>
> Attachments: image-2022-06-23-15-04-46-410.png, 
> image-2022-06-23-15-05-04-912.png, image-2022-06-24-14-13-08-220.png, 
> image-2022-06-24-14-13-34-266.png, image-2022-06-28-11-53-02-861.png
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> !image-2022-06-23-15-04-46-410.png!
> !image-2022-06-23-15-05-04-912.png!
> 1.16.X port field cant use variable registry, but 1.15.X can.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10158) ListFTP required field can not use Variable Registry.

2022-06-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17560784#comment-17560784
 ] 

ASF subversion and git services commented on NIFI-10158:


Commit 0458b6432dd010e6727ac5df7d96310e22c5f0a4 in nifi's branch 
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0458b6432d ]

NIFI-10158 Corrected ListFTP expression support for Hostname and Port

Signed-off-by: Nathan Gough 

This closes #6162.


> ListFTP  required field can not use Variable Registry.
> --
>
> Key: NIFI-10158
> URL: https://issues.apache.org/jira/browse/NIFI-10158
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: 1.16.1, 1.16.2, 1.16.3
>Reporter: Hadi
>Assignee: David Handermann
>Priority: Minor
> Attachments: image-2022-06-23-15-04-46-410.png, 
> image-2022-06-23-15-05-04-912.png, image-2022-06-24-14-13-08-220.png, 
> image-2022-06-24-14-13-34-266.png, image-2022-06-28-11-53-02-861.png
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> !image-2022-06-23-15-04-46-410.png!
> !image-2022-06-23-15-05-04-912.png!
> 1.16.X port field cant use variable registry, but 1.15.X can.
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] thenatog closed pull request #6162: NIFI-10158 Correct ListFTP expression support for Hostname and Port

2022-06-29 Thread GitBox


thenatog closed pull request #6162: NIFI-10158 Correct ListFTP expression 
support for Hostname and Port
URL: https://github.com/apache/nifi/pull/6162


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] thenatog commented on pull request #6162: NIFI-10158 Correct ListFTP expression support for Hostname and Port

2022-06-29 Thread GitBox


thenatog commented on PR #6162:
URL: https://github.com/apache/nifi/pull/6162#issuecomment-1170540459

   Tested this with a virtual box FTP server and found that I was able to set 
variables in my flow and reference these in the ListFTP processor to connect 
and list files on that server. +1 will merge soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10181) Upgrade to Groovy 3.0.10

2022-06-29 Thread Matt Burgess (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-10181:

Summary: Upgrade to Groovy 3.0.10  (was: Upgrade to Groovy 3.0.11)

> Upgrade to Groovy 3.0.10
> 
>
> Key: NIFI-10181
> URL: https://issues.apache.org/jira/browse/NIFI-10181
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> There have been a number of bug fixes since Groovy 3.0.8, notably those that 
> help it work better on Java 17. In addition, the version of Groovy in the 
> nifi-groovyx-bundle is Groovy 2 so that should be upgraded to use the same 
> version as everything else.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10173) Upgrade Flume to 1.10.0

2022-06-29 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10173:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Upgrade Flume to 1.10.0
> ---
>
> Key: NIFI-10173
> URL: https://issues.apache.org/jira/browse/NIFI-10173
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Labels: dependency-upgrade
> Fix For: 1.17.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Apache Flume dependencies should be upgraded to 1.10.0 in order to resolve 
> CVE-2022-25167 related to Flume JMS Sources.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-10162) Improve InvokeHTTP Property Configuration

2022-06-29 Thread Kevin Doran (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Doran updated NIFI-10162:
---
Fix Version/s: 1.17.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Improve InvokeHTTP Property Configuration
> -
>
> Key: NIFI-10162
> URL: https://issues.apache.org/jira/browse/NIFI-10162
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.17.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The {{InvokeHTTP}} Processor includes a number of required and optional 
> properties that support a variety of use cases. The introduction of framework 
> support for dependent properties provides the opportunity to streamline the 
> number of properties visible in the default configuration. Among others, 
> properties related to proxy configuration and authentication can have 
> dependencies applied to indicate optional status. Adjusting property ordering 
> to place required properties first would also make the configuration easier 
> to follow.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-10162) Improve InvokeHTTP Property Configuration

2022-06-29 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-10162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17560661#comment-17560661
 ] 

ASF subversion and git services commented on NIFI-10162:


Commit 7a47c8cfbd458ab037275762c385d50372c130a3 in nifi's branch 
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=7a47c8cfbd ]

NIFI-10162 Reorganized InvokeHTTP Properties

- Corrected handling of documentation for allowable values

NIFI-10162 Updated Multipart Form-Data Name description

This closes #6163.

Signed-off-by: Kevin Doran 


> Improve InvokeHTTP Property Configuration
> -
>
> Key: NIFI-10162
> URL: https://issues.apache.org/jira/browse/NIFI-10162
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The {{InvokeHTTP}} Processor includes a number of required and optional 
> properties that support a variety of use cases. The introduction of framework 
> support for dependent properties provides the opportunity to streamline the 
> number of properties visible in the default configuration. Among others, 
> properties related to proxy configuration and authentication can have 
> dependencies applied to indicate optional status. Adjusting property ordering 
> to place required properties first would also make the configuration easier 
> to follow.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] kevdoran closed pull request #6163: NIFI-10162 Reorganize InvokeHTTP Properties

2022-06-29 Thread GitBox


kevdoran closed pull request #6163: NIFI-10162 Reorganize InvokeHTTP Properties
URL: https://github.com/apache/nifi/pull/6163


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10182) Remove Vendor Repositories from Maven Configuration

2022-06-29 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-10182:

Status: Patch Available  (was: Open)

> Remove Vendor Repositories from Maven Configuration
> ---
>
> Key: NIFI-10182
> URL: https://issues.apache.org/jira/browse/NIFI-10182
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Tools and Build
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Trivial
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Following removal of unused Maven repositories from the root Maven 
> configuration, remaining optional vendor repository definitions should be 
> removed. Optional repositories can be configured through local Maven settings 
> configurations and are not necessary for standard builds.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] exceptionfactory opened a new pull request, #6169: NIFI-10182 Remove optional vendor Maven repository

2022-06-29 Thread GitBox


exceptionfactory opened a new pull request, #6169:
URL: https://github.com/apache/nifi/pull/6169

   # Summary
   
   [NIFI-10182](https://issues.apache.org/jira/browse/NIFI-10182) Removes the 
remaining optional vendor profile and repository definition from the root Maven 
configuration. This follows the same pattern as the changes for NIFI-10180 
implemented in #6168.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-10182) Remove Vendor Repositories from Maven Configuration

2022-06-29 Thread David Handermann (Jira)
David Handermann created NIFI-10182:
---

 Summary: Remove Vendor Repositories from Maven Configuration
 Key: NIFI-10182
 URL: https://issues.apache.org/jira/browse/NIFI-10182
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Tools and Build
Reporter: David Handermann
Assignee: David Handermann


Following removal of unused Maven repositories from the root Maven 
configuration, remaining optional vendor repository definitions should be 
removed. Optional repositories can be configured through local Maven settings 
configurations and are not necessary for standard builds.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [nifi] NissimShiman commented on pull request #6035: NIFI-9440 Allow Controller Services to have configurable Bulletins

2022-06-29 Thread GitBox


NissimShiman commented on PR #6035:
URL: https://github.com/apache/nifi/pull/6035#issuecomment-1170451341

   Thank you @mattyb149  and @markobean for looking this over! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6156: NIFI-10167: Added advanced timing metrics for processors, such as CPU…

2022-06-29 Thread GitBox


exceptionfactory commented on code in PR #6156:
URL: https://github.com/apache/nifi/pull/6156#discussion_r910370087


##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/diagnostics/bootstrap/tasks/ProcessorTimingDiagnosticTask.java:
##
@@ -0,0 +1,228 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.diagnostics.bootstrap.tasks;
+
+import org.apache.nifi.controller.ProcessorNode;
+import org.apache.nifi.controller.flow.FlowManager;
+import org.apache.nifi.controller.repository.FlowFileEvent;
+import org.apache.nifi.controller.repository.FlowFileEventRepository;
+import org.apache.nifi.controller.repository.RepositoryStatusReport;
+import org.apache.nifi.diagnostics.DiagnosticTask;
+import org.apache.nifi.diagnostics.DiagnosticsDumpElement;
+import org.apache.nifi.diagnostics.StandardDiagnosticsDumpElement;
+import org.apache.nifi.processor.DataUnit;
+
+import java.text.DecimalFormat;
+import java.text.NumberFormat;
+import java.util.ArrayList;
+import java.util.Comparator;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.concurrent.TimeUnit;
+
+public class ProcessorTimingDiagnosticTask implements DiagnosticTask {
+private final FlowFileEventRepository eventRepo;
+private final FlowManager flowManager;
+
+// | Proc ID| Proc 
Name  | Proc Type  | Group Name | Proc Secs | CPU Secs  | %CPU used by Proc |
+private static final String PROCESSOR_TIMING_FORMAT = "| %1$-36.36s | 
%2$-36.36s | %3$-36.36s | %4$-36.36s | %5$15.15s | %6$27.27s | %7$25.25s | " +
+//   Read Secs | Write Secs| Commit Sec | GC millis | MB Read| MB 
Write   |
+"%8$16.16s | %9$16.16s | %10$20.20s | %11$13.13s | %12$11.11s | 
%13$11.11s |";
+
+public ProcessorTimingDiagnosticTask(final FlowFileEventRepository 
flowFileEventRepository, final FlowManager flowManager) {
+this.eventRepo = flowFileEventRepository;
+this.flowManager = flowManager;
+}
+
+@Override
+public DiagnosticsDumpElement captureDump(final boolean verbose) {
+final List details = new ArrayList<>();
+
+final RepositoryStatusReport statusReport = 
eventRepo.reportTransferEvents(System.currentTimeMillis());
+final Map eventsByComponentId = 
statusReport.getReportEntries();
+
+final List timings = new ArrayList<>();
+eventsByComponentId.entrySet().stream()
+.map(entry -> getTiming(entry.getKey(), entry.getValue()))
+.filter(Objects::nonNull)
+.forEach(timings::add); // create ArrayList and add here instead 
of .collect(toList()) because arraylist allows us to sort
+
+// Sort based on the Processor CPU time, highest CPU usage first
+
timings.sort(Comparator.comparing(ProcessorTiming::getCpuNanos).reversed());
+
+final DecimalFormat dataSizeFormat = new DecimalFormat("#,###,###.##");
+final DecimalFormat percentageFormat = new DecimalFormat("##.##");
+final NumberFormat secondsFormat = NumberFormat.getInstance();
+
+long totalCpuNanos = 0L;
+long totalProcNanos = 0L;
+long totalReadNanos = 0L;
+long totalWriteNanos = 0L;
+long totalSessionCommitNanos = 0L;
+long totalBytesRead = 0L;
+long totalBytesWritten = 0L;
+long totalGcNanos = 0L;
+
+// Tally totals for all timing elements
+for (final ProcessorTiming timing : timings) {
+totalCpuNanos += timing.getCpuNanos();
+totalProcNanos += timing.getProcessingNanos();
+totalReadNanos += timing.getReadNanos();
+totalWriteNanos += timing.getWriteNanos();
+totalSessionCommitNanos += timing.getSessionCommitNanos();
+totalBytesRead += timing.getBytesRead();
+totalBytesWritten += timing.getBytesWritten();
+totalGcNanos += timing.getGarbageCollectionNanos();
+}
+
+if (totalCpuNanos < 1) {
+details.add("No Processor Timing Diagnostic information has been 
gathered.");
+return new 

[jira] [Resolved] (NIFI-7327) Processor for decrypting and/or unpacking protected archives

2022-06-29 Thread David Handermann (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-7327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-7327.

Resolution: Duplicate

> Processor for decrypting and/or unpacking protected archives
> 
>
> Key: NIFI-7327
> URL: https://issues.apache.org/jira/browse/NIFI-7327
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Theo Hulscher
>Assignee: Theo Hulscher
>Priority: Major
>  Labels: compression, decrypt, encryption, features, password, zip
>
> UnpackContent has no capability for decrypting password protected archives 
> and EncryptContent only decrypts the archive as a single file. Archives like 
> protected zip-files are crypted per compressed file and therefor need a 
> different approach. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (NIFI-10181) Upgrade to Groovy 3.0.11

2022-06-29 Thread Matt Burgess (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess reassigned NIFI-10181:
---

Assignee: Matt Burgess

> Upgrade to Groovy 3.0.11
> 
>
> Key: NIFI-10181
> URL: https://issues.apache.org/jira/browse/NIFI-10181
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Major
>
> There have been a number of bug fixes since Groovy 3.0.8, notably those that 
> help it work better on Java 17. In addition, the version of Groovy in the 
> nifi-groovyx-bundle is Groovy 2 so that should be upgraded to use the same 
> version as everything else.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (NIFI-10181) Upgrade to Groovy 3.0.11

2022-06-29 Thread Matt Burgess (Jira)
Matt Burgess created NIFI-10181:
---

 Summary: Upgrade to Groovy 3.0.11
 Key: NIFI-10181
 URL: https://issues.apache.org/jira/browse/NIFI-10181
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Extensions
Reporter: Matt Burgess


There have been a number of bug fixes since Groovy 3.0.8, notably those that 
help it work better on Java 17. In addition, the version of Groovy in the 
nifi-groovyx-bundle is Groovy 2 so that should be upgraded to use the same 
version as everything else.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (NIFI-9810) Extract RocksDBFlowFileRepository to its own module and deprecate

2022-06-29 Thread Kevin Doran (Jira)


[ 
https://issues.apache.org/jira/browse/NIFI-9810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17560621#comment-17560621
 ] 

Kevin Doran commented on NIFI-9810:
---

After discussion with [~exceptionfactory] and [~joewitt], the new RocksDB NAR 
will be excluded from the convenience assembly binary, so users of that 
implementation will have to download and add the NAR  when they upgrade to NiFi 
>=1.17.0, with a plan to drop it as an optional extension entirely in NiFi .20

> Extract RocksDBFlowFileRepository to its own module and deprecate
> -
>
> Key: NIFI-9810
> URL: https://issues.apache.org/jira/browse/NIFI-9810
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Kevin Doran
>Assignee: Kevin Doran
>Priority: Minor
> Fix For: 1.17.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> For arm64 / Apple M1 compatibility, RocksDB needs to be bumped to >= 
> v6.29.4.1 (see below for runtime errors on an Apple Silicon M1 Mac with the 
> current version).
> RocksDB is used only by the RocksDBFlowFileRepository implementation. After 
> wider discussion with the community and who could help test and verify this 
> change, we came to the conclusion it makes the most sense to focus 
> maintenance efforts on the default FlowFileRepository implementation and 
> deprecate the RocksDB variant.
> For now, we will bump the version of RocksDB for arm64 compatibility on 
> macOS, but this ticket is also to extract it to its own module to isolate it, 
> and also mark it as deprecated with an eye on dropping it in a future major 
> version of NiFi.
> *MIGRATION GUIDANCE NOTE*
> Users of the {{RocksDBFlowFileRepository}} will have to download the new 
> {{org.apache.nifi::nifi-rocksdb-nar::x.y.z}} and add it to the lib directory 
> after upgrading past 1.16.3



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-9810) Extract RocksDBFlowFileRepository to its own module and deprecate

2022-06-29 Thread Kevin Doran (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Doran updated NIFI-9810:
--
Description: 
For arm64 / Apple M1 compatibility, RocksDB needs to be bumped to >= v6.29.4.1 
(see below for runtime errors on an Apple Silicon M1 Mac with the current 
version).

RocksDB is used only by the RocksDBFlowFileRepository implementation. After 
wider discussion with the community and who could help test and verify this 
change, we came to the conclusion it makes the most sense to focus maintenance 
efforts on the default FlowFileRepository implementation and deprecate the 
RocksDB variant.

For now, we will bump the version of RocksDB for arm64 compatibility on macOS, 
but this ticket is also to extract it to its own module to isolate it, and also 
mark it as deprecated with an eye on dropping it in a future major version of 
NiFi.


*MIGRATION GUIDANCE NOTE*
Users of the {{RocksDBFlowFileRepository}} will have to download the new 
{{org.apache.nifi::nifi-rocksdb-nar::x.y.z}} and add it to the lib directory 
after upgrading past 1.16.3


  was:
For arm64 / Apple M1 compatibility, RocksDB needs to be bumped to >= v6.29.4.1 
(see below for runtime errors on an Apple Silicon M1 Mac with the current 
version).

RocksDB is used only by the RocksDBFlowFileRepository implementation. After 
wider discussion with the community and who could help test and verify this 
change, we came to the conclusion it makes the most sense to focus maintenance 
efforts on the default FlowFileRepository implementation and deprecate the 
RocksDB variant.

For now, we will bump the version of RocksDB for arm64 compatibility on macOS, 
but this ticket is also to extract it to its own module to isolate it, and also 
mark it as deprecated with an eye on dropping it in a future major version of 
NiFi.

*MIGRATION GUIDANCE NOTE*
Users of the {{RocksDBFlowFileRepository}} will have to download the new 
{{org.apache.nifi::nifi-rocksdb-nar::x.y.z}} and add it to the lib directory 
after upgrading past 1.16.3





{noformat}
[INFO] -< org.apache.nifi:nifi-rocksdb-utils >-
[INFO] Building nifi-rocksdb-utils 1.16.0-SNAPSHOT [35/642]
[INFO] [ jar ]-
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-maven-version) @ 
nifi-rocksdb-utils ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-java-version) @ 
nifi-rocksdb-utils ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.7.0:process 
(process-resource-bundles) @ nifi-rocksdb-utils ---
[INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] --- maven-resources-plugin:3.2.0:resources (default-resources) @ 
nifi-rocksdb-utils ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Using 'UTF-8' encoding to copy filtered properties files.
[INFO] skip non existing resourceDirectory 
/Users/kdoran/dev/code/nifi/nifi-commons/nifi-rocksdb-utils/src/main/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.9.0:compile (default-compile) @ 
nifi-rocksdb-utils ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:3.2.0:testResources (default-testResources) @ 
nifi-rocksdb-utils ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Using 'UTF-8' encoding to copy filtered properties files.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.9.0:testCompile (default-testCompile) @ 
nifi-rocksdb-utils ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-compiler-plugin:3.9.0:testCompile (groovy-tests) @ 
nifi-rocksdb-utils ---
[INFO] Changes detected - recompiling the module!
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
nifi-rocksdb-utils ---
[INFO]
[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO] Running org.apache.nifi.rocksdb.TestRocksDBMetronome
[ERROR] Tests run: 10, Failures: 2, Errors: 7, Skipped: 0, Time elapsed: 0.097 
s <<< FAILURE! - in org.apache.nifi.rocksdb.TestRocksDBMetronome
[ERROR] org.apache.nifi.rocksdb.TestRocksDBMetronome.testColumnFamilies(Path)  
Time elapsed: 0.058 s  <<< ERROR!
java.lang.UnsatisfiedLinkError: 
/private/var/folders/dj/1c85sd0d6dvcp1fltmwr5nl4gn/T/librocksdbjni1540031708884427750.jnilib:
 
dlopen(/private/var/folders/dj/1c85sd0d6dvcp1fltmwr5nl4gn/T/librocksdbjni1540031708884427750.jnilib,
 0x0001): tried: 
'/private/var/folders/dj/1c85sd0d6dvcp1fltmwr5nl4gn/T/librocksdbjni1540031708884427750.jnilib'
 (mach-o file, but is an incompatible architecture (have 'x86_64', need 
'arm64e')), 

[jira] [Updated] (NIFI-9810) Extract RocksDBFlowFileRepository to its own module and deprecate

2022-06-29 Thread Kevin Doran (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Doran updated NIFI-9810:
--
Assignee: Kevin Doran
  Status: Patch Available  (was: Open)

> Extract RocksDBFlowFileRepository to its own module and deprecate
> -
>
> Key: NIFI-9810
> URL: https://issues.apache.org/jira/browse/NIFI-9810
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Kevin Doran
>Assignee: Kevin Doran
>Priority: Minor
> Fix For: 1.17.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> For arm64 / Apple M1 compatibility, RocksDB needs to be bumped to >= 
> v6.29.4.1 (see below for runtime errors on an Apple Silicon M1 Mac with the 
> current version).
> RocksDB is used only by the RocksDBFlowFileRepository implementation. After 
> wider discussion with the community and who could help test and verify this 
> change, we came to the conclusion it makes the most sense to focus 
> maintenance efforts on the default FlowFileRepository implementation and 
> deprecate the RocksDB variant.
> For now, we will bump the version of RocksDB for arm64 compatibility on 
> macOS, but this ticket is also to extract it to its own module to isolate it, 
> and also mark it as deprecated with an eye on dropping it in a future major 
> version of NiFi.
> *MIGRATION GUIDANCE NOTE*
> Users of the {{RocksDBFlowFileRepository}} will have to download the new 
> {{org.apache.nifi::nifi-rocksdb-nar::x.y.z}} and add it to the lib directory 
> after upgrading past 1.16.3



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-9810) Extract RocksDBFlowFileRepository to its own module and deprecate

2022-06-29 Thread Kevin Doran (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Doran updated NIFI-9810:
--
Fix Version/s: 1.17.0

> Extract RocksDBFlowFileRepository to its own module and deprecate
> -
>
> Key: NIFI-9810
> URL: https://issues.apache.org/jira/browse/NIFI-9810
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Kevin Doran
>Priority: Minor
> Fix For: 1.17.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> For arm64 / Apple M1 compatibility, RocksDB needs to be bumped to >= 
> v6.29.4.1 (see below for runtime errors on an Apple Silicon M1 Mac with the 
> current version).
> RocksDB is used only by the RocksDBFlowFileRepository implementation. After 
> wider discussion with the community and who could help test and verify this 
> change, we came to the conclusion it makes the most sense to focus 
> maintenance efforts on the default FlowFileRepository implementation and 
> deprecate the RocksDB variant.
> For now, we will bump the version of RocksDB for arm64 compatibility on 
> macOS, but this ticket is also to extract it to its own module to isolate it, 
> and also mark it as deprecated with an eye on dropping it in a future major 
> version of NiFi.
> *MIGRATION GUIDANCE NOTE*
> Users of the {{RocksDBFlowFileRepository}} will have to download the new 
> {{org.apache.nifi::nifi-rocksdb-nar::x.y.z}} and add it to the lib directory 
> after upgrading past 1.16.3



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (NIFI-9810) Extract RocksDBFlowFileRepository to its own module and deprecate

2022-06-29 Thread Kevin Doran (Jira)


 [ 
https://issues.apache.org/jira/browse/NIFI-9810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kevin Doran updated NIFI-9810:
--
Description: 
For arm64 / Apple M1 compatibility, RocksDB needs to be bumped to >= v6.29.4.1 
(see below for runtime errors on an Apple Silicon M1 Mac with the current 
version).

RocksDB is used only by the RocksDBFlowFileRepository implementation. After 
wider discussion with the community and who could help test and verify this 
change, we came to the conclusion it makes the most sense to focus maintenance 
efforts on the default FlowFileRepository implementation and deprecate the 
RocksDB variant.

For now, we will bump the version of RocksDB for arm64 compatibility on macOS, 
but this ticket is also to extract it to its own module to isolate it, and also 
mark it as deprecated with an eye on dropping it in a future major version of 
NiFi.

*MIGRATION GUIDANCE NOTE*
Users of the {{RocksDBFlowFileRepository}} will have to download the new 
{{org.apache.nifi::nifi-rocksdb-nar::x.y.z}} and add it to the lib directory 
after upgrading past 1.16.3





{noformat}
[INFO] -< org.apache.nifi:nifi-rocksdb-utils >-
[INFO] Building nifi-rocksdb-utils 1.16.0-SNAPSHOT [35/642]
[INFO] [ jar ]-
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-maven-version) @ 
nifi-rocksdb-utils ---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-java-version) @ 
nifi-rocksdb-utils ---
[INFO]
[INFO] --- maven-remote-resources-plugin:1.7.0:process 
(process-resource-bundles) @ nifi-rocksdb-utils ---
[INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] Copying 3 resources from 1 bundle.
[INFO]
[INFO] --- maven-resources-plugin:3.2.0:resources (default-resources) @ 
nifi-rocksdb-utils ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Using 'UTF-8' encoding to copy filtered properties files.
[INFO] skip non existing resourceDirectory 
/Users/kdoran/dev/code/nifi/nifi-commons/nifi-rocksdb-utils/src/main/resources
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.9.0:compile (default-compile) @ 
nifi-rocksdb-utils ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-resources-plugin:3.2.0:testResources (default-testResources) @ 
nifi-rocksdb-utils ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Using 'UTF-8' encoding to copy filtered properties files.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO]
[INFO] --- maven-compiler-plugin:3.9.0:testCompile (default-testCompile) @ 
nifi-rocksdb-utils ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-compiler-plugin:3.9.0:testCompile (groovy-tests) @ 
nifi-rocksdb-utils ---
[INFO] Changes detected - recompiling the module!
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M5:test (default-test) @ 
nifi-rocksdb-utils ---
[INFO]
[INFO] ---
[INFO]  T E S T S
[INFO] ---
[INFO] Running org.apache.nifi.rocksdb.TestRocksDBMetronome
[ERROR] Tests run: 10, Failures: 2, Errors: 7, Skipped: 0, Time elapsed: 0.097 
s <<< FAILURE! - in org.apache.nifi.rocksdb.TestRocksDBMetronome
[ERROR] org.apache.nifi.rocksdb.TestRocksDBMetronome.testColumnFamilies(Path)  
Time elapsed: 0.058 s  <<< ERROR!
java.lang.UnsatisfiedLinkError: 
/private/var/folders/dj/1c85sd0d6dvcp1fltmwr5nl4gn/T/librocksdbjni1540031708884427750.jnilib:
 
dlopen(/private/var/folders/dj/1c85sd0d6dvcp1fltmwr5nl4gn/T/librocksdbjni1540031708884427750.jnilib,
 0x0001): tried: 
'/private/var/folders/dj/1c85sd0d6dvcp1fltmwr5nl4gn/T/librocksdbjni1540031708884427750.jnilib'
 (mach-o file, but is an incompatible architecture (have 'x86_64', need 
'arm64e')), '/usr/lib/librocksdbjni1540031708884427750.jnilib' (no such file)
at 
org.apache.nifi.rocksdb.TestRocksDBMetronome.testColumnFamilies(TestRocksDBMetronome.java:170)

[ERROR] org.apache.nifi.rocksdb.TestRocksDBMetronome.testWaitForSync(Path)  
Time elapsed: 0.003 s  <<< ERROR!
java.lang.NoClassDefFoundError: Could not initialize class org.rocksdb.RocksDB
at 
org.apache.nifi.rocksdb.TestRocksDBMetronome.testWaitForSync(TestRocksDBMetronome.java:267)

[ERROR] 
org.apache.nifi.rocksdb.TestRocksDBMetronome.testWaitForSyncWithValue(Path)  
Time elapsed: 0.001 s  <<< ERROR!
java.lang.NoClassDefFoundError: Could not initialize class org.rocksdb.RocksDB
at 
org.apache.nifi.rocksdb.TestRocksDBMetronome.testWaitForSyncWithValue(TestRocksDBMetronome.java:299)

[ERROR] org.apache.nifi.rocksdb.TestRocksDBMetronome.testCounterIncrement(Path) 
 Time elapsed: 0.001 s  <<< ERROR!
java.lang.NoClassDefFoundError: Could not initialize class 

[GitHub] [nifi] kevdoran commented on a diff in pull request #6155: NIFI-9810 Isolate and deprecate RocksDB repository

2022-06-29 Thread GitBox


kevdoran commented on code in PR #6155:
URL: https://github.com/apache/nifi/pull/6155#discussion_r910253814


##
nifi-nar-bundles/nifi-rocksdb-bundle/nifi-rocksdb-nar/pom.xml:
##
@@ -0,0 +1,41 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
https://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+nifi-rocksdb-bundle
+org.apache.nifi
+1.17.0-SNAPSHOT
+
+4.0.0
+
+nifi-rocksdb-nar
+nar
+
+
+true
+true
+
+
+
+
+org.apache.nifi

Review Comment:
   Good catch, corrected in the latest



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6155: NIFI-9810 Isolate and deprecate RocksDB repository

2022-06-29 Thread GitBox


exceptionfactory commented on code in PR #6155:
URL: https://github.com/apache/nifi/pull/6155#discussion_r910235137


##
nifi-nar-bundles/nifi-rocksdb-bundle/nifi-rocksdb-nar/pom.xml:
##
@@ -0,0 +1,41 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
https://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+
+nifi-rocksdb-bundle
+org.apache.nifi
+1.17.0-SNAPSHOT
+
+4.0.0
+
+nifi-rocksdb-nar
+nar
+
+
+true
+true
+
+
+
+
+org.apache.nifi

Review Comment:
   It looks like this NAR dependency tree is missing `nifi-rocksdb-repository`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] kevdoran commented on pull request #6155: NIFI-9810 Isolate and deprecate RocksDB repository

2022-06-29 Thread GitBox


kevdoran commented on PR #6155:
URL: https://github.com/apache/nifi/pull/6155#issuecomment-1170272091

   Thanks for the review and feedback @exceptionfactory! This is a good idea, 
and given the limited usage of this implementation, excluding it from the 
convenience binary makes sense. I've moved the implementation to its own NAR 
now and here are the new testing instructions:
   
   ```
   # Build full project
   
   # Copy the new nifi-rocksdb-nar to the assembly lib dir:
   > cp 
nifi-nar-bundles/nifi-rocksdb-bundle/nifi-rocksdb-nar/target/nifi-rocksdb-nar-1.17.0-SNAPSHOT.nar
 nifi-assembly/target/nifi-1.17.0-SNAPSHOT-bin/nifi-1.17.0-SNAPSHOT/lib
   
   # Edit the assembly nifi.properties to have the following: 
nifi.flowfile.repository.implementation=org.apache.nifi.controller.repository.RocksDBFlowFileRepository
   
   # Start NiFi and verify it works as expected
   > 
./nifi-assembly/target/nifi-1.17.0-SNAPSHOT-bin/nifi-1.17.0-SNAPSHOT/bin/nifi.sh
 run
   ```
   
   This is still failing at runtime when using those steps, so I need to fix 
something 
   
   @joewitt - This PR will update the Administration Guide appropriately, and 
I've added a note to the JIRA about the need for special migration guidance
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] joewitt commented on pull request #6155: NIFI-9810 Isolate and deprecate RocksDB repository

2022-06-29 Thread GitBox


joewitt commented on PR #6155:
URL: https://github.com/apache/nifi/pull/6155#issuecomment-1170254815

   ahh good catch.  We should flag this in the migration guidance too that this 
module is no longer bundled by default but is available like other nars.  We 
should flag that in the docs whereever this thing is referenced too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10180) Remove Unnecessary Maven Repositories

2022-06-29 Thread Joe Witt (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Joe Witt updated  NIFI-10180  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi /  NIFI-10180  
 
 
  Remove Unnecessary Maven Repositories   
 

  
 
 
 
 

 
Change By: 
 Joe Witt  
 
 
Fix Version/s: 
 1.17.0  
 
 
Resolution: 
 Fixed  
 
 
Status: 
 Patch Available Resolved  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Updated] (NIFI-10173) Upgrade Flume to 1.10.0

2022-06-29 Thread Joe Witt (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Joe Witt updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi /  NIFI-10173  
 
 
  Upgrade Flume to 1.10.0   
 

  
 
 
 
 

 
Change By: 
 Joe Witt  
 
 
Fix Version/s: 
 1.17.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Commented] (NIFI-10180) Remove Unnecessary Maven Repositories

2022-06-29 Thread ASF subversion and git services (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 ASF subversion and git services commented on  NIFI-10180  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Remove Unnecessary Maven Repositories   
 

  
 
 
 
 

 
 Commit 6997f17bff9270da4877fad3a53a8f4a9feae9ad in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6997f17bff ] NIFI-10180 This closes #6168. Removed standard Maven repository definitions 
 
Upgraded Apache parent from 25 to 26 
Upgraded Apache Rat Plugin from 0.13 to 0.14 
Upgraded Maven Compiler Plugin from 3.9.0 to 3.10.1 
Removed Confluent repository from Confluent Registry Service module 
Removed MapR repository profile configuration 
Removed Hortonworks repository profile configuration 
 Signed-off-by: Joe Witt   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Commented] (NIFI-10173) Upgrade Flume to 1.10.0

2022-06-29 Thread ASF subversion and git services (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 ASF subversion and git services commented on  NIFI-10173  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Upgrade Flume to 1.10.0   
 

  
 
 
 
 

 
 Commit ee3dcc78bf58ff02af9351ac9593978b0b5cd0e4 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ee3dcc78bf ] NIFI-10173 This closes #6164. Upgraded Flume from 1.6.0 to 1.10.0 
 
Removed unmaintained flume-dataset-sink and flume-ng-elasticsearch-sink dependencies 
Added dependency-check suppression configuration for false positives on Flume libraries 
 Signed-off-by: Joe Witt   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[GitHub] [nifi] asfgit closed pull request #6164: NIFI-10173 Upgrade Flume from 1.6.0 to 1.10.0

2022-06-29 Thread GitBox


asfgit closed pull request #6164: NIFI-10173 Upgrade Flume from 1.6.0 to 1.10.0
URL: https://github.com/apache/nifi/pull/6164


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] asfgit closed pull request #6168: NIFI-10180 Remove Unnecessary Maven Repository Definitions

2022-06-29 Thread GitBox


asfgit closed pull request #6168: NIFI-10180 Remove Unnecessary Maven 
Repository Definitions
URL: https://github.com/apache/nifi/pull/6168


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-10173) Upgrade Flume to 1.10.0

2022-06-29 Thread Joe Witt (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Joe Witt commented on  NIFI-10173  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Upgrade Flume to 1.10.0   
 

  
 
 
 
 

 
 reviewing  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[GitHub] [nifi] Lehel44 commented on a diff in pull request #6034: NIFI-9916: ListenTrapSNMP USM parsing refactor.

2022-06-29 Thread GitBox


Lehel44 commented on code in PR #6034:
URL: https://github.com/apache/nifi/pull/6034#discussion_r910137822


##
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/operations/SNMPTrapReceiverHandlerTest.java:
##
@@ -95,22 +88,17 @@ public void testCloseTrapReceiverCleansUpResources() throws 
IOException {
 }
 
 @Test
-public void testAddUsmUsers() throws JsonProcessingException, 
FileNotFoundException {
+public void testAddUsmUsers() {

Review Comment:
   Thanks for the suggestion!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-10169) JoinEnrichment merged schema incorrect if first Enrichment record is null

2022-06-29 Thread ASF subversion and git services (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 ASF subversion and git services commented on  NIFI-10169  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: JoinEnrichment merged schema incorrect if first Enrichment record is null   
 

  
 
 
 
 

 
 Commit 39c366eeef6a8c5be496ccab9c395a4fe94be9c3 in nifi's branch refs/heads/main from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=39c366eeef ] NIFI-10169: When using the Insert Record Fields join strategy of JoinEnrichment, ensure that in order to combine schemas from the original record and the enrichment record we use incorporateSchema() so that even when the first enrichment record is null, we get the schema correct Signed-off-by: Pierre Villard  This closes #6157.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Updated] (NIFI-10169) JoinEnrichment merged schema incorrect if first Enrichment record is null

2022-06-29 Thread Pierre Villard (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Pierre Villard updated  NIFI-10169  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi /  NIFI-10169  
 
 
  JoinEnrichment merged schema incorrect if first Enrichment record is null   
 

  
 
 
 
 

 
Change By: 
 Pierre Villard  
 
 
Resolution: 
 Fixed  
 
 
Status: 
 Patch Available Resolved  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[GitHub] [nifi] asfgit closed pull request #6157: NIFI-10169: When using the Insert Record Fields join strategy of Join…

2022-06-29 Thread GitBox


asfgit closed pull request #6157: NIFI-10169: When using the Insert Record 
Fields join strategy of Join…
URL: https://github.com/apache/nifi/pull/6157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (NIFI-10174) Upgrade to Spring Framework 5.3.21 and Spring Security to 5.7.2

2022-06-29 Thread Pierre Villard (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Pierre Villard updated  NIFI-10174  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi /  NIFI-10174  
 
 
  Upgrade to Spring Framework 5.3.21 and Spring Security to 5.7.2   
 

  
 
 
 
 

 
Change By: 
 Pierre Villard  
 
 
Fix Version/s: 
 1.17.0  
 
 
Resolution: 
 Fixed  
 
 
Status: 
 Patch Available Resolved  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[GitHub] [nifi] asfgit closed pull request #6165: NIFI-10174 Upgrade Spring Framework from 5.3.20 to 5.3.21

2022-06-29 Thread GitBox


asfgit closed pull request #6165: NIFI-10174 Upgrade Spring Framework from 
5.3.20 to 5.3.21
URL: https://github.com/apache/nifi/pull/6165


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-10174) Upgrade to Spring Framework 5.3.21 and Spring Security to 5.7.2

2022-06-29 Thread ASF subversion and git services (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 ASF subversion and git services commented on  NIFI-10174  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Upgrade to Spring Framework 5.3.21 and Spring Security to 5.7.2   
 

  
 
 
 
 

 
 Commit 4a9c3435dbf466e6df6e1ac62bac4b89c88a195e in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4a9c3435db ] NIFI-10174 Upgraded Spring Framework from 5.3.20 to 5.3.21 
 
Upgraded Spring Security from 5.7.1 to 5.7.2 
Upgraded Spring Boot from 2.7.0 to 2.7.1 for NiFi Registry 
 Signed-off-by: Pierre Villard  This closes #6165.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Updated] (NIFI-10175) Upgrade Jetty to 9.4.48

2022-06-29 Thread Pierre Villard (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Pierre Villard updated  NIFI-10175  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi /  NIFI-10175  
 
 
  Upgrade Jetty to 9.4.48   
 

  
 
 
 
 

 
Change By: 
 Pierre Villard  
 
 
Fix Version/s: 
 1.17.0  
 
 
Resolution: 
 Fixed  
 
 
Status: 
 Patch Available Resolved  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Commented] (NIFI-10175) Upgrade Jetty to 9.4.48

2022-06-29 Thread ASF subversion and git services (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 ASF subversion and git services commented on  NIFI-10175  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Upgrade Jetty to 9.4.48   
 

  
 
 
 
 

 
 Commit 5bdede1fab7cbde997e686283e312cc8a3de8746 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5bdede1fab ] NIFI-10175 Upgraded Jetty from 9.4.46 to 9.4.48 Signed-off-by: Pierre Villard  This closes #6166.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[GitHub] [nifi] asfgit closed pull request #6166: NIFI-10175 Upgrade Jetty from 9.4.46 to 9.4.48

2022-06-29 Thread GitBox


asfgit closed pull request #6166: NIFI-10175 Upgrade Jetty from 9.4.46 to 9.4.48
URL: https://github.com/apache/nifi/pull/6166


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Resolved] (NIFI-4670) when i start consumerKafka processor more than eleven,all of the processors get into an indefinite stuck state

2022-06-29 Thread Mark Payne (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mark Payne resolved as Cannot Reproduce  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi /  NIFI-4670  
 
 
  when i start consumerKafka processor more than eleven,all of the processors get into an indefinite stuck state   
 

  
 
 
 
 

 
Change By: 
 Mark Payne  
 
 
Resolution: 
 Cannot Reproduce  
 
 
Status: 
 Open Resolved  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[GitHub] [nifi] pvillard31 commented on pull request #6167: NIFI-10176 Upgrade OkHttp from 4.9.3 to 4.10.0

2022-06-29 Thread GitBox


pvillard31 commented on PR #6167:
URL: https://github.com/apache/nifi/pull/6167#issuecomment-1170109468

   Merged with 
https://github.com/apache/nifi/commit/4cb9997ea299ba1b112dc58f19e73f8349551f34.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [nifi] pvillard31 closed pull request #6167: NIFI-10176 Upgrade OkHttp from 4.9.3 to 4.10.0

2022-06-29 Thread GitBox


pvillard31 closed pull request #6167: NIFI-10176 Upgrade OkHttp from 4.9.3 to 
4.10.0
URL: https://github.com/apache/nifi/pull/6167


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (NIFI-10176) Upgrade OkHttp to 4.10.0

2022-06-29 Thread ASF subversion and git services (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 ASF subversion and git services commented on  NIFI-10176  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Upgrade OkHttp to 4.10.0   
 

  
 
 
 
 

 
 Commit 4cb9997ea299ba1b112dc58f19e73f8349551f34 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4cb9997ea2 ] NIFI-10176 Upgraded OkHttp from 4.9.3 to 4.10.0 Signed-off-by: Pierre Villard  This closes #6167.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Updated] (NIFI-10176) Upgrade OkHttp to 4.10.0

2022-06-29 Thread Pierre Villard (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Pierre Villard updated  NIFI-10176  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi /  NIFI-10176  
 
 
  Upgrade OkHttp to 4.10.0   
 

  
 
 
 
 

 
Change By: 
 Pierre Villard  
 
 
Fix Version/s: 
 1.17.0  
 
 
Resolution: 
 Fixed  
 
 
Status: 
 Patch Available Resolved  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Commented] (NIFI-10143) ListFTP/GetFTP has issues with danish special characters (UTF-8)

2022-06-29 Thread Paul Grey (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Paul Grey commented on  NIFI-10143  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: ListFTP/GetFTP has issues with danish special characters (UTF-8)   
 

  
 
 
 
 

 
 Thanks for those details. I guess what we've found is a disconnect between the native character encoding of Windows and its UTF-8 support for the FTP protocol.  When you create a folder or a file in Windows Explorer, the name is stored using the native encoding.  This name is only compatible with UTF-8 for characters up to code point 127 (which covers the English alphabet). (1) Since the representation of "æøå/æøå.txt" is different in code page 437 versus UTF-8, the MS FTP server does not "see" the folder/file requested by ListFTP.  Since Linux uses UTF-8 as its native encoding, these issues don't typically exist. (2) This might be the basis of a solution that will work for you.  Since this PutFTP has UTF-8 enabled, and MS FTP has UTF-8 enabled, the folder / filename is encoded as UTF-8 in the Windows filesystem, and it is thus visible to ListFTP.  When you do this, the Windows Explorer view of the filenames is garbled, as you noted, because Explorer doesn't understand the UTF-8 characters.  MS FTP understands UTF-8 (if enabled), but the filesystem does not. If PutFTP and ListFTP are used with UTF-8 disabled, then they communicate using the native encoding of the machine on which they are run.  If this native encoding matches that of the MS FTP server, this should work for any character representable in that encoding.  So this is why Danish works but Arabic doesn't; Danish characters can be represented in code page 437, but Arabic characters cannot. FileZilla must have been developed to have an awareness of both UTF-8 and the native machine encoding, and to try both when servicing a request. Since you earlier indicated a need for MS-AD and NTFS rights, you should be able to use MS FTP (with UTF-8 enabled) to do what you need (Put, List, Fetch).  You will want to avoid file / folder naming through Windows Explorer in your designated FTP folder. One other wrinkle.  It may be possible to open an MS command prompt on your FTP server and to switch its code page to be UTF-8.  You would then be able to create files / folders in that command prompt window that MS FTP would be able to serve to UTF-8 clients.  (These names would appear garbled in Windows Explorer.)  I recommend extreme caution if you consider any of the options discussed in this link. https://stackoverflow.com/questions/57131654/using-utf-8-encoding-chcp-65001-in-command-prompt-windows-powershell-window    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 

[jira] [Assigned] (MINIFICPP-1830) Verify regex properties in processors in case it is set to empty

2022-06-29 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gábor Gyimesi assigned an issue to Gábor Gyimesi  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi MiNiFi C++ /  MINIFICPP-1830  
 
 
  Verify regex properties in processors in case it is set to empty   
 

  
 
 
 
 

 
Change By: 
 Gábor Gyimesi  
 
 
Assignee: 
 Gábor Gyimesi  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Commented] (NIFI-10180) Remove Unnecessary Maven Repositories

2022-06-29 Thread Joe Witt (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Joe Witt commented on  NIFI-10180  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Remove Unnecessary Maven Repositories   
 

  
 
 
 
 

 
 will happily review as you continue to crush tech debt ruthlessly. love it. thanks  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Updated] (NIFI-10180) Remove Unnecessary Maven Repositories

2022-06-29 Thread David Handermann (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 David Handermann updated  NIFI-10180  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi /  NIFI-10180  
 
 
  Remove Unnecessary Maven Repositories   
 

  
 
 
 
 

 
Change By: 
 David Handermann  
 
 
Status: 
 Open Patch Available  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[GitHub] [nifi] exceptionfactory opened a new pull request, #6168: NIFI-10180 Remove Unnecessary Maven Repository Definitions

2022-06-29 Thread GitBox


exceptionfactory opened a new pull request, #6168:
URL: https://github.com/apache/nifi/pull/6168

   # Summary
   
   [NIFI-10180](https://issues.apache.org/jira/browse/NIFI-10180) Removes 
unnecessary Maven Repository definitions from the root configuration.
   
   The Shibboleth repository is no longer necessary following the upgrade to 
Spring Security 5 for SAML integration. Other repository definitions 
unnecessarily override Maven Central and Apache Snapshots available through the 
parent Apache Maven configuration, and standard Maven settings. The optional 
MapR and Hortonworks repository profiles are also removed, as well as the 
Confluent repository in the Confluent Registry Service module.
   
   Additional changes include the follow upgrades:
   
   - Upgraded Apache parent from 25 to 26
   - Upgraded Apache Rat Plugin from 0.13 to 0.14
   - Upgraded Maven Compiler Plugin from 3.9.0 to 3.10.1
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 8
 - [ ] JDK 11
 - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-10180) Remove Unnecessary Maven Repositories

2022-06-29 Thread David Handermann (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 David Handermann created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi /  NIFI-10180  
 
 
  Remove Unnecessary Maven Repositories   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 David Handermann  
 
 
Components: 
 Tools and Build  
 
 
Created: 
 29/Jun/22 14:24  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 David Handermann  
 

  
 
 
 
 

 
 The Maven build configuration contains several unnecessary repository definitions that should be removed. The Shibboleth repository is no longer necessary following the migration to Spring Security 5 for SAML integration, and other custom repository definitions can be removed.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

   

[GitHub] [nifi] tpalfy commented on a diff in pull request #6034: NIFI-9916: ListenTrapSNMP USM parsing refactor.

2022-06-29 Thread GitBox


tpalfy commented on code in PR #6034:
URL: https://github.com/apache/nifi/pull/6034#discussion_r909616877


##
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/resources/docs/org.apache.nifi.snmp.processors.ListenTrapSNMP/additionalDetails.html:
##
@@ -24,10 +24,11 @@
 Summary
 
 This processor listens to SNMP traps and creates a flowfile from the trap 
PDU.
-The versions SNMPv1, SNMPv2c and SNMPv3 are supproted. The component is 
based on http://www.snmp4j.org/;>SNMP4J.
+The versions SNMPv1, SNMPv2c and SNMPv3 are supported. The component is 
based on http://www.snmp4j.org/;>SNMP4J.
 
 
-In case of SNMPv3, users can be specified in a json file. E.g.:
+SNMPv3 has user-based security. There are three ways to specify the USM 
user database and these can be selected using the USM Users Source property.

Review Comment:
   ```suggestion
   SNMPv3 has user-based security. There are three ways to specify the USM 
user database and can be selected using the USM Users Source property.
   ```



##
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/utils/UsmReader.java:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.snmp.utils;
+
+import com.fasterxml.jackson.core.JsonParser;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.DeserializationContext;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
+import com.fasterxml.jackson.databind.module.SimpleModule;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.snmp4j.security.UsmUser;
+import org.snmp4j.smi.OID;
+import org.snmp4j.smi.OctetString;
+
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Scanner;
+import java.util.stream.Collectors;
+
+public interface UsmReader {

Review Comment:
   This factory interface pattern (for a lack of better words) is imaginative 
but quite unusual and has some drawbacks.
   
   The
   ```
   List readUsm(String usmUsers);
   ```
   method has parameter that can mean different things and based on that the 
implementation logic is different.
   
   I'd rather have that "different thing" passed on to regular implementations 
via constructor.
   The solution overall would be cleaner and more conventional.
   
   Also writing tests to those implementations would be straightforward - the 
current implementations lack proper testing.



##
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/operations/SNMPTrapReceiverHandler.java:
##
@@ -38,27 +33,28 @@
 import org.snmp4j.smi.Integer32;
 import org.snmp4j.smi.OctetString;
 
-import java.io.File;
-import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.util.List;
-import java.util.Scanner;
 
 public class SNMPTrapReceiverHandler {
 
 private static final Logger logger = 
LoggerFactory.getLogger(SNMPTrapReceiverHandler.class);
 
 private final SNMPConfiguration configuration;
-private final String usmUsersFilePath;
+private final List usmUsers;
 private Snmp snmpManager;
 private boolean isStarted;
 
-public SNMPTrapReceiverHandler(final SNMPConfiguration configuration, 
final String usmUsersFilePath) {
+public SNMPTrapReceiverHandler(final SNMPConfiguration configuration, 
final List usmUsers) {
 this.configuration = configuration;
-this.usmUsersFilePath = usmUsersFilePath;
+this.usmUsers = usmUsers;
 snmpManager = new 
SNMPManagerFactory().createSnmpManagerInstance(configuration);
 }
 
+public SNMPTrapReceiverHandler(final SNMPConfiguration configuration) {

Review Comment:
   This constructor is not used, can be removed.



##
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/test/java/org/apache/nifi/snmp/operations/SNMPTrapReceiverHandlerTest.java:
##
@@ 

[jira] [Created] (NIFI-10179) Add to ReplaceText the possibility to specify the search and replacement values with an attribute or parameter

2022-06-29 Thread Andrea Molteni (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Andrea Molteni created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi /  NIFI-10179  
 
 
  Add to ReplaceText the possibility to specify the search and replacement values with an attribute or parameter   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Affects Versions: 
 1.16.3  
 
 
Assignee: 
 Unassigned  
 
 
Attachments: 
 image.png  
 
 
Components: 
 Core Framework  
 
 
Created: 
 29/Jun/22 13:07  
 
 
Labels: 
 replace improvement  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Andrea Molteni  
 

  
 
 
 
 

 
 Actually the ReplaceText processor can be programmed with a replacement strategy of kind : Regex Replace. This means that the properties Replacement value and replace value can host some EL attribute or parameters. The regex itself will not be in the attribute, but it is intended that the user wants to use the attribute as some part of it.  eg ov value supported value: (.{${mynumber}})(.*) but if i prepare the regex search and replacement value in a dedicated attribute of the flowfile then it is not possible to set the property to the attribute content  (see attached image)    
 

  
 
 
 
 

 

[jira] [Assigned] (MINIFICPP-1872) Unify test utilities

2022-06-29 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gábor Gyimesi assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi MiNiFi C++ /  MINIFICPP-1872  
 
 
  Unify test utilities   
 

  
 
 
 
 

 
Change By: 
 Gábor Gyimesi  
 
 
Assignee: 
 Gábor Gyimesi  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Updated] (MINIFICPP-1843) Implement PutElasticsearchJson and ElasticSearchClientServiceImpl

2022-06-29 Thread Martin Zink (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Zink updated  MINIFICPP-1843  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 https://github.com/apache/nifi-minifi-cpp/commit/f2d977ec7249757c93dbfdda10a3fc5fee25399c  
 

  
 
 
 
 

 
 Apache NiFi MiNiFi C++ /  MINIFICPP-1843  
 
 
  Implement PutElasticsearchJson and ElasticSearchClientServiceImpl   
 

  
 
 
 
 

 
Change By: 
 Martin Zink  
 
 
Resolution: 
 Fixed  
 
 
Status: 
 Patch Available Resolved  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Updated] (MINIFICPP-1700) Change leftover integers to std::chrono from MINIFICPP-1688

2022-06-29 Thread Martin Zink (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Zink updated  MINIFICPP-1700  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 https://github.com/apache/nifi-minifi-cpp/commit/58a3041fa0efc635b5f6a8fedafda55f3448e676  
 

  
 
 
 
 

 
 Apache NiFi MiNiFi C++ /  MINIFICPP-1700  
 
 
  Change leftover integers to std::chrono from MINIFICPP-1688   
 

  
 
 
 
 

 
Change By: 
 Martin Zink  
 
 
Resolution: 
 Fixed  
 
 
Status: 
 Patch Available Resolved  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Updated] (MINIFICPP-1863) PutGCSObject has NumberOfRetries twice in properties()

2022-06-29 Thread Martin Zink (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Zink updated  MINIFICPP-1863  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 https://github.com/apache/nifi-minifi-cpp/commit/4481f28824a73fcfe7ac8f46575bb58caf7cecc7  
 

  
 
 
 
 

 
 Apache NiFi MiNiFi C++ /  MINIFICPP-1863  
 
 
  PutGCSObject has NumberOfRetries twice in properties()   
 

  
 
 
 
 

 
Change By: 
 Martin Zink  
 
 
Resolution: 
 Fixed  
 
 
Status: 
 Patch Available Resolved  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Updated] (MINIFICPP-1842) getTimeStr should use std::chrono

2022-06-29 Thread Martin Zink (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Zink updated  MINIFICPP-1842  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 https://github.com/apache/nifi-minifi-cpp/commit/58a3041fa0efc635b5f6a8fedafda55f3448e676  
 

  
 
 
 
 

 
 Apache NiFi MiNiFi C++ /  MINIFICPP-1842  
 
 
  getTimeStr should use std::chrono   
 

  
 
 
 
 

 
Change By: 
 Martin Zink  
 
 
Resolution: 
 Fixed  
 
 
Status: 
 Patch Available Resolved  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1361: Fix corrupted clcache in windows build

2022-06-29 Thread GitBox


lordgamez opened a new pull request, #1361:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1361

   Windows build became corrupted in 
https://github.com/apache/nifi-minifi-cpp/runs/7108938306 due to missing cache 
object. Cache key is updated in this change.
   
   https://issues.apache.org/jira/browse/MINIFICPP-1877
   
   ---
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI 
results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (MINIFICPP-1877) Windows cache corrupted in CI

2022-06-29 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gábor Gyimesi assigned an issue to Gábor Gyimesi  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi MiNiFi C++ /  MINIFICPP-1877  
 
 
  Windows cache corrupted in CI   
 

  
 
 
 
 

 
Change By: 
 Gábor Gyimesi  
 
 
Assignee: 
 Gábor Gyimesi  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Created] (MINIFICPP-1877) Windows cache corrupted in CI

2022-06-29 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gábor Gyimesi created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi MiNiFi C++ /  MINIFICPP-1877  
 
 
  Windows cache corrupted in CI   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 29/Jun/22 10:54  
 
 
Priority: 
  Trivial  
 
 
Reporter: 
 Gábor Gyimesi  
 

  
 
 
 
 

 
 Cache object is corrupted in CI for windows build. Cache key should be updated to avoid this issue.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 
   

[jira] [Assigned] (MINIFICPP-1853) Enable multiple metrics from the same processor type

2022-06-29 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gábor Gyimesi assigned an issue to Gábor Gyimesi  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi MiNiFi C++ /  MINIFICPP-1853  
 
 
  Enable multiple metrics from the same processor type   
 

  
 
 
 
 

 
Change By: 
 Gábor Gyimesi  
 
 
Assignee: 
 Gábor Gyimesi  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[jira] [Assigned] (MINIFICPP-1872) Unify test utilities

2022-06-29 Thread Jira
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gábor Gyimesi assigned an issue to Gábor Gyimesi  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi MiNiFi C++ /  MINIFICPP-1872  
 
 
  Unify test utilities   
 

  
 
 
 
 

 
Change By: 
 Gábor Gyimesi  
 
 
Assignee: 
 Gábor Gyimesi  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)  
 
 

 
   
 

  
 

  
 

   



[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1360: MINIFICPP-1853 Enable multiple metrics from the same processor type

2022-06-29 Thread GitBox


lordgamez opened a new pull request, #1360:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1360

   https://issues.apache.org/jira/browse/MINIFICPP-1853
   
   --
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI 
results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (NIFI-10178) nifi 1.16.X security advice

2022-06-29 Thread Hadiiiiiiiii (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Hadi created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Apache NiFi /  NIFI-10178  
 
 
  nifi 1.16.X security advice   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Affects Versions: 
 1.16.3, 1.16.2, 1.16.1  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 Core Framework  
 
 
Created: 
 29/Jun/22 08:09  
 
 
Environment: 
 linux  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Hadi  
 

  
 
 
 
 

 
 some dependency need update in nifi-framework-nar/nifi-hadoop-libraries-nar/nifi-hive-nar 

 


org.apache.velocity
velocity-engine-core
2.3


commons-collections
commons-collections
3.2.2
  

  
 

  
 
 
 
 

 
 
 

 
 
 Add