[GitHub] [nifi] emiliosetiadarma opened a new pull request, #6931: NIFI-11061: implemented NiFi Registry property for specifying network…
emiliosetiadarma opened a new pull request, #6931: URL: https://github.com/apache/nifi/pull/6931 … interface when connecting over HTTPS # Summary [NIFI-11061](https://issues.apache.org/jira/browse/NIFI-11061) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 8 - [x] JDK 11 - [x] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] nandorsoma opened a new pull request, #6930: NIFI-11144 Fix failing tests for ConsumeJMS/PublishJMS
nandorsoma opened a new pull request, #6930: URL: https://github.com/apache/nifi/pull/6930 # Summary [NIFI-11144](https://issues.apache.org/jira/browse/NIFI-11144) As the title says, this PR intends to fix currently failing tests without changing the behavior of the processors. There are two things worth mentioning. There was an exception propagation in ConsumeJMS. The comment next to it doesn't really make sense. In 2020 a commit was added, which even caught all exceptions in the Abstract class. I tried to figure out what the expectation would be. Propagate it according to the original behavior, or go forward and remove the rethrow part. I decided to do the latter because propagating the exception doesn't make sense in this case. There is no upstream connection, and when "consume" fails, there won't be a flowfile in the output relationship, so rollback is unnecessary, which could be triggered by the exception. The other thing is testMultiplethreads(). It failed with timeout because we reached a limit after publishing a thousand messages. It is probably related to [this](https://activemq.apache.org/how-to-deal-with-large-number-of-threads-in-clients). I tried multiple different configurations without luck. It is a hint, but maybe not all of them work with the test broker implementation. Ultimately I decided to set the total messages to that threshold. This way, we can spare the additional configuration, and one thousand messages should be enough for the purpose of the test. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] Lehel44 commented on a diff in pull request #6853: NIFI-11045: Sensitive dynamic property support for parameterized quer…
Lehel44 commented on code in PR #6853:
URL: https://github.com/apache/nifi/pull/6853#discussion_r1098077362
##
nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/main/java/org/apache/nifi/util/db/JdbcCommon.java:
##
@@ -711,18 +711,59 @@ public static void setParameters(final PreparedStatement
stmt, final Map attributes) throws SQLException {
Review Comment:
- According to @turcsanyip's remarks, since logging occurs only in the
setParameter method if the flowfile attribute is "sql.arguments.*type," and
- @exceptionfactory - filtering out the type is not needed
we may revert to the old behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] NissimShiman commented on pull request #6924: NIFI-10950 DistributeLoad processor - removed unsupported Load Distribution Service
NissimShiman commented on PR #6924: URL: https://github.com/apache/nifi/pull/6924#issuecomment-1419967037 Thank you @joewitt ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10581) Update to Apache Tika 2.6.0
[ https://issues.apache.org/jira/browse/NIFI-10581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10581: Issue Type: Improvement (was: Task) > Update to Apache Tika 2.6.0 > --- > > Key: NIFI-10581 > URL: https://issues.apache.org/jira/browse/NIFI-10581 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: David Handermann >Priority: Major > Fix For: 1.20.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10580) Update NiFi to use SLF4j 2.x line instead of 1.x line
[ https://issues.apache.org/jira/browse/NIFI-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10580: Issue Type: Improvement (was: Task) > Update NiFi to use SLF4j 2.x line instead of 1.x line > - > > Key: NIFI-10580 > URL: https://issues.apache.org/jira/browse/NIFI-10580 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: David Handermann >Priority: Major > Fix For: 1.20.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-10618) Add GetAsanaObject Processor
[ https://issues.apache.org/jira/browse/NIFI-10618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-10618: Summary: Add GetAsanaObject Processor (was: Asana source connector) > Add GetAsanaObject Processor > > > Key: NIFI-10618 > URL: https://issues.apache.org/jira/browse/NIFI-10618 > Project: Apache NiFi > Issue Type: New Feature > Components: Extensions >Reporter: Rajmund Takacs >Assignee: Rajmund Takacs >Priority: Major > Labels: Asana > Fix For: 1.20.0 > > Time Spent: 12h > Remaining Estimate: 0h > > Connector to incrementally fetch data from Asana. It should be possible to > select the type of information being collected. Example: collect the tasks. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11103) Conduct Apache NiFi 1.20 release
[ https://issues.apache.org/jira/browse/NIFI-11103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684940#comment-17684940 ] ASF subversion and git services commented on NIFI-11103: Commit 81296b5b69a69d26afb8f8dec3a58a8363653890 in nifi's branch refs/heads/NIFI-11103-RC1 from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=81296b5b69 ] NIFI-11103-RC1 prepare release nifi-1.20.0-RC1 > Conduct Apache NiFi 1.20 release > > > Key: NIFI-11103 > URL: https://issues.apache.org/jira/browse/NIFI-11103 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.20.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11103) Conduct Apache NiFi 1.20 release
[ https://issues.apache.org/jira/browse/NIFI-11103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684941#comment-17684941 ] ASF subversion and git services commented on NIFI-11103: Commit 896fdacbbd0c656dce3f9ebbf552b76fea3f66b6 in nifi's branch refs/heads/NIFI-11103-RC1 from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=896fdacbbd ] NIFI-11103-RC1 prepare for next development iteration > Conduct Apache NiFi 1.20 release > > > Key: NIFI-11103 > URL: https://issues.apache.org/jira/browse/NIFI-11103 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.20.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mkalavala opened a new pull request, #6929: NIFI-11116 Refactor nifi-registry/nifi-registry-core to use JUnit5
mkalavala opened a new pull request, #6929: URL: https://github.com/apache/nifi/pull/6929 # Summary [NIFI-6](https://issues.apache.org/jira/browse/NIFI-6) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [x] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-9131) Refactor nifi-ldap-iaa-providers-bundle to use JUnit 5
[ https://issues.apache.org/jira/browse/NIFI-9131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684898#comment-17684898 ] David Handermann commented on NIFI-9131: [~dstiegli1] Although code licensed under Apache Software License 2.0 can be brought into the NiFi repository, that may not be the best solution. [~mkalavala] has started looking into options for the LDAP tests, which should avoid the need for copying code. > Refactor nifi-ldap-iaa-providers-bundle to use JUnit 5 > -- > > Key: NIFI-9131 > URL: https://issues.apache.org/jira/browse/NIFI-9131 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Mike Thomsen >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11130) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions
[
https://issues.apache.org/jira/browse/NIFI-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684896#comment-17684896
]
David Handermann commented on NIFI-11130:
-
Thanks for the updates [~dstiegli1], the current pull request for these changes
looks helpful.
I agree that the Spock tests should be covered under NIFI-10047. We should also
move away from Spock as a subset of the Groovy test migration. That effort will
involve rewriting some portion of those tests.
> Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5
> Assertions
> ---
>
> Key: NIFI-11130
> URL: https://issues.apache.org/jira/browse/NIFI-11130
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A regular expression search
> {code:java}
> assert .*
> {code}
> in nifi/nifi-nar-bundles indicates there are over 100 Groovy assert
> statements.
> Refactor these to use JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11116) Refactor nifi-registry/nifi-registry-core to use JUnit5
[ https://issues.apache.org/jira/browse/NIFI-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manju Kalavala updated NIFI-6: -- Description: Except LdapUserGroupProviderTest refactor all other unit tests to use Junit5. LdapUserGroupProviderTest will be refactored as part of NIFI-9131 > Refactor nifi-registry/nifi-registry-core to use JUnit5 > --- > > Key: NIFI-6 > URL: https://issues.apache.org/jira/browse/NIFI-6 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Manju Kalavala >Assignee: Manju Kalavala >Priority: Major > > Except LdapUserGroupProviderTest refactor all other unit tests to use Junit5. > LdapUserGroupProviderTest will be refactored as part of NIFI-9131 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on pull request #6914: NIFI-11125: Adding unset property handling to AbstractDBCPConnectionPool
exceptionfactory commented on PR #6914: URL: https://github.com/apache/nifi/pull/6914#issuecomment-1419604283 Based on offline discussion with @Lehel44, closing this pull request in favor of evaluation a different approach to code reuse for other Connection Pool services. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6914: NIFI-11125: Adding unset property handling to AbstractDBCPConnectionPool
exceptionfactory closed pull request #6914: NIFI-11125: Adding unset property handling to AbstractDBCPConnectionPool URL: https://github.com/apache/nifi/pull/6914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6596: NIFI-10717 fix inconsistent tests
exceptionfactory commented on code in PR #6596:
URL: https://github.com/apache/nifi/pull/6596#discussion_r1097776857
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/inheritance/MissingComponentsCheck.java:
##
@@ -34,15 +35,15 @@ public FlowInheritability checkInheritability(final
DataFlow existingFlow, final
existingMissingComponents.removeAll(proposedFlow.getMissingComponents());
if (existingMissingComponents.size() > 0) {
-final String missingIds =
StringUtils.join(existingMissingComponents, ",");
+final String missingIds =
StringUtils.join(existingMissingComponents.stream().sorted().collect(Collectors.toList()),
",");
Review Comment:
@ZhewenFu Thanks for the reply. This method also creates two `HashSet`
objects, did you try changing them to `LinkedHashSet` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] gresockj commented on pull request #6658: NIFI-10797 add customisable Elasticsearch REST Client config and Elasticsearch Cluster Sniffer
gresockj commented on PR #6658: URL: https://github.com/apache/nifi/pull/6658#issuecomment-1419563321 Neat ideas for additional ES client configuration. Reviewing now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6525: NIFI-10639 Fix testAddedRowsTwoTables
exceptionfactory commented on PR #6525: URL: https://github.com/apache/nifi/pull/6525#issuecomment-1419562041 Thanks for the contribution @ZhewenFu. Based on the latest comments, it sounds like further work is necessary to understanding the underlying cause of non-deterministic behavior. With that background, I am closing the current pull request, but feel free to follow up with a new pull request when you have narrowed down the source of the behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6525: NIFI-10639 Fix testAddedRowsTwoTables
exceptionfactory closed pull request #6525: NIFI-10639 Fix testAddedRowsTwoTables URL: https://github.com/apache/nifi/pull/6525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6508: NIFI-10623 fix flaky tests in TestHttpClient
exceptionfactory closed pull request #6508: NIFI-10623 fix flaky tests in TestHttpClient URL: https://github.com/apache/nifi/pull/6508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6508: NIFI-10623 fix flaky tests in TestHttpClient
exceptionfactory commented on PR #6508: URL: https://github.com/apache/nifi/pull/6508#issuecomment-1419554638 @Kerr0220 As mentioned recently, changes from another PR should have improved and impacted behavior for this particular pull request. At this point, it would be best to open a new pull request when you are ready for further review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11103) Conduct Apache NiFi 1.20 release
[ https://issues.apache.org/jira/browse/NIFI-11103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684854#comment-17684854 ] ASF subversion and git services commented on NIFI-11103: Commit efe7b7d30f6cb3f7368bb7b7c148857cf8ff6ec3 in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=efe7b7d30f ] NIFI-11103 bumping version refs for 1.20 > Conduct Apache NiFi 1.20 release > > > Key: NIFI-11103 > URL: https://issues.apache.org/jira/browse/NIFI-11103 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.20.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #6569: NIFI-10692 Fixed Possible Array Ordering Permutations Problem in Tests
exceptionfactory closed pull request #6569: NIFI-10692 Fixed Possible Array Ordering Permutations Problem in Tests URL: https://github.com/apache/nifi/pull/6569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6569: NIFI-10692 Fixed Possible Array Ordering Permutations Problem in Tests
exceptionfactory commented on PR #6569: URL: https://github.com/apache/nifi/pull/6569#issuecomment-1419512090 @BoyuLi4 Thanks for the contribution, but the current changes do not address the root cause of the concern. Making this type of change in a test method does not address the source of potential non-deterministic behavior, and leaves the possibility of it easily coming up in other places. I am closing this pull request for now, but feel free to open a new pull request after evaluating the root cause and potential solutions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6224: NIFI-10073 Adding fluid load balancing strategy
exceptionfactory closed pull request #6224: NIFI-10073 Adding fluid load balancing strategy URL: https://github.com/apache/nifi/pull/6224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6629: NIFI-10774 fix flaky tests in TestGetHDFSFileInfo
exceptionfactory commented on PR #6629: URL: https://github.com/apache/nifi/pull/6629#issuecomment-1419508576 @YiweiLi4 Thanks for the contribution, as previously these test changes should be implemented without the additional dependency. I am closing this pull request for now, but feel free to follow up after making the requested changes when you are ready for further review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6629: NIFI-10774 fix flaky tests in TestGetHDFSFileInfo
exceptionfactory closed pull request #6629: NIFI-10774 fix flaky tests in TestGetHDFSFileInfo URL: https://github.com/apache/nifi/pull/6629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6676: NIFI-10837 fixing flaky test in TestXMLReader
exceptionfactory closed pull request #6676: NIFI-10837 fixing flaky test in TestXMLReader URL: https://github.com/apache/nifi/pull/6676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6676: NIFI-10837 fixing flaky test in TestXMLReader
exceptionfactory commented on PR #6676: URL: https://github.com/apache/nifi/pull/6676#issuecomment-1419499165 @TheGreatRandall as noted previously, it would be best to trace this problem to the root cause instead of making adjustments further down. I am closing this pull request for now, but feel free to follow up on this issue and open a new pull request after evaluating the root cause with a potential solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11145) Upgrade PostgreSQL JDBC to 42.5.3
[ https://issues.apache.org/jira/browse/NIFI-11145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684832#comment-17684832 ] ASF subversion and git services commented on NIFI-11145: Commit a9ea659622f48573688d6af41ff0b8630ffd7a01 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a9ea659622 ] NIFI-11145 This closes #6928. Upgraded PostgreSQL JDBC from 42.4.3 to 42.5.3 Signed-off-by: Joe Witt > Upgrade PostgreSQL JDBC to 42.5.3 > - > > Key: NIFI-11145 > URL: https://issues.apache.org/jira/browse/NIFI-11145 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The PostgreSQL JDBC test dependency for NiFi Registry should be upgraded to > address [CVE-2022-41946|https://nvd.nist.gov/vuln/detail/CVE-2022-41946]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #6928: NIFI-11145 Upgrade PostgreSQL JDBC from 42.4.3 to 42.5.3
asfgit closed pull request #6928: NIFI-11145 Upgrade PostgreSQL JDBC from 42.4.3 to 42.5.3 URL: https://github.com/apache/nifi/pull/6928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11130) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions
[
https://issues.apache.org/jira/browse/NIFI-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-11130:
Status: Patch Available (was: Open)
> Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5
> Assertions
> ---
>
> Key: NIFI-11130
> URL: https://issues.apache.org/jira/browse/NIFI-11130
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A regular expression search
> {code:java}
> assert .*
> {code}
> in nifi/nifi-nar-bundles indicates there are over 100 Groovy assert
> statements.
> Refactor these to use JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11145) Upgrade PostgreSQL JDBC to 42.5.3
[ https://issues.apache.org/jira/browse/NIFI-11145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-11145: Fix Version/s: 1.20.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade PostgreSQL JDBC to 42.5.3 > - > > Key: NIFI-11145 > URL: https://issues.apache.org/jira/browse/NIFI-11145 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 1.20.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The PostgreSQL JDBC test dependency for NiFi Registry should be upgraded to > address [CVE-2022-41946|https://nvd.nist.gov/vuln/detail/CVE-2022-41946]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on pull request #6757: NIFI-10944 FixTestConvertAvroToParquet
exceptionfactory commented on PR #6757: URL: https://github.com/apache/nifi/pull/6757#issuecomment-1419475204 @TheGreatRandall The current changes introduce a workaround in tests for something that appears to be a more fundamental issue as noted in other pull requests. I am closing this pull request for now, and you are welcome to follow up with a new pull request if you find a solution that addresses the root cause of the non-deterministic concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6757: NIFI-10944 FixTestConvertAvroToParquet
exceptionfactory closed pull request #6757: NIFI-10944 FixTestConvertAvroToParquet URL: https://github.com/apache/nifi/pull/6757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #6776: NIFI-10968 - Test multipleKeysOneNotFound
exceptionfactory closed pull request #6776: NIFI-10968 - Test multipleKeysOneNotFound URL: https://github.com/apache/nifi/pull/6776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6776: NIFI-10968 - Test multipleKeysOneNotFound
exceptionfactory commented on PR #6776: URL: https://github.com/apache/nifi/pull/6776#issuecomment-1419470974 @TheGreatRandall The current changes are not a suitable solution since they introduce a workaround in tests for something that appears to be a more fundamental issue. As also noted, initial pull requests should contain a single squashed commit for review. I am closing this pull request for now, and you are welcome to follow up with a new pull request if you find a solution that addresses the root cause of the non-deterministic concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11143) Upgrade Spark Streaming to 3.3.1
[
https://issues.apache.org/jira/browse/NIFI-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-11143:
Fix Version/s: 1.20.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Upgrade Spark Streaming to 3.3.1
>
>
> Key: NIFI-11143
> URL: https://issues.apache.org/jira/browse/NIFI-11143
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Labels: dependency-upgrade
> Fix For: 1.20.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The external {{nifi-spark-receiver}} module has a provided dependency on
> Spark Streaming. The dependency version should be upgraded from 3.3.0 to
> 3.3.1 to avoid vulnerability findings related to shaded dependencies,
> although actual vulnerabilities depend on the Spark Streaming runtime version
> used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11143) Upgrade Spark Streaming to 3.3.1
[
https://issues.apache.org/jira/browse/NIFI-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684823#comment-17684823
]
ASF subversion and git services commented on NIFI-11143:
Commit 33af9766b1a26ab22be796ece550d4fd9eb6920e in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=33af9766b1 ]
NIFI-11143 This closes #6926. Upgraded Spark Streaming from 3.3.0 to 3.3.1
Signed-off-by: Joe Witt
> Upgrade Spark Streaming to 3.3.1
>
>
> Key: NIFI-11143
> URL: https://issues.apache.org/jira/browse/NIFI-11143
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Labels: dependency-upgrade
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The external {{nifi-spark-receiver}} module has a provided dependency on
> Spark Streaming. The dependency version should be upgraded from 3.3.0 to
> 3.3.1 to avoid vulnerability findings related to shaded dependencies,
> although actual vulnerabilities depend on the Spark Streaming runtime version
> used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #6926: NIFI-11143 Upgrade Spark Streaming from 3.3.0 to 3.3.1
asfgit closed pull request #6926: NIFI-11143 Upgrade Spark Streaming from 3.3.0 to 3.3.1 URL: https://github.com/apache/nifi/pull/6926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #6924: NIFI-10950 DistributeLoad processor - removed unsupported Load Distribution Service
joewitt commented on PR #6924: URL: https://github.com/apache/nifi/pull/6924#issuecomment-1419434920 I am a +1 but we should do this with the NiFi 2.0 release. I've tagged the JIRA as such. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11145) Upgrade PostgreSQL JDBC to 42.5.3
[ https://issues.apache.org/jira/browse/NIFI-11145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11145: Status: Patch Available (was: Open) > Upgrade PostgreSQL JDBC to 42.5.3 > - > > Key: NIFI-11145 > URL: https://issues.apache.org/jira/browse/NIFI-11145 > Project: Apache NiFi > Issue Type: Improvement > Components: NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The PostgreSQL JDBC test dependency for NiFi Registry should be upgraded to > address [CVE-2022-41946|https://nvd.nist.gov/vuln/detail/CVE-2022-41946]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #6928: NIFI-11145 Upgrade PostgreSQL JDBC from 42.4.3 to 42.5.3
exceptionfactory opened a new pull request, #6928: URL: https://github.com/apache/nifi/pull/6928 # Summary [NIFI-11145](https://issues.apache.org/jira/browse/NIFI-11145) Upgrades the PostgreSQL JDBC test dependency for NiFi Registry from 42.4.3 to 42.5.3 to resolve CVE-2022-41946. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-10950) Distribute Load processor - remove Load Distribution Service as Distribution Strategy
[
https://issues.apache.org/jira/browse/NIFI-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-10950:
Fix Version/s: 2.0.0
> Distribute Load processor - remove Load Distribution Service as Distribution
> Strategy
> -
>
> Key: NIFI-10950
> URL: https://issues.apache.org/jira/browse/NIFI-10950
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Nissim Shiman
>Assignee: Nissim Shiman
>Priority: Major
> Fix For: 2.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The DistributeLoad processor's Distribution Strategy property is currently
> able to be set to "load distribution service"
> But when attempting to create the load distribution service, we get the
> message:
> {code:java}
> No controller service types found that are applicable for this property
> {code}
> The underlying load distribution service api [1] is not implemented, so it
> can be removed as a distribution strategy, in order to avoid the above
> situation.
> [1]
> [https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-standard-services/nifi-load-distribution-service-api/src/main/java/org/apache/nifi/loading/LoadDistributionService.java]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-11145) Upgrade PostgreSQL JDBC to 42.5.3
David Handermann created NIFI-11145: --- Summary: Upgrade PostgreSQL JDBC to 42.5.3 Key: NIFI-11145 URL: https://issues.apache.org/jira/browse/NIFI-11145 Project: Apache NiFi Issue Type: Improvement Components: NiFi Registry Reporter: David Handermann Assignee: David Handermann The PostgreSQL JDBC test dependency for NiFi Registry should be upgraded to address [CVE-2022-41946|https://nvd.nist.gov/vuln/detail/CVE-2022-41946]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-10906) Release NiFi NAR Maven Plugin 1.4.0
[ https://issues.apache.org/jira/browse/NIFI-10906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Doran resolved NIFI-10906. Resolution: Done > Release NiFi NAR Maven Plugin 1.4.0 > --- > > Key: NIFI-10906 > URL: https://issues.apache.org/jira/browse/NIFI-10906 > Project: Apache NiFi > Issue Type: Task >Reporter: Kevin Doran >Assignee: Kevin Doran >Priority: Major > Fix For: nifi-nar-maven-plugin-1.4.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11130) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions
[
https://issues.apache.org/jira/browse/NIFI-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684801#comment-17684801
]
Daniel Stieglitz edited comment on NIFI-11130 at 2/6/23 4:48 PM:
-
[~exceptionfactory] I have made changes to replace the instances of where
Groovy assert was used but there were also a few instances where Java unit
tests were using Java assert so I replaced those also. Many of the Groovy
assert instances were used in Spock unit tests which I am not familiar with and
I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
Also the scripts under directory
{code:java}
nifi/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/test/resources/groovy
{code} which are executed in unit tests also use Groovy assert but I assumed
those do not need to have JUnit assertions.
was (Author: JIRAUSER294662):
[~exceptionfactory] I have made changes to replace the instances of where
Groovy assert was used but there were also a few instances where Java unit
tests were using Java assert so I replaced those also. Many of the Groovy
assert instances were used in Spock unit tests which I am not familiar with and
I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
Also the scripts under directory
{code:java}
nifi/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/test/resources/groovy
{code} which are executed in unit tests also use Groovy assert but I assumed
those do not need to have JUnit asserts.
> Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5
> Assertions
> ---
>
> Key: NIFI-11130
> URL: https://issues.apache.org/jira/browse/NIFI-11130
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A regular expression search
> {code:java}
> assert .*
> {code}
> in nifi/nifi-nar-bundles indicates there are over 100 Groovy assert
> statements.
> Refactor these to use JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11130) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions
[
https://issues.apache.org/jira/browse/NIFI-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684801#comment-17684801
]
Daniel Stieglitz edited comment on NIFI-11130 at 2/6/23 4:46 PM:
-
[~exceptionfactory] I have made changes to replace the instances of where
Groovy assert was used but there were also a few instances where Java unit
tests were using Java assert so I replaced those also. Many of the Groovy
assert instances were used in Spock unit tests which I am not familiar with and
I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
Also the scripts under directory
{code:java}
nifi/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/test/resources/groovy
{code} which are executed in unit tests also have asserts but I assumed those
do not need to have Junit asserts.
was (Author: JIRAUSER294662):
[~exceptionfactory] I have made changes to replace the instances of where
Groovy assert was used but there were also a few instances where Java unit
tests were using Java assert so I replaced those also. Many of the Groovy
assert instances were used in Spock unit tests which I am not familiar with and
I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
Also the scripts under this directory
{code:java}
nifi/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/test/resources/groovy
{code} which are executed in unit tests also have asserts but I assumed those
do not need to have Junit asserts.
> Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5
> Assertions
> ---
>
> Key: NIFI-11130
> URL: https://issues.apache.org/jira/browse/NIFI-11130
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A regular expression search
> {code:java}
> assert .*
> {code}
> in nifi/nifi-nar-bundles indicates there are over 100 Groovy assert
> statements.
> Refactor these to use JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11130) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions
[
https://issues.apache.org/jira/browse/NIFI-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684801#comment-17684801
]
Daniel Stieglitz edited comment on NIFI-11130 at 2/6/23 4:46 PM:
-
[~exceptionfactory] I have made changes to replace the instances of where
Groovy assert was used but there were also a few instances where Java unit
tests were using Java assert so I replaced those also. Many of the Groovy
assert instances were used in Spock unit tests which I am not familiar with and
I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
Also the scripts under directory
{code:java}
nifi/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/test/resources/groovy
{code} which are executed in unit tests also use Groovy assert but I assumed
those do not need to have JUnit asserts.
was (Author: JIRAUSER294662):
[~exceptionfactory] I have made changes to replace the instances of where
Groovy assert was used but there were also a few instances where Java unit
tests were using Java assert so I replaced those also. Many of the Groovy
assert instances were used in Spock unit tests which I am not familiar with and
I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
Also the scripts under directory
{code:java}
nifi/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/test/resources/groovy
{code} which are executed in unit tests also have asserts but I assumed those
do not need to have Junit asserts.
> Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5
> Assertions
> ---
>
> Key: NIFI-11130
> URL: https://issues.apache.org/jira/browse/NIFI-11130
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A regular expression search
> {code:java}
> assert .*
> {code}
> in nifi/nifi-nar-bundles indicates there are over 100 Groovy assert
> statements.
> Refactor these to use JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11130) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions
[
https://issues.apache.org/jira/browse/NIFI-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684801#comment-17684801
]
Daniel Stieglitz edited comment on NIFI-11130 at 2/6/23 4:45 PM:
-
[~exceptionfactory] I have made changes to replace the instances of where
Groovy assert was used but there were also a few instances where Java unit
tests were using Java assert so I replaced those also. Many of the Groovy
assert instances were used in Spock unit tests which I am not familiar with and
I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
Also the scripts under this directory
{code:java}
nifi/nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/test/resources/groovy
{code} which are executed in unit tests also have asserts but I assumed those
do not need to have Junit asserts.
was (Author: JIRAUSER294662):
[~exceptionfactory] I have made changes to replace the instances of where
Groovy assert was used but there were also a few instances where Java unit
tests were using Java assert so I replaced those also. Many of the Groovy
assert instances were used in Spock unit tests which I am not familiar with and
I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
> Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5
> Assertions
> ---
>
> Key: NIFI-11130
> URL: https://issues.apache.org/jira/browse/NIFI-11130
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A regular expression search
> {code:java}
> assert .*
> {code}
> in nifi/nifi-nar-bundles indicates there are over 100 Groovy assert
> statements.
> Refactor these to use JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] turcsanyip commented on a diff in pull request #6916: NIFI-11124: Add qualified path attribute to HDFS processors
turcsanyip commented on code in PR #6916: URL: https://github.com/apache/nifi/pull/6916#discussion_r1097632083 ## nifi-nar-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java: ## @@ -158,6 +158,7 @@ public abstract class AbstractHadoopProcessor extends AbstractProcessor implemen public static final String ABSOLUTE_HDFS_PATH_ATTRIBUTE = "absolute.hdfs.path"; +public static final String QUALIFIED_PATH_ATTRIBUTE = "qualified.path"; Review Comment: @mark-bathori Thanks for adding this attribute to HDFS processors! The attribute name does not have a reference to hadoop/hdfs which would be useful in the downstream flow to identify the origin of the attribute. As the file can be located on S3/ADLS too, I would use 'hadoop' over 'hdfs'. To emphasize that it is a URL, I would also suggest 'url' instead of 'path'. Something like: `hadoop.file.url` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11144) Fix failing tests for ConsumeJMS/PublishJMS
Nandor Soma Abonyi created NIFI-11144: - Summary: Fix failing tests for ConsumeJMS/PublishJMS Key: NIFI-11144 URL: https://issues.apache.org/jira/browse/NIFI-11144 Project: Apache NiFi Issue Type: Improvement Components: Extensions Reporter: Nandor Soma Abonyi Assignee: Nandor Soma Abonyi -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11130) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions
[
https://issues.apache.org/jira/browse/NIFI-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684801#comment-17684801
]
Daniel Stieglitz edited comment on NIFI-11130 at 2/6/23 4:28 PM:
-
[~exceptionfactory] I have made changes to replace the instances of where
Groovy assert was used but there were also a few instances where Java unit
tests were using Java assert so I replaced those also. Many of the Groovy
assert instances were used in Spock unit tests which I am not familiar with and
I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
was (Author: JIRAUSER294662):
[~exceptionfactory] I have made changes to replace the instances of where
Groovy assert was used but there were also a few instances where Java unit
tests were using Java assert so I replaced those also. I also noticed there
were specific Spock unit tests which I am not familiar with and I was not sure
how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
> Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5
> Assertions
> ---
>
> Key: NIFI-11130
> URL: https://issues.apache.org/jira/browse/NIFI-11130
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A regular expression search
> {code:java}
> assert .*
> {code}
> in nifi/nifi-nar-bundles indicates there are over 100 Groovy assert
> statements.
> Refactor these to use JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11130) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions
[
https://issues.apache.org/jira/browse/NIFI-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684801#comment-17684801
]
Daniel Stieglitz edited comment on NIFI-11130 at 2/6/23 4:27 PM:
-
[~exceptionfactory] I have made changes to replace the instances of where
Groovy assert was used but there were also a few instances where Java unit
tests were using Java assert so I replaced those also. I also noticed there
were specific Spock unit tests which I am not familiar with and I was not sure
how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
was (Author: JIRAUSER294662):
[~exceptionfactory] I have made changes to replace the Groovy assert but there
were also a few instances where Java unit tests were using assert so I replaced
those also. I also noticed there were specific Spock unit tests which I am not
familiar with and I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
> Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5
> Assertions
> ---
>
> Key: NIFI-11130
> URL: https://issues.apache.org/jira/browse/NIFI-11130
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A regular expression search
> {code:java}
> assert .*
> {code}
> in nifi/nifi-nar-bundles indicates there are over 100 Groovy assert
> statements.
> Refactor these to use JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11130) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions
[
https://issues.apache.org/jira/browse/NIFI-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684801#comment-17684801
]
Daniel Stieglitz edited comment on NIFI-11130 at 2/6/23 4:26 PM:
-
[~exceptionfactory] I have made changes to replace the Groovy assert but there
were also a few instances where Java unit tests were using assert so I replaced
those also. I also noticed there were specific Spock unit tests which I am not
familiar with and I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can that be left for NIFI-10047 ?
was (Author: JIRAUSER294662):
[~exceptionfactory] I have made changes to replace the Groovy assert but there
were also a few instances where Java unit tests were using assert so I replaced
those also. I also noticed there were specific Spock unit tests which I am not
familiar with and I was not sure how to refactor to Java. Those file are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can that be left for NIFI-10047 ?
> Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5
> Assertions
> ---
>
> Key: NIFI-11130
> URL: https://issues.apache.org/jira/browse/NIFI-11130
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A regular expression search
> {code:java}
> assert .*
> {code}
> in nifi/nifi-nar-bundles indicates there are over 100 Groovy assert
> statements.
> Refactor these to use JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-11130) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions
[
https://issues.apache.org/jira/browse/NIFI-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684801#comment-17684801
]
Daniel Stieglitz edited comment on NIFI-11130 at 2/6/23 4:26 PM:
-
[~exceptionfactory] I have made changes to replace the Groovy assert but there
were also a few instances where Java unit tests were using assert so I replaced
those also. I also noticed there were specific Spock unit tests which I am not
familiar with and I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can those be left for NIFI-10047 ?
was (Author: JIRAUSER294662):
[~exceptionfactory] I have made changes to replace the Groovy assert but there
were also a few instances where Java unit tests were using assert so I replaced
those also. I also noticed there were specific Spock unit tests which I am not
familiar with and I was not sure how to refactor to Java. Those files are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can that be left for NIFI-10047 ?
> Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5
> Assertions
> ---
>
> Key: NIFI-11130
> URL: https://issues.apache.org/jira/browse/NIFI-11130
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A regular expression search
> {code:java}
> assert .*
> {code}
> in nifi/nifi-nar-bundles indicates there are over 100 Groovy assert
> statements.
> Refactor these to use JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11130) Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5 Assertions
[
https://issues.apache.org/jira/browse/NIFI-11130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684801#comment-17684801
]
Daniel Stieglitz commented on NIFI-11130:
-
[~exceptionfactory] I have made changes to replace the Groovy assert but there
were also a few instances where Java unit tests were using assert so I replaced
those also. I also noticed there were specific Spock unit tests which I am not
familiar with and I was not sure how to refactor to Java. Those file are:
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/test/groovy/org/apache/nifi/util/SnippetUtilsSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/PositionScalerSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardPolicyBasedAuthorizerDAOSpec.groovy
#
nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/dao/impl/StandardTemplateDAOSpec.groovy
Can that be left for NIFI-10047 ?
> Refactor Groovy assert statements under nifi/nifi-nar-bundles to use JUnit 5
> Assertions
> ---
>
> Key: NIFI-11130
> URL: https://issues.apache.org/jira/browse/NIFI-11130
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A regular expression search
> {code:java}
> assert .*
> {code}
> in nifi/nifi-nar-bundles indicates there are over 100 Groovy assert
> statements.
> Refactor these to use JUnit 5 assertions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] dan-s1 opened a new pull request, #6927: [NIFI-11130] Further changes to upgrade from JUnit 4 to JUnit 5.
dan-s1 opened a new pull request, #6927: URL: https://github.com/apache/nifi/pull/6927 # Summary [NIFI-11130](https://issues.apache.org/jira/browse/NIFI-11130) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11143) Upgrade Spark Streaming to 3.3.1
[
https://issues.apache.org/jira/browse/NIFI-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11143:
Status: Patch Available (was: Open)
> Upgrade Spark Streaming to 3.3.1
>
>
> Key: NIFI-11143
> URL: https://issues.apache.org/jira/browse/NIFI-11143
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Labels: dependency-upgrade
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The external {{nifi-spark-receiver}} module has a provided dependency on
> Spark Streaming. The dependency version should be upgraded from 3.3.0 to
> 3.3.1 to avoid vulnerability findings related to shaded dependencies,
> although actual vulnerabilities depend on the Spark Streaming runtime version
> used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #6926: NIFI-11143 Upgrade Spark Streaming from 3.3.0 to 3.3.1
exceptionfactory opened a new pull request, #6926: URL: https://github.com/apache/nifi/pull/6926 # Summary [NIFI-11143](https://issues.apache.org/jira/browse/NIFI-11143) Upgrades the provided dependency for Spark Streaming from 3.3.0 to 3.3.1 to correct vulnerability findings associated with shaded dependencies. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 8 - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11143) Upgrade Spark Streaming to 3.3.1
David Handermann created NIFI-11143:
---
Summary: Upgrade Spark Streaming to 3.3.1
Key: NIFI-11143
URL: https://issues.apache.org/jira/browse/NIFI-11143
Project: Apache NiFi
Issue Type: Improvement
Components: Extensions
Reporter: David Handermann
Assignee: David Handermann
The external {{nifi-spark-receiver}} module has a provided dependency on Spark
Streaming. The dependency version should be upgraded from 3.3.0 to 3.3.1 to
avoid vulnerability findings related to shaded dependencies, although actual
vulnerabilities depend on the Spark Streaming runtime version used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-11142) Security fix for SnakeYAML
[ https://issues.apache.org/jira/browse/NIFI-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Liszli resolved NIFI-11142. -- Resolution: Not A Problem The questionable Constructor is not used in the codebase. > Security fix for SnakeYAML > -- > > Key: NIFI-11142 > URL: https://issues.apache.org/jira/browse/NIFI-11142 > Project: Apache NiFi > Issue Type: Improvement > Components: MiNiFi >Reporter: Robert Liszli >Assignee: Robert Liszli >Priority: Minor > > *Fix for:* > SnakeYaml's Constructor() class does not restrict types which can be > instantiated during deserialization. Deserializing yaml content provided by > an attacker can lead to remote code execution. We recommend using SnakeYaml's > SafeConsturctor when parsing untrusted content to restrict deserialization. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11142) Security fix for SnakeYAML
[ https://issues.apache.org/jira/browse/NIFI-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684699#comment-17684699 ] David Handermann commented on NIFI-11142: - You're welcome, sounds good! SnakeYAML has had several associated vulnerabilities reported, which has prompted changes in the default behavior of YAML parsing in more recent versions. If you discover future issues with potential security implications that have not yet been disclosed to the public, please contact [secur...@nifi.apache.org|mailto:secur...@nifi.apache.org] for initial coordination prior to creating a Jira issue. > Security fix for SnakeYAML > -- > > Key: NIFI-11142 > URL: https://issues.apache.org/jira/browse/NIFI-11142 > Project: Apache NiFi > Issue Type: Improvement > Components: MiNiFi >Reporter: Robert Liszli >Assignee: Robert Liszli >Priority: Minor > Fix For: 1.20.0 > > > *Fix for:* > SnakeYaml's Constructor() class does not restrict types which can be > instantiated during deserialization. Deserializing yaml content provided by > an attacker can lead to remote code execution. We recommend using SnakeYaml's > SafeConsturctor when parsing untrusted content to restrict deserialization. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11142) Security fix for SnakeYAML
[ https://issues.apache.org/jira/browse/NIFI-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11142: Fix Version/s: (was: 1.20.0) > Security fix for SnakeYAML > -- > > Key: NIFI-11142 > URL: https://issues.apache.org/jira/browse/NIFI-11142 > Project: Apache NiFi > Issue Type: Improvement > Components: MiNiFi >Reporter: Robert Liszli >Assignee: Robert Liszli >Priority: Minor > > *Fix for:* > SnakeYaml's Constructor() class does not restrict types which can be > instantiated during deserialization. Deserializing yaml content provided by > an attacker can lead to remote code execution. We recommend using SnakeYaml's > SafeConsturctor when parsing untrusted content to restrict deserialization. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11142) Security fix for SnakeYAML
[ https://issues.apache.org/jira/browse/NIFI-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684698#comment-17684698 ] Robert Liszli commented on NIFI-11142: -- Thanks for the info. Checked the code and you're right. I close this ticket. > Security fix for SnakeYAML > -- > > Key: NIFI-11142 > URL: https://issues.apache.org/jira/browse/NIFI-11142 > Project: Apache NiFi > Issue Type: Improvement > Components: MiNiFi >Reporter: Robert Liszli >Assignee: Robert Liszli >Priority: Minor > Fix For: 1.20.0 > > > *Fix for:* > SnakeYaml's Constructor() class does not restrict types which can be > instantiated during deserialization. Deserializing yaml content provided by > an attacker can lead to remote code execution. We recommend using SnakeYaml's > SafeConsturctor when parsing untrusted content to restrict deserialization. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11142) Security fix for SnakeYAML
[
https://issues.apache.org/jira/browse/NIFI-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684697#comment-17684697
]
David Handermann commented on NIFI-11142:
-
For additional clarification, the no-argument SnakeYAML {{Constructor}} is
deprecated, and does use the generic {{Object.class}} reference, versus other
constructor options that have a more restricted set of default objects, so
problematic usage depends on the particular case.
> Security fix for SnakeYAML
> --
>
> Key: NIFI-11142
> URL: https://issues.apache.org/jira/browse/NIFI-11142
> Project: Apache NiFi
> Issue Type: Improvement
> Components: MiNiFi
>Reporter: Robert Liszli
>Assignee: Robert Liszli
>Priority: Minor
> Fix For: 1.20.0
>
>
> *Fix for:*
> SnakeYaml's Constructor() class does not restrict types which can be
> instantiated during deserialization. Deserializing yaml content provided by
> an attacker can lead to remote code execution. We recommend using SnakeYaml's
> SafeConsturctor when parsing untrusted content to restrict deserialization.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11142) Security fix for SnakeYAML
[
https://issues.apache.org/jira/browse/NIFI-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684695#comment-17684695
]
David Handermann commented on NIFI-11142:
-
[~rliszli] Can you provide some additional background on this issue? NiFi uses
SnakeYAML 1.33, and recent versions of the {{Constructor}} class extend
{{{}SafeConstructor{}}}, so making changes should not be necessary.
> Security fix for SnakeYAML
> --
>
> Key: NIFI-11142
> URL: https://issues.apache.org/jira/browse/NIFI-11142
> Project: Apache NiFi
> Issue Type: Improvement
> Components: MiNiFi
>Reporter: Robert Liszli
>Assignee: Robert Liszli
>Priority: Minor
> Fix For: 1.20.0
>
>
> *Fix for:*
> SnakeYaml's Constructor() class does not restrict types which can be
> instantiated during deserialization. Deserializing yaml content provided by
> an attacker can lead to remote code execution. We recommend using SnakeYaml's
> SafeConsturctor when parsing untrusted content to restrict deserialization.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (NIFI-11142) Security fix for SnakeYAML
[ https://issues.apache.org/jira/browse/NIFI-11142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Liszli reassigned NIFI-11142: Assignee: Robert Liszli > Security fix for SnakeYAML > -- > > Key: NIFI-11142 > URL: https://issues.apache.org/jira/browse/NIFI-11142 > Project: Apache NiFi > Issue Type: Improvement > Components: MiNiFi >Reporter: Robert Liszli >Assignee: Robert Liszli >Priority: Minor > Fix For: 1.20.0 > > > *Fix for:* > SnakeYaml's Constructor() class does not restrict types which can be > instantiated during deserialization. Deserializing yaml content provided by > an attacker can lead to remote code execution. We recommend using SnakeYaml's > SafeConsturctor when parsing untrusted content to restrict deserialization. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11142) Security fix for SnakeYAML
Robert Liszli created NIFI-11142: Summary: Security fix for SnakeYAML Key: NIFI-11142 URL: https://issues.apache.org/jira/browse/NIFI-11142 Project: Apache NiFi Issue Type: Improvement Components: MiNiFi Reporter: Robert Liszli Fix For: 1.20.0 *Fix for:* SnakeYaml's Constructor() class does not restrict types which can be instantiated during deserialization. Deserializing yaml content provided by an attacker can lead to remote code execution. We recommend using SnakeYaml's SafeConsturctor when parsing untrusted content to restrict deserialization. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1482: MINIFICPP-2009 - CWEL should add resolved attributes with json output…
fgerlits commented on code in PR #1482:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1482#discussion_r1097388376
##
extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp:
##
@@ -238,6 +238,18 @@ TEST_CASE("ConsumeWindowsEventLog extracts some attributes
by default", "[onTrig
auto logger_processor = test_plan->addProcessor("LogAttribute", "logger",
Success, true);
test_plan->setProperty(logger_processor,
LogAttribute::FlowFilesToLog.getName(), "0");
+ SECTION("XML output") {
+CHECK(test_plan->setProperty(cwel_processor, ConsumeWindowsEventLog
::OutputFormat.getName(), "XML"));
Review Comment:
very minor, but the space before the `::` looks weird
##
extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp:
##
@@ -238,6 +238,18 @@ TEST_CASE("ConsumeWindowsEventLog extracts some attributes
by default", "[onTrig
auto logger_processor = test_plan->addProcessor("LogAttribute", "logger",
Success, true);
test_plan->setProperty(logger_processor,
LogAttribute::FlowFilesToLog.getName(), "0");
+ SECTION("XML output") {
+CHECK(test_plan->setProperty(cwel_processor, ConsumeWindowsEventLog
::OutputFormat.getName(), "XML"));
Review Comment:
I think these three should be `REQUIRE`s instead of `CHECK`s, because it
doesn't make sense to continue running the test if we could not set the property
##
extensions/windows-event-log/ConsumeWindowsEventLog.cpp:
##
@@ -699,42 +699,38 @@ void ConsumeWindowsEventLog::refreshTimeZoneData() {
}
void ConsumeWindowsEventLog::putEventRenderFlowFileToSession(const
EventRender& eventRender, core::ProcessSession& session) const {
- auto commitFlowFile = [&] (const std::shared_ptr& flowFile,
const std::string& content, const std::string& mimeType) {
-session.writeBuffer(flowFile, content);
-session.putAttribute(flowFile, core::SpecialFlowAttribute::MIME_TYPE,
mimeType);
-session.putAttribute(flowFile, "timezone.name", timezone_name_);
-session.putAttribute(flowFile, "timezone.offset", timezone_offset_);
-session.getProvenanceReporter()->receive(flowFile, provenanceUri_,
getUUIDStr(), "Consume windows event logs", 0ms);
-session.transfer(flowFile, Success);
+ auto commitFlowFile = [&] (const std::string& content, const std::string&
mimeType) {
+auto flow_file = session.create();
+addMatchedFieldsAsAttributes(eventRender, session, flow_file);
+session.writeBuffer(flow_file, content);
+session.putAttribute(flow_file, core::SpecialFlowAttribute::MIME_TYPE,
mimeType);
+session.putAttribute(flow_file, "timezone.name", timezone_name_);
+session.putAttribute(flow_file, "timezone.offset", timezone_offset_);
+session.getProvenanceReporter()->receive(flow_file, provenanceUri_,
getUUIDStr(), "Consume windows event logs", 0ms);
+session.transfer(flow_file, Success);
};
if (output_.xml) {
-auto flowFile = session.create();
logger_->log_trace("Writing rendered XML to a flow file");
-
-for (const auto : eventRender.matched_fields) {
- if (!fieldMapping.second.empty()) {
-session.putAttribute(flowFile, fieldMapping.first,
fieldMapping.second);
- }
-}
-
-commitFlowFile(flowFile, eventRender.xml, "application/xml");
+commitFlowFile(eventRender.xml, "application/xml");
}
if (output_.plaintext) {
logger_->log_trace("Writing rendered plain text to a flow file");
-commitFlowFile(session.create(), eventRender.plaintext, "text/plain");
+commitFlowFile(eventRender.plaintext, "text/plain");
}
- if (output_.json.type == JSONType::Raw) {
-logger_->log_trace("Writing rendered raw JSON to a flow file");
-commitFlowFile(session.create(), eventRender.json, "application/json");
- } else if (output_.json.type == JSONType::Simple) {
-logger_->log_trace("Writing rendered simple JSON to a flow file");
-commitFlowFile(session.create(), eventRender.json, "application/json");
- } else if (output_.json.type == JSONType::Flattened) {
-logger_->log_trace("Writing rendered flattened JSON to a flow file");
-commitFlowFile(session.create(), eventRender.json, "application/json");
+ if (output_.json.type != JSONType::None) {
Review Comment:
`OutputFormat::JSON` has an `operator bool` which does this, so this could
be `if (output_.json) { ... }`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MINIFICPP-1887) Add default Connection size limits
[ https://issues.apache.org/jira/browse/MINIFICPP-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-1887: --- Status: Patch Available (was: In Progress) https://github.com/apache/nifi-minifi-cpp/pull/1501 > Add default Connection size limits > -- > > Key: MINIFICPP-1887 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1887 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Martin Zink >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #1482: MINIFICPP-2009 - CWEL should add resolved attributes with json output…
martinzink commented on PR #1482: URL: https://github.com/apache/nifi-minifi-cpp/pull/1482#issuecomment-1418739726 > Currently we have the options XML, Plaintext, Both, JSON for Output Format. The "Both" option is quite ambiguous now that we have 3 different output formats, should we revise this? Either have an "All" option for all 3 output formats, or rename it to "XML and Plaintext'. Yeah thats a bit confusing I agree. I think we should address that. (But I dont see an easy fix without breaking compatibility with previous configurations and seems out of the scope of this PR) I've created a jira for this https://issues.apache.org/jira/browse/MINIFICPP-2042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2042) Address CWEL ambigous Output property
Martin Zink created MINIFICPP-2042:
--
Summary: Address CWEL ambigous Output property
Key: MINIFICPP-2042
URL: https://issues.apache.org/jira/browse/MINIFICPP-2042
Project: Apache NiFi MiNiFi C++
Issue Type: Bug
Reporter: Martin Zink
[~lordgamez] made a great observation
[https://github.com/apache/nifi-minifi-cpp/pull/1482#issuecomment-1385016182]
{noformat}
Currently we have the options XML, Plaintext, Both, JSON for Output Format. The
"Both" option is quite ambiguous now that we have 3 different output formats,
should we revise this? Either have an "All" option for all 3 output formats, or
rename it to "XML and Plaintext'.{noformat}
I don't see an easy way to fix this without breaking compatibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1482: MINIFICPP-2009 - CWEL should add resolved attributes with json output…
martinzink commented on code in PR #1482:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1482#discussion_r1097100636
##
extensions/windows-event-log/ConsumeWindowsEventLog.cpp:
##
@@ -696,32 +696,30 @@ void
ConsumeWindowsEventLog::putEventRenderFlowFileToSession(const EventRender&
};
if (output_.xml) {
-auto flowFile = session.create();
logger_->log_trace("Writing rendered XML to a flow file");
-
-for (const auto : eventRender.matched_fields) {
- if (!fieldMapping.second.empty()) {
-session.putAttribute(flowFile, fieldMapping.first,
fieldMapping.second);
- }
-}
-
-commitFlowFile(flowFile, eventRender.xml, "application/xml");
+auto flow_file = session.create();
+addMatchedFieldsAsAttributes(eventRender, session, flow_file);
+commitFlowFile(flow_file, eventRender.xml, "application/xml");
}
if (output_.plaintext) {
logger_->log_trace("Writing rendered plain text to a flow file");
commitFlowFile(session.create(), eventRender.plaintext, "text/plain");
}
- if (output_.json.type == JSONType::Raw) {
-logger_->log_trace("Writing rendered raw JSON to a flow file");
-commitFlowFile(session.create(), eventRender.json, "application/json");
- } else if (output_.json.type == JSONType::Simple) {
-logger_->log_trace("Writing rendered simple JSON to a flow file");
-commitFlowFile(session.create(), eventRender.json, "application/json");
- } else if (output_.json.type == JSONType::Flattened) {
-logger_->log_trace("Writing rendered flattened JSON to a flow file");
-commitFlowFile(session.create(), eventRender.json, "application/json");
+ if (output_.json.type != JSONType::None) {
+logger_->log_trace("Writing rendered %s JSON to a flow file",
output_.json.type.toString());
+auto flow_file = session.create();
+addMatchedFieldsAsAttributes(eventRender, session, flow_file);
Review Comment:
Sry for the late reply.
I've added this for all cases(and a test for plaintext aswell) in
https://github.com/apache/nifi-minifi-cpp/pull/1482/commits/76db15357c1f2efd8cf2fa1cec2a7ed370eb0bf7
##
extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp:
##
@@ -236,6 +236,14 @@ TEST_CASE("ConsumeWindowsEventLog extracts some attributes
by default", "[onTrig
auto logger_processor = test_plan->addProcessor("LogAttribute", "logger",
Success, true);
test_plan->setProperty(logger_processor,
LogAttribute::FlowFilesToLog.getName(), "0");
+ SECTION("XML output") {
+CHECK(test_plan->setProperty(cwel_processor, ConsumeWindowsEventLog
::OutputFormat.getName(), "XML"));
+ }
+
+ SECTION("Json output") {
+CHECK(test_plan->setProperty(cwel_processor, ConsumeWindowsEventLog
::OutputFormat.getName(), "JSON"));
+ }
Review Comment:
Sorry for the late reply.
Yes there are some tests that cover those cases in
[MetadataWalkerTests](https://github.com/apache/nifi-minifi-cpp/blob/main/extensions/windows-event-log/tests/MetadataWalkerTests.cpp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
