[GitHub] [nifi] levilentz commented on a diff in pull request #7677: NIFI-7355: add bytecode submission to tinkerpop service
levilentz commented on code in PR #7677:
URL: https://github.com/apache/nifi/pull/7677#discussion_r1328040951
##
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.graph;
+
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.nifi.annotation.behavior.RequiresInstanceClassLoading;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.components.resource.ResourceCardinality;
+import org.apache.nifi.components.resource.ResourceType;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.graph.gremlin.SimpleEntry;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.ssl.SSLContextService;
+import org.apache.nifi.util.StringUtils;
+import org.apache.tinkerpop.gremlin.driver.Client;
+import org.apache.tinkerpop.gremlin.driver.Cluster;
+import org.apache.tinkerpop.gremlin.driver.Result;
+import org.apache.tinkerpop.gremlin.driver.remote.DriverRemoteConnection;
+import org.apache.tinkerpop.gremlin.process.traversal.AnonymousTraversalSource;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource;
+
+import javax.script.Bindings;
+import javax.script.Compilable;
+import javax.script.CompiledScript;
+import javax.script.ScriptEngine;
+import javax.script.ScriptEngineManager;
+import javax.script.ScriptException;
+import java.io.File;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.stream.Collectors;
+
+
+@Tags({"graph", "gremlin"})
+@CapabilityDescription("This service interacts with a tinkerpop-compliant
graph service, providing both script submission and bytecode submission
capabilities. " +
+"Script submission is the default, with the script command being sent
to the gremlin server as text. This should only be used for simple interactions
with a tinkerpop-compliant server. " +
+"Bytecode submission, when providing a jar with the serialization
dependencies, offers much richer way of interacting with the server, and should
be used when doing complex manipulations" +
+" of the underlying data.")
+@RequiresInstanceClassLoading
+public class TinkerpopClientService extends AbstractControllerService
implements GraphClientService {
+public static final String NOT_SUPPORTED = "NOT_SUPPORTED";
+private static final AllowableValue BYTECODE_SUBMISSION = new
AllowableValue("bytecode-submission", "ByteCode Submission",
+"Scripts directly interact with the server via the NiFi JVM"
+);
+
+private static final AllowableValue SCRIPT_SUBMISSION = new
AllowableValue("script-submission", "Script Submission",
+"Script is sent to the gremlin server as a submittion"
+);
+
+private static final AllowableValue YAML_SETTINGS = new
AllowableValue("yaml-settings", "Yaml Settings",
+"Connection to the gremlin server will be specified via a yaml
file (more flexible)");
+
+private static final AllowableValue SERVICE_SETTINGS = new
AllowableValue("service-settings", "Service-Defined Settings",
+"Connection to the gremlin server will be specified via
[jira] [Updated] (NIFI-12072) Move to StackWalker API to avoid the no longer allowed SecurityManager in Java 18+
[ https://issues.apache.org/jira/browse/NIFI-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-12072: -- Fix Version/s: 2.0.0 (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Move to StackWalker API to avoid the no longer allowed SecurityManager in > Java 18+ > -- > > Key: NIFI-12072 > URL: https://issues.apache.org/jira/browse/NIFI-12072 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > With NiFi 1.x we used a SecurityManager as part of our Nar Context Class > Loading jailing process whereby even spawned threads we'd find the right > classloader and pin the context. Java 21 makes this no longer acceptable so > we need a new solution. > Enter the StackWalker API https://bugs.openjdk.org/browse/JDK-8043814 > Using this we can move to a more efficient and better go forward model that > is Java 21+ friendly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12072) Move to StackWalker API to avoid the no longer allowed SecurityManager in Java 18+
[ https://issues.apache.org/jira/browse/NIFI-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766018#comment-17766018 ] ASF subversion and git services commented on NIFI-12072: Commit cbf5bb98f9a5c835e2a72f7c383e73f4c2187429 in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=cbf5bb98f9 ] NIFI-12072 moved to StackWalker API elimnating usage of SecurityManager (#7742) > Move to StackWalker API to avoid the no longer allowed SecurityManager in > Java 18+ > -- > > Key: NIFI-12072 > URL: https://issues.apache.org/jira/browse/NIFI-12072 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.latest > > Time Spent: 0.5h > Remaining Estimate: 0h > > With NiFi 1.x we used a SecurityManager as part of our Nar Context Class > Loading jailing process whereby even spawned threads we'd find the right > classloader and pin the context. Java 21 makes this no longer acceptable so > we need a new solution. > Enter the StackWalker API https://bugs.openjdk.org/browse/JDK-8043814 > Using this we can move to a more efficient and better go forward model that > is Java 21+ friendly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] markap14 merged pull request #7742: NIFI-12072 moved to StackWalker API elimnating usage of SecurityManager
markap14 merged PR #7742: URL: https://github.com/apache/nifi/pull/7742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #7742: NIFI-12072 moved to StackWalker API elimnating usage of SecurityManager
markap14 commented on PR #7742: URL: https://github.com/apache/nifi/pull/7742#issuecomment-1722316123 Thanks @joewitt , the code changes look good. It appears to carry out the correct logic, but eliminates use of the Security Manager. There's a system test failure, but it's clearly unrelated. Something we should look into but not within this scope. I'm a +1, thanks for eliminating that reference to Security Manager. Will merge to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] levilentz commented on a diff in pull request #7677: NIFI-7355: add bytecode submission to tinkerpop service
levilentz commented on code in PR #7677:
URL: https://github.com/apache/nifi/pull/7677#discussion_r1328007426
##
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/src/test/java/org/apache/nifi/graph/GremlinClientServiceIT.java:
##
@@ -42,20 +42,20 @@ public void setup() throws Exception {
clientService = new TestableGremlinClientService();
runner = TestRunners.newTestRunner(NoOpProcessor.class);
runner.addControllerService("gremlinService", clientService);
-runner.setProperty(clientService,
AbstractTinkerpopClientService.CONTACT_POINTS, "localhost");
Review Comment:
Tracking, I am planning on building out integration tests utilizing test
containers, will be doing that shortly after I verify the most recent changes
work with my local test env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] levilentz commented on a diff in pull request #7677: NIFI-7355: add bytecode submission to tinkerpop service
levilentz commented on code in PR #7677:
URL: https://github.com/apache/nifi/pull/7677#discussion_r1328007330
##
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.graph;
+
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.nifi.annotation.behavior.RequiresInstanceClassLoading;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.components.resource.ResourceCardinality;
+import org.apache.nifi.components.resource.ResourceType;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.graph.gremlin.SimpleEntry;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.ssl.SSLContextService;
+import org.apache.nifi.util.StringUtils;
+import org.apache.tinkerpop.gremlin.driver.Client;
+import org.apache.tinkerpop.gremlin.driver.Cluster;
+import org.apache.tinkerpop.gremlin.driver.Result;
+import org.apache.tinkerpop.gremlin.driver.remote.DriverRemoteConnection;
+import org.apache.tinkerpop.gremlin.process.traversal.AnonymousTraversalSource;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource;
+
+import javax.script.Bindings;
+import javax.script.Compilable;
+import javax.script.CompiledScript;
+import javax.script.ScriptEngine;
+import javax.script.ScriptEngineManager;
+import javax.script.ScriptException;
+import java.io.File;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.stream.Collectors;
+
+
+@Tags({"graph", "gremlin"})
+@CapabilityDescription("This service interacts with a tinkerpop-compliant
graph service, providing both script submission and bytecode submission
capabilities. " +
+"Script submission is the default, with the script command being sent
to the gremlin server as text. This should only be used for simple interactions
with a tinkerpop-compliant server. " +
+"Bytecode submission, when providing a jar with the serialization
dependencies, offers much richer way of interacting with the server, and should
be used when doing complex manipulations" +
+" of the underlying data.")
+@RequiresInstanceClassLoading
+public class TinkerpopClientService extends AbstractControllerService
implements GraphClientService {
+public static final String NOT_SUPPORTED = "NOT_SUPPORTED";
+private static final AllowableValue BYTECODE_SUBMISSION = new
AllowableValue("bytecode-submission", "ByteCode Submission",
+"Scripts directly interact with the server via the NiFi JVM"
+);
+
+private static final AllowableValue SCRIPT_SUBMISSION = new
AllowableValue("script-submission", "Script Submission",
+"Script is sent to the gremlin server as a submittion"
+);
+
+private static final AllowableValue YAML_SETTINGS = new
AllowableValue("yaml-settings", "Yaml Settings",
+"Connection to the gremlin server will be specified via a yaml
file (more flexible)");
+
+private static final AllowableValue SERVICE_SETTINGS = new
AllowableValue("service-settings", "Service-Defined Settings",
+"Connection to the gremlin server will be specified via
[GitHub] [nifi] levilentz commented on a diff in pull request #7677: NIFI-7355: add bytecode submission to tinkerpop service
levilentz commented on code in PR #7677: URL: https://github.com/apache/nifi/pull/7677#discussion_r1328007167 ## nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services-nar/src/main/resources/META-INF/NOTICE: ## @@ -108,13 +108,11 @@ The following binary components are provided under the Apache Software License v (ASLv2) Exp4j Copyright 2017 - (ASLv2) Groovy 2.4.16 (http://www.groovy-lang.org) -groovy-2.4.16-indy -groovy-json-2.4.16-indy -groovy-sql-2.4.16-indy + (ASLv2) Groovy 2.5.10 (http://www.groovy-lang.org) Review Comment: @MikeThomsen -- L check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] levilentz commented on a diff in pull request #7677: NIFI-7355: add bytecode submission to tinkerpop service
levilentz commented on code in PR #7677:
URL: https://github.com/apache/nifi/pull/7677#discussion_r1328006626
##
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.graph;
+
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.nifi.annotation.behavior.RequiresInstanceClassLoading;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.components.resource.ResourceCardinality;
+import org.apache.nifi.components.resource.ResourceType;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.graph.gremlin.SimpleEntry;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.ssl.SSLContextService;
+import org.apache.nifi.util.StringUtils;
+import org.apache.tinkerpop.gremlin.driver.Client;
+import org.apache.tinkerpop.gremlin.driver.Cluster;
+import org.apache.tinkerpop.gremlin.driver.Result;
+import org.apache.tinkerpop.gremlin.driver.remote.DriverRemoteConnection;
+import org.apache.tinkerpop.gremlin.process.traversal.AnonymousTraversalSource;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource;
+
+import javax.script.Bindings;
+import javax.script.Compilable;
+import javax.script.CompiledScript;
+import javax.script.ScriptEngine;
+import javax.script.ScriptEngineManager;
+import javax.script.ScriptException;
+import java.io.File;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.stream.Collectors;
+
+
+@Tags({"graph", "gremlin"})
+@CapabilityDescription("This service interacts with a tinkerpop-compliant
graph service, providing both script submission and bytecode submission
capabilities. " +
+"Script submission is the default, with the script command being sent
to the gremlin server as text. This should only be used for simple interactions
with a tinkerpop-compliant server. " +
+"Bytecode submission, when providing a jar with the serialization
dependencies, offers much richer way of interacting with the server, and should
be used when doing complex manipulations" +
+" of the underlying data.")
+@RequiresInstanceClassLoading
+public class TinkerpopClientService extends AbstractControllerService
implements GraphClientService {
+public static final String NOT_SUPPORTED = "NOT_SUPPORTED";
+private static final AllowableValue BYTECODE_SUBMISSION = new
AllowableValue("bytecode-submission", "ByteCode Submission",
+"Scripts directly interact with the server via the NiFi JVM"
+);
+
+private static final AllowableValue SCRIPT_SUBMISSION = new
AllowableValue("script-submission", "Script Submission",
+"Script is sent to the gremlin server as a submittion"
+);
+
+private static final AllowableValue YAML_SETTINGS = new
AllowableValue("yaml-settings", "Yaml Settings",
+"Connection to the gremlin server will be specified via a yaml
file (more flexible)");
+
+private static final AllowableValue SERVICE_SETTINGS = new
AllowableValue("service-settings", "Service-Defined Settings",
+"Connection to the gremlin server will be specified via
[GitHub] [nifi] levilentz commented on a diff in pull request #7677: NIFI-7355: add bytecode submission to tinkerpop service
levilentz commented on code in PR #7677:
URL: https://github.com/apache/nifi/pull/7677#discussion_r1328005806
##
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.graph;
+
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.nifi.annotation.behavior.RequiresInstanceClassLoading;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.components.resource.ResourceCardinality;
+import org.apache.nifi.components.resource.ResourceType;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.graph.gremlin.SimpleEntry;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.ssl.SSLContextService;
+import org.apache.nifi.util.StringUtils;
+import org.apache.tinkerpop.gremlin.driver.Client;
+import org.apache.tinkerpop.gremlin.driver.Cluster;
+import org.apache.tinkerpop.gremlin.driver.Result;
+import org.apache.tinkerpop.gremlin.driver.remote.DriverRemoteConnection;
+import org.apache.tinkerpop.gremlin.process.traversal.AnonymousTraversalSource;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource;
+
+import javax.script.Bindings;
+import javax.script.Compilable;
+import javax.script.CompiledScript;
+import javax.script.ScriptEngine;
+import javax.script.ScriptEngineManager;
+import javax.script.ScriptException;
+import java.io.File;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.stream.Collectors;
+
+
+@Tags({"graph", "gremlin"})
+@CapabilityDescription("This service interacts with a tinkerpop-compliant
graph service, providing both script submission and bytecode submission
capabilities. " +
+"Script submission is the default, with the script command being sent
to the gremlin server as text. This should only be used for simple interactions
with a tinkerpop-compliant server. " +
+"Bytecode submission, when providing a jar with the serialization
dependencies, offers much richer way of interacting with the server, and should
be used when doing complex manipulations" +
+" of the underlying data.")
+@RequiresInstanceClassLoading
+public class TinkerpopClientService extends AbstractControllerService
implements GraphClientService {
+public static final String NOT_SUPPORTED = "NOT_SUPPORTED";
+private static final AllowableValue BYTECODE_SUBMISSION = new
AllowableValue("bytecode-submission", "ByteCode Submission",
+"Scripts directly interact with the server via the NiFi JVM"
+);
+
+private static final AllowableValue SCRIPT_SUBMISSION = new
AllowableValue("script-submission", "Script Submission",
+"Script is sent to the gremlin server as a submittion"
+);
+
+private static final AllowableValue YAML_SETTINGS = new
AllowableValue("yaml-settings", "Yaml Settings",
+"Connection to the gremlin server will be specified via a yaml
file (more flexible)");
+
+private static final AllowableValue SERVICE_SETTINGS = new
AllowableValue("service-settings", "Service-Defined Settings",
+"Connection to the gremlin server will be specified via
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7677: NIFI-7355: add bytecode submission to tinkerpop service
exceptionfactory commented on code in PR #7677:
URL: https://github.com/apache/nifi/pull/7677#discussion_r1328004654
##
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/pom.xml:
##
@@ -110,6 +110,28 @@
gremlin-driver
${gremlin.version}
+
+
+org.codehaus.groovy
+groovy
+3.0.17
+
+
+org.codehaus.groovy
+groovy-jsr223
+3.0.17
+
+
+org.codehaus.groovy
+groovy-dateutil
+3.0.17
Review Comment:
The latest version still shows Groovy 3.0.17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] levilentz commented on a diff in pull request #7677: NIFI-7355: add bytecode submission to tinkerpop service
levilentz commented on code in PR #7677:
URL: https://github.com/apache/nifi/pull/7677#discussion_r1328004530
##
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.graph;
+
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.nifi.annotation.behavior.RequiresInstanceClassLoading;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.components.resource.ResourceCardinality;
+import org.apache.nifi.components.resource.ResourceType;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.graph.gremlin.SimpleEntry;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.ssl.SSLContextService;
+import org.apache.nifi.util.StringUtils;
+import org.apache.tinkerpop.gremlin.driver.Client;
+import org.apache.tinkerpop.gremlin.driver.Cluster;
+import org.apache.tinkerpop.gremlin.driver.Result;
+import org.apache.tinkerpop.gremlin.driver.remote.DriverRemoteConnection;
+import org.apache.tinkerpop.gremlin.process.traversal.AnonymousTraversalSource;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource;
+
+import javax.script.Bindings;
+import javax.script.Compilable;
+import javax.script.CompiledScript;
+import javax.script.ScriptEngine;
+import javax.script.ScriptEngineManager;
+import javax.script.ScriptException;
+import java.io.File;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.stream.Collectors;
+
+
+@Tags({"graph", "gremlin"})
+@CapabilityDescription("This service interacts with a tinkerpop-compliant
graph service, providing both script submission and bytecode submission
capabilities. " +
+"Script submission is the default, with the script command being sent
to the gremlin server as text. This should only be used for simple interactions
with a tinkerpop-compliant server. " +
+"Bytecode submission, when providing a jar with the serialization
dependencies, offers much richer way of interacting with the server, and should
be used when doing complex manipulations" +
+" of the underlying data.")
+@RequiresInstanceClassLoading
+public class TinkerpopClientService extends AbstractControllerService
implements GraphClientService {
+public static final String NOT_SUPPORTED = "NOT_SUPPORTED";
+private static final AllowableValue BYTECODE_SUBMISSION = new
AllowableValue("bytecode-submission", "ByteCode Submission",
+"Scripts directly interact with the server via the NiFi JVM"
+);
+
+private static final AllowableValue SCRIPT_SUBMISSION = new
AllowableValue("script-submission", "Script Submission",
+"Script is sent to the gremlin server as a submittion"
+);
+
+private static final AllowableValue YAML_SETTINGS = new
AllowableValue("yaml-settings", "Yaml Settings",
+"Connection to the gremlin server will be specified via a yaml
file (more flexible)");
+
+private static final AllowableValue SERVICE_SETTINGS = new
AllowableValue("service-settings", "Service-Defined Settings",
+"Connection to the gremlin server will be specified via
[GitHub] [nifi] levilentz commented on a diff in pull request #7677: NIFI-7355: add bytecode submission to tinkerpop service
levilentz commented on code in PR #7677:
URL: https://github.com/apache/nifi/pull/7677#discussion_r1328004438
##
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/src/main/java/org/apache/nifi/graph/TinkerpopClientService.java:
##
@@ -0,0 +1,538 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.graph;
+
+import org.apache.commons.codec.digest.DigestUtils;
+import org.apache.nifi.annotation.behavior.RequiresInstanceClassLoading;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.components.resource.ResourceCardinality;
+import org.apache.nifi.components.resource.ResourceType;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.graph.gremlin.SimpleEntry;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.ssl.SSLContextService;
+import org.apache.nifi.util.StringUtils;
+import org.apache.tinkerpop.gremlin.driver.Client;
+import org.apache.tinkerpop.gremlin.driver.Cluster;
+import org.apache.tinkerpop.gremlin.driver.Result;
+import org.apache.tinkerpop.gremlin.driver.remote.DriverRemoteConnection;
+import org.apache.tinkerpop.gremlin.process.traversal.AnonymousTraversalSource;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource;
+
+import javax.script.Bindings;
+import javax.script.Compilable;
+import javax.script.CompiledScript;
+import javax.script.ScriptEngine;
+import javax.script.ScriptEngineManager;
+import javax.script.ScriptException;
+import java.io.File;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.stream.Collectors;
+
+
+@Tags({"graph", "gremlin"})
+@CapabilityDescription("This service interacts with a tinkerpop-compliant
graph service, providing both script submission and bytecode submission
capabilities. " +
+"Script submission is the default, with the script command being sent
to the gremlin server as text. This should only be used for simple interactions
with a tinkerpop-compliant server. " +
+"Bytecode submission, when providing a jar with the serialization
dependencies, offers much richer way of interacting with the server, and should
be used when doing complex manipulations" +
+" of the underlying data.")
+@RequiresInstanceClassLoading
+public class TinkerpopClientService extends AbstractControllerService
implements GraphClientService {
+public static final String NOT_SUPPORTED = "NOT_SUPPORTED";
+private static final AllowableValue BYTECODE_SUBMISSION = new
AllowableValue("bytecode-submission", "ByteCode Submission",
+"Scripts directly interact with the server via the NiFi JVM"
+);
+
+private static final AllowableValue SCRIPT_SUBMISSION = new
AllowableValue("script-submission", "Script Submission",
+"Script is sent to the gremlin server as a submittion"
+);
+
+private static final AllowableValue YAML_SETTINGS = new
AllowableValue("yaml-settings", "Yaml Settings",
+"Connection to the gremlin server will be specified via a yaml
file (more flexible)");
+
+private static final AllowableValue SERVICE_SETTINGS = new
AllowableValue("service-settings", "Service-Defined Settings",
+"Connection to the gremlin server will be specified via
[GitHub] [nifi] levilentz commented on a diff in pull request #7677: NIFI-7355: add bytecode submission to tinkerpop service
levilentz commented on code in PR #7677:
URL: https://github.com/apache/nifi/pull/7677#discussion_r1328004291
##
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/pom.xml:
##
@@ -110,6 +110,28 @@
gremlin-driver
${gremlin.version}
+
+
+org.codehaus.groovy
+groovy
+3.0.17
+
+
+org.codehaus.groovy
+groovy-jsr223
+3.0.17
+
+
+org.codehaus.groovy
+groovy-dateutil
+3.0.17
+
+
+commons-codec
+commons-codec
+1.15
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] levilentz commented on a diff in pull request #7677: NIFI-7355: add bytecode submission to tinkerpop service
levilentz commented on code in PR #7677:
URL: https://github.com/apache/nifi/pull/7677#discussion_r1328004274
##
nifi-nar-bundles/nifi-graph-bundle/nifi-other-graph-services/pom.xml:
##
@@ -110,6 +110,28 @@
gremlin-driver
${gremlin.version}
+
+
+org.codehaus.groovy
+groovy
+3.0.17
+
+
+org.codehaus.groovy
+groovy-jsr223
+3.0.17
+
+
+org.codehaus.groovy
+groovy-dateutil
+3.0.17
Review Comment:
Implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12055) ListenSyslog: Parse Messages didn't recognize some of the syslogevents
[
https://issues.apache.org/jira/browse/NIFI-12055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17766007#comment-17766007
]
Otto Fowler commented on NIFI-12055:
I am not sure what you mean. I see the <38> in all the messages. I wrote a
test using the bytes from Wireshark and saw the one succeed and rest fail as
you did.
I don't think the failures have anything to do with the facility etc
Sometimes things don't include the hostname in the syslog by default and you
have enable it by configuration. If you can figure out how to do this on your
source side it will be yummy.
You can write a custom GROK to parse these messages without the hostname part
for sure though
> ListenSyslog: Parse Messages didn't recognize some of the syslogevents
> --
>
> Key: NIFI-12055
> URL: https://issues.apache.org/jira/browse/NIFI-12055
> Project: Apache NiFi
> Issue Type: Task
> Components: Extensions
>Affects Versions: 1.23.2
> Environment: Debian VM
>Reporter: Dirk Mader
>Priority: Major
> Fix For: 1.23.2
>
> Attachments: dump_syslog.tcpd
>
>
> I tested with an OpenBSD Current to send syslog to ListenSyslog.
> But most of the Events are running into "invalid".
> In the attached tcpdump are 4 Events: 3 of them will marked as *invalid* by
> "Parsing Messages" 1 of them is marked as as *success*
> The success message is {{"the last message repeated 2 times"}}
> The only change in properties was the UDP Port to 5140
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1651: MINIFICPP-2193 - Add manifest to debug bundle
szaszm commented on code in PR #1651: URL: https://github.com/apache/nifi-minifi-cpp/pull/1651#discussion_r1327994089 ## libminifi/src/c2/C2Agent.cpp: ## @@ -686,6 +686,23 @@ C2Payload C2Agent::bundleDebugInfo(std::maphttps://godbolt.org/z/9vvGK8Wfd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-8135) DataTypeUtils conversion methods for Records to java Maps should respect Choice types
[ https://issues.apache.org/jira/browse/NIFI-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson reassigned NIFI-8135: --- Assignee: Chris Sampson > DataTypeUtils conversion methods for Records to java Maps should respect > Choice types > - > > Key: NIFI-8135 > URL: https://issues.apache.org/jira/browse/NIFI-8135 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.11.4 >Reporter: Chris Sampson >Assignee: Chris Sampson >Priority: Major > > Where a schema field is a Map of Choice, with options of Array (of Strings), > Map (of Strings) or String, Record Readers incorrectly deserialise the data > of the nested Map/Array as Records containing no schema. When converting the > overall Record into a java Map using DataTypeUtils, the nested MapRecord is > not converted into a Map. > This can lead to data loss between readers & writers. > This appears to be related to one/more of: > * missing schema in the nested MapRecord object (even if it's presented with > the data to the Record Reader) - the conversion methods could infer a schema > for such MapRecords rather than effectively skipping them > * Choice types don't appear to be respected for nested fields (e.g. checking > whether the options within a Choice are for Map or Array, not just whether > the field dataType passed to the conversion method is for Map or Array, etc. > ... it's a Choice that should allow for these) > * Array/ Map conversion should not assume all elements within the collection > are of the same type, especially if the field's type is Choice -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] ChrisSamo632 opened a new pull request, #7745: NIFI-8134 allow unescapeJson Record Path function to recursively convert Maps to Records
ChrisSamo632 opened a new pull request, #7745: URL: https://github.com/apache/nifi/pull/7745 # Summary [NIFI-8134](https://issues.apache.org/jira/browse/NIFI-8134) allow unescapeJson Record Path function to recursively convert Maps to Records # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 17 ### Licensing - ~[ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)~ - ~[ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files~ ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7744: NIFI-12053 - Update Github CI Builds for 2.x line to Java 21 images Update NiFi Docs/Readme to reference Java 21 as basis
exceptionfactory commented on code in PR #7744: URL: https://github.com/apache/nifi/pull/7744#discussion_r1327968001 ## nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/pom.xml: ## @@ -412,6 +412,15 @@ + +org.apache.maven.plugins +maven-surefire-plugin + + +--add-opens java.base/java.net=ALL-UNNAMED Review Comment: A comment on the reason for this inclusion would be helpful, mentioning the offending Hive class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] ChrisSamo632 commented on pull request #7744: NIFI-12053 - Update Github CI Builds for 2.x line to Java 21 images Update NiFi Docs/Readme to reference Java 21 as basis
ChrisSamo632 commented on PR #7744: URL: https://github.com/apache/nifi/pull/7744#issuecomment-1722267059 Docker images will need updating to build & run with Java 21 (once the base images are available) - is this being covered under a separate future ticket? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-8134) DataTypeUtils.toRecord methods do not recursively convert Maps into Records
[ https://issues.apache.org/jira/browse/NIFI-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-8134: Fix Version/s: 1.latest 2.latest > DataTypeUtils.toRecord methods do not recursively convert Maps into Records > --- > > Key: NIFI-8134 > URL: https://issues.apache.org/jira/browse/NIFI-8134 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.11.4 >Reporter: Chris Sampson >Assignee: Chris Sampson >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Given a java Map that contains one or more Maps as values (optionally nested > within arrays), the DataTypeUtils.toRecord method should convert the child > Maps to Records before converting the to level Map. > This assumes the associated schema for the data represents these objects as > Records (including as part of a Choice of Array type). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-8134) DataTypeUtils.toRecord methods do not recursively convert Maps into Records
[ https://issues.apache.org/jira/browse/NIFI-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Sampson updated NIFI-8134: Status: Patch Available (was: In Progress) > DataTypeUtils.toRecord methods do not recursively convert Maps into Records > --- > > Key: NIFI-8134 > URL: https://issues.apache.org/jira/browse/NIFI-8134 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.11.4 >Reporter: Chris Sampson >Assignee: Chris Sampson >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Given a java Map that contains one or more Maps as values (optionally nested > within arrays), the DataTypeUtils.toRecord method should convert the child > Maps to Records before converting the to level Map. > This assumes the associated schema for the data represents these objects as > Records (including as part of a Choice of Array type). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7422: NIFI-11740: Added SnowflakeConfigurationService
exceptionfactory closed pull request #7422: NIFI-11740: Added SnowflakeConfigurationService URL: https://github.com/apache/nifi/pull/7422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #7544: NIFI-11858 Improve column name normalization in PutDatabaseRecord and UpdateDatabaseTable processor
exceptionfactory commented on PR #7544: URL: https://github.com/apache/nifi/pull/7544#issuecomment-1722249456 > Hi @exceptionfactory , when this feature will be available in NiFi Thanks @ravinarayansingh These changes still need substantive review, along with a number of other pull requests, but thanks for addressing the initial feedback so far. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11857) CLI - recursively change version of processors
[ https://issues.apache.org/jira/browse/NIFI-11857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765981#comment-17765981 ] ASF subversion and git services commented on NIFI-11857: Commit 4b121827525e393ca365ab36023a2f26f905c2b3 in nifi's branch refs/heads/support/nifi-1.x from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4b12182752 ] NIFI-11857 - CLI - recursively change version of Processors This closes #7528 Signed-off-by: David Handermann (cherry picked from commit cb03d6de74c9931e0ac52f77ce98f5b8eb39e3d1) > CLI - recursively change version of processors > -- > > Key: NIFI-11857 > URL: https://issues.apache.org/jira/browse/NIFI-11857 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 50m > Remaining Estimate: 0h > > Imagine a new version of a component is made available and you want to switch > to that version for hundreds of instances of that component in your flows. > Having a CLI command to do that would be helpful. It'll take a PG ID to scope > where this should be applied. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11857) CLI - recursively change version of processors
[ https://issues.apache.org/jira/browse/NIFI-11857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11857: Fix Version/s: 2.0.0 1.24.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > CLI - recursively change version of processors > -- > > Key: NIFI-11857 > URL: https://issues.apache.org/jira/browse/NIFI-11857 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 2.0.0, 1.24.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Imagine a new version of a component is made available and you want to switch > to that version for hundreds of instances of that component in your flows. > Having a CLI command to do that would be helpful. It'll take a PG ID to scope > where this should be applied. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11857) CLI - recursively change version of processors
[ https://issues.apache.org/jira/browse/NIFI-11857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765980#comment-17765980 ] ASF subversion and git services commented on NIFI-11857: Commit cb03d6de74c9931e0ac52f77ce98f5b8eb39e3d1 in nifi's branch refs/heads/main from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=cb03d6de74 ] NIFI-11857 - CLI - recursively change version of Processors This closes #7528 Signed-off-by: David Handermann > CLI - recursively change version of processors > -- > > Key: NIFI-11857 > URL: https://issues.apache.org/jira/browse/NIFI-11857 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 50m > Remaining Estimate: 0h > > Imagine a new version of a component is made available and you want to switch > to that version for hundreds of instances of that component in your flows. > Having a CLI command to do that would be helpful. It'll take a PG ID to scope > where this should be applied. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7528: NIFI-11857 - CLI - recursively change version of processors
exceptionfactory closed pull request #7528: NIFI-11857 - CLI - recursively change version of processors URL: https://github.com/apache/nifi/pull/7528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12073) Eliminate Toolkit Usage of SecurityManager API which is not allowed in Java 21
[ https://issues.apache.org/jira/browse/NIFI-12073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765976#comment-17765976 ] David Handermann commented on NIFI-12073: - Backported test removal to the support branch to reduce the need for potential future maintenance of these tests. > Eliminate Toolkit Usage of SecurityManager API which is not allowed in Java 21 > -- > > Key: NIFI-12073 > URL: https://issues.apache.org/jira/browse/NIFI-12073 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0, 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12073) Eliminate Toolkit Usage of SecurityManager API which is not allowed in Java 21
[ https://issues.apache.org/jira/browse/NIFI-12073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765975#comment-17765975 ] ASF subversion and git services commented on NIFI-12073: Commit 26193918cf8e1aab98a0199fa41d84b42bb0092a in nifi's branch refs/heads/support/nifi-1.x from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=26193918cf ] NIFI-12073 removed toolkit tests which rely on system exit calls and captures not allowed any longer by defunct security manager support in Java 21 Signed-off-by: Pierre Villard This closes #7743. (cherry picked from commit ad753318e72db821aae8075117b825a5cb0b26c9) > Eliminate Toolkit Usage of SecurityManager API which is not allowed in Java 21 > -- > > Key: NIFI-12073 > URL: https://issues.apache.org/jira/browse/NIFI-12073 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12073) Eliminate Toolkit Usage of SecurityManager API which is not allowed in Java 21
[ https://issues.apache.org/jira/browse/NIFI-12073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12073: Fix Version/s: 1.24.0 > Eliminate Toolkit Usage of SecurityManager API which is not allowed in Java 21 > -- > > Key: NIFI-12073 > URL: https://issues.apache.org/jira/browse/NIFI-12073 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0, 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7744: NIFI-12053 - Update Github CI Builds for 2.x line to Java 21 images Update NiFi Docs/Readme to reference Java 21 as basis
exceptionfactory commented on code in PR #7744:
URL: https://github.com/apache/nifi/pull/7744#discussion_r1327968092
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/bootstrap.conf:
##
@@ -90,6 +85,13 @@ java.arg.17=-Dzookeeper.admin.enableServer=false
#
org.apache.jasper.servlet.JasperLoader,org.jvnet.hk2.internal.DelegatingClassLoader,org.apache.nifi.nar.NarClassLoader
# End of Java Agent config for native library loading.
+# The following entry is needed in Java 21 because some libraries invoke
+# reflective calls that Java no longer considers allowed by default.
+#
https://docs.oracle.com/en/java/javase/16/migrate/migrating-jdk-8-later-jdk-releases.html#GUID-7BB28E4D-99B3-4078-BDC4-FC24180CE82B
+# This may need to be modified if additional reflective access is needed by
certain libraries
+# This is only known to be needed for the Hive3 processors as of now.
+java.arg.20=--add-opens=java.base/java.net=ALL-UNNAMED
Review Comment:
Although this is an unfortunate requirement for Hive 3, the comment is
helpful. Hopefully we can remove this in the future with newer Hive versions.
##
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/pom.xml:
##
@@ -412,6 +412,15 @@
+
+org.apache.maven.plugins
+maven-surefire-plugin
+
+
+--add-opens
java.base/java.net=ALL-UNNAMED
Review Comment:
A comment on the reason for this inclusion avoid be helpful, mentioning the
offending Hive class.
##
.github/workflows/ci-workflow.yml:
##
@@ -97,11 +96,11 @@ jobs:
~/.m2/repository
# Cache Maven modules using a cache key different from setup-java
steps
key: ${{ runner.os }}-maven-static-analysis-${{
hashFiles('**/pom.xml') }}
- - name: Set up Java 17
+ - name: Set up Java 21
uses: actions/setup-java@v3
with:
distribution: 'zulu'
- java-version: '17'
+ java-version: '21-ea'
Review Comment:
We should avoid switching an Early Access build version and wait until the
official release version is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12073) Eliminate Toolkit Usage of SecurityManager API which is not allowed in Java 21
[ https://issues.apache.org/jira/browse/NIFI-12073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765956#comment-17765956 ] ASF subversion and git services commented on NIFI-12073: Commit ad753318e72db821aae8075117b825a5cb0b26c9 in nifi's branch refs/heads/main from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=ad753318e7 ] NIFI-12073 removed toolkit tests which rely on system exit calls and captures not allowed any longer by defunct security manager support in Java 21 Signed-off-by: Pierre Villard This closes #7743. > Eliminate Toolkit Usage of SecurityManager API which is not allowed in Java 21 > -- > > Key: NIFI-12073 > URL: https://issues.apache.org/jira/browse/NIFI-12073 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Priority: Major > Fix For: 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12073) Eliminate Toolkit Usage of SecurityManager API which is not allowed in Java 21
[ https://issues.apache.org/jira/browse/NIFI-12073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12073: -- Fix Version/s: 2.0.0 (was: 2.latest) Assignee: Joe Witt Resolution: Fixed Status: Resolved (was: Patch Available) > Eliminate Toolkit Usage of SecurityManager API which is not allowed in Java 21 > -- > > Key: NIFI-12073 > URL: https://issues.apache.org/jira/browse/NIFI-12073 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 2.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] asfgit closed pull request #7743: NIFI-12073 removed toolkit tests which rely on system exit calls and …
asfgit closed pull request #7743: NIFI-12073 removed toolkit tests which rely on system exit calls and … URL: https://github.com/apache/nifi/pull/7743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12071) Deprecate InvokeGRPC and ListenGRPC
[ https://issues.apache.org/jira/browse/NIFI-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-12071. --- Fix Version/s: 1.24.0 (was: 1.latest) Assignee: Joe Witt Resolution: Fixed > Deprecate InvokeGRPC and ListenGRPC > --- > > Key: NIFI-12071 > URL: https://issues.apache.org/jira/browse/NIFI-12071 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.24.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12071) Deprecate InvokeGRPC and ListenGRPC
[ https://issues.apache.org/jira/browse/NIFI-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17765955#comment-17765955 ] ASF subversion and git services commented on NIFI-12071: Commit f7c06d39a7c8983bae307d27574119ddcf6dc256 in nifi's branch refs/heads/support/nifi-1.x from Joe Witt [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=f7c06d39a7 ] NIFI-12071 add deprecation notices to grpc processors and fix brittle test depending on certain command line output Signed-off-by: Pierre Villard This closes #7741. > Deprecate InvokeGRPC and ListenGRPC > --- > > Key: NIFI-12071 > URL: https://issues.apache.org/jira/browse/NIFI-12071 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Joe Witt >Priority: Major > Fix For: 1.latest > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] joewitt opened a new pull request, #7744: NIFI-12053
joewitt opened a new pull request, #7744: URL: https://github.com/apache/nifi/pull/7744 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12074) Update docker builds to use Java 21 images
Joe Witt created NIFI-12074: --- Summary: Update docker builds to use Java 21 images Key: NIFI-12074 URL: https://issues.apache.org/jira/browse/NIFI-12074 Project: Apache NiFi Issue Type: Improvement Reporter: Joe Witt Fix For: 2.latest -- This message was sent by Atlassian Jira (v8.20.10#820010)
