[GitHub] nifi pull request #2187: NIFI-4450 Update Kite SDK version

2017-10-05 Thread gglanzani 
Github user gglanzani commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2187#discussion_r143040403
  
--- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/pom.xml ---
@@ -25,8 +25,9 @@
 jar
 
 
-1.0.0
+1.1.0
 
1.3.9-1
+2.3.1
--- End diff --

Sure, I got no problem with that!



---

[GitHub] nifi pull request #2187: NIFI-4450 Update Kite SDK version

2017-10-04 Thread gglanzani 
Github user gglanzani commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2187#discussion_r142768827
  
--- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/pom.xml ---
@@ -25,8 +25,9 @@
 jar
 
 
-1.0.0
+1.1.0
 
1.3.9-1
+2.3.1
--- End diff --

Well, the thing is... the tests would fail without jackson. So I've looked 
at the `pom.xml` provided by Kite, and just plugged that into nifi-kite.

Are your tests successful without that addition and kite 1.1.0?


---

[GitHub] nifi pull request #2186: NIFI-4443 Increase StoreInKiteDataset flexibility

2017-10-04 Thread gglanzani 
Github user gglanzani commented on a diff in the pull request:

https://github.com/apache/nifi/pull/2186#discussion_r142768212
  
--- Diff: 
nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AbstractKiteProcessor.java
 ---
@@ -47,33 +47,16 @@
 abstract class AbstractKiteProcessor extends AbstractProcessor {
 
 private static final Splitter COMMA = Splitter.on(',').trimResults();
-protected static final Validator FILES_EXIST = new Validator() {
-@Override
-public ValidationResult validate(String subject, String 
configFiles,
-ValidationContext context) {
-if (configFiles != null && !configFiles.isEmpty()) {
-for (String file : COMMA.split(configFiles)) {
-ValidationResult result = 
StandardValidators.FILE_EXISTS_VALIDATOR
-.validate(subject, file, context);
-if (!result.isValid()) {
-return result;
-}
-}
-}
-return new ValidationResult.Builder()
-.subject(subject)
-.input(configFiles)
-.explanation("Files exist")
-.valid(true)
-.build();
-}
-};
 
 protected static final PropertyDescriptor CONF_XML_FILES
 = new PropertyDescriptor.Builder()
-.name("Hadoop configuration files")
-.description("A comma-separated list of Hadoop configuration 
files")
-.addValidator(FILES_EXIST)
+.name("hadoop-configuration-resources")
--- End diff --

Good point, fixed


---

[GitHub] nifi pull request #2187: NIFI-4450 Update Kite SDK version

2017-10-01 Thread gglanzani 
GitHub user gglanzani opened a pull request:

https://github.com/apache/nifi/pull/2187

NIFI-4450 Update Kite SDK version

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?

I have restricted myself to the kite-nar tests, are nifi-processing tests 
are failing for, to me, some extraneous reason.

- [ ] Have you written or updated unit tests to verify your changes?

Not relevant.

- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 

Yes, jackson is released under the same Apache license

- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gglanzani/nifi nb

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2187


commit 2f9a2cd0c879e4898b4227b0b4ff83e48ebde445
Author: Giovanni Lanzani <giova...@lanzani.nl>
Date:   2017-10-01T17:52:53Z

[NIFI-4450] Update Kite SDK version




---

[GitHub] nifi pull request #2186: [NIFI-4443] Increase StoreInKiteDataset flexibility

2017-09-30 Thread gglanzani 
GitHub user gglanzani opened a pull request:

https://github.com/apache/nifi/pull/2186

[NIFI-4443] Increase StoreInKiteDataset flexibility

* The configuration property CONF_XML_FILE now support Expression
  Language and reuse a Hadoop validator;
* The ADDITIONAL_CLASSPATH_RESOURCES property has been added, so that
  things such as writing to Azure Blob Storage should become possible.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

Yes. The Jira also mention Kerberos support. I am not feeling so 
adventurous however (I'm a Python programmer). I can update the Jira and split 
it, as I believe there is still value in this PR.

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?

Note: `nifi-scripting-processors` is giving a, to me, completely unrelated 
error to the proposed changes

```java
java.lang.ClassCastException: Cannot cast 
jdk.nashorn.internal.objects.NativeArray to java.util.Collection
```

- [x] Have you written or updated unit tests to verify your changes?

I had to put in a Dataset creation in the test because otherwise I couldn't 
use `runner.assertValid()`. If there is a simpler way to do this, please let me 
know and I'll update accordingly.

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gglanzani/nifi master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2186.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2186


commit 6ab60ee2f14700fb3e8dd2849bef4391f536fca8
Author: Giovanni Lanzani <giova...@lanzani.nl>
Date:   2017-09-29T21:21:03Z

[NIFI-4443] Increase StoreInKiteDataset flexibility

* The configuration property CONF_XML_FILE now support Expression
  Language and reuse a Hadoop validator;
* The ADDITIONAL_CLASSPATH_RESOURCES property has been added, so that
  things such as writing to Azure Blob Storage should become possible.




---

[GitHub] nifi pull request #1558: Clarify documentation for File Filter

2017-03-02 Thread gglanzani 
GitHub user gglanzani opened a pull request:

https://github.com/apache/nifi/pull/1558

Clarify documentation for File Filter

Could close JIRA 3549


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gglanzani/nifi master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1558


commit 49b6d46022ddf46f7b572d69c844c57dfc54e287
Author: Giovanni Lanzani <gglanz...@users.noreply.github.com>
Date:   2017-03-02T21:43:17Z

Clarify documentation for File Filter

Could close JIRA 3549




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1557: Clarify documentation for File Filter

2017-03-02 Thread gglanzani 
Github user gglanzani closed the pull request at:

https://github.com/apache/nifi/pull/1557


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1557: Clarify documenation for File Filter

2017-03-02 Thread gglanzani 
GitHub user gglanzani opened a pull request:

https://github.com/apache/nifi/pull/1557

Clarify documenation for File Filter

Could close JIRA 3549


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gglanzani/nifi master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1557.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1557


commit 62462ce4d03fcd9c680006fb1de981ebc996c06c
Author: Giovanni Lanzani <gglanz...@users.noreply.github.com>
Date:   2017-03-02T21:26:05Z

Clarify documenation for File Filter

Could close JIRA 3549




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1467: NIFI-3408 Add exception class when InvokeHTTP fails

2017-02-06 Thread gglanzani 
Github user gglanzani commented on the issue:

https://github.com/apache/nifi/pull/1467
  
Hi @pvillard31 thanks for the review. I've incorporated the changes.

I've renamed the two new attributes to 
`invoke.http.java.exception.{class,message}`. They reflect better the 
underlying methods.

Note: I've not updated the test to test for the message. I think it 
would turn out to be a pretty verbose test BUT let me know in case you 
disagree :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1467: NIFI-3408 Add exception class when InvokeHTTP fails

2017-02-03 Thread gglanzani 
Github user gglanzani commented on the issue:

https://github.com/apache/nifi/pull/1467
  
I see the tests are failing here, but seemingly due to the npm registry.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1467: NIFI-3408 Add exception class when InvokeHTTP fails

2017-02-02 Thread gglanzani 
GitHub user gglanzani opened a pull request:

https://github.com/apache/nifi/pull/1467

NIFI-3408 Add exception class when InvokeHTTP fails

Hi, 

I think this closes the Jira ticket. I couldn't execute (all) the tests as 
an SMTP tests fails on Windows (in my machine at least), but it fails on the 
master branch and on release 1.1.0 and 1.0.0 so I guess it's not due to the 
changes below.

I also have not added tests related to this. The test suite in 
nifi-standard-processors seemed quite thin, I'm probably missing something.

Disclaimer: I'm a data scientist that writes Python. I'm more than willing 
to learn (and help!) if things are not how they should be.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gglanzani/nifi master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1467.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1467






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---