[GitHub] nifi issue #1431: Merge pull request #1 from apache/master

2017-01-18 Thread ktseytlin 
Github user ktseytlin commented on the issue:

https://github.com/apache/nifi/pull/1431
  
please disregard!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1431: Merge pull request #1 from apache/master

2017-01-18 Thread ktseytlin 
Github user ktseytlin closed the pull request at:

https://github.com/apache/nifi/pull/1431


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1431: Merge pull request #1 from apache/master

2017-01-18 Thread ktseytlin 
GitHub user ktseytlin opened a pull request:

https://github.com/apache/nifi/pull/1431

Merge pull request #1 from apache/master

Bringing in Nifi master into local

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ktseytlin/nifi master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1431


commit e20bb67d94f2bc636ffed6c205a2cebfad5ddab6
Author: Keren Tseytlin <ktseyt...@users.noreply.github.com>
Date:   2016-10-06T20:44:51Z

Merge pull request #1 from apache/master

Bringing in Nifi master into local




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1112: NIFI-2799: AWS Credentials for Assume Role Need Proxy

2016-10-12 Thread ktseytlin 
Github user ktseytlin commented on the issue:

https://github.com/apache/nifi/pull/1112
  
@jvwing I tested with the updated logic on my end and it worked, so I 
pushed that out in the most recent commit. Does all look good to you now? Any 
other improvements we can make?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-11 Thread ktseytlin 
Github user ktseytlin commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1112#discussion_r82799369
  
--- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/strategies/AssumeRoleCredentialsStrategy.java
 ---
@@ -113,16 +134,34 @@ public AWSCredentialsProvider 
getDerivedCredentialsProvider(Map

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-07 Thread ktseytlin 
Github user ktseytlin commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1112#discussion_r82453054
  
--- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/strategies/AssumeRoleCredentialsStrategy.java
 ---
@@ -113,16 +134,34 @@ public AWSCredentialsProvider 
getDerivedCredentialsProvider(Map

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-07 Thread ktseytlin 
Github user ktseytlin commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1112#discussion_r82451576
  
--- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/strategies/AssumeRoleCredentialsStrategy.java
 ---
@@ -113,16 +134,34 @@ public AWSCredentialsProvider 
getDerivedCredentialsProvider(Map(STSAssumeRoleSessionCredentialsProvider.java:187)
at 
com.amazonaws.auth.STSAssumeRoleSessionCredentialsProvider.(STSAssumeRoleSessionCredentialsProvider.java:34)
at 
com.amazonaws.auth.STSAssumeRoleSessionCredentialsProvider$Builder.build(STSAssumeRoleSessionCredentialsProvider.java:436)
```

I wanted to refactor it like that, but again, since I am not able to test 
in my environment the previous work I played it on the safe side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-07 Thread ktseytlin 
Github user ktseytlin commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1112#discussion_r82450516
  
--- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/strategies/AssumeRoleCredentialsStrategy.java
 ---
@@ -113,16 +134,34 @@ public AWSCredentialsProvider 
getDerivedCredentialsProvider(Map

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-07 Thread ktseytlin 
Github user ktseytlin commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1112#discussion_r82446283
  
--- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/strategies/AssumeRoleCredentialsStrategy.java
 ---
@@ -113,16 +134,34 @@ public AWSCredentialsProvider 
getDerivedCredentialsProvider(Map

[GitHub] nifi issue #1112: NIFI-2799: AWS Credentials for Assume Role Need Proxy

2016-10-07 Thread ktseytlin 
Github user ktseytlin commented on the issue:

https://github.com/apache/nifi/pull/1112
  
This is obviously a pretty awful drawing I threw together... but it shows 
what AWS is like in an enterprise. For every single service I ever want to 
execute, I need to go through a proxy. Hence why this bug fix is needed. The 
only situation in which this wouldn't occur is if the enterprise specifically 
opened up the endpoints to each service, which would allow it to avoid going 
through the proxy. 


![image](https://cloud.githubusercontent.com/assets/10350664/19191905/4e30ecee-8c72-11e6-9cab-3f42caee5f4f.png)

@jvwing Hope this is helpful for regarding our previous conversation about 
proxy things :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-07 Thread ktseytlin 
Github user ktseytlin commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1112#discussion_r82389180
  
--- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/CredentialPropertyDescriptors.java
 ---
@@ -44,7 +45,7 @@
 .allowableValues("true", "false")
 .defaultValue("false")
 .description("If true, uses the Default Credential chain, 
including EC2 instance profiles or roles, " +
-"environment variables, default user credentials, etc.")
+"environment variables, default user credentials, 
etc.")
--- End diff --

Yes, it's just a formatting change to make it clear that the break in the 
string means that it's still part of the description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-07 Thread ktseytlin 
Github user ktseytlin commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1112#discussion_r82389187
  
--- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/CredentialPropertyDescriptors.java
 ---
@@ -153,6 +154,29 @@
 .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
 .sensitive(false)
 .description("External ID for cross-account access. This is 
used in conjunction with role arn, " +
-"role name, and optional session time out")
+"role name, and optional session time out")
--- End diff --

Yes, it's just a formatting change to make it clear that the break in the 
string means that it's still part of the description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-07 Thread ktseytlin 
Github user ktseytlin commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1112#discussion_r82388965
  
--- Diff: 
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/CredentialPropertyDescriptors.java
 ---
@@ -18,6 +18,7 @@
 
 import org.apache.nifi.components.PropertyDescriptor;
 import org.apache.nifi.processor.util.StandardValidators;
+import org.joda.time.DateTime;
--- End diff --

Yep, will remove. I actually don't remember adding this, my bad.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-06 Thread ktseytlin 
GitHub user ktseytlin opened a pull request:

https://github.com/apache/nifi/pull/1112

NIFI-2799: AWS Credentials for Assume Role Need Proxy

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

https://issues.apache.org/jira/browse/NIFI-2799

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?

Full tests have been run, and unit tests for additional functionality pass. 
This build has also been tested on AWS and it is confirmed that the way the 
proxy is configured using these changes allow for the AssumeRole tokens to be 
properly generated.

- [X ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

@jvwing 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ktseytlin/nifi NIFI-2799

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1112


commit e20bb67d94f2bc636ffed6c205a2cebfad5ddab6
Author: Keren Tseytlin <ktseyt...@users.noreply.github.com>
Date:   2016-10-06T20:44:51Z

Merge pull request #1 from apache/master

Bringing in Nifi master into local

commit 8c6d0c81a2ff5e417ee7b676a0db5d773a6c7679
Author: Keren Tseytlin <keren.tseyt...@capitalone.com>
Date:   2016-10-06T21:04:12Z

Updated AssumeAWSCredentials to allow for Assume Role to create and use 
proxy credentials in order to get temprorary access keys when traversing VPCs

commit a980194e9b3ceca0cc8fdd2ad17b996c4c1d19b7
Author: speddy93 <saisumanpe...@gmail.com>
Date:   2016-10-06T21:10:41Z

Added tests: testAssumeRoleInvalidProxyPort




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---