[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1203: MINIFICPP-1672 - Configurable msi
adamdebreceni commented on a change in pull request #1203: URL: https://github.com/apache/nifi-minifi-cpp/pull/1203#discussion_r738409844 ## File path: msi/WixWin.wsi ## @@ -113,6 +117,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more 1 + 1 Review comment: removed the license dialog step for "Change" action -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1203: MINIFICPP-1672 - Configurable msi
adamdebreceni commented on a change in pull request #1203: URL: https://github.com/apache/nifi-minifi-cpp/pull/1203#discussion_r738156449 ## File path: msi/WixWin.wsi ## @@ -113,6 +117,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more 1 + 1 Review comment: since the user might select new extension to be added I felt like the same legal requirements apply as during a fresh install, IANAL so if it is not required I'll remove it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1203: MINIFICPP-1672 - Configurable msi
adamdebreceni commented on a change in pull request #1203: URL: https://github.com/apache/nifi-minifi-cpp/pull/1203#discussion_r736522171 ## File path: CMakeLists.txt ## @@ -808,14 +809,28 @@ else() endif() set(CPACK_PACKAGE_INSTALL_DIRECTORY "ApacheNiFiMiNiFi") set(CPACK_ARCHIVE_COMPONENT_INSTALL ON) -set(CPACK_RDKAFKA_COMPONENT_INSTALL ON) -set(CPACK_MQTT_COMPONENT_INSTALL ON) + + +# !WARNING! we need to manually add to CPACK_COMPONENTS_ALL otherwise +# all components specified in "install" directives are added +# (including thirdparties like range-v3) + +list(APPEND CPACK_COMPONENTS_ALL bin) +cpack_add_component(bin REQUIRED) if(WIN32) - set(CPACK_COMPONENTS_ALL bin conf minifijni tzdata) + list(APPEND CPACK_COMPONENTS_ALL tzdata) + cpack_add_component(tzdata) else() - set(CPACK_COMPONENTS_ALL bin conf minifijni) + list(APPEND CPACK_COMPONENTS_ALL conf) + cpack_add_component(conf REQUIRED) endif() Review comment: added display names -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
