[jira] [Commented] (NIFI-2280) Annotate methods as deprecated on 0.x which aren't needed on 1.x

2016-07-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381451#comment-15381451
 ] 

ASF GitHub Bot commented on NIFI-2280:
--

Github user joewitt closed the pull request at:

https://github.com/apache/nifi/pull/664


> Annotate methods as deprecated on 0.x which aren't needed on 1.x
> 
>
> Key: NIFI-2280
> URL: https://issues.apache.org/jira/browse/NIFI-2280
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
> Fix For: 0.8.0
>
>
> During the deprecated method removal/cleanup on 1.0 a few methods became no 
> longer necessary that weren't deprecated on 0.x.
> So this ticket is to mark them as deprecated on 0.x.
> They are:
> - Encrypt Process interface method for getCipher can be Deprecated. Was 
> deprecated in a couple impls.  Discussion on NIFI-1157
> - AbstractControllerService 'onConfigurationChange' is no longer needed.  Was 
> an empty impl and invoked by annotation.  Deprecate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2280) Annotate methods as deprecated on 0.x which aren't needed on 1.x

2016-07-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381442#comment-15381442
 ] 

ASF GitHub Bot commented on NIFI-2280:
--

Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/664
  
@joewitt just pushed out the change but since it's only on the 0.x branch 
you'll need to close this PR manually.

https://git1-us-west.apache.org/repos/asf?p=nifi.git;a=commit;h=537b3d0d


> Annotate methods as deprecated on 0.x which aren't needed on 1.x
> 
>
> Key: NIFI-2280
> URL: https://issues.apache.org/jira/browse/NIFI-2280
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
> Fix For: 0.8.0
>
>
> During the deprecated method removal/cleanup on 1.0 a few methods became no 
> longer necessary that weren't deprecated on 0.x.
> So this ticket is to mark them as deprecated on 0.x.
> They are:
> - Encrypt Process interface method for getCipher can be Deprecated. Was 
> deprecated in a couple impls.  Discussion on NIFI-1157
> - AbstractControllerService 'onConfigurationChange' is no longer needed.  Was 
> an empty impl and invoked by annotation.  Deprecate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2280) Annotate methods as deprecated on 0.x which aren't needed on 1.x

2016-07-17 Thread Joseph Witt (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381439#comment-15381439
 ] 

Joseph Witt commented on NIFI-2280:
---

ah nice catch and thanks for taking care of it!

> Annotate methods as deprecated on 0.x which aren't needed on 1.x
> 
>
> Key: NIFI-2280
> URL: https://issues.apache.org/jira/browse/NIFI-2280
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
> Fix For: 0.8.0
>
>
> During the deprecated method removal/cleanup on 1.0 a few methods became no 
> longer necessary that weren't deprecated on 0.x.
> So this ticket is to mark them as deprecated on 0.x.
> They are:
> - Encrypt Process interface method for getCipher can be Deprecated. Was 
> deprecated in a couple impls.  Discussion on NIFI-1157
> - AbstractControllerService 'onConfigurationChange' is no longer needed.  Was 
> an empty impl and invoked by annotation.  Deprecate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2280) Annotate methods as deprecated on 0.x which aren't needed on 1.x

2016-07-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381430#comment-15381430
 ] 

ASF GitHub Bot commented on NIFI-2280:
--

Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/664
  
Looks good overall, a couple of the deprecated markings are missing a 
corresponding "@deprecated use other getCipher requiring a salt" javadoc. I'll 
just add them for you because everything else looks good.


> Annotate methods as deprecated on 0.x which aren't needed on 1.x
> 
>
> Key: NIFI-2280
> URL: https://issues.apache.org/jira/browse/NIFI-2280
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
> Fix For: 0.8.0
>
>
> During the deprecated method removal/cleanup on 1.0 a few methods became no 
> longer necessary that weren't deprecated on 0.x.
> So this ticket is to mark them as deprecated on 0.x.
> They are:
> - Encrypt Process interface method for getCipher can be Deprecated. Was 
> deprecated in a couple impls.  Discussion on NIFI-1157
> - AbstractControllerService 'onConfigurationChange' is no longer needed.  Was 
> an empty impl and invoked by annotation.  Deprecate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2280) Annotate methods as deprecated on 0.x which aren't needed on 1.x

2016-07-16 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380923#comment-15380923
 ] 

ASF subversion and git services commented on NIFI-2280:
---

Commit ad02b43099312d0a3552cd7e032385272d076d8d in nifi's branch 
refs/heads/master from [~joewitt]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ad02b43 ]

NIFI-1157 removed methods no longer needed due to deprecation cleanup.  In 
NIFI-2280 also ensure they were deprecated on the 0.x line. This closes #663.


> Annotate methods as deprecated on 0.x which aren't needed on 1.x
> 
>
> Key: NIFI-2280
> URL: https://issues.apache.org/jira/browse/NIFI-2280
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
> Fix For: 0.8.0
>
>
> During the deprecated method removal/cleanup on 1.0 a few methods became no 
> longer necessary that weren't deprecated on 0.x.
> So this ticket is to mark them as deprecated on 0.x.
> They are:
> - Encrypt Process interface method for getCipher can be Deprecated. Was 
> deprecated in a couple impls.  Discussion on NIFI-1157
> - AbstractControllerService 'onConfigurationChange' is no longer needed.  Was 
> an empty impl and invoked by annotation.  Deprecate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (NIFI-2280) Annotate methods as deprecated on 0.x which aren't needed on 1.x

2016-07-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380171#comment-15380171
 ] 

ASF GitHub Bot commented on NIFI-2280:
--

GitHub user joewitt opened a pull request:

https://github.com/apache/nifi/pull/664

NIFI-2280 marked methods as deprecated which will be removed in next major 
release

This PR must only be applied to the 0.x line.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/joewitt/incubator-nifi NIFI-2280

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/664.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #664


commit d060d75f5fb7a147fe7e0ef9035e8246b9951862
Author: joewitt 
Date:   2016-07-15T21:34:08Z

NIFI-2280 marked methods as deprecated as appropriate to the cleanup 
discovered found in NIFI-1157




> Annotate methods as deprecated on 0.x which aren't needed on 1.x
> 
>
> Key: NIFI-2280
> URL: https://issues.apache.org/jira/browse/NIFI-2280
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Joseph Witt
>Assignee: Joseph Witt
> Fix For: 0.8.0
>
>
> During the deprecated method removal/cleanup on 1.0 a few methods became no 
> longer necessary that weren't deprecated on 0.x.
> So this ticket is to mark them as deprecated on 0.x.
> They are:
> - Encrypt Process interface method for getCipher can be Deprecated. Was 
> deprecated in a couple impls.  Discussion on NIFI-1157
> - AbstractControllerService 'onConfigurationChange' is no longer needed.  Was 
> an empty impl and invoked by annotation.  Deprecate.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)