[jira] [Commented] (NIFI-3474) GeoEnrich - stop using exceptions for mainline flow control.
[ https://issues.apache.org/jira/browse/NIFI-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951107#comment-15951107 ] Andre F de Miranda commented on NIFI-3474: -- [~randy_b] did you have a chance to have a look on [~joewitt] reponse? Are you ok if we close this ticket? > GeoEnrich - stop using exceptions for mainline flow control. > > > Key: NIFI-3474 > URL: https://issues.apache.org/jira/browse/NIFI-3474 > Project: Apache NiFi > Issue Type: Bug >Reporter: Randy Bovay >Assignee: Andre F de Miranda >Priority: Minor > > modification to the code to stop using exceptions for mainline flow control. > Specifically we don't want to throw an exception simply because an address > was not found. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3474) GeoEnrich - stop using exceptions for mainline flow control.
[ https://issues.apache.org/jira/browse/NIFI-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864929#comment-15864929 ] Joseph Witt commented on NIFI-3474: --- Yeah I believe it is a no-fix. Will defer to [~randy_b] as the requester. There are two aspects of concern: 1) What if a flow file comes in with no attribute containing a valid IP address? - avoid this by having RouteOnAttribute validate the input before sending to this processor 2) What if the ip address attribute results in a no-lookup? - this case of causing exceptions has already been resolved in the existing GeoEnrich processor. The maxmind reader was overridden to fix this behavior and actually I believe this was the reason for this ticket. Believe this is an OBE. I think all cases are well covered now. > GeoEnrich - stop using exceptions for mainline flow control. > > > Key: NIFI-3474 > URL: https://issues.apache.org/jira/browse/NIFI-3474 > Project: Apache NiFi > Issue Type: Bug >Reporter: Randy Bovay >Assignee: Andre >Priority: Minor > > modification to the code to stop using exceptions for mainline flow control. > Specifically we don't want to throw an exception simply because an address > was not found. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3474) GeoEnrich - stop using exceptions for mainline flow control.
[ https://issues.apache.org/jira/browse/NIFI-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864889#comment-15864889 ] Andre commented on NIFI-3474: - sorry [~joewitt] I misinterpreted your comment. Seems like a no-fix to me. > GeoEnrich - stop using exceptions for mainline flow control. > > > Key: NIFI-3474 > URL: https://issues.apache.org/jira/browse/NIFI-3474 > Project: Apache NiFi > Issue Type: Bug >Reporter: Randy Bovay >Assignee: Andre >Priority: Minor > > modification to the code to stop using exceptions for mainline flow control. > Specifically we don't want to throw an exception simply because an address > was not found. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3474) GeoEnrich - stop using exceptions for mainline flow control.
[ https://issues.apache.org/jira/browse/NIFI-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864874#comment-15864874 ] Andre commented on NIFI-3474: - I am happy to address that as part of the GeoEnrich realated revamp I am putting together as part of NIFI-2661 > GeoEnrich - stop using exceptions for mainline flow control. > > > Key: NIFI-3474 > URL: https://issues.apache.org/jira/browse/NIFI-3474 > Project: Apache NiFi > Issue Type: Bug >Reporter: Randy Bovay >Assignee: Andre >Priority: Minor > > modification to the code to stop using exceptions for mainline flow control. > Specifically we don't want to throw an exception simply because an address > was not found. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3474) GeoEnrich - stop using exceptions for mainline flow control.
[ https://issues.apache.org/jira/browse/NIFI-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864558#comment-15864558 ] Joseph Witt commented on NIFI-3474: --- It is definitely the case that RouteOnAttribute should be used ahead of this processor to ensure it is passed valid input. Passing it input for which there is no valid IP address present in the specified input means we'd need to add an additional relationship "failure" or "invalid input" or something which we'd like to avoid as using 'not found' seems improper considering at present it meaningfully says "I looked up the IP and there were no results in the database" which is more meaningful than "for some reason I didn't find anything" Does this make sense? > GeoEnrich - stop using exceptions for mainline flow control. > > > Key: NIFI-3474 > URL: https://issues.apache.org/jira/browse/NIFI-3474 > Project: Apache NiFi > Issue Type: Bug >Reporter: Randy Bovay >Priority: Minor > > modification to the code to stop using exceptions for mainline flow control. > Specifically we don't want to throw an exception simply because an address > was not found. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
