[jira] [Commented] (NIFI-4745) Emit validation failure description in attribute from ValidateRecord processor

2018-02-06 Thread Koji Kawamura (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353776#comment-16353776
 ] 

Koji Kawamura commented on NIFI-4745:
-

Hi [~alfonz], I've added you as a contributor of NiFi JIRA project and assigned 
you to this one. Mark has posted several comments on your 
[PR|https://github.com/apache/nifi/pull/2425], have you seen those already? If 
you have any questions, please let us know. Thanks!

> Emit validation failure description in attribute from ValidateRecord processor
> --
>
> Key: NIFI-4745
> URL: https://issues.apache.org/jira/browse/NIFI-4745
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.5.0
>Reporter: Martin Mucha
>Assignee: Martin Mucha
>Priority: Minor
>
> We need to pass description of validation failure further in
> processing chain, and eventually pass it back to calling system.
> Therefore having failure description logged in logs and issued as provenance
> route event is not sufficient for us. 
> It should be easy to emit same data, which are being sent in provenance route 
> event, from ValidateRecord as new attribute.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4745) Emit validation failure description in attribute from ValidateRecord processor

2018-01-23 Thread Martin Mucha (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335675#comment-16335675
 ] 

Martin Mucha commented on NIFI-4745:


created new pull request, please check it up.

Thanks.

> Emit validation failure description in attribute from ValidateRecord processor
> --
>
> Key: NIFI-4745
> URL: https://issues.apache.org/jira/browse/NIFI-4745
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.5.0
>Reporter: Martin Mucha
>Priority: Minor
>
> We need to pass description of validation failure further in
> processing chain, and eventually pass it back to calling system.
> Therefore having failure description logged in logs and issued as provenance
> route event is not sufficient for us. 
> It should be easy to emit same data, which are being sent in provenance route 
> event, from ValidateRecord as new attribute.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4745) Emit validation failure description in attribute from ValidateRecord processor

2018-01-15 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326701#comment-16326701
 ] 

ASF GitHub Bot commented on NIFI-4745:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/2384
  
Hi @martin-mucha Thanks for your first contribution! The PR is closed 
without being reviewed and I can't find other PRs created for NIFI-4745. Do you 
have a PR ready for being reviewed somewhere?

About your concern to add another argument to the completeFlowFile method 
which has already lots of arguments, I think that should be fine, since it's 
just a private method and the method is a good place to add new attribute 
values.

BTW, ValidateRecord can validate multiple Records within a single incoming 
FlowFile. Is it going to be sufficient to write validation result to a FlowFile 
attribute? Isn't it be more useful if we can write validation failure detail to 
the outgoing Records, so that each record can have its failure detail?



> Emit validation failure description in attribute from ValidateRecord processor
> --
>
> Key: NIFI-4745
> URL: https://issues.apache.org/jira/browse/NIFI-4745
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.5.0
>Reporter: Martin Mucha
>Priority: Minor
>
> We need to pass description of validation failure further in
> processing chain, and eventually pass it back to calling system.
> Therefore having failure description logged in logs and issued as provenance
> route event is not sufficient for us. 
> It should be easy to emit same data, which are being sent in provenance route 
> event, from ValidateRecord as new attribute.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4745) Emit validation failure description in attribute from ValidateRecord processor

2018-01-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318765#comment-16318765
 ] 

ASF GitHub Bot commented on NIFI-4745:
--

Github user mmucha-redhat closed the pull request at:

https://github.com/apache/nifi/pull/2384


> Emit validation failure description in attribute from ValidateRecord processor
> --
>
> Key: NIFI-4745
> URL: https://issues.apache.org/jira/browse/NIFI-4745
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.5.0
>Reporter: Martin Mucha
>Priority: Minor
>
> We need to pass description of validation failure further in
> processing chain, and eventually pass it back to calling system.
> Therefore having failure description logged in logs and issued as provenance
> route event is not sufficient for us. 
> It should be easy to emit same data, which are being sent in provenance route 
> event, from ValidateRecord as new attribute.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4745) Emit validation failure description in attribute from ValidateRecord processor

2018-01-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315459#comment-16315459
 ] 

ASF GitHub Bot commented on NIFI-4745:
--

Github user mmucha-redhat commented on the issue:

https://github.com/apache/nifi/pull/2384
  
Hi!

This is my first contribution. Please help me to finish this; I don't like 
the śtate of code in this file, and would like to agree on doing some 
refactorings, namely completelyFlowFile having too many arguments. Ideally I 
wouldn't like to pass attributeNameToStoreFailureDescription into this method, 
but I did not find a way how to add attribute, when writer is not closed yet. 
Please comment heavily if needed, I'm here ready to fix all issues!
Thanks!



> Emit validation failure description in attribute from ValidateRecord processor
> --
>
> Key: NIFI-4745
> URL: https://issues.apache.org/jira/browse/NIFI-4745
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.5.0
>Reporter: Martin Mucha
>Priority: Minor
>
> We need to pass description of validation failure further in
> processing chain, and eventually pass it back to calling system.
> Therefore having failure description logged in logs and issued as provenance
> route event is not sufficient for us. 
> It should be easy to emit same data, which are being sent in provenance route 
> event, from ValidateRecord as new attribute.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (NIFI-4745) Emit validation failure description in attribute from ValidateRecord processor

2018-01-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315409#comment-16315409
 ] 

ASF GitHub Bot commented on NIFI-4745:
--

GitHub user mmucha-redhat opened a pull request:

https://github.com/apache/nifi/pull/2384

NIFI-4745 : configuration property allowing failure description proce…

…ssing

We need to pass description of validation failure further in
processing chain, and eventually pass it back to calling system.
Therefore having failure desc logged in logs and issued as provenance
route event is not sufficient for us.

This patch adds new property, specifying name of attribute to be
created and filled with validation failure description.

Signed-off-by: Martin Mucha 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mmucha-redhat/nifi emitFailureDescription

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2384


commit 34ab2d8df08af00c1363c2f23c442e1ce1d5419a
Author: Martin Mucha 
Date:   2018-01-07T10:34:30Z

NIFI-4745 : configuration property allowing failure description processing

We need to pass description of validation failure further in
processing chain, and eventually pass it back to calling system.
Therefore having failure desc logged in logs and issued as provenance
route event is not sufficient for us.

This patch adds new property, specifying name of attribute to be
created and filled with validation failure description.

Signed-off-by: Martin Mucha 




> Emit validation failure description in attribute from ValidateRecord processor
> --
>
> Key: NIFI-4745
> URL: https://issues.apache.org/jira/browse/NIFI-4745
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.5.0
>Reporter: Martin Mucha
>Priority: Minor
>
> We need to pass description of validation failure further in
> processing chain, and eventually pass it back to calling system.
> Therefore having failure description logged in logs and issued as provenance
> route event is not sufficient for us. 
> It should be easy to emit same data, which are being sent in provenance route 
> event, from ValidateRecord as new attribute.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)