[jira] [Commented] (OPENNLP-1213) Use ja for Japanese language code rather than jp
[
https://issues.apache.org/jira/browse/OPENNLP-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591454#comment-16591454
]
ASF GitHub Bot commented on OPENNLP-1213:
-
kojisekig closed pull request #328: OPENNLP-1213: Use ja for Japanese language
code rather than jp
URL: https://github.com/apache/opennlp/pull/328
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/opennlp-tools/src/main/java/opennlp/tools/sentdetect/lang/Factory.java
b/opennlp-tools/src/main/java/opennlp/tools/sentdetect/lang/Factory.java
index 4a34229d7..b54c1590e 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/sentdetect/lang/Factory.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/sentdetect/lang/Factory.java
@@ -35,7 +35,7 @@
public static final char[] thEosCharacters = new char[] { ' ','\n' };
- public static final char[] jpEosCharacters = new char[] {'。', '！', '？'};
+ public static final char[] jpnEosCharacters = new char[] {'。', '！', '？'};
public EndOfSentenceScanner createEndOfSentenceScanner(String languageCode) {
@@ -72,8 +72,8 @@ public SDContextGenerator
createSentenceContextGenerator(String languageCode) {
return thEosCharacters;
} else if ("pt".equals(languageCode) || "por".equals(languageCode)) {
return ptEosCharacters;
-} else if ("jp".equals(languageCode) || "jpn".equals(languageCode)) {
- return jpEosCharacters;
+} else if ("jpn".equals(languageCode)) {
+ return jpnEosCharacters;
}
return defaultEosCharacters;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use ja for Japanese language code rather than jp
>
>
> Key: OPENNLP-1213
> URL: https://issues.apache.org/jira/browse/OPENNLP-1213
> Project: OpenNLP
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Koji Sekiguchi
>Priority: Minor
> Fix For: 1.9.1
>
>
> It seems that Factory of sentdetect uses "jp" for Japanese language code but
> I think it is country code. Let's use "ja" instead.
> We could leave "jp" for back-compat, but I don't think we need to do it. So
> I'll just replace "jp" with "ja" in the patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OPENNLP-1213) Use ja for Japanese language code rather than jp
[
https://issues.apache.org/jira/browse/OPENNLP-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579729#comment-16579729
]
ASF GitHub Bot commented on OPENNLP-1213:
-
kottmann commented on a change in pull request #328: OPENNLP-1213: Use ja for
Japanese language code rather than jp
URL: https://github.com/apache/opennlp/pull/328#discussion_r209928880
##
File path:
opennlp-tools/src/main/java/opennlp/tools/sentdetect/lang/Factory.java
##
@@ -72,8 +72,8 @@ public SDContextGenerator
createSentenceContextGenerator(String languageCode) {
return thEosCharacters;
} else if ("pt".equals(languageCode) || "por".equals(languageCode)) {
return ptEosCharacters;
-} else if ("jp".equals(languageCode) || "jpn".equals(languageCode)) {
- return jpEosCharacters;
+} else if ("ja".equals(languageCode) || "jpn".equals(languageCode)) {
Review comment:
And changing it will break it, so I suggest it would be better to remove it
instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use ja for Japanese language code rather than jp
>
>
> Key: OPENNLP-1213
> URL: https://issues.apache.org/jira/browse/OPENNLP-1213
> Project: OpenNLP
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Koji Sekiguchi
>Priority: Minor
> Fix For: 1.9.1
>
>
> It seems that Factory of sentdetect uses "jp" for Japanese language code but
> I think it is country code. Let's use "ja" instead.
> We could leave "jp" for back-compat, but I don't think we need to do it. So
> I'll just replace "jp" with "ja" in the patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OPENNLP-1213) Use ja for Japanese language code rather than jp
[
https://issues.apache.org/jira/browse/OPENNLP-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579728#comment-16579728
]
ASF GitHub Bot commented on OPENNLP-1213:
-
kottmann commented on a change in pull request #328: OPENNLP-1213: Use ja for
Japanese language code rather than jp
URL: https://github.com/apache/opennlp/pull/328#discussion_r209928880
##
File path:
opennlp-tools/src/main/java/opennlp/tools/sentdetect/lang/Factory.java
##
@@ -72,8 +72,8 @@ public SDContextGenerator
createSentenceContextGenerator(String languageCode) {
return thEosCharacters;
} else if ("pt".equals(languageCode) || "por".equals(languageCode)) {
return ptEosCharacters;
-} else if ("jp".equals(languageCode) || "jpn".equals(languageCode)) {
- return jpEosCharacters;
+} else if ("ja".equals(languageCode) || "jpn".equals(languageCode)) {
Review comment:
And changing it will break it, so I suggest it would be better to remove it
instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use ja for Japanese language code rather than jp
>
>
> Key: OPENNLP-1213
> URL: https://issues.apache.org/jira/browse/OPENNLP-1213
> Project: OpenNLP
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Koji Sekiguchi
>Priority: Minor
> Fix For: 1.9.1
>
>
> It seems that Factory of sentdetect uses "jp" for Japanese language code but
> I think it is country code. Let's use "ja" instead.
> We could leave "jp" for back-compat, but I don't think we need to do it. So
> I'll just replace "jp" with "ja" in the patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OPENNLP-1213) Use ja for Japanese language code rather than jp
[
https://issues.apache.org/jira/browse/OPENNLP-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579727#comment-16579727
]
ASF GitHub Bot commented on OPENNLP-1213:
-
kottmann commented on a change in pull request #328: OPENNLP-1213: Use ja for
Japanese language code rather than jp
URL: https://github.com/apache/opennlp/pull/328#discussion_r209928801
##
File path:
opennlp-tools/src/main/java/opennlp/tools/sentdetect/lang/Factory.java
##
@@ -72,8 +72,8 @@ public SDContextGenerator
createSentenceContextGenerator(String languageCode) {
return thEosCharacters;
} else if ("pt".equals(languageCode) || "por".equals(languageCode)) {
return ptEosCharacters;
-} else if ("jp".equals(languageCode) || "jpn".equals(languageCode)) {
- return jpEosCharacters;
+} else if ("ja".equals(languageCode) || "jpn".equals(languageCode)) {
Review comment:
We have the two letter codes here only for backward compatibility.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use ja for Japanese language code rather than jp
>
>
> Key: OPENNLP-1213
> URL: https://issues.apache.org/jira/browse/OPENNLP-1213
> Project: OpenNLP
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Koji Sekiguchi
>Priority: Minor
> Fix For: 1.9.1
>
>
> It seems that Factory of sentdetect uses "jp" for Japanese language code but
> I think it is country code. Let's use "ja" instead.
> We could leave "jp" for back-compat, but I don't think we need to do it. So
> I'll just replace "jp" with "ja" in the patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OPENNLP-1213) Use ja for Japanese language code rather than jp
[
https://issues.apache.org/jira/browse/OPENNLP-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579730#comment-16579730
]
ASF GitHub Bot commented on OPENNLP-1213:
-
kottmann commented on a change in pull request #328: OPENNLP-1213: Use ja for
Japanese language code rather than jp
URL: https://github.com/apache/opennlp/pull/328#discussion_r209928801
##
File path:
opennlp-tools/src/main/java/opennlp/tools/sentdetect/lang/Factory.java
##
@@ -72,8 +72,8 @@ public SDContextGenerator
createSentenceContextGenerator(String languageCode) {
return thEosCharacters;
} else if ("pt".equals(languageCode) || "por".equals(languageCode)) {
return ptEosCharacters;
-} else if ("jp".equals(languageCode) || "jpn".equals(languageCode)) {
- return jpEosCharacters;
+} else if ("ja".equals(languageCode) || "jpn".equals(languageCode)) {
Review comment:
We have the two letter codes here only for backward compatibility and
changing it will break it.
I suggest we remove the two letter code for Japanese.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use ja for Japanese language code rather than jp
>
>
> Key: OPENNLP-1213
> URL: https://issues.apache.org/jira/browse/OPENNLP-1213
> Project: OpenNLP
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Koji Sekiguchi
>Priority: Minor
> Fix For: 1.9.1
>
>
> It seems that Factory of sentdetect uses "jp" for Japanese language code but
> I think it is country code. Let's use "ja" instead.
> We could leave "jp" for back-compat, but I don't think we need to do it. So
> I'll just replace "jp" with "ja" in the patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OPENNLP-1213) Use ja for Japanese language code rather than jp
[
https://issues.apache.org/jira/browse/OPENNLP-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579723#comment-16579723
]
ASF GitHub Bot commented on OPENNLP-1213:
-
kottmann commented on a change in pull request #328: OPENNLP-1213: Use ja for
Japanese language code rather than jp
URL: https://github.com/apache/opennlp/pull/328#discussion_r209928557
##
File path:
opennlp-tools/src/main/java/opennlp/tools/sentdetect/lang/Factory.java
##
@@ -35,7 +35,7 @@
public static final char[] thEosCharacters = new char[] { ' ','\n' };
- public static final char[] jpEosCharacters = new char[] {'。', '！', '？'};
+ public static final char[] jaEosCharacters = new char[] {'。', '！', '？'};
Review comment:
Would be better to use the three letter codes in the variable name. It was
decided to drop two letter codes from OpenNLP.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use ja for Japanese language code rather than jp
>
>
> Key: OPENNLP-1213
> URL: https://issues.apache.org/jira/browse/OPENNLP-1213
> Project: OpenNLP
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Koji Sekiguchi
>Priority: Minor
> Fix For: 1.9.1
>
>
> It seems that Factory of sentdetect uses "jp" for Japanese language code but
> I think it is country code. Let's use "ja" instead.
> We could leave "jp" for back-compat, but I don't think we need to do it. So
> I'll just replace "jp" with "ja" in the patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OPENNLP-1213) Use ja for Japanese language code rather than jp
[ https://issues.apache.org/jira/browse/OPENNLP-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579183#comment-16579183 ] ASF GitHub Bot commented on OPENNLP-1213: - kojisekig opened a new pull request #328: OPENNLP-1213: Use ja for Japanese language code rather than jp URL: https://github.com/apache/opennlp/pull/328 Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with OPENNLP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use ja for Japanese language code rather than jp > > > Key: OPENNLP-1213 > URL: https://issues.apache.org/jira/browse/OPENNLP-1213 > Project: OpenNLP > Issue Type: Bug >Affects Versions: 1.9.0 >Reporter: Koji Sekiguchi >Priority: Minor > Fix For: 1.9.1 > > > It seems that Factory of sentdetect uses "jp" for Japanese language code but > I think it is country code. Let's use "ja" instead. > We could leave "jp" for back-compat, but I don't think we need to do it. So > I'll just replace "jp" with "ja" in the patch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
