[GitHub] rabbah commented on issue #3671: Activation id in header

[GitBox]

rabbah commented on issue #3671: Activation id in header
URL: 
https://github.com/apache/incubator-openwhisk/pull/3671#issuecomment-392007532
 
 
   For the first parts:
   
   For a trigger, the request id is the triggers activation id. Every activated 
action generates a new activation id as we do today. 
   
   For a sequence the outermost action (the sequence itself) gets the id all 
the subcomponents get new ids (as today). 
   
   Same for conductor actions.
   
   The uniqueness is the part I’m concerned about. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

rabbah commented on issue #3705: Revert "Add ASF license to optional XML files 
and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392015966
 
 
   @cbickel can you explain the reason for reverting - ie how are the 
comment/license headers an issue? Thanks. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] style95 commented on a change in pull request #3671: Activation id in header

[GitBox]

style95 commented on a change in pull request #3671: Activation id in header
URL: 
https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r190836887
 
 

 ##
 File path: core/controller/src/main/scala/whisk/core/controller/Entities.scala
 ##
 @@ -65,14 +65,25 @@ protected[controller] trait ValidateRequestSize extends 
Directives {
   protected val fieldDescriptionForSizeError = "Request"
 }
 
+protected trait CustomHeaders extends Directives {
+
+  /** Add activation ID in headers */
+  protected def respondWithActivationIdHeader(activation: WhiskActivation): 
Directive0 =
 
 Review comment:
   Updated accordingly


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mhenke1 commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

mhenke1 commented on issue #3705: Revert "Add ASF license to optional XML files 
and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392050223
 
 
   https://stackoverflow.com/a/1196485


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3704: Provide invoker maintenance mode

[GitBox]

rabbah commented on issue #3704: Provide invoker maintenance mode
URL: 
https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-392049947
 
 
   +1 @chetanmeh 
   
   The administrative interfaces should have authentication in place. While at 
it, we should apply the same to the `/invokers` route in the controller perhaps.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

rabbah commented on issue #3705: Revert "Add ASF license to optional XML files 
and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392049524
 
 
   did you try having  `` as the first 
line and comment for license to follow --- just a guess.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jeremiaswerner closed pull request #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

jeremiaswerner closed pull request #3705: Revert "Add ASF license to optional 
XML files and last gradle file."
URL: https://github.com/apache/incubator-openwhisk/pull/3705
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah closed pull request #3502: Immutable attachments via putAndAttach

[GitBox]

rabbah closed pull request #3502: Immutable attachments via putAndAttach
URL: https://github.com/apache/incubator-openwhisk/pull/3502
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala 
b/common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala
index 631f60ad1c..3750398939 100644
--- a/common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala
+++ b/common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala
@@ -26,6 +26,7 @@ import akka.util.ByteString
 import spray.json.JsObject
 import whisk.common.Logging
 import whisk.common.TransactionId
+import whisk.core.entity.Attachments.Attached
 import whisk.core.entity.DocInfo
 
 abstract class StaleParameter(val value: Option[String])
@@ -69,16 +70,18 @@ trait ArtifactStore[DocumentAbstraction] {
* If the operation is successful, the future completes with the requested 
document if it exists.
*
* @param doc the document info for the record to get (must contain valid id 
and rev)
+   * @param attachmentHandler function to update the attachment details in 
document
* @param transid the transaction id for logging
* @param ma manifest for A to determine its runtime type, required by some 
db APIs
* @return a future that completes either with DocumentAbstraction if the 
document exists and is deserializable into desired type
*/
-  protected[database] def get[A <: DocumentAbstraction](doc: DocInfo)(implicit 
transid: TransactionId,
-  ma: 
Manifest[A]): Future[A]
+  protected[database] def get[A <: DocumentAbstraction](
+doc: DocInfo,
+attachmentHandler: Option[(A, Attached) => A] = None)(implicit transid: 
TransactionId, ma: Manifest[A]): Future[A]
 
   /**
* Gets all documents from database view that match a start key, up to an 
end key, using a future.
-   * If the operation is successful, the promise completes with List[View]] 
with zero or more documents.
+   * If the operation is successful, the promise completes with List[View] 
with zero or more documents.
*
* @param table the name of the table to query
* @param startKey to starting key to query the view for
@@ -119,9 +122,17 @@ trait ArtifactStore[DocumentAbstraction] {
 
   /**
* Attaches a "file" of type `contentType` to an existing document. The 
revision for the document must be set.
+   *
+   * @param update - function to transform the document with new attachment 
details
+   * @param oldAttachment Optional old document instance for the update 
scenario. It would be used to determine
+   *  the existing attachment details.
*/
-  protected[core] def attach(doc: DocInfo, name: String, contentType: 
ContentType, docStream: Source[ByteString, _])(
-implicit transid: TransactionId): Future[DocInfo]
+  protected[database] def putAndAttach[A <: DocumentAbstraction](
+d: A,
+update: (A, Attached) => A,
+contentType: ContentType,
+docStream: Source[ByteString, _],
+oldAttachment: Option[Attached])(implicit transid: TransactionId): 
Future[(DocInfo, Attached)]
 
   /**
* Retrieves a saved attachment, streaming it into the provided Sink.
diff --git 
a/common/scala/src/main/scala/whisk/core/database/CouchDbRestStore.scala 
b/common/scala/src/main/scala/whisk/core/database/CouchDbRestStore.scala
index 0d97077a25..ffa2aafe26 100644
--- a/common/scala/src/main/scala/whisk/core/database/CouchDbRestStore.scala
+++ b/common/scala/src/main/scala/whisk/core/database/CouchDbRestStore.scala
@@ -28,11 +28,13 @@ import akka.stream.scaladsl._
 import akka.util.ByteString
 import spray.json._
 import whisk.common.{Logging, LoggingMarkers, MetricEmitter, TransactionId}
+import whisk.core.entity.Attachments.Attached
 import whisk.core.database.StoreUtils._
 import whisk.core.entity.BulkEntityResult
 import whisk.core.entity.DocInfo
-import whisk.http.Messages
 import whisk.core.entity.DocumentReader
+import whisk.core.entity.UUID
+import whisk.http.Messages
 
 /**
  * Basic client to put and delete artifacts in a data store.
@@ -62,6 +64,7 @@ class CouchDbRestStore[DocumentAbstraction <: 
DocumentSerializer](dbProtocol: St
 
   protected[core] implicit val executionContext = system.dispatcher
 
+  private val attachmentScheme = "couch"
   private val client: CouchDbRestClient =
 new CouchDbRestClient(dbProtocol, dbHost, dbPort.toInt, dbUsername, 
dbPassword, dbName)
 
@@ -207,8 +210,10 @@ class CouchDbRestStore[DocumentAbstraction <: 
DocumentSerializer](dbProtocol: St
   ErrorLevel))
   }
 
-  override protected[database] def get[A <: DocumentAbstraction](doc: 
DocInfo)(implicit transid: TransactionId,
- 

[GitHub] vvraskin commented on issue #3706: Limit cipher suites used for controller https

[GitBox]

vvraskin commented on issue #3706: Limit cipher suites used for controller https
URL: 
https://github.com/apache/incubator-openwhisk/pull/3706#issuecomment-392043561
 
 
   PG3 2297 is on its way


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jthomas commented on issue #118: add User-Agent to request header

[GitBox]

jthomas commented on issue #118: add User-Agent to request header
URL: 
https://github.com/apache/incubator-openwhisk-client-js/pull/118#issuecomment-391981750
 
 
   :+1:
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cbickel opened a new pull request #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

cbickel opened a new pull request #3705: Revert "Add ASF license to optional 
XML files and last gradle file."
URL: https://github.com/apache/incubator-openwhisk/pull/3705
 
 
   Reverts apache/incubator-openwhisk#3702


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vvraskin commented on issue #3706: Limit cipher suites used for controller https

[GitBox]

vvraskin commented on issue #3706: Limit cipher suites used for controller https
URL: 
https://github.com/apache/incubator-openwhisk/pull/3706#issuecomment-392043561
 
 
   PG3 2297 is on its way


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jthomas closed issue #117: add User-Agent to request header

[GitBox]

jthomas closed issue #117: add User-Agent to request header
URL: https://github.com/apache/incubator-openwhisk-client-js/issues/117
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jthomas closed pull request #118: add User-Agent to request header

[GitBox]

jthomas closed pull request #118: add User-Agent to request header
URL: https://github.com/apache/incubator-openwhisk-client-js/pull/118
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index cdaa050..74df04e 100644
--- a/README.md
+++ b/README.md
@@ -90,7 +90,20 @@ Client constructor will read values for the `apihost`, 
`namespace`, `api_key`, `
 - *__OW_APIGW_TOKEN*
 - *__OW_APIGW_SPACE_SUID*
 
+### User-Agent
 
+A User-Agent header may be specified to be passed along with all calls
+to OpenWhisk. This can be helpful, if you wish to discriminate client
+traffic to your OpenWhisk backend. By default, the header will have
+the value `openwhisk-client-js`. You may override this by passing
+along a `'User-Agent'` field in the options structure of any API
+calls; note that this is *not* a constructor argument, but rather an
+option to the API calls themselves. For example, one might specify a
+`myClient` user agent to an action invocation as follows:
+
+```javascript
+ow.actions.invoke({ 'User-Agent': 'myClient', name, params })
+```
 
 ## Examples
 
diff --git a/lib/client.js b/lib/client.js
index 900173c..48723e3 100644
--- a/lib/client.js
+++ b/lib/client.js
@@ -124,6 +124,7 @@ class Client {
   url: this.pathUrl(path),
   rejectUnauthorized: !this.options.ignoreCerts,
   headers: {
+'User-Agent': (options && options['User-Agent']) || 
'openwhisk-client-js',
 Authorization: this.authHeader()
   }
 }, options)
diff --git a/test/unit/actions.test.js b/test/unit/actions.test.js
index 8d3140f..c3a6455 100644
--- a/test/unit/actions.test.js
+++ b/test/unit/actions.test.js
@@ -429,3 +429,18 @@ test('create a new action with version parameter', t => {
 
   return actions.create({name: '12345', action, version})
 })
+
+test('should pass through requested User-Agent header', t => {
+  t.plan(1)
+  const userAgent = 'userAgentShouldPassThroughPlease'
+  const client = {}
+  const actions = new Actions(client)
+  const action = 'function main() { // main function body};'
+  const version = '1.0.0'
+
+  client.request = (method, path, options) => {
+t.is(options['User-Agent'], userAgent)
+  }
+
+  return actions.create({name: '12345', action, version, 'User-Agent': 
userAgent})
+})


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392022657
 
 
   That’s odd how come adding comments at the top of an xml brakes 
functionality?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392022849
 
 
   What’s the root cause? How do we fix instead of doing a drastic revert with 
no other options being proposed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sven-lange-last commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

sven-lange-last commented on issue #3705: Revert "Add ASF license to optional 
XML files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392049152
 
 
   This is the exception occurring with the XML comment:
   
   ```
   Failed to auto configure default logger context
   Reported exception:
   ch.qos.logback.core.joran.spi.JoranException: Problem parsing XML document. 
See previously reported errors.
   at 
ch.qos.logback.core.joran.event.SaxEventRecorder.recordEvents(SaxEventRecorder.java:65)
   at 
ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:151)
   at 
ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:110)
   at 
ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:53)
   at 
ch.qos.logback.classic.util.ContextInitializer.configureByResource(ContextInitializer.java:75)
   at 
ch.qos.logback.classic.util.ContextInitializer.autoConfig(ContextInitializer.java:150)
   at org.slf4j.impl.StaticLoggerBinder.init(StaticLoggerBinder.java:84)
   at org.slf4j.impl.StaticLoggerBinder.(StaticLoggerBinder.java:55)
   at org.slf4j.LoggerFactory.bind(LoggerFactory.java:150)
   at org.slf4j.LoggerFactory.performInitialization(LoggerFactory.java:124)
   at org.slf4j.LoggerFactory.getILoggerFactory(LoggerFactory.java:412)
   at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:357)
   at kamon.util.logger.LazyLogger$.apply(LazyLogger.scala:46)
   at kamon.util.logger.LazyLogger$.apply(LazyLogger.scala:47)
   at kamon.Kamon$Instance.(Kamon.scala:50)
   at kamon.Kamon$.(Kamon.scala:30)
   at kamon.Kamon$.(Kamon.scala)
   at whisk.core.controller.Controller$.main(Controller.scala:188)
   at whisk.core.controller.Controller.main(Controller.scala)
   Caused by: org.xml.sax.SAXParseException; systemId: 
jar:file:/controller/lib/openwhisk-common.jar!/logback.xml; lineNumber: 5; 
columnNumber: 6; The processing instruction target matching "[xX][mM][lL]" is 
not allowed.
   at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1239)
   at 
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:643)
   at 
com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(SAXParserImpl.java:327)
   at 
ch.qos.logback.core.joran.event.SaxEventRecorder.recordEvents(SaxEventRecorder.java:59)
   ... 18 more
   00:01:20,741 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Could 
NOT find resource [logback-test.xml]
   00:01:20,741 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Could 
NOT find resource [logback.groovy]
   00:01:20,741 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Found 
resource [logback.xml] at 
[jar:file:/controller/lib/openwhisk-common.jar!/logback.xml]
   00:01:20,769 |-INFO in 
ch.qos.logback.core.joran.spi.ConfigurationWatchList@3fb1549b - URL 
[jar:file:/controller/lib/openwhisk-common.jar!/logback.xml] is not of type file
   00:01:20,836 |-ERROR in 
ch.qos.logback.core.joran.event.SaxEventRecorder@ea6147e - XML_PARSING - 
Parsing fatal error on line 5 and column 6
   00:01:20,836 |-ERROR in 
ch.qos.logback.core.joran.event.SaxEventRecorder@ea6147e - 
org.xml.sax.SAXParseException; systemId: 
jar:file:/controller/lib/openwhisk-common.jar!/logback.xml; lineNumber: 5; 
columnNumber: 6; The processing instruction target matching "[xX][mM][lL]" is 
not allowed.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] style95 commented on a change in pull request #3671: Activation id in header

[GitBox]

style95 commented on a change in pull request #3671: Activation id in header
URL: 
https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r190837409
 
 

 ##
 File path: 
tests/src/test/scala/whisk/core/controller/test/ControllerTestCommon.scala
 ##
 @@ -91,6 +91,8 @@ protected trait ControllerTestCommon
   val authStore = WhiskAuthStore.datastore()
   val logStore = SpiLoader.get[LogStoreProvider].logStore(actorSystem)
 
+  val ActivationIdHeaderInLowercase = "x-openwhisk-activation-id"
 
 Review comment:
   Updated accordingly.
   
   Regarding case, I followed scala constant naming convention(Upper camel 
case).
   Is it OW convention(start with a lowercase letter)?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3671: Activation id in header

[GitBox]

codecov-io commented on issue #3671: Activation id in header
URL: 
https://github.com/apache/incubator-openwhisk/pull/3671#issuecomment-392002725
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3671?src=pr=h1)
 Report
   > Merging 
[#3671](https://codecov.io/gh/apache/incubator-openwhisk/pull/3671?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/2cc22272635d23e4e94dd739fbca71f354043c42?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `92.85%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3671/graphs/tree.svg?height=150=650=l0YmsiSAso=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3671?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3671  +/-   ##
   ==
   + Coverage74.5%   74.53%   +0.02% 
   ==
 Files 126  126  
 Lines5994 6001   +7 
 Branches  392  378  -14 
   ==
   + Hits 4466 4473   +7 
 Misses   1528 1528
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3671?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...rc/main/scala/whisk/core/controller/Entities.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3671/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9FbnRpdGllcy5zY2FsYQ==)
 | `93.54% <100%> (+0.44%)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/controller/Triggers.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3671/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9UcmlnZ2Vycy5zY2FsYQ==)
 | `80.85% <100%> (+0.13%)` | :arrow_up: |
   | 
[...src/main/scala/whisk/core/controller/Actions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3671/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9BY3Rpb25zLnNjYWxh)
 | `91.37% <90%> (+0.08%)` | :arrow_up: |
   | 
[.../main/scala/whisk/core/controller/WebActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3671/diff?src=pr=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9XZWJBY3Rpb25zLnNjYWxh)
 | `88.62% <92.85%> (+0.08%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3671?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3671?src=pr=footer).
 Last update 
[2cc2227...ae4f98f](https://codecov.io/gh/apache/incubator-openwhisk/pull/3671?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cbickel commented on issue #3671: Activation id in header

[GitBox]

cbickel commented on issue #3671: Activation id in header
URL: 
https://github.com/apache/incubator-openwhisk/pull/3671#issuecomment-392002543
 
 
   @rabbah @ddragosd 
   I also thought about making tid and activationid the same, but I see the 
following problems:
   - If a trigger is invoked, you have a trigger activation and several action 
activations. Which of these activations should get the tid as activation id
   - Same for sequences. Which of the actions should get the tid as 
activation-id.
   - One of the ideas of sending the tid to the controller, was to generate the 
tid in one of the providers and pass it with the request. With this ability you 
would be able to trace a request from end to end. But this also adds the risk, 
that it could not be unique anymore.
   
   But maybe there is an easy solution for all of these concerns ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cmonkey commented on issue #3590: Collect test reports as part of log collection

[GitBox]

cmonkey commented on issue #3590: Collect test reports as part of log collection
URL: 
https://github.com/apache/incubator-openwhisk/pull/3590#issuecomment-391949397
 
 
   b!不b  c But  t e   a a.   .
   Ya jajtjj t.   T
   W
   Carlos Santana  于 2018年5月3日周四 05:36写道：
   
   > *@csantanapr* requested changes on this pull request.
   >
   > Can  j.This t-shirts.  Mu.   T.   Awe make controllable with a ansible
   > variable? it opt in, maybe defining a variable in top group vars that can
   > be overridden by a specific environment
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cbickel commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

cbickel commented on issue #3705: Revert "Add ASF license to optional XML files 
and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392017818
 
 
   @rabbah Sorry, I updated the description.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3698: Make amount of parallel docker runs configurable.

[GitBox]

codecov-io commented on issue #3698: Make amount of parallel docker runs 
configurable.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3698#issuecomment-392048718
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3698?src=pr=h1)
 Report
   > Merging 
[#3698](https://codecov.io/gh/apache/incubator-openwhisk/pull/3698?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b3923300638d64b375d8b79dbc268e0ae50a6bf8?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3698/graphs/tree.svg?token=l0YmsiSAso=pr=150=650)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3698?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3698  +/-   ##
   ==
   + Coverage   75.01%   75.01%   +<.01% 
   ==
 Files 126  126  
 Lines6023 6024   +1 
 Branches  385  389   +4 
   ==
   + Hits 4518 4519   +1 
 Misses   1505 1505
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3698?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...whisk/core/containerpool/docker/DockerClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3698/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ2xpZW50LnNjYWxh)
 | `95.74% <100%> (ø)` | :arrow_up: |
   | 
[.../scala/src/main/scala/whisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3698/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=)
 | `92.3% <100%> (+0.05%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3698?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3698?src=pr=footer).
 Last update 
[b392330...3a05c19](https://codecov.io/gh/apache/incubator-openwhisk/pull/3698?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

codecov-io commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392021825
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3705?src=pr=h1)
 Report
   > Merging 
[#3705](https://codecov.io/gh/apache/incubator-openwhisk/pull/3705?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/2cc22272635d23e4e94dd739fbca71f354043c42?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3705/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3705?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #3705   +/-   ##
   ==
 Coverage74.5%   74.5%   
   ==
 Files 126 126   
 Lines59945994   
 Branches  392 392   
   ==
 Hits 44664466   
 Misses   15281528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3705?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3705?src=pr=footer).
 Last update 
[2cc2227...582d576](https://codecov.io/gh/apache/incubator-openwhisk/pull/3705?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392023366
 
 
   For the most part all files should have an ASF header, if someone can 
proposed how can we get the xml files with the header or state why logging 
brakes and there is no workaround and we are forced to excempt the files with 
explanation from having the ASF license header


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

rabbah commented on issue #3705: Revert "Add ASF license to optional XML files 
and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392049524
 
 
   did you try having  `` as the first 
line --- just a guess.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on a change in pull request #3707: enable concurrent runs on ActionContainer test utility

[GitBox]

rabbah commented on a change in pull request #3707: enable concurrent runs on 
ActionContainer test utility 
URL: 
https://github.com/apache/incubator-openwhisk/pull/3707#discussion_r190926261
 
 

 ##
 File path: common/scala/src/main/scala/whisk/core/containerpool/HttpUtils.scala
 ##
 @@ -76,11 +83,12 @@ protected[core] class HttpUtils(hostname: String, timeout: 
FiniteDuration, maxRe
 request.addHeader(HttpHeaders.ACCEPT, "application/json")
 request.setEntity(entity)
 
-execute(request, timeout.toMillis.toInt, retry)
+execute(request, timeout.toMillis.toInt, maxConcurrent, retry)
   }
 
   private def execute(request: HttpRequestBase,
   timeoutMsec: Integer,
+  maxConcurrent: Int,
 
 Review comment:
   how is `maxConcurrent` used in `execute`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] chetanmeh commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

chetanmeh commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392106682
 
 
   What @rabbah mentioned should work as we use similar approach at 
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-run/src/main/resources/logback.xml


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tysonnorris opened a new pull request #3707: enable concurrent runs on ActionContainer test utility

[GitBox]

tysonnorris opened a new pull request #3707: enable concurrent runs on 
ActionContainer test utility 
URL: https://github.com/apache/incubator-openwhisk/pull/3707
 
 
   support for tests in 
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41
   
   
   
   
   ## Description
   
   
   Enable ActionContainer test execute concurrent /run requests on containers, 
to support testing containers that enable concurrency activation processing. 
   
   ## Related issue and scope
   
   - [ ] I opened an issue to propose and discuss this change (#)
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [x] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [x] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new pull request #42: Update repo. files to latest ASF license scanning standards to match OW project policies

[GitBox]

mrutkows opened a new pull request #42: Update repo. files to latest ASF 
license scanning standards to match OW project policies
URL: https://github.com/apache/incubator-openwhisk-utilities/pull/42
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #41: remove use of state in nodejs app

[GitBox]

rabbah commented on issue #41: remove use of state in nodejs app
URL: 
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#issuecomment-392063629
 
 
   Yes. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mhenke1 commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

mhenke1 commented on issue #3705: Revert "Add ASF license to optional XML files 
and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392050223
 
 
   ^^^That is the definitive solution
   https://stackoverflow.com/a/1196485


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] brunogirin opened a new issue #940: API section doesn't support path parameters

[GitBox]

brunogirin opened a new issue #940: API section doesn't support path parameters
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/940
 
 
   When deploying a manifest that includes an API endpoint with path 
parameters, `wskdeploy` throws an error saying that the response shoud use type 
'.http' to receive path parameters.
   
   ## Manifest
   
   See the attached manifest file. The error occurs both with POST and PUT.
   
   
[manifest.zip](https://github.com/apache/incubator-openwhisk-wskdeploy/files/2039876/manifest.zip)
   
   ## Error
   
   ```
   Error: Deployment did not complete sucessfully. Run `wskdeploy undeploy` to 
remove partially deployed assets.
   Error: servicedeployer.go [1625]: [ERROR_WHISK_CLIENT_ERROR]: Error code: 
246: API creation failure: The action must use a response type of '.http' in 
order to receive the path parameters.: HTTP Response Status: 502 Bad Gateway 
HTTP Response Body: {"error":"API creation failure: The action must use a 
response type of '.http' in order to receive the path parameters."}
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tysonnorris commented on a change in pull request #3707: enable concurrent runs on ActionContainer test utility

[GitBox]

tysonnorris commented on a change in pull request #3707: enable concurrent runs 
on ActionContainer test utility 
URL: 
https://github.com/apache/incubator-openwhisk/pull/3707#discussion_r190930105
 
 

 ##
 File path: common/scala/src/main/scala/whisk/core/containerpool/HttpUtils.scala
 ##
 @@ -76,11 +83,12 @@ protected[core] class HttpUtils(hostname: String, timeout: 
FiniteDuration, maxRe
 request.addHeader(HttpHeaders.ACCEPT, "application/json")
 request.setEntity(entity)
 
-execute(request, timeout.toMillis.toInt, retry)
+execute(request, timeout.toMillis.toInt, maxConcurrent, retry)
   }
 
   private def execute(request: HttpRequestBase,
   timeoutMsec: Integer,
+  maxConcurrent: Int,
 
 Review comment:
   hmm right. must have been left over from some previous iteration. removed it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3680: Adjust invoker playbook to pull blackbox docker images when a prefix is specified.

[GitBox]

codecov-io commented on issue #3680: Adjust invoker playbook to pull blackbox 
docker images when a prefix is specified.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3680#issuecomment-390292471
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=h1)
 Report
   > Merging 
[#3680](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b3923300638d64b375d8b79dbc268e0ae50a6bf8?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `75%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3680  +/-   ##
   ==
   + Coverage   75.01%   75.02%   +<.01% 
   ==
 Files 126  126  
 Lines6023 6021   -2 
 Branches  385  392   +7 
   ==
   - Hits 4518 4517   -1 
   + Misses   1505 1504   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh)
 | `62.96% <100%> (+1.14%)` | :arrow_up: |
   | 
[.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==)
 | `27.58% <100%> (+0.91%)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `93.58% <80%> (-2.52%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=footer).
 Last update 
[b392330...9f51886](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3699: Add gatling-throughput test for cold invocations.

[GitBox]

codecov-io commented on issue #3699: Add gatling-throughput test for cold 
invocations.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3699#issuecomment-391705629
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=h1)
 Report
   > Merging 
[#3699](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b3923300638d64b375d8b79dbc268e0ae50a6bf8?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3699   +/-   ##
   ===
 Coverage   75.01%   75.01%   
   ===
 Files 126  126   
 Lines6023 6023   
 Branches  385  385   
   ===
 Hits 4518 4518   
 Misses   1505 1505
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=footer).
 Last update 
[b392330...93a1b2d](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tysonnorris commented on issue #3507: allow use of string for controller id

[GitBox]

tysonnorris commented on issue #3507: allow use of string for controller id
URL: 
https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-392098039
 
 
   @cbickel @rabbah @dubee any comments on this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3680: Adjust invoker playbook to pull blackbox docker images when a prefix is specified.

[GitBox]

codecov-io commented on issue #3680: Adjust invoker playbook to pull blackbox 
docker images when a prefix is specified.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3680#issuecomment-390292471
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=h1)
 Report
   > Merging 
[#3680](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b3923300638d64b375d8b79dbc268e0ae50a6bf8?src=pr=desc)
 will **increase** coverage by `0.04%`.
   > The diff coverage is `87.5%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3680  +/-   ##
   ==
   + Coverage   75.01%   75.05%   +0.04% 
   ==
 Files 126  126  
 Lines6023 6021   -2 
 Branches  385  392   +7 
   ==
   + Hits 4518 4519   +1 
   + Misses   1505 1502   -3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `96.15% <100%> (+0.04%)` | :arrow_up: |
   | 
[.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==)
 | `27.58% <100%> (+0.91%)` | :arrow_up: |
   | 
[...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh)
 | `62.96% <100%> (+1.14%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=footer).
 Last update 
[b392330...6261407](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3708: Single build.gradle file missing ASF license header

[GitBox]

codecov-io commented on issue #3708: Single build.gradle file missing ASF 
license header
URL: 
https://github.com/apache/incubator-openwhisk/pull/3708#issuecomment-392096299
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3708?src=pr=h1)
 Report
   > Merging 
[#3708](https://codecov.io/gh/apache/incubator-openwhisk/pull/3708?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b3923300638d64b375d8b79dbc268e0ae50a6bf8?src=pr=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3708/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3708?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3708  +/-   ##
   ==
   - Coverage   75.01%   74.99%   -0.02% 
   ==
 Files 126  126  
 Lines6023 6023  
 Branches  385  385  
   ==
   - Hits 4518 4517   -1 
   - Misses   1505 1506   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3708?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...rc/main/scala/whisk/common/ForcableSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3708/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjYWJsZVNlbWFwaG9yZS5zY2FsYQ==)
 | `84.61% <0%> (-3.85%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3708?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3708?src=pr=footer).
 Last update 
[b392330...ebd2be6](https://codecov.io/gh/apache/incubator-openwhisk/pull/3708?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3680: Adjust invoker playbook to pull blackbox docker images when a prefix is specified.

[GitBox]

codecov-io commented on issue #3680: Adjust invoker playbook to pull blackbox 
docker images when a prefix is specified.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3680#issuecomment-390292471
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=h1)
 Report
   > Merging 
[#3680](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b3923300638d64b375d8b79dbc268e0ae50a6bf8?src=pr=desc)
 will **increase** coverage by `0.04%`.
   > The diff coverage is `87.5%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3680  +/-   ##
   ==
   + Coverage   75.01%   75.05%   +0.04% 
   ==
 Files 126  126  
 Lines6023 6021   -2 
 Branches  385  392   +7 
   ==
   + Hits 4518 4519   +1 
   + Misses   1505 1502   -3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==)
 | `27.58% <100%> (+0.91%)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `96.15% <100%> (+0.04%)` | :arrow_up: |
   | 
[...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh)
 | `62.96% <100%> (+1.14%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=footer).
 Last update 
[b392330...9f51886](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3699: Add gatling-throughput test for cold invocations.

[GitBox]

codecov-io commented on issue #3699: Add gatling-throughput test for cold 
invocations.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3699#issuecomment-391705629
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=h1)
 Report
   > Merging 
[#3699](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b3923300638d64b375d8b79dbc268e0ae50a6bf8?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699/graphs/tree.svg?token=l0YmsiSAso=pr=150=650)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3699   +/-   ##
   ===
 Coverage   75.01%   75.01%   
   ===
 Files 126  126   
 Lines6023 6023   
 Branches  385  385   
   ===
 Hits 4518 4518   
 Misses   1505 1505
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=footer).
 Last update 
[b392330...93a1b2d](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows closed pull request #941: commenting out TestExportHelloWorld as its unstable in Travis

[GitBox]

mrutkows closed pull request #941: commenting out TestExportHelloWorld as its 
unstable in Travis
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/941
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tests/src/integration/export/export_test.go 
b/tests/src/integration/export/export_test.go
index c976ff61..753dcb15 100644
--- a/tests/src/integration/export/export_test.go
+++ b/tests/src/integration/export/export_test.go
@@ -21,15 +21,27 @@ package tests
 
 import (
"fmt"
+   "math/rand"
"os"
+   "strconv"
"testing"
 

"github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/common"
"github.com/stretchr/testify/assert"
 )
 
+const EXPORT_TEST_PATH = 
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/"
+
 func TestExport(t *testing.T) {
projectName := "EXT_PROJECT"
+
+   manifestLib1Path := os.Getenv("GOPATH") + EXPORT_TEST_PATH + 
"manifest_lib1.yaml"
+   manifestLib2Path := os.Getenv("GOPATH") + EXPORT_TEST_PATH + 
"manifest_lib2.yaml"
+   manifestExtPath := os.Getenv("GOPATH") + EXPORT_TEST_PATH + 
"manifest_ext.yaml"
+
+   targetManifestFolder := os.Getenv("GOPATH") + EXPORT_TEST_PATH + "tmp-" 
+ strconv.Itoa(rand.Intn(1000)) + "/"
+   targetManifestPath := targetManifestFolder + "manifest-" + projectName 
+ ".yaml"
+
wskdeploy := common.NewWskdeploy()
 
_, err := wskdeploy.ManagedDeploymentOnlyManifest(manifestLib1Path)
@@ -63,8 +75,12 @@ func TestExport(t *testing.T) {
assert.Equal(t, nil, err, "Failed to undeploy the lib2.")
 }
 
-func TestExportHelloWorld(t *testing.T) {
+func SkipTestExportHelloWorld(t *testing.T) {
projectName := "HELLO_WORLD"
+   manifestHelloWorldPath := os.Getenv("GOPATH") + EXPORT_TEST_PATH + 
"manifest_helloworld.yaml"
+   targetManifestFolder := os.Getenv("GOPATH") + EXPORT_TEST_PATH + "tmp-" 
+ strconv.Itoa(rand.Intn(1000)) + "/"
+   targetManifestHelloWorldPath := targetManifestFolder + "manifest-" + 
projectName + ".yaml"
+
wskdeploy := common.NewWskdeploy()
 
_, err := 
wskdeploy.ManagedDeploymentManifestAndProject(manifestHelloWorldPath, 
projectName)
@@ -95,6 +111,9 @@ func TestExportHelloWorld(t *testing.T) {
 }
 
 func TestExport2Pack(t *testing.T) {
+   manifest2PackPath := os.Getenv("GOPATH") + EXPORT_TEST_PATH + 
"manifest_2pack.yaml"
+   targetManifestFolder := os.Getenv("GOPATH") + EXPORT_TEST_PATH + "tmp-" 
+ strconv.Itoa(rand.Intn(1000)) + "/"
+   target2PackManifestPath := targetManifestFolder + 
"exported2packmanifest.yaml"
projectName := "2pack"
wskdeploy := common.NewWskdeploy()
 
@@ -113,20 +132,6 @@ func TestExport2Pack(t *testing.T) {
_, err = os.Stat(targetManifestFolder + "package_2/pack2_greeting2.js")
assert.Equal(t, nil, err, "Missing exported 
package_2/pack2_greeting2.js")
 
-   _, err = wskdeploy.UndeployManifestPathOnly(target2PackManifestPath)
+   _, err = wskdeploy.UndeployManifestPathOnly(manifest2PackPath)
assert.Equal(t, nil, err, "Failed to undeploy")
 }
-
-var (
-   manifestLib1Path = os.Getenv("GOPATH") + 
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/manifest_lib1.yaml"
-   manifestLib2Path = os.Getenv("GOPATH") + 
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/manifest_lib2.yaml"
-   manifestExtPath  = os.Getenv("GOPATH") + 
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/manifest_ext.yaml"
-
-   targetManifestFolder = os.Getenv("GOPATH") + 
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/tmp/"
-   targetManifestPath   = targetManifestFolder + "manifest.yaml"
-
-   manifestHelloWorldPath   = os.Getenv("GOPATH") + 
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/manifest_helloworld.yaml"
-   targetManifestHelloWorldPath = targetManifestFolder + "manifest.yaml"
-   manifest2PackPath= os.Getenv("GOPATH") + 
"/src/github.com/apache/incubator-openwhisk-wskdeploy/tests/src/integration/export/manifest_2pack.yaml"
-   target2PackManifestPath  = targetManifestFolder + 
"exported2packmanifest.yaml"
-)


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mhamann commented on issue #304: API Gateway Path Parameters For Query Params?

[GitBox]

mhamann commented on issue #304: API Gateway Path Parameters For Query Params?
URL: 
https://github.com/apache/incubator-openwhisk-apigateway/issues/304#issuecomment-392163031
 
 
   Query parameters are, by definition, not required. I have yet to come across 
a well-designed API that required query params.
   
   In my opinion, this would be solving the problem in the wrong way.
   
   Per your example, why not:
   ```
   /{id}/name/{myname}/age/{myage}
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rabbah commented on issue #304: API Gateway Path Parameters For Query Params?

[GitBox]

rabbah commented on issue #304: API Gateway Path Parameters For Query Params?
URL: 
https://github.com/apache/incubator-openwhisk-apigateway/issues/304#issuecomment-392166750
 
 
   Per the URI RFC https://tools.ietf.org/html/rfc3986#section-3.4 query 
parameters contain non-hierarchical parameters.
   
   Should the API GW enforce a style of API design that eschews query 
parameters?
   
   Further if developers are migrating existing APIs which may not be well 
designed should they be excluded?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3703: Add the license and notice for ConcurrentMapBackedCache.scala

[GitBox]

codecov-io commented on issue #3703: Add the license and notice for 
ConcurrentMapBackedCache.scala
URL: 
https://github.com/apache/incubator-openwhisk/pull/3703#issuecomment-391831090
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=h1)
 Report
   > Merging 
[#3703](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/9df6a57ef48540bdd58245e8f8cfbfacb6383db6?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `90%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/graphs/tree.svg?src=pr=l0YmsiSAso=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3703   +/-   ##
   ===
 Coverage   75.01%   75.01%   
   ===
 Files 126  127+1 
 Lines6023 6023   
 Branches  385  385   
   ===
 Hits 4518 4518   
 Misses   1505 1505
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...re/database/MultipleReadersSingleWriterCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvTXVsdGlwbGVSZWFkZXJzU2luZ2xlV3JpdGVyQ2FjaGUuc2NhbGE=)
 | `95.83% <ø> (+1%)` | :arrow_up: |
   | 
[...whisk/core/database/ConcurrentMapBackedCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ29uY3VycmVudE1hcEJhY2tlZENhY2hlLnNjYWxh)
 | `90% <90%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=footer).
 Last update 
[9df6a57...5392044](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3703: Add the license and notice for ConcurrentMapBackedCache.scala

[GitBox]

codecov-io commented on issue #3703: Add the license and notice for 
ConcurrentMapBackedCache.scala
URL: 
https://github.com/apache/incubator-openwhisk/pull/3703#issuecomment-391831090
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=h1)
 Report
   > Merging 
[#3703](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/9df6a57ef48540bdd58245e8f8cfbfacb6383db6?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `90%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/graphs/tree.svg?src=pr=l0YmsiSAso=150=650)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3703   +/-   ##
   ===
 Coverage   75.01%   75.01%   
   ===
 Files 126  127+1 
 Lines6023 6023   
 Branches  385  385   
   ===
 Hits 4518 4518   
 Misses   1505 1505
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...re/database/MultipleReadersSingleWriterCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvTXVsdGlwbGVSZWFkZXJzU2luZ2xlV3JpdGVyQ2FjaGUuc2NhbGE=)
 | `95.83% <ø> (+1%)` | :arrow_up: |
   | 
[...whisk/core/database/ConcurrentMapBackedCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ29uY3VycmVudE1hcEJhY2tlZENhY2hlLnNjYWxh)
 | `90% <90%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=footer).
 Last update 
[9df6a57...35a354f](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3703: Add the license and notice for ConcurrentMapBackedCache.scala

[GitBox]

codecov-io commented on issue #3703: Add the license and notice for 
ConcurrentMapBackedCache.scala
URL: 
https://github.com/apache/incubator-openwhisk/pull/3703#issuecomment-391831090
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=h1)
 Report
   > Merging 
[#3703](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/9df6a57ef48540bdd58245e8f8cfbfacb6383db6?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `90%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3703   +/-   ##
   ===
 Coverage   75.01%   75.01%   
   ===
 Files 126  127+1 
 Lines6023 6023   
 Branches  385  385   
   ===
 Hits 4518 4518   
 Misses   1505 1505
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...re/database/MultipleReadersSingleWriterCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvTXVsdGlwbGVSZWFkZXJzU2luZ2xlV3JpdGVyQ2FjaGUuc2NhbGE=)
 | `95.83% <ø> (+1%)` | :arrow_up: |
   | 
[...whisk/core/database/ConcurrentMapBackedCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ29uY3VycmVudE1hcEJhY2tlZENhY2hlLnNjYWxh)
 | `90% <90%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=footer).
 Last update 
[9df6a57...35a354f](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tysonnorris commented on issue #41: remove use of state in nodejs app

[GitBox]

tysonnorris commented on issue #41: remove use of state in nodejs app
URL: 
https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#issuecomment-392062854
 
 
   @rabbah you mean to separate the ActionContainer changes into its own PR? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3680: Adjust invoker playbook to pull blackbox docker images when a prefix is specified.

[GitBox]

codecov-io commented on issue #3680: Adjust invoker playbook to pull blackbox 
docker images when a prefix is specified.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3680#issuecomment-390292471
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=h1)
 Report
   > Merging 
[#3680](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b3923300638d64b375d8b79dbc268e0ae50a6bf8?src=pr=desc)
 will **increase** coverage by `0.04%`.
   > The diff coverage is `87.5%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/graphs/tree.svg?width=650=150=l0YmsiSAso=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3680  +/-   ##
   ==
   + Coverage   75.01%   75.05%   +0.04% 
   ==
 Files 126  126  
 Lines6023 6021   -2 
 Branches  385  392   +7 
   ==
   + Hits 4518 4519   +1 
   + Misses   1505 1502   -3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[.../containerpool/docker/DockerContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyRmFjdG9yeS5zY2FsYQ==)
 | `27.58% <100%> (+0.91%)` | :arrow_up: |
   | 
[...scala/whisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh)
 | `62.96% <100%> (+1.14%)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `96.15% <100%> (+0.04%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=footer).
 Last update 
[b392330...6261407](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3697: Add equals method to ensure that ByteSize instances satisfy Comparable contract

[GitBox]

codecov-io commented on issue #3697: Add equals method to ensure that ByteSize 
instances satisfy Comparable contract
URL: 
https://github.com/apache/incubator-openwhisk/pull/3697#issuecomment-391501095
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=h1)
 Report
   > Merging 
[#3697](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b3923300638d64b375d8b79dbc268e0ae50a6bf8?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `83.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/graphs/tree.svg?width=650=150=l0YmsiSAso=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3697  +/-   ##
   ==
   + Coverage   75.01%   75.02%   +<.01% 
   ==
 Files 126  126  
 Lines6023 6029   +6 
 Branches  385  384   -1 
   ==
   + Hits 4518 4523   +5 
   - Misses   1505 1506   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `96.15% <83.33%> (-1.68%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=footer).
 Last update 
[b392330...284b473](https://codecov.io/gh/apache/incubator-openwhisk/pull/3697?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3669: Make stemcells configurable by deployment

[GitBox]

codecov-io commented on issue #3669: Make stemcells configurable by deployment 
URL: 
https://github.com/apache/incubator-openwhisk/pull/3669#issuecomment-389936897
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=h1)
 Report
   > Merging 
[#3669](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b3923300638d64b375d8b79dbc268e0ae50a6bf8?src=pr=desc)
 will **increase** coverage by `0.03%`.
   > The diff coverage is `84.21%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3669  +/-   ##
   ==
   + Coverage   75.01%   75.04%   +0.03% 
   ==
 Files 126  126  
 Lines6023 6031   +8 
 Branches  385  380   -5 
   ==
   + Hits 4518 4526   +8 
 Misses   1505 1505
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...scala/whisk/core/containerpool/ContainerPool.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJQb29sLnNjYWxh)
 | `85.88% <100%> (ø)` | :arrow_up: |
   | 
[...rc/main/scala/whisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==)
 | `96.34% <100%> (+0.23%)` | :arrow_up: |
   | 
[.../scala/src/main/scala/whisk/core/entity/Size.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZW50aXR5L1NpemUuc2NhbGE=)
 | `96% <75%> (-1.83%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=footer).
 Last update 
[b392330...7cba197](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new pull request #3708: Single build.gradle file missing ASF license header

[GitBox]

mrutkows opened a new pull request #3708: Single build.gradle file missing ASF 
license header
URL: https://github.com/apache/incubator-openwhisk/pull/3708
 
 
   
   
   ## Description
   
   
   
   ## Related issue and scope
   
   - [ ] I opened an issue to propose and discuss this change (#)
   
   ## My changes affect the following components
   
   
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   - [X] Compliance
   
   ## Types of changes
   
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing 
behavior).
   
   ## Checklist:
   
   
   - [ ] I signed an [Apache 
CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style 
guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness)
 and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3707: enable concurrent runs on ActionContainer test utility

[GitBox]

codecov-io commented on issue #3707: enable concurrent runs on ActionContainer 
test utility 
URL: 
https://github.com/apache/incubator-openwhisk/pull/3707#issuecomment-392093713
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=h1)
 Report
   > Merging 
[#3707](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b3923300638d64b375d8b79dbc268e0ae50a6bf8?src=pr=desc)
 will **decrease** coverage by `0.04%`.
   > The diff coverage is `54.54%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3707  +/-   ##
   ==
   - Coverage   75.01%   74.96%   -0.05% 
   ==
 Files 126  126  
 Lines6023 6032   +9 
 Branches  385  384   -1 
   ==
   + Hits 4518 4522   +4 
   - Misses   1505 1510   +5
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=)
 | `83.67% <54.54%> (-8.83%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=footer).
 Last update 
[b392330...6dd94b4](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3707: enable concurrent runs on ActionContainer test utility

[GitBox]

codecov-io commented on issue #3707: enable concurrent runs on ActionContainer 
test utility 
URL: 
https://github.com/apache/incubator-openwhisk/pull/3707#issuecomment-392093713
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=h1)
 Report
   > Merging 
[#3707](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/b3923300638d64b375d8b79dbc268e0ae50a6bf8?src=pr=desc)
 will **decrease** coverage by `0.04%`.
   > The diff coverage is `44.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#3707  +/-   ##
   ==
   - Coverage   75.01%   74.96%   -0.05% 
   ==
 Files 126  126  
 Lines6023 6032   +9 
 Branches  385  384   -1 
   ==
   + Hits 4518 4522   +4 
   - Misses   1505 1510   +5
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ain/scala/whisk/core/containerpool/HttpUtils.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udGFpbmVycG9vbC9IdHRwVXRpbHMuc2NhbGE=)
 | `83.67% <44.44%> (-8.83%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=footer).
 Last update 
[b392330...890ab12](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392118219
 
 
   @mrutkows ^^


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392119885
 
 
   Yeah I see Travis is  but I see the failure
   https://travis-ci.org/apache/incubator-openwhisk/jobs/383311969#L3422
   ```
   
:tests:performance:gatling_tests:gatlingRun-BlockingInvokeOneActionSimulationFailed
 to auto configure default logger context
   Reported exception:
   ch.qos.logback.core.joran.spi.JoranException: Problem parsing XML document. 
See previously reported errors.
at 
ch.qos.logback.core.joran.event.SaxEventRecorder.recordEvents(SaxEventRecorder.java:65)
at 
ch.qos.logback.core.joran.GenericConfigurator.doConfigure(GenericConfigurator.java:151)
   ```
   and just continue and some tests actually ran. 樂 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pritidesai opened a new pull request #941: commenting out TestExportHelloWorld as its unstable in Travis

[GitBox]

pritidesai opened a new pull request #941: commenting out TestExportHelloWorld 
as its unstable in Travis
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/941
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392118167
 
 
   yeah it looks having the `` at the top 
is the solution and adjust the code scan to assume that xml ASF licenses start 
with this line.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #204: ignore mycluster.yaml

[GitBox]

csantanapr commented on issue #204: ignore mycluster.yaml
URL: 
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/204#issuecomment-392127587
 
 
   WTF? Travis failed
   ```
   Reading configuration file [scancode/ASF-Release.cfg]...
   Scanning files starting at 
[/home/travis/build/apache/incubator-openwhisk-deploy-kube/tools/travis/../..]...
   Scan detected 4 error(s) in 4 file(s):
 
[/home/travis/build/apache/incubator-openwhisk-deploy-kube/tools/travis/../../.travis.yml]:
  1: file does not include required license header.
 
[/home/travis/build/apache/incubator-openwhisk-deploy-kube/tools/travis/../../docker/docker-pull/pull_images.yml]:
  1: file does not include required license header.
 
[/home/travis/build/apache/incubator-openwhisk-deploy-kube/tools/travis/../../helm/values.yaml]:
 62: line has trailing whitespace.
 
[/home/travis/build/apache/incubator-openwhisk-deploy-kube/tools/travis/../../kubernetes/package-kafka/kafkapkginstaller.yml]:
 20: line has trailing whitespace.
   Scan detected 4 error(s) in 4 file(s):
   ```
   It looks yaml files need license headers. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new pull request #40: Fix example.c to have correct ASF license header.

[GitBox]

mrutkows opened a new pull request #40: Fix example.c to have correct ASF 
license header.
URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/40
 
 
   and also fix the Dockerfile headers to remove the bad '#' character


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dgrove-oss closed pull request #204: ignore mycluster.yaml

[GitBox]

dgrove-oss closed pull request #204: ignore mycluster.yaml
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/204
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.gitignore b/.gitignore
index 5300e42..210a582 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1,2 @@
 kubernetes/nginx/certs
+helm/mycluster.yaml
diff --git a/.travis.yml b/.travis.yml
index 35de9c9..13bb8a6 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,3 +1,5 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
 sudo: required
 
 env:
diff --git a/docker/docker-pull/pull_images.yml 
b/docker/docker-pull/pull_images.yml
index 05510b6..bc1dc85 100644
--- a/docker/docker-pull/pull_images.yml
+++ b/docker/docker-pull/pull_images.yml
@@ -1,3 +1,5 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more 
contributor
+# license agreements; and to You under the Apache License, Version 2.0.
 ---
 
 # Playbook to prefetch runtime action images from a docker registry for an 
invoker node.
diff --git a/helm/values.yaml b/helm/values.yaml
index bcffa16..dc4 100644
--- a/helm/values.yaml
+++ b/helm/values.yaml
@@ -59,7 +59,7 @@ db:
 enabled: false
 pvcName: couchdb-pvc
 size: 8Gi
-storageClass: CouchDBSC 
+storageClass: CouchDBSC
 accessMode: ReadWriteOnce
 
 # Nginx configurations
diff --git a/kubernetes/package-kafka/kafkapkginstaller.yml 
b/kubernetes/package-kafka/kafkapkginstaller.yml
index 6f22e44..3ddf198 100644
--- a/kubernetes/package-kafka/kafkapkginstaller.yml
+++ b/kubernetes/package-kafka/kafkapkginstaller.yml
@@ -17,7 +17,7 @@ spec:
   restartPolicy: Never
   containers:
   - name: kafkapkginstaller
-imagePullPolicy: IfNotPresent 
+imagePullPolicy: IfNotPresent
 image: openwhisk/kube-kafkapkginstaller
 env:
 - name: "APIHOST"


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392118771
 
 
   @cbickel @jeremiaswerner since you reverted and took the ASF license header, 
What do you think of having the files include the ASF header and the files 
start with `` 
   
   Would you revert again ?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392118771
 
 
   @cbickel @jeremiaswerner since you reverted and took the ASF license header 
out, What do you think of having the files include the ASF header and the files 
start with `` 
   
   Would you revert again ?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392119132
 
 
   Now that I think about it how come Travis didn't catch this problem in the 
PR that introduce the header?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo closed pull request #3708: Single build.gradle file missing ASF license header

[GitBox]

houshengbo closed pull request #3708: Single build.gradle file missing ASF 
license header
URL: https://github.com/apache/incubator-openwhisk/pull/3708
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tests/dat/actions/unicode/build.gradle 
b/tests/dat/actions/unicode/build.gradle
index 2839d50314..71833aafdc 100644
--- a/tests/dat/actions/unicode/build.gradle
+++ b/tests/dat/actions/unicode/build.gradle
@@ -1,3 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 apply plugin: 'java'
 
 version = '1.0'


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] tysonnorris commented on issue #3707: enable concurrent runs on ActionContainer test utility

[GitBox]

tysonnorris commented on issue #3707: enable concurrent runs on ActionContainer 
test utility 
URL: 
https://github.com/apache/incubator-openwhisk/pull/3707#issuecomment-392131196
 
 
   @rabbah I removed the unused `maxConcurrent` parameter


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #204: ignore mycluster.yaml

[GitBox]

csantanapr commented on issue #204: ignore mycluster.yaml
URL: 
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/204#issuecomment-392140419
 
 
   merge away sir @dgrove-oss 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo closed pull request #162: clean up repos. and file exclusion listings.

[GitBox]

houshengbo closed pull request #162: clean up repos. and file exclusion 
listings.
URL: https://github.com/apache/incubator-openwhisk-release/pull/162
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/license_compliance.md b/docs/license_compliance.md
index a74d4df..99cc5e1 100644
--- a/docs/license_compliance.md
+++ b/docs/license_compliance.md
@@ -75,23 +75,25 @@ In accordance with Apache LICENSE policies, the table below 
lists general exclus
 
 | TAG | File type | Rationale |
 |:---|:---|:---|
-| ANS.INI | Ansible (host) Inventory Files (`*.ini`) | Configuration files. 
Not much creativity.Example: 
[incubator-openwhisk/ansible/environments/local/hosts.j2.ini](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/local/hosts.j2.ini)
 |
 | ANS.CFG| Ansible Configuration Files (`*.cfg`) | Configuration files. Not 
much creativity.Example: 
[incubator-openwhisk/ansible/ansible.cfg](https://github.com/apache/incubator-openwhisk/blob/master/ansible/ansible.cfg)
 |
-| ANS.HOSTS | Ansible hosts files (`hosts`) | Configuration files. Not much 
creativity.Example: 
[incubator-openwhisk/ansible/environments/distributed/hosts](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/distributed/hosts)
 |
 | ANS.ENV | Ansible environment files (`*.env`) | Configuration files. Not 
much creativity.Example: 
[ansible/environments/distributed/files/openstack/openstack.env](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/distributed/files/openstack/openstack.env)
 |
-| DATA.TEST | Empty (zero-length) test files | Empty test data 
file.Example: 
[incubator-openwhisk/tests/dat/actions/empty.js](https://github.com/apache/incubator-openwhisk/blob/master/tests/dat/actions/empty.js)
 |
+| ANS.HOSTS | Ansible hosts files (`hosts`) | Configuration files. Not much 
creativity.Example: 
[incubator-openwhisk/ansible/environments/distributed/hosts](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/distributed/hosts)
 |
+| ANS.INI | Ansible (host) Inventory Files (`*.ini`) | Configuration files. 
Not much creativity.Example: 
[incubator-openwhisk/ansible/environments/local/hosts.j2.ini](https://github.com/apache/incubator-openwhisk/blob/master/ansible/environments/local/hosts.j2.ini)
 |
+| API.ENC | Encrypted API Credentials used in Travis | Configuration 
data.Example: 
[incubator-openwhisk-catalog/credentials.json.enc](https://github.com/apache/incubator-openwhisk-catalog/blob/master/credentials.json.enc)
 |
 | DATA.AUTH | API Auth. key | Configuration data.Example: 
[ansible/files/auth.guest](https://github.com/apache/incubator-openwhisk/blob/master/ansible/files/auth.guest)
 |
+| DATA.TEST | Empty (zero-length) test files | Empty test data 
file.Example: 
[incubator-openwhisk/tests/dat/actions/empty.js](https://github.com/apache/incubator-openwhisk/blob/master/tests/dat/actions/empty.js)
 |
 | GIT.1 | Git configuration (`.gitattributes`, `.gitignore`) | Configuration 
file. Not much creativity.  |
 | GIT.2 | Git tracking (`.git` subdirectory) | Git file tracking. Not part of 
project source. |
-| I18N.1 | Golang Internationalization resource files (`i18n_resources.go`) | 
Not much creativity. The file is auto-generated; not able to add 
header.Example: 
[incubator-openwhisk-client-go/wski18n/i18n_resources.go](https://github.com/apache/incubator-openwhisk-client-go/blob/master/wski18n/i18n_resources.go)
 |
 | GODEPS.1 | GoDeps dependencies data (`Godeps.json`) |  | JSON data generated 
by the GoDeps utility.Example: 
[incubator-openwhisk-wskdeploy/blob/master/Godeps/Godeps.json](https://github.com/apache/incubator-openwhisk-wskdeploy/blob/master/Godeps/Godeps.json)
 |
 | GODEPS.2 | GoDeps Readme file (`Readme`) | Plain text Readme generated by 
the GoDeps utility; states the directory and JSON file within it were 
autogenerated. |
-| GRDL.1 | Gradle batch files (`gradlew.bat`)| Generated by Gradle 
wrapper.Example: 
[incubator-openwhisk/blob/master/gradlew.bat](https://github.com/apache/incubator-openwhisk/blob/master/gradlew.bat)
 |
-| GRDL.2 | Gradle files (`.gogradle`) | Not much creativity |
-| GRDL.3 | Gradle Wrapper files (`gradlew`) | Generated by Gradle 
wrapper.Example: 
[incubator-openwhisk/gradlew](https://github.com/apache/incubator-openwhisk/blob/master/gradlew)
 |
+| GRDL.BAT | Gradle batch files (`gradlew.bat`)| Generated by 
Gradle.Example: 
[incubator-openwhisk/blob/master/gradlew.bat](https://github.com/apache/incubator-openwhisk/blob/master/gradlew.bat)
 |
+| GRDL.JAR | Gradle Wrapper executable JAR (`gradle-wrapper.jar`) | Generated 
by Gradle.Example: 

[GitHub] houshengbo closed pull request #42: Update repo. files to latest ASF license scanning standards to match OW project policies

[GitBox]

houshengbo closed pull request #42: Update repo. files to latest ASF license 
scanning standards to match OW project policies
URL: https://github.com/apache/incubator-openwhisk-utilities/pull/42
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 4bd83a1..93c7de3 100644
--- a/README.md
+++ b/README.md
@@ -45,7 +45,7 @@ Scan detected 3 error(s) in 1 file(s):
   27: line has trailing whitespaces.
 ```
 
-To make sure this never happens to you, you can run the same tests on your 
local machine every time you commit changes. 
+To make sure this never happens to you, you can run the same tests on your 
local machine every time you commit changes.
 
 1. Clone the OpenWhisk utilities project repo.:
 ```bash
diff --git a/scancode/ASF-Release.cfg b/scancode/ASF-Release.cfg
index 5bc9bd1..724d848 100644
--- a/scancode/ASF-Release.cfg
+++ b/scancode/ASF-Release.cfg
@@ -57,6 +57,7 @@ ASFMinifiedLicenseHeaderREM.txt
 .github
 .gitignore
 .jshintrc
+.profiling.*
 .pydevproject
 .rat-excludes
 
diff --git a/scancode/NoExclusions.cfg b/scancode/NoExclusions.cfg
index f465c77..b3c6348 100644
--- a/scancode/NoExclusions.cfg
+++ b/scancode/NoExclusions.cfg
@@ -57,6 +57,7 @@ ASFMinifiedLicenseHeaderREM.txt
 .github
 .gitignore
 .jshintrc
+.profiling.*
 .pydevproject
 .rat-excludes
 
diff --git a/scancode/travis.cfg b/scancode/travis.cfg
index 6b3ddb1..9c10889 100644
--- a/scancode/travis.cfg
+++ b/scancode/travis.cfg
@@ -10,29 +10,44 @@ ASFLicenseHeaderHash.txt
 ASFLicenseHeaderLua.txt
 ASFMinifiedLicenseHashHeader.txt
 ASFMinifiedLicenseHeader.txt
+ASFMinifiedLicenseHeaderREM.txt
 
 # Filters (path/filename) with wildcards and associated scan checks
 # that are to be run against them.  The checks are actual valid
 # function names found in scanCode.py.
 [Includes]
-*=is_not_symlink
-*.conf=has_block_license, no_trailing_spaces, eol_at_eof
-*.go=has_block_license, no_trailing_spaces, eol_at_eof
-*.gradle=no_tabs, no_trailing_spaces, eol_at_eof
-*.java=has_block_license, no_tabs, no_trailing_spaces, eol_at_eof
-*.js=no_tabs, no_trailing_spaces, eol_at_eof
-*.lua=has_block_license, no_trailing_spaces, eol_at_eof
-*.md=has_block_license, no_trailing_spaces, eol_at_eof, no_tabs
-*.py=no_tabs, no_trailing_spaces, eol_at_eof
-*.scala=has_block_license, no_tabs, no_trailing_spaces, eol_at_eof
-*.sh=has_block_license, no_trailing_spaces, eol_at_eof
+*=is_not_symlink, regex_check
+*.conf=has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.go=has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.gradle=has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.groovy=has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.html=has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.java=no_tabs, has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.js=no_tabs, has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.lua=has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.md=no_tabs, has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.properties=no_tabs, has_block_license, no_trailing_spaces, eol_at_eof, 
regex_check
+*.py=no_tabs, has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.scala=has_block_license, no_tabs, no_trailing_spaces, eol_at_eof, regex_check
+*.sh=has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.swift=no_tabs, has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.yaml=has_block_license, no_trailing_spaces, eol_at_eof, regex_check
+*.yml=has_block_license, no_trailing_spaces, eol_at_eof, regex_check
 
 # List of paths (inclusive of subdirectories) to exlude from code scanning
 [Excludes]
 # General exclusions
-.tox
-.git
 .bin
+.dockerignore
+.git
+.gitattributes
+.github
+.gitignore
+.jshintrc
+.profiling.*
+.pydevproject
+.rat-excludes
+.tox
 
 # Scancode unit tests
 tests/exclude


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] houshengbo closed pull request #40: Fix example.c to have correct ASF license header.

[GitBox]

houshengbo closed pull request #40: Fix example.c to have correct ASF license 
header.
URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/40
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdk/docker/example.c b/sdk/docker/example.c
index d884af2..904d835 100644
--- a/sdk/docker/example.c
+++ b/sdk/docker/example.c
@@ -1,22 +1,18 @@
 /*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
  *
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
+ * http://www.apache.org/licenses/LICENSE-2.0
  *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  */
 
 #include 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3703: Add the license and notice for ConcurrentMapBackedCache.scala

[GitBox]

codecov-io commented on issue #3703: Add the license and notice for 
ConcurrentMapBackedCache.scala
URL: 
https://github.com/apache/incubator-openwhisk/pull/3703#issuecomment-391831090
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=h1)
 Report
   > Merging 
[#3703](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/9df6a57ef48540bdd58245e8f8cfbfacb6383db6?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `90%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/graphs/tree.svg?width=650=l0YmsiSAso=150=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3703   +/-   ##
   ===
 Coverage   75.01%   75.01%   
   ===
 Files 126  127+1 
 Lines6023 6023   
 Branches  385  385   
   ===
 Hits 4518 4518   
 Misses   1505 1505
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...re/database/MultipleReadersSingleWriterCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvTXVsdGlwbGVSZWFkZXJzU2luZ2xlV3JpdGVyQ2FjaGUuc2NhbGE=)
 | `95.83% <ø> (+1%)` | :arrow_up: |
   | 
[...whisk/core/database/ConcurrentMapBackedCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ29uY3VycmVudE1hcEJhY2tlZENhY2hlLnNjYWxh)
 | `90% <90%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=footer).
 Last update 
[9df6a57...b93e83c](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr opened a new pull request #204: ignore mycluster.yaml

[GitBox]

csantanapr opened a new pull request #204: ignore mycluster.yaml
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/204
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392125914
 
 
   I see it looks like it only cause problems with generating the logs.
   But the gradle task continued.
   Maybe the tests ran, it didn't generate logs
   and ended with 0 exit code
   ```
   The command "OPENWHISK_HOST="172.17.0.1" MEAN_RESPONSE_TIME="1000" 
   API_KEY="$(cat ansible/files/auth.guest)" 
EXCLUDED_KINDS="python:default,java:default,swift:default" 
   ./gradlew gatlingRun-LatencySimulation" exited with 0.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3705: Revert "Add ASF license to optional XML files and last gradle file."

[GitBox]

csantanapr commented on issue #3705: Revert "Add ASF license to optional XML 
files and last gradle file."
URL: 
https://github.com/apache/incubator-openwhisk/pull/3705#issuecomment-392125914
 
 
   I see it looks like it only cause problems with generating the logs.
   But the gradle task continued.
   Maybe the tests ran, it didn't generate logs
   and ended with 0 exit code
   ```
   The command "OPENWHISK_HOST="172.17.0.1" MEAN_RESPONSE_TIME="1000" 
API_KEY="$(cat ansible/files/auth.guest)" 
EXCLUDED_KINDS="python:default,java:default,swift:default" ./gradlew 
gatlingRun-LatencySimulation" exited with 0.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3689: Enable extending environment variables of Controller and Invoker

[GitBox]

csantanapr commented on issue #3689: Enable extending environment variables of 
Controller and Invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/3689#issuecomment-392206350
 
 
   Thanks @chetanmeh for the changes.
   PG1 2954 ⏳ 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #304: API Gateway Path Parameters For Query Params?

[GitBox]

csantanapr commented on issue #304: API Gateway Path Parameters For Query 
Params?
URL: 
https://github.com/apache/incubator-openwhisk-apigateway/issues/304#issuecomment-392210799
 
 
   query parameters are usually used as optional information like filters and 
overrides. 
   
   Absolutely they can migrate not well designed APIs to OW nothing preventing 
them from using query parameters when they invoke their APIs


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3689: Enable extending environment variables of Controller and Invoker

[GitBox]

csantanapr commented on issue #3689: Enable extending environment variables of 
Controller and Invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/3689#issuecomment-392206350
 
 
   Thanks @chetanmeh for the changes.
   PG1 2954 ⏳ 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] csantanapr commented on issue #3689: Enable extending environment variables of Controller and Invoker

[GitBox]

csantanapr commented on issue #3689: Enable extending environment variables of 
Controller and Invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/3689#issuecomment-392219418
 
 
   Hey @chetanmeh please review the commit I just pushed 
https://github.com/apache/incubator-openwhisk/pull/3689/commits/fd358716d3ba7ba20960ed9b802a142d67345569
   It's was what I was proposing we do is much simpler, it allows override from 
an environment.
   Also it does proper combine using `dict` in ansible
   
   Now you are able to edit your own environment like `environment/local` and 
add something like
   ```
   controller_extraEnv:
 CONFIG_whisk_cosmosdb_endpoint : "https://.documents.azure.com:443/"
 CONFIG_whisk_cosmosdb_key : "some secret"
 CONFIG_whisk_cosmosdb_db : openwhisk
   invoker_extraEnv:
 CONFIG_whisk_cosmosdb_endpoint : "https://.documents.azure.com:443/"
 CONFIG_whisk_cosmosdb_key : "some secret"
 CONFIG_whisk_cosmosdb_db : openwhisk
   ```
   You can do it like this ^^ or in your environment load an environment 
variable into the environment file, or override using `ansible-playbook -e`
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] chetanmeh commented on issue #3689: Enable extending environment variables of Controller and Invoker

[GitBox]

chetanmeh commented on issue #3689: Enable extending environment variables of 
Controller and Invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/3689#issuecomment-392226848
 
 
   @csantanapr  I needed this support for travis specially. There I want to 
have a way where just with a env variable switch I can make test run against 
Cosmos. So earlier plan was to define pre configured env set in local
   
   
   ```yaml
   cosmos:
   CONFIG_whisk_spi_ArtifactStoreProvider: 
whisk.core.database.cosmosdb.CosmosDBArtifactStoreProvider
   CONFIG_whisk_cosmosdb_endpoint : {{ lookup('env','COSMOSDB_ENDPOINT') }}
   CONFIG_whisk_cosmosdb_key : "{{ lookup('env','COSMOSDB_KEY') }}"
   CONFIG_whisk_cosmosdb_db : "{{ lookup('env','COSMOSDB_KEY') }}"
   ```
   
   These env variables would then be configured via travis ui. And then in 
cosmos db stage of travis set
   ```
   export OPENWHISK_EXTRA_ENV=cosmos
   ```
   
   This way with minimal changes specific to  Cosmos I can run test against it. 
Any pointers on how to achieve that with approach you proposed?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3689: Enable extending environment variables of Controller and Invoker

[GitBox]

codecov-io commented on issue #3689: Enable extending environment variables of 
Controller and Invoker
URL: 
https://github.com/apache/incubator-openwhisk/pull/3689#issuecomment-391266601
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=h1)
 Report
   > Merging 
[#3689](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/9df6a57ef48540bdd58245e8f8cfbfacb6383db6?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689/graphs/tree.svg?token=l0YmsiSAso=pr=650=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3689   +/-   ##
   ===
 Coverage   75.01%   75.01%   
   ===
 Files 126  126   
 Lines6023 6023   
 Branches  385  385   
   ===
 Hits 4518 4518   
 Misses   1505 1505
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=footer).
 Last update 
[9df6a57...fd35871](https://codecov.io/gh/apache/incubator-openwhisk/pull/3689?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3703: Add the license and notice for ConcurrentMapBackedCache.scala

[GitBox]

codecov-io commented on issue #3703: Add the license and notice for 
ConcurrentMapBackedCache.scala
URL: 
https://github.com/apache/incubator-openwhisk/pull/3703#issuecomment-391831090
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=h1)
 Report
   > Merging 
[#3703](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/9df6a57ef48540bdd58245e8f8cfbfacb6383db6?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `90%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/graphs/tree.svg?src=pr=650=l0YmsiSAso=150)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#3703   +/-   ##
   ===
 Coverage   75.01%   75.01%   
   ===
 Files 126  127+1 
 Lines6023 6023   
 Branches  385  385   
   ===
 Hits 4518 4518   
 Misses   1505 1505
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...re/database/MultipleReadersSingleWriterCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvTXVsdGlwbGVSZWFkZXJzU2luZ2xlV3JpdGVyQ2FjaGUuc2NhbGE=)
 | `95.83% <ø> (+1%)` | :arrow_up: |
   | 
[...whisk/core/database/ConcurrentMapBackedCache.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703/diff?src=pr=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvQ29uY3VycmVudE1hcEJhY2tlZENhY2hlLnNjYWxh)
 | `90% <90%> (ø)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=footer).
 Last update 
[9df6a57...5392044](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mrutkows opened a new pull request #164: Fix or document last remaining exclusions across all release repos.

[GitBox]

mrutkows opened a new pull request #164: Fix or document last remaining 
exclusions across all release repos.
URL: https://github.com/apache/incubator-openwhisk-release/pull/164
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] matt-boyd commented on issue #3691: README: Available typo

[GitBox]

matt-boyd commented on issue #3691: README: Available typo
URL: 
https://github.com/apache/incubator-openwhisk/pull/3691#issuecomment-391957655
 
 
   Yes! Signed the CLA! 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

[GitBox]

chetanmeh commented on a change in pull request #2282: Distributed tracing 
support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r190799810
 
 

 ##
 File path: 
core/controller/src/main/scala/whisk/core/controller/Controller.scala
 ##
 @@ -203,6 +204,7 @@ object Controller {
 // if deploying multiple instances (scale out), must pass the instance 
number as the
 require(args.length >= 1, "controller instance required")
 val instance = args(0).toInt
+OpenTracingProvider.apply("Controller")
 
 Review comment:
   Instead of having controller and invoker initialize the tracer it would be 
better to capture the name as part of config itself. Then you can specify the 
name in reference.conf of invoker and controller and no need for any explicit 
initialization call


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

[GitBox]

chetanmeh commented on a change in pull request #2282: Distributed tracing 
support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r190802179
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/common/tracing/OpenTracingProvider.scala
 ##
 @@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.common.tracing
+
+import scala.collection.concurrent.TrieMap
+import scala.collection.mutable
+
+import brave.Tracing
+import brave.opentracing.BraveTracer
+import io.opentracing.{ActiveSpan, SpanContext}
+import io.opentracing.util.GlobalTracer
+import io.opentracing.propagation.{Format, TextMapExtractAdapter, 
TextMapInjectAdapter}
+import zipkin.reporter.Sender
+import zipkin.reporter.okhttp3.OkHttpSender
+import zipkin.reporter.AsyncReporter
+import zipkin.reporter.Reporter
+import pureconfig._
+import whisk.common.{LogMarkerToken, TransactionId}
+import whisk.core.ConfigKeys
+
+/**
+ * OpenTracing based implementation for tracing
+ */
+object OpenTracingProvider {
+
+  private val spanMap: mutable.Map[String, mutable.ListBuffer[ActiveSpan]] =
+TrieMap[String, mutable.ListBuffer[ActiveSpan]]()
+  private val contextMap: mutable.Map[String, SpanContext] = TrieMap[String, 
SpanContext]()
+
+  var enabled = false;
+
+  def apply(serviceName: String): Unit = {
+configureTracer(serviceName)
+  }
+
+  /**
+   * Start a Trace for given service.
+   *
+   * @param transactionId transactionId to which this Trace belongs.
+   * @return TracedRequest which provides details about current service being 
traced.
+   */
+  def startTrace(logMarker: LogMarkerToken, transactionId: TransactionId): 
Unit = {
+if (enabled) {
+  var activeSpan: Option[ActiveSpan] = None
+  spanMap.get(transactionId.meta.id) match {
+case Some(spanList) => {
+  //create a child trace
+  activeSpan = Some(
+GlobalTracer
+  .get()
+  .buildSpan(logMarker.action)
+  .withTag("transactionId", transactionId.meta.id)
+  .asChildOf(spanList.last)
+  .startActive())
+}
+case None => {
+  contextMap.get(transactionId.meta.id) match {
+case Some(context) => {
+  //create child trace if we have a tracing context
+  activeSpan = 
Some(GlobalTracer.get().buildSpan(logMarker.action).asChildOf(context).startActive())
+}
+case None => {
+  activeSpan = 
Some(GlobalTracer.get().buildSpan(logMarker.action).ignoreActiveSpan().startActive())
+}
+  }
+  //initialize list for this transactionId
+  val list: mutable.ListBuffer[ActiveSpan] = mutable.ListBuffer()
+  spanMap.put(transactionId.meta.id, list)
+}
+  }
+
+  //add active span to list
+  if (activeSpan.isDefined)
+spanMap.get(transactionId.meta.id).map(_.+=:(activeSpan.get))
+}
 
 Review comment:
   Avoid using `var` as much as possible. For example here it would be better 
to have `spanMap` use immutable list as values instead of buffer. And then 
above logic can be rewritten as below. Note here we add to head of list. So 
later in clear we need to remove from head
   
   ```scala
 override def startTrace(logMarker: LogMarkerToken, transactionId: 
TransactionId): Unit = {
   val spanList = spanMap.getOrElse(transactionId.meta.id, Nil)
   val activeSpan = spanList match {
 case Nil => getContextSpan(logMarker, transactionId)
 case _ =>
   tracer
 .buildSpan(logMarker.action)
 .withTag("transactionId", transactionId.meta.id)
 .asChildOf(spanList.last)
 .startActive()
   }
   
   spanMap.put(transactionId.meta.id, activeSpan :: spanList)
 }
   
 private def getContextSpan(logMarker: LogMarkerToken, transactionId: 
TransactionId) = {
   val baseSpan = tracer.buildSpan(logMarker.action)
   contextMap
 .get(transactionId.meta.id)
 .map(baseSpan.asChildOf(_).startActive())
 .getOrElse(baseSpan.ignoreActiveSpan().startActive())
 }
   ```

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

[GitBox]

chetanmeh commented on a change in pull request #2282: Distributed tracing 
support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r190803840
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/common/tracing/OpenTracingProvider.scala
 ##
 @@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.common.tracing
+
+import scala.collection.concurrent.TrieMap
+import scala.collection.mutable
+
+import brave.Tracing
+import brave.opentracing.BraveTracer
+import io.opentracing.{ActiveSpan, SpanContext}
+import io.opentracing.util.GlobalTracer
+import io.opentracing.propagation.{Format, TextMapExtractAdapter, 
TextMapInjectAdapter}
+import zipkin.reporter.Sender
+import zipkin.reporter.okhttp3.OkHttpSender
+import zipkin.reporter.AsyncReporter
+import zipkin.reporter.Reporter
+import pureconfig._
+import whisk.common.{LogMarkerToken, TransactionId}
+import whisk.core.ConfigKeys
+
+/**
+ * OpenTracing based implementation for tracing
+ */
+object OpenTracingProvider {
+
+  private val spanMap: mutable.Map[String, mutable.ListBuffer[ActiveSpan]] =
+TrieMap[String, mutable.ListBuffer[ActiveSpan]]()
+  private val contextMap: mutable.Map[String, SpanContext] = TrieMap[String, 
SpanContext]()
+
+  var enabled = false;
+
+  def apply(serviceName: String): Unit = {
+configureTracer(serviceName)
+  }
+
+  /**
+   * Start a Trace for given service.
+   *
+   * @param transactionId transactionId to which this Trace belongs.
+   * @return TracedRequest which provides details about current service being 
traced.
+   */
+  def startTrace(logMarker: LogMarkerToken, transactionId: TransactionId): 
Unit = {
+if (enabled) {
+  var activeSpan: Option[ActiveSpan] = None
+  spanMap.get(transactionId.meta.id) match {
+case Some(spanList) => {
+  //create a child trace
+  activeSpan = Some(
+GlobalTracer
+  .get()
+  .buildSpan(logMarker.action)
+  .withTag("transactionId", transactionId.meta.id)
+  .asChildOf(spanList.last)
+  .startActive())
+}
+case None => {
+  contextMap.get(transactionId.meta.id) match {
+case Some(context) => {
+  //create child trace if we have a tracing context
+  activeSpan = 
Some(GlobalTracer.get().buildSpan(logMarker.action).asChildOf(context).startActive())
+}
+case None => {
+  activeSpan = 
Some(GlobalTracer.get().buildSpan(logMarker.action).ignoreActiveSpan().startActive())
+}
+  }
+  //initialize list for this transactionId
+  val list: mutable.ListBuffer[ActiveSpan] = mutable.ListBuffer()
+  spanMap.put(transactionId.meta.id, list)
+}
+  }
+
+  //add active span to list
+  if (activeSpan.isDefined)
+spanMap.get(transactionId.meta.id).map(_.+=:(activeSpan.get))
+}
+  }
+
+  /**
+   * Finish a Trace associated with given transactionId.
+   *
+   * @param transactionId
+   */
+  def finish(logMarker: LogMarkerToken, transactionId: TransactionId): Unit = {
+if (enabled)
+  clear(transactionId)
+  }
+
+  /**
+   * Register error
+   *
+   * @param transactionId
+   */
+  def error(transactionId: TransactionId): Unit = {
+if (enabled)
+  clear(transactionId)
+  }
+
+  /**
+   * Get the current TraceContext which can be used for downstream services
+   *
+   * @param transactionId
+   * @return
+   */
+  def getTraceContext(transactionId: TransactionId): Option[Map[String, 
String]] = {
+var contextMap: Option[Map[String, String]] = None
+if (enabled) {
+  spanMap.get(transactionId.meta.id) match {
+case Some(spanList) => {
+  var map: java.util.Map[String, String] = new java.util.HashMap()
+  //inject latest span context in map
+  GlobalTracer.get().inject(spanList.last.context(), 
Format.Builtin.TEXT_MAP, new TextMapInjectAdapter(map))
+  contextMap = 
Some(scala.collection.JavaConverters.mapAsScalaMapConverter(map).asScala.toMap)
+}
+case None => None
+  }
+}
+contextMap
+  }
+
+  /**
+   * Get 

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

[GitBox]

chetanmeh commented on a change in pull request #2282: Distributed tracing 
support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r190799562
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/common/tracing/OpenTracingProvider.scala
 ##
 @@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.common.tracing
+
+import scala.collection.concurrent.TrieMap
+import scala.collection.mutable
+
+import brave.Tracing
+import brave.opentracing.BraveTracer
+import io.opentracing.{ActiveSpan, SpanContext}
+import io.opentracing.util.GlobalTracer
+import io.opentracing.propagation.{Format, TextMapExtractAdapter, 
TextMapInjectAdapter}
+import zipkin.reporter.Sender
+import zipkin.reporter.okhttp3.OkHttpSender
+import zipkin.reporter.AsyncReporter
+import zipkin.reporter.Reporter
+import pureconfig._
+import whisk.common.{LogMarkerToken, TransactionId}
+import whisk.core.ConfigKeys
+
+/**
+ * OpenTracing based implementation for tracing
+ */
+object OpenTracingProvider {
+
+  private val spanMap: mutable.Map[String, mutable.ListBuffer[ActiveSpan]] =
+TrieMap[String, mutable.ListBuffer[ActiveSpan]]()
+  private val contextMap: mutable.Map[String, SpanContext] = TrieMap[String, 
SpanContext]()
+
+  var enabled = false;
+
+  def apply(serviceName: String): Unit = {
+configureTracer(serviceName)
+  }
+
+  /**
+   * Start a Trace for given service.
+   *
+   * @param transactionId transactionId to which this Trace belongs.
+   * @return TracedRequest which provides details about current service being 
traced.
+   */
+  def startTrace(logMarker: LogMarkerToken, transactionId: TransactionId): 
Unit = {
+if (enabled) {
+  var activeSpan: Option[ActiveSpan] = None
+  spanMap.get(transactionId.meta.id) match {
+case Some(spanList) => {
+  //create a child trace
+  activeSpan = Some(
+GlobalTracer
+  .get()
+  .buildSpan(logMarker.action)
+  .withTag("transactionId", transactionId.meta.id)
+  .asChildOf(spanList.last)
+  .startActive())
+}
+case None => {
+  contextMap.get(transactionId.meta.id) match {
+case Some(context) => {
+  //create child trace if we have a tracing context
+  activeSpan = 
Some(GlobalTracer.get().buildSpan(logMarker.action).asChildOf(context).startActive())
+}
+case None => {
+  activeSpan = 
Some(GlobalTracer.get().buildSpan(logMarker.action).ignoreActiveSpan().startActive())
+}
+  }
+  //initialize list for this transactionId
+  val list: mutable.ListBuffer[ActiveSpan] = mutable.ListBuffer()
+  spanMap.put(transactionId.meta.id, list)
+}
+  }
+
+  //add active span to list
+  if (activeSpan.isDefined)
+spanMap.get(transactionId.meta.id).map(_.+=:(activeSpan.get))
+}
+  }
+
+  /**
+   * Finish a Trace associated with given transactionId.
+   *
+   * @param transactionId
+   */
+  def finish(logMarker: LogMarkerToken, transactionId: TransactionId): Unit = {
+if (enabled)
+  clear(transactionId)
+  }
+
+  /**
+   * Register error
+   *
+   * @param transactionId
+   */
+  def error(transactionId: TransactionId): Unit = {
+if (enabled)
+  clear(transactionId)
+  }
+
+  /**
+   * Get the current TraceContext which can be used for downstream services
+   *
+   * @param transactionId
+   * @return
+   */
+  def getTraceContext(transactionId: TransactionId): Option[Map[String, 
String]] = {
+var contextMap: Option[Map[String, String]] = None
+if (enabled) {
+  spanMap.get(transactionId.meta.id) match {
+case Some(spanList) => {
+  var map: java.util.Map[String, String] = new java.util.HashMap()
+  //inject latest span context in map
+  GlobalTracer.get().inject(spanList.last.context(), 
Format.Builtin.TEXT_MAP, new TextMapInjectAdapter(map))
+  contextMap = 
Some(scala.collection.JavaConverters.mapAsScalaMapConverter(map).asScala.toMap)
+}
+case None => None
+  }
+}
+contextMap
+  }
+
+  /**
+   * Get 

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

[GitBox]

chetanmeh commented on a change in pull request #2282: Distributed tracing 
support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r190804603
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/common/tracing/OpenTracingProvider.scala
 ##
 @@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.common.tracing
+
+import scala.collection.concurrent.TrieMap
+import scala.collection.mutable
+
+import brave.Tracing
+import brave.opentracing.BraveTracer
+import io.opentracing.{ActiveSpan, SpanContext}
+import io.opentracing.util.GlobalTracer
+import io.opentracing.propagation.{Format, TextMapExtractAdapter, 
TextMapInjectAdapter}
+import zipkin.reporter.Sender
+import zipkin.reporter.okhttp3.OkHttpSender
+import zipkin.reporter.AsyncReporter
+import zipkin.reporter.Reporter
+import pureconfig._
+import whisk.common.{LogMarkerToken, TransactionId}
+import whisk.core.ConfigKeys
+
+/**
+ * OpenTracing based implementation for tracing
+ */
+object OpenTracingProvider {
+
+  private val spanMap: mutable.Map[String, mutable.ListBuffer[ActiveSpan]] =
+TrieMap[String, mutable.ListBuffer[ActiveSpan]]()
+  private val contextMap: mutable.Map[String, SpanContext] = TrieMap[String, 
SpanContext]()
+
+  var enabled = false;
+
+  def apply(serviceName: String): Unit = {
+configureTracer(serviceName)
+  }
+
+  /**
+   * Start a Trace for given service.
+   *
+   * @param transactionId transactionId to which this Trace belongs.
+   * @return TracedRequest which provides details about current service being 
traced.
+   */
+  def startTrace(logMarker: LogMarkerToken, transactionId: TransactionId): 
Unit = {
+if (enabled) {
+  var activeSpan: Option[ActiveSpan] = None
+  spanMap.get(transactionId.meta.id) match {
+case Some(spanList) => {
+  //create a child trace
+  activeSpan = Some(
+GlobalTracer
+  .get()
+  .buildSpan(logMarker.action)
+  .withTag("transactionId", transactionId.meta.id)
+  .asChildOf(spanList.last)
+  .startActive())
+}
+case None => {
+  contextMap.get(transactionId.meta.id) match {
+case Some(context) => {
+  //create child trace if we have a tracing context
+  activeSpan = 
Some(GlobalTracer.get().buildSpan(logMarker.action).asChildOf(context).startActive())
+}
+case None => {
+  activeSpan = 
Some(GlobalTracer.get().buildSpan(logMarker.action).ignoreActiveSpan().startActive())
+}
+  }
+  //initialize list for this transactionId
+  val list: mutable.ListBuffer[ActiveSpan] = mutable.ListBuffer()
+  spanMap.put(transactionId.meta.id, list)
+}
+  }
+
+  //add active span to list
+  if (activeSpan.isDefined)
+spanMap.get(transactionId.meta.id).map(_.+=:(activeSpan.get))
+}
+  }
+
+  /**
+   * Finish a Trace associated with given transactionId.
+   *
+   * @param transactionId
+   */
+  def finish(logMarker: LogMarkerToken, transactionId: TransactionId): Unit = {
+if (enabled)
+  clear(transactionId)
+  }
+
+  /**
+   * Register error
+   *
+   * @param transactionId
+   */
+  def error(transactionId: TransactionId): Unit = {
+if (enabled)
+  clear(transactionId)
+  }
+
+  /**
+   * Get the current TraceContext which can be used for downstream services
+   *
+   * @param transactionId
+   * @return
+   */
+  def getTraceContext(transactionId: TransactionId): Option[Map[String, 
String]] = {
+var contextMap: Option[Map[String, String]] = None
+if (enabled) {
+  spanMap.get(transactionId.meta.id) match {
+case Some(spanList) => {
+  var map: java.util.Map[String, String] = new java.util.HashMap()
+  //inject latest span context in map
+  GlobalTracer.get().inject(spanList.last.context(), 
Format.Builtin.TEXT_MAP, new TextMapInjectAdapter(map))
+  contextMap = 
Some(scala.collection.JavaConverters.mapAsScalaMapConverter(map).asScala.toMap)
+}
+case None => None
+  }
+}
+contextMap
+  }
+
+  /**
+   * Get 

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

[GitBox]

chetanmeh commented on a change in pull request #2282: Distributed tracing 
support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r190802858
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/common/tracing/OpenTracingProvider.scala
 ##
 @@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.common.tracing
+
+import scala.collection.concurrent.TrieMap
+import scala.collection.mutable
+
+import brave.Tracing
+import brave.opentracing.BraveTracer
+import io.opentracing.{ActiveSpan, SpanContext}
+import io.opentracing.util.GlobalTracer
+import io.opentracing.propagation.{Format, TextMapExtractAdapter, 
TextMapInjectAdapter}
+import zipkin.reporter.Sender
+import zipkin.reporter.okhttp3.OkHttpSender
+import zipkin.reporter.AsyncReporter
+import zipkin.reporter.Reporter
+import pureconfig._
+import whisk.common.{LogMarkerToken, TransactionId}
+import whisk.core.ConfigKeys
+
+/**
+ * OpenTracing based implementation for tracing
+ */
+object OpenTracingProvider {
+
+  private val spanMap: mutable.Map[String, mutable.ListBuffer[ActiveSpan]] =
+TrieMap[String, mutable.ListBuffer[ActiveSpan]]()
+  private val contextMap: mutable.Map[String, SpanContext] = TrieMap[String, 
SpanContext]()
+
+  var enabled = false;
+
+  def apply(serviceName: String): Unit = {
+configureTracer(serviceName)
+  }
+
+  /**
+   * Start a Trace for given service.
+   *
+   * @param transactionId transactionId to which this Trace belongs.
+   * @return TracedRequest which provides details about current service being 
traced.
+   */
+  def startTrace(logMarker: LogMarkerToken, transactionId: TransactionId): 
Unit = {
+if (enabled) {
+  var activeSpan: Option[ActiveSpan] = None
+  spanMap.get(transactionId.meta.id) match {
+case Some(spanList) => {
+  //create a child trace
+  activeSpan = Some(
+GlobalTracer
+  .get()
+  .buildSpan(logMarker.action)
+  .withTag("transactionId", transactionId.meta.id)
+  .asChildOf(spanList.last)
+  .startActive())
+}
+case None => {
+  contextMap.get(transactionId.meta.id) match {
+case Some(context) => {
+  //create child trace if we have a tracing context
+  activeSpan = 
Some(GlobalTracer.get().buildSpan(logMarker.action).asChildOf(context).startActive())
+}
+case None => {
+  activeSpan = 
Some(GlobalTracer.get().buildSpan(logMarker.action).ignoreActiveSpan().startActive())
+}
+  }
+  //initialize list for this transactionId
+  val list: mutable.ListBuffer[ActiveSpan] = mutable.ListBuffer()
+  spanMap.put(transactionId.meta.id, list)
+}
+  }
+
+  //add active span to list
+  if (activeSpan.isDefined)
+spanMap.get(transactionId.meta.id).map(_.+=:(activeSpan.get))
+}
+  }
+
+  /**
+   * Finish a Trace associated with given transactionId.
+   *
+   * @param transactionId
+   */
+  def finish(logMarker: LogMarkerToken, transactionId: TransactionId): Unit = {
+if (enabled)
+  clear(transactionId)
+  }
+
+  /**
+   * Register error
+   *
+   * @param transactionId
+   */
+  def error(transactionId: TransactionId): Unit = {
+if (enabled)
+  clear(transactionId)
+  }
+
+  /**
+   * Get the current TraceContext which can be used for downstream services
+   *
+   * @param transactionId
+   * @return
+   */
+  def getTraceContext(transactionId: TransactionId): Option[Map[String, 
String]] = {
+var contextMap: Option[Map[String, String]] = None
+if (enabled) {
+  spanMap.get(transactionId.meta.id) match {
+case Some(spanList) => {
+  var map: java.util.Map[String, String] = new java.util.HashMap()
+  //inject latest span context in map
+  GlobalTracer.get().inject(spanList.last.context(), 
Format.Builtin.TEXT_MAP, new TextMapInjectAdapter(map))
+  contextMap = 
Some(scala.collection.JavaConverters.mapAsScalaMapConverter(map).asScala.toMap)
+}
+case None => None
+  }
+}
+contextMap
+  }
+
+  /**
+   * Get 

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

[GitBox]

chetanmeh commented on a change in pull request #2282: Distributed tracing 
support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r190800720
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/common/tracing/OpenTracingProvider.scala
 ##
 @@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.common.tracing
+
+import scala.collection.concurrent.TrieMap
+import scala.collection.mutable
+
+import brave.Tracing
+import brave.opentracing.BraveTracer
+import io.opentracing.{ActiveSpan, SpanContext}
+import io.opentracing.util.GlobalTracer
+import io.opentracing.propagation.{Format, TextMapExtractAdapter, 
TextMapInjectAdapter}
+import zipkin.reporter.Sender
+import zipkin.reporter.okhttp3.OkHttpSender
+import zipkin.reporter.AsyncReporter
+import zipkin.reporter.Reporter
+import pureconfig._
+import whisk.common.{LogMarkerToken, TransactionId}
+import whisk.core.ConfigKeys
+
+/**
+ * OpenTracing based implementation for tracing
+ */
+object OpenTracingProvider {
+
+  private val spanMap: mutable.Map[String, mutable.ListBuffer[ActiveSpan]] =
+TrieMap[String, mutable.ListBuffer[ActiveSpan]]()
+  private val contextMap: mutable.Map[String, SpanContext] = TrieMap[String, 
SpanContext]()
+
+  var enabled = false;
+
+  def apply(serviceName: String): Unit = {
+configureTracer(serviceName)
+  }
+
+  /**
+   * Start a Trace for given service.
+   *
+   * @param transactionId transactionId to which this Trace belongs.
+   * @return TracedRequest which provides details about current service being 
traced.
+   */
+  def startTrace(logMarker: LogMarkerToken, transactionId: TransactionId): 
Unit = {
+if (enabled) {
+  var activeSpan: Option[ActiveSpan] = None
+  spanMap.get(transactionId.meta.id) match {
+case Some(spanList) => {
+  //create a child trace
+  activeSpan = Some(
+GlobalTracer
+  .get()
+  .buildSpan(logMarker.action)
+  .withTag("transactionId", transactionId.meta.id)
+  .asChildOf(spanList.last)
+  .startActive())
+}
+case None => {
+  contextMap.get(transactionId.meta.id) match {
+case Some(context) => {
+  //create child trace if we have a tracing context
+  activeSpan = 
Some(GlobalTracer.get().buildSpan(logMarker.action).asChildOf(context).startActive())
+}
+case None => {
+  activeSpan = 
Some(GlobalTracer.get().buildSpan(logMarker.action).ignoreActiveSpan().startActive())
+}
+  }
+  //initialize list for this transactionId
+  val list: mutable.ListBuffer[ActiveSpan] = mutable.ListBuffer()
+  spanMap.put(transactionId.meta.id, list)
+}
+  }
+
+  //add active span to list
+  if (activeSpan.isDefined)
+spanMap.get(transactionId.meta.id).map(_.+=:(activeSpan.get))
+}
+  }
+
+  /**
+   * Finish a Trace associated with given transactionId.
+   *
+   * @param transactionId
+   */
+  def finish(logMarker: LogMarkerToken, transactionId: TransactionId): Unit = {
+if (enabled)
+  clear(transactionId)
+  }
+
+  /**
+   * Register error
+   *
+   * @param transactionId
+   */
+  def error(transactionId: TransactionId): Unit = {
+if (enabled)
+  clear(transactionId)
+  }
+
+  /**
+   * Get the current TraceContext which can be used for downstream services
+   *
+   * @param transactionId
+   * @return
+   */
+  def getTraceContext(transactionId: TransactionId): Option[Map[String, 
String]] = {
+var contextMap: Option[Map[String, String]] = None
+if (enabled) {
+  spanMap.get(transactionId.meta.id) match {
+case Some(spanList) => {
+  var map: java.util.Map[String, String] = new java.util.HashMap()
+  //inject latest span context in map
+  GlobalTracer.get().inject(spanList.last.context(), 
Format.Builtin.TEXT_MAP, new TextMapInjectAdapter(map))
+  contextMap = 
Some(scala.collection.JavaConverters.mapAsScalaMapConverter(map).asScala.toMap)
 
 Review comment:
   Instead of this you can use [JavaConverters implicits][1]
   
   

[GitHub] chetanmeh commented on a change in pull request #2282: Distributed tracing support #2192

[GitBox]

chetanmeh commented on a change in pull request #2282: Distributed tracing 
support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r190802724
 
 

 ##
 File path: 
common/scala/src/main/scala/whisk/common/tracing/OpenTracingProvider.scala
 ##
 @@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package whisk.common.tracing
+
+import scala.collection.concurrent.TrieMap
+import scala.collection.mutable
+
+import brave.Tracing
+import brave.opentracing.BraveTracer
+import io.opentracing.{ActiveSpan, SpanContext}
+import io.opentracing.util.GlobalTracer
+import io.opentracing.propagation.{Format, TextMapExtractAdapter, 
TextMapInjectAdapter}
+import zipkin.reporter.Sender
+import zipkin.reporter.okhttp3.OkHttpSender
+import zipkin.reporter.AsyncReporter
+import zipkin.reporter.Reporter
+import pureconfig._
+import whisk.common.{LogMarkerToken, TransactionId}
+import whisk.core.ConfigKeys
+
+/**
+ * OpenTracing based implementation for tracing
+ */
+object OpenTracingProvider {
+
+  private val spanMap: mutable.Map[String, mutable.ListBuffer[ActiveSpan]] =
+TrieMap[String, mutable.ListBuffer[ActiveSpan]]()
+  private val contextMap: mutable.Map[String, SpanContext] = TrieMap[String, 
SpanContext]()
+
+  var enabled = false;
+
+  def apply(serviceName: String): Unit = {
+configureTracer(serviceName)
+  }
+
 
 Review comment:
   It would better to avoid a mutable enabled flag and rely on that in logic 
later. Instead have 2 variants - `NoopTracer` and `OpenTracer`. Something like 
below. With this whole tracing would be setup at time of first access to 
tracer. If enabled `OpenTracer` would get used otherwise a noop variant would 
be used
   
   ```scala
   object WhiskTracerProvider {
 val tracingConfig = loadConfigOrThrow[TracingConfig](ConfigKeys.tracing)
   
 val tracer = if (tracingConfig.enabled) new 
OpenTracer(createZipkinTracer(tracingConfig)) else NoopTracer
   }
   
   trait WhiskTracer {
 def startTrace(logMarker: LogMarkerToken, transactionId: TransactionId): 
Unit = {}
 def finish(logMarker: LogMarkerToken, transactionId: TransactionId): Unit 
= {}
 def error(transactionId: TransactionId): Unit = {}
 def getTraceContext(transactionId: TransactionId): Option[Map[String, 
String]] = None
 def setTraceContext(transactionId: TransactionId, context: 
Option[Map[String, String]]): Unit = {}
   }
   
   private object NoopTracer extends WhiskTracer
   
   private class OpenTracer(tracer: Tracer) extends WhiskTracer {
   //Implement the methods here
   }


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3699: Add gatling-throughput test for cold invocations.

[GitBox]

codecov-io commented on issue #3699: Add gatling-throughput test for cold 
invocations.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3699#issuecomment-391705629
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=h1)
 Report
   > Merging 
[#3699](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/2cc22272635d23e4e94dd739fbca71f354043c42?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699/graphs/tree.svg?token=l0YmsiSAso=pr=150=650)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #3699   +/-   ##
   ==
 Coverage74.5%   74.5%   
   ==
 Files 126 126   
 Lines59945994   
 Branches  392 392   
   ==
 Hits 44664466   
 Misses   15281528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=footer).
 Last update 
[2cc2227...55fa487](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cbickel commented on issue #3696: Move the files under performance to tests/performance

[GitBox]

cbickel commented on issue #3696: Move the files under performance to 
tests/performance
URL: 
https://github.com/apache/incubator-openwhisk/pull/3696#issuecomment-391970454
 
 
   @csantanapr @houshengbo Why is this change necessary?
   This breaks everyone, that is already using the performance tests.
   If you want to move the performance-tests, especially the gatling tests to 
the tests-dir, why did you not include them in the same gradle-test project, 
but left them as it's own project inside another project?
   
   @mrutkows This is no step forward towards `organizing around test suites 
that can be parallized `. These tests were already running in parallel in 
travis, even before this commit. What's the issue with excluding `performance` 
as well, on generating the tar?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cbickel commented on issue #3696: Move the files under performance to tests/performance

[GitBox]

cbickel commented on issue #3696: Move the files under performance to 
tests/performance
URL: 
https://github.com/apache/incubator-openwhisk/pull/3696#issuecomment-391970454
 
 
   @csantanapr @houshengbo Why is this change necessary?
   This breaks everyone, that is already using the performance tests to verify 
their system.
   If you want to move the performance-tests, especially the gatling tests to 
the tests-dir, why did you not include them in the same gradle-test project, 
but left them as it's own project inside another project?
   
   @mrutkows This is no step forward towards `organizing around test suites 
that can be parallized `. These tests were already running in parallel in 
travis, even before this commit. What's the issue with excluding `performance` 
as well, on generating the tar?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3622: make containers' timezone sync with the docker host

[GitBox]

codecov-io commented on issue #3622: make containers' timezone sync with the 
docker host
URL: 
https://github.com/apache/incubator-openwhisk/pull/3622#issuecomment-387274607
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3622?src=pr=h1)
 Report
   > Merging 
[#3622](https://codecov.io/gh/apache/incubator-openwhisk/pull/3622?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/2cc22272635d23e4e94dd739fbca71f354043c42?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3622/graphs/tree.svg?width=650=150=pr=l0YmsiSAso)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3622?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #3622   +/-   ##
   ==
 Coverage74.5%   74.5%   
   ==
 Files 126 126   
 Lines59945994   
 Branches  392 392   
   ==
 Hits 44664466   
 Misses   15281528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3622?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3622?src=pr=footer).
 Last update 
[2cc2227...a1ed720](https://codecov.io/gh/apache/incubator-openwhisk/pull/3622?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #3699: Add gatling-throughput test for cold invocations.

[GitBox]

codecov-io commented on issue #3699: Add gatling-throughput test for cold 
invocations.
URL: 
https://github.com/apache/incubator-openwhisk/pull/3699#issuecomment-391705629
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=h1)
 Report
   > Merging 
[#3699](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-openwhisk/commit/2cc22272635d23e4e94dd739fbca71f354043c42?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699/graphs/tree.svg?token=l0YmsiSAso=pr=150=650)](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #3699   +/-   ##
   ==
 Coverage74.5%   74.5%   
   ==
 Files 126 126   
 Lines59945994   
 Branches  392 392   
   ==
 Hits 44664466   
 Misses   15281528
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=footer).
 Last update 
[2cc2227...59c74a9](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services