[GitHub] rahulqelfo opened a new pull request #3956: Ow karate
rahulqelfo opened a new pull request #3956: Ow karate URL: https://github.com/apache/incubator-openwhisk/pull/3956 This PR consists of functional test cases using Karate BDD Framework. ## Description This PR intends to complement the existing functional tests cases using the Karate BDD framework. The idea of implementing this framework is to enable testers/QA to create complete E2E scenarios utilizing the common testing framework. Also as this Framework supports Gatling, it enables to create Smoke tests based on performance. ## Related issue and scope In process of creating brief wiki explaining about this approach in here-->https://cwiki.apache.org/confluence/display/OPENWHISK/OpenWhisk+Project+Wiki ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [x] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [x] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [x] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3955: Add an variable to set the timezone for all of components
codecov-io commented on issue #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955#issuecomment-411667536 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr&el=h1) Report > Merging [#3955](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/79e72e641703b4138cc58bc6bf0d5863a8fe6919?src=pr&el=desc) will **decrease** coverage by `4.77%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3955 +/- ## == - Coverage 85.54% 80.77% -4.78% == Files 146 146 Lines7057 7057 Branches 420 420 == - Hits 6037 5700 -337 - Misses 1020 1357 +337 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `75.67% <0%> (-16.22%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr&el=footer). Last update [79e72e6...3247225](https://codecov.io/gh/apache/incubator-openwhisk/pull/3955?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3955: Add an variable to set the timezone for all of components
markusthoemmes commented on a change in pull request #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955#discussion_r208838373 ## File path: ansible/roles/apigateway/tasks/deploy.yml ## @@ -28,3 +29,6 @@ until: result.status == 200 retries: 12 delay: 5 + +- name: install tzdata on apigateway + shell: docker exec apigateway sh -c "apk add -u tzdata && api-gateway -s reload" Review comment: Should this be pushed upstream rather than patching here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3798: Allow for activation store to accept user and request information
chetanmeh commented on issue #3798: Allow for activation store to accept user and request information URL: https://github.com/apache/incubator-openwhisk/pull/3798#issuecomment-411672562 > where do you think the UserContext case class should live Adding it to `ActivationStore` looks fine This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fmaschler commented on issue #2926: Missing document for wskadmin
fmaschler commented on issue #2926: Missing document for wskadmin
URL:
https://github.com/apache/incubator-openwhisk/issues/2926#issuecomment-411676875
I came across this issue using the docker-compose quick-start. I guess it's
deprecated with the new tool `wskadmin-next`? Since neither of the two works I
provided the properties in `$OPENWHISK_PROJECT_HOME/whisk.properties` and got
the following error:
> Failed to get namespace key ({"error":"not_found","reason":"no_db_file"})
Any suggestions how to fix that?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh commented on issue #2926: Missing document for wskadmin
chetanmeh commented on issue #2926: Missing document for wskadmin URL: https://github.com/apache/incubator-openwhisk/issues/2926#issuecomment-411678781 `wskadmin-next` is not deprecated. You need to have required properties in `whisk.properties` file. Can you share output of `wskadmin -v user get guest`. That would provide more details. Also as you have created a custom whisk.properties file can you provide that also. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jiangpengcheng commented on a change in pull request #3955: Add an variable to set the timezone for all of components
jiangpengcheng commented on a change in pull request #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955#discussion_r208845167 ## File path: ansible/roles/apigateway/tasks/deploy.yml ## @@ -28,3 +29,6 @@ until: result.status == 200 retries: 12 delay: 5 + +- name: install tzdata on apigateway + shell: docker exec apigateway sh -c "apk add -u tzdata && api-gateway -s reload" Review comment: yes, that's better, but then it won't compatible with old apigateway This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3814: wskadmin scala db command to export and import
codecov-io edited a comment on issue #3814: wskadmin scala db command to export and import URL: https://github.com/apache/incubator-openwhisk/pull/3814#issuecomment-400666862 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr&el=h1) Report > Merging [#3814](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/79e72e641703b4138cc58bc6bf0d5863a8fe6919?src=pr&el=desc) will **decrease** coverage by `14.8%`. > The diff coverage is `52.4%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#3814 +/- ## === - Coverage 85.54% 70.74% -14.81% === Files 146 149+3 Lines7057 7264 +207 Branches 420 441 +21 === - Hits 6037 5139 -898 - Misses 1020 2125 +1105 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...src/main/scala/whisk/core/cli/ProgressTicker.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr&el=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvd2hpc2svY29yZS9jbGkvUHJvZ3Jlc3NUaWNrZXIuc2NhbGE=) | `5.26% <5.26%> (ø)` | | | [...rc/main/scala/whisk/core/cli/CommandMessages.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr&el=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvd2hpc2svY29yZS9jbGkvQ29tbWFuZE1lc3NhZ2VzLnNjYWxh) | `86.36% <50%> (-8.09%)` | :arrow_down: | | [...ols/admin/src/main/scala/whisk/core/cli/Main.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr&el=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvd2hpc2svY29yZS9jbGkvTWFpbi5zY2FsYQ==) | `27.84% <60%> (+2.51%)` | :arrow_up: | | [...isk/core/database/memory/MemoryArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvbWVtb3J5L01lbW9yeUFydGlmYWN0U3RvcmUuc2NhbGE=) | `97.61% <66.66%> (-0.76%)` | :arrow_down: | | [...la/whisk/core/database/CouchDBStreamingStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr&el=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvd2hpc2svY29yZS9kYXRhYmFzZS9Db3VjaERCU3RyZWFtaW5nU3RvcmUuc2NhbGE=) | `82.14% <82.14%> (ø)` | | | [...src/main/scala/whisk/core/database/DbCommand.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr&el=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvd2hpc2svY29yZS9kYXRhYmFzZS9EYkNvbW1hbmQuc2NhbGE=) | `82.6% <82.6%> (ø)` | | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...la/src/main/scala/whisk/http/BasicRasService.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvQmFzaWNSYXNTZXJ2aWNlLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...a/src/main/scala/whisk/http/BasicHttpService.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2h0dHAvQmFzaWNIdHRwU2VydmljZS5zY2FsYQ==) | `0% <0%> (-93.45%)` | :arrow_down: | | ... and [53 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr&el=footer). Last update [79e72e6...7c9fc98](https://codecov.io/gh/apache/incubator-openwhisk/pull/3814?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---
[GitHub] fmaschler opened a new issue #3957: wskadmin-next configuration error
fmaschler opened a new issue #3957: wskadmin-next configuration error URL: https://github.com/apache/incubator-openwhisk/issues/3957 The tool `wskadmin-next` failed to list namespaces when following the steps in the [README](https://github.com/apache/incubator-openwhisk/blob/master/tools/admin/README-NEXT.md). ## Environment details: * local deployment with docker-compose * version * docker:18.03.1-ce * docker-compose:1.22.0 * Ubuntu: 18.04 (4.14.47-64) ## Steps to reproduce the issue: 1. Local deployment with docker-compose 2. [Build](https://github.com/apache/incubator-openwhisk/blob/master/tools/admin/README-NEXT.md#build) wskadmin-next 3. Add [configuration file](https://github.com/apache/incubator-openwhisk/blob/master/tools/admin/README-NEXT.md#build) 4. Run `$./wskadmin-next -c application-cli.conf user get guest` ## Expected results: ``` guest 23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP ``` ## Actual results: ``` Exception in thread "main" java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.springframework.boot.loader.MainMethodRunner.run(MainMethodRunner.java:48) at org.springframework.boot.loader.Launcher.launch(Launcher.java:87) at org.springframework.boot.loader.Launcher.launch(Launcher.java:50) at org.springframework.boot.loader.JarLauncher.main(JarLauncher.java:51) Caused by: java.lang.ExceptionInInitializerError at whisk.common.TransactionId$.started$extension(TransactionId.scala:89) at whisk.core.database.CouchDbRestStore.get(CouchDbRestStore.scala:221) at whisk.core.database.UserCommand.getKey(UserCommand.scala:223) at whisk.core.database.UserCommand.exec(UserCommand.scala:158) at whisk.core.cli.WhiskAdmin.executeCommand(Main.scala:190) at whisk.core.cli.Main$$anonfun$5.apply(Main.scala:107) at whisk.core.cli.Main$$anonfun$5.apply(Main.scala:106) at scala.util.Try$.apply(Try.scala:192) at whisk.core.cli.Main$.executeWithSystem(Main.scala:106) at whisk.core.cli.Main$.execute(Main.scala:93) at whisk.core.cli.Main$.main(Main.scala:86) at whisk.core.cli.Main.main(Main.scala) ... 8 more Caused by: pureconfig.error.ConfigReaderException: Cannot convert configuration to a whisk.common.tracing.TracingConfig. Failures are: at 'whisk.tracing': - (jar:file$OPENWHISK_PROJECT_HOME/bin/wskadmin-next!/BOOT-INF/lib/openwhisk-common-1.0.0-SNAPSHOT.jar!/application.conf:193) Key not found: 'component'. at pureconfig.package$.getResultOrThrow(package.scala:138) at pureconfig.package$.loadConfigOrThrow(package.scala:160) at whisk.common.tracing.WhiskTracerProvider$.(OpenTracingProvider.scala:158) at whisk.common.tracing.WhiskTracerProvider$.(OpenTracingProvider.scala:158) ... 20 more ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] fmaschler commented on issue #2926: Missing document for wskadmin
fmaschler commented on issue #2926: Missing document for wskadmin URL: https://github.com/apache/incubator-openwhisk/issues/2926#issuecomment-411684133 Of course `wskadmin-next` ist not deprecated, I referred to `wskadmin`. The verbose flag did help to find the mistake in the requested URL. `whisk.properties` contained a wrong DB name... Thanks @chetanmeh for the quick help! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3950: Extend system testsuite
codecov-io commented on issue #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#issuecomment-411691678 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=h1) Report > Merging [#3950](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/da1b28b5473e03961ca15e91136dd81fc93a3996?src=pr&el=desc) will **decrease** coverage by `4.42%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3950 +/- ## == - Coverage 85.19% 80.77% -4.43% == Files 146 146 Lines7057 7057 Branches 420 420 == - Hits 6012 5700 -312 - Misses 1045 1357 +312 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `73.94% <0%> (+15.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=footer). Last update [da1b28b...97f2b9b](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3950: Extend system testsuite
codecov-io edited a comment on issue #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#issuecomment-411691678 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=h1) Report > Merging [#3950](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/da1b28b5473e03961ca15e91136dd81fc93a3996?src=pr&el=desc) will **decrease** coverage by `4.42%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3950 +/- ## == - Coverage 85.19% 80.77% -4.43% == Files 146 146 Lines7057 7057 Branches 420 420 == - Hits 6012 5700 -312 - Misses 1045 1357 +312 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `73.94% <0%> (+15.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=footer). Last update [da1b28b...97f2b9b](https://codecov.io/gh/apache/incubator-openwhisk/pull/3950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #2926: Missing document for wskadmin
chetanmeh commented on issue #2926: Missing document for wskadmin URL: https://github.com/apache/incubator-openwhisk/issues/2926#issuecomment-411695146 My mistake ... I mean `wskadmin` is yet not deprecated and should work for your usecase This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #3951: Docs fixes for action invocations
codecov-io commented on issue #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#issuecomment-411695432 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951?src=pr&el=h1) Report > Merging [#3951](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/da1b28b5473e03961ca15e91136dd81fc93a3996?src=pr&el=desc) will **decrease** coverage by `4.42%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3951 +/- ## == - Coverage 85.19% 80.77% -4.43% == Files 146 146 Lines7057 7057 Branches 420 420 == - Hits 6012 5700 -312 - Misses 1045 1357 +312 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | | [...rc/main/scala/whisk/common/ForcibleSemaphore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvbW1vbi9Gb3JjaWJsZVNlbWFwaG9yZS5zY2FsYQ==) | `88.46% <0%> (+3.84%)` | :arrow_up: | | [...ain/scala/whisk/core/invoker/InvokerReactive.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvaW52b2tlci9JbnZva2VyUmVhY3RpdmUuc2NhbGE=) | `73.94% <0%> (+15.12%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951?src=pr&el=footer). Last update [da1b28b...65614e7](https://codecov.io/gh/apache/incubator-openwhisk/pull/3951?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jvdgeest opened a new pull request #271: Correctly writing custom OpenWhisk authentication keys (for the guest…
jvdgeest opened a new pull request #271: Correctly writing custom OpenWhisk authentication keys (for the guest… URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/271 … and whisk.system users) into the CouchDB database. With this fix, custom auth keys that are defined in `values.yml` of the Helm chart (`whisk.auth.system` and `whisk.auth.guest`) are correctly applied and stored in the CouchDB database of OpenWhisk. In the `initdb.sh` script, the `https://github.com/apache/incubator-openwhisk` git repository is cloned on line number 5. In this git repository, the auth keys for OpenWhisk are stored in the `ansible/files/auth.guest` and `/openwhisk/ansible/files/auth.whisk.system` files. These files contain the default authentication keys. I have added two lines to this shell script, that take the secret keys from Kubernetes containing the custom values defined in`values.yml` of the Helm chart. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite
markusthoemmes commented on a change in pull request #3950: Extend system
testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208862427
##
File path: tests/src/test/scala/whisk/core/cli/test/WskEntitlementTests.scala
##
@@ -160,6 +160,46 @@ abstract class WskEntitlementTests extends TestHelpers
with WskTestHelpers with
}
}
+ it should "list shared packages when package is turned into public" in
withAssetCleaner(guestWskProps) {
+(wp, assetHelper) =>
+ assetHelper.withCleaner(wsk.pkg, samplePackage) { (pkg, _) =>
+pkg.create(samplePackage)(wp)
+ }
+
+ retry {
+val packageList =
wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
+verifyPackageNotSharedList(packageList, guestNamespace, samplePackage)
+ }
+
+ wsk.pkg.create(samplePackage, update = true, shared = Some(true))(wp)
+
+ retry {
+val packageList =
wsk.pkg.list(Some(s"/$guestNamespace"))(defaultWskProps)
+verifyPackageSharedList(packageList, guestNamespace, samplePackage)
+ }
+ }
+
+ it should "not list any packages from invalid namespace" in
withAssetCleaner(guestWskProps) { (wp, assetHelper) =>
+val invalidNamespace = "whisk.systsdf"
+retry {
+ val packageList = wsk.pkg.list(Some(s"/$invalidNamespace"))(wp)
+ packageList.stdout should be("[]") //empty list
+}
+ }
+
+ it should "reject getting package from invalid namespace" in
withAssetCleaner(guestWskProps) { (wp, assetHelper) =>
+val invalidNamespace = "whisk.systsdf"
+wsk.pkg.get(s"/${invalidNamespace}/utils", expectedExitCode =
forbiddenCode)(wp).stderr should include(
+ "not authorized")
+ }
+
+ it should "reject getting invalid package from valid namespace" in
withAssetCleaner(guestWskProps) {
+(wp, assetHelper) =>
+ val invalidPackage = "util"
+ wsk.pkg.get(s"/whisk.system/${invalidPackage}", expectedExitCode =
forbiddenCode)(wp).stderr should include(
+"not authorized")
+ }
Review comment:
Should all of these be moved to `PackagesApiTests.scala`?
EDIT: After a discussion via Slack, we agreed to keep these in here for the
moment since they revealed missing pieces in the swagger documentation.
Does this only apply to the last two? Could we move the first ones to the
API-level test and keep the others in here leaving a TODO to move once the
API-level tests can validate swagger conformity as well?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite
markusthoemmes commented on a change in pull request #3950: Extend system
testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208863182
##
File path:
tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala
##
@@ -462,6 +462,58 @@ class ActivationsApiTests extends ControllerTestCommon
with WhiskActivationsApi
}
}
+ it should "skip activations and return correct ones" in {
+implicit val tid = transid()
+val activations = (1 to 3).map { _ =>
+ WhiskActivation(
+namespace,
+aname(),
+creds.subject,
+ActivationId.generate(),
+start = Instant.now,
+end = Instant.now)
+}.toList
+
+try {
+ activations.foreach(storeActivation)
+ waitOnListActivationsInNamespace(namespace, 3)
+
+ Get(s"$collectionPath?skip=1") ~> Route.seal(routes(creds)) ~> check {
+status should be(OK)
+val activations = responseAs[List[JsObject]]
+activations.length should be(2)
+ }
+} finally {
+ activations.foreach(a =>
deleteActivation(ActivationId(a.docid.asString)))
+}
+ }
+
+ it should "return last activation" in {
+implicit val tid = transid()
+val activations = (1 to 3).map { _ =>
+ WhiskActivation(
+namespace,
+aname(),
+creds.subject,
+ActivationId.generate(),
+start = Instant.now,
+end = Instant.now)
+}.toList
+
+try {
+ activations.foreach(storeActivation)
+ waitOnListActivationsInNamespace(namespace, 3)
+
+ Get(s"$collectionPath?limit=1") ~> Route.seal(routes(creds)) ~> check {
+status should be(OK)
+val activations = responseAs[List[JsObject]]
+activations.length should be(1)
+ }
Review comment:
Same comments as above, we should narrow the check and not hardcode the "3"
in the waitOn expression.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite
markusthoemmes commented on a change in pull request #3950: Extend system testsuite URL: https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208861393 ## File path: tests/src/test/scala/system/basic/WskActivationTests.scala ## @@ -21,6 +21,7 @@ import common.rest.WskRestOperations import org.junit.runner.RunWith import org.scalatest.junit.JUnitRunner import common._ + Review comment: Please drop this file from the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite
markusthoemmes commented on a change in pull request #3950: Extend system
testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208862658
##
File path:
tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala
##
@@ -462,6 +462,58 @@ class ActivationsApiTests extends ControllerTestCommon
with WhiskActivationsApi
}
}
+ it should "skip activations and return correct ones" in {
+implicit val tid = transid()
+val activations = (1 to 3).map { _ =>
+ WhiskActivation(
+namespace,
+aname(),
+creds.subject,
+ActivationId.generate(),
+start = Instant.now,
+end = Instant.now)
+}.toList
+
+try {
+ activations.foreach(storeActivation)
+ waitOnListActivationsInNamespace(namespace, 3)
Review comment:
The "3" can be derived fromt the activations list:
`waitOnListActivationsInNamespace(namespace, activations.size)`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite
markusthoemmes commented on a change in pull request #3950: Extend system
testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208862176
##
File path: tests/src/test/scala/system/basic/WskRestBasicTests.scala
##
@@ -320,6 +320,40 @@ class WskRestBasicTests extends TestHelpers with
WskTestHelpers with WskActorSys
}
}
+ it should "create action using parameter file, invoke an action using
another parameter file" in withAssetCleaner(
+wskprops) { (wp, assetHelper) =>
+val name = "paramOverridingAction"
+val file = Some(TestUtils.getTestActionFilename("argsPrint.js"))
+val argsCreate = Some(TestUtils.getTestActionFilename("argsCreate.json"))
+
+assetHelper.withCleaner(wsk.action, name) { (action, _) =>
+ action.create(name, file, parameterFile = argsCreate)
+}
+
+//check only first parameters is filled
+val expectedOutput1 = JsObject("param1" -> JsString("value1"), "param2" ->
JsString(""))
+val run1 = wsk.action.invoke(name)
+withActivation(wsk.activation, run1) { activation =>
+ activation.response.result shouldBe Some(expectedOutput1)
+}
+
+//check second parameter is supplied by param file (merging parameters)
+val argsInvoke2 = Some(TestUtils.getTestActionFilename("argsInvoke.json"))
+val expectedOutput2 = JsObject("param1" -> JsString("value1"), "param2" ->
JsString("value2"))
+val run2 = wsk.action.invoke(name, parameterFile = argsInvoke2)
+withActivation(wsk.activation, run2) { activation =>
+ activation.response.result shouldBe Some(expectedOutput2)
+}
+
+//check first param overridden by params file and second param supplied by
the file
+val argsInvoke3 =
Some(TestUtils.getTestActionFilename("argsInvokeOverride.json"))
+val expectedOutput3 = JsObject("param1" -> JsString("value3"), "param2" ->
JsString("value2"))
+val run3 = wsk.action.invoke(name, parameterFile = argsInvoke3)
+withActivation(wsk.activation, run3) { activation =>
+ activation.response.result shouldBe Some(expectedOutput3)
+}
+ }
Review comment:
Parameter files are not even implemented by the API IIRC, as in: The test
utility just reads the file and transforms the parameters to be included in the
call like every other parameter as well. As such, I think this is only useful
as a CLI test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite
markusthoemmes commented on a change in pull request #3950: Extend system
testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208861341
##
File path: tests/src/test/scala/system/basic/WskActionTests.scala
##
@@ -71,6 +71,49 @@ class WskActionTests extends TestHelpers with
WskTestHelpers with JsHelpers with
}
}
+ it should "invoke an action that throws an uncaught exception and returns
correct status code" in withAssetCleaner(
+wskprops) { (wp, assetHelper) =>
+val name = "throwExceptionAction"
+assetHelper.withCleaner(wsk.action, name) { (action, _) =>
+ action.create(name,
Some(TestUtils.getTestActionFilename("runexception.js")))
+}
+
+withActivation(wsk.activation, wsk.action.invoke(name)) { activation =>
+ val response = activation.response
+ activation.response.status shouldBe "action developer error"
+ activation.response.result shouldBe Some(
+JsObject("error" -> "An error has occurred: Extraordinary
exception".toJson))
+}
+ }
+
+ it should "invoke an action with option --blocking only and verify output"
in withAssetCleaner(wskprops) {
+(wp, assetHelper) =>
+ val name = "invokeResult"
+ assetHelper.withCleaner(wsk.action, name) { (action, _) =>
+action.create(name, Some(TestUtils.getTestActionFilename("echo.js")))
+ }
+ val args = Map("hello" -> "Robert".toJson)
+ val run = wsk.action.invoke(name, args, blocking = true)
+
+ run.stdout.parseJson.asJsObject.getFieldPath("response",
"result").get.asJsObject shouldBe JsObject(args)
+
+ run.stdout.parseJson.asJsObject
+.getFields(
+ "activationId",
+ "annotations",
+ "duration",
+ "end",
+ "logs",
+ "name",
+ "namespace",
+ "publish",
+ "response",
+ "start",
+ "subject",
+ "version") should have size 12
+
+ }
Review comment:
I think this test should move to the API-level, as it only verifies the
schema of the response vs. doing something that requires to go through the
whole system, is that correct?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite
markusthoemmes commented on a change in pull request #3950: Extend system
testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208863005
##
File path:
tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala
##
@@ -462,6 +462,58 @@ class ActivationsApiTests extends ControllerTestCommon
with WhiskActivationsApi
}
}
+ it should "skip activations and return correct ones" in {
+implicit val tid = transid()
+val activations = (1 to 3).map { _ =>
+ WhiskActivation(
+namespace,
+aname(),
+creds.subject,
+ActivationId.generate(),
+start = Instant.now,
+end = Instant.now)
+}.toList
+
+try {
+ activations.foreach(storeActivation)
+ waitOnListActivationsInNamespace(namespace, 3)
+
+ Get(s"$collectionPath?skip=1") ~> Route.seal(routes(creds)) ~> check {
+status should be(OK)
+val activations = responseAs[List[JsObject]]
+activations.length should be(2)
Review comment:
Can we narrow this check by checking for the correct activations? Like:
```scala
responseActivations shouldBe activations.map(_.toJson).drop(1)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite
markusthoemmes commented on a change in pull request #3950: Extend system
testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208860665
##
File path: tests/src/test/scala/common/rest/WskRestOperations.scala
##
@@ -733,13 +738,23 @@ class RestActivationOperations(implicit val actorSystem:
ActorSystem)
fieldFilter: Option[String] = None,
last: Option[Boolean] = None,
summary: Option[Boolean] = None)(implicit wp: WskProps):
RestResult = {
-val rr = activationId match {
+val actId = activationId match {
+ case Some(id) => activationId
+ case None =>
+last match {
+ case Some(b) if b == true => {
+val activations = pollFor(N = 1, entity = None, limit = Some(1))
+require(activations.size <= 1)
+if (activations.isEmpty) None else Some(activations.head)
+ }
Review comment:
The pattern match can match the "true" directly, as in:
```scala
last match {
case Some(true) =>
...
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] chetanmeh opened a new pull request #3958: Add tracing component name to wskadmin-next
chetanmeh opened a new pull request #3958: Add tracing component name to wskadmin-next URL: https://github.com/apache/incubator-openwhisk/pull/3958 `wskadmin-next` fails to start with configuration exception. This config is required for each independent component which depends on common module to provide tracing name. This does not get caught in test as there the combined config from controller and invoker provide required missing config. Fixes #3957 ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components - [ ] API - [ ] Controller - [ ] Message Bus (e.g., Kafka) - [ ] Loadbalancer - [ ] Invoker - [ ] Intrinsic actions (e.g., sequences, conductors) - [ ] Data stores (e.g., CouchDB) - [ ] Tests - [ ] Deployment - [ ] CLI - [ ] General tooling - [ ] Documentation ## Types of changes - [ ] Bug fix (generally a non-breaking change which closes an issue). - [ ] Enhancement or new feature (adds new functionality). - [ ] Breaking change (a bug fix or enhancement which changes existing behavior). ## Checklist: - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md). - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :). - [ ] I added tests to cover my changes. - [ ] My changes require further changes to the documentation. - [ ] I updated the documentation where necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3957: wskadmin-next configuration error
chetanmeh commented on issue #3957: wskadmin-next configuration error URL: https://github.com/apache/incubator-openwhisk/issues/3957#issuecomment-411724078 I had currently [fixed it][1] as part of work in #3814. Now created a separate PR #3958 to fix this specifically [1]: https://github.com/apache/incubator-openwhisk/pull/3814/commits/8c4138430a26f0f994c81ad848241edc9804d1a5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh commented on issue #3958: Add tracing component name to wskadmin-next
chetanmeh commented on issue #3958: Add tracing component name to wskadmin-next URL: https://github.com/apache/incubator-openwhisk/pull/3958#issuecomment-411724410 > Could this be included in the generated conf file? Can be but its more of a constant config so better part of embedded conf. Do not expect it to be tweaked by user This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] chetanmeh edited a comment on issue #3957: wskadmin-next configuration error
chetanmeh edited a comment on issue #3957: wskadmin-next configuration error URL: https://github.com/apache/incubator-openwhisk/issues/3957#issuecomment-411724078 I had currently [fixed it][1] as part of work in #3814. Now created a separate PR #3958 to fix this specifically [1]: https://github.com/apache/incubator-openwhisk/pull/3814/commits/8c4138430a26f0f994c81ad848241edc9804d1a5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3950: Extend system testsuite
mgencur commented on a change in pull request #3950: Extend system testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208896992
##
File path:
tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala
##
@@ -462,6 +462,58 @@ class ActivationsApiTests extends ControllerTestCommon
with WhiskActivationsApi
}
}
+ it should "skip activations and return correct ones" in {
+implicit val tid = transid()
+val activations = (1 to 3).map { _ =>
+ WhiskActivation(
+namespace,
+aname(),
+creds.subject,
+ActivationId.generate(),
+start = Instant.now,
+end = Instant.now)
+}.toList
+
+try {
+ activations.foreach(storeActivation)
+ waitOnListActivationsInNamespace(namespace, 3)
+
+ Get(s"$collectionPath?skip=1") ~> Route.seal(routes(creds)) ~> check {
+status should be(OK)
+val activations = responseAs[List[JsObject]]
+activations.length should be(2)
Review comment:
There are two problems with this solution:
1) the two json results are not completely equal (one of them has more
fields)
2) it looks like the activations might be returned in different order so it
might be different every time
Comparing just the size of the results is more robust
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite
markusthoemmes commented on a change in pull request #3950: Extend system
testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208900516
##
File path:
tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala
##
@@ -462,6 +462,58 @@ class ActivationsApiTests extends ControllerTestCommon
with WhiskActivationsApi
}
}
+ it should "skip activations and return correct ones" in {
+implicit val tid = transid()
+val activations = (1 to 3).map { _ =>
+ WhiskActivation(
+namespace,
+aname(),
+creds.subject,
+ActivationId.generate(),
+start = Instant.now,
+end = Instant.now)
+}.toList
+
+try {
+ activations.foreach(storeActivation)
+ waitOnListActivationsInNamespace(namespace, 3)
+
+ Get(s"$collectionPath?skip=1") ~> Route.seal(routes(creds)) ~> check {
+status should be(OK)
+val activations = responseAs[List[JsObject]]
+activations.length should be(2)
Review comment:
Hmm, that sounds fishy. If we define the timestamps for the activations that
we save, the order should be guaranteed.
I buy the schema difference though, should we then just check for the
activation id for example?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on issue #3958: Add tracing component name to wskadmin-next
markusthoemmes commented on issue #3958: Add tracing component name to wskadmin-next URL: https://github.com/apache/incubator-openwhisk/pull/3958#issuecomment-411732911 Why is this needed if tracing is disabled? Do we have a bug somewhere else? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3950: Extend system testsuite
mgencur commented on a change in pull request #3950: Extend system testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208905795
##
File path:
tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala
##
@@ -462,6 +462,58 @@ class ActivationsApiTests extends ControllerTestCommon
with WhiskActivationsApi
}
}
+ it should "skip activations and return correct ones" in {
+implicit val tid = transid()
+val activations = (1 to 3).map { _ =>
+ WhiskActivation(
+namespace,
+aname(),
+creds.subject,
+ActivationId.generate(),
+start = Instant.now,
+end = Instant.now)
+}.toList
+
+try {
+ activations.foreach(storeActivation)
+ waitOnListActivationsInNamespace(namespace, 3)
+
+ Get(s"$collectionPath?skip=1") ~> Route.seal(routes(creds)) ~> check {
+status should be(OK)
+val activations = responseAs[List[JsObject]]
+activations.length should be(2)
Review comment:
Well, I'm just reporting what I'm seeing:)
Running this code twice:
`
Get(s"$collectionPath?skip=1") ~> Route.seal(routes(creds)) ~> check {
status should be(OK)
val activations = responseAs[List[JsObject]].map(_.fields("name"))
println(s"Resp: $activations")
}
`
Gives me:
`
1) Resp: List("activations_tests_name15", "activations_tests_name13")
2) Resp: List("activations_tests_name14", "activations_tests_name15")
`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] markusthoemmes commented on a change in pull request #3950: Extend system testsuite
markusthoemmes commented on a change in pull request #3950: Extend system
testsuite
URL:
https://github.com/apache/incubator-openwhisk/pull/3950#discussion_r208909320
##
File path:
tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala
##
@@ -462,6 +462,58 @@ class ActivationsApiTests extends ControllerTestCommon
with WhiskActivationsApi
}
}
+ it should "skip activations and return correct ones" in {
+implicit val tid = transid()
+val activations = (1 to 3).map { _ =>
+ WhiskActivation(
+namespace,
+aname(),
+creds.subject,
+ActivationId.generate(),
+start = Instant.now,
+end = Instant.now)
+}.toList
+
+try {
+ activations.foreach(storeActivation)
+ waitOnListActivationsInNamespace(namespace, 3)
+
+ Get(s"$collectionPath?skip=1") ~> Route.seal(routes(creds)) ~> check {
+status should be(OK)
+val activations = responseAs[List[JsObject]]
+activations.length should be(2)
Review comment:
You might need to specifically set the start/end respectively to have each
activation after the other. Granularity is milliseconds so it's plausible they
all get the same timestamp in this test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rabbah commented on a change in pull request #3955: Add an variable to set the timezone for all of components
rabbah commented on a change in pull request #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955#discussion_r208915212 ## File path: ansible/README.md ## @@ -359,3 +359,11 @@ limits: - The `limits.concurrentInvocations` represents the maximum concurrent invocations allowed per namespace. - The `limits.firesPerMinute` represents the allowed namespace trigger firings per minute. - The `limits.sequenceMaxLength` represents the maximum length of a sequence action. + + Set the timezone for containers +The default timezone is `UTC`, which may differ from your servers, and makes it a litter difficult to analyse error logs, the configuration locates in [./group_vars/all](./group_vars/all) and may be changed by modifying the group_vars or by passing extra var to ansible-playbook(`-e docker_timzone=xxx`) for your specific environment. Review comment: Suggested rewrite: The default timezone for all system containers is `UTC`. The timezone may differ from your servers which could make it difficult to inspect logs. The timezone is configured globally in [group_vars/all](./group_vars/all) or by passing an extra variable `-e docker_timzone=xxx` when you run an `ansible-playbook`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3955: Add an variable to set the timezone for all of components
rabbah commented on a change in pull request #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955#discussion_r208915359 ## File path: ansible/README.md ## @@ -359,3 +359,11 @@ limits: - The `limits.concurrentInvocations` represents the maximum concurrent invocations allowed per namespace. - The `limits.firesPerMinute` represents the allowed namespace trigger firings per minute. - The `limits.sequenceMaxLength` represents the maximum length of a sequence action. + + Set the timezone for containers +The default timezone is `UTC`, which may differ from your servers, and makes it a litter difficult to analyse error logs, the configuration locates in [./group_vars/all](./group_vars/all) and may be changed by modifying the group_vars or by passing extra var to ansible-playbook(`-e docker_timzone=xxx`) for your specific environment. +``` +docker: Review comment: instead of this, I suggest just linking to the line of code in the `all` file below. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on a change in pull request #3955: Add an variable to set the timezone for all of components
csantanapr commented on a change in pull request #3955: Add an variable to set the timezone for all of components URL: https://github.com/apache/incubator-openwhisk/pull/3955#discussion_r208926951 ## File path: ansible/roles/apigateway/tasks/deploy.yml ## @@ -28,3 +29,6 @@ until: result.status == 200 retries: 12 delay: 5 + +- name: install tzdata on apigateway + shell: docker exec apigateway sh -c "apk add -u tzdata && api-gateway -s reload" Review comment: This is a hack, please add the package to the apigateway image in their repo here https://github.com/apache/incubator-openwhisk-apigateway/blob/master/Dockerfile#L27 then you can bump the [version of the apigateway](https://github.com/apache/incubator-openwhisk/blob/master/ansible/group_vars/all#L253) in a subsequent PR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur opened a new issue #3959: Validate API-level tests against Swagger spec
mgencur opened a new issue #3959: Validate API-level tests against Swagger spec URL: https://github.com/apache/incubator-openwhisk/issues/3959 The goal is to include validation of requests and responses (maybe only responses) in *ApiTests which are mostly located under whisk/core/controller package in the test suite. This validation is already in place for the tests in system.basic package. ## Provide the expected results and outputs: ``` The validator should check that request and response conforms to the Swagger spec in core/controller/src/main/resources/apiv1swagger.json ``` ## Additional information you deem important: Some test from the system.basic test suite might be later moved to the API-level tests as long as we have the swagger spec validation in place. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208926172 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with id 5975c24de0114ef2b5c24de0118ef A blocking invocation request will _wait_ for the activation result to be available. The wait period is the lesser of 60 seconds or the action's configured [time limit](reference.md#per-action-timeout-ms-default-60s). -The result of the activation is returned if it is available within the wait period. + +The result of the activation is returned if it is available within the blocking wait period (this wait period is by default 60 seconds as well). Review comment: does it make sense to fold this line into the sentence on 216 - a bit redundant IMO. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208928955 ## File path: docs/actions.md ## @@ -340,7 +344,7 @@ is skipped if an action is dispatched to a previously initialized container --- You can tell if an [invocation was a warm activation or a cold one requiring initialization](annotations.md#annotations-specific-to-activations) by inspecting the activation record. - An action runs for a bounded amount of time. This limit can be configured per action, and applies to both the -initialization and the execution separately. +initialization and the execution separately. If the action time limit is exceeded the activation's response status is _application error_. Review comment: I suggest: If the action time limit is exceeded during initialization, the activation's response status is ... otherwise it is ... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208927670 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with id 5975c24de0114ef2b5c24de0118ef A blocking invocation request will _wait_ for the activation result to be available. The wait period is the lesser of 60 seconds or the action's configured [time limit](reference.md#per-action-timeout-ms-default-60s). -The result of the activation is returned if it is available within the wait period. + +The result of the activation is returned if it is available within the blocking wait period (this wait period is by default 60 seconds as well). Otherwise, the activation continues processing in the system and an activation ID is returned so that one may check for the result later, as with non-blocking requests (see [here](#watching-action-output) for tips on monitoring activations). +If execution of the action exceeds the action's configured time limit within the blocking wait period +the result of the invocation is an error caused by the action timeout and the response status is _application error_. Review comment: I don't think we've explained application error or response status at this point; this happens in the next section (understanding the activation record). How about this: When an action exceeds its configured time lime, the activation record will indicate this error. See [understanding the activation record] for more details. or something to that effect. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208926821 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with id 5975c24de0114ef2b5c24de0118ef A blocking invocation request will _wait_ for the activation result to be available. The wait period is the lesser of 60 seconds or the action's configured [time limit](reference.md#per-action-timeout-ms-default-60s). -The result of the activation is returned if it is available within the wait period. + +The result of the activation is returned if it is available within the blocking wait period (this wait period is by default 60 seconds as well). Otherwise, the activation continues processing in the system and an activation ID is returned so that one may check for the result later, as with non-blocking requests (see [here](#watching-action-output) for tips on monitoring activations). +If execution of the action exceeds the action's configured time limit within the blocking wait period Review comment: If this is strictly intended to explain the activation's response status, then I suggest dropping the sentence on line 224 because what you write next is true for _all_ activations that exceed their configured duration. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208927943 ## File path: docs/actions.md ## @@ -233,8 +240,11 @@ Each action invocation results in an activation record which contains the follow - `response`: A dictionary that defines the following keys - `status`: The activation result, which might be one of the following values: - *"success"*: the action invocation completed successfully. -- *"application error"*: the action invocation was successful, but the action returned an error value on purpose, for instance because a precondition on the arguments was not met. -- *"action developer error"*: the action was invoked, but it completed abnormally, for instance the action did not detect an exception, or a syntax error existed. +- *"application error"*: the action was invoked, but returned an error value on purpose, for instance because a precondition on the arguments was not met. This status code is also returned under specific conditions such as: + - action timed out Review comment: since there's only one other condition, how about: This status code is also set when the action exceeds its configured time limit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208928501 ## File path: docs/actions.md ## @@ -233,8 +240,11 @@ Each action invocation results in an activation record which contains the follow - `response`: A dictionary that defines the following keys - `status`: The activation result, which might be one of the following values: - *"success"*: the action invocation completed successfully. -- *"application error"*: the action invocation was successful, but the action returned an error value on purpose, for instance because a precondition on the arguments was not met. -- *"action developer error"*: the action was invoked, but it completed abnormally, for instance the action did not detect an exception, or a syntax error existed. +- *"application error"*: the action was invoked, but returned an error value on purpose, for instance because a precondition on the arguments was not met. This status code is also returned under specific conditions such as: + - action timed out +- *"action developer error"*: the action was invoked, but it completed abnormally, for instance the action did not detect an exception, or a syntax error existed. This status code is also returned under specific conditions such as: + - wrong docker container name + - initialization of a function failed Review comment: - the function failed to initialize for any reason (including time out) - a Docker action specified the wrong docker container name - a Docker action that does not properly implement the expected runtime protocol (link to actions-new.md)? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3951: Docs fixes for action invocations
rabbah commented on issue #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#issuecomment-411758033 Thanks for improving the docs - this is important and appreciated. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed pull request #3173: incubator-openwhisk-2882 Delete printlns
rabbah closed pull request #3173: incubator-openwhisk-2882 Delete printlns
URL: https://github.com/apache/incubator-openwhisk/pull/3173
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/tests/src/test/scala/whisk/core/database/test/CleanUpActivationsTest.scala
b/tests/src/test/scala/whisk/core/database/test/CleanUpActivationsTest.scala
index f2240427d5..6a838e6e9a 100644
--- a/tests/src/test/scala/whisk/core/database/test/CleanUpActivationsTest.scala
+++ b/tests/src/test/scala/whisk/core/database/test/CleanUpActivationsTest.scala
@@ -49,7 +49,7 @@ class CleanUpActivationsTest
with StreamLogging
with DatabaseScriptTestUtils {
- val testDbPrefix = s"cleanuptest_${dbPrefix}"
+ val testDbPrefix = s"cleanuptest_$dbPrefix"
val cleanUpTool =
WhiskProperties.getFileRelativeToWhiskHome("tools/db/cleanUpActivations.py").getAbsolutePath
val designDocPath = WhiskProperties
.getFileRelativeToWhiskHome("ansible/files/activations_design_document_for_activations_db.json")
@@ -58,14 +58,14 @@ class CleanUpActivationsTest
implicit def toDuration(dur: FiniteDuration) =
java.time.Duration.ofMillis(dur.toMillis)
/** Runs the clean up script to delete old activations */
- def runCleanUpTool(dbUrl: String, dbName: String, days: Int, docsPerRequest:
Int = 200) = {
-println(s"Running clean up tool: $dbUrl, $dbName, $days, $docsPerRequest")
+ def runCleanUpTool(dbUrl: DatabaseUrl, dbName: String, days: Int,
docsPerRequest: Int = 200) = {
+println(s"Running clean up tool: ${dbUrl.safeUrl}, $dbName, $days,
$docsPerRequest")
val cmd = Seq(
python,
cleanUpTool,
"--dbUrl",
- dbUrl,
+ dbUrl.url,
"--dbName",
dbName,
"--days",
diff --git
a/tests/src/test/scala/whisk/core/database/test/DatabaseScriptTestUtils.scala
b/tests/src/test/scala/whisk/core/database/test/DatabaseScriptTestUtils.scala
index 8957736738..b8c341ddf4 100644
---
a/tests/src/test/scala/whisk/core/database/test/DatabaseScriptTestUtils.scala
+++
b/tests/src/test/scala/whisk/core/database/test/DatabaseScriptTestUtils.scala
@@ -36,6 +36,12 @@ import whisk.core.database.CouchDbConfig
trait DatabaseScriptTestUtils extends ScalaFutures with Matchers with WaitFor
with IntegrationPatience {
+ case class DatabaseUrl(dbProtocol: String, dbUsername: String, dbPassword:
String, dbHost: String, dbPort: String) {
+def url = s"$dbProtocol://$dbUsername:$dbPassword@$dbHost:$dbPort"
+
+def safeUrl = s"$dbProtocol://$dbHost:$dbPort"
+ }
+
val python = WhiskProperties.python
val config = loadConfigOrThrow[CouchDbConfig](ConfigKeys.couchdb)
val dbProtocol = config.protocol
@@ -44,14 +50,14 @@ trait DatabaseScriptTestUtils extends ScalaFutures with
Matchers with WaitFor wi
val dbUsername = config.username
val dbPassword = config.password
val dbPrefix = WhiskProperties.getProperty(WhiskConfig.dbPrefix)
- val dbUrl =
s"${dbProtocol}://${dbUsername}:${dbPassword}@${dbHost}:${dbPort}"
+ val dbUrl = DatabaseUrl(dbProtocol, dbUsername, dbPassword, dbHost,
dbPort.toString)
def retry[T](task: => T) = whisk.utils.retry(task, 10,
Some(500.milliseconds))
/** Creates a new database with the given name */
def createDatabase(name: String, designDocPath: Option[String])(implicit as:
ActorSystem, logging: Logging) = {
// Implicitly remove database for sanitization purposes
-removeDatabase(name, true)
+removeDatabase(name, ignoreFailure = true)
println(s"Creating database: $name")
val db = new ExtendedCouchDbRestClient(dbProtocol, dbHost, dbPort,
dbUsername, dbPassword, name)
diff --git
a/tests/src/test/scala/whisk/core/database/test/RemoveLogsTests.scala
b/tests/src/test/scala/whisk/core/database/test/RemoveLogsTests.scala
index fc116d0998..bebb9dd353 100644
--- a/tests/src/test/scala/whisk/core/database/test/RemoveLogsTests.scala
+++ b/tests/src/test/scala/whisk/core/database/test/RemoveLogsTests.scala
@@ -46,14 +46,14 @@ class RemoveLogsTests extends FlatSpec with
DatabaseScriptTestUtils with StreamL
WhiskProperties.getFileRelativeToWhiskHome("tools/db/deleteLogsFromActivations.py").getAbsolutePath
/** Runs the clean up script to delete old activations */
- def removeLogsTool(dbUrl: String, dbName: String, days: Int, docsPerRequest:
Int = 20) = {
-println(s"Running removeLogs tool: $dbUrl, $dbName, $days,
$docsPerRequest")
+ def removeLogsTool(dbUrl: DatabaseUrl, dbName: String, days: Int,
docsPerRequest: Int = 20) = {
+println(s"Running removeLogs tool: ${dbUrl.safeUrl}, $dbName, $days,
$docsPerRequest")
val cmd = Seq(
python,
removeLogsToolPath,
"--dbUrl",
- dbUrl,
+ dbUrl.url,
"--dbName",
dbName,
[GitHub] chetanmeh commented on issue #3958: Add tracing component name to wskadmin-next
chetanmeh commented on issue #3958: Add tracing component name to wskadmin-next URL: https://github.com/apache/incubator-openwhisk/pull/3958#issuecomment-411763212 @markusthoemmes This is due to how currently tracing is configured. It requires a component name which is provided via config. For example Invoker provides it like below https://github.com/apache/incubator-openwhisk/blob/79e72e641703b4138cc58bc6bf0d5863a8fe6919/core/invoker/src/main/resources/application.conf#L71-L74 And similarly Controller provides it in its config. So each new module would need to provide this. Other option can be that we provide a default value in common reference.conf https://github.com/apache/incubator-openwhisk/blob/f593de8614cf51c84ed7e78b27e93f64cda72c75/common/scala/src/main/resources/application.conf#L207-L219 The other module can choose to override it if needed. So we can either keep current fix or do above change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah closed issue #2882: redact information in test log message
rabbah closed issue #2882: redact information in test log message URL: https://github.com/apache/incubator-openwhisk/issues/2882 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #2882: redact information in test log message
rabbah commented on issue #2882: redact information in test log message URL: https://github.com/apache/incubator-openwhisk/issues/2882#issuecomment-411763485 Thanks for the contribution and fix. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3173: incubator-openwhisk-2882 Delete printlns
rabbah commented on issue #3173: incubator-openwhisk-2882 Delete printlns URL: https://github.com/apache/incubator-openwhisk/pull/3173#issuecomment-411764105 @vooolll do you have an Apache CLA? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah edited a comment on issue #3173: incubator-openwhisk-2882 Delete printlns
rabbah edited a comment on issue #3173: incubator-openwhisk-2882 Delete printlns URL: https://github.com/apache/incubator-openwhisk/pull/3173#issuecomment-411764105 @vooolll do you have an Apache CLA on file? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dgrove-oss commented on issue #271: Correctly writing custom OpenWhisk authentication keys (for the guest…
dgrove-oss commented on issue #271: Correctly writing custom OpenWhisk authentication keys (for the guest… URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/271#issuecomment-411770579 Thanks; change makes sense to me. Could you please file an Apache CLA as described here: https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mdeuser closed pull request #3760: Separate routemgmt.yml out from openwhisk.yml playbook
mdeuser closed pull request #3760: Separate routemgmt.yml out from openwhisk.yml playbook URL: https://github.com/apache/incubator-openwhisk/pull/3760 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/ansible/README.md b/ansible/README.md index 04cf9ff18c..d9e4a87ebe 100644 --- a/ansible/README.md +++ b/ansible/README.md @@ -150,27 +150,31 @@ cd ansible ansible-playbook -i environments/ couchdb.yml ansible-playbook -i environments/ initdb.yml ansible-playbook -i environments/ wipe.yml -ansible-playbook -i environments/ apigateway.yml ansible-playbook -i environments/ openwhisk.yml + +# installs a catalog of public packages and actions ansible-playbook -i environments/ postdeploy.yml + +# to use the API gateway +ansible-playbook -i environments/ apigateway.yml +ansible-playbook -i environments/ routemgmt.yml ``` -You need to run `initdb.yml` **every time** you do a fresh deploy CouchDB to initialize the subjects database. -The playbooks `wipe.yml` and `postdeploy.yml` should be run on a fresh deployment only, otherwise all transient -data that include actions and activations are lost. +- You need to run `initdb.yml` **every time** you do a fresh deploy CouchDB to initialize the subjects database. +- The `wipe.yml` playbook should be run on a fresh deployment only, otherwise actions and activations will be lost. +- Run `postdeploy.yml` after deployment to install a catalog of useful packages. +- To use the API Gateway, you'll need to run `apigateway.yml` and `routemgmt.yml`. +- Use `ansible-playbook -i environments/ openwhisk.yml` to avoid wiping the data store. This is useful to start OpenWhisk after restarting your Operating System. Limitation -You can not run multiple CouchDB nodes on a single machine. -This limitation comes from Erlang EPMD. -When CouchDB forms a cluster, it counts on EPMD to find other nodes. -If we want to run multiple nodes on a single machine, we must differentiate EPMD port(`4369`) for each nodes. But if this port is different on each nodes, they cannot find each other. -So if you want to deploy multiple CouchDB nodes, all nodes should be placed on different machines respectively. +You cannot run multiple CouchDB nodes on a single machine. This limitation comes from Erlang EPMD which CouchDB relies on to find other nodes. +To deploy multiple CouchDB nodes, they should be placed on different machines respectively otherwise their ports will clash. ### Deploying Using Cloudant -- Make sure your `db_local.ini` file is set up for Cloudant. See [Setup](#setup) -- Then execute +- Make sure your `db_local.ini` file is set up for Cloudant. See [Setup](#setup). +- Then execute: ``` cd @@ -180,16 +184,21 @@ ansible-playbook -i environments/ initdb.yml ansible-playbook -i environments/ wipe.yml ansible-playbook -i environments/ apigateway.yml ansible-playbook -i environments/ openwhisk.yml -ansible-playbook -i environments/ postdeploy.yml -``` -You need to run `initdb` on Cloudant **only once** per Cloudant database to initialize the subjects database. -The `initdb.yml` playbook will only initialize your database if it is not initialized already, else it will skip initialization steps. +# installs a catalog of public packages and actions +ansible-playbook -i environments/ postdeploy.yml -The playbooks `wipe.yml` and `postdeploy.yml` should be run on a fresh deployment only, otherwise all transient -data that include actions and activations are lost. +# to use the API gateway +ansible-playbook -i environments/ apigateway.yml +ansible-playbook -i environments/ routemgmt.yml +``` -Use `ansible-playbook -i environments/ openwhisk.yml` to avoid wiping the data store. This is useful to start OpenWhisk after restarting your Operating System. +- You need to run `initdb` on Cloudant **only once** per Cloudant database to initialize the subjects database. +- The `initdb.yml` playbook will only initialize your database if it is not initialized already, else it will skip initialization steps. +- The `wipe.yml` playbook should be run on a fresh deployment only, otherwise actions and activations will be lost. +- Run `postdeploy.yml` after deployment to install a catalog of useful packages. +- To use the API Gateway, you'll need to run `apigateway.yml` and `routemgmt.yml`. +- Use `ansible-playbook -i environments/ openwhisk.yml` to avoid wiping the data store. This is useful to start OpenWhisk after restarting your Operating System. ### Configuring the installation of `wsk` CLI There are two installation modes to install `wsk` CLI: remote and local. diff --git a/ansible/README_DISTRIBUTED.md b/ansible/README_DISTRIBUTED.md index 2aa408e451..3b859ad6be 100644 --- a/ansible/README_DISTRIBUTED.md +++
[GitHub] fmaschler opened a new pull request #147: Use 0.9.0 release as default sources
fmaschler opened a new pull request #147: Use 0.9.0 release as default sources URL: https://github.com/apache/incubator-openwhisk-devtools/pull/147 Now with the first official release one could use that to download sources in the quick-start deployment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah edited a comment on issue #3173: incubator-openwhisk-2882 Delete printlns
rabbah edited a comment on issue #3173: incubator-openwhisk-2882 Delete printlns URL: https://github.com/apache/incubator-openwhisk/pull/3173#issuecomment-411764105 @vooolll do you have an Apache CLA on file? Could you please file an Apache CLA as described here: https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md otherwise. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208947806 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with id 5975c24de0114ef2b5c24de0118ef A blocking invocation request will _wait_ for the activation result to be available. The wait period is the lesser of 60 seconds or the action's configured [time limit](reference.md#per-action-timeout-ms-default-60s). -The result of the activation is returned if it is available within the wait period. + +The result of the activation is returned if it is available within the blocking wait period (this wait period is by default 60 seconds as well). Review comment: AFAIK, the action default timeout is 60 seconds, the blocking wait timeout is by default 60 as well. It could certainly be worded differently but I think it's good as it is. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208948137 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with id 5975c24de0114ef2b5c24de0118ef A blocking invocation request will _wait_ for the activation result to be available. The wait period is the lesser of 60 seconds or the action's configured [time limit](reference.md#per-action-timeout-ms-default-60s). -The result of the activation is returned if it is available within the wait period. + +The result of the activation is returned if it is available within the blocking wait period (this wait period is by default 60 seconds as well). Otherwise, the activation continues processing in the system and an activation ID is returned so that one may check for the result later, as with non-blocking requests (see [here](#watching-action-output) for tips on monitoring activations). +If execution of the action exceeds the action's configured time limit within the blocking wait period Review comment: Unless the configured time limit is longer than 60 seconds and the blocking wait time is the default. In this case it returns 202 as you said previously? Curious... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #7: remove hardcoded env variables for run handler
csantanapr opened a new pull request #7: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-ballerina/pull/7 This allows for a customized invoker with an SPI to send more variables in the run handler This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208948722 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with id 5975c24de0114ef2b5c24de0118ef A blocking invocation request will _wait_ for the activation result to be available. The wait period is the lesser of 60 seconds or the action's configured [time limit](reference.md#per-action-timeout-ms-default-60s). -The result of the activation is returned if it is available within the wait period. + +The result of the activation is returned if it is available within the blocking wait period (this wait period is by default 60 seconds as well). Review comment: just seems redundant as line 217 already says 60 seconds (you can add this is the default there) and strictly not correct since an action with a timeout less than 60s for an action, it's a little confusing as worded. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr commented on issue #7: remove hardcoded env variables for run handler
csantanapr commented on issue #7: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-ballerina/pull/7#issuecomment-411775479 @eweiter could you review this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208948995 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with id 5975c24de0114ef2b5c24de0118ef A blocking invocation request will _wait_ for the activation result to be available. The wait period is the lesser of 60 seconds or the action's configured [time limit](reference.md#per-action-timeout-ms-default-60s). -The result of the activation is returned if it is available within the wait period. + +The result of the activation is returned if it is available within the blocking wait period (this wait period is by default 60 seconds as well). Otherwise, the activation continues processing in the system and an activation ID is returned so that one may check for the result later, as with non-blocking requests (see [here](#watching-action-output) for tips on monitoring activations). +If execution of the action exceeds the action's configured time limit within the blocking wait period +the result of the invocation is an error caused by the action timeout and the response status is _application error_. Review comment: Could be. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208949514 ## File path: docs/actions.md ## @@ -233,8 +240,11 @@ Each action invocation results in an activation record which contains the follow - `response`: A dictionary that defines the following keys - `status`: The activation result, which might be one of the following values: - *"success"*: the action invocation completed successfully. -- *"application error"*: the action invocation was successful, but the action returned an error value on purpose, for instance because a precondition on the arguments was not met. -- *"action developer error"*: the action was invoked, but it completed abnormally, for instance the action did not detect an exception, or a syntax error existed. +- *"application error"*: the action was invoked, but returned an error value on purpose, for instance because a precondition on the arguments was not met. This status code is also returned under specific conditions such as: + - action timed out +- *"action developer error"*: the action was invoked, but it completed abnormally, for instance the action did not detect an exception, or a syntax error existed. This status code is also returned under specific conditions such as: + - wrong docker container name + - initialization of a function failed Review comment: ok This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mgencur commented on a change in pull request #3951: Docs fixes for action invocations
mgencur commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208949464 ## File path: docs/actions.md ## @@ -233,8 +240,11 @@ Each action invocation results in an activation record which contains the follow - `response`: A dictionary that defines the following keys - `status`: The activation result, which might be one of the following values: - *"success"*: the action invocation completed successfully. -- *"application error"*: the action invocation was successful, but the action returned an error value on purpose, for instance because a precondition on the arguments was not met. -- *"action developer error"*: the action was invoked, but it completed abnormally, for instance the action did not detect an exception, or a syntax error existed. +- *"application error"*: the action was invoked, but returned an error value on purpose, for instance because a precondition on the arguments was not met. This status code is also returned under specific conditions such as: + - action timed out Review comment: ok This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on a change in pull request #3951: Docs fixes for action invocations
rabbah commented on a change in pull request #3951: Docs fixes for action invocations URL: https://github.com/apache/incubator-openwhisk/pull/3951#discussion_r208949761 ## File path: docs/actions.md ## @@ -216,10 +216,17 @@ ok: invoked /whisk.system/samples/greeting with id 5975c24de0114ef2b5c24de0118ef A blocking invocation request will _wait_ for the activation result to be available. The wait period is the lesser of 60 seconds or the action's configured [time limit](reference.md#per-action-timeout-ms-default-60s). -The result of the activation is returned if it is available within the wait period. + +The result of the activation is returned if it is available within the blocking wait period (this wait period is by default 60 seconds as well). Otherwise, the activation continues processing in the system and an activation ID is returned so that one may check for the result later, as with non-blocking requests (see [here](#watching-action-output) for tips on monitoring activations). +If execution of the action exceeds the action's configured time limit within the blocking wait period Review comment: There are two things at play: 1. the HTTP response to the client: if the action has not finished in 60 seconds, the status code is 202 and an activation id is returned 2. in all cases (unless the system fails to generate one), the activation record for an action is created and recorded, and if the action timed out, the response status will be application error (for run) or developer error (for init). Is that clearer? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3919: Allow raw JSON string as response for webaction without base64 encoding.
codecov-io edited a comment on issue #3919: Allow raw JSON string as response for webaction without base64 encoding. URL: https://github.com/apache/incubator-openwhisk/pull/3919#issuecomment-409779533 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=h1) Report > Merging [#3919](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/79e72e641703b4138cc58bc6bf0d5863a8fe6919?src=pr&el=desc) will **decrease** coverage by `4.78%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3919 +/- ## == - Coverage 85.54% 80.75% -4.79% == Files 146 146 Lines7057 7057 Branches 420 411 -9 == - Hits 6037 5699 -338 - Misses 1020 1358 +338 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [.../main/scala/whisk/core/controller/WebActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9XZWJBY3Rpb25zLnNjYWxh) | `91.01% <100%> (-0.4%)` | :arrow_down: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `75.67% <0%> (-16.22%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=footer). Last update [79e72e6...feea3f6](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #10: remove hardcoded env variables for run handler
csantanapr opened a new pull request #10: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-ruby/pull/10 This allows for the customized invoker with an SPI to send more variables in the run handler @eweiter could you review this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #67: remove hardcoded env variables for run handler
csantanapr opened a new pull request #67: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/67 This allows for the customized invoker with an SPI to send more variables in the run handler @eweiter could you review this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pritidesai closed pull request #291: ADjust colors for yaml and bash; add bash highlighting
pritidesai closed pull request #291: ADjust colors for yaml and bash; add bash
highlighting
URL: https://github.com/apache/incubator-openwhisk-website/pull/291
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/_layouts/documentation.html b/_layouts/documentation.html
index 39e774c..c0c5fb8 100644
--- a/_layouts/documentation.html
+++ b/_layouts/documentation.html
@@ -159,9 +159,11 @@ Docker Compose
The easiest way to start deploying OpenWhisk is to get Docker
installed on Mac, Windows or Linux.
This does not give you a production deployment but gives you
enough of the pieces to start writing functions and seeing them executing.
-git clone https://github.com/apache/incubator-openwhisk-devtools.git
-cd incubator-openwhisk-devtools/docker-compose
-make quick-start
+{% highlight bash %}
+$ git clone https://github.com/apache/incubator-openwhisk-devtools.git
+$ cd incubator-openwhisk-devtools/docker-compose
+$ make quick-start
+{% endhighlight %}
For more detailed instructions, see the
@@ -295,23 +297,26 @@ Configure the wsk CLI
To get the CLI command help, execute the following command:
-wsk --help
+{% highlight bash %}$ wsk --help{% endhighlight %}
-
Authenticate wsk
CLI
You can configure wsk CLI to use your OpenWhisk credentials
in few different ways:
With wsk property setup
Run the following command to set whisk API HOST and
authorization key to create the configuration file:
-wsk property set --apihost --auth
--namespace guest
+{% highlight bash %}
+$ wsk property set --apihost --auth --namespace guest
+{% endhighlight %}
Credentials are stored in ~/.wskprops, which you
can edit directly if needed.
Environment Variables Setup
Access credentials can be provided using properties
file as environment variable:
-export WSK_CONFIG_FILE=
-wsk list
+{% highlight bash %}
+$ export WSK_CONFIG_FILE=
+$ wsk list
+{% endhighlight %}
@@ -334,9 +339,8 @@ Whisk Deploy
Start by verifying the utility can display the command
line help:
-wskdeploy --help
+{% highlight bash %}$ wskdeploy --help{% endhighlight %}
-
Create Package Manifest File manifest.yaml:
Please refer to the
@@ -351,7 +355,7 @@ Whisk Deploy
here.
Deploying an OpenWhisk Manifest file:
-wskdeploy -m manifest.yaml
+{% highlight bash %}$ wskdeploy -m manifest.yaml{% endhighlight %}
@@ -467,23 +471,24 @@ Creating and Invoking NodeJS actions
Create an action
called helloJS using hello.js:
-wsk action create helloJS hello.js
+{% highlight bash %}$ wsk action create helloJS hello.js{% endhighlight %}
ok: created action helloJS
Invoke the
helloJS action as a blocking activation:
-wsk action invoke helloJS --blocking
+{% highlight bash %}$ wsk action invoke helloJS --blocking{% endhighlight %}
-{
-"result": {
-"payload": "Hello world"
-},
-"status": "success",
-"success": true
-}
+{% highlight yaml %}
+{
+ "result": {
+ "payload": "Hello world"
+},
+"status": "success",
+"success": true
+}{% endhighlight %}
Deploy using
wskdeploy:
@@ -506,7 +511,7 @@ Creating and Invoking NodeJS actions
Run deployment with wskdeploy:
-wskdeploy -m manifest.yaml
+{% highlight bash %}$ wskdeploy -m manifest.yaml{% endhighlight %}
@@ -556,19 +561,21 @@ Creating And Invoking Python actions
Create an action
called helloPy using hello.py:
-wsk action create helloPy hello.py
+{% highlight bash %}$ wsk action create helloPy hello.py{% endhighlight %}
ok: created a
[GitHub] csantanapr opened a new pull request #55: remove hardcoded env variables for run handler
csantanapr opened a new pull request #55: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/55 This allows for the customized invoker with an SPI to send more variables in the run handler @eweiter could you review this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] csantanapr opened a new pull request #78: remove hardcoded env variables for run handler
csantanapr opened a new pull request #78: remove hardcoded env variables for run handler URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/78 This allows for the customized invoker with an SPI to send more variables in the run handler @eweiter could you review this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io edited a comment on issue #3919: Allow raw JSON string as response for webaction without base64 encoding.
codecov-io edited a comment on issue #3919: Allow raw JSON string as response for webaction without base64 encoding. URL: https://github.com/apache/incubator-openwhisk/pull/3919#issuecomment-409779533 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=h1) Report > Merging [#3919](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/79e72e641703b4138cc58bc6bf0d5863a8fe6919?src=pr&el=desc) will **decrease** coverage by `4.78%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#3919 +/- ## == - Coverage 85.54% 80.75% -4.79% == Files 146 146 Lines7057 7057 Branches 420 411 -9 == - Hits 6037 5699 -338 - Misses 1020 1358 +338 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [.../main/scala/whisk/core/controller/WebActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvY29udHJvbGxlci9XZWJBY3Rpb25zLnNjYWxh) | `91.01% <100%> (-0.4%)` | :arrow_down: | | [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: | | [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.1%)` | :arrow_down: | | [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.6%)` | :arrow_down: | | [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-81.82%)` | :arrow_down: | | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `0% <0%> (-58.83%)` | :arrow_down: | | [...whisk/connector/kafka/KafkaProducerConnector.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2Nvbm5lY3Rvci9rYWZrYS9LYWZrYVByb2R1Y2VyQ29ubmVjdG9yLnNjYWxh) | `75.67% <0%> (-16.22%)` | :arrow_down: | | [...la/whisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL3doaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `92% <0%> (-4%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=footer). Last update [79e72e6...feea3f6](https://codecov.io/gh/apache/incubator-openwhisk/pull/3919?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] junoyoon commented on issue #3880: Modify that web action in the bound package can be accessed.
junoyoon commented on issue #3880: Modify that web action in the bound package can be accessed. URL: https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-411795589 @upgle is it done? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rabbah commented on issue #3880: Modify that web action in the bound package can be accessed.
rabbah commented on issue #3880: Modify that web action in the bound package can be accessed. URL: https://github.com/apache/incubator-openwhisk/pull/3880#issuecomment-411796869 The last commit looks a lot better now - I'll review more thoroughly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee closed pull request #3919: Allow raw JSON string as response for webaction without base64 encoding.
dubee closed pull request #3919: Allow raw JSON string as response for
webaction without base64 encoding.
URL: https://github.com/apache/incubator-openwhisk/pull/3919
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core/controller/src/main/scala/whisk/core/controller/WebActions.scala
b/core/controller/src/main/scala/whisk/core/controller/WebActions.scala
index e195561b04..6015525511 100644
--- a/core/controller/src/main/scala/whisk/core/controller/WebActions.scala
+++ b/core/controller/src/main/scala/whisk/core/controller/WebActions.scala
@@ -324,12 +324,10 @@ protected[core] object WhiskWebActionsApi extends
Directives {
findContentTypeInHeader(headers, transid, `text/html`).flatMap { mediaType
=>
val ct = ContentType(mediaType, () => HttpCharsets.`UTF-8`)
ct match {
-// base64 encoded json will appear as non-binary but it is excluded
here for legacy reasons
-case nonbinary: ContentType.NonBinary if !isJsonFamily(mediaType) =>
Success(HttpEntity(nonbinary, str))
+case nonbinary: ContentType.NonBinary => Success(HttpEntity(nonbinary,
str))
// because of the default charset provided to the content type
constructor
-// the remaining content types to match against are binary at this
point, or
-// the legacy base64 encoded json
+// the remaining content types to match against are binary at this
point
case _ /* ContentType.Binary */ =>
Try(Base64.getDecoder().decode(str)).map(HttpEntity(ct, _))
}
} match {
@@ -592,7 +590,7 @@ trait WhiskWebActionsApi extends Directives with
ValidateRequestSize with PostAc
}
case HttpEntity.Strict(contentType, data) =>
- // application/json is not a binary type in Akka, but is binary in
Spray
+ // for legacy, we are encoding application/json still
if (contentType.mediaType.binary || contentType.mediaType ==
`application/json`) {
Try(JsString(Base64.getEncoder.encodeToString(data.toArray)))
match {
case Success(bytes) => process(Some(bytes), isRawHttpAction)
diff --git a/core/routemgmt/common/apigw-utils.js
b/core/routemgmt/common/apigw-utils.js
index 84d4104c15..a4eebbc4be 100644
--- a/core/routemgmt/common/apigw-utils.js
+++ b/core/routemgmt/common/apigw-utils.js
@@ -529,8 +529,6 @@ function addEndpointToSwaggerApi(swaggerApi, endpoint,
responsetype) {
responsetype = responsetype || 'json';
console.log('addEndpointToSwaggerApi: operationid = '+operationId);
try {
-var auth_base64 =
Buffer.from(endpoint.action.authkey,'ascii').toString('base64');
-
// If the relative path already exists, append to it; otherwise create it
if (!swaggerApi.paths[endpoint.gatewayPath]) {
swaggerApi.paths[endpoint.gatewayPath] = {};
@@ -890,7 +888,7 @@ function replaceNamespaceInUrl(url, namespace) {
* {
*statusCode: 502,<- signifies an application error
*headers: {'Content-Type': 'application/json'},
- *body: Base64 encoded JSON error string
+ *body: JSON object or JSON string
* }
* Otherwise, the action was invoked as a regular OpenWhisk action
* (i.e. https://OW-HOST/api/v1/namesapces/NS/actions/ACTION) and the
@@ -909,18 +907,16 @@ function makeErrorResponseObject(err, isWebAction) {
return err;
}
- var bodystr;
+ var bodystr = err;
if (typeof err === 'string') {
-bodystr = JSON.stringify({
+bodystr = {
"error": JSON.parse(makeJsonString(err)), // Make sure err is plain old
string to avoid duplicate JSON escaping
-});
- } else {
-bodystr = JSON.stringify(err);
+};
}
return {
statusCode: 502,
headers: { 'Content-Type': 'application/json' },
-body: new Buffer(bodystr).toString('base64'),
+body: bodystr
};
}
@@ -935,7 +931,7 @@ function makeErrorResponseObject(err, isWebAction) {
* {
*statusCode: 200,<- signifies a successful action
*headers: {'Content-Type': 'application/json'},
- *body: Base64 encoded JSON error string
+ *body: JSON object or JSON string
* }
* Otherwise, the action was invoked as a regular OpenWhisk action
* (i.e. https://OW-HOST/api/v1/namesapces/NS/actions/ACTION) and the
@@ -950,20 +946,18 @@ function makeErrorResponseObject(err, isWebAction) {
function makeResponseObject(resp, isWebAction) {
console.log('makeResponseObject: isWebAction: '+isWebAction);
if (!isWebAction) {
-console.log('makeErrorResponseObject: not called as a web action');
+console.log('makeResponseObject: not called as a web action');
return resp;
}
- var bodystr;
+ var bodystr = resp;
if (typeof resp === 'string') {
-bodystr = make
[GitHub] dubee commented on issue #3173: incubator-openwhisk-2882 Delete printlns
dubee commented on issue #3173: incubator-openwhisk-2882 Delete printlns URL: https://github.com/apache/incubator-openwhisk/pull/3173#issuecomment-411853578 This could have used a PG. Looks like upstream dependancies are broken as a result of these changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #284: Add code highlighting
mrutkows closed issue #284: Add code highlighting URL: https://github.com/apache/incubator-openwhisk-website/issues/284 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #284: Add code highlighting
mrutkows commented on issue #284: Add code highlighting URL: https://github.com/apache/incubator-openwhisk-website/issues/284#issuecomment-411858817 We added syntax highlighting using Jekyll Rouge and Pygmentation based CSS See PR: https://github.com/apache/incubator-openwhisk-website/pull/290 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #274: Need to provide links/method to point to releases
mrutkows commented on issue #274: Need to provide links/method to point to releases URL: https://github.com/apache/incubator-openwhisk-website/issues/274#issuecomment-411860127 IMO, we should do a "dropdown" from the "Downloads" menu on the home page like shown here: https://kubernetes.io/ with a menu of versioned releases ... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #270: Create README Templates for Deployment methods
mrutkows commented on issue #270: Create README Templates for Deployment methods URL: https://github.com/apache/incubator-openwhisk-website/issues/270#issuecomment-411861632 We should reach out to Dave Grove, Brendan/Ben and Dragos when developing the template (perhaps not all at once but iterate with them over time. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #268: Add Quotes (somewhere) and remove old pages
mrutkows commented on issue #268: Add Quotes (somewhere) and remove old pages URL: https://github.com/apache/incubator-openwhisk-website/issues/268#issuecomment-411861876 Perhaps add to the "Community" page? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #268: Add Quotes (somewhere) and remove old pages
mrutkows commented on issue #268: Add Quotes (somewhere) and remove old pages URL: https://github.com/apache/incubator-openwhisk-website/issues/268#issuecomment-411862139 Quotes are problematic since we have no means to keep them current and the ones we have are over 2+ years old and 1/3 are anonymous. That is really not imparting much of a testimonial. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #255: WHAT, HOW, WHY Install OpenWhisk on the main page.
mrutkows closed issue #255: WHAT, HOW, WHY Install OpenWhisk on the main page. URL: https://github.com/apache/incubator-openwhisk-website/issues/255 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #255: WHAT, HOW, WHY Install OpenWhisk on the main page.
mrutkows commented on issue #255: WHAT, HOW, WHY Install OpenWhisk on the main page. URL: https://github.com/apache/incubator-openwhisk-website/issues/255#issuecomment-411865132 With the redesign of website I believe we fixed all these issues. If we missed any, I would suggest opening individual/granular issues for us to address against the new content. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #292: Project Website requires License page (or link to)
mrutkows opened a new issue #292: Project Website requires License page (or link to) URL: https://github.com/apache/incubator-openwhisk-website/issues/292 See Apache Spark (for ideas..): https://spark.apache.org/ With the "Apache Software Foundation" menu and drop-down with "License" that links to the Apache hosted copy of the 2.0 license .. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #292: Project Website requires License page (or link to)
mrutkows commented on issue #292: Project Website requires License page (or link to) URL: https://github.com/apache/incubator-openwhisk-website/issues/292#issuecomment-411868610 We should likely look at using the Footer more, especially since upon graduation the disclaimer goes away and then we have simply a blue rectangle (empty). Perhaps the license stmt. can go here... it fulfills the ASF requirement, yet does not take up real estate in the Header. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dubee commented on issue #3941: to address #3918, reuse a container on applicationError
dubee commented on issue #3941: to address #3918, reuse a container on applicationError URL: https://github.com/apache/incubator-openwhisk/pull/3941#issuecomment-411868731 @csantanapr any comments on this one? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #219: Add IBM logo to supporters web page
mrutkows commented on issue #219: Add IBM logo to supporters web page URL: https://github.com/apache/incubator-openwhisk-website/issues/219#issuecomment-411868859 Added the IBM Logo (with hyperlink to IBM Cloud Functions as part of the redesign dropped Aug. 2018. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #219: Add IBM logo to supporters web page
mrutkows closed issue #219: Add IBM logo to supporters web page URL: https://github.com/apache/incubator-openwhisk-website/issues/219 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #293: Need list (or link to one) of all project Committers as per ASF reqs.
mrutkows opened a new issue #293: Need list (or link to one) of all project Committers as per ASF reqs. URL: https://github.com/apache/incubator-openwhisk-website/issues/293 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows opened a new issue #294: Need FAQ to adhere to ASF reqs.
mrutkows opened a new issue #294: Need FAQ to adhere to ASF reqs. URL: https://github.com/apache/incubator-openwhisk-website/issues/294 Perhaps provide a link from Documentation page? [] FAQ: frequently asked questions are answered here. the old FAQ (before redesign) was not very useful, we need one that is better in quality. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #294: Need FAQ to adhere to ASF reqs.
mrutkows commented on issue #294: Need FAQ to adhere to ASF reqs. URL: https://github.com/apache/incubator-openwhisk-website/issues/294#issuecomment-411871034 Note Spark, has a Menuitem "FAQ" (under Documentation menu), perhaps we can simply link on our main Documentation page? https://spark.apache.org/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #241: Revisit the web site Incubator graduation checklist, and add issues as needed
mrutkows commented on issue #241: Revisit the web site Incubator graduation checklist, and add issues as needed URL: https://github.com/apache/incubator-openwhisk-website/issues/241#issuecomment-411872137 Added individual issues against the recommended checklist. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #241: Revisit the web site Incubator graduation checklist, and add issues as needed
mrutkows closed issue #241: Revisit the web site Incubator graduation checklist, and add issues as needed URL: https://github.com/apache/incubator-openwhisk-website/issues/241 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows closed issue #222: Verify Ruby installed command not correct for OSX (homebrew)
mrutkows closed issue #222: Verify Ruby installed command not correct for OSX (homebrew) URL: https://github.com/apache/incubator-openwhisk-website/issues/222 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #212: Update Apache Incubator logo
mrutkows commented on issue #212: Update Apache Incubator logo URL: https://github.com/apache/incubator-openwhisk-website/issues/212#issuecomment-411872887 With the website redesign, I would recommend placing the "incubator" logo in the Footer (alongside the disclaimer). See http://incubator.apache.org/guides/press-kit.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #220: Add dates/links for China OpenWhisk Academy events / videos / slides /transcripts
mrutkows commented on issue #220: Add dates/links for China OpenWhisk Academy events / videos / slides /transcripts URL: https://github.com/apache/incubator-openwhisk-website/issues/220#issuecomment-411873662 We REALLY need a means to submit (email/form requests) for submitting not only News, but also content, and requests for use of logo or to be added to Supporters page. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #220: Add dates/links for China OpenWhisk Academy events / videos / slides /transcripts
mrutkows commented on issue #220: Add dates/links for China OpenWhisk Academy events / videos / slides /transcripts URL: https://github.com/apache/incubator-openwhisk-website/issues/220#issuecomment-411875210 Perhaps add an invitation at the top of the Community page like: News and Events Please let us know if you have any news or events you would to share with the communoty and publisize. Email us at: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows edited a comment on issue #220: Add dates/links for China OpenWhisk Academy events / videos / slides /transcripts
mrutkows edited a comment on issue #220: Add dates/links for China OpenWhisk Academy events / videos / slides /transcripts URL: https://github.com/apache/incubator-openwhisk-website/issues/220#issuecomment-411875210 Perhaps add an invitation at the top of the Community page like: **News and Events** _Please let us know if you have any news or events you would to share with the communoty and publicize._ Email us at: private@ NOTE: we can always goto Apache Infra. and create a new email list name like "reque...@openwhisk.incubator.apache.org" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #217: Update GitHub link to Apache org. and suggest new page for "code" (repos).
mrutkows commented on issue #217: Update GitHub link to Apache org. and suggest new page for "code" (repos). URL: https://github.com/apache/incubator-openwhisk-website/issues/217#issuecomment-411877331 How do we do something like this: https://cwiki.apache.org/confluence/display/OPENWHISK/Subproject+listing in the Documentation page? Section "Project structure" - List of repos. (as in Wiki) Also see ,main repo. README: https://github.com/apache/incubator-openwhisk Repository Structure The OpenWhisk system is built from a number of components. The picture below groups the components by their GitHub repos. Please open issues for a component against the appropriate repo (if in doubt just open against the main openwhisk repo). component/repo mapping This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrutkows commented on issue #217: Update GitHub link to Apache org. and suggest new page for "code" (repos).
mrutkows commented on issue #217: Update GitHub link to Apache org. and suggest new page for "code" (repos). URL: https://github.com/apache/incubator-openwhisk-website/issues/217#issuecomment-411877467 link to https://github.com/apache/incubator-openwhisk/blob/master/docs/dev/modules.md and update to make more current. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bbrowning commented on issue #3772: Update kubectl version in invoker Dockerfile
bbrowning commented on issue #3772: Update kubectl version in invoker Dockerfile URL: https://github.com/apache/incubator-openwhisk/pull/3772#issuecomment-411899256 Bumping the Kube version makes sense to me. I'll let @bwmcadams do the review and merge dance. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ddragosd commented on issue #147: Use 0.9.0 release as default sources
ddragosd commented on issue #147: Use 0.9.0 release as default sources URL: https://github.com/apache/incubator-openwhisk-devtools/pull/147#issuecomment-411900387 @fmaschler great idea. Can we make the version variable so one can continue to run with the master too ? For Travis in particular, getting the build to fail when an upstream change is made in master is a great way to keep this current. WDYT ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
