Re: [PR] Bump org.scala-lang:scala-library from 2.13.8 to 2.13.9 in /java/bench [orc]
cxzl25 commented on PR #1913: URL: https://github.com/apache/orc/pull/1913#issuecomment-2076331019 Spark 3.5 use `2.13.8` https://github.com/apache/spark/blob/branch-3.5/pom.xml#L3657 ```xml 2.13.8 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.scala-lang:scala-library from 2.13.8 to 2.13.9 in /java/bench [orc]
dependabot[bot] opened a new pull request, #1913: URL: https://github.com/apache/orc/pull/1913 Bumps [org.scala-lang:scala-library](https://github.com/scala/scala) from 2.13.8 to 2.13.9. Release notes Sourced from https://github.com/scala/scala/releases";>org.scala-lang:scala-library's releases. Scala 2.13.9 The following changes are highlights of this release: Regression Library maintainers should avoid publishing libraries using Scala 2.13.9. Please use https://github.com/scala/scala/releases/v2.13.10";>2.13.10 instead. 2.13.9 has a https://redirect.github.com/scala/bug/issues/12650";>regression where binary-incompatible bytecode is emitted for case classes which are also value classes (case class ... extends AnyVal). Compatibility with Scala 3 Tasty Reader: Add support for Scala 3.2 (https://redirect.github.com/scala/scala/pull/10068";>#10068) Tasty Reader: Restrict access to experimental definitions (https://redirect.github.com/scala/scala/pull/10020";>#10020) To aid cross-building, accept and ignore using in method calls (https://redirect.github.com/scala/scala/pull/10064";>#10064 by https://github.com/som-snytt";>@som-snytt) To aid cross-building, allow ? as a wildcard even without -Xsource:3 (https://redirect.github.com/scala/scala/pull/9990";>#9990) Make Scala-3-style implicit resolution explicitly opt-in rather than bundled in -Xsource:3 (https://redirect.github.com/scala/scala/pull/10012";>#10012 by https://github.com/povder";>@povder) Prefer type of overridden member when inferring (under -Xsource:3) (https://redirect.github.com/scala/scala/pull/9891";>#9891 by https://github.com/som-snytt";>@som-snytt) JDK version support Make -release more useful, deprecate -target, align with Scala 3 (https://redirect.github.com/scala/scala/pull/9982";>#9982 by https://github.com/som-snytt";>@som-snytt) Support JDK 19 (https://redirect.github.com/scala/scala/pull/10001";>#10001 by https://github.com/Philippus";>@Philippus) Warnings and lints Add -Wnonunit-statement to warn about discarded values in statement position (https://redirect.github.com/scala/scala/pull/9893";>#9893 by https://github.com/som-snytt";>@som-snytt) Make unused-import warnings easier to silence (support filtering by origin=) (https://redirect.github.com/scala/scala/pull/9939";>#9939 by https://github.com/som-snytt";>@som-snytt) Add -Wperformance lints for *Ref boxing and nonlocal return (https://redirect.github.com/scala/scala/pull/9889";>#9889 by https://github.com/som-snytt";>@som-snytt) Language improvements Improve support for Unicode supplementary characters in identifiers and string interpolation (https://redirect.github.com/scala/scala/pull/9805";>#9805 by https://github.com/som-snytt";>@som-snytt) Compiler options Use subcolon args to simplify optimizer options (https://redirect.github.com/scala/scala/pull/9810";>#9810 by https://github.com/som-snytt";>@som-snytt) For troubleshooting compiler, add -Vdebug-type-error (and remove -Yissue-debug) (https://redirect.github.com/scala/scala/pull/9824";>#9824 by https://github.com/tribbloid";>@tribbloid) Security Error on source files with Unicode directional formatting characters (https://redirect.github.com/scala/scala/pull/10017";>#10017) Prevent Function0 execution during LazyList deserialization (https://redirect.github.com/scala/scala/pull/10118";>#10118) Bugfixes Emit all bridge methods non-final (perhaps affecting serialization compat) (https://redirect.github.com/scala/scala/pull/9976";>#9976) Fix null-pointer regression in Vector#prependedAll and Vector#appendedAll (https://redirect.github.com/scala/scala/pull/9983";>#9983) Improve concurrent behavior of Java ConcurrentMap wrapper (https://redirect.github.com/scala/scala/pull/10027";>#10027 by https://github.com/igabaydulin";>@igabaydulin) Preserve null policy in wrapped Java Maps (https://redirect.github.com/scala/scala/pull/10129";>#10129 by https://github.com/som-snytt";>@som-snytt) Changes that shipped in Scala 2.12.16 and 2.12.17 are also included in this release. ... (truncated) Commits https://github.com/scala/scala/commit/986dcc160aab85298f6cab0bf8dd0345497cdc01";>986dcc1 Merge pull request https://redirect.github.com/scala/scala/issues/10129";>#10129 from som-snytt/followup/12586-preserve-NPE https://github.com/scala/scala/commit/b824b84c4ea93cc1490b3172b0684539fcd99a25";>b824b84 Preserve null policy in wrapped Java Map https://github.com/scala/scala/commit/d578a02ea6b41b662072759c82c19f9309a15176";>d578a02 Merge pull request https://redirect.github.com/scala/scala/issues/10128";>#10128 from SethTisue/revert-10114-10123 https://github.com/scala/scala/commit/e5fe9193d520f8e611244101e95a85a51067f79d";>e5fe919 Revert "Args files are 1 arg per line, fix -Vprint-args -" htt
Re: [PR] ORC-1704: Migration to Scala 2.13 of Apache Spark 3.5.1 at SparkBenchmark [orc]
dongjoon-hyun commented on PR #1912: URL: https://github.com/apache/orc/pull/1912#issuecomment-2076325131 Merged to main/2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (ORC-1704) Migration to Scala 2.13 of Apache Spark 3.5.1 at SparkBenchmark
[ https://issues.apache.org/jira/browse/ORC-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun resolved ORC-1704. Fix Version/s: 2.0.1 2.1.0 Resolution: Fixed Issue resolved by pull request 1912 [https://github.com/apache/orc/pull/1912] > Migration to Scala 2.13 of Apache Spark 3.5.1 at SparkBenchmark > --- > > Key: ORC-1704 > URL: https://issues.apache.org/jira/browse/ORC-1704 > Project: ORC > Issue Type: Improvement >Reporter: dzcxzl >Assignee: dzcxzl >Priority: Minor > Fix For: 2.0.1, 2.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (ORC-1704) Migration to Scala 2.13 of Apache Spark 3.5.1 at SparkBenchmark
[ https://issues.apache.org/jira/browse/ORC-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun reassigned ORC-1704: -- Assignee: dzcxzl > Migration to Scala 2.13 of Apache Spark 3.5.1 at SparkBenchmark > --- > > Key: ORC-1704 > URL: https://issues.apache.org/jira/browse/ORC-1704 > Project: ORC > Issue Type: Improvement >Reporter: dzcxzl >Assignee: dzcxzl >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] ORC-1704: Migration to Scala 2.13 of Apache Spark 3.5.1 at SparkBenchmark [orc]
dongjoon-hyun closed pull request #1912: ORC-1704: Migration to Scala 2.13 of Apache Spark 3.5.1 at SparkBenchmark URL: https://github.com/apache/orc/pull/1912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (ORC-1703) Bump `maven-jar-plugin` to 3.4.1
[ https://issues.apache.org/jira/browse/ORC-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun resolved ORC-1703. Fix Version/s: 2.1.0 Resolution: Fixed Issue resolved by pull request 1905 [https://github.com/apache/orc/pull/1905] > Bump `maven-jar-plugin` to 3.4.1 > > > Key: ORC-1703 > URL: https://issues.apache.org/jira/browse/ORC-1703 > Project: ORC > Issue Type: Bug > Components: Java >Affects Versions: 2.1.0 >Reporter: Dongjoon Hyun >Assignee: Dongjoon Hyun >Priority: Minor > Fix For: 2.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (ORC-1703) Bump `maven-jar-plugin` to 3.4.1
[ https://issues.apache.org/jira/browse/ORC-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun reassigned ORC-1703: -- Assignee: Dongjoon Hyun > Bump `maven-jar-plugin` to 3.4.1 > > > Key: ORC-1703 > URL: https://issues.apache.org/jira/browse/ORC-1703 > Project: ORC > Issue Type: Bug > Components: Java >Affects Versions: 2.1.0 >Reporter: Dongjoon Hyun >Assignee: Dongjoon Hyun >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] ORC-1703: Bump `maven-jar-plugin` to 3.4.1 [orc]
dongjoon-hyun commented on PR #1905: URL: https://github.com/apache/orc/pull/1905#issuecomment-2075298401 Merged to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ORC-1703: Bump `maven-jar-plugin` to 3.4.1 [orc]
dongjoon-hyun closed pull request #1905: ORC-1703: Bump `maven-jar-plugin` to 3.4.1 URL: https://github.com/apache/orc/pull/1905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ORC-1703: Bump `maven-jar-plugin` to 3.4.1 [orc]
dependabot[bot] commented on PR #1905: URL: https://github.com/apache/orc/pull/1905#issuecomment-2075297947 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (ORC-1702) Bump `bcpkix-jdk18on` to 1.78.1
[ https://issues.apache.org/jira/browse/ORC-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun resolved ORC-1702. Fix Version/s: 2.1.0 Resolution: Fixed Issue resolved by pull request 1904 [https://github.com/apache/orc/pull/1904] > Bump `bcpkix-jdk18on` to 1.78.1 > --- > > Key: ORC-1702 > URL: https://issues.apache.org/jira/browse/ORC-1702 > Project: ORC > Issue Type: Bug > Components: Java >Affects Versions: 2.1.0 >Reporter: Dongjoon Hyun >Assignee: Dongjoon Hyun >Priority: Minor > Fix For: 2.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (ORC-1702) Bump `bcpkix-jdk18on` to 1.78.1
[ https://issues.apache.org/jira/browse/ORC-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun reassigned ORC-1702: -- Assignee: Dongjoon Hyun > Bump `bcpkix-jdk18on` to 1.78.1 > --- > > Key: ORC-1702 > URL: https://issues.apache.org/jira/browse/ORC-1702 > Project: ORC > Issue Type: Bug > Components: Java >Affects Versions: 2.1.0 >Reporter: Dongjoon Hyun >Assignee: Dongjoon Hyun >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] ORC-1702: Bump `bcpkix-jdk18on` to 1.78.1 [orc]
dependabot[bot] commented on PR #1904: URL: https://github.com/apache/orc/pull/1904#issuecomment-2075294181 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ORC-1702: Bump `bcpkix-jdk18on` to 1.78.1 [orc]
dongjoon-hyun closed pull request #1904: ORC-1702: Bump `bcpkix-jdk18on` to 1.78.1 URL: https://github.com/apache/orc/pull/1904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (ORC-1701) Bump `threeten-extra` to 1.8.0
[ https://issues.apache.org/jira/browse/ORC-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun reassigned ORC-1701: -- Assignee: Dongjoon Hyun > Bump `threeten-extra` to 1.8.0 > -- > > Key: ORC-1701 > URL: https://issues.apache.org/jira/browse/ORC-1701 > Project: ORC > Issue Type: Improvement > Components: Java >Affects Versions: 2.1.0 >Reporter: Dongjoon Hyun >Assignee: Dongjoon Hyun >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (ORC-1701) Bump `threeten-extra` to 1.8.0
[ https://issues.apache.org/jira/browse/ORC-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun resolved ORC-1701. Fix Version/s: 2.1.0 Resolution: Fixed Issue resolved by pull request 1903 [https://github.com/apache/orc/pull/1903] > Bump `threeten-extra` to 1.8.0 > -- > > Key: ORC-1701 > URL: https://issues.apache.org/jira/browse/ORC-1701 > Project: ORC > Issue Type: Improvement > Components: Java >Affects Versions: 2.1.0 >Reporter: Dongjoon Hyun >Assignee: Dongjoon Hyun >Priority: Minor > Fix For: 2.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] ORC-1701: Bump `threeten-extra` to 1.8.0 [orc]
dependabot[bot] commented on PR #1903: URL: https://github.com/apache/orc/pull/1903#issuecomment-2075289701 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ORC-1701: Bump `threeten-extra` to 1.8.0 [orc]
dongjoon-hyun closed pull request #1903: ORC-1701: Bump `threeten-extra` to 1.8.0 URL: https://github.com/apache/orc/pull/1903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] ORC-1699: Fix SparkBenchmark in Parquet format according to SPARK-40918 [orc]
dongjoon-hyun commented on issue #1911: URL: https://github.com/apache/orc/issues/1911#issuecomment-2075275964 This is resolved via https://github.com/apache/orc/commit/4aefa267cfc7250474ee6727634ca6cbf74f91d6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] ORC-1699: Fix SparkBenchmark in Parquet format according to SPARK-40918 [orc]
dongjoon-hyun closed issue #1911: ORC-1699: Fix SparkBenchmark in Parquet format according to SPARK-40918 URL: https://github.com/apache/orc/issues/1911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ORC-1699: Fix SparkBenchmark in Parquet format according to SPARK-40918 [orc]
dongjoon-hyun commented on PR #1908: URL: https://github.com/apache/orc/pull/1908#issuecomment-2075273696 Thank you! Merged to main/2.0/1.9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (ORC-1699) Fix SparkBenchmark in Parquet format according to SPARK-40918
[ https://issues.apache.org/jira/browse/ORC-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun resolved ORC-1699. Fix Version/s: 2.0.1 1.9.4 2.1.0 Resolution: Fixed Issue resolved by pull request 1908 [https://github.com/apache/orc/pull/1908] > Fix SparkBenchmark in Parquet format according to SPARK-40918 > - > > Key: ORC-1699 > URL: https://issues.apache.org/jira/browse/ORC-1699 > Project: ORC > Issue Type: Improvement >Reporter: dzcxzl >Assignee: dzcxzl >Priority: Major > Fix For: 2.0.1, 1.9.4, 2.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (ORC-1699) Fix SparkBenchmark in Parquet format according to SPARK-40918
[ https://issues.apache.org/jira/browse/ORC-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun reassigned ORC-1699: -- Assignee: dzcxzl > Fix SparkBenchmark in Parquet format according to SPARK-40918 > - > > Key: ORC-1699 > URL: https://issues.apache.org/jira/browse/ORC-1699 > Project: ORC > Issue Type: Improvement >Reporter: dzcxzl >Assignee: dzcxzl >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (ORC-1698) Upgrade `commons-cli` to 1.7.0
[ https://issues.apache.org/jira/browse/ORC-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun reassigned ORC-1698: -- Assignee: dzcxzl > Upgrade `commons-cli` to 1.7.0 > -- > > Key: ORC-1698 > URL: https://issues.apache.org/jira/browse/ORC-1698 > Project: ORC > Issue Type: Improvement >Reporter: dzcxzl >Assignee: dzcxzl >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] ORC-1699: Fix SparkBenchmark in Parquet format according to SPARK-40918 [orc]
dongjoon-hyun closed pull request #1908: ORC-1699: Fix SparkBenchmark in Parquet format according to SPARK-40918 URL: https://github.com/apache/orc/pull/1908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ORC-1698: Upgrade `commons-cli` to 1.7.0 [orc]
dongjoon-hyun commented on PR #1907: URL: https://github.com/apache/orc/pull/1907#issuecomment-2075269917 Thank you. Merged to main/2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (ORC-1698) Upgrade `commons-cli` to 1.7.0
[ https://issues.apache.org/jira/browse/ORC-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjoon Hyun resolved ORC-1698. Fix Version/s: 2.0.1 2.1.0 Resolution: Fixed Issue resolved by pull request 1907 [https://github.com/apache/orc/pull/1907] > Upgrade `commons-cli` to 1.7.0 > -- > > Key: ORC-1698 > URL: https://issues.apache.org/jira/browse/ORC-1698 > Project: ORC > Issue Type: Improvement >Reporter: dzcxzl >Assignee: dzcxzl >Priority: Minor > Fix For: 2.0.1, 2.1.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump commons-cli:commons-cli from 1.6.0 to 1.7.0 in /java [orc]
dependabot[bot] commented on PR #1906: URL: https://github.com/apache/orc/pull/1906#issuecomment-2075268643 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ORC-1698: Upgrade `commons-cli` to 1.7.0 [orc]
dongjoon-hyun closed pull request #1907: ORC-1698: Upgrade `commons-cli` to 1.7.0 URL: https://github.com/apache/orc/pull/1907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-cli:commons-cli from 1.6.0 to 1.7.0 in /java [orc]
dongjoon-hyun closed pull request #1906: Bump commons-cli:commons-cli from 1.6.0 to 1.7.0 in /java URL: https://github.com/apache/orc/pull/1906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ORC-1694: Upgrade gson to 2.9.0 for Benchmarks Hive [orc]
cxzl25 commented on PR #1896: URL: https://github.com/apache/orc/pull/1896#issuecomment-2074826875 > If we can run all benchmarks without any issues I tested all the commands against the benchmark's README and found a few problems, though not related to the gson version. Except ORC-1696 has been merged, I can retest after ORC-1699 ORC-1700 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] ORC-1700: Write parquet decimal type data in Benchmark using `FIXED_LEN_BYTE_ARRAY` type [orc]
cxzl25 commented on code in PR #1910: URL: https://github.com/apache/orc/pull/1910#discussion_r1577706424 ## java/bench/core/src/resources/taxi.schema: ## @@ -9,13 +9,13 @@ struct< PULocationID: bigint, DOLocationID: bigint, payment_type: bigint, - fare_amount: decimal(8,2), - extra: decimal(8,2), - mta_tax: decimal(8,2), - tip_amount: decimal(8,2), - tolls_amount: decimal(8,2), - improvement_surcharge: decimal(8,2), - total_amount: decimal(8,2), + fare_amount: decimal(10,2), Review Comment: Testing locally I found that there is such data as 82599861, which causes the decimal write to fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] ORC-1700: Write parquet decimal type data in Benchmark using `FIXED_LEN_BYTE_ARRAY` type [orc]
cxzl25 opened a new pull request, #1910: URL: https://github.com/apache/orc/pull/1910 ### What changes were proposed in this pull request? This PR aims to write parquet decimal type data in Benchmark using `FIXED_LEN_BYTE_ARRAY` type. ### Why are the changes needed? Because the decimal type of the parquet file generated now corresponds to the binary type of parquet, but Spark3.5.1 does not support reading. Spark 3.5.1 supports reading if using the `FIXED_LEN_BYTE_ARRAY` type. main ``` optional binary fare_amount (DECIMAL(8,2)); ``` PR ``` optional fixed_len_byte_array(5) fare_amount (DECIMAL(10,2)); ``` ```bash java -jar spark/target/orc-benchmarks-spark-2.1.0-SNAPSHOT.jar spark data -format=parquet -compress zstd -data taxi ``` ```java org.apache.spark.sql.execution.datasources.SchemaColumnConvertNotSupportedException: column: [fare_amount], physicalType: BINARY, logicalType: decimal(8,2) at org.apache.spark.sql.execution.datasources.parquet.ParquetVectorUpdaterFactory.constructConvertNotSupportedException(ParquetVectorUpdaterFactory.java:1136) at org.apache.spark.sql.execution.datasources.parquet.ParquetVectorUpdaterFactory.getUpdater(ParquetVectorUpdaterFactory.java:199) at org.apache.spark.sql.execution.datasources.parquet.VectorizedColumnReader.readBatch(VectorizedColumnReader.java:175) at org.apache.spark.sql.execution.datasources.parquet.VectorizedParquetRecordReader.nextBatch(VectorizedParquetRecordReader.java:342) at org.apache.spark.sql.execution.datasources.parquet.VectorizedParquetRecordReader.nextKeyValue(VectorizedParquetRecordReader.java:233) at org.apache.spark.sql.execution.datasources.RecordReaderIterator.hasNext(RecordReaderIterator.scala:39) at org.apache.orc.bench.spark.SparkBenchmark.processReader(SparkBenchmark.java:170) at org.apache.orc.bench.spark.SparkBenchmark.fullRead(SparkBenchmark.java:216) at org.apache.orc.bench.spark.jmh_generated.SparkBenchmark_fullRead_jmhTest.fullRead_avgt_jmhStub(SparkBenchmark_fullRead_jmhTest.java:219) ``` ### How was this patch tested? local test ### Was this patch authored or co-authored using generative AI tooling? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Test Spark 4.0.0-SNAPSHOT [orc]
cxzl25 commented on code in PR #1909:
URL: https://github.com/apache/orc/pull/1909#discussion_r1577523579
##
java/bench/spark/pom.xml:
##
@@ -171,8 +171,9 @@
META-INF/NOTICE-binary
META-INF/NOTICE.md
META-INF/NOTICE.txt
-META-INF/DUMMY.SF
-META-INF/DUMMY.DSA
+META-INF/*.SF
+META-INF/*.DSA
+META-INF/*.RSA
Review Comment:
```
[WARNING] eclipse-collections-11.1.0.jar, eclipse-collections-api-11.1.0.jar
define 4 overlapping resources:
[WARNING] - LICENSE-EDL-1.0.txt
[WARNING] - LICENSE-EPL-1.0.txt
[WARNING] - META-INF/ECLIPSE_.RSA
[WARNING] - META-INF/ECLIPSE_.SF
```
https://github.com/apache/orc/assets/3898450/79eaf13b-9cca-4254-a5bf-650f7b5016d0";>
##
java/bench/spark/src/java/org/apache/orc/bench/spark/SparkBenchmark.java:
##
@@ -74,7 +74,7 @@
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.MICROSECONDS)
@AutoService(OrcBenchmark.class)
-@Fork(jvmArgsAppend = "--add-opens=java.base/sun.nio.ch=ALL-UNNAMED")
+@Fork(jvmArgsAppend = {"--add-opens=java.base/sun.nio.ch=ALL-UNNAMED",
"--add-opens=java.base/sun.util.calendar=ALL-UNNAMED"})
Review Comment:
```java
Caused by: java.lang.IllegalAccessException: symbolic reference class is not
accessible: class sun.util.calendar.ZoneInfo, from interface
org.apache.spark.sql.catalyst.util.SparkDateTimeUtils (unnamed module @2b71fc7e)
at
java.base/java.lang.invoke.MemberName.makeAccessException(MemberName.java:955)
at
java.base/java.lang.invoke.MethodHandles$Lookup.checkSymbolicClass(MethodHandles.java:3686)
at
java.base/java.lang.invoke.MethodHandles$Lookup.resolveOrFail(MethodHandles.java:3646)
at
java.base/java.lang.invoke.MethodHandles$Lookup.findVirtual(MethodHandles.java:2680)
at
org.apache.spark.sql.catalyst.util.SparkDateTimeUtils.$init$(SparkDateTimeUtils.scala:206)
at
org.apache.spark.sql.catalyst.util.DateTimeUtils$.(DateTimeUtils.scala:41)
```
##
java/bench/spark/src/java/org/apache/orc/bench/spark/SparkBenchmark.java:
##
@@ -198,8 +198,8 @@ public void fullRead(InputSource source,
default:
break;
}
-Seq> optionsScala = JavaConverters
-.asScalaBufferConverter(options).asScala().toSeq();
+Seq> optionsScala = JavaConverters
+.asScalaBufferConverter(options).asScala().toList();
Review Comment:
```
scala.collection.Seq> can't
convert to scala.collection.immutable.Seq
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
