[jira] [Commented] (ORC-283) Enable the cmake build to pick specified libraries over the default libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ORC-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322673#comment-16322673
 ] 

ASF GitHub Bot commented on ORC-283:


Github user asfgit closed the pull request at:

https://github.com/apache/orc/pull/204


> Enable the cmake build to pick specified libraries over the default libraries
> -
>
> Key: ORC-283
> URL: https://issues.apache.org/jira/browse/ORC-283
> Project: ORC
>  Issue Type: Bug
>Reporter: Deepak Majeti
>Assignee: Deepak Majeti
>
> The changes in https://github.com/apache/orc/pull/194 are causing libraries 
> in the default path to be picked over the specified path.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ORC-283) Enable the cmake build to pick specified libraries over the default libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ORC-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299975#comment-16299975
 ] 

ASF GitHub Bot commented on ORC-283:


Github user majetideepak commented on a diff in the pull request:

https://github.com/apache/orc/pull/204#discussion_r158269151
  
--- Diff: cmake_modules/FindGTest.cmake ---
@@ -28,7 +28,7 @@ find_path (GTEST_INCLUDE_DIR gmock/gmock.h HINTS
   NO_DEFAULT_PATH
   PATH_SUFFIXES "include")
 
-find_library (GTEST_LIBRARIES NAMES gmock PATHS
+find_library (GTEST_LIBRARIES NAMES gmock HINTS
--- End diff --

`HINTS` is apt here. `PATHS` must only be used for hardcoded guesses.
https://cmake.org/cmake/help/v3.0/command/find_library.html


> Enable the cmake build to pick specified libraries over the default libraries
> -
>
> Key: ORC-283
> URL: https://issues.apache.org/jira/browse/ORC-283
> Project: ORC
>  Issue Type: Bug
>Reporter: Deepak Majeti
>Assignee: Deepak Majeti
>
> The changes in https://github.com/apache/orc/pull/194 are causing libraries 
> in the default path to be picked over the specified path.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ORC-283) Enable the cmake build to pick specified libraries over the default libraries

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ORC-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299961#comment-16299961
 ] 

ASF GitHub Bot commented on ORC-283:


GitHub user majetideepak opened a pull request:

https://github.com/apache/orc/pull/204

ORC-283: Enable the cmake build to pick specified libraries over the …

…default libraries

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/majetideepak/orc ORC-283

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/orc/pull/204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #204


commit 1a34380e7eb6323e3f0b92b377943f1ba5562d5e
Author: Deepak Majeti 
Date:   2017-12-21T12:17:12Z

ORC-283: Enable the cmake build to pick specified libraries over the 
default libraries




> Enable the cmake build to pick specified libraries over the default libraries
> -
>
> Key: ORC-283
> URL: https://issues.apache.org/jira/browse/ORC-283
> Project: ORC
>  Issue Type: Bug
>Reporter: Deepak Majeti
>Assignee: Deepak Majeti
>
> The changes in https://github.com/apache/orc/pull/194 are causing libraries 
> in the default path to be picked over the specified path.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)