[jira] [Commented] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018514#comment-17018514 ] Hudson commented on PHOENIX-5678: - ABORTED: Integrated in Jenkins build Phoenix-4.x-HBase-1.4 #373 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.4/373/]) PHOENIX-5678 : Cleanup anonymous classes used for BaseMutationPlan (yanxinyi: rev 2d85374a2da720f0fb83e8576b27a0e95f01051a) * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/PostLocalIndexDDLCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/CreateFunctionCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/CreateSchemaCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java > Cleanup anonymous inner classes used for BaseMutationPlan > - > > Key: PHOENIX-5678 > URL: https://issues.apache.org/jira/browse/PHOENIX-5678 > Project: Phoenix > Issue Type: Sub-task >Affects Versions: 5.1.0, 4.15.1 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5678.master.000.patch > > > BaseMutationPlan has been extended as anonymous inner class at multiple > places and some of them have lots of logic placed in overridden methods. We > should convert them to Inner classes and use object of extended inner class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018496#comment-17018496 ] Hudson commented on PHOENIX-5678: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3329 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3329/]) PHOENIX-5678 : Cleanup anonymous classes used for BaseMutationPlan (yanxinyi: rev 044155414b44426226437127aed891aa17aa079f) * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/CreateSchemaCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/CreateFunctionCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/PostLocalIndexDDLCompiler.java > Cleanup anonymous inner classes used for BaseMutationPlan > - > > Key: PHOENIX-5678 > URL: https://issues.apache.org/jira/browse/PHOENIX-5678 > Project: Phoenix > Issue Type: Sub-task >Affects Versions: 5.1.0, 4.15.1 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5678.master.000.patch > > > BaseMutationPlan has been extended as anonymous inner class at multiple > places and some of them have lots of logic placed in overridden methods. We > should convert them to Inner classes and use object of extended inner class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018458#comment-17018458 ] Hudson commented on PHOENIX-5678: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #658 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/658/]) PHOENIX-5678 : Cleanup anonymous classes used for BaseMutationPlan (yanxinyi: rev 27e179bf0d3fa70854f6f059fa674ceec6e2b283) * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/CreateFunctionCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/PostLocalIndexDDLCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/CreateSchemaCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java > Cleanup anonymous inner classes used for BaseMutationPlan > - > > Key: PHOENIX-5678 > URL: https://issues.apache.org/jira/browse/PHOENIX-5678 > Project: Phoenix > Issue Type: Sub-task >Affects Versions: 5.1.0, 4.15.1 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5678.master.000.patch > > > BaseMutationPlan has been extended as anonymous inner class at multiple > places and some of them have lots of logic placed in overridden methods. We > should convert them to Inner classes and use object of extended inner class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018412#comment-17018412 ] Hudson commented on PHOENIX-5678: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBase-1.5 #251 (See [https://builds.apache.org/job/Phoenix-4.x-HBase-1.5/251/]) PHOENIX-5678 : Cleanup anonymous classes used for BaseMutationPlan (yanxinyi: rev e4d9694b1cfa01c088838d33bc283d1b520e2c30) * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/CreateFunctionCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/PostLocalIndexDDLCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/CreateSchemaCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java > Cleanup anonymous inner classes used for BaseMutationPlan > - > > Key: PHOENIX-5678 > URL: https://issues.apache.org/jira/browse/PHOENIX-5678 > Project: Phoenix > Issue Type: Sub-task >Affects Versions: 5.1.0, 4.15.1 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5678.master.000.patch > > > BaseMutationPlan has been extended as anonymous inner class at multiple > places and some of them have lots of logic placed in overridden methods. We > should convert them to Inner classes and use object of extended inner class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018346#comment-17018346 ] Xinyi Yan commented on PHOENIX-5678: Thanks for the contribution, [~vjasani]. Let me apply and commit your patch! > Cleanup anonymous inner classes used for BaseMutationPlan > - > > Key: PHOENIX-5678 > URL: https://issues.apache.org/jira/browse/PHOENIX-5678 > Project: Phoenix > Issue Type: Sub-task >Affects Versions: 5.1.0, 4.15.1 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5678.master.000.patch > > > BaseMutationPlan has been extended as anonymous inner class at multiple > places and some of them have lots of logic placed in overridden methods. We > should convert them to Inner classes and use object of extended inner class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016242#comment-17016242 ] Xinyi Yan commented on PHOENIX-5678: +1 lgtm > Cleanup anonymous inner classes used for BaseMutationPlan > - > > Key: PHOENIX-5678 > URL: https://issues.apache.org/jira/browse/PHOENIX-5678 > Project: Phoenix > Issue Type: Sub-task >Affects Versions: 5.1.0, 4.15.1 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5678.master.000.patch > > > BaseMutationPlan has been extended as anonymous inner class at multiple > places and some of them have lots of logic placed in overridden methods. We > should convert them to Inner classes and use object of extended inner class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan
[
https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015678#comment-17015678
]
Hadoop QA commented on PHOENIX-5678:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12990940/PHOENIX-5678.master.000.patch
against master branch at commit beb6457086c8e51fc8be5eceb468a1edf8a358b7.
ATTACHMENT ID: 12990940
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3303//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3303//console
This message is automatically generated.
> Cleanup anonymous inner classes used for BaseMutationPlan
> -
>
> Key: PHOENIX-5678
> URL: https://issues.apache.org/jira/browse/PHOENIX-5678
> Project: Phoenix
> Issue Type: Sub-task
>Affects Versions: 5.1.0, 4.15.1
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 5.1.0, 4.15.1
>
> Attachments: PHOENIX-5678.master.000.patch
>
>
> BaseMutationPlan has been extended as anonymous inner class at multiple
> places and some of them have lots of logic placed in overridden methods. We
> should convert them to Inner classes and use object of extended inner class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5678) Cleanup anonymous inner classes used for BaseMutationPlan
[ https://issues.apache.org/jira/browse/PHOENIX-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17015313#comment-17015313 ] Viraj Jasani commented on PHOENIX-5678: --- Please review [~ckulkarni] [~gjacoby] > Cleanup anonymous inner classes used for BaseMutationPlan > - > > Key: PHOENIX-5678 > URL: https://issues.apache.org/jira/browse/PHOENIX-5678 > Project: Phoenix > Issue Type: Sub-task >Affects Versions: 5.1.0, 4.15.1 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 5.1.0, 4.15.1 > > Attachments: PHOENIX-5678.master.000.patch > > > BaseMutationPlan has been extended as anonymous inner class at multiple > places and some of them have lots of logic placed in overridden methods. We > should convert them to Inner classes and use object of extended inner class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
