[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716240#comment-17716240 ] ASF GitHub Bot commented on PHOENIX-6395: - stoty commented on PR #1151: URL: https://github.com/apache/phoenix/pull/1151#issuecomment-1521692096 A modified version of this patch has already been merged to master and 5.1 > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.2.0, 5.1.3 >Reporter: vikas meka >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.0, 5.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716241#comment-17716241 ] ASF GitHub Bot commented on PHOENIX-6395: - stoty closed pull request #1151: PHOENIX-6395 Reusing Connection instance object instead of creating everytime in PhoenixAccessController class. URL: https://github.com/apache/phoenix/pull/1151 > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.2.0, 5.1.3 >Reporter: vikas meka >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.0, 5.1.4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687235#comment-17687235 ] ASF GitHub Bot commented on PHOENIX-6395: - stoty closed pull request #1560: PHOENIX-6395 Reusing Connection instance object instead of creating e… URL: https://github.com/apache/phoenix/pull/1560 > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.2.0, 5.1.3 >Reporter: vikas meka >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687231#comment-17687231 ] Istvan Toth commented on PHOENIX-6395: -- Oops, closing the shared connection when the Coprocessor is stopped is a very bad idea. Pushing an addendum. > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.2.0, 5.1.3 >Reporter: vikas meka >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687207#comment-17687207 ] ASF GitHub Bot commented on PHOENIX-6395: - stoty commented on PR #1560: URL: https://github.com/apache/phoenix/pull/1560#issuecomment-1426116389 Thank you @gjacoby126 . My explanation above has a mistake, there is one connection per ConnectionType, not one per RegionCoprocessorEnvironment. The API for ServerUtil.ConnectionFactory suggests that theConnection cache is per RegionCoprocessorEnvironment , but that's not true. The cache is actually a static object, so the the Connection objects are per classloader singletons, just as the CQSI objects. I was worried that we're creating hundreds of connections with ServerUtil.ConnectionFactory, but that factrory is doing the right thing. > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.2.0, 5.1.3 >Reporter: vikas meka >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687079#comment-17687079 ] ASF GitHub Bot commented on PHOENIX-6395: - stoty commented on PR #1560: URL: https://github.com/apache/phoenix/pull/1560#issuecomment-1425820014 The same question occured to me. However, when we use ServerUtil.ConnectionFactory, we are always getting the same Connection instance (per env), so storing the reference in the coprocessor instance doesn't change that, we just avoid some cache lookups. We already use ServerUtil.ConnectionFactory in a few places, I don't recall seeing problems stemming from this. We also use PhoenixConnections on the server side, which implement a similar pattern with the CQSI objects holding Connection objects being cached forever. (IUC we don't check or re-create those either) > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.2.0, 5.1.3 >Reporter: vikas meka >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687066#comment-17687066 ] ASF GitHub Bot commented on PHOENIX-6395: - gjacoby126 commented on PR #1560: URL: https://github.com/apache/phoenix/pull/1560#issuecomment-1425777413 Generally looks good > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.2.0, 5.1.3 >Reporter: vikas meka >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686416#comment-17686416 ] Istvan Toth commented on PHOENIX-6395: -- Do you mind if I pick this up [~vmeka] ? > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 5.2.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686414#comment-17686414 ] ASF GitHub Bot commented on PHOENIX-6395: - stoty opened a new pull request, #1560: URL: https://github.com/apache/phoenix/pull/1560 …verytime in PhoenixAccessController class Co-authored-by: vmeka2020 > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 5.2.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556568#comment-17556568 ] ASF GitHub Bot commented on PHOENIX-6395: - gjacoby126 commented on PR #1152: URL: https://github.com/apache/phoenix/pull/1152#issuecomment-1160833853 Closing as 4.x has been EOLed > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 4.17.0, 5.2.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556567#comment-17556567 ] ASF GitHub Bot commented on PHOENIX-6395: - gjacoby126 closed pull request #1152: PHOENIX-6395 Reusing Connection instance object instead of creating everytime in PhoenixAccessController class. URL: https://github.com/apache/phoenix/pull/1152 > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 4.17.0, 5.2.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556566#comment-17556566 ] ASF GitHub Bot commented on PHOENIX-6395: - gjacoby126 commented on PR #1151: URL: https://github.com/apache/phoenix/pull/1151#issuecomment-1160833597 @vmeka2020 - are you still interested in getting this patch into Phoenix 5.2? Looks like this PR needs to be rebased before we can see if the tests are currently passing. > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 4.17.0, 5.2.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17550637#comment-17550637 ] Geoffrey Jacoby commented on PHOENIX-6395: -- [~vmeka]- just checking if are you still targeting this JIRA for the 5.2 release? Looks like your PR needs a rebase and it had some test failures. If not please set the Fix Version to 5.2.1. Thanks! > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 4.17.0, 5.2.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401605#comment-17401605 ] ASF GitHub Bot commented on PHOENIX-6395: - stoty commented on pull request #1152: URL: https://github.com/apache/phoenix/pull/1152#issuecomment-901804983 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 20m 7s | 4.x passed | | +1 :green_heart: | compile | 1m 5s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 59s | 4.x passed | | +1 :green_heart: | javadoc | 0m 48s | 4.x passed | | +0 :ok: | spotbugs | 3m 21s | phoenix-core in 4.x has 958 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 11m 37s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | -1 :x: | checkstyle | 0m 59s | phoenix-core: The patch generated 15 new + 130 unchanged - 9 fixed = 145 total (was 139) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 46s | the patch passed | | +1 :green_heart: | spotbugs | 3m 27s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 195m 54s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. | | | | 244m 43s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.PermissionsCacheIT | | | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT | | | phoenix.end2end.index.PartialIndexRebuilderIT | | | phoenix.end2end.PermissionNSDisabledIT | | | phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT | | | phoenix.end2end.PermissionNSEnabledIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1152 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux f56f53f6fd45 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 9dc5e2e | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/testReport/ | | Max. process+thread count | 4718 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL:
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391747#comment-17391747 ] ASF GitHub Bot commented on PHOENIX-6395: - stoty commented on pull request #1151: URL: https://github.com/apache/phoenix/pull/1151#issuecomment-891231084 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 8m 12s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 31m 0s | master passed | | +0 | hbaserecompile | 38m 25s | HBase recompiled. | | +1 :green_heart: | compile | 1m 8s | master passed | | +1 :green_heart: | checkstyle | 1m 7s | master passed | | +1 :green_heart: | javadoc | 0m 59s | master passed | | +0 :ok: | spotbugs | 3m 43s | phoenix-core in master has 973 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 17m 11s | the patch passed | | +0 | hbaserecompile | 28m 24s | HBase recompiled. | | +1 :green_heart: | compile | 1m 13s | the patch passed | | +1 :green_heart: | javac | 1m 13s | the patch passed | | -1 :x: | checkstyle | 1m 6s | phoenix-core: The patch generated 16 new + 173 unchanged - 12 fixed = 189 total (was 185) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 54s | the patch passed | | +1 :green_heart: | spotbugs | 3m 37s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 119m 4s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 32s | The patch does not generate ASF License warnings. | | | | 207m 45s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.PermissionsCacheIT | | | phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT | | | phoenix.end2end.PermissionNSDisabledIT | | | phoenix.end2end.PermissionNSEnabledIT | | | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1151 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux d21160d90aa6 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 025a4af | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/testReport/ | | Max. process+thread count | 5960 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > >
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371777#comment-17371777 ] ASF GitHub Bot commented on PHOENIX-6395: - stoty commented on pull request #1152: URL: https://github.com/apache/phoenix/pull/1152#issuecomment-871053501 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 20m 30s | 4.x passed | | +1 :green_heart: | compile | 1m 5s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 33s | 4.x passed | | +1 :green_heart: | javadoc | 0m 48s | 4.x passed | | +0 :ok: | spotbugs | 3m 20s | phoenix-core in 4.x has 957 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 11m 55s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | -1 :x: | checkstyle | 0m 35s | phoenix-core: The patch generated 17 new + 313 unchanged - 12 fixed = 330 total (was 325) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed | | +1 :green_heart: | spotbugs | 3m 28s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 205m 12s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. | | | | 253m 49s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.PermissionsCacheIT | | | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT | | | phoenix.end2end.index.PartialIndexRebuilderIT | | | phoenix.end2end.PermissionNSDisabledIT | | | phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT | | | phoenix.end2end.PermissionNSEnabledIT | | | phoenix.end2end.AuditLoggingIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1152 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 8c679e5fca3b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / dd9b8af | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/testReport/ | | Max. process+thread count | 4716 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL:
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344831#comment-17344831 ] Lars Hofhansl commented on PHOENIX-6395: What about branch 5.1 (5.1.2)? > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 4.17.0, 5.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288787#comment-17288787 ] ASF GitHub Bot commented on PHOENIX-6395: - stoty commented on pull request #1152: URL: https://github.com/apache/phoenix/pull/1152#issuecomment-783816806 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 7s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 14m 46s | 4.x passed | | +1 :green_heart: | compile | 1m 6s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 33s | 4.x passed | | +1 :green_heart: | javadoc | 0m 48s | 4.x passed | | +0 :ok: | spotbugs | 3m 16s | phoenix-core in 4.x has 945 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 6m 47s | the patch passed | | +1 :green_heart: | compile | 1m 5s | the patch passed | | +1 :green_heart: | javac | 1m 5s | the patch passed | | -1 :x: | checkstyle | 0m 32s | phoenix-core: The patch generated 9 new + 321 unchanged - 4 fixed = 330 total (was 325) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 47s | the patch passed | | +1 :green_heart: | spotbugs | 3m 29s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 192m 21s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 1m 1s | The patch does not generate ASF License warnings. | | | | 230m 56s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT | | | phoenix.end2end.PermissionNSEnabledIT | | | phoenix.end2end.PermissionsCacheIT | | | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT | | | phoenix.end2end.PermissionNSDisabledIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1152 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 909155496d5f 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 358ace8 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/testReport/ | | Max. process+thread count | 4839 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1152/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type:
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288747#comment-17288747 ] ASF GitHub Bot commented on PHOENIX-6395: - stoty commented on pull request #1151: URL: https://github.com/apache/phoenix/pull/1151#issuecomment-783788346 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 59s | master passed | | +0 | hbaserecompile | 23m 14s | HBase recompiled. | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | checkstyle | 0m 41s | master passed | | +1 :green_heart: | javadoc | 0m 52s | master passed | | +0 :ok: | spotbugs | 3m 5s | phoenix-core in master has 959 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 2s | the patch passed | | +0 | hbaserecompile | 17m 55s | HBase recompiled. | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | -1 :x: | checkstyle | 0m 42s | phoenix-core: The patch generated 14 new + 319 unchanged - 13 fixed = 333 total (was 332) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed | | +1 :green_heart: | spotbugs | 3m 14s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 101m 35s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 44s | The patch does not generate ASF License warnings. | | | | 155m 46s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT | | | phoenix.end2end.PermissionNSDisabledIT | | | phoenix.end2end.PermissionNSEnabledIT | | | phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT | | | phoenix.end2end.PermissionsCacheIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1151 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux bd8b24b11d86 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 8668bfa | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/testReport/ | | Max. process+thread count | 8965 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1151/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > >
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288714#comment-17288714 ] ASF GitHub Bot commented on PHOENIX-6395: - stoty commented on pull request #1150: URL: https://github.com/apache/phoenix/pull/1150#issuecomment-783768727 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 27s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 14m 6s | 4.x passed | | +1 :green_heart: | compile | 1m 0s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 33s | 4.x passed | | +1 :green_heart: | javadoc | 0m 46s | 4.x passed | | +0 :ok: | spotbugs | 2m 59s | phoenix-core in 4.x has 945 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 41s | the patch passed | | +1 :green_heart: | compile | 1m 0s | the patch passed | | +1 :green_heart: | javac | 1m 0s | the patch passed | | -1 :x: | checkstyle | 0m 34s | phoenix-core: The patch generated 17 new + 313 unchanged - 12 fixed = 330 total (was 325) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 43s | the patch passed | | +1 :green_heart: | spotbugs | 3m 10s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 133m 58s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 49s | The patch does not generate ASF License warnings. | | | | 173m 40s | | | Reason | Tests | |---:|:--| | Failed junit tests | phoenix.end2end.PermissionNSEnabledIT | | | phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT | | | phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT | | | phoenix.end2end.PermissionsCacheIT | | | phoenix.end2end.PermissionNSDisabledIT | | | phoenix.end2end.index.IndexMetadataIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1150/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1150 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 4d7d5242c087 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 358ace8 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1150/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1150/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1150/1/testReport/ | | Max. process+thread count | 4760 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1150/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 >
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288655#comment-17288655 ] ASF GitHub Bot commented on PHOENIX-6395: - vmeka2020 opened a new pull request #1152: URL: https://github.com/apache/phoenix/pull/1152 Reusing Connection instance object instead of creating everytime in PhoenixAccessController class. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 4.17.0, 5.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288657#comment-17288657 ] ASF GitHub Bot commented on PHOENIX-6395: - vmeka2020 closed pull request #1150: URL: https://github.com/apache/phoenix/pull/1150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 4.17.0, 5.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288658#comment-17288658 ] ASF GitHub Bot commented on PHOENIX-6395: - vmeka2020 commented on pull request #1150: URL: https://github.com/apache/phoenix/pull/1150#issuecomment-783720189 closing in as i am having issues with some rebasing, opening a new one, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 4.17.0, 5.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288650#comment-17288650 ] ASF GitHub Bot commented on PHOENIX-6395: - vmeka2020 opened a new pull request #1151: URL: https://github.com/apache/phoenix/pull/1151 Reusing Connection instance object instead of creating everytime in PhoenixAccessController class. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 4.17.0, 5.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6395) Reusing Connection instance object instead of creating everytime in PhoenixAccessController class.
[ https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288647#comment-17288647 ] ASF GitHub Bot commented on PHOENIX-6395: - dbwong commented on pull request #1150: URL: https://github.com/apache/phoenix/pull/1150#issuecomment-783712085 Changes look good but would like have some sort of testing. Either an IT or a well written UT should suffice. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reusing Connection instance object instead of creating everytime in > PhoenixAccessController class. > --- > > Key: PHOENIX-6395 > URL: https://issues.apache.org/jira/browse/PHOENIX-6395 > Project: Phoenix > Issue Type: Bug >Reporter: vikas meka >Assignee: vikas meka >Priority: Major > Fix For: 4.17.0, 5.2.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
