[jira] [Updated] (RATIS-123) Add CLI for FileStore example
[ https://issues.apache.org/jira/browse/RATIS-123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-123: -- Attachment: FileStoreServer.java I have a very simple, incomplete implementation of FileStoreServer. It may be a good starting point for this JIRA. FileStoreServer.java > Add CLI for FileStore example > - > > Key: RATIS-123 > URL: https://issues.apache.org/jira/browse/RATIS-123 > Project: Ratis > Issue Type: New Feature >Reporter: Tsz Wo Nicholas Sze > Attachments: FileStoreServer.java > > > In RATIS-122, we adds a File Store example which support the following > operations > - Write(path, data) > - Read(path) > - Delete(path) > In this JIRA, we add some CLIs so that servers and the clients can be run in > command line. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RATIS-117) Add test for situation when old leader can/cannot commit log
[ https://issues.apache.org/jira/browse/RATIS-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yubo Xu updated RATIS-117: -- Attachment: RATIS-117.003.patch Added new test util method and updated the logic in testOldLeaderNotCommit to only validate the log entries in last term, local test succeeded. > Add test for situation when old leader can/cannot commit log > > > Key: RATIS-117 > URL: https://issues.apache.org/jira/browse/RATIS-117 > Project: Ratis > Issue Type: Test >Reporter: Yubo Xu >Assignee: Yubo Xu >Priority: Minor > Attachments: RATIS-117.001.patch, RATIS-117.002.patch, > RATIS-117.003.patch > > > As described in Question 7 of the quiz at > [https://ramcloud.stanford.edu/~ongaro/userstudy/quizzes.html], an old leader > can complete the commitment of an old log entry satisfying certain > requirements. We need tests to confirm Ratis behaves correctly under such > cases. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent
[
https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243247#comment-16243247
]
Tsz Wo Nicholas Sze commented on RATIS-77:
--
I probably is missing something -- why it should return {{stream
InstallSnapshotReplyProto}} but not just {{InstallSnapshotReplyProto}}? I
thought InstallSnapshotReplyProto is a small response which does not need a
stream.
> "RaftServerProtocolService" and " GRpc.proto" inconsistent
> --
>
> Key: RATIS-77
> URL: https://issues.apache.org/jira/browse/RATIS-77
> Project: Ratis
> Issue Type: Bug
>Reporter: kaiyangzhang
>Assignee: garvit
>
> *Maybe a bug, look at the comments in the code and GRpc.proto*
> {code:title=GRpc.proto|borderStyle=solid}
>..
>..
>//Executes a client-streaming call , return only one response.
>rpc installSnapshot(stream ratis.common.InstallSnapshotRequestProto)
> returns(ratis.common.InstallSnapshotReplyProto) {}
>...
>...
> {code}
> {code:title=RaftServerProtocolService.java |borderStyle=solid}
>
>
> @Override
> public StreamObserver installSnapshot(
> StreamObserver responseObserver) {
> return new StreamObserver() {
> @Override
> public void onNext(InstallSnapshotRequestProto request) {
> try {
> //receive a client-streaming call, return a response stream
> //code and GRpc.proto inconsistent
> final InstallSnapshotReplyProto reply =
> server.installSnapshot(request);
> responseObserver.onNext(reply);
> } catch (Throwable e) {
> LOG.info("{} got exception when handling installSnapshot {}: {}",
> id, request.getServerRequest(), e);
> responseObserver.onError(RaftGrpcUtil.wrapException(e));
> }
> }
>..
>..
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RATIS-134) PeerProxyMap#addPeers should add peers only if it is not already present in the proxymap
[
https://issues.apache.org/jira/browse/RATIS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243218#comment-16243218
]
Tsz Wo Nicholas Sze commented on RATIS-134:
---
Thanks for the update. The patch looks good. Need some more your help below:
# Let's rename PeerProxyMap.putIfAbsent to computeIfAbsent.
# Let's call PeerProxyMap.computeIfAbsent in addPeers.
# The resetProxy method also have a call to peers.put. Could you also change
it to call PeerProxyMap.computeIfAbsent?
> PeerProxyMap#addPeers should add peers only if it is not already present in
> the proxymap
>
>
> Key: RATIS-134
> URL: https://issues.apache.org/jira/browse/RATIS-134
> Project: Ratis
> Issue Type: Bug
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
> Attachments: RATIS-134.001.patch, RATIS-134.002.patch
>
>
> {{PeerProxyMap#addPeers}} currently adds peers to the proxyMap without
> checkint the current state. This should be optimized to allow addition only
> if the peer is not present in the proxyMap.
> {code}
> public void addPeers(Iterable newPeers) {
> for(RaftPeer p : newPeers) {
> peers.put(p.getId(), new PeerAndProxy(p));
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RATIS-72) Enable Ratis to run on high-performance RDMA networks
[ https://issues.apache.org/jira/browse/RATIS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243288#comment-16243288 ] Tsz Wo Nicholas Sze commented on RATIS-72: -- [~atrivedi], please feel free to file JIRA if you see test failures. You may first check the output files (in ./ratis-Xxx/target/surefire-reports) and post the files in the JIRA. Thank you in advance! > Enable Ratis to run on high-performance RDMA networks > - > > Key: RATIS-72 > URL: https://issues.apache.org/jira/browse/RATIS-72 > Project: Ratis > Issue Type: New Feature >Reporter: Animesh Trivedi >Assignee: Animesh Trivedi >Priority: Minor > Attachments: failed-test > > > We want to enable Ratis to run on high-performance RDMA networks. There has > already been quite a bit of activity in leveraging RDMA networks in modern > data processing stacks. Distributed consensus is one of the problems that can > be accelerated using high-performance/RDMA messaging. > We start by implementing a Ratis RPC implementation using DiSNI and DaPRC > modules (https://github.com/zrlio/) for RDMA networks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RATIS-136) Reduce log level for segment rollover
[ https://issues.apache.org/jira/browse/RATIS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-136: -- Attachment: RATIS-136.003.patch RATIS-136.003.patch: file to be committed. > Reduce log level for segment rollover > - > > Key: RATIS-136 > URL: https://issues.apache.org/jira/browse/RATIS-136 > Project: Ratis > Issue Type: Bug >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh > Attachments: RATIS-136.001.patch, RATIS-136.002.patch, > RATIS-136.003.patch > > > ratis logs every segment rollover, this does generate lots of log entries in > the log file for Ozone. This patch will reduce the log entries for some of > the log entries. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RATIS-136) Reduce log level for segment rollover
[
https://issues.apache.org/jira/browse/RATIS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243272#comment-16243272
]
Tsz Wo Nicholas Sze commented on RATIS-136:
---
{code}
---
a/ratis-server/src/test/java/org/apache/ratis/server/storage/TestRaftLogSegment.java
+++
b/ratis-server/src/test/java/org/apache/ratis/server/storage/TestRaftLogSegment.java
@@ -39,7 +39,6 @@ import java.io.File;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Arrays;
-import java.util.List;
{code}
It seems that the above change was by accident since the new patch does not
compile without the import.
I adds the import back locally and everything works well. All tests have
passed.
+1 on the patch
(Since this is a very minor nite, I will revert the import change and commit
the patch.)
> Reduce log level for segment rollover
> -
>
> Key: RATIS-136
> URL: https://issues.apache.org/jira/browse/RATIS-136
> Project: Ratis
> Issue Type: Bug
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
> Attachments: RATIS-136.001.patch, RATIS-136.002.patch
>
>
> ratis logs every segment rollover, this does generate lots of log entries in
> the log file for Ozone. This patch will reduce the log entries for some of
> the log entries.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (RATIS-136) Reduce log level for segment rollover
[ https://issues.apache.org/jira/browse/RATIS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze resolved RATIS-136. --- Resolution: Fixed Fix Version/s: 0.2.0-alpha I have committed this. Thanks, Mukul! > Reduce log level for segment rollover > - > > Key: RATIS-136 > URL: https://issues.apache.org/jira/browse/RATIS-136 > Project: Ratis > Issue Type: Bug >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh > Fix For: 0.2.0-alpha > > Attachments: RATIS-136.001.patch, RATIS-136.002.patch, > RATIS-136.003.patch > > > ratis logs every segment rollover, this does generate lots of log entries in > the log file for Ozone. This patch will reduce the log entries for some of > the log entries. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (RATIS-132) Support simple 'mvn clean compile' command (move shading before the compile phase)
[
https://issues.apache.org/jira/browse/RATIS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243254#comment-16243254
]
Tsz Wo Nicholas Sze edited comment on RATIS-132 at 11/8/17 2:11 AM:
I have committed this. Thanks, Marton!
was (Author: szetszwo):
I have committed this.
> Support simple 'mvn clean compile' command (move shading before the compile
> phase)
> ---
>
> Key: RATIS-132
> URL: https://issues.apache.org/jira/browse/RATIS-132
> Project: Ratis
> Issue Type: Bug
>Reporter: Elek, Marton
>Assignee: Elek, Marton
> Fix For: 0.2.0-alpha
>
> Attachments: RATIS-132.001.patch, RATIS-132.002.patch
>
>
> The current situation is described in the BUILDING.md:
> {code}
> When building Ratis the first time, shaded files need to be generated by the
> following command:
> ```
> $ mvn package -DskipTests
> ```
> After that, `mvn compile` or `mvn test` can be used as normal.
> For example, we may run the basic tests by
> ```
> {code}
> In short: the shading phase is bound to the 'package' maven phase, therefore
> we can't use 'mvn clean install' just 'mvn clean package' because the package
> phase should be done before the compilation of ratis-proto-shaded.
> This blocks the nightly build as yetus uses one 'mvn clean compile' or 'mvn
> clean test-compile' without invoking the package phase.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (RATIS-137) RaftBasicTests.testBasicAppendEntries may fail
Tsz Wo Nicholas Sze created RATIS-137:
-
Summary: RaftBasicTests.testBasicAppendEntries may fail
Key: RATIS-137
URL: https://issues.apache.org/jira/browse/RATIS-137
Project: Ratis
Issue Type: Bug
Reporter: Tsz Wo Nicholas Sze
[~atrivedi] reported in RATIS-72 that the test may fail.
{code}
TestRaftWithHadoopRpc>RaftBasicTests.testBasicAppendEntries:127->RaftBasicTests.lambda$testBasicAppendEntries$1:127
expected:<10> but was:<11>
{code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RATIS-137) RaftBasicTests.testBasicAppendEntries may fail
[
https://issues.apache.org/jira/browse/RATIS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243265#comment-16243265
]
Tsz Wo Nicholas Sze commented on RATIS-137:
---
It seems that the failure happens at
{code}
//RaftTestUtil: line 150
Assert.assertEquals(expectedMessages.length, entries.length);
{code}
10 messages were created in the test so that expectedMessages.length is 10.
But entries.length == 11. I suspect the additional log is a NO-OP which get
added when there is a leader change.
> RaftBasicTests.testBasicAppendEntries may fail
> --
>
> Key: RATIS-137
> URL: https://issues.apache.org/jira/browse/RATIS-137
> Project: Ratis
> Issue Type: Bug
>Reporter: Tsz Wo Nicholas Sze
>
> [~atrivedi] reported in RATIS-72 that the test may fail.
> {code}
> TestRaftWithHadoopRpc>RaftBasicTests.testBasicAppendEntries:127->RaftBasicTests.lambda$testBasicAppendEntries$1:127
> expected:<10> but was:<11>
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RATIS-72) Enable Ratis to run on high-performance RDMA networks
[
https://issues.apache.org/jira/browse/RATIS-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243260#comment-16243260
]
Tsz Wo Nicholas Sze commented on RATIS-72:
--
{code}
TestRaftWithHadoopRpc>RaftBasicTests.testBasicAppendEntries:127->RaftBasicTests.lambda$testBasicAppendEntries$1:127
expected:<10> but was:<11>
{code}
This seems a bug in the test. Let me file a JIRA.
> Enable Ratis to run on high-performance RDMA networks
> -
>
> Key: RATIS-72
> URL: https://issues.apache.org/jira/browse/RATIS-72
> Project: Ratis
> Issue Type: New Feature
>Reporter: Animesh Trivedi
>Assignee: Animesh Trivedi
>Priority: Minor
> Attachments: failed-test
>
>
> We want to enable Ratis to run on high-performance RDMA networks. There has
> already been quite a bit of activity in leveraging RDMA networks in modern
> data processing stacks. Distributed consensus is one of the problems that can
> be accelerated using high-performance/RDMA messaging.
> We start by implementing a Ratis RPC implementation using DiSNI and DaPRC
> modules (https://github.com/zrlio/) for RDMA networks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent
[
https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jitendra Nath Pandey reassigned RATIS-77:
-
Assignee: garvit
> "RaftServerProtocolService" and " GRpc.proto" inconsistent
> --
>
> Key: RATIS-77
> URL: https://issues.apache.org/jira/browse/RATIS-77
> Project: Ratis
> Issue Type: Bug
>Reporter: kaiyangzhang
>Assignee: garvit
>
> *Maybe a bug, look at the comments in the code and GRpc.proto*
> {code:title=GRpc.proto|borderStyle=solid}
>..
>..
>//Executes a client-streaming call , return only one response.
>rpc installSnapshot(stream ratis.common.InstallSnapshotRequestProto)
> returns(ratis.common.InstallSnapshotReplyProto) {}
>...
>...
> {code}
> {code:title=RaftServerProtocolService.java |borderStyle=solid}
>
>
> @Override
> public StreamObserver installSnapshot(
> StreamObserver responseObserver) {
> return new StreamObserver() {
> @Override
> public void onNext(InstallSnapshotRequestProto request) {
> try {
> //receive a client-streaming call, return a response stream
> //code and GRpc.proto inconsistent
> final InstallSnapshotReplyProto reply =
> server.installSnapshot(request);
> responseObserver.onNext(reply);
> } catch (Throwable e) {
> LOG.info("{} got exception when handling installSnapshot {}: {}",
> id, request.getServerRequest(), e);
> responseObserver.onError(RaftGrpcUtil.wrapException(e));
> }
> }
>..
>..
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RATIS-132) Support simple 'mvn clean compile' command (move shading before the compile phase)
[
https://issues.apache.org/jira/browse/RATIS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242821#comment-16242821
]
Hadoop QA commented on RATIS-132:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
46s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
13s{color} | {color:red} root in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
11s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
10s{color} | {color:red} ratis-hadoop-shaded in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
8s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 37s{color}
| {color:red} ratis-proto-shaded generated 100 new + 0 unchanged - 0 fixed =
100 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 10s{color}
| {color:red} ratis-hadoop-shaded in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 8s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
27s{color} | {color:red} root generated 419 new + 22 unchanged - 0 fixed = 441
total (was 22) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
6s{color} | {color:green} ratis-proto-shaded in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 9s{color}
| {color:red} ratis-hadoop-shaded in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 5m 44s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 59s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2017-11-07
|
| JIRA Issue | RATIS-132 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896487/RATIS-132.002.patch |
| Optional Tests | asflicense javac javadoc unit xml compile |
| uname | Linux 255bfe3ef224 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7
11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 6d0d114 |
| Default Java | 1.8.0_131 |
| compile |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/branch-compile-root.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/patch-mvninstall-root.txt
|
| compile |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/patch-compile-ratis-hadoop-shaded.txt
|
| compile |
[jira] [Commented] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent
[
https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242810#comment-16242810
]
Jing Zhao commented on RATIS-77:
I think the original comment is correct, and we should change the protobuf
definition so that it returns a stream.
> "RaftServerProtocolService" and " GRpc.proto" inconsistent
> --
>
> Key: RATIS-77
> URL: https://issues.apache.org/jira/browse/RATIS-77
> Project: Ratis
> Issue Type: Bug
>Reporter: kaiyangzhang
>Assignee: Jing Zhao
>
> *Maybe a bug, look at the comments in the code and GRpc.proto*
> {code:title=GRpc.proto|borderStyle=solid}
>..
>..
>//Executes a client-streaming call , return only one response.
>rpc installSnapshot(stream ratis.common.InstallSnapshotRequestProto)
> returns(ratis.common.InstallSnapshotReplyProto) {}
>...
>...
> {code}
> {code:title=RaftServerProtocolService.java |borderStyle=solid}
>
>
> @Override
> public StreamObserver installSnapshot(
> StreamObserver responseObserver) {
> return new StreamObserver() {
> @Override
> public void onNext(InstallSnapshotRequestProto request) {
> try {
> //receive a client-streaming call, return a response stream
> //code and GRpc.proto inconsistent
> final InstallSnapshotReplyProto reply =
> server.installSnapshot(request);
> responseObserver.onNext(reply);
> } catch (Throwable e) {
> LOG.info("{} got exception when handling installSnapshot {}: {}",
> id, request.getServerRequest(), e);
> responseObserver.onError(RaftGrpcUtil.wrapException(e));
> }
> }
>..
>..
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent
[
https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao reassigned RATIS-77:
--
Assignee: (was: Jing Zhao)
> "RaftServerProtocolService" and " GRpc.proto" inconsistent
> --
>
> Key: RATIS-77
> URL: https://issues.apache.org/jira/browse/RATIS-77
> Project: Ratis
> Issue Type: Bug
>Reporter: kaiyangzhang
>
> *Maybe a bug, look at the comments in the code and GRpc.proto*
> {code:title=GRpc.proto|borderStyle=solid}
>..
>..
>//Executes a client-streaming call , return only one response.
>rpc installSnapshot(stream ratis.common.InstallSnapshotRequestProto)
> returns(ratis.common.InstallSnapshotReplyProto) {}
>...
>...
> {code}
> {code:title=RaftServerProtocolService.java |borderStyle=solid}
>
>
> @Override
> public StreamObserver installSnapshot(
> StreamObserver responseObserver) {
> return new StreamObserver() {
> @Override
> public void onNext(InstallSnapshotRequestProto request) {
> try {
> //receive a client-streaming call, return a response stream
> //code and GRpc.proto inconsistent
> final InstallSnapshotReplyProto reply =
> server.installSnapshot(request);
> responseObserver.onNext(reply);
> } catch (Throwable e) {
> LOG.info("{} got exception when handling installSnapshot {}: {}",
> id, request.getServerRequest(), e);
> responseObserver.onError(RaftGrpcUtil.wrapException(e));
> }
> }
>..
>..
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (RATIS-132) Support simple 'mvn clean compile' command (move shading before the compile phase)
[
https://issues.apache.org/jira/browse/RATIS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elek, Marton updated RATIS-132:
---
Attachment: RATIS-132.002.patch
Thank you [~szetszwo] to point to this problem. You are exactly right.
Under the hood the protobuf-maven-plugin marks the
generated-sources/protobuf/java directory as additional compileSourceRoot. If
we ignore the protobuf compilation, this is also missing and the generated
classes won't be on the classpath.
In the improved path I modified the outputDirectory to the src/main/java, and
also turned off the clearOutputDirectory option as both invocation (normal +
grpc) use the same output directory. According to the doc of this option it's
safe to turn off: _"With the latest versions of protoc (2.5.0 or later) this
[=clearOuputDirectory] is generally not required, although some earlier
versions reportedly had issues with running two code generations in a row
without clearing out the output directory in between."_
> Support simple 'mvn clean compile' command (move shading before the compile
> phase)
> ---
>
> Key: RATIS-132
> URL: https://issues.apache.org/jira/browse/RATIS-132
> Project: Ratis
> Issue Type: Bug
>Reporter: Elek, Marton
>Assignee: Elek, Marton
>Priority: Trivial
> Attachments: RATIS-132.001.patch, RATIS-132.002.patch
>
>
> The current situation is described in the BUILDING.md:
> {code}
> When building Ratis the first time, shaded files need to be generated by the
> following command:
> ```
> $ mvn package -DskipTests
> ```
> After that, `mvn compile` or `mvn test` can be used as normal.
> For example, we may run the basic tests by
> ```
> {code}
> In short: the shading phase is bound to the 'package' maven phase, therefore
> we can't use 'mvn clean install' just 'mvn clean package' because the package
> phase should be done before the compilation of ratis-proto-shaded.
> This blocks the nightly build as yetus uses one 'mvn clean compile' or 'mvn
> clean test-compile' without invoking the package phase.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RATIS-77) "RaftServerProtocolService" and " GRpc.proto" inconsistent
[
https://issues.apache.org/jira/browse/RATIS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242621#comment-16242621
]
Tsz Wo Nicholas Sze commented on RATIS-77:
--
> //Executes a client-streaming call , return only one response.
This comment is not in GRpc.proto anymore.
Is this still a problem?
> "RaftServerProtocolService" and " GRpc.proto" inconsistent
> --
>
> Key: RATIS-77
> URL: https://issues.apache.org/jira/browse/RATIS-77
> Project: Ratis
> Issue Type: Bug
>Reporter: kaiyangzhang
>Assignee: Jing Zhao
>
> *Maybe a bug, look at the comments in the code and GRpc.proto*
> {code:title=GRpc.proto|borderStyle=solid}
>..
>..
>//Executes a client-streaming call , return only one response.
>rpc installSnapshot(stream ratis.common.InstallSnapshotRequestProto)
> returns(ratis.common.InstallSnapshotReplyProto) {}
>...
>...
> {code}
> {code:title=RaftServerProtocolService.java |borderStyle=solid}
>
>
> @Override
> public StreamObserver installSnapshot(
> StreamObserver responseObserver) {
> return new StreamObserver() {
> @Override
> public void onNext(InstallSnapshotRequestProto request) {
> try {
> //receive a client-streaming call, return a response stream
> //code and GRpc.proto inconsistent
> final InstallSnapshotReplyProto reply =
> server.installSnapshot(request);
> responseObserver.onNext(reply);
> } catch (Throwable e) {
> LOG.info("{} got exception when handling installSnapshot {}: {}",
> id, request.getServerRequest(), e);
> responseObserver.onError(RaftGrpcUtil.wrapException(e));
> }
> }
>..
>..
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (RATIS-136) Reduce log level for segment rollover
[ https://issues.apache.org/jira/browse/RATIS-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mukul Kumar Singh updated RATIS-136: Attachment: RATIS-136.002.patch > Reduce log level for segment rollover > - > > Key: RATIS-136 > URL: https://issues.apache.org/jira/browse/RATIS-136 > Project: Ratis > Issue Type: Bug >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh > Attachments: RATIS-136.001.patch, RATIS-136.002.patch > > > ratis logs every segment rollover, this does generate lots of log entries in > the log file for Ozone. This patch will reduce the log entries for some of > the log entries. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RATIS-134) PeerProxyMap#addPeers should add peers only if it is not already present in the proxymap
[
https://issues.apache.org/jira/browse/RATIS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242127#comment-16242127
]
Hadoop QA commented on RATIS-134:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
46s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
22s{color} | {color:red} ratis-common in master failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
6s{color} | {color:red} ratis-common in master failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
6s{color} | {color:red} ratis-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
5s{color} | {color:red} ratis-common in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 5s{color}
| {color:red} ratis-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 6s{color}
| {color:red} ratis-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 4m 58s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2017-11-07
|
| JIRA Issue | RATIS-134 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896438/RATIS-134.002.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux 228e28332d38 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 6d0d114 |
| Default Java | 1.8.0_131 |
| mvninstall |
https://builds.apache.org/job/PreCommit-RATIS-Build/17/artifact/out/branch-mvninstall-ratis-common.txt
|
| compile |
https://builds.apache.org/job/PreCommit-RATIS-Build/17/artifact/out/branch-compile-ratis-common.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-RATIS-Build/17/artifact/out/patch-mvninstall-ratis-common.txt
|
| compile |
https://builds.apache.org/job/PreCommit-RATIS-Build/17/artifact/out/patch-compile-ratis-common.txt
|
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/17/artifact/out/patch-compile-ratis-common.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/17/artifact/out/patch-unit-ratis-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/17/testReport/ |
| modules | C: ratis-common U: ratis-common |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/17/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> PeerProxyMap#addPeers should add peers only if it is not already present in
> the proxymap
>
>
> Key: RATIS-134
> URL:
[jira] [Updated] (RATIS-134) PeerProxyMap#addPeers should add peers only if it is not already present in the proxymap
[
https://issues.apache.org/jira/browse/RATIS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukul Kumar Singh updated RATIS-134:
Attachment: RATIS-134.002.patch
> PeerProxyMap#addPeers should add peers only if it is not already present in
> the proxymap
>
>
> Key: RATIS-134
> URL: https://issues.apache.org/jira/browse/RATIS-134
> Project: Ratis
> Issue Type: Bug
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
> Attachments: RATIS-134.001.patch, RATIS-134.002.patch
>
>
> {{PeerProxyMap#addPeers}} currently adds peers to the proxyMap without
> checkint the current state. This should be optimized to allow addition only
> if the peer is not present in the proxyMap.
> {code}
> public void addPeers(Iterable newPeers) {
> for(RaftPeer p : newPeers) {
> peers.put(p.getId(), new PeerAndProxy(p));
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
