[
https://issues.apache.org/jira/browse/RATIS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242821#comment-16242821
]
Hadoop QA commented on RATIS-132:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
46s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
13s{color} | {color:red} root in master failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
11s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
10s{color} | {color:red} ratis-hadoop-shaded in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
8s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 37s{color}
| {color:red} ratis-proto-shaded generated 100 new + 0 unchanged - 0 fixed =
100 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 10s{color}
| {color:red} ratis-hadoop-shaded in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 8s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
27s{color} | {color:red} root generated 419 new + 22 unchanged - 0 fixed = 441
total (was 22) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
6s{color} | {color:green} ratis-proto-shaded in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 9s{color}
| {color:red} ratis-hadoop-shaded in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 5m 44s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 59s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2017-11-07
|
| JIRA Issue | RATIS-132 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12896487/RATIS-132.002.patch |
| Optional Tests | asflicense javac javadoc unit xml compile |
| uname | Linux 255bfe3ef224 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7
11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 6d0d114 |
| Default Java | 1.8.0_131 |
| compile |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/branch-compile-root.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/patch-mvninstall-root.txt
|
| compile |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/patch-compile-ratis-hadoop-shaded.txt
|
| compile |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/patch-compile-root.txt
|
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/diff-compile-javac-ratis-proto-shaded.txt
|
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/patch-compile-ratis-hadoop-shaded.txt
|
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/patch-compile-root.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/whitespace-eol.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/diff-javadoc-javadoc-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/patch-unit-ratis-hadoop-shaded.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/testReport/ |
| modules | C: ratis-proto-shaded ratis-hadoop-shaded . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/18/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Support simple 'mvn clean compile' command (move shading before the compile
> phase)
> -----------------------------------------------------------------------------------
>
> Key: RATIS-132
> URL: https://issues.apache.org/jira/browse/RATIS-132
> Project: Ratis
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Trivial
> Attachments: RATIS-132.001.patch, RATIS-132.002.patch
>
>
> The current situation is described in the BUILDING.md:
> {code}
> When building Ratis the first time, shaded files need to be generated by the
> following command:
> ```
> $ mvn package -DskipTests
> ```
> After that, `mvn compile` or `mvn test` can be used as normal.
> For example, we may run the basic tests by
> ```
> {code}
> In short: the shading phase is bound to the 'package' maven phase, therefore
> we can't use 'mvn clean install' just 'mvn clean package' because the package
> phase should be done before the compilation of ratis-proto-shaded.
> This blocks the nightly build as yetus uses one 'mvn clean compile' or 'mvn
> clean test-compile' without invoking the package phase.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
