[jira] [Commented] (RATIS-265) Ratis Leader flow control request from raft client to avoid OOM errors
[ https://issues.apache.org/jira/browse/RATIS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622498#comment-16622498 ] Tsz Wo Nicholas Sze commented on RATIS-265: --- [~rajeshbabu], thanks for the patch! The approach looks good. - TooManyPendingRequestsException sounds too specific. How about renaming it to ServerBusyException, or even RetriableException? So that the client should retry. - There are some tabs in TooManyPendingRequestsException.java. We uses two-space for indentation. > Ratis Leader flow control request from raft client to avoid OOM errors > -- > > Key: RATIS-265 > URL: https://issues.apache.org/jira/browse/RATIS-265 > Project: Ratis > Issue Type: Bug > Components: server >Affects Versions: 0.2.0 >Reporter: Mukul Kumar Singh >Assignee: Rajeshbabu Chintaguntla >Priority: Blocker > Labels: ozone > Attachments: RATIS-265_wip.patch > > > In scenario where there is lots of load on the Ratis leader, the leader > accepts and adds all the requests as pending appends into the sliding window. > However if there are lots of pending replies in the sliding window, the > leader should reply with an error/exception to the client to retry the > command later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-265) Ratis Leader flow control request from raft client to avoid OOM errors
[ https://issues.apache.org/jira/browse/RATIS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620562#comment-16620562 ] Rajeshbabu Chintaguntla commented on RATIS-265: --- [~szetszwo] [~msingh] Here is the wip patch. TooManyPendingRequestsException is not properly sending wired back to client from server. Looking into it. Just can you just confirm the approach am following in the patch is fine or not? > Ratis Leader flow control request from raft client to avoid OOM errors > -- > > Key: RATIS-265 > URL: https://issues.apache.org/jira/browse/RATIS-265 > Project: Ratis > Issue Type: Bug > Components: server >Affects Versions: 0.2.0 >Reporter: Mukul Kumar Singh >Assignee: Rajeshbabu Chintaguntla >Priority: Blocker > Labels: ozone > Attachments: RATIS-265_wip.patch > > > In scenario where there is lots of load on the Ratis leader, the leader > accepts and adds all the requests as pending appends into the sliding window. > However if there are lots of pending replies in the sliding window, the > leader should reply with an error/exception to the client to retry the > command later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-265) Ratis Leader flow control request from raft client to avoid OOM errors
[ https://issues.apache.org/jira/browse/RATIS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554572#comment-16554572 ] Tsz Wo Nicholas Sze commented on RATIS-265: --- Maintaining a limit in PendingRequests sounds good. > Ratis Leader flow control request from raft client to avoid OOM errors > -- > > Key: RATIS-265 > URL: https://issues.apache.org/jira/browse/RATIS-265 > Project: Ratis > Issue Type: Bug > Components: server >Affects Versions: 0.2.0 >Reporter: Mukul Kumar Singh >Assignee: Rajeshbabu Chintaguntla >Priority: Blocker > Labels: ozone > > In scenario where there is lots of load on the Ratis leader, the leader > accepts and adds all the requests as pending appends into the sliding window. > However if there are lots of pending replies in the sliding window, the > leader should reply with an error/exception to the client to retry the > command later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-265) Ratis Leader flow control request from raft client to avoid OOM errors
[ https://issues.apache.org/jira/browse/RATIS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554565#comment-16554565 ] Rajeshbabu Chintaguntla commented on RATIS-265: --- [~szetszwo] I can use PendingRequests for maintaining the limit and counters of pending requests and the limit can be configurable right? Can throw exception if the requests count reaches limit. > Ratis Leader flow control request from raft client to avoid OOM errors > -- > > Key: RATIS-265 > URL: https://issues.apache.org/jira/browse/RATIS-265 > Project: Ratis > Issue Type: Bug > Components: server >Affects Versions: 0.2.0 >Reporter: Mukul Kumar Singh >Assignee: Rajeshbabu Chintaguntla >Priority: Blocker > Labels: ozone > > In scenario where there is lots of load on the Ratis leader, the leader > accepts and adds all the requests as pending appends into the sliding window. > However if there are lots of pending replies in the sliding window, the > leader should reply with an error/exception to the client to retry the > command later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-265) Ratis Leader flow control request from raft client to avoid OOM errors
[ https://issues.apache.org/jira/browse/RATIS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536636#comment-16536636 ] Tsz Wo Nicholas Sze commented on RATIS-265: --- We should limit the number of pending requests in RaftServerImpl.submitClientRequestAsync instead of in the sliding window. Sliding window is per client. It won't help the OOM problem if there are many clients. > Ratis Leader flow control request from raft client to avoid OOM errors > -- > > Key: RATIS-265 > URL: https://issues.apache.org/jira/browse/RATIS-265 > Project: Ratis > Issue Type: Bug >Affects Versions: 0.2.0-alpha >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Fix For: 0.2.0-alpha > > > In scenario where there is lots of load on the Ratis leader, the leader > accepts and adds all the requests as pending appends into the sliding window. > However if there are lots of pending replies in the sliding window, the > leader should reply with an error/exception to the client to retry the > command later. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
