[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[ https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905593#comment-16905593 ] Ankit Singhal commented on RATIS-654: - Thank you [~szetszwo] for the review. > Fix generation LICENSE and NOTICE for third-party dependencies > -- > > Key: RATIS-654 > URL: https://issues.apache.org/jira/browse/RATIS-654 > Project: Ratis > Issue Type: Bug > Components: build >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Fix For: 0.4.0 > > Attachments: RATIS-654.patch, RATIS-654_v1.patch, RATIS-654_v2.patch > > > Details on licenses, what can be bundled and what can't be as per apache:- > http://www.apache.org/legal/resolved.html > Below is the guide on how a dev should be assembling LICENSE and NOTICE: > http://www.apache.org/dev/licensing-howto.html > We need to include LICENSE and NOTICE for transitive dependencies as well > http://www.apache.org/dev/licensing-howto.html#deps-of-deps > The supplemental model[s1] of maven can help in supplementing missing > information of LICENSE and NOTICE in the third-party dependencies in our > bundled LICENSE and NOTICE > [1] > https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html > Here, I have copied the resource-bundle created by HBase , so that we don't > need to re-write whole logic of generating LICENSE and NOTICE in apache way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[ https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905570#comment-16905570 ] Tsz Wo Nicholas Sze commented on RATIS-654: --- +1 the v2 patch looks good. > -1whitespace 0m 0s The patch 5 line(s) with tabs. Will fix the tabs when committing the patch. > Fix generation LICENSE and NOTICE for third-party dependencies > -- > > Key: RATIS-654 > URL: https://issues.apache.org/jira/browse/RATIS-654 > Project: Ratis > Issue Type: Bug > Components: build >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Attachments: RATIS-654.patch, RATIS-654_v1.patch, RATIS-654_v2.patch > > > Details on licenses, what can be bundled and what can't be as per apache:- > http://www.apache.org/legal/resolved.html > Below is the guide on how a dev should be assembling LICENSE and NOTICE: > http://www.apache.org/dev/licensing-howto.html > We need to include LICENSE and NOTICE for transitive dependencies as well > http://www.apache.org/dev/licensing-howto.html#deps-of-deps > The supplemental model[s1] of maven can help in supplementing missing > information of LICENSE and NOTICE in the third-party dependencies in our > bundled LICENSE and NOTICE > [1] > https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html > Here, I have copied the resource-bundle created by HBase , so that we don't > need to re-write whole logic of generating LICENSE and NOTICE in apache way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[
https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905560#comment-16905560
]
Hadoop QA commented on RATIS-654:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
55s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} shellcheck {color} | {color:blue} 0m
1s{color} | {color:blue} Shellcheck was not available. {color} |
| {color:blue}0{color} | {color:blue} shelldocs {color} | {color:blue} 0m
1s{color} | {color:blue} Shelldocs was not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
6s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 5 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
8s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 30m 44s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.server.TestMetaServer |
| | ratis.logservice.TestLogServiceWithNetty |
| | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.netty.TestRaftSnapshotWithNetty |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.grpc.TestRaftSnapshotWithGrpc |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.netty.TestRaftStateMachineExceptionWithNetty |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.netty.TestRaftReconfigurationWithNetty |
| | ratis.examples.filestore.TestFileStoreWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithNetty |
| | ratis.TestMultiRaftGroup |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 Image:yetus/ratis:date2019-08-12 |
| JIRA Issue | RATIS-654 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977396/RATIS-654_v2.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
shellcheck shelldocs |
| uname | Linux b1fe0056ba23 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 4c11031 |
| maven | version: Apache Maven 3.6.0
(97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) |
| Default Java | 1.8.0_222 |
| whitespace |
https://builds.apache.org/job/PreCommit-RATIS-Build/929/artifact/out/whitespace-tabs.txt
|
| unit |
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[ https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905515#comment-16905515 ] Ankit Singhal commented on RATIS-654: - Attaching v2 taking care of the last review and adding a different assembly for examples.jar as this only bundles most of the third-party dependencies. > Fix generation LICENSE and NOTICE for third-party dependencies > -- > > Key: RATIS-654 > URL: https://issues.apache.org/jira/browse/RATIS-654 > Project: Ratis > Issue Type: Bug > Components: build >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Attachments: RATIS-654.patch, RATIS-654_v1.patch, RATIS-654_v2.patch > > > Details on licenses, what can be bundled and what can't be as per apache:- > http://www.apache.org/legal/resolved.html > Below is the guide on how a dev should be assembling LICENSE and NOTICE: > http://www.apache.org/dev/licensing-howto.html > We need to include LICENSE and NOTICE for transitive dependencies as well > http://www.apache.org/dev/licensing-howto.html#deps-of-deps > The supplemental model[s1] of maven can help in supplementing missing > information of LICENSE and NOTICE in the third-party dependencies in our > bundled LICENSE and NOTICE > [1] > https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html > Here, I have copied the resource-bundle created by HBase , so that we don't > need to re-write whole logic of generating LICENSE and NOTICE in apache way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[
https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905508#comment-16905508
]
Hadoop QA commented on RATIS-654:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
7s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 5 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
7s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 32s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
18s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 43s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.netty.TestLogAppenderWithNetty |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 Image:yetus/ratis:date2019-08-12 |
| JIRA Issue | RATIS-654 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12977059/RATIS-654_v1.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 4c62e8d1aa0f 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 4c11031 |
| maven | version: Apache Maven 3.6.0
(97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) |
| Default Java | 1.8.0_222 |
| whitespace |
https://builds.apache.org/job/PreCommit-RATIS-Build/928/artifact/out/whitespace-tabs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/928/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/928/testReport/ |
| Max. process+thread count | 2395 (vs. ulimit of 5000) |
| modules | C: ratis-metrics ratis-resource-bundle . ratis-assembly U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/928/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Fix generation LICENSE and NOTICE for third-party dependencies
> --
>
> Key: RATIS-654
> URL: https://issues.apache.org/jira/browse/RATIS-654
> Project: Ratis
> Issue Type: Bug
> Components: build
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Attachments:
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[
https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905490#comment-16905490
]
Tsz Wo Nicholas Sze commented on RATIS-654:
---
- ratis-assembly/pom.xml
{code}
+org.codehaus.mojo
+exec-maven-plugin
+1.3.1
{code}
The version can be omitted since it is already specified in the parent pom.
- pom.xml
{code}
@@ -165,7 +170,7 @@
-->
0.12
1.9
-1.3.1
+1.6.0
3.0.0
1.0-alpha-8
1.0
{code}
How about we update the version to the latest as above?
> Fix generation LICENSE and NOTICE for third-party dependencies
> --
>
> Key: RATIS-654
> URL: https://issues.apache.org/jira/browse/RATIS-654
> Project: Ratis
> Issue Type: Bug
> Components: build
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Attachments: RATIS-654.patch, RATIS-654_v1.patch
>
>
> Details on licenses, what can be bundled and what can't be as per apache:-
> http://www.apache.org/legal/resolved.html
> Below is the guide on how a dev should be assembling LICENSE and NOTICE:
> http://www.apache.org/dev/licensing-howto.html
> We need to include LICENSE and NOTICE for transitive dependencies as well
> http://www.apache.org/dev/licensing-howto.html#deps-of-deps
> The supplemental model[s1] of maven can help in supplementing missing
> information of LICENSE and NOTICE in the third-party dependencies in our
> bundled LICENSE and NOTICE
> [1]
> https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html
> Here, I have copied the resource-bundle created by HBase , so that we don't
> need to re-write whole logic of generating LICENSE and NOTICE in apache way.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[
https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903186#comment-16903186
]
Ankit Singhal commented on RATIS-654:
-
Thanks [~szetszwo] for the review.
bq. If the Hadoop libraries is not included in ratis-examples*.jar. The
drawback is that the example won't be run with Hadoop RPC unless users install
the libraries themselves. It seems fine.
Raised https://issues.apache.org/jira/browse/RATIS-656 for the same
{quote}
The patch uses exec-maven-plugin 1.4. We are already using exec-maven-plugin
1.3.1 in root/pom.xml. Let's update the version from 1.3.1 to 1.4.
The indentation is off in some of the pom.xml changes.
I forgot to mention that the patch does not apply to master. Please update
your local git.
{quote}
Fixed in the new v1 patch attached.
> Fix generation LICENSE and NOTICE for third-party dependencies
> --
>
> Key: RATIS-654
> URL: https://issues.apache.org/jira/browse/RATIS-654
> Project: Ratis
> Issue Type: Bug
> Components: build
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Attachments: RATIS-654.patch, RATIS-654_v1.patch
>
>
> Details on licenses, what can be bundled and what can't be as per apache:-
> http://www.apache.org/legal/resolved.html
> Below is the guide on how a dev should be assembling LICENSE and NOTICE:
> http://www.apache.org/dev/licensing-howto.html
> We need to include LICENSE and NOTICE for transitive dependencies as well
> http://www.apache.org/dev/licensing-howto.html#deps-of-deps
> The supplemental model[s1] of maven can help in supplementing missing
> information of LICENSE and NOTICE in the third-party dependencies in our
> bundled LICENSE and NOTICE
> [1]
> https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html
> Here, I have copied the resource-bundle created by HBase , so that we don't
> need to re-write whole logic of generating LICENSE and NOTICE in apache way.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[ https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902499#comment-16902499 ] Tsz Wo Nicholas Sze commented on RATIS-654: --- [~an...@apache.org], I forgot to mention that the patch does not apply to master. Please update your local git. > Fix generation LICENSE and NOTICE for third-party dependencies > -- > > Key: RATIS-654 > URL: https://issues.apache.org/jira/browse/RATIS-654 > Project: Ratis > Issue Type: Bug > Components: build >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Attachments: RATIS-654.patch > > > Details on licenses, what can be bundled and what can't be as per apache:- > http://www.apache.org/legal/resolved.html > Below is the guide on how a dev should be assembling LICENSE and NOTICE: > http://www.apache.org/dev/licensing-howto.html > We need to include LICENSE and NOTICE for transitive dependencies as well > http://www.apache.org/dev/licensing-howto.html#deps-of-deps > The supplemental model[s1] of maven can help in supplementing missing > information of LICENSE and NOTICE in the third-party dependencies in our > bundled LICENSE and NOTICE > [1] > https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html > Here, I have copied the resource-bundle created by HBase , so that we don't > need to re-write whole logic of generating LICENSE and NOTICE in apache way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[ https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902480#comment-16902480 ] Tsz Wo Nicholas Sze commented on RATIS-654: --- Some other comments on the patch: - The patch uses exec-maven-plugin 1.4. We are already using exec-maven-plugin 1.3.1 in root/pom.xml. Let's update the version from 1.3.1 to 1.4. - The indentation is off in some of the pom.xml changes. > Fix generation LICENSE and NOTICE for third-party dependencies > -- > > Key: RATIS-654 > URL: https://issues.apache.org/jira/browse/RATIS-654 > Project: Ratis > Issue Type: Bug > Components: build >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Attachments: RATIS-654.patch > > > Details on licenses, what can be bundled and what can't be as per apache:- > http://www.apache.org/legal/resolved.html > Below is the guide on how a dev should be assembling LICENSE and NOTICE: > http://www.apache.org/dev/licensing-howto.html > We need to include LICENSE and NOTICE for transitive dependencies as well > http://www.apache.org/dev/licensing-howto.html#deps-of-deps > The supplemental model[s1] of maven can help in supplementing missing > information of LICENSE and NOTICE in the third-party dependencies in our > bundled LICENSE and NOTICE > [1] > https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html > Here, I have copied the resource-bundle created by HBase , so that we don't > need to re-write whole logic of generating LICENSE and NOTICE in apache way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[ https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902474#comment-16902474 ] Tsz Wo Nicholas Sze commented on RATIS-654: --- If the Hadoop libraries is not included in ratis-examples*.jar. The drawback is that the example won't be run with Hadoop RPC unless users install the libraries themselves. It seems fine. > Fix generation LICENSE and NOTICE for third-party dependencies > -- > > Key: RATIS-654 > URL: https://issues.apache.org/jira/browse/RATIS-654 > Project: Ratis > Issue Type: Bug > Components: build >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Attachments: RATIS-654.patch > > > Details on licenses, what can be bundled and what can't be as per apache:- > http://www.apache.org/legal/resolved.html > Below is the guide on how a dev should be assembling LICENSE and NOTICE: > http://www.apache.org/dev/licensing-howto.html > We need to include LICENSE and NOTICE for transitive dependencies as well > http://www.apache.org/dev/licensing-howto.html#deps-of-deps > The supplemental model[s1] of maven can help in supplementing missing > information of LICENSE and NOTICE in the third-party dependencies in our > bundled LICENSE and NOTICE > [1] > https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html > Here, I have copied the resource-bundle created by HBase , so that we don't > need to re-write whole logic of generating LICENSE and NOTICE in apache way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[ https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902469#comment-16902469 ] Ankit Singhal commented on RATIS-654: - bq. Another way is to include our ratis-hadoop binary but not the dependencies from ratis-hadoop. In this way, users have to install the ratis-hadoop dependencies themselves when they use ratis-hadoop. we include dependencies only in ratis-examples*.jar , you mean we should not include Hadoop libraries there? > Fix generation LICENSE and NOTICE for third-party dependencies > -- > > Key: RATIS-654 > URL: https://issues.apache.org/jira/browse/RATIS-654 > Project: Ratis > Issue Type: Bug > Components: build >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Attachments: RATIS-654.patch > > > Details on licenses, what can be bundled and what can't be as per apache:- > http://www.apache.org/legal/resolved.html > Below is the guide on how a dev should be assembling LICENSE and NOTICE: > http://www.apache.org/dev/licensing-howto.html > We need to include LICENSE and NOTICE for transitive dependencies as well > http://www.apache.org/dev/licensing-howto.html#deps-of-deps > The supplemental model[s1] of maven can help in supplementing missing > information of LICENSE and NOTICE in the third-party dependencies in our > bundled LICENSE and NOTICE > [1] > https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html > Here, I have copied the resource-bundle created by HBase , so that we don't > need to re-write whole logic of generating LICENSE and NOTICE in apache way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[ https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902391#comment-16902391 ] Tsz Wo Nicholas Sze commented on RATIS-654: --- Another way is to include our ratis-hadoop binary but not the dependencies from ratis-hadoop. In this way, users have to install the ratis-hadoop dependencies themselves when they use ratis-hadoop. > Fix generation LICENSE and NOTICE for third-party dependencies > -- > > Key: RATIS-654 > URL: https://issues.apache.org/jira/browse/RATIS-654 > Project: Ratis > Issue Type: Bug > Components: build >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Attachments: RATIS-654.patch > > > Details on licenses, what can be bundled and what can't be as per apache:- > http://www.apache.org/legal/resolved.html > Below is the guide on how a dev should be assembling LICENSE and NOTICE: > http://www.apache.org/dev/licensing-howto.html > We need to include LICENSE and NOTICE for transitive dependencies as well > http://www.apache.org/dev/licensing-howto.html#deps-of-deps > The supplemental model[s1] of maven can help in supplementing missing > information of LICENSE and NOTICE in the third-party dependencies in our > bundled LICENSE and NOTICE > [1] > https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html > Here, I have copied the resource-bundle created by HBase , so that we don't > need to re-write whole logic of generating LICENSE and NOTICE in apache way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[ https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902335#comment-16902335 ] Tsz Wo Nicholas Sze commented on RATIS-654: --- > you mean we do source release of ratis-hadoop module but not the binary > release to avoid unnecessary dependencies? Yes, we should do a binary release without ratis-hadoop. If there is a need, we may do another bin release with it (or we may release ratis-hadoop separately). > Fix generation LICENSE and NOTICE for third-party dependencies > -- > > Key: RATIS-654 > URL: https://issues.apache.org/jira/browse/RATIS-654 > Project: Ratis > Issue Type: Bug > Components: build >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Attachments: RATIS-654.patch > > > Details on licenses, what can be bundled and what can't be as per apache:- > http://www.apache.org/legal/resolved.html > Below is the guide on how a dev should be assembling LICENSE and NOTICE: > http://www.apache.org/dev/licensing-howto.html > We need to include LICENSE and NOTICE for transitive dependencies as well > http://www.apache.org/dev/licensing-howto.html#deps-of-deps > The supplemental model[s1] of maven can help in supplementing missing > information of LICENSE and NOTICE in the third-party dependencies in our > bundled LICENSE and NOTICE > [1] > https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html > Here, I have copied the resource-bundle created by HBase , so that we don't > need to re-write whole logic of generating LICENSE and NOTICE in apache way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[ https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901519#comment-16901519 ] Ankit Singhal commented on RATIS-654: - bq. HBase is a much bigger project compared to Ratis. I wonder if we would include a lot of unnecessary dependencies. Actually, LICENSE and NOTICE will be included for the dependencies only getting used in Ratis(not all listed in supplemental-models.xml) bq. BTW, we should make Ratis not depending on Hadoop (or at least an option) since you mean we do source release of ratis-hadoop module but not the binary release to avoid unnecessary dependencies? > Fix generation LICENSE and NOTICE for third-party dependencies > -- > > Key: RATIS-654 > URL: https://issues.apache.org/jira/browse/RATIS-654 > Project: Ratis > Issue Type: Bug > Components: build >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Attachments: RATIS-654.patch > > > Details on licenses, what can be bundled and what can't be as per apache:- > http://www.apache.org/legal/resolved.html > Below is the guide on how a dev should be assembling LICENSE and NOTICE: > http://www.apache.org/dev/licensing-howto.html > We need to include LICENSE and NOTICE for transitive dependencies as well > http://www.apache.org/dev/licensing-howto.html#deps-of-deps > The supplemental model[s1] of maven can help in supplementing missing > information of LICENSE and NOTICE in the third-party dependencies in our > bundled LICENSE and NOTICE > [1] > https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html > Here, I have copied the resource-bundle created by HBase , so that we don't > need to re-write whole logic of generating LICENSE and NOTICE in apache way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[ https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901472#comment-16901472 ] Tsz Wo Nicholas Sze commented on RATIS-654: --- Hi [~an...@apache.org], really appreciated that you work on this. > ... copied the resource-bundle created by HBase , ... HBase is a much bigger project compared to Ratis. I wonder if we would include a lot of unnecessary dependencies. BTW, we should make Ratis not depending on Hadoop (or at least an option) since # Hadoop has a huge dependency tree. It unnecessarily taxes the users who are not using ratis-hadoop (i.e. hadoop rpc). # The ratis-hadoop module is not well maintained. Even the unit tests may fail. > Fix generation LICENSE and NOTICE for third-party dependencies > -- > > Key: RATIS-654 > URL: https://issues.apache.org/jira/browse/RATIS-654 > Project: Ratis > Issue Type: Bug > Components: build >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Attachments: RATIS-654.patch > > > Details on licenses, what can be bundled and what can't be as per apache:- > http://www.apache.org/legal/resolved.html > Below is the guide on how a dev should be assembling LICENSE and NOTICE: > http://www.apache.org/dev/licensing-howto.html > We need to include LICENSE and NOTICE for transitive dependencies as well > http://www.apache.org/dev/licensing-howto.html#deps-of-deps > The supplemental model[s1] of maven can help in supplementing missing > information of LICENSE and NOTICE in the third-party dependencies in our > bundled LICENSE and NOTICE > [1] > https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html > Here, I have copied the resource-bundle created by HBase , so that we don't > need to re-write whole logic of generating LICENSE and NOTICE in apache way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-654) Fix generation LICENSE and NOTICE for third-party dependencies
[ https://issues.apache.org/jira/browse/RATIS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901474#comment-16901474 ] Tsz Wo Nicholas Sze commented on RATIS-654: --- [~elserj], would you like to take a look the patch? > Fix generation LICENSE and NOTICE for third-party dependencies > -- > > Key: RATIS-654 > URL: https://issues.apache.org/jira/browse/RATIS-654 > Project: Ratis > Issue Type: Bug > Components: build >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Major > Attachments: RATIS-654.patch > > > Details on licenses, what can be bundled and what can't be as per apache:- > http://www.apache.org/legal/resolved.html > Below is the guide on how a dev should be assembling LICENSE and NOTICE: > http://www.apache.org/dev/licensing-howto.html > We need to include LICENSE and NOTICE for transitive dependencies as well > http://www.apache.org/dev/licensing-howto.html#deps-of-deps > The supplemental model[s1] of maven can help in supplementing missing > information of LICENSE and NOTICE in the third-party dependencies in our > bundled LICENSE and NOTICE > [1] > https://maven.apache.org/plugins/maven-remote-resources-plugin/supplemental-models.html > Here, I have copied the resource-bundle created by HBase , so that we don't > need to re-write whole logic of generating LICENSE and NOTICE in apache way. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
