[jira] [Assigned] (RATIS-7) Code cleanup for SimpleStateMachine4Testing
[ https://issues.apache.org/jira/browse/RATIS-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jitendra Nath Pandey reassigned RATIS-7: Assignee: garvit > Code cleanup for SimpleStateMachine4Testing > --- > > Key: RATIS-7 > URL: https://issues.apache.org/jira/browse/RATIS-7 > Project: Ratis > Issue Type: Improvement >Reporter: Jing Zhao >Assignee: garvit >Priority: Minor > > The current SimpleStateMachine4Testing code can be further cleaned. E.g., > # There is an unused import > # some member fields' access can be private > We can use this jira to cleanup it code. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (RATIS-22) Add Builder for RaftClientRequestSender
Tsz Wo Nicholas Sze created RATIS-22: Summary: Add Builder for RaftClientRequestSender Key: RATIS-22 URL: https://issues.apache.org/jira/browse/RATIS-22 Project: Ratis Issue Type: Sub-task Reporter: Tsz Wo Nicholas Sze Assignee: Tsz Wo Nicholas Sze RaftClientRequestSender should provide a Builder to build objects from implementation subclasses. The idea is similar to RaftServerRpc.Builder. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (RATIS-21) Add RpcType and ServerFactory
[ https://issues.apache.org/jira/browse/RATIS-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao resolved RATIS-21. Resolution: Fixed Fix Version/s: 0.1 I've committed the patch. Thanks Nicholas! > Add RpcType and ServerFactory > - > > Key: RATIS-21 > URL: https://issues.apache.org/jira/browse/RATIS-21 > Project: Ratis > Issue Type: Sub-task >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze > Fix For: 0.1 > > Attachments: r21_20170215.patch, r21_20170216.patch > > > Add an RpcType enum so that it can identify rpc implementations such as > NETTY, GRPC, etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (RATIS-21) Add RpcType and ServerFactory
[ https://issues.apache.org/jira/browse/RATIS-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870976#comment-15870976 ] Jing Zhao commented on RATIS-21: The patch looks good to me. +1. > Add RpcType and ServerFactory > - > > Key: RATIS-21 > URL: https://issues.apache.org/jira/browse/RATIS-21 > Project: Ratis > Issue Type: Sub-task >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze > Attachments: r21_20170215.patch, r21_20170216.patch > > > Add an RpcType enum so that it can identify rpc implementations such as > NETTY, GRPC, etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RATIS-22) Add Builder for RaftClientRequestSender
[ https://issues.apache.org/jira/browse/RATIS-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-22: - Attachment: r22_20170216.patch r22_20170216.patch: adds RaftClientRequestSender.Builder and the subclass implementations. > Add Builder for RaftClientRequestSender > --- > > Key: RATIS-22 > URL: https://issues.apache.org/jira/browse/RATIS-22 > Project: Ratis > Issue Type: Sub-task >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze > Attachments: r22_20170216.patch > > > RaftClientRequestSender should provide a Builder to build objects from > implementation subclasses. The idea is similar to RaftServerRpc.Builder. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (RATIS-13) Add global unique ID for Raft Client
[
https://issues.apache.org/jira/browse/RATIS-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870859#comment-15870859
]
Tsz Wo Nicholas Sze commented on RATIS-13:
--
- The CodeInjectionForTesting changes in GRpcLogAppender and RaftServerImpl
should be reverted.
- We should not remove the following javadoc in RaftClient
{code}
-/** Set {@link RaftClient} ID. */
-public Builder setClientId(String clientId) {
+public Builder setClientId(ClientId clientId)
{code}
+1 Patch looks good other than that.
> Add global unique ID for Raft Client
>
>
> Key: RATIS-13
> URL: https://issues.apache.org/jira/browse/RATIS-13
> Project: Ratis
> Issue Type: Sub-task
>Reporter: Jing Zhao
>Assignee: Jing Zhao
> Attachments: RATIS-13.000.patch, RATIS-13.001.patch
>
>
> Similar idea as HADOOP-9688. But since we need to support various RPC
> engines, the client id is not added in the RPC layer but in the raft protocol
> layer.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Closed] (RATIS-13) Add global unique ID for Raft Client
[ https://issues.apache.org/jira/browse/RATIS-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao closed RATIS-13. -- Resolution: Fixed Fix Version/s: 0.1 I've committed the patch. > Add global unique ID for Raft Client > > > Key: RATIS-13 > URL: https://issues.apache.org/jira/browse/RATIS-13 > Project: Ratis > Issue Type: Sub-task >Reporter: Jing Zhao >Assignee: Jing Zhao > Fix For: 0.1 > > Attachments: RATIS-13.000.patch, RATIS-13.001.patch, > RATIS-13.002.patch > > > Similar idea as HADOOP-9688. But since we need to support various RPC > engines, the client id is not added in the RPC layer but in the raft protocol > layer. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RATIS-21) Add RpcType and ServerFactory
[ https://issues.apache.org/jira/browse/RATIS-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-21: - Attachment: r21_20170216.patch r21_20170216.patch: sync'ed with trunk and some minor changes. > Add RpcType and ServerFactory > - > > Key: RATIS-21 > URL: https://issues.apache.org/jira/browse/RATIS-21 > Project: Ratis > Issue Type: Sub-task >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze > Attachments: r21_20170215.patch, r21_20170216.patch > > > Add an RpcType enum so that it can identify rpc implementations such as > NETTY, GRPC, etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RATIS-13) Add global unique ID for Raft Client
[ https://issues.apache.org/jira/browse/RATIS-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-13: --- Attachment: RATIS-13.002.patch Thanks again for the review, Nicholas! Here's the 002 patch. I will commit it shortly. > Add global unique ID for Raft Client > > > Key: RATIS-13 > URL: https://issues.apache.org/jira/browse/RATIS-13 > Project: Ratis > Issue Type: Sub-task >Reporter: Jing Zhao >Assignee: Jing Zhao > Attachments: RATIS-13.000.patch, RATIS-13.001.patch, > RATIS-13.002.patch > > > Similar idea as HADOOP-9688. But since we need to support various RPC > engines, the client id is not added in the RPC layer but in the raft protocol > layer. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (RATIS-13) Add global unique ID for Raft Client
[ https://issues.apache.org/jira/browse/RATIS-13?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated RATIS-13: --- Attachment: RATIS-13.001.patch Thanks a lot for the review, Nicholas! Update the patch to address comments. > Add global unique ID for Raft Client > > > Key: RATIS-13 > URL: https://issues.apache.org/jira/browse/RATIS-13 > Project: Ratis > Issue Type: Sub-task >Reporter: Jing Zhao >Assignee: Jing Zhao > Attachments: RATIS-13.000.patch, RATIS-13.001.patch > > > Similar idea as HADOOP-9688. But since we need to support various RPC > engines, the client id is not added in the RPC layer but in the raft protocol > layer. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
