[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946962#comment-15946962 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user yilingfeng closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/69 > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903251#comment-15903251 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 [![Coverage Status](https://coveralls.io/builds/10512144/badge)](https://coveralls.io/builds/10512144) Changes Unknown when pulling **e91b85072365df42afa7854305663bfb645714d2 on yilingfeng:master** into ** on apache:master**. > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903250#comment-15903250 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 [![Coverage Status](https://coveralls.io/builds/10512144/badge)](https://coveralls.io/builds/10512144) Changes Unknown when pulling **e91b85072365df42afa7854305663bfb645714d2 on yilingfeng:master** into ** on apache:master**. > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903249#comment-15903249 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 [![Coverage Status](https://coveralls.io/builds/10512144/badge)](https://coveralls.io/builds/10512144) Changes Unknown when pulling **e91b85072365df42afa7854305663bfb645714d2 on yilingfeng:master** into ** on apache:master**. > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902348#comment-15902348 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 @zhouxinyu Thanks for clarifying it! ;) If we don't want to test the private method too, I am ok with the tests now to be merged. > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902319#comment-15902319 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user yilingfeng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 What does it mean? @vongosling @shroman > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900806#comment-15900806 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 @yilingfeng Great :+1: But let's have a new PR for that, as @vongosling commented above (if I understood it correctly)? > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900795#comment-15900795 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user yilingfeng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 Sorry, I’ve modified the unit tests. @shroman > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900752#comment-15900752 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 @vongosling I meant "If I were you, I would ..." :) Anyway, I don't see why this pr can be merged if a unit test can be easily written. I think we have to accept PRs with tests, except for the cases when they cannot be implemented. Ok, then let's close this pr? and tests can be submitted in another one. @yilingfeng I have a quick look, and here is what I think. Better name the file `MessageClientIDSetterTest.java` and have tests for `getNearlyTimeFromID()` etc. instead of implementing another method in your unit test class. > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900737#comment-15900737 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 thanks @yilingfeng . Consider this PR has been merged, we will commit your unit-test in another commit. @shroman I have a same understand as @zhouxinyu about your unit-test said :-) > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900718#comment-15900718 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user yilingfeng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 Ok,I've added a unit test. @lizhanhui @shroman > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15900576#comment-15900576 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 @zhouxinyu Probably you misunderstood what I meant :) -- this PR needs unit tests. I think it's the responsibility of the person who submitted PR to create them, whenever possible, since it reflects his/her intentions. @yilingfeng Can you please add unit tests? > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887256#comment-15887256 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user yilingfeng commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 Thank you for your detailed and clear explanation. It was very helpful and understandable. @Jaskey > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887149#comment-15887149 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user Jaskey commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 From java doc, 0 of `HOUR` is representing noon or midnight. So this problem exists if we call the method after 12:am, the HOUR will becomes 12 RATHER than 0, which may result in problems. Good catch and nice job. FYI: you could try with different system clock, which will give you different result. Calendar cal = Calendar.getInstance(); cal.set(Calendar.DAY_OF_MONTH, 1); cal.set(Calendar.HOUR, 0); cal.set(Calendar.MINUTE, 0); cal.set(Calendar.SECOND, 0); cal.set(Calendar.MILLISECOND, 0); System.out.println(new Date(cal.getTimeInMillis())); System.out.println(cal.get(Calendar.AM_PM)); > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885017#comment-15885017 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 +1 > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885014#comment-15885014 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 Good catch. Looks good to me. > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-111) fix possible MQClientException when query message before today
[ https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884213#comment-15884213 ] ASF GitHub Bot commented on ROCKETMQ-111: - Github user coveralls commented on the issue: https://github.com/apache/incubator-rocketmq/pull/69 [![Coverage Status](https://coveralls.io/builds/10328299/badge)](https://coveralls.io/builds/10328299) Coverage increased (+0.06%) to 31.58% when pulling **45647c0f48f46e0eb75eb3504d4f71ee03c4e27a on yilingfeng:master** into **573b22c37806a21543b90707bcce6022243a62da on apache:master**. > fix possible MQClientException when query message before today > -- > > Key: ROCKETMQ-111 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-111 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-commons >Affects Versions: 4.0.0-incubating >Reporter: Yiling Feng >Assignee: Jixiang Jin > Labels: build > Fix For: 4.0.0-incubating > > > Using "cal.set(Calendar.HOUR,0);" when query message before today which may > result in : > "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC: > query message by key finished, but no message. " > "HOUR" is used for the 12-hour clock.This will cause the start time of the > query message to be greater than the creation time of the message. > Implemenations: > Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour > clock. -- This message was sent by Atlassian JIRA (v6.3.15#6346)