[jira] [Commented] (SCB-796) Update the paas-lager package
[
https://issues.apache.org/jira/browse/SCB-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566350#comment-16566350
]
ASF GitHub Bot commented on SCB-796:
asifdxtreme closed pull request #408: SCB-796 Update the paas-lager package
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/408
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/glide.yaml b/glide.yaml
index 2a8830a0..fce282ba 100644
--- a/glide.yaml
+++ b/glide.yaml
@@ -3,9 +3,9 @@ import:
- package: github.com/Knetic/govaluate
version: 91facc4ae520fef82c9aee6b6ae720d9ae789131
repo: https://github.com/Knetic/govaluate
-- package: github.com/ServiceComb/paas-lager
- version: 378a833fc008d8343083dc73e77db142afccf377
- repo: https://github.com/ServiceComb/paas-lager
+- package: github.com/go-chassis/paas-lager
+ version: master
+ repo: https://github.com/go-chassis/paas-lager
subpackages:
- third_party/forked/cloudfoundry/lager
- package: github.com/Shopify/sarama
diff --git a/pkg/etcdsync/mutex.go b/pkg/etcdsync/mutex.go
index cc7fc2d0..81070f8f 100644
--- a/pkg/etcdsync/mutex.go
+++ b/pkg/etcdsync/mutex.go
@@ -133,7 +133,7 @@ func (m *DLock) Lock(wait bool) (err error) {
return fmt.Errorf("Key %s is locked by id=%s", m.builder.key,
m.id)
}
- util.Logger().Warnf(err, "Key %s is locked, waiting for other node
releases it, id=%s", m.builder.key, m.id)
+ util.Logger().Errorf(err, "Key %s is locked, waiting for other node
releases it, id=%s, %s", m.builder.key, m.id)
ctx, cancel := context.WithTimeout(m.builder.ctx,
time.Duration(m.builder.ttl)*time.Second)
util.Go(func(context.Context) {
@@ -149,7 +149,7 @@ func (m *DLock) Lock(wait bool) (err error) {
return nil
}))
if err != nil {
- util.Logger().Warnf(nil, "%s, key=%s, id=%s",
err.Error(), m.builder.key, m.id)
+ util.Logger().Warnf("%s, key=%s, id=%s", err.Error(),
m.builder.key, m.id)
}
})
select {
diff --git a/pkg/grace/grace.go b/pkg/grace/grace.go
index e53c6d44..2d188559 100644
--- a/pkg/grace/grace.go
+++ b/pkg/grace/grace.go
@@ -157,7 +157,7 @@ func fork() (err error) {
util.Logger().Errorf(err, "fork a process failed, %v", args)
return
}
- util.Logger().Warnf(nil, "fork process %v", args)
+ util.Logger().Warnf("fork process %v", args)
return
}
diff --git a/pkg/plugin/loader.go b/pkg/plugin/loader.go
index 0306ef22..f5a3bbac 100644
--- a/pkg/plugin/loader.go
+++ b/pkg/plugin/loader.go
@@ -49,7 +49,7 @@ func (pm *Loader) Init() {
err := pm.ReloadPlugins()
if len(pm.Plugins) == 0 {
- util.Logger().Warnf(err, "no any plugin has been loaded.")
+ util.Logger().Errorf(err, "no any plugin has been loaded.")
}
}
diff --git a/pkg/rest/server.go b/pkg/rest/server.go
index 06bbcaa3..0bcabb60 100644
--- a/pkg/rest/server.go
+++ b/pkg/rest/server.go
@@ -260,10 +260,10 @@ func (srv *Server) gracefulStop(d time.Duration) {
}
if n != 0 {
- util.Logger().Warnf(nil, "%s timed out, force close %d
connection(s)", d, n)
+ util.Logger().Warnf("%s timed out, force close %d
connection(s)", d, n)
err := srv.Server.Close()
if err != nil {
- util.Logger().Warnf(err, "server close failed")
+ util.Logger().Errorf(err, "server close failed")
}
}
}
diff --git a/pkg/tlsutil/tlsutil.go b/pkg/tlsutil/tlsutil.go
index b50acd17..4995ecd8 100644
--- a/pkg/tlsutil/tlsutil.go
+++ b/pkg/tlsutil/tlsutil.go
@@ -42,7 +42,7 @@ func ParseSSLCipherSuites(ciphers string,
permitTlsCipherSuiteMap map[string]uin
cipherSuiteList = append(cipherSuiteList, cipherSuite)
} else {
// 配置算法不存在
- util.Logger().Warnf(nil, "cipher %s not exist.",
cipherSuiteName)
+ util.Logger().Warnf("cipher %s not exist.",
cipherSuiteName)
}
}
@@ -58,7 +58,7 @@ func ParseSSLProtocol(sprotocol string) uint16 {
if protocol, ok := TLS_VERSION_MAP[sprotocol]; ok {
result = protocol
} else {
- util.Logger().Warnf(nil, "invalid ssl minimal version(%s), use
default.", sprotocol)
+ util.Logger().Warnf("invalid ssl minimal version(%s), use
default.", sprotocol)
}
return result
diff --git a/pkg/util/log.go b/pkg/util/log.go
index
[jira] [Commented] (SCB-792) More abundant metrics information
[
https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566348#comment-16566348
]
ASF GitHub Bot commented on SCB-792:
asifdxtreme closed pull request #407: SCB-792 More abundant metrics information
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/docs/README.md b/docs/README.md
index 481d3f8e..5a9f8aa1 100644
--- a/docs/README.md
+++ b/docs/README.md
@@ -6,7 +6,7 @@
- [Api
Documentation](https://rawcdn.githack.com/ServiceComb/service-center/master/docs/api-docs.html)
- [Contribution Guide](/docs/contribution.md)
+- [Plug-in Extension](/server/plugin/README.md)
[Docker Image Guide](/scripts/docker)
@@ -14,4 +14,14 @@
- [Making Front-end Image](/scripts/docker/build-frontend-image)
- [Deploy Service-Center in Cluster](/docs/sc-cluster.md)
+ Deploy Service-Center
+
+- [Cluster Deployment](/docs/sc-cluster.md)
+
+- [Deploy with TLS](/docs/security-tls.md)
+
+ Monitoring Service-Center
+
+- [Integrate with Grafana](/docs/integration-grafana.md)
+
+ [Contribution Guide](/docs/contribution.md)
\ No newline at end of file
diff --git a/docs/integration-grafana.PNG b/docs/integration-grafana.PNG
new file mode 100644
index ..e8e96090
Binary files /dev/null and b/docs/integration-grafana.PNG differ
diff --git a/docs/integration-grafana.md b/docs/integration-grafana.md
new file mode 100644
index ..1909fd85
--- /dev/null
+++ b/docs/integration-grafana.md
@@ -0,0 +1,9 @@
+# Integrate with Grafana
+
+As Service-Center uses Prometheus lib to report metrics.
+Then it is easy to integrate with Grafana.
+Here is a [template](/integration/health-metrics-grafana.json) file can be
imported in Grafana.
+
+After the import, you can get the view like blow.
+
+
\ No newline at end of file
diff --git a/docs/security_tls.md b/docs/security-tls.md
similarity index 100%
rename from docs/security_tls.md
rename to docs/security-tls.md
diff --git a/glide.yaml b/glide.yaml
index 2a8830a0..fce282ba 100644
--- a/glide.yaml
+++ b/glide.yaml
@@ -3,9 +3,9 @@ import:
- package: github.com/Knetic/govaluate
version: 91facc4ae520fef82c9aee6b6ae720d9ae789131
repo: https://github.com/Knetic/govaluate
-- package: github.com/ServiceComb/paas-lager
- version: 378a833fc008d8343083dc73e77db142afccf377
- repo: https://github.com/ServiceComb/paas-lager
+- package: github.com/go-chassis/paas-lager
+ version: master
+ repo: https://github.com/go-chassis/paas-lager
subpackages:
- third_party/forked/cloudfoundry/lager
- package: github.com/Shopify/sarama
diff --git a/integration/health-metrics-grafana.json
b/integration/health-metrics-grafana.json
index fdc80d25..7b435ba3 100644
--- a/integration/health-metrics-grafana.json
+++ b/integration/health-metrics-grafana.json
@@ -109,7 +109,7 @@
},
"gridPos": {
"h": 3,
-"w": 2,
+"w": 4,
"x": 0,
"y": 0
},
@@ -171,88 +171,6 @@
],
"valueName": "current"
},
-{
- "cacheTimeout": null,
- "colorBackground": false,
- "colorValue": false,
- "colors": [
-"#299c46",
-"rgba(237, 129, 40, 0.89)",
-"#d44a3a"
- ],
- "datasource": "${DS_LOCAL}",
- "format": "none",
- "gauge": {
-"maxValue": 100,
-"minValue": 0,
-"show": false,
-"thresholdLabels": false,
-"thresholdMarkers": true
- },
- "gridPos": {
-"h": 3,
-"w": 2,
-"x": 2,
-"y": 0
- },
- "id": 19,
- "interval": null,
- "links": [],
- "mappingType": 1,
- "mappingTypes": [
-{
- "name": "value to text",
- "value": 1
-},
-{
- "name": "range to text",
- "value": 2
-}
- ],
- "maxDataPoints": 100,
- "minSpan": 4,
- "nullPointMode": "connected",
- "nullText": null,
- "postfix": "",
- "postfixFontSize": "50%",
- "prefix": "",
- "prefixFontSize": "50%",
- "rangeMaps": [
-{
- "from": "null",
- "text": "N/A",
- "to": "null"
-}
- ],
- "sparkline": {
-"fillColor": "rgba(31, 118, 189, 0.18)",
-"full": true,
-"lineColor": "rgb(31, 120, 193)",
-"show": false
- },
- "tableColumn": "",
- "targets": [
-{
- "expr":
"max(service_center_db_backend_total{job=\"service-center\"})",
- "format": "time_series",
- "instant": false,
- "intervalFactor":
[jira] [Commented] (SCB-782) [SCB-782]support revision check when use pull mode with config center
[ https://issues.apache.org/jira/browse/SCB-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566304#comment-16566304 ] ASF GitHub Bot commented on SCB-782: coveralls edited a comment on issue #851: [SCB-782]support revision check when use pull mode with config center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/851#issuecomment-409563471 [](https://coveralls.io/builds/18284010) Coverage decreased (-0.2%) to 84.918% when pulling **6cc4da2ecb0bc303fef384d485471b54aa9af995 on heyile:rkd_new_8_1** into **ebff3ee49384e78a4210291702f13ff357acd671 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-782]support revision check when use pull mode with config center > - > > Key: SCB-782 > URL: https://issues.apache.org/jira/browse/SCB-782 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-786) when instances cache is not sync to SC caused by bug, auto fix it.
[ https://issues.apache.org/jira/browse/SCB-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin resolved SCB-786. - Resolution: Done > when instances cache is not sync to SC caused by bug, auto fix it. > -- > > Key: SCB-786 > URL: https://issues.apache.org/jira/browse/SCB-786 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin resolved SCB-790. - Resolution: Done > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-782) [SCB-782]support revision check when use pull mode with config center
[ https://issues.apache.org/jira/browse/SCB-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566292#comment-16566292 ] ASF GitHub Bot commented on SCB-782: coveralls edited a comment on issue #851: [SCB-782]support revision check when use pull mode with config center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/851#issuecomment-409563471 [](https://coveralls.io/builds/18283698) Coverage decreased (-0.1%) to 84.941% when pulling **feead587aefec7be30ee341d5e15ebe69bb8ab2a on heyile:rkd_new_8_1** into **ebff3ee49384e78a4210291702f13ff357acd671 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-782]support revision check when use pull mode with config center > - > > Key: SCB-782 > URL: https://issues.apache.org/jira/browse/SCB-782 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-788) public key black/white add feature: choose server by version
[ https://issues.apache.org/jira/browse/SCB-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566291#comment-16566291 ] ASF GitHub Bot commented on SCB-788: coveralls commented on issue #846: [SCB-788] public key black/white add feature: choose server by version URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/846#issuecomment-409791801 [](https://coveralls.io/builds/18283685) Coverage decreased (-0.04%) to 85.042% when pulling **bc322ad301871596be55b6382d626135d33d6441 on weichao666:blacksupportversion** into **ebff3ee49384e78a4210291702f13ff357acd671 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > public key black/white add feature: choose server by version > > > Key: SCB-788 > URL: https://issues.apache.org/jira/browse/SCB-788 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-788) public key black/white add feature: choose server by version
[ https://issues.apache.org/jira/browse/SCB-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566255#comment-16566255 ] ASF GitHub Bot commented on SCB-788: weichao666 opened a new pull request #846: [SCB-788] public key black/white add feature: choose server by version URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/846 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > public key black/white add feature: choose server by version > > > Key: SCB-788 > URL: https://issues.apache.org/jira/browse/SCB-788 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-788) public key black/white add feature: choose server by version
[
https://issues.apache.org/jira/browse/SCB-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566251#comment-16566251
]
ASF GitHub Bot commented on SCB-788:
weichao666 closed pull request #846: [SCB-788] public key black/white add
feature: choose server by version
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/846
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java
index 617e86be7..f94ec2c15 100644
---
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java
+++
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/RestObjectMapper.java
@@ -26,7 +26,6 @@
import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.JavaType;
import com.fasterxml.jackson.databind.JsonSerializer;
-import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.SerializationFeature;
import com.fasterxml.jackson.databind.SerializerProvider;
import com.fasterxml.jackson.databind.module.SimpleModule;
diff --git a/core/src/test/java/org/apache/servicecomb/core/TestExecutors.java
b/core/src/test/java/org/apache/servicecomb/core/TestExecutors.java
index 8d64571c1..4de37b59f 100644
--- a/core/src/test/java/org/apache/servicecomb/core/TestExecutors.java
+++ b/core/src/test/java/org/apache/servicecomb/core/TestExecutors.java
@@ -56,6 +56,7 @@ public void run() {
strThreadTest = "thread Ran";
}
});
+oReactiveExecutor.close();
Assert.assertEquals("thread Ran", strThreadTest);
}
}
diff --git
a/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/AccessController.java
b/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/AccessController.java
index 9d8ff1b51..82145ae95 100644
---
a/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/AccessController.java
+++
b/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/AccessController.java
@@ -16,9 +16,12 @@
*/
package org.apache.servicecomb.authentication.provider;
+import java.lang.reflect.Field;
+import java.lang.reflect.Method;
import java.util.HashMap;
import java.util.Iterator;
import java.util.Map;
+import java.util.Map.Entry;
import org.apache.commons.lang3.StringUtils;
import org.apache.servicecomb.serviceregistry.api.registry.Microservice;
@@ -54,6 +57,8 @@
private static final String KEY_RULE_POSTFIX = ".rule";
+ private static final String TYPE_STRING_NAME = "java.lang.String";
+
private Map whiteList = new HashMap<>();
private Map blackList = new HashMap<>();
@@ -84,15 +89,40 @@ private boolean blackDenied(Microservice microservice) {
private boolean matchFound(Microservice microservice, Map ruleList) {
boolean matched = false;
for (ConfigurationItem item : ruleList.values()) {
- // TODO: Currently we only support property, not support tags. And we
will support tags later.
if (ConfigurationItem.CATEGORY_PROPERTY.equals(item.category)) {
-// TODO: Currently we only support to configure serviceName. And we
will support others later.
-if ("serviceName".equals(item.propertyName)) {
- if (isPatternMatch(microservice.getServiceName(), item.rule)) {
-matched = true;
-break;
+// we support to configure properties, e.g. serviceName, appId,
environment, alias, version and so on, also support key in properties.
+Class service = microservice.getClass();
+for (Method method : service.getDeclaredMethods()) {
+ String methodName = method.getName();
+ if (!methodName.startsWith("get"))
+continue;
+ if
(!method.getGenericReturnType().getTypeName().equals(TYPE_STRING_NAME))
+continue;
+ char[] charArray = methodName.toCharArray();
+ charArray[3] += 32;
+ String fieldName = String.valueOf(charArray, 3, charArray.length -
3);
+ if (fieldName.equals(item.propertyName)) {
+Field field;
+String fieldValue = null;
+try {
+ field = service.getDeclaredField(fieldName);
+ field.setAccessible(true);
+ fieldValue = (String) field.get(microservice);
+} catch (Exception e) {
+ LOG.error("get field by reflection failed, error message: {}",
[jira] [Resolved] (SCB-777) Support @BeanParam annotation in JAX-RS developing style
[ https://issues.apache.org/jira/browse/SCB-777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YaoHaishi resolved SCB-777. --- Resolution: Fixed PR has been merged > Support @BeanParam annotation in JAX-RS developing style > > > Key: SCB-777 > URL: https://issues.apache.org/jira/browse/SCB-777 > Project: Apache ServiceComb > Issue Type: New Feature >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Minor > Fix For: java-chassis-1.1.0 > > > @BeanParam usage reference: > https://docs.oracle.com/javaee/7/api/javax/ws/rs/BeanParam.html > We need to support such kind of param annotation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-751) The load balancer of Saga may be faced with peak problem.
[
https://issues.apache.org/jira/browse/SCB-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang reassigned SCB-751:
Assignee: justin li (was: Willem Jiang)
> The load balancer of Saga may be faced with peak problem.
> -
>
> Key: SCB-751
> URL: https://issues.apache.org/jira/browse/SCB-751
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
>Affects Versions: saga-0.2.0
> Environment: project: incubator-servicecomb-saga-0.2.0
>Reporter: Gannalyo
>Assignee: justin li
>Priority: Major
> Labels: load-balancer, saga
> Fix For: saga-0.3.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Currently, Saga's load balancer will *select a fastest 'MessageSender'* to
> send msg from pool.
> My problem:
> At some point, if every Alpha node need take 10 minutes to handle business
> for some reasons(e.g. network), that means, Saga will handle all following
> requests by the fastest 'MessageSender' within 10 minutes.
> So, I think that the performance for Saga's load balancer will get a discount.
> Of course, I believe one alpha node can handle many many requests. Just for
> improving Saga.
> Part of code from LoadBalancedClusterMessageSender.java
> {code:java}
> ...
> MessageSender messageSender = fastestSender();
> try {
> long startTime = System.nanoTime();
> AlphaResponse response = messageSender.send(event);
> senders.put(messageSender, System.nanoTime() - startTime);
> return response;
> } catch (OmegaException e) {
> throw e;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-751) The load balancer of Saga may be faced with peak problem.
[
https://issues.apache.org/jira/browse/SCB-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566215#comment-16566215
]
Willem Jiang commented on SCB-751:
--
We could apply the RoundRobbin, PickFastest load balance strategy here.
> The load balancer of Saga may be faced with peak problem.
> -
>
> Key: SCB-751
> URL: https://issues.apache.org/jira/browse/SCB-751
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
>Affects Versions: saga-0.2.0
> Environment: project: incubator-servicecomb-saga-0.2.0
>Reporter: Gannalyo
>Assignee: Willem Jiang
>Priority: Major
> Labels: load-balancer, saga
> Fix For: saga-0.3.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Currently, Saga's load balancer will *select a fastest 'MessageSender'* to
> send msg from pool.
> My problem:
> At some point, if every Alpha node need take 10 minutes to handle business
> for some reasons(e.g. network), that means, Saga will handle all following
> requests by the fastest 'MessageSender' within 10 minutes.
> So, I think that the performance for Saga's load balancer will get a discount.
> Of course, I believe one alpha node can handle many many requests. Just for
> improving Saga.
> Part of code from LoadBalancedClusterMessageSender.java
> {code:java}
> ...
> MessageSender messageSender = fastestSender();
> try {
> long startTime = System.nanoTime();
> AlphaResponse response = messageSender.send(event);
> senders.put(messageSender, System.nanoTime() - startTime);
> return response;
> } catch (OmegaException e) {
> throw e;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SCB-745) RetrySender should not throw exception when go the saga start event.
[ https://issues.apache.org/jira/browse/SCB-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-745: - Fix Version/s: saga-0.3.0 > RetrySender should not throw exception when go the saga start event. > > > Key: SCB-745 > URL: https://issues.apache.org/jira/browse/SCB-745 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Affects Versions: saga-0.2.0 >Reporter: Willem Jiang >Assignee: justin li >Priority: Major > Fix For: saga-0.3.0 > > > If Alpha Server Fail when book-service do send event, the book-service will > fail forever. > It turns out the RetrySender should not throw exception when go the saga > start event. > You can find more information here. > https://github.com/apache/incubator-servicecomb-saga/issues/217 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-745) RetrySender should not throw exception when go the saga start event.
[ https://issues.apache.org/jira/browse/SCB-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566211#comment-16566211 ] Willem Jiang commented on SCB-745: -- Hi Justin Could you take a look at this issue? It should be easy to fix by changing the strategy of load balance and retry policy for the sender. > RetrySender should not throw exception when go the saga start event. > > > Key: SCB-745 > URL: https://issues.apache.org/jira/browse/SCB-745 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Affects Versions: saga-0.2.0 >Reporter: Willem Jiang >Assignee: justin li >Priority: Major > Fix For: saga-0.3.0 > > > If Alpha Server Fail when book-service do send event, the book-service will > fail forever. > It turns out the RetrySender should not throw exception when go the saga > start event. > You can find more information here. > https://github.com/apache/incubator-servicecomb-saga/issues/217 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565482#comment-16565482 ] ASF GitHub Bot commented on SCB-792: coveralls edited a comment on issue #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#issuecomment-409155842 [](https://coveralls.io/builds/18272330) Coverage decreased (-0.1%) to 76.246% when pulling **0c50f9ca21cdc8db58b613641386d053db2e03cf on little-cui:metrics** into **7bf5c582204d6237f3c3fe61d5d6f59986796a23 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565447#comment-16565447 ] ASF GitHub Bot commented on SCB-792: codecov-io edited a comment on issue #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#issuecomment-409155366 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=h1) Report > Merging [#407](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7bf5c582204d6237f3c3fe61d5d6f59986796a23?src=pr=desc) will **decrease** coverage by `0.05%`. > The diff coverage is `51.11%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=tree) ```diff @@Coverage Diff @@ ## master #407 +/- ## == - Coverage 73.06% 73.01% -0.06% == Files 118 118 Lines9747 9746 -1 == - Hits 7122 7116 -6 - Misses 2153 2156 +3 - Partials 472 474 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.33% <ø> (ø)` | :arrow_up: | | [server/plugin/infra/tls/buildin/tls.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90bHMvYnVpbGRpbi90bHMuZ28=) | `82.08% <0%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `53.21% <0%> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.72% <0%> (ø)` | :arrow_up: | | [server/service/util/dependency\_query.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5X3F1ZXJ5Lmdv) | `51.9% <0%> (ø)` | :arrow_up: | | [server/core/backend/cacher\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9jYWNoZXJfa3YuZ28=) | `66.77% <0%> (ø)` | :arrow_up: | | [server/service/validate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdmFsaWRhdGUuZ28=) | `84.48% <0%> (ø)` | :arrow_up: | | [...ver/plugin/infra/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vZmlsZV9jb2xsZWN0b3IuZ28=) | `52.42% <0%> (ø)` | :arrow_up: | | [server/plugin/infra/tracing/buildin/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vY29tbW9uLmdv) | `50% <0%> (ø)` | :arrow_up: | | [server/core/backend/lease.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9sZWFzZS5nbw==) | `84.21% <0%> (ø)` | :arrow_up: | | ... and [20 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=footer). Last update [7bf5c58...0c50f9c](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565416#comment-16565416 ] ASF GitHub Bot commented on SCB-792: codecov-io edited a comment on issue #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#issuecomment-409155366 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=h1) Report > Merging [#407](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7bf5c582204d6237f3c3fe61d5d6f59986796a23?src=pr=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `51.11%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=tree) ```diff @@Coverage Diff @@ ## master #407 +/- ## == - Coverage 73.06% 72.99% -0.08% == Files 118 118 Lines9747 9746 -1 == - Hits 7122 7114 -8 - Misses 2153 2156 +3 - Partials 472 476 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.33% <ø> (ø)` | :arrow_up: | | [server/service/util/dependency\_query.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5X3F1ZXJ5Lmdv) | `51.9% <0%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `53.21% <0%> (ø)` | :arrow_up: | | [server/service/validate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdmFsaWRhdGUuZ28=) | `84.48% <0%> (ø)` | :arrow_up: | | [...ver/plugin/infra/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vZmlsZV9jb2xsZWN0b3IuZ28=) | `52.42% <0%> (ø)` | :arrow_up: | | [server/core/backend/cacher\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9jYWNoZXJfa3YuZ28=) | `66.77% <0%> (ø)` | :arrow_up: | | [server/plugin/infra/tls/buildin/tls.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90bHMvYnVpbGRpbi90bHMuZ28=) | `82.08% <0%> (ø)` | :arrow_up: | | [server/core/backend/lease.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9sZWFzZS5nbw==) | `84.21% <0%> (ø)` | :arrow_up: | | [server/plugin/infra/tracing/buildin/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vY29tbW9uLmdv) | `50% <0%> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.72% <0%> (ø)` | :arrow_up: | | ... and [19 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=footer). Last update [7bf5c58...0c50f9c](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/407?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565412#comment-16565412 ] ASF GitHub Bot commented on SCB-792: coveralls edited a comment on issue #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#issuecomment-409155842 [](https://coveralls.io/builds/18271632) Coverage decreased (-0.1%) to 76.283% when pulling **580b8846bd0e34712a0d22aec17e2d9eb19cd3dd on little-cui:metrics** into **7bf5c582204d6237f3c3fe61d5d6f59986796a23 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-435) Add plugin document in ServiceCenter
[ https://issues.apache.org/jira/browse/SCB-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] little-cui resolved SCB-435. Resolution: Fixed > Add plugin document in ServiceCenter > > > Key: SCB-435 > URL: https://issues.apache.org/jira/browse/SCB-435 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: Willem Jiang >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > > Current we don't have document about how to write or configure plugins for > the service-center. It could help use to customize the service-center if we > have good document for it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-745) RetrySender should not throw exception when go the saga start event.
[ https://issues.apache.org/jira/browse/SCB-745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang reassigned SCB-745: Assignee: justin li > RetrySender should not throw exception when go the saga start event. > > > Key: SCB-745 > URL: https://issues.apache.org/jira/browse/SCB-745 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Affects Versions: saga-0.2.0 >Reporter: Willem Jiang >Assignee: justin li >Priority: Major > > If Alpha Server Fail when book-service do send event, the book-service will > fail forever. > It turns out the RetrySender should not throw exception when go the saga > start event. > You can find more information here. > https://github.com/apache/incubator-servicecomb-saga/issues/217 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565383#comment-16565383 ] ASF GitHub Bot commented on SCB-792: little-cui commented on a change in pull request #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#discussion_r206894331 ## File path: integration/health-metrics-grafana.json ## @@ -31,6 +31,12 @@ "name": "Grafana", Review comment: DONE This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565345#comment-16565345 ] ASF GitHub Bot commented on SCB-792: little-cui commented on a change in pull request #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#discussion_r206884555 ## File path: server/metric/common.go ## @@ -16,17 +16,44 @@ */ package metric -import "time" +import ( + "github.com/astaxie/beego" + "net" + "sync" + "time" +) const ( - defaultMetricsSize = 100 - collectInterval= 5 * time.Second + collectInterval = 5 * time.Second Review comment: i think there are no necessary to make it configurable, because the gather just used internal for some special situations, like calculate the QPS and adjust whether to raise an overload alarm. the interval is not the report metrics period. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-796) Update the paas-lager package
[ https://issues.apache.org/jira/browse/SCB-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] little-cui resolved SCB-796. Resolution: Fixed > Update the paas-lager package > - > > Key: SCB-796 > URL: https://issues.apache.org/jira/browse/SCB-796 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-796) Update the paas-lager package
[ https://issues.apache.org/jira/browse/SCB-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565335#comment-16565335 ] ASF GitHub Bot commented on SCB-796: coveralls commented on issue #408: SCB-796 Update the paas-lager package URL: https://github.com/apache/incubator-servicecomb-service-center/pull/408#issuecomment-409577462 [](https://coveralls.io/builds/18270590) Coverage decreased (-0.06%) to 76.317% when pulling **a1bce290d2987a56f460c4d88d673aba16d9df10 on little-cui:master** into **7bf5c582204d6237f3c3fe61d5d6f59986796a23 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update the paas-lager package > - > > Key: SCB-796 > URL: https://issues.apache.org/jira/browse/SCB-796 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-796) Update the paas-lager package
[ https://issues.apache.org/jira/browse/SCB-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565334#comment-16565334 ] ASF GitHub Bot commented on SCB-796: codecov-io commented on issue #408: SCB-796 Update the paas-lager package URL: https://github.com/apache/incubator-servicecomb-service-center/pull/408#issuecomment-409577014 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408?src=pr=h1) Report > Merging [#408](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/7bf5c582204d6237f3c3fe61d5d6f59986796a23?src=pr=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `51.11%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408?src=pr=tree) ```diff @@Coverage Diff @@ ## master #408 +/- ## == - Coverage 73.06% 73.03% -0.04% == Files 118 118 Lines9747 9746 -1 == - Hits 7122 7118 -4 - Misses 2153 2154 +1 - Partials 472 474 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.33% <ø> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.72% <0%> (ø)` | :arrow_up: | | [server/core/backend/lease.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9sZWFzZS5nbw==) | `84.21% <0%> (ø)` | :arrow_up: | | [...ver/plugin/infra/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vZmlsZV9jb2xsZWN0b3IuZ28=) | `52.42% <0%> (ø)` | :arrow_up: | | [server/plugin/infra/tracing/buildin/common.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90cmFjaW5nL2J1aWxkaW4vY29tbW9uLmdv) | `50% <0%> (ø)` | :arrow_up: | | [server/service/util/dependency\_query.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5X3F1ZXJ5Lmdv) | `51.9% <0%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `53.21% <0%> (ø)` | :arrow_up: | | [server/plugin/infra/tls/buildin/tls.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS90bHMvYnVpbGRpbi90bHMuZ28=) | `82.08% <0%> (ø)` | :arrow_up: | | [server/core/backend/cacher\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvYmFja2VuZC9jYWNoZXJfa3YuZ28=) | `66.77% <0%> (ø)` | :arrow_up: | | [server/service/validate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdmFsaWRhdGUuZ28=) | `84.48% <0%> (ø)` | :arrow_up: | | ... and [18 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408?src=pr=footer). Last update [7bf5c58...a1bce29](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/408?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to
[jira] [Commented] (SCB-796) Update the paas-lager package
[ https://issues.apache.org/jira/browse/SCB-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565309#comment-16565309 ] ASF GitHub Bot commented on SCB-796: little-cui opened a new pull request #408: SCB-796 Update the paas-lager package URL: https://github.com/apache/incubator-servicecomb-service-center/pull/408 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update the paas-lager package > - > > Key: SCB-796 > URL: https://issues.apache.org/jira/browse/SCB-796 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-796) Update the paas-lager package
little-cui created SCB-796: -- Summary: Update the paas-lager package Key: SCB-796 URL: https://issues.apache.org/jira/browse/SCB-796 Project: Apache ServiceComb Issue Type: Improvement Components: Service-Center Reporter: little-cui Assignee: little-cui Fix For: service-center-1.1.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-782) [SCB-782]support revision check when use pull mode with config center
[ https://issues.apache.org/jira/browse/SCB-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565248#comment-16565248 ] ASF GitHub Bot commented on SCB-782: coveralls commented on issue #851: [SCB-782]support revision check when use pull mode with config center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/851#issuecomment-409563471 [](https://coveralls.io/builds/18269833) Coverage decreased (-0.1%) to 84.945% when pulling **fbe4f7e8e6ea752395589d4baeb03c7357797a55 on heyile:rkd_new_8_1** into **ebff3ee49384e78a4210291702f13ff357acd671 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-782]support revision check when use pull mode with config center > - > > Key: SCB-782 > URL: https://issues.apache.org/jira/browse/SCB-782 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-782) [SCB-782]support revision check when use pull mode with config center
[ https://issues.apache.org/jira/browse/SCB-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565213#comment-16565213 ] ASF GitHub Bot commented on SCB-782: heyile opened a new pull request #851: [SCB-782]support revision check when use pull mode with config center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/851 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-782]support revision check when use pull mode with config center > - > > Key: SCB-782 > URL: https://issues.apache.org/jira/browse/SCB-782 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-687) highway server not accept too many connection
[ https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yangyongzheng resolved SCB-687. --- Resolution: Fixed > highway server not accept too many connection > - > > Key: SCB-687 > URL: https://issues.apache.org/jira/browse/SCB-687 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565148#comment-16565148 ] ASF GitHub Bot commented on SCB-792: asifdxtreme commented on a change in pull request #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#discussion_r206841318 ## File path: server/metric/common.go ## @@ -16,17 +16,44 @@ */ package metric -import "time" +import ( + "github.com/astaxie/beego" + "net" + "sync" + "time" +) const ( - defaultMetricsSize = 100 - collectInterval= 5 * time.Second + collectInterval = 5 * time.Second Review comment: Suggestion : Can we make this interval time configurable? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[ https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565147#comment-16565147 ] ASF GitHub Bot commented on SCB-792: asifdxtreme commented on a change in pull request #407: SCB-792 More abundant metrics information URL: https://github.com/apache/incubator-servicecomb-service-center/pull/407#discussion_r206841975 ## File path: integration/health-metrics-grafana.json ## @@ -31,6 +31,12 @@ "name": "Grafana", Review comment: Suggestion : If possible can we add the Dashboard Snapshot image of the Grafana, currently we do not have any dashboard snapshot of this json dashbord. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > More abundant metrics information > - > > Key: SCB-792 > URL: https://issues.apache.org/jira/browse/SCB-792 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-784) SagaStart annotated method should abort the saga transaction once the exception is thrown
[
https://issues.apache.org/jira/browse/SCB-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565120#comment-16565120
]
ASF GitHub Bot commented on SCB-784:
coveralls commented on issue #235: SCB-784 SagaStart should send TxAbortEvent
when the exception is thrown
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/235#issuecomment-409534354
[](https://coveralls.io/builds/18268023)
Coverage increased (+0.2%) to 94.252% when pulling
**735fdf2b14a37e63491dcb0c440955a707a81592 on SCB-784** into
**b1c3fb9b0b36315d441d95d3fadb11a9f56fdc92 on master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SagaStart annotated method should abort the saga transaction once the
> exception is thrown
> -
>
> Key: SCB-784
> URL: https://issues.apache.org/jira/browse/SCB-784
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Saga
>Reporter: Willem Jiang
>Assignee: Willem Jiang
>Priority: Major
> Fix For: saga-0.3.0
>
>
> The below transaction should be aborted, now the Omega should send the abort
> message back to the alpha.
> {code}
> @SagaStart
> service() {
> transaction1;
> exception;
> transaction2;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-794) Edge invocation do not properly send servlet filter response code
[
https://issues.apache.org/jira/browse/SCB-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565091#comment-16565091
]
ASF GitHub Bot commented on SCB-794:
liubao68 closed pull request #849: [SCB-794]Edge invocation do not properly
send servlet filter response code
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/849
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/http/DefaultHttpClientFilter.java
b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/http/DefaultHttpClientFilter.java
index 097c39cad..bfaac0041 100644
---
a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/http/DefaultHttpClientFilter.java
+++
b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/http/DefaultHttpClientFilter.java
@@ -30,8 +30,8 @@
import org.apache.servicecomb.foundation.vertx.http.HttpServletRequestEx;
import org.apache.servicecomb.foundation.vertx.http.HttpServletResponseEx;
import org.apache.servicecomb.swagger.invocation.Response;
-import org.apache.servicecomb.swagger.invocation.exception.CommonExceptionData;
import org.apache.servicecomb.swagger.invocation.exception.ExceptionFactory;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
import org.apache.servicecomb.swagger.invocation.response.ResponseMeta;
public class DefaultHttpClientFilter implements HttpClientFilter {
@@ -79,7 +79,7 @@ protected Object extractResult(Invocation invocation,
HttpServletResponseEx resp
responseEx.getStatus(),
responseEx.getStatusType().getReasonPhrase(),
responseEx.getHeader(HttpHeaders.CONTENT_TYPE));
- return ExceptionFactory.createConsumerException(new
CommonExceptionData(msg));
+ return ExceptionFactory.createConsumerException(new
InvocationException(responseEx.getStatus(),
responseEx.getStatusType().getReasonPhrase(), msg));
}
try {
diff --git
a/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/http/TestDefaultHttpClientFilter.java
b/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/http/TestDefaultHttpClientFilter.java
index 8e6168a24..542e82c55 100644
---
a/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/http/TestDefaultHttpClientFilter.java
+++
b/transports/transport-rest/transport-rest-client/src/test/java/org/apache/servicecomb/transport/rest/client/http/TestDefaultHttpClientFilter.java
@@ -32,7 +32,6 @@
import org.apache.servicecomb.foundation.vertx.http.HttpServletResponseEx;
import org.apache.servicecomb.foundation.vertx.http.ReadStreamPart;
import org.apache.servicecomb.swagger.invocation.Response;
-import org.apache.servicecomb.swagger.invocation.exception.CommonExceptionData;
import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
import org.apache.servicecomb.swagger.invocation.response.ResponseMeta;
import org.junit.Assert;
@@ -120,15 +119,19 @@ public void
testAfterReceiveResponseNullProduceProcessor(@Mocked Invocation invo
result = operationMeta;
operationMeta.getExtData(RestConst.SWAGGER_REST_OPERATION);
result = swaggerRestOperation;
+responseEx.getStatus();
+result = 401;
}
};
Response response = filter.afterReceiveResponse(invocation, responseEx);
InvocationException exception = response.getResult();
-CommonExceptionData data = (CommonExceptionData) exception.getErrorData();
Assert.assertEquals(
-"method null, path null, statusCode 0, reasonPhrase null, response
content-type null is not supported",
-data.getMessage());
+401,
+exception.getStatusCode());
+Assert.assertEquals(
+"method null, path null, statusCode 401, reasonPhrase null, response
content-type null is not supported",
+exception.getErrorData());
}
@Test
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Edge invocation do not properly send servlet filter response code
>
[jira] [Commented] (SCB-795) update jackson from 2.9.5 to 2.9.6
[ https://issues.apache.org/jira/browse/SCB-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565093#comment-16565093 ] ASF GitHub Bot commented on SCB-795: liubao68 closed pull request #850: [SCB-795] update jackson from 2.9.5 to 2.9.6 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/850 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/java-chassis-dependencies/pom.xml b/java-chassis-dependencies/pom.xml index 0d28ba488..66d7be4d0 100644 --- a/java-chassis-dependencies/pom.xml +++ b/java-chassis-dependencies/pom.xml @@ -31,7 +31,7 @@ pom -2.9.5 +2.9.6 3.5.0 0.8 4.3.16.RELEASE diff --git a/java-chassis-distribution/src/release/LICENSE b/java-chassis-distribution/src/release/LICENSE index f69f08660..d241e547d 100644 --- a/java-chassis-distribution/src/release/LICENSE +++ b/java-chassis-distribution/src/release/LICENSE @@ -362,14 +362,14 @@ hystrix-core (https://github.com/Netflix/Hystrix) com.netflix.hystrix:hystrix-co hystrix-javanica (https://github.com/Netflix/Hystrix) com.netflix.hystrix:hystrix-javanica:jar:1.5.12 hystrix-metrics-event-stream (https://github.com/Netflix/Hystrix) com.netflix.hystrix:hystrix-metrics-event-stream:jar:1.5.12 hystrix-serialization (https://github.com/Netflix/Hystrix) com.netflix.hystrix:hystrix-serialization:jar:1.5.12 -Jackson dataformat: protobuf (http://github.com/FasterXML/jackson-dataformats-binary) com.fasterxml.jackson.dataformat:jackson-dataformat-protobuf:bundle:2.9.5 +Jackson dataformat: protobuf (http://github.com/FasterXML/jackson-dataformats-binary) com.fasterxml.jackson.dataformat:jackson-dataformat-protobuf:bundle:2.9.6 Jackson module: Afterburner (https://github.com/FasterXML/jackson-modules-base) com.fasterxml.jackson.module:jackson-module-afterburner:bundle:2.8.11 Jackson module: JAXB-annotations (http://github.com/FasterXML/jackson-module-jaxb-annotations) com.fasterxml.jackson.module:jackson-module-jaxb-annotations:bundle:2.8.11 -Jackson-annotations (http://github.com/FasterXML/jackson) com.fasterxml.jackson.core:jackson-annotations:bundle:2.9.5 -Jackson-core (https://github.com/FasterXML/jackson-core) com.fasterxml.jackson.core:jackson-core:bundle:2.9.5 -jackson-databind (http://github.com/FasterXML/jackson) com.fasterxml.jackson.core:jackson-databind:bundle:2.9.5 -Jackson-dataformat-XML (http://wiki.fasterxml.com/JacksonExtensionXmlDataBinding) com.fasterxml.jackson.dataformat:jackson-dataformat-xml:bundle:2.9.5 -Jackson-dataformat-YAML (https://github.com/FasterXML/jackson-dataformats-text) com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:bundle:2.9.5 +Jackson-annotations (http://github.com/FasterXML/jackson) com.fasterxml.jackson.core:jackson-annotations:bundle:2.9.6 +Jackson-core (https://github.com/FasterXML/jackson-core) com.fasterxml.jackson.core:jackson-core:bundle:2.9.6 +jackson-databind (http://github.com/FasterXML/jackson) com.fasterxml.jackson.core:jackson-databind:bundle:2.9.6 +Jackson-dataformat-XML (http://wiki.fasterxml.com/JacksonExtensionXmlDataBinding) com.fasterxml.jackson.dataformat:jackson-dataformat-xml:bundle:2.9.6 +Jackson-dataformat-YAML (https://github.com/FasterXML/jackson-dataformats-text) com.fasterxml.jackson.dataformat:jackson-dataformat-yaml:bundle:2.9.6 Javassist (http://www.javassist.org/) org.javassist:javassist:bundle:3.18.1-GA javax.inject (http://code.google.com/p/atinject/) javax.inject:javax.inject:jar:1 JBoss Logging 3 (http://www.jboss.org) org.jboss.logging:jboss-logging:jar:3.3.2.Final This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > update jackson from 2.9.5 to 2.9.6 > -- > > Key: SCB-795 > URL: https://issues.apache.org/jira/browse/SCB-795 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-782) [SCB-782]support revision check when use pull mode with config center
[
https://issues.apache.org/jira/browse/SCB-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565078#comment-16565078
]
ASF GitHub Bot commented on SCB-782:
heyile closed pull request #842: [SCB-782]support revision check when use pull
mode with config center
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/842
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
b/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
index a58de4da2..8ae181f15 100644
---
a/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
+++
b/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
@@ -136,7 +136,7 @@ public void connectServer() {
}
refreshMembers(memberDiscovery);
ConfigRefresh refreshTask = new ConfigRefresh(parseConfigUtils,
memberDiscovery);
-refreshTask.run(true);
+refreshTask.run();
executor.scheduleWithFixedDelay(refreshTask,
firstRefreshInterval,
refreshInterval,
@@ -160,13 +160,14 @@ private void refreshMembers(MemberDiscovery
memberDiscovery) {
String configCenter = memberDiscovery.getConfigServer();
IpPort ipPort = NetUtils.parseIpPortFromURI(configCenter);
clientMgr.findThreadBindClientPool().runOnContext(client -> {
-HttpClientRequest request = client.get(ipPort.getPort(),
ipPort.getHostOrIp(), uriConst.MEMBERS, rsp -> {
- if (rsp.statusCode() == HttpResponseStatus.OK.code()) {
-rsp.bodyHandler(buf -> {
- memberDiscovery.refreshMembers(buf.toJsonObject());
+HttpClientRequest request =
+client.get(ipPort.getPort(), ipPort.getHostOrIp(),
uriConst.MEMBERS, rsp -> {
+ if (rsp.statusCode() == HttpResponseStatus.OK.code()) {
+rsp.bodyHandler(buf -> {
+ memberDiscovery.refreshMembers(buf.toJsonObject());
+});
+ }
});
- }
-});
SignRequest signReq = createSignRequest(request.method().toString(),
configCenter + uriConst.MEMBERS,
new HashMap<>(),
@@ -174,7 +175,8 @@ private void refreshMembers(MemberDiscovery
memberDiscovery) {
if (ConfigCenterConfig.INSTANCE.getToken() != null) {
request.headers().add("X-Auth-Token",
ConfigCenterConfig.INSTANCE.getToken());
}
-authHeaderProviders.forEach(provider ->
request.headers().addAll(provider.getSignAuthHeaders(signReq)));
+authHeaderProviders.forEach(provider -> request.headers()
+.addAll(provider.getSignAuthHeaders(signReq)));
request.exceptionHandler(e -> {
LOGGER.error("Fetch member from {} failed. Error message is [{}].",
configCenter, e.getMessage());
});
@@ -235,12 +237,12 @@ private HttpClientOptions createHttpClientOptions() {
}
public void run(boolean wait) {
- // this will be single threaded, so we don't care about concurrent
- // staffs
try {
String configCenter = memberdis.getConfigServer();
if (refreshMode == 1) {
- refreshConfig(configCenter, wait);
+ //must make sure there is only one thread is invoking
refreshConfigMethod
+ //hence, we change wait parameter from false to true
+ refreshConfig(configCenter, true);
} else if (!isWatching) {
// 重新监听时需要先加载，避免在断开期间丢失变更
refreshConfig(configCenter, wait);
@@ -302,6 +304,7 @@ public void doWatch(String configCenter)
LOGGER.info("watching config recieved {}", action);
Map mAction = action.toJsonObject().getMap();
if ("CREATE".equals(mAction.get("action"))) {
+ //event loop can not be blocked,we just keep nothing changed
in push mode
refreshConfig(configCenter, false);
} else if ("MEMBER_CHANGE".equals(mAction.get("action"))) {
refreshMembers(memberdis);
@@ -314,7 +317,8 @@ public void doWatch(String configCenter)
waiter.countDown();
},
e -> {
- LOGGER.error("watcher connect to config center {} refresh port
{} failed. Error message is [{}]",
+ LOGGER.error(
+ "watcher connect to config center {} refresh port {} failed.
Error message is [{}]",
configCenter,
refreshPort,
e.getMessage());
@@ -352,12 +356,14 @@ public void
[jira] [Commented] (SCB-795) update jackson from 2.9.5 to 2.9.6
[ https://issues.apache.org/jira/browse/SCB-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564995#comment-16564995 ] ASF GitHub Bot commented on SCB-795: coveralls commented on issue #850: [SCB-795] update jackson from 2.9.5 to 2.9.6 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/850#issuecomment-409501164 [](https://coveralls.io/builds/18266359) Coverage decreased (-0.005%) to 86.7% when pulling **68afb7ddacccb1acfc5b0ace35e94152b33adffd on weichao666:updatejackson** into **0e8664d57ecaba2f36cbbf2308b6d5c63dcf1c75 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > update jackson from 2.9.5 to 2.9.6 > -- > > Key: SCB-795 > URL: https://issues.apache.org/jira/browse/SCB-795 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564961#comment-16564961 ] ASF GitHub Bot commented on SCB-790: wujimin commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206795595 ## File path: pom.xml ## @@ -313,4 +227,101 @@ + + + Review comment: there is no any log for maven-deploy-plugin This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-795) update jackson from 2.9.5 to 2.9.6
[ https://issues.apache.org/jira/browse/SCB-795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564946#comment-16564946 ] ASF GitHub Bot commented on SCB-795: weichao666 opened a new pull request #850: [SCB-795] update jackson from 2.9.5 to 2.9.6 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/850 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > update jackson from 2.9.5 to 2.9.6 > -- > > Key: SCB-795 > URL: https://issues.apache.org/jira/browse/SCB-795 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-795) update jackson from 2.9.5 to 2.9.6
WeiChao created SCB-795: --- Summary: update jackson from 2.9.5 to 2.9.6 Key: SCB-795 URL: https://issues.apache.org/jira/browse/SCB-795 Project: Apache ServiceComb Issue Type: Improvement Components: Java-Chassis Reporter: WeiChao Assignee: WeiChao Fix For: java-chassis-1.1.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564896#comment-16564896
]
ASF GitHub Bot commented on SCB-687:
liubao68 closed pull request #824: [SCB-687] add highway server connection
protection
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/824
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/integration-tests/spring-pojo-tests/src/test/java/org/apache/servicecomb/demo/pojo/test/PojoSpringMain.java
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/ClientClosedEvent.java
similarity index 60%
rename from
integration-tests/spring-pojo-tests/src/test/java/org/apache/servicecomb/demo/pojo/test/PojoSpringMain.java
rename to
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/ClientClosedEvent.java
index a81656cac..68fa037a4 100644
---
a/integration-tests/spring-pojo-tests/src/test/java/org/apache/servicecomb/demo/pojo/test/PojoSpringMain.java
+++
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/ClientClosedEvent.java
@@ -15,17 +15,26 @@
* limitations under the License.
*/
-package org.apache.servicecomb.demo.pojo.test;
+package org.apache.servicecomb.foundation.vertx;
-import org.apache.servicecomb.springboot.starter.provider.EnableServiceComb;
-import org.springframework.boot.SpringApplication;
-import org.springframework.boot.autoconfigure.SpringBootApplication;
+/**
+ * Notice: this event will raised in vertx eventloop thread, so do not run any
block code
+ */
+public class ClientClosedEvent {
+ private final String address;
+
+ private final int totalConnectedCount;
-@SpringBootApplication
-@EnableServiceComb
-public class PojoSpringMain {
+ public String getAddress() {
+return address;
+ }
+
+ public int getTotalConnectedCount() {
+return totalConnectedCount;
+ }
- public static void main(final String[] args) throws Exception {
-SpringApplication.run(PojoSpringMain.class, args);
+ public ClientClosedEvent(String address, int totalConnectedCount) {
+this.address = address;
+this.totalConnectedCount = totalConnectedCount;
}
-}
+}
\ No newline at end of file
diff --git
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/ClientConnectedEvent.java
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/ClientConnectedEvent.java
new file mode 100644
index 0..09e752e8e
--- /dev/null
+++
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/ClientConnectedEvent.java
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.foundation.vertx;
+
+import io.vertx.core.net.NetSocket;
+
+/**
+ * Notice: this event will raised in vertx eventloop thread, so do not run any
block code
+ */
+public class ClientConnectedEvent {
+ private final NetSocket netSocket;
+
+ private final int totalConnectedCount;
+
+ public NetSocket getNetSocket() {
+return netSocket;
+ }
+
+ public int getTotalConnectedCount() {
+return totalConnectedCount;
+ }
+
+ public ClientConnectedEvent(NetSocket netSocket, int totalConnectedCount) {
+this.netSocket = netSocket;
+this.totalConnectedCount = totalConnectedCount;
+ }
+}
\ No newline at end of file
diff --git
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
index a4fd6902e..a2db20637 100644
---
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
+++
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
@@ -18,14 +18,19 @@
package
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564888#comment-16564888 ] ASF GitHub Bot commented on SCB-790: wujimin commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206780066 ## File path: integration-tests/it-producer/pom.xml ## @@ -0,0 +1,25 @@ + +http://maven.apache.org/POM/4.0.0; Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564887#comment-16564887 ] ASF GitHub Bot commented on SCB-790: wujimin commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206780039 ## File path: integration-tests/it-edge/pom.xml ## @@ -0,0 +1,37 @@ + +http://maven.apache.org/POM/4.0.0; Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[
https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564886#comment-16564886
]
ASF GitHub Bot commented on SCB-790:
wujimin commented on a change in pull request #847: [SCB-790] integration test
support create new target microservice instance in one node
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206780017
##
File path:
integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/base/TestDownload.java
##
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.it.testcase.base;
+
+import org.apache.servicecomb.it.testcase.support.DownloadSchemaIntf;
+import org.apache.servicecomb.provider.pojo.Invoker;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestDownload {
+ private static DownloadSchemaIntf intf = Invoker
+ .createProxy("it-producer", "download", DownloadSchemaIntf.class);
+
+ static int x;
+
+ @Test
+ public void test1() {
+x++;
+System.out.println("test" + x);
+//intf.tempFileEntity("abc");
+ }
+
+ @Test
+ public void test2() {
+x++;
+System.out.println("test2");
+Assert.assertEquals(x, x + 1);
+ }
+// private File dir = new File("target/download");
Review comment:
commented code will be used in the future.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support create new target microservice instance in one node
> ---
>
> Key: SCB-790
> URL: https://issues.apache.org/jira/browse/SCB-790
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564884#comment-16564884 ] ASF GitHub Bot commented on SCB-790: wujimin commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206779723 ## File path: integration-tests/it-consumer/pom.xml ## @@ -0,0 +1,30 @@ + +http://maven.apache.org/POM/4.0.0; Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564882#comment-16564882 ] ASF GitHub Bot commented on SCB-790: wujimin commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206779654 ## File path: integration-tests/it-common-service/pom.xml ## @@ -0,0 +1,25 @@ + Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564883#comment-16564883 ] ASF GitHub Bot commented on SCB-790: wujimin commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206779710 ## File path: integration-tests/it-common/pom.xml ## @@ -0,0 +1,21 @@ + +http://maven.apache.org/POM/4.0.0; Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564881#comment-16564881 ] ASF GitHub Bot commented on SCB-790: wujimin commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206779621 ## File path: demo/pom.xml ## @@ -181,6 +181,7 @@ org.sonatype.plugins Review comment: done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564851#comment-16564851 ] ASF GitHub Bot commented on SCB-790: WillemJiang commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206771472 ## File path: integration-tests/it-producer/pom.xml ## @@ -0,0 +1,25 @@ + +http://maven.apache.org/POM/4.0.0; Review comment: License header. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564850#comment-16564850 ] ASF GitHub Bot commented on SCB-790: WillemJiang commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206768313 ## File path: integration-tests/it-consumer/pom.xml ## @@ -0,0 +1,30 @@ + +http://maven.apache.org/POM/4.0.0; Review comment: License header. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564853#comment-16564853 ] ASF GitHub Bot commented on SCB-790: WillemJiang commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206768080 ## File path: integration-tests/it-common/pom.xml ## @@ -0,0 +1,21 @@ + +http://maven.apache.org/POM/4.0.0; Review comment: License header. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[
https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564854#comment-16564854
]
ASF GitHub Bot commented on SCB-790:
WillemJiang commented on a change in pull request #847: [SCB-790] integration
test support create new target microservice instance in one node
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206768774
##
File path:
integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/base/TestDownload.java
##
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.it.testcase.base;
+
+import org.apache.servicecomb.it.testcase.support.DownloadSchemaIntf;
+import org.apache.servicecomb.provider.pojo.Invoker;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestDownload {
+ private static DownloadSchemaIntf intf = Invoker
+ .createProxy("it-producer", "download", DownloadSchemaIntf.class);
+
+ static int x;
+
+ @Test
+ public void test1() {
+x++;
+System.out.println("test" + x);
+//intf.tempFileEntity("abc");
+ }
+
+ @Test
+ public void test2() {
+x++;
+System.out.println("test2");
+Assert.assertEquals(x, x + 1);
+ }
+// private File dir = new File("target/download");
Review comment:
Can we remove these commented code?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support create new target microservice instance in one node
> ---
>
> Key: SCB-790
> URL: https://issues.apache.org/jira/browse/SCB-790
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564852#comment-16564852 ] ASF GitHub Bot commented on SCB-790: WillemJiang commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206774427 ## File path: pom.xml ## @@ -313,4 +227,101 @@ + + + Review comment: I think we need to add the deploy profile at the same time. You can find the travis deploy command [here](https://github.com/apache/incubator-servicecomb-java-chassis/blob/master/scripts/travis.sh#L59) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564855#comment-16564855 ] ASF GitHub Bot commented on SCB-790: WillemJiang commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206768936 ## File path: integration-tests/it-edge/pom.xml ## @@ -0,0 +1,37 @@ + +http://maven.apache.org/POM/4.0.0; Review comment: License header. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564811#comment-16564811 ] ASF GitHub Bot commented on SCB-790: WillemJiang commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206767999 ## File path: integration-tests/it-common-service/pom.xml ## @@ -0,0 +1,25 @@ + Review comment: We need to add the Apache License header here. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-790) support create new target microservice instance in one node
[ https://issues.apache.org/jira/browse/SCB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564810#comment-16564810 ] ASF GitHub Bot commented on SCB-790: WillemJiang commented on a change in pull request #847: [SCB-790] integration test support create new target microservice instance in one node URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/847#discussion_r206767859 ## File path: demo/pom.xml ## @@ -181,6 +181,7 @@ org.sonatype.plugins Review comment: I think we don't need this staging maven plugin any more, as we don't deploy the artifacts into nexus public repo. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > support create new target microservice instance in one node > --- > > Key: SCB-790 > URL: https://issues.apache.org/jira/browse/SCB-790 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-794) Edge invocation do not properly send servlet filter response code
[ https://issues.apache.org/jira/browse/SCB-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564799#comment-16564799 ] ASF GitHub Bot commented on SCB-794: liubao68 opened a new pull request #849: [SCB-794]Edge invocation do not properly send servlet filter response code URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/849 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Edge invocation do not properly send servlet filter response code > - > > Key: SCB-794 > URL: https://issues.apache.org/jira/browse/SCB-794 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: liubao >Assignee: liubao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[ https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564796#comment-16564796 ] ASF GitHub Bot commented on SCB-687: wujimin commented on a change in pull request #824: [SCB-687] add highway server connection protection URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r206766484 ## File path: integration-tests/spring-pojo-connection-limit-test/src/test/resources/microservice.yaml ## @@ -17,7 +17,7 @@ APPLICATION_ID: pojotest-it service_description: - name: pojo-connection-limit + name: pojo Review comment: at last, we will move integration test to real SC, not a mock SC, your logic will cause conflict in that time. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > highway server not accept too many connection > - > > Key: SCB-687 > URL: https://issues.apache.org/jira/browse/SCB-687 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-794) Edge invocation do not properly send servlet filter response code
liubao created SCB-794: -- Summary: Edge invocation do not properly send servlet filter response code Key: SCB-794 URL: https://issues.apache.org/jira/browse/SCB-794 Project: Apache ServiceComb Issue Type: Bug Reporter: liubao Assignee: liubao -- This message was sent by Atlassian JIRA (v7.6.3#76005)
