[jira] [Commented] (SCB-958) The instance delete event delay more than 2s
[
https://issues.apache.org/jira/browse/SCB-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647328#comment-16647328
]
ASF GitHub Bot commented on SCB-958:
little-cui closed pull request #456: SCB-958 The instance delete event delay
more than 2s
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/456
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/server/core/backend/defer_instance.go
b/server/core/backend/defer_instance.go
index 82e81b06..7f3f459f 100644
--- a/server/core/backend/defer_instance.go
+++ b/server/core/backend/defer_instance.go
@@ -135,6 +135,9 @@ func (iedh *InstanceEventDeferHandler) check(ctx
context.Context) {
t.Reset(deferCheckWindow)
if !iedh.enabled {
+ for _, item := range iedh.items {
+ iedh.recover(item.event)
+ }
continue
}
diff --git a/server/core/backend/defer_test.go
b/server/core/backend/defer_test.go
index bb246fc8..f80f57c1 100644
--- a/server/core/backend/defer_test.go
+++ b/server/core/backend/defer_test.go
@@ -91,6 +91,27 @@ func TestInstanceEventDeferHandler_HandleChan(t *testing.T) {
}
cache := {c: make(map[string]*discovery.KeyValue)}
+ cache.Put("/1", kv1)
+ evts0 := []discovery.KvEvent{
+ {
+ Type: pb.EVT_DELETE,
+ KV: kv1,
+ },
+ }
+
+ iedh := {
+ Percent: 1,
+ }
+ iedh.OnCondition(cache, evts0)
+ select {
+ case evt := <-iedh.HandleChan():
+ if string(evt.KV.Key) != "/1" || evt.Type != pb.EVT_DELETE {
+ t.Fatalf(`TestInstanceEventDeferHandler_HandleChan
DELETE failed`)
+ }
+ case <-time.After(deferCheckWindow + time.Second):
+ t.Fatalf(`TestInstanceEventDeferHandler_HandleChan DELETE timed
out`)
+ }
+
cache.Put("/1", kv1)
cache.Put("/2", kv2)
cache.Put("/3", kv3)
@@ -149,10 +170,7 @@ func TestInstanceEventDeferHandler_HandleChan(t
*testing.T) {
},
}
- iedh := {
- Percent: 0.01,
- }
-
+ iedh.Percent = 0.01
iedh.OnCondition(cache, evts1)
iedh.OnCondition(cache, evts2)
iedh.OnCondition(cache, evts3)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> The instance delete event delay more than 2s
>
>
> Key: SCB-958
> URL: https://issues.apache.org/jira/browse/SCB-958
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Critical
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-837) make http2 production ready
[ https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646527#comment-16646527 ] ASF GitHub Bot commented on SCB-837: coveralls edited a comment on issue #947: [SCB-837] make http2 production ready URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#issuecomment-428578957 [](https://coveralls.io/builds/19470366) Coverage increased (+0.02%) to 86.234% when pulling **5da315c611aeb8206fa62d3964c3707fbe88e212 on heyile:metrics_http2** into **c3f1d662cd5b41b17b58e553a45b144c8101e8ad on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > make http2 production ready > --- > > Key: SCB-837 > URL: https://issues.apache.org/jira/browse/SCB-837 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: wujimin >Assignee: 何一乐 >Priority: Major > Fix For: java-chassis-1.1.0 > > > currenty, http2 client use all http1.1 settings, that cause http2 client > performance is so bad. > > we need to conside http2 client settings at least: > 1.concurrent stream in one connection, default value is 3, we must make it > bigger > 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent > stream count > > we must perform a performance test, that make sure got a good result, and > then set the setting to be our default setting. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-954) improve consumer stage time record when failed
[ https://issues.apache.org/jira/browse/SCB-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin resolved SCB-954. - Resolution: Done > improve consumer stage time record when failed > -- > > Key: SCB-954 > URL: https://issues.apache.org/jira/browse/SCB-954 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-956) not support body to be a enum
[ https://issues.apache.org/jira/browse/SCB-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin resolved SCB-956. - Resolution: Fixed > not support body to be a enum > - > > Key: SCB-956 > URL: https://issues.apache.org/jira/browse/SCB-956 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-959) When parsing inner classes，CtType will throw NotFoundException
[ https://issues.apache.org/jira/browse/SCB-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646308#comment-16646308 ] ASF GitHub Bot commented on SCB-959: liubao68 commented on issue #950: [SCB-959] When parsing inner classes，CtType will throw NotFoundException URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/950#issuecomment-428922024 How this problem happen? Does user define a model which contains inner class? Can you add an integration tests for that so we can know how this happen. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When parsing inner classes，CtType will throw NotFoundException > -- > > Key: SCB-959 > URL: https://issues.apache.org/jira/browse/SCB-959 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-957) delete too old protobuf map compatible flag
[
https://issues.apache.org/jira/browse/SCB-957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646306#comment-16646306
]
ASF GitHub Bot commented on SCB-957:
wujimin commented on a change in pull request #949: [SCB-957] delete too old
protobuf map compatible flag
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/949#discussion_r224412887
##
File path:
transports/transport-highway/src/main/java/org/apache/servicecomb/transport/highway/message/LoginRequest.java
##
@@ -42,11 +42,12 @@ public static LoginRequest readObject(Buffer bodyBuffer)
throws Exception {
@Tag(2)
private String zipName;
+ // no need this flag any more, but tag(3) should be reserved
// 历史版本中的protoStuff实现的protobuf的map编码与标准的protobuf不兼容
// 为保持highway的兼容，旧的不兼容编码也要保留
// 只有LoginRequest/LoginResponse同时为true时，才使用标准protobuf编码
- @Tag(3)
- private boolean useProtobufMapCodec;
+ //@Tag(3)
+ //private boolean useProtobufMapCodec;
Review comment:
impossible, maybe one years ago version used the old format
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> delete too old protobuf map compatible flag
> ---
>
> Key: SCB-957
> URL: https://issues.apache.org/jira/browse/SCB-957
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-957) delete too old protobuf map compatible flag
[
https://issues.apache.org/jira/browse/SCB-957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646301#comment-16646301
]
ASF GitHub Bot commented on SCB-957:
liubao68 commented on a change in pull request #949: [SCB-957] delete too old
protobuf map compatible flag
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/949#discussion_r224411839
##
File path:
transports/transport-highway/src/main/java/org/apache/servicecomb/transport/highway/message/LoginRequest.java
##
@@ -42,11 +42,12 @@ public static LoginRequest readObject(Buffer bodyBuffer)
throws Exception {
@Tag(2)
private String zipName;
+ // no need this flag any more, but tag(3) should be reserved
// 历史版本中的protoStuff实现的protobuf的map编码与标准的protobuf不兼容
// 为保持highway的兼容，旧的不兼容编码也要保留
// 只有LoginRequest/LoginResponse同时为true时，才使用标准protobuf编码
- @Tag(3)
- private boolean useProtobufMapCodec;
+ //@Tag(3)
+ //private boolean useProtobufMapCodec;
Review comment:
Can old version of highway consumer access new version of provider after
this change?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> delete too old protobuf map compatible flag
> ---
>
> Key: SCB-957
> URL: https://issues.apache.org/jira/browse/SCB-957
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-956) not support body to be a enum
[
https://issues.apache.org/jira/browse/SCB-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646290#comment-16646290
]
ASF GitHub Bot commented on SCB-956:
liubao68 closed pull request #948: [SCB-956] Not support body to be a enum
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/948
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/foundations/foundation-protobuf/pom.xml
b/foundations/foundation-protobuf/pom.xml
index a5e1416d3..7ee177f1b 100644
--- a/foundations/foundation-protobuf/pom.xml
+++ b/foundations/foundation-protobuf/pom.xml
@@ -60,5 +60,10 @@
jackson-dataformat-protobuf
test
+
+ org.apache.servicecomb
+ foundation-test-scaffolding
+
+
\ No newline at end of file
diff --git
a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/Root.java
b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/Root.java
index d4241ddd1..ddb4f07e0 100644
---
a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/Root.java
+++
b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/Root.java
@@ -19,6 +19,8 @@
import java.util.List;
import java.util.Map;
+import org.apache.servicecomb.foundation.test.scaffolding.model.Color;
+
public class Root {
private int int32;
diff --git
a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/performance/cases/Mixed.java
b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/performance/cases/Mixed.java
index c1a7200e0..9201e7b00 100644
---
a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/performance/cases/Mixed.java
+++
b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/performance/cases/Mixed.java
@@ -19,9 +19,9 @@
import java.util.Arrays;
import java.util.HashMap;
-import org.apache.servicecomb.foundation.protobuf.internal.model.Color;
import
org.apache.servicecomb.foundation.protobuf.internal.model.ProtobufRoot.User;
import org.apache.servicecomb.foundation.protobuf.performance.TestBase;
+import org.apache.servicecomb.foundation.test.scaffolding.model.Color;
public class Mixed extends TestBase {
public Mixed() {
diff --git
a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/performance/cases/Scalars.java
b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/performance/cases/Scalars.java
index 1c902a79f..9e457af87 100644
---
a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/performance/cases/Scalars.java
+++
b/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/performance/cases/Scalars.java
@@ -16,8 +16,8 @@
*/
package org.apache.servicecomb.foundation.protobuf.performance.cases;
-import org.apache.servicecomb.foundation.protobuf.internal.model.Color;
import org.apache.servicecomb.foundation.protobuf.performance.TestBase;
+import org.apache.servicecomb.foundation.test.scaffolding.model.Color;
public class Scalars extends TestBase {
public Scalars() {
diff --git
a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/Color.java
b/foundations/foundation-test-scaffolding/src/main/java/org/apache/servicecomb/foundation/test/scaffolding/model/Color.java
similarity index 92%
rename from
foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/Color.java
rename to
foundations/foundation-test-scaffolding/src/main/java/org/apache/servicecomb/foundation/test/scaffolding/model/Color.java
index 19c724f2f..5cca0d9f5 100644
---
a/foundations/foundation-protobuf/src/test/java/org/apache/servicecomb/foundation/protobuf/internal/model/Color.java
+++
b/foundations/foundation-test-scaffolding/src/main/java/org/apache/servicecomb/foundation/test/scaffolding/model/Color.java
@@ -1,4 +1,4 @@
-package org.apache.servicecomb.foundation.protobuf.internal.model;/*
+/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
@@ -15,6 +15,8 @@
* limitations under the License.
*/
+package org.apache.servicecomb.foundation.test.scaffolding.model;
+
public enum Color {
RED,
YELLOW,
diff --git
[jira] [Commented] (SCB-948) convert proto model to string
[ https://issues.apache.org/jira/browse/SCB-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646277#comment-16646277 ] ASF GitHub Bot commented on SCB-948: liubao68 commented on a change in pull request #946: [SCB-948] Convert proto model to string URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/946#discussion_r224404316 ## File path: java-chassis-distribution/src/release/LICENSE ## @@ -461,3 +461,4 @@ Zipkin Sender: OkHttp 3 (https://github.com/openzipkin/zipkin-reporter-java/zipk Zipkin v1 (https://github.com/openzipkin/zipkin/) io.zipkin.java:zipkin:jar:2.4.2 Zipkin v2 (https://github.com/openzipkin/zipkin/) io.zipkin.zipkin2:zipkin:jar:2.4.2 zuul-core (https://github.com/Netflix/zuul) com.netflix.zuul:zuul-core:jar:1.3.0 +protobuf-java (https://github.com/protocolbuffers/protobuf/tree/master/java) com.google.protobuf:protobuf-java:jar:3.6.1 Review comment: This project does not using Apache License v2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > convert proto model to string > - > > Key: SCB-948 > URL: https://issues.apache.org/jira/browse/SCB-948 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-954) improve consumer stage time record when failed
[ https://issues.apache.org/jira/browse/SCB-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646271#comment-16646271 ] ASF GitHub Bot commented on SCB-954: liubao68 closed pull request #945: [SCB-954] improve consumer stage time record when failed URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/945 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core/src/main/java/org/apache/servicecomb/core/invocation/InvocationStageTrace.java b/core/src/main/java/org/apache/servicecomb/core/invocation/InvocationStageTrace.java index 193644cc5..bf7879541 100644 --- a/core/src/main/java/org/apache/servicecomb/core/invocation/InvocationStageTrace.java +++ b/core/src/main/java/org/apache/servicecomb/core/invocation/InvocationStageTrace.java @@ -27,30 +27,33 @@ * start/finish/startBusiness/finishBusiness * * for consumer: - * start -> startHandlersRequest -> startClientFiltersRequest -> startSend -> finishGetConnection -> finishWriteToBuffer - * / - * \/ - * finish <- finishHandlersResponse <- finishClientFiltersResponse <- startClientFiltersResponse <- finishReceiveResponse + * (prepare) (handlerReq) (clientFilterReq) + * start > startHandlersRequest ---> startClientFiltersRequest -- + * <(sendRequest)->| + *(receiveResponse) (writeToBuffer) (getConnection)| + *---finishReceiveResponse <- finishWriteToBuffer <--- finishGetConnection <-- startSend <- + * | (wakeConsumer)(clientFiltersResponse) (handlersResponse) + * |-> startClientFiltersResponse ---> finishClientFiltersResponse ---> finishHandlersResponse --> finish * * for producer: - * ? -> - * start -> startSchedule -> startExecution -> startServerFiltersRequest -> startHandlersRequest -> startBusinessMethod- - * | - * \/ - * finish <- finishWriteToBuffer <- finishServerFiltersResponse <- finishHandlersResponse <- finishBusiness <- finishBusinessMethod + * (prepare) (threadPoolQueue) (serverFiltersRequest) + * start > startSchedule -> startExecution -> startServerFiltersRequest ---> startHandlersRequest --- + * (handlersResponse) <-(business)-> (handlersRequest) | + * -finishHandlersResponse <-- finishBusiness <--- finishBusinessMethod <-- startBusinessMethod-- + * | (serverFiltersResponse) (sendResponse) + * |---> finishServerFiltersResponse --> finish + * * for edge: - * ? -> - * start -> startSchedule -> startExecution -> startServerFiltersRequest -- - * / - * -- - */ - * ---> startHandlersRequest -> startClientFiltersRequest -> startSend -> finishGetConnection -> finishWriteToBuffer - * / - * \/ - * finishHandlersResponse <- finishClientFiltersResponse <- startClientFiltersResponse <- finishReceiveResponse - *| - * \/ - * finish <- finishServerFiltersResponse + * (prepare) (threadPoolQueue) (serverFiltersRequest) + * start > startSchedule -> startExecution -> startServerFiltersRequest > startHandlersRequest -- + * <--(sendRequest)--> | + * (writeToBuffer) (getConnection) (clientFilterReq)(handlersRequest) | + * --- finishWriteToBuffer <-- finishGetConnection <-- startSend <--
[jira] [Commented] (SCB-737) avoid null point exception
[
https://issues.apache.org/jira/browse/SCB-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646266#comment-16646266
]
ASF GitHub Bot commented on SCB-737:
liubao68 closed pull request #936: [SCB-737]Avoid null point exception
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/936
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/schema/PojoProducers.java
b/providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/schema/PojoProducers.java
index 4e0e3619d..b173ead65 100644
---
a/providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/schema/PojoProducers.java
+++
b/providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/schema/PojoProducers.java
@@ -63,6 +63,9 @@ protected void processProvider(String beanName, Object bean) {
// aop后，新的实例的父类可能是原class，也可能只是个proxy，父类不是原class
// 所以，需要先取出原class，再取标注
Class beanCls = BeanUtils.getImplClassFromBean(bean);
+if(beanCls == null) {
+ return;
+}
RpcSchema rpcSchema = beanCls.getAnnotation(RpcSchema.class);
if (rpcSchema == null) {
return;
diff --git
a/providers/provider-rest-common/src/main/java/org/apache/servicecomb/provider/rest/common/RestProducers.java
b/providers/provider-rest-common/src/main/java/org/apache/servicecomb/provider/rest/common/RestProducers.java
index 5adedfe50..8fac2e201 100644
---
a/providers/provider-rest-common/src/main/java/org/apache/servicecomb/provider/rest/common/RestProducers.java
+++
b/providers/provider-rest-common/src/main/java/org/apache/servicecomb/provider/rest/common/RestProducers.java
@@ -49,6 +49,9 @@ protected void processProvider(String beanName, Object bean) {
// aop后，新的实例的父类可能是原class，也可能只是个proxy，父类不是原class
// 所以，需要先取出原class，再取标注
Class beanCls = BeanUtils.getImplClassFromBean(bean);
+if(beanCls == null) {
+ return;
+}
RestSchema restSchema = beanCls.getAnnotation(RestSchema.class);
if (restSchema == null) {
return;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> avoid null point exception
> --
>
> Key: SCB-737
> URL: https://issues.apache.org/jira/browse/SCB-737
> Project: Apache ServiceComb
> Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>
> 2018-07-11
> 03:27:52,651Z(28241):ERROR{}[main]org.springframework.boot.SpringApplication.reportFailure(SpringApplication.java:771)-->Application
> startup failed
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name 'batchConfig': Unsatisfied dependency expressed
> through field 'jobBuilderFactory'; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'jobBuilders' defined in class path resource
> [org/springframework/batch/core/configuration/annotation/SimpleBatchConfiguration.class]:
> Bean instantiation via factory method failed; nested exception is
> org.springframework.beans.BeanInstantiationException: Failed to instantiate
> [org.springframework.batch.core.configuration.annotation.JobBuilderFactory]:
> Factory method 'jobBuilders' threw exception; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'jobRepository' defined in class path resource
> [org/springframework/batch/core/configuration/annotation/SimpleBatchConfiguration.class]:
> Initialization of bean failed; nested exception is
> java.lang.NullPointerException
>
> RELEASE]
> at
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:202)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
> org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:207)
> ~[spring-beans-4.3.5.RELEASE.jar:4.3.5.RELEASE]
> at
[jira] [Commented] (SCB-837) make http2 production ready
[
https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646195#comment-16646195
]
ASF GitHub Bot commented on SCB-837:
heyile closed pull request #947: [SCB-837] make http2 production ready
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/947
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
index 98f5fd205..3fb9af337 100644
---
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
+++
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
@@ -19,6 +19,8 @@
import
org.apache.servicecomb.foundation.vertx.metrics.metric.DefaultClientEndpointMetric;
import
org.apache.servicecomb.foundation.vertx.metrics.metric.DefaultClientEndpointMetricManager;
import
org.apache.servicecomb.foundation.vertx.metrics.metric.DefaultHttpSocketMetric;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import io.vertx.core.http.HttpClient;
import io.vertx.core.http.HttpClientOptions;
@@ -34,6 +36,9 @@
*/
public class DefaultHttpClientMetrics implements
HttpClientMetrics {
+
+ private static final Logger LOGGER =
LoggerFactory.getLogger(DefaultHttpClientMetrics.class);
+
private final DefaultClientEndpointMetricManager clientEndpointMetricManager;
private final HttpClient client;
@@ -77,8 +82,9 @@ public void dequeueRequest(DefaultClientEndpointMetric
endpointMetric, Object ta
@Override
public void endpointConnected(DefaultClientEndpointMetric endpointMetric,
DefaultHttpSocketMetric socketMetric) {
-socketMetric.setEndpointMetric(endpointMetric);
-endpointMetric.onConnect();
+// as http2 client will not invoke this method, the endpointMetric info
will lost.
+// you can get more details from
https://github.com/eclipse-vertx/vert.x/issues/2660
+// hence, we will set endpointMetric info in the method
connected(SocketAddress remoteAddress, String remoteName)
}
@Override
@@ -133,7 +139,11 @@ public void disconnected(Object webSocketMetric) {
@Override
public DefaultHttpSocketMetric connected(SocketAddress remoteAddress, String
remoteName) {
-return new DefaultHttpSocketMetric(null);
+//we can get endpointMetric info here, so set the endpointMetric info
directly
+DefaultClientEndpointMetric clientEndpointMetric =
this.clientEndpointMetricManager
+.getClientEndpointMetric(remoteAddress);
+clientEndpointMetric.onConnect();
+return new DefaultHttpSocketMetric(clientEndpointMetric);
}
@Override
diff --git
a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
index 05f73a7f8..2ce5620fa 100644
---
a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
+++
b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
@@ -61,9 +61,7 @@ public void init(Vertx vertx) throws Exception {
HttpClientOptions httpClientOptions = createHttpClientOptions();
clientMgr = new ClientPoolManager<>(vertx, new
HttpClientPoolFactory(httpClientOptions));
-HttpClientOptions httpClientOptionshttp2 = createHttpClientOptions();
-
httpClientOptionshttp2.setUseAlpn(true).setProtocolVersion(HttpVersion.HTTP_2);
-httpClientOptionshttp2.setHttp2ClearTextUpgrade(false);
+HttpClientOptions httpClientOptionshttp2 = createHttp2ClientOptions();
clientMgrHttp2 = new ClientPoolManager<>(vertx, new
HttpClientPoolFactory(httpClientOptionshttp2));
@@ -87,6 +85,21 @@ private static HttpClientOptions createHttpClientOptions() {
return httpClientOptions;
}
+ private static HttpClientOptions createHttp2ClientOptions() {
+HttpClientOptions httpClientOptions = new HttpClientOptions();
+
httpClientOptions.setMaxPoolSize(TransportClientConfig.getConnectionMaxPoolSize())
+.setUseAlpn(true)
+
.setIdleTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())
+
.setHttp2MultiplexingLimit(TransportClientConfig.getHttp2MultiplexingLimit())
+
[jira] [Commented] (SCB-837) make http2 production ready
[ https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646196#comment-16646196 ] ASF GitHub Bot commented on SCB-837: heyile opened a new pull request #947: [SCB-837] make http2 production ready URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/947 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > make http2 production ready > --- > > Key: SCB-837 > URL: https://issues.apache.org/jira/browse/SCB-837 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: wujimin >Assignee: 何一乐 >Priority: Major > Fix For: java-chassis-1.1.0 > > > currenty, http2 client use all http1.1 settings, that cause http2 client > performance is so bad. > > we need to conside http2 client settings at least: > 1.concurrent stream in one connection, default value is 3, we must make it > bigger > 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent > stream count > > we must perform a performance test, that make sure got a good result, and > then set the setting to be our default setting. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-837) make http2 production ready
[
https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646193#comment-16646193
]
ASF GitHub Bot commented on SCB-837:
heyile closed pull request #947: [SCB-837] make http2 production ready
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/947
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
index 98f5fd205..3fb9af337 100644
---
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
+++
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
@@ -19,6 +19,8 @@
import
org.apache.servicecomb.foundation.vertx.metrics.metric.DefaultClientEndpointMetric;
import
org.apache.servicecomb.foundation.vertx.metrics.metric.DefaultClientEndpointMetricManager;
import
org.apache.servicecomb.foundation.vertx.metrics.metric.DefaultHttpSocketMetric;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import io.vertx.core.http.HttpClient;
import io.vertx.core.http.HttpClientOptions;
@@ -34,6 +36,9 @@
*/
public class DefaultHttpClientMetrics implements
HttpClientMetrics {
+
+ private static final Logger LOGGER =
LoggerFactory.getLogger(DefaultHttpClientMetrics.class);
+
private final DefaultClientEndpointMetricManager clientEndpointMetricManager;
private final HttpClient client;
@@ -77,8 +82,9 @@ public void dequeueRequest(DefaultClientEndpointMetric
endpointMetric, Object ta
@Override
public void endpointConnected(DefaultClientEndpointMetric endpointMetric,
DefaultHttpSocketMetric socketMetric) {
-socketMetric.setEndpointMetric(endpointMetric);
-endpointMetric.onConnect();
+// as http2 client will not invoke this method, the endpointMetric info
will lost.
+// you can get more details from
https://github.com/eclipse-vertx/vert.x/issues/2660
+// hence, we will set endpointMetric info in the method
connected(SocketAddress remoteAddress, String remoteName)
}
@Override
@@ -133,7 +139,11 @@ public void disconnected(Object webSocketMetric) {
@Override
public DefaultHttpSocketMetric connected(SocketAddress remoteAddress, String
remoteName) {
-return new DefaultHttpSocketMetric(null);
+//we can get endpointMetric info here, so set the endpointMetric info
directly
+DefaultClientEndpointMetric clientEndpointMetric =
this.clientEndpointMetricManager
+.getClientEndpointMetric(remoteAddress);
+clientEndpointMetric.onConnect();
+return new DefaultHttpSocketMetric(clientEndpointMetric);
}
@Override
diff --git
a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
index 05f73a7f8..2ce5620fa 100644
---
a/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
+++
b/transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
@@ -61,9 +61,7 @@ public void init(Vertx vertx) throws Exception {
HttpClientOptions httpClientOptions = createHttpClientOptions();
clientMgr = new ClientPoolManager<>(vertx, new
HttpClientPoolFactory(httpClientOptions));
-HttpClientOptions httpClientOptionshttp2 = createHttpClientOptions();
-
httpClientOptionshttp2.setUseAlpn(true).setProtocolVersion(HttpVersion.HTTP_2);
-httpClientOptionshttp2.setHttp2ClearTextUpgrade(false);
+HttpClientOptions httpClientOptionshttp2 = createHttp2ClientOptions();
clientMgrHttp2 = new ClientPoolManager<>(vertx, new
HttpClientPoolFactory(httpClientOptionshttp2));
@@ -87,6 +85,21 @@ private static HttpClientOptions createHttpClientOptions() {
return httpClientOptions;
}
+ private static HttpClientOptions createHttp2ClientOptions() {
+HttpClientOptions httpClientOptions = new HttpClientOptions();
+
httpClientOptions.setMaxPoolSize(TransportClientConfig.getConnectionMaxPoolSize())
+.setUseAlpn(true)
+
.setIdleTimeout(TransportClientConfig.getConnectionIdleTimeoutInSeconds())
+
.setHttp2MultiplexingLimit(TransportClientConfig.getHttp2MultiplexingLimit())
+
[jira] [Commented] (SCB-837) make http2 production ready
[ https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646194#comment-16646194 ] ASF GitHub Bot commented on SCB-837: heyile opened a new pull request #947: [SCB-837] make http2 production ready URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/947 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > make http2 production ready > --- > > Key: SCB-837 > URL: https://issues.apache.org/jira/browse/SCB-837 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: wujimin >Assignee: 何一乐 >Priority: Major > Fix For: java-chassis-1.1.0 > > > currenty, http2 client use all http1.1 settings, that cause http2 client > performance is so bad. > > we need to conside http2 client settings at least: > 1.concurrent stream in one connection, default value is 3, we must make it > bigger > 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent > stream count > > we must perform a performance test, that make sure got a good result, and > then set the setting to be our default setting. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-928) support swagger "collection-format" feature
[ https://issues.apache.org/jira/browse/SCB-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YaoHaishi reassigned SCB-928: - Assignee: YaoHaishi > support swagger "collection-format" feature > --- > > Key: SCB-928 > URL: https://issues.apache.org/jira/browse/SCB-928 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: YaoHaishi >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-959) When parsing inner classes，CtType will throw NotFoundException
[ https://issues.apache.org/jira/browse/SCB-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646124#comment-16646124 ] ASF GitHub Bot commented on SCB-959: weichao666 commented on issue #950: [SCB-959] When parsing inner classes，CtType will throw NotFoundException URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/950#issuecomment-428870134 parsing inner class, use getCanonicalName() will throw NotFoundException, so use getName() This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When parsing inner classes，CtType will throw NotFoundException > -- > > Key: SCB-959 > URL: https://issues.apache.org/jira/browse/SCB-959 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-959) When parsing inner classes，CtType will throw NotFoundException
[ https://issues.apache.org/jira/browse/SCB-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646119#comment-16646119 ] ASF GitHub Bot commented on SCB-959: coveralls commented on issue #950: [SCB-959] When parsing inner classes，CtType will throw NotFoundException URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/950#issuecomment-428868294 [](https://coveralls.io/builds/19464152) Coverage increased (+0.008%) to 86.221% when pulling **c0ec9f81150693c9e175fa83f282106bef1becd2 on weichao666:getname** into **c3f1d662cd5b41b17b58e553a45b144c8101e8ad on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When parsing inner classes，CtType will throw NotFoundException > -- > > Key: SCB-959 > URL: https://issues.apache.org/jira/browse/SCB-959 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-837) make http2 production ready
[
https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646111#comment-16646111
]
ASF GitHub Bot commented on SCB-837:
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r224357351
##
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
##
@@ -83,13 +82,10 @@ public void dequeueRequest(DefaultClientEndpointMetric
endpointMetric, Object ta
@Override
public void endpointConnected(DefaultClientEndpointMetric endpointMetric,
DefaultHttpSocketMetric socketMetric) {
-//only http1.1 will invoke this method, just make a check
-if (endpointMetric != null) {
- if (endpointMetric != socketMetric.getEndpointMetric()) {
-socketMetric.setEndpointMetric(endpointMetric);
- }
- endpointMetric.onConnect();
-}
+// as http2 client will not invoke this method, the endpointMetric info
will lost.
+// you can get more details from
https://github.com/eclipse-vertx/vert.x/issues/2660
+// hence, we will set endpointMetric info in the method
connected(SocketAddress remoteAddress, String remoteName)
+endpointMetric.onConnect();
Review comment:
move to "connected", so that will depend if vertx fixed the bug.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> make http2 production ready
> ---
>
> Key: SCB-837
> URL: https://issues.apache.org/jira/browse/SCB-837
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: 何一乐
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> currenty, http2 client use all http1.1 settings, that cause http2 client
> performance is so bad.
>
> we need to conside http2 client settings at least:
> 1.concurrent stream in one connection, default value is 3, we must make it
> bigger
> 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent
> stream count
>
> we must perform a performance test, that make sure got a good result, and
> then set the setting to be our default setting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-959) When parsing inner classes，CtType will throw NotFoundException
[ https://issues.apache.org/jira/browse/SCB-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646099#comment-16646099 ] ASF GitHub Bot commented on SCB-959: weichao666 opened a new pull request #950: [SCB-959] When parsing inner classes，CtType will throw NotFoundException URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/950 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When parsing inner classes，CtType will throw NotFoundException > -- > > Key: SCB-959 > URL: https://issues.apache.org/jira/browse/SCB-959 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-959) When parsing inner classes，CtType will throw NotFoundException
[ https://issues.apache.org/jira/browse/SCB-959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646083#comment-16646083 ] ASF GitHub Bot commented on SCB-959: weichao666 opened a new pull request #950: [SCB-959] When parsing inner classes，CtType will throw NotFoundException URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/950 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When parsing inner classes，CtType will throw NotFoundException > -- > > Key: SCB-959 > URL: https://issues.apache.org/jira/browse/SCB-959 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-959) When parsing inner classes，CtType will throw NotFoundException
WeiChao created SCB-959: --- Summary: When parsing inner classes，CtType will throw NotFoundException Key: SCB-959 URL: https://issues.apache.org/jira/browse/SCB-959 Project: Apache ServiceComb Issue Type: Bug Components: Java-Chassis Reporter: WeiChao Assignee: WeiChao Fix For: java-chassis-1.1.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
