[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[ https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652965#comment-16652965 ] ASF GitHub Bot commented on SCB-935: asifdxtreme commented on issue #317: [SCB-935] [WIP] Saga transaction management console UI initial commit URL: https://github.com/apache/incubator-servicecomb-saga/pull/317#issuecomment-430492027 @anvithks please replace favicon.* with ServiceComb icons, you can get it in this [project](https://github.com/apache/incubator-servicecomb-website) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ServiceComb Saga Frontend > - > > Key: SCB-935 > URL: https://issues.apache.org/jira/browse/SCB-935 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > > Develop new ServiceComb Saga Frontend based on the design over here > https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[
https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652963#comment-16652963
]
ASF GitHub Bot commented on SCB-935:
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225782066
##
File path:
saga-web/src/main/resources/saga-frontend/src/app/@theme/layouts/sample/sample.layout.ts
##
@@ -0,0 +1,103 @@
+import { Component, OnDestroy } from '@angular/core';
Review comment:
please double check usage of this file
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceComb Saga Frontend
> -
>
> Key: SCB-935
> URL: https://issues.apache.org/jira/browse/SCB-935
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Develop new ServiceComb Saga Frontend based on the design over here
> https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[
https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652964#comment-16652964
]
ASF GitHub Bot commented on SCB-935:
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225782566
##
File path: saga-web/src/main/resources/saga-frontend/tslint.json
##
@@ -0,0 +1,136 @@
+{
Review comment:
tslint might not be required, please double check
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceComb Saga Frontend
> -
>
> Key: SCB-935
> URL: https://issues.apache.org/jira/browse/SCB-935
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Develop new ServiceComb Saga Frontend based on the design over here
> https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[ https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652962#comment-16652962 ] ASF GitHub Bot commented on SCB-935: asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga transaction management console UI initial commit URL: https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225782019 ## File path: saga-web/src/main/resources/saga-frontend/src/app/@theme/layouts/sample/sample.layout.scss ## @@ -0,0 +1,179 @@ +@import '../../styles/themes'; Review comment: are we using sample.layout.scss anywhere? please double check This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ServiceComb Saga Frontend > - > > Key: SCB-935 > URL: https://issues.apache.org/jira/browse/SCB-935 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > > Develop new ServiceComb Saga Frontend based on the design over here > https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[
https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652961#comment-16652961
]
ASF GitHub Bot commented on SCB-935:
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225782453
##
File path:
saga-web/src/main/resources/saga-frontend/src/assets/data/events.json
##
@@ -0,0 +1,869 @@
+[{
Review comment:
I guess this file doesn't needs to be checked in.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceComb Saga Frontend
> -
>
> Key: SCB-935
> URL: https://issues.apache.org/jira/browse/SCB-935
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Develop new ServiceComb Saga Frontend based on the design over here
> https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[ https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652956#comment-16652956 ] ASF GitHub Bot commented on SCB-935: asifdxtreme commented on issue #317: [SCB-935] [WIP] Saga transaction management console UI initial commit URL: https://github.com/apache/incubator-servicecomb-saga/pull/317#issuecomment-430489779 ### // TODO (Mandatory before the PR merge) For New dependencies following things should be done - [ ] Add the license copies in this [directory](https://github.com/apache/incubator-servicecomb-saga/tree/master/saga-distribution/src/release/licenses) - [ ] Add the Usage information over [here](https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/NOTICE) - [ ] Add the Usage information with the version number over [here](https://github.com/apache/incubator-servicecomb-saga/blob/master/saga-distribution/src/release/LICENSE) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ServiceComb Saga Frontend > - > > Key: SCB-935 > URL: https://issues.apache.org/jira/browse/SCB-935 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > > Develop new ServiceComb Saga Frontend based on the design over here > https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[
https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652949#comment-16652949
]
ASF GitHub Bot commented on SCB-935:
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225778980
##
File path: saga-web/src/main/resources/saga-frontend/package.json
##
@@ -0,0 +1,115 @@
+{
+ "name": "saga-frontend",
+ "version": "2.3.0",
+ "license": "MIT",
+ "repository": {
+"type": "git",
+"url": "git+https://github.com/akveo/ngx-admin.git";
+ },
+ "bugs": {
+"url": "https://github.com/akveo/ngx-admin/issues";
+ },
+ "browserslist": [
+"> 1%",
+"last 2 versions",
+"IE 11"
+ ],
+ "scripts": {
+"ng": "ng",
+"conventional-changelog": "conventional-changelog",
+"start": "ng serve --port 5200",
+"build": "ng build",
+"build:prod": "npm run build -- --prod --aot",
+"test": "ng test",
+"test:coverage": "rimraf coverage && npm run test -- --code-coverage",
+"lint": "ng lint",
+"lint:fix": "ng lint saga-frontend --fix",
+"lint:styles": "stylelint ./src/**/*.scss",
+"lint:ci": "npm run lint && npm run lint:styles",
+"pree2e": "webdriver-manager update --standalone false --gecko false",
+"e2e": "ng e2e",
+"docs": "compodoc -p src/tsconfig.app.json -d docs",
+"docs:serve": "compodoc -p src/tsconfig.app.json -d docs -s",
+"prepush": "npm run lint:ci",
+"release:changelog": "npm run conventional-changelog -- -p angular -i
CHANGELOG.md -s"
+ },
+ "dependencies": {
+"@agm/core": "1.0.0-beta.2",
+"@angular/animations": "6.0.0",
+"@angular/common": "6.0.0",
+"@angular/compiler": "6.0.0",
+"@angular/core": "6.0.0",
+"@angular/forms": "6.0.0",
+"@angular/http": "6.0.0",
+"@angular/platform-browser": "6.0.0",
+"@angular/platform-browser-dynamic": "6.0.0",
+"@angular/router": "6.0.0",
+"@asymmetrik/ngx-leaflet": "3.0.1",
+"@nebular/auth": "2.0.0-rc.10",
+"@nebular/security": "2.0.0-rc.10",
+"@nebular/theme": "2.0.0-rc.10",
+"@ng-bootstrap/ng-bootstrap": "1.0.0",
+"@swimlane/ngx-charts": "7.0.1",
+"angular-tree-component": "7.2.0",
+"angular2-chartjs": "0.4.1",
+"angular2-toaster": "6.0.0",
+"bootstrap": "4.0.0",
+"chart.js": "2.7.1",
+"ckeditor": "4.7.3",
+"classlist.js": "1.1.20150312",
+"core-js": "2.5.1",
+"echarts": "^4.0.2",
+"intl": "1.2.5",
+"ionicons": "2.0.1",
+"leaflet": "1.2.0",
+"nebular-icons": "1.0.9",
+"ng2-ckeditor": "1.1.13",
+"ng2-completer": "2.0.8",
+"ng2-smart-table": "1.3.5",
+"ngx-echarts": "2.0.1",
+"normalize.css": "6.0.0",
+"pace-js": "1.0.2",
+"roboto-fontface": "0.8.0",
+"rxjs": "^6.1.0",
+"rxjs-compat": "^6.1.0",
+"socicon": "3.0.5",
+"tinymce": "4.5.7",
+"typeface-exo": "0.0.22",
+"underscore": "^1.9.1",
+"web-animations-js": "2.2.5",
+"zone.js": "^0.8.26"
+ },
+ "devDependencies": {
Review comment:
probably we don't need these
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceComb Saga Frontend
> -
>
> Key: SCB-935
> URL: https://issues.apache.org/jira/browse/SCB-935
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Develop new ServiceComb Saga Frontend based on the design over here
> https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[
https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652948#comment-16652948
]
ASF GitHub Bot commented on SCB-935:
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225780290
##
File path: saga-web/src/main/resources/saga-frontend/package.json
##
@@ -0,0 +1,115 @@
+{
+ "name": "saga-frontend",
+ "version": "2.3.0",
+ "license": "MIT",
+ "repository": {
+"type": "git",
+"url": "git+https://github.com/akveo/ngx-admin.git";
+ },
+ "bugs": {
+"url": "https://github.com/akveo/ngx-admin/issues";
+ },
+ "browserslist": [
+"> 1%",
+"last 2 versions",
+"IE 11"
+ ],
+ "scripts": {
+"ng": "ng",
+"conventional-changelog": "conventional-changelog",
+"start": "ng serve --port 5200",
+"build": "ng build",
+"build:prod": "npm run build -- --prod --aot",
+"test": "ng test",
+"test:coverage": "rimraf coverage && npm run test -- --code-coverage",
+"lint": "ng lint",
+"lint:fix": "ng lint saga-frontend --fix",
+"lint:styles": "stylelint ./src/**/*.scss",
+"lint:ci": "npm run lint && npm run lint:styles",
+"pree2e": "webdriver-manager update --standalone false --gecko false",
+"e2e": "ng e2e",
+"docs": "compodoc -p src/tsconfig.app.json -d docs",
+"docs:serve": "compodoc -p src/tsconfig.app.json -d docs -s",
+"prepush": "npm run lint:ci",
+"release:changelog": "npm run conventional-changelog -- -p angular -i
CHANGELOG.md -s"
+ },
+ "dependencies": {
+"@agm/core": "1.0.0-beta.2",
+"@angular/animations": "6.0.0",
+"@angular/common": "6.0.0",
+"@angular/compiler": "6.0.0",
+"@angular/core": "6.0.0",
+"@angular/forms": "6.0.0",
+"@angular/http": "6.0.0",
+"@angular/platform-browser": "6.0.0",
+"@angular/platform-browser-dynamic": "6.0.0",
+"@angular/router": "6.0.0",
+"@asymmetrik/ngx-leaflet": "3.0.1",
+"@nebular/auth": "2.0.0-rc.10",
+"@nebular/security": "2.0.0-rc.10",
+"@nebular/theme": "2.0.0-rc.10",
+"@ng-bootstrap/ng-bootstrap": "1.0.0",
+"@swimlane/ngx-charts": "7.0.1",
+"angular-tree-component": "7.2.0",
+"angular2-chartjs": "0.4.1",
+"angular2-toaster": "6.0.0",
+"bootstrap": "4.0.0",
+"chart.js": "2.7.1",
+"ckeditor": "4.7.3",
+"classlist.js": "1.1.20150312",
+"core-js": "2.5.1",
+"echarts": "^4.0.2",
+"intl": "1.2.5",
+"ionicons": "2.0.1",
+"leaflet": "1.2.0",
+"nebular-icons": "1.0.9",
+"ng2-ckeditor": "1.1.13",
+"ng2-completer": "2.0.8",
+"ng2-smart-table": "1.3.5",
+"ngx-echarts": "2.0.1",
+"normalize.css": "6.0.0",
+"pace-js": "1.0.2",
+"roboto-fontface": "0.8.0",
+"rxjs": "^6.1.0",
+"rxjs-compat": "^6.1.0",
+"socicon": "3.0.5",
+"tinymce": "4.5.7",
Review comment:
https://github.com/tinymce/tinymce/blob/master/LICENSE.TXT tinymce is not
compatibel with Apache License, please find an alternative to this
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceComb Saga Frontend
> -
>
> Key: SCB-935
> URL: https://issues.apache.org/jira/browse/SCB-935
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Develop new ServiceComb Saga Frontend based on the design over here
> https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[
https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652950#comment-16652950
]
ASF GitHub Bot commented on SCB-935:
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225780497
##
File path: saga-web/src/main/resources/saga-frontend/package.json
##
@@ -0,0 +1,115 @@
+{
+ "name": "saga-frontend",
+ "version": "2.3.0",
+ "license": "MIT",
+ "repository": {
+"type": "git",
+"url": "git+https://github.com/akveo/ngx-admin.git";
+ },
+ "bugs": {
+"url": "https://github.com/akveo/ngx-admin/issues";
+ },
+ "browserslist": [
+"> 1%",
+"last 2 versions",
+"IE 11"
+ ],
+ "scripts": {
+"ng": "ng",
+"conventional-changelog": "conventional-changelog",
+"start": "ng serve --port 5200",
+"build": "ng build",
+"build:prod": "npm run build -- --prod --aot",
+"test": "ng test",
+"test:coverage": "rimraf coverage && npm run test -- --code-coverage",
+"lint": "ng lint",
+"lint:fix": "ng lint saga-frontend --fix",
+"lint:styles": "stylelint ./src/**/*.scss",
+"lint:ci": "npm run lint && npm run lint:styles",
+"pree2e": "webdriver-manager update --standalone false --gecko false",
+"e2e": "ng e2e",
+"docs": "compodoc -p src/tsconfig.app.json -d docs",
+"docs:serve": "compodoc -p src/tsconfig.app.json -d docs -s",
+"prepush": "npm run lint:ci",
+"release:changelog": "npm run conventional-changelog -- -p angular -i
CHANGELOG.md -s"
+ },
+ "dependencies": {
Review comment:
I guess some of this might not be required after trimming down the UI to
minimal, so please double check this list
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceComb Saga Frontend
> -
>
> Key: SCB-935
> URL: https://issues.apache.org/jira/browse/SCB-935
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Develop new ServiceComb Saga Frontend based on the design over here
> https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[
https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652952#comment-16652952
]
ASF GitHub Bot commented on SCB-935:
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225780098
##
File path: saga-web/src/main/resources/saga-frontend/package.json
##
@@ -0,0 +1,115 @@
+{
+ "name": "saga-frontend",
+ "version": "2.3.0",
+ "license": "MIT",
+ "repository": {
+"type": "git",
+"url": "git+https://github.com/akveo/ngx-admin.git";
+ },
+ "bugs": {
+"url": "https://github.com/akveo/ngx-admin/issues";
+ },
+ "browserslist": [
+"> 1%",
+"last 2 versions",
+"IE 11"
+ ],
+ "scripts": {
+"ng": "ng",
+"conventional-changelog": "conventional-changelog",
+"start": "ng serve --port 5200",
+"build": "ng build",
+"build:prod": "npm run build -- --prod --aot",
+"test": "ng test",
+"test:coverage": "rimraf coverage && npm run test -- --code-coverage",
+"lint": "ng lint",
+"lint:fix": "ng lint saga-frontend --fix",
+"lint:styles": "stylelint ./src/**/*.scss",
+"lint:ci": "npm run lint && npm run lint:styles",
+"pree2e": "webdriver-manager update --standalone false --gecko false",
+"e2e": "ng e2e",
+"docs": "compodoc -p src/tsconfig.app.json -d docs",
+"docs:serve": "compodoc -p src/tsconfig.app.json -d docs -s",
+"prepush": "npm run lint:ci",
+"release:changelog": "npm run conventional-changelog -- -p angular -i
CHANGELOG.md -s"
+ },
+ "dependencies": {
+"@agm/core": "1.0.0-beta.2",
+"@angular/animations": "6.0.0",
+"@angular/common": "6.0.0",
+"@angular/compiler": "6.0.0",
+"@angular/core": "6.0.0",
+"@angular/forms": "6.0.0",
+"@angular/http": "6.0.0",
+"@angular/platform-browser": "6.0.0",
+"@angular/platform-browser-dynamic": "6.0.0",
+"@angular/router": "6.0.0",
+"@asymmetrik/ngx-leaflet": "3.0.1",
+"@nebular/auth": "2.0.0-rc.10",
+"@nebular/security": "2.0.0-rc.10",
+"@nebular/theme": "2.0.0-rc.10",
+"@ng-bootstrap/ng-bootstrap": "1.0.0",
+"@swimlane/ngx-charts": "7.0.1",
+"angular-tree-component": "7.2.0",
+"angular2-chartjs": "0.4.1",
+"angular2-toaster": "6.0.0",
+"bootstrap": "4.0.0",
+"chart.js": "2.7.1",
+"ckeditor": "4.7.3",
+"classlist.js": "1.1.20150312",
+"core-js": "2.5.1",
+"echarts": "^4.0.2",
+"intl": "1.2.5",
+"ionicons": "2.0.1",
+"leaflet": "1.2.0",
+"nebular-icons": "1.0.9",
+"ng2-ckeditor": "1.1.13",
+"ng2-completer": "2.0.8",
+"ng2-smart-table": "1.3.5",
+"ngx-echarts": "2.0.1",
+"normalize.css": "6.0.0",
+"pace-js": "1.0.2",
+"roboto-fontface": "0.8.0",
Review comment:
are we using this anywhere in our code?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceComb Saga Frontend
> -
>
> Key: SCB-935
> URL: https://issues.apache.org/jira/browse/SCB-935
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Develop new ServiceComb Saga Frontend based on the design over here
> https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[
https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652951#comment-16652951
]
ASF GitHub Bot commented on SCB-935:
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225778878
##
File path: saga-web/src/main/resources/saga-frontend/package.json
##
@@ -0,0 +1,115 @@
+{
+ "name": "saga-frontend",
+ "version": "2.3.0",
+ "license": "MIT",
+ "repository": {
+"type": "git",
+"url": "git+https://github.com/akveo/ngx-admin.git";
+ },
+ "bugs": {
+"url": "https://github.com/akveo/ngx-admin/issues";
+ },
+ "browserslist": [
+"> 1%",
+"last 2 versions",
+"IE 11"
+ ],
+ "scripts": {
Review comment:
probably we don't need these
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceComb Saga Frontend
> -
>
> Key: SCB-935
> URL: https://issues.apache.org/jira/browse/SCB-935
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Develop new ServiceComb Saga Frontend based on the design over here
> https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[
https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652936#comment-16652936
]
ASF GitHub Bot commented on SCB-935:
asifdxtreme commented on a change in pull request #317: [SCB-935] [WIP] Saga
transaction management console UI initial commit
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/317#discussion_r225778816
##
File path: saga-web/src/main/resources/saga-frontend/package.json
##
@@ -0,0 +1,115 @@
+{
+ "name": "saga-frontend",
+ "version": "2.3.0",
+ "license": "MIT",
+ "repository": {
+"type": "git",
+"url": "git+https://github.com/akveo/ngx-admin.git";
Review comment:
please update these links
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ServiceComb Saga Frontend
> -
>
> Key: SCB-935
> URL: https://issues.apache.org/jira/browse/SCB-935
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Develop new ServiceComb Saga Frontend based on the design over here
> https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-966) Downloaded Html file for schema's are static pages because of which models are not visible
[ https://issues.apache.org/jira/browse/SCB-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652929#comment-16652929 ] Mohammad Asif Siddiqui commented on SCB-966: Adding the other option to download schema in swagger.yaml format seems to be a better solution > Downloaded Html file for schema's are static pages because of which models > are not visible > -- > > Key: SCB-966 > URL: https://issues.apache.org/jira/browse/SCB-966 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Affects Versions: service-center-1.0.0 >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Labels: features > > Issue : Currently the downloaded html file for schema is the static file > because of which the models and other closures are not visible. > Solution : Either find another solution to download the html which is > dynamic, something like httpClient for Swagger OR provide the schema in a > swagger file -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-966) Downloaded Html file for schema's are static pages because of which models are not visible
Mohammad Asif Siddiqui created SCB-966: -- Summary: Downloaded Html file for schema's are static pages because of which models are not visible Key: SCB-966 URL: https://issues.apache.org/jira/browse/SCB-966 Project: Apache ServiceComb Issue Type: Improvement Components: Service-Center Affects Versions: service-center-1.0.0 Reporter: Mohammad Asif Siddiqui Assignee: Mohammad Asif Siddiqui Issue : Currently the downloaded html file for schema is the static file because of which the models and other closures are not visible. Solution : Either find another solution to download the html which is dynamic, something like httpClient for Swagger OR provide the schema in a swagger file -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-965) resolve DoS attack problem about enum/byte/Byte/short/Short/int/Integer/long/Long/float/Float/double/Double
wujimin created SCB-965: --- Summary: resolve DoS attack problem about enum/byte/Byte/short/Short/int/Integer/long/Long/float/Float/double/Double Key: SCB-965 URL: https://issues.apache.org/jira/browse/SCB-965 Project: Apache ServiceComb Issue Type: Bug Components: Java-Chassis Reporter: wujimin Assignee: wujimin Fix For: java-chassis-1.1.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-837) make http2 production ready
[
https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652837#comment-16652837
]
ASF GitHub Bot commented on SCB-837:
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r225760967
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/TransportClientConfig.java
##
@@ -48,9 +75,11 @@ public static int getConnectionIdleTimeoutInSeconds() {
}
public static boolean getConnectionKeepAlive() {
-return
DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.rest.client.connection.keepAlive",
true).get();
+return
DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.rest.client.connection.keepAlive",
true)
Review comment:
io.vertx.core.http.HttpClientOptions#DEFAULT_KEEP_ALIVE
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> make http2 production ready
> ---
>
> Key: SCB-837
> URL: https://issues.apache.org/jira/browse/SCB-837
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: 何一乐
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> currenty, http2 client use all http1.1 settings, that cause http2 client
> performance is so bad.
>
> we need to conside http2 client settings at least:
> 1.concurrent stream in one connection, default value is 3, we must make it
> bigger
> 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent
> stream count
>
> we must perform a performance test, that make sure got a good result, and
> then set the setting to be our default setting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-837) make http2 production ready
[
https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652839#comment-16652839
]
ASF GitHub Bot commented on SCB-837:
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r225761072
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/TransportClientConfig.java
##
@@ -48,9 +75,11 @@ public static int getConnectionIdleTimeoutInSeconds() {
}
public static boolean getConnectionKeepAlive() {
-return
DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.rest.client.connection.keepAlive",
true).get();
+return
DynamicPropertyFactory.getInstance().getBooleanProperty("servicecomb.rest.client.connection.keepAlive",
true)
+.get();
}
+
public static boolean getConnectionCompression() {
return DynamicPropertyFactory.getInstance()
.getBooleanProperty("servicecomb.rest.client.connection.compression",
false)
Review comment:
io.vertx.core.http.HttpClientOptions#DEFAULT_TRY_USE_COMPRESSION
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> make http2 production ready
> ---
>
> Key: SCB-837
> URL: https://issues.apache.org/jira/browse/SCB-837
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: 何一乐
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> currenty, http2 client use all http1.1 settings, that cause http2 client
> performance is so bad.
>
> we need to conside http2 client settings at least:
> 1.concurrent stream in one connection, default value is 3, we must make it
> bigger
> 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent
> stream count
>
> we must perform a performance test, that make sure got a good result, and
> then set the setting to be our default setting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-837) make http2 production ready
[
https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652836#comment-16652836
]
ASF GitHub Bot commented on SCB-837:
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r225760905
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/TransportClientConfig.java
##
@@ -37,8 +39,33 @@ public static int getThreadCount() {
return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.thread-count",
1).get();
}
+ public static int getHttp2ConnectionMaxPoolSize() {
+return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.http2.maxPoolSize",
+HttpClientOptions.DEFAULT_HTTP2_MAX_POOL_SIZE)
+.get();
+ }
+
+ public static int getHttp2MultiplexingLimit() {
+return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.http2.multiplexingLimit",
+HttpClientOptions.DEFAULT_HTTP2_MULTIPLEXING_LIMIT)
+.get();
+ }
+
+ public static int getHttp2ConnectionIdleTimeoutInSeconds() {
+return DynamicPropertyFactory.getInstance()
+.getIntProperty("servicecomb.rest.client.http2.idleTimeoutInSeconds",
0)
+.get();
+ }
+
+ public static boolean getUseAlpn() {
+return DynamicPropertyFactory.getInstance()
+.getBooleanProperty("servicecomb.rest.client.http2.useAlpnEnabled",
true)
+.get();
+ }
+
public static int getConnectionMaxPoolSize() {
-return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.connection.maxPoolSize",
5).get();
+return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.connection.maxPoolSize",
5)
Review comment:
io.vertx.core.http.HttpClientOptions#DEFAULT_MAX_POOL_SIZE
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> make http2 production ready
> ---
>
> Key: SCB-837
> URL: https://issues.apache.org/jira/browse/SCB-837
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: 何一乐
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> currenty, http2 client use all http1.1 settings, that cause http2 client
> performance is so bad.
>
> we need to conside http2 client settings at least:
> 1.concurrent stream in one connection, default value is 3, we must make it
> bigger
> 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent
> stream count
>
> we must perform a performance test, that make sure got a good result, and
> then set the setting to be our default setting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-837) make http2 production ready
[
https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652831#comment-16652831
]
ASF GitHub Bot commented on SCB-837:
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r225760102
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/TransportClientConfig.java
##
@@ -37,8 +39,33 @@ public static int getThreadCount() {
return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.thread-count",
1).get();
}
+ public static int getHttp2ConnectionMaxPoolSize() {
+return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.http2.maxPoolSize",
+HttpClientOptions.DEFAULT_HTTP2_MAX_POOL_SIZE)
+.get();
+ }
+
+ public static int getHttp2MultiplexingLimit() {
+return
DynamicPropertyFactory.getInstance().getIntProperty("servicecomb.rest.client.http2.multiplexingLimit",
+HttpClientOptions.DEFAULT_HTTP2_MULTIPLEXING_LIMIT)
+.get();
+ }
+
+ public static int getHttp2ConnectionIdleTimeoutInSeconds() {
+return DynamicPropertyFactory.getInstance()
+.getIntProperty("servicecomb.rest.client.http2.idleTimeoutInSeconds",
0)
Review comment:
io.vertx.core.net.TCPSSLOptions#DEFAULT_IDLE_TIMEOUT
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> make http2 production ready
> ---
>
> Key: SCB-837
> URL: https://issues.apache.org/jira/browse/SCB-837
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: 何一乐
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> currenty, http2 client use all http1.1 settings, that cause http2 client
> performance is so bad.
>
> we need to conside http2 client settings at least:
> 1.concurrent stream in one connection, default value is 3, we must make it
> bigger
> 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent
> stream count
>
> we must perform a performance test, that make sure got a good result, and
> then set the setting to be our default setting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-837) make http2 production ready
[
https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652829#comment-16652829
]
ASF GitHub Bot commented on SCB-837:
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r225759853
##
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
##
@@ -133,7 +139,24 @@ public void disconnected(Object webSocketMetric) {
@Override
public DefaultHttpSocketMetric connected(SocketAddress remoteAddress, String
remoteName) {
-return new DefaultHttpSocketMetric(null);
+// when host of createEndpoint is not ip but a hostName
+// get from remoteAddress will return null
+// in this time need to try again with remoteName
+// connected is a low frequency method, this try logic will not cause
performance problem
+
+DefaultClientEndpointMetric clientEndpointMetric =
this.clientEndpointMetricManager
+.getClientEndpointMetric(remoteAddress);
+if (clientEndpointMetric == null) {
+ LOGGER.warn("can not find endpointMetric directly by remoteAddress {},
try again with remoteName {}",
Review comment:
line from 142 to 145 explain when will get a null result.
but i think the warn log is not necessary, it's a normal status, no need to
warn
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> make http2 production ready
> ---
>
> Key: SCB-837
> URL: https://issues.apache.org/jira/browse/SCB-837
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: 何一乐
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> currenty, http2 client use all http1.1 settings, that cause http2 client
> performance is so bad.
>
> we need to conside http2 client settings at least:
> 1.concurrent stream in one connection, default value is 3, we must make it
> bigger
> 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent
> stream count
>
> we must perform a performance test, that make sure got a good result, and
> then set the setting to be our default setting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-837) make http2 production ready
[
https://issues.apache.org/jira/browse/SCB-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652825#comment-16652825
]
ASF GitHub Bot commented on SCB-837:
wujimin commented on a change in pull request #947: [SCB-837] make http2
production ready
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/947#discussion_r225759652
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/RestTransportClient.java
##
@@ -87,6 +85,21 @@ private static HttpClientOptions createHttpClientOptions() {
return httpClientOptions;
}
+ private static HttpClientOptions createHttp2ClientOptions() {
+HttpClientOptions httpClientOptions = new HttpClientOptions();
+
httpClientOptions.setMaxPoolSize(TransportClientConfig.getConnectionMaxPoolSize())
+.setUseAlpn(TransportClientConfig.getUseAlpn())
+.setHttp2ClearTextUpgrade(false)
Review comment:
last developer said that must set to false
but he did not make http2 production ready
so we better to confirm this again:
producer a is h2
producer b is h2c
one consumer can invoke both a and b
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> make http2 production ready
> ---
>
> Key: SCB-837
> URL: https://issues.apache.org/jira/browse/SCB-837
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: 何一乐
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> currenty, http2 client use all http1.1 settings, that cause http2 client
> performance is so bad.
>
> we need to conside http2 client settings at least:
> 1.concurrent stream in one connection, default value is 3, we must make it
> bigger
> 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent
> stream count
>
> we must perform a performance test, that make sure got a good result, and
> then set the setting to be our default setting.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-964) Fix MediaType setting problem
[ https://issues.apache.org/jira/browse/SCB-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652625#comment-16652625 ] ASF GitHub Bot commented on SCB-964: coveralls commented on issue #958: [SCB-964] Fix setting MediaType problem URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/958#issuecomment-430434078 [](https://coveralls.io/builds/19550189) Coverage increased (+0.01%) to 86.346% when pulling **d726523e361f557c39de33f33e5eed5ff6541c15 on yhs0092:fix_setting_consumes_problem_UnsupportedOperationException** into **abdb21adee72717f8fadd6f5fa2a89ebe4e00920 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix MediaType setting problem > - > > Key: SCB-964 > URL: https://issues.apache.org/jira/browse/SCB-964 > Project: Apache ServiceComb > Issue Type: Bug >Affects Versions: java-chassis-1.1.0 >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > > When users set consumes/produces by @RequestMapping annotation, and then set > consumes/produces by @ApiOperation again. An UnsupportedOperationException > will be thrown because RequestMappingMethodAnnotationProcessor set a List > into consumes/produces of swagger Operation that does not allow add() > operation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-718) If auto discovery failed , will cause a dead cycle
[ https://issues.apache.org/jira/browse/SCB-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652522#comment-16652522 ] ASF GitHub Bot commented on SCB-718: coveralls edited a comment on issue #937: [SCB-718]If auto discovery failed, will cause a dead cycle URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/937#issuecomment-425730811 [](https://coveralls.io/builds/19541679) Coverage increased (+0.1%) to 86.337% when pulling **06472d01a03c117ec910c9a180bced96e33f001b on laijianbin:cache** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > If auto discovery failed , will cause a dead cycle > -- > > Key: SCB-718 > URL: https://issues.apache.org/jira/browse/SCB-718 > Project: Apache ServiceComb > Issue Type: Task >Reporter: laijianbin >Assignee: laijianbin >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-718) If auto discovery failed , will cause a dead cycle
[ https://issues.apache.org/jira/browse/SCB-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652523#comment-16652523 ] ASF GitHub Bot commented on SCB-718: coveralls edited a comment on issue #937: [SCB-718]If auto discovery failed, will cause a dead cycle URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/937#issuecomment-425730811 [](https://coveralls.io/builds/19541694) Coverage increased (+0.1%) to 86.337% when pulling **06472d01a03c117ec910c9a180bced96e33f001b on laijianbin:cache** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > If auto discovery failed , will cause a dead cycle > -- > > Key: SCB-718 > URL: https://issues.apache.org/jira/browse/SCB-718 > Project: Apache ServiceComb > Issue Type: Task >Reporter: laijianbin >Assignee: laijianbin >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-961) Isolation provide a way to isolate for at least a moment
[ https://issues.apache.org/jira/browse/SCB-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652514#comment-16652514 ] ASF GitHub Bot commented on SCB-961: coveralls commented on issue #957: [SCB-961]provide a way to isolate for at least a moment URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/957#issuecomment-430415856 [](https://coveralls.io/builds/19541087) Coverage decreased (-0.0009%) to 86.331% when pulling **c62833443b8fdbae147f8579074dbedee83293e1 on liubao68:isolation-rev** into **abdb21adee72717f8fadd6f5fa2a89ebe4e00920 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Isolation provide a way to isolate for at least a moment > > > Key: SCB-961 > URL: https://issues.apache.org/jira/browse/SCB-961 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > > Scenario > Assume provider will producer 50% error, and consumer access producer with > very high volume. (concurrent access) > Now if reached isolation condition, and will recover almost at once since > it's quite likely a concurrent access will give a success invocation. > In order to isolate for at least a minimal time in this scenario, we provide > a configuration for this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651859#comment-16651859 ] ASF GitHub Bot commented on SCB-953: codecov-io commented on issue #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458#issuecomment-430272510 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=h1) Report > Merging [#458](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/8ddbc2f1bbcda497fb059bac928efb93433e9808?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #458 +/- ## == + Coverage 60.18% 60.19% +<.01% == Files 156 156 Lines 1341113411 == + Hits 8072 8073 +1 Misses 4760 4760 + Partials 579 578 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: | | [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `64.07% <0%> (+0.97%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=footer). Last update [8ddbc2f...bc24da1](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/458?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-964) Fix MediaType setting problem
[ https://issues.apache.org/jira/browse/SCB-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651854#comment-16651854 ] ASF GitHub Bot commented on SCB-964: yhs0092 opened a new pull request #958: [SCB-964] Fix setting MediaType problem URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/958 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix MediaType setting problem > - > > Key: SCB-964 > URL: https://issues.apache.org/jira/browse/SCB-964 > Project: Apache ServiceComb > Issue Type: Bug >Affects Versions: java-chassis-1.1.0 >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > > When users set consumes/produces by @RequestMapping annotation, and then set > consumes/produces by @ApiOperation again. An UnsupportedOperationException > will be thrown because RequestMappingMethodAnnotationProcessor set a List > into consumes/produces of swagger Operation that does not allow add() > operation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-964) Fix MediaType setting problem
YaoHaishi created SCB-964: - Summary: Fix MediaType setting problem Key: SCB-964 URL: https://issues.apache.org/jira/browse/SCB-964 Project: Apache ServiceComb Issue Type: Bug Affects Versions: java-chassis-1.1.0 Reporter: YaoHaishi Assignee: YaoHaishi When users set consumes/produces by @RequestMapping annotation, and then set consumes/produces by @ApiOperation again. An UnsupportedOperationException will be thrown because RequestMappingMethodAnnotationProcessor set a List into consumes/produces of swagger Operation that does not allow add() operation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-953) Support sync distinct Kubernetes service types to service-center
[ https://issues.apache.org/jira/browse/SCB-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651817#comment-16651817 ] ASF GitHub Bot commented on SCB-953: little-cui opened a new pull request #458: SCB-953 Support sync distinct Kubernetes service types to service-center URL: https://github.com/apache/incubator-servicecomb-service-center/pull/458 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support sync distinct Kubernetes service types to service-center > > > Key: SCB-953 > URL: https://issues.apache.org/jira/browse/SCB-953 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-963) Saga transactional method can't work when compensation happens
cherrylzhao created SCB-963: --- Summary: Saga transactional method can't work when compensation happens Key: SCB-963 URL: https://issues.apache.org/jira/browse/SCB-963 Project: Apache ServiceComb Issue Type: Bug Components: Saga Affects Versions: saga-0.2.0, saga-0.3.0 Reporter: cherrylzhao Assignee: cherrylzhao Fix For: saga-0.3.0 currently we cached the compensation method of raw bean in callback context. it will make transactional method inefficient, we should cache the transaction proxy bean instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[ https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651467#comment-16651467 ] ASF GitHub Bot commented on SCB-935: anvithks commented on issue #317: [SCB-935] [WIP] Saga transaction management console UI initial commit URL: https://github.com/apache/incubator-servicecomb-saga/pull/317#issuecomment-430188706 > BTW, we can need to create a module of UI first, then put the compiled js into the static resource directory of the saga-web. I will write an install script for the UI. This script will compile the UI from the source and copy the contents of the dist/ folder in to the static/ folder. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ServiceComb Saga Frontend > - > > Key: SCB-935 > URL: https://issues.apache.org/jira/browse/SCB-935 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > > Develop new ServiceComb Saga Frontend based on the design over here > https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-935) ServiceComb Saga Frontend
[ https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651464#comment-16651464 ] ASF GitHub Bot commented on SCB-935: anvithks commented on issue #317: [SCB-935] [WIP] Saga transaction management console UI initial commit URL: https://github.com/apache/incubator-servicecomb-saga/pull/317#issuecomment-430188343 > @anvithks After went through the PR, I found you may just copy https://github.com/akveo/ngx-admin/tree/starter-kit code here. I'm not sure if it's best way to do it, but need to make sure it works with Apache License first. @WillemJiang sorry for the delayed response. I was on planned vacation and could not check on this. Yes, you are right we can use the starter kit but it does not have many of the UI components that we have used in the UI. I will check if I can start with the starter-kit and add our modules. Let me get back to you on that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ServiceComb Saga Frontend > - > > Key: SCB-935 > URL: https://issues.apache.org/jira/browse/SCB-935 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Saga >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > > Develop new ServiceComb Saga Frontend based on the design over here > https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-962) The forwardPolicy of Saga can configurethe maximum of retries
Sion Yang created SCB-962: - Summary: The forwardPolicy of Saga can configurethe maximum of retries Key: SCB-962 URL: https://issues.apache.org/jira/browse/SCB-962 Project: Apache ServiceComb Issue Type: Improvement Components: Saga Affects Versions: saga-0.2.0 Reporter: Sion Yang Assignee: Sion Yang Fix For: saga-0.3.0 Currently, forwardPolicy would keep trying transaction part when transaction failed, which may cause saga retry transaction infinitely. So it's necessary to configure the maximum of transaction retries. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
