[jira] [Commented] (SCB-1056) Put provider QPS flow control in front
[ https://issues.apache.org/jira/browse/SCB-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705610#comment-16705610 ] ASF GitHub Bot commented on SCB-1056: - yhs0092 commented on issue #1017: [SCB-1056] put provider flow control logic in front URL: https://github.com/apache/servicecomb-java-chassis/pull/1017#issuecomment-443396967 I think a better solution is to refactor the handler mechanism and let the handler execution position more flexiable. The PR just provides a temporary solution. And I don't use the `ProviderQpsFlowControlHandler` like `UiDispathcer` using `LoadBalanceHandler`, because I want to avoid importing extra maven dependency. The better solution may require a full refactoring design for handler mechanism. This should be tracked in a new issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Put provider QPS flow control in front > -- > > Key: SCB-1056 > URL: https://issues.apache.org/jira/browse/SCB-1056 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > > Currently provider QPS flow control is in ProviderQpsFlowControlHandler which > works in provider handler chain. As a result, the flow control logic takes > effect too late and much CPU resource is wasted on processing those requests > that should be rejected earlier. > Put the provider QPS flow control logic in front can save the resource. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1056) Put provider QPS flow control in front
[
https://issues.apache.org/jira/browse/SCB-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705602#comment-16705602
]
ASF GitHub Bot commented on SCB-1056:
-
yhs0092 commented on a change in pull request #1017: [SCB-1056] put provider
flow control logic in front
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1017#discussion_r238050682
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##
@@ -150,6 +167,39 @@ protected void scheduleInvocation() {
});
}
+ private Holder checkQpsFlowControl(OperationMeta operationMeta) {
+Holder qpsFlowControlReject = new Holder<>(false);
+Handler providerQpsFlowControlHandler =
findQpsFlowControlHandler(operationMeta);
+if (null != providerQpsFlowControlHandler) {
+ try {
+providerQpsFlowControlHandler.handle(invocation, response -> {
+ qpsFlowControlReject.value = true;
+ produceProcessor = ProduceProcessorManager.JSON_PROCESSOR;
+ sendResponse(response);
+});
+ } catch (Exception e) {
+LOGGER.error("failed to execute ProviderQpsFlowControlHandler", e);
+qpsFlowControlReject.value = true;
+sendFailResponse(e);
+ }
+}
+return qpsFlowControlReject;
Review comment:
I don't quite understand this statement.
Do you mean in line 175
```
providerQpsFlowControlHandler.handle(invocation, response -> {
```
the `response` may be null?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Put provider QPS flow control in front
> --
>
> Key: SCB-1056
> URL: https://issues.apache.org/jira/browse/SCB-1056
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
>
> Currently provider QPS flow control is in ProviderQpsFlowControlHandler which
> works in provider handler chain. As a result, the flow control logic takes
> effect too late and much CPU resource is wasted on processing those requests
> that should be rejected earlier.
> Put the provider QPS flow control logic in front can save the resource.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1056) Put provider QPS flow control in front
[
https://issues.apache.org/jira/browse/SCB-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705600#comment-16705600
]
ASF GitHub Bot commented on SCB-1056:
-
yhs0092 commented on a change in pull request #1017: [SCB-1056] put provider
flow control logic in front
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1017#discussion_r238050519
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##
@@ -150,6 +167,39 @@ protected void scheduleInvocation() {
});
}
+ private Holder checkQpsFlowControl(OperationMeta operationMeta) {
+Holder qpsFlowControlReject = new Holder<>(false);
+Handler providerQpsFlowControlHandler =
findQpsFlowControlHandler(operationMeta);
+if (null != providerQpsFlowControlHandler) {
+ try {
+providerQpsFlowControlHandler.handle(invocation, response -> {
Review comment:
No, `ProviderQpsFlowControlHandler` has been modified in this PR, too. Now
`ProviderQpsFlowControlHandler` checks whether it is in the handler chain. If
it finds it's in the handler chain, the `Invocation#next()` method will not be
invoked.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Put provider QPS flow control in front
> --
>
> Key: SCB-1056
> URL: https://issues.apache.org/jira/browse/SCB-1056
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
>
> Currently provider QPS flow control is in ProviderQpsFlowControlHandler which
> works in provider handler chain. As a result, the flow control logic takes
> effect too late and much CPU resource is wasted on processing those requests
> that should be rejected earlier.
> Put the provider QPS flow control logic in front can save the resource.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1053) Batch microservices instances discovery API
[ https://issues.apache.org/jira/browse/SCB-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705007#comment-16705007 ] ASF GitHub Bot commented on SCB-1053: - codecov-io edited a comment on issue #502: WIP: SCB-1053 Batch microservices instances discovery API URL: https://github.com/apache/servicecomb-service-center/pull/502#issuecomment-442483359 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=h1) Report > Merging [#502](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/6285f2bb9cb4b6ad7195dfaf931bfb0ba89561de?src=pr&el=desc) will **decrease** coverage by `0.29%`. > The diff coverage is `6.06%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #502 +/- ## = - Coverage 59.21% 58.92% -0.3% = Files 166 166 Lines 1387813944 +66 = - Hits 8218 8216 -2 - Misses 5074 5143 +69 + Partials 586 585 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/core/proto/types.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vdHlwZXMuZ28=) | `0% <ø> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/servicecenter/repo.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvcmVwby5nbw==) | `20% <0%> (-13.34%)` | :arrow_down: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `42.62% <0%> (-4.37%)` | :arrow_down: | | [server/service/validate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdmFsaWRhdGUuZ28=) | `81.66% <0%> (-2.82%)` | :arrow_down: | | [server/service/instance\_validator.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VfdmFsaWRhdG9yLmdv) | `86.66% <0%> (-13.34%)` | :arrow_down: | | [server/service/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `63.32% <0%> (-3.8%)` | :arrow_down: | | [server/plugin/pkg/discovery/etcd/repo.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvcmVwby5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `69.01% <0%> (-9.86%)` | :arrow_down: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <0%> (-0.65%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=footer). Last update [6285f2b...34a7765](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this ser
[jira] [Commented] (SCB-1053) Batch microservices instances discovery API
[ https://issues.apache.org/jira/browse/SCB-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705009#comment-16705009 ] ASF GitHub Bot commented on SCB-1053: - coveralls edited a comment on issue #502: WIP: SCB-1053 Batch microservices instances discovery API URL: https://github.com/apache/servicecomb-service-center/pull/502#issuecomment-442483399 [](https://coveralls.io/builds/20386461) Coverage decreased (-0.4%) to 61.373% when pulling **34a7765657878dc492dceaff2c2b486c0ea3e93f on little-cui:find** into **6285f2bb9cb4b6ad7195dfaf931bfb0ba89561de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Batch microservices instances discovery API > --- > > Key: SCB-1053 > URL: https://issues.apache.org/jira/browse/SCB-1053 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1053) Batch microservices instances discovery API
[ https://issues.apache.org/jira/browse/SCB-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704951#comment-16704951 ] ASF GitHub Bot commented on SCB-1053: - little-cui commented on a change in pull request #502: WIP: SCB-1053 Batch microservices instances discovery API URL: https://github.com/apache/servicecomb-service-center/pull/502#discussion_r237722818 ## File path: server/core/swagger/v4.yaml ## @@ -1417,6 +1424,44 @@ paths: description: 内部错误 schema: type: string +post: Review comment: because the query parameter maybe beyond the url length limitation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Batch microservices instances discovery API > --- > > Key: SCB-1053 > URL: https://issues.apache.org/jira/browse/SCB-1053 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-1055) Please delete old releases from mirroring system
[ https://issues.apache.org/jira/browse/SCB-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb closed SCB-1055. - thanks > Please delete old releases from mirroring system > > > Key: SCB-1055 > URL: https://issues.apache.org/jira/browse/SCB-1055 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: Sebb >Assignee: Mohammad Asif Siddiqui >Priority: Major > > To reduce the load on the ASF mirrors, projects are required to delete old > releases [1] > Please can you remove all non-current releases from the dist/release area? > It's unfair to expect the 3rd party mirrors to carry old releases. > However you can still link to the archives for historic releases. > Please also update your release procedures (if relevant) > Thanks! > [1] http://www.apache.org/dev/release.html#when-to-archive -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-1058) Remove Incubator dist tree
Sebb created SCB-1058: - Summary: Remove Incubator dist tree Key: SCB-1058 URL: https://issues.apache.org/jira/browse/SCB-1058 Project: Apache ServiceComb Issue Type: Task Reporter: Sebb The Incubator dist tree is no longer needed, and should be removed: https://dist.apache.org/repos/dist/release/incubator/servicecomb/ and https://dist.apache.org/repos/dist/dev/incubator/servicecomb/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-1055) Please delete old releases from mirroring system
[ https://issues.apache.org/jira/browse/SCB-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui resolved SCB-1055. - Resolution: Fixed > Please delete old releases from mirroring system > > > Key: SCB-1055 > URL: https://issues.apache.org/jira/browse/SCB-1055 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: Sebb >Assignee: Mohammad Asif Siddiqui >Priority: Major > > To reduce the load on the ASF mirrors, projects are required to delete old > releases [1] > Please can you remove all non-current releases from the dist/release area? > It's unfair to expect the 3rd party mirrors to carry old releases. > However you can still link to the archives for historic releases. > Please also update your release procedures (if relevant) > Thanks! > [1] http://www.apache.org/dev/release.html#when-to-archive -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1055) Please delete old releases from mirroring system
[ https://issues.apache.org/jira/browse/SCB-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704732#comment-16704732 ] Mohammad Asif Siddiqui commented on SCB-1055: - Release Guide has been updated and present over here http://servicecomb.apache.org/developers/release-guide/ > Please delete old releases from mirroring system > > > Key: SCB-1055 > URL: https://issues.apache.org/jira/browse/SCB-1055 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: Sebb >Assignee: Mohammad Asif Siddiqui >Priority: Major > > To reduce the load on the ASF mirrors, projects are required to delete old > releases [1] > Please can you remove all non-current releases from the dist/release area? > It's unfair to expect the 3rd party mirrors to carry old releases. > However you can still link to the archives for historic releases. > Please also update your release procedures (if relevant) > Thanks! > [1] http://www.apache.org/dev/release.html#when-to-archive -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1055) Please delete old releases from mirroring system
[ https://issues.apache.org/jira/browse/SCB-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704654#comment-16704654 ] ASF GitHub Bot commented on SCB-1055: - asifdxtreme commented on issue #156: [SCB-1055] Update the 1.1.0 Release Info and update old release links to archive URL: https://github.com/apache/servicecomb-website/pull/156#issuecomment-443187281 Preview : https://asifdxtreme.github.io/servicecomb-website/release/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Please delete old releases from mirroring system > > > Key: SCB-1055 > URL: https://issues.apache.org/jira/browse/SCB-1055 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: Sebb >Assignee: Mohammad Asif Siddiqui >Priority: Major > > To reduce the load on the ASF mirrors, projects are required to delete old > releases [1] > Please can you remove all non-current releases from the dist/release area? > It's unfair to expect the 3rd party mirrors to carry old releases. > However you can still link to the archives for historic releases. > Please also update your release procedures (if relevant) > Thanks! > [1] http://www.apache.org/dev/release.html#when-to-archive -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1055) Please delete old releases from mirroring system
[ https://issues.apache.org/jira/browse/SCB-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704652#comment-16704652 ] ASF GitHub Bot commented on SCB-1055: - asifdxtreme opened a new pull request #156: [SCB-1055] Update the 1.1.0 Release Info and update old release links to archive URL: https://github.com/apache/servicecomb-website/pull/156 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Please delete old releases from mirroring system > > > Key: SCB-1055 > URL: https://issues.apache.org/jira/browse/SCB-1055 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: Sebb >Assignee: Mohammad Asif Siddiqui >Priority: Major > > To reduce the load on the ASF mirrors, projects are required to delete old > releases [1] > Please can you remove all non-current releases from the dist/release area? > It's unfair to expect the 3rd party mirrors to carry old releases. > However you can still link to the archives for historic releases. > Please also update your release procedures (if relevant) > Thanks! > [1] http://www.apache.org/dev/release.html#when-to-archive -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1053) Batch microservices instances discovery API
[ https://issues.apache.org/jira/browse/SCB-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704448#comment-16704448 ] ASF GitHub Bot commented on SCB-1053: - coveralls edited a comment on issue #502: WIP: SCB-1053 Batch microservices instances discovery API URL: https://github.com/apache/servicecomb-service-center/pull/502#issuecomment-442483399 [](https://coveralls.io/builds/20378521) Coverage decreased (-0.1%) to 61.588% when pulling **7771db051de35b85fe7de379315be1e2917be857 on little-cui:find** into **6285f2bb9cb4b6ad7195dfaf931bfb0ba89561de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Batch microservices instances discovery API > --- > > Key: SCB-1053 > URL: https://issues.apache.org/jira/browse/SCB-1053 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1053) Batch microservices instances discovery API
[ https://issues.apache.org/jira/browse/SCB-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704447#comment-16704447 ] ASF GitHub Bot commented on SCB-1053: - codecov-io edited a comment on issue #502: WIP: SCB-1053 Batch microservices instances discovery API URL: https://github.com/apache/servicecomb-service-center/pull/502#issuecomment-442483359 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=h1) Report > Merging [#502](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/6285f2bb9cb4b6ad7195dfaf931bfb0ba89561de?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `50%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #502 +/- ## == + Coverage 59.21% 59.22% +<.01% == Files 166 166 Lines 1387813886 +8 == + Hits 8218 8224 +6 - Misses 5074 5078 +4 + Partials 586 584 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/core/proto/types.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUvcHJvdG8vdHlwZXMuZ28=) | `0% <ø> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/servicecenter/repo.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvcmVwby5nbw==) | `20% <0%> (-13.34%)` | :arrow_down: | | [server/plugin/pkg/discovery/etcd/repo.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvcmVwby5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <0%> (-0.65%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.93% <0%> (+0.33%)` | :arrow_up: | | [scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==) | `96.15% <0%> (+1.28%)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/502/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.38% <0%> (+3.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=footer). Last update [6285f2b...7771db0](https://codecov.io/gh/apache/servicecomb-service-center/pull/502?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Batch microservices instances discovery API > --- > > Key: SCB-1053 > URL: https://issues.apache.org/jira/browse/SCB-1053 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
