[jira] [Commented] (SCB-331) Log optimization
[
https://issues.apache.org/jira/browse/SCB-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483415#comment-16483415
]
laijianbin commented on SCB-331:
I have commited a PR,but liubao think it is no need to modify.So i closed this
issue
https://github.com/apache/incubator-servicecomb-java-chassis/pull/551
> Log optimization
>
>
> Key: SCB-331
> URL: https://issues.apache.org/jira/browse/SCB-331
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is missing, skip to load configuration from
> config center"); return null; }
> changed to
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is not configured"); return null; }
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-331) Log optimization
[
https://issues.apache.org/jira/browse/SCB-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476953#comment-16476953
]
Yang Bo commented on SCB-331:
-
[~laijianbin] Could you please resolve this issue.
> Log optimization
>
>
> Key: SCB-331
> URL: https://issues.apache.org/jira/browse/SCB-331
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is missing, skip to load configuration from
> config center"); return null; }
> changed to
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is not configured"); return null; }
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-331) Log optimization
[
https://issues.apache.org/jira/browse/SCB-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359918#comment-16359918
]
ASF GitHub Bot commented on SCB-331:
laijianbin closed pull request #551: [SCB-331] log optimization
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/551
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
b/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
index 28e285512..c28706cc7 100644
---
a/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
+++
b/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
@@ -151,7 +151,7 @@ private static void
duplicateServiceCombConfigToCse(ConcurrentCompositeConfigura
public static DynamicWatchedConfiguration
createConfigFromConfigCenter(Configuration localConfiguration) {
if (localConfiguration.getProperty(configCenterUrlKey) == null) {
- LOGGER.info("config center URL is missing, skip to load configuration
from config center");
+ LOGGER.info("config center URL is not configured");
return null;
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log optimization
>
>
> Key: SCB-331
> URL: https://issues.apache.org/jira/browse/SCB-331
> Project: Apache ServiceComb
> Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is missing, skip to load configuration from
> config center"); return null; }
> changed to
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is not configured"); return null; }
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-331) Log optimization
[
https://issues.apache.org/jira/browse/SCB-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357775#comment-16357775
]
ASF GitHub Bot commented on SCB-331:
wujimin commented on a change in pull request #551: [SCB-331] log optimization
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/551#discussion_r167114260
##
File path:
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
##
@@ -151,7 +151,7 @@ private static void
duplicateServiceCombConfigToCse(ConcurrentCompositeConfigura
public static DynamicWatchedConfiguration
createConfigFromConfigCenter(Configuration localConfiguration) {
if (localConfiguration.getProperty(configCenterUrlKey) == null) {
- LOGGER.info("config center URL is missing, skip to load configuration
from config center");
+ LOGGER.info("config center URL is not configured");
Review comment:
1.maybe print config key is better
2."skip to load configuration from config center", it's better to keep this
information
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log optimization
>
>
> Key: SCB-331
> URL: https://issues.apache.org/jira/browse/SCB-331
> Project: Apache ServiceComb
> Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is missing, skip to load configuration from
> config center"); return null; }
> changed to
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is not configured"); return null; }
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-331) Log optimization
[
https://issues.apache.org/jira/browse/SCB-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356634#comment-16356634
]
ASF GitHub Bot commented on SCB-331:
liubao68 commented on issue #551: [SCB-331] log optimization
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/551#issuecomment-364035766
Need english speaker to check. I think it's not better than before.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log optimization
>
>
> Key: SCB-331
> URL: https://issues.apache.org/jira/browse/SCB-331
> Project: Apache ServiceComb
> Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is missing, skip to load configuration from
> config center"); return null; }
> changed to
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is not configured"); return null; }
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-331) Log optimization
[
https://issues.apache.org/jira/browse/SCB-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354953#comment-16354953
]
ASF GitHub Bot commented on SCB-331:
coveralls commented on issue #551: [SCB-331] log optimization
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/551#issuecomment-363654070
[](https://coveralls.io/builds/15407372)
Coverage decreased (-0.01%) to 87.258% when pulling
**ca06d7c9821aa90dd4b77bb82c6be93ca0491f4c on laijianbin:SCB-331** into
**bbe18e493aa3fb3d1531f7e6bee806e22d9994b4 on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log optimization
>
>
> Key: SCB-331
> URL: https://issues.apache.org/jira/browse/SCB-331
> Project: Apache ServiceComb
> Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is missing, skip to load configuration from
> config center"); return null; }
> changed to
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is not configured"); return null; }
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-331) Log optimization
[
https://issues.apache.org/jira/browse/SCB-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16354878#comment-16354878
]
ASF GitHub Bot commented on SCB-331:
laijianbin opened a new pull request #551: [SCB-331] log optimization
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/551
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
JIRA issue. Your pull request should address just this issue, without pulling
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log optimization
>
>
> Key: SCB-331
> URL: https://issues.apache.org/jira/browse/SCB-331
> Project: Apache ServiceComb
> Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
>
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is missing, skip to load configuration from
> config center"); return null; }
> changed to
> public static DynamicWatchedConfiguration
> createConfigFromConfigCenter(Configuration localConfiguration) {
> if (localConfiguration.getProperty(configCenterUrlKey) == null)
> { LOGGER.info("config center URL is not configured"); return null; }
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
