[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=902078=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902078 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 27/Jan/24 07:22 Start Date: 27/Jan/24 07:22 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1913050830 I would try first with `mvn -DskipAssembly package` or install Jakarta modules first ``` cd jakarta mvn -DskipAssembly install ``` and then install the whole project. I noticed some problem with having these transformed modules next to the core modules. Issue Time Tracking --- Worklog Id: (was: 902078) Time Spent: 9h 40m (was: 9.5h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Labels: M1 > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 9h 40m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=902030=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-902030 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 26/Jan/24 22:29 Start Date: 26/Jan/24 22:29 Worklog Time Spent: 10m Work Description: ClancyDamon commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1912779876 Sorry for the delay. Holidays and personal stuff. I'm not doing anything special. I'm just running the maven install command from the source directory after downloading to my local machine - mvn -DskipAssembly=true install I'm following the build instructions from apache - https://struts.apache.org/builds.html Issue Time Tracking --- Worklog Id: (was: 902030) Time Spent: 9.5h (was: 9h 20m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Labels: M1 > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 9.5h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=898296=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898296 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 06/Jan/24 14:13 Start Date: 06/Jan/24 14:13 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1879699081 When using Maven you should be able download SNAPSHOTs from ASF repo or you can download nigthlies from here https://struts.apache.org/builds.html#nightly-builds Issue Time Tracking --- Worklog Id: (was: 898296) Time Spent: 9h 20m (was: 9h 10m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Labels: M1 > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 9h 20m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=898290=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898290 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 06/Jan/24 12:47 Start Date: 06/Jan/24 12:47 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1879672442 How do you run these tests? And maybe it's related to Amazon Corretto yet I don't have version locally to test Issue Time Tracking --- Worklog Id: (was: 898290) Time Spent: 9h 10m (was: 9h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Labels: M1 > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 9h 10m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=898274=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-898274
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 05/Jan/24 23:09
Start Date: 05/Jan/24 23:09
Worklog Time Spent: 10m
Work Description: ClancyDamon commented on PR #778:
URL: https://github.com/apache/struts/pull/778#issuecomment-1879365149
I'm having some trouble building the 7-0-x release. Compilation seems to be
okay, but it fails when executing the tests inside of the core module.
Specifically org.apache.struts2.interceptor.ActionFileUploadInterceptorTest and
org.apache.struts2.interceptor.FileUploadInterceptorTest.
`---
Test set: org.apache.struts2.interceptor.ActionFileUploadInterceptorTest
---
Tests run: 15, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.267 s <<<
FAILURE! - in org.apache.struts2.interceptor.ActionFileUploadInterceptorTest
org.apache.struts2.interceptor.ActionFileUploadInterceptorTest.testMultipleAccept
Time elapsed: 0.021 s <<< FAILURE!
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertNotNull(Assert.java:256)
at junit.framework.Assert.assertNotNull(Assert.java:248)
at junit.framework.TestCase.assertNotNull(TestCase.java:391)
at
org.apache.struts2.interceptor.ActionFileUploadInterceptorTest.testMultipleAccept(ActionFileUploadInterceptorTest.java:360)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at junit.framework.TestCase.runTest(TestCase.java:177)
at junit.framework.TestCase.runBare(TestCase.java:142)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:130)
at junit.framework.TestSuite.runTest(TestSuite.java:241)
at junit.framework.TestSuite.run(TestSuite.java:236)
at
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:90)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:49)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:120)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:95)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:69)
at
org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:146)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
at
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
at
org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)
org.apache.struts2.interceptor.ActionFileUploadInterceptorTest.testUnacceptedNumberOfFiles
Time elapsed: 0.019 s <<< FAILURE!
junit.framework.ComparisonFailure: expected:<[Request exceeded allowed
number of files! Permitted number of files is: 3!]> but was:<[Error uploading:
{0}]>
at junit.framework.Assert.assertEquals(Assert.java:100)
at junit.framework.Assert.assertEquals(Assert.java:107)
at junit.framework.TestCase.assertEquals(TestCase.java:260)
at
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895928=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895928 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 16/Dec/23 09:31 Start Date: 16/Dec/23 09:31 Worklog Time Spent: 10m Work Description: lukaszlenart merged PR #778: URL: https://github.com/apache/struts/pull/778 Issue Time Tracking --- Worklog Id: (was: 895928) Time Spent: 8h 50m (was: 8h 40m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Labels: M1 > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 8h 50m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895927=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895927 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 16/Dec/23 09:30 Start Date: 16/Dec/23 09:30 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1858773261 Let's roll Thanks a lot @jdyer1 for you work and all reviewers Issue Time Tracking --- Worklog Id: (was: 895927) Time Spent: 8h 40m (was: 8.5h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Labels: M1 > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 8h 40m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895882=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895882 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 15/Dec/23 17:00 Start Date: 15/Dec/23 17:00 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1858197528 Thank you @sepe81 for your review. I pushed fixes for each of the problems you identified. Issue Time Tracking --- Worklog Id: (was: 895882) Time Spent: 8.5h (was: 8h 20m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Labels: M1 > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 8.5h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895710=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895710
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 14/Dec/23 18:43
Start Date: 14/Dec/23 18:43
Worklog Time Spent: 10m
Work Description: sepe81 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1427133369
##
core/src/test/java/org/apache/struts2/views/jsp/BeanTagTest.java:
##
@@ -83,8 +83,8 @@ public void testSimple_clearTagStateSet() {
fail();
}
-request.verify();
-pageContext.verify();
+
Review Comment:
remove two empty lines
Issue Time Tracking
---
Worklog Id: (was: 895710)
Time Spent: 8h 20m (was: 8h 10m)
> Support for JEE 9+
> ---
>
> Key: WW-5141
> URL: https://issues.apache.org/jira/browse/WW-5141
> Project: Struts 2
> Issue Type: New Feature
> Components: Core
>Reporter: Daniel Le Berre
>Priority: Major
> Labels: M1
> Fix For: 7.0.0
>
> Attachments: pom.xml
>
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895709=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895709
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 14/Dec/23 18:42
Start Date: 14/Dec/23 18:42
Worklog Time Spent: 10m
Work Description: sepe81 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1427132286
##
core/src/test/java/org/apache/struts2/interceptor/FileUploadInterceptorTest.java:
##
@@ -550,6 +553,7 @@ private String encodeTextFile(String bondary, String
endline, String name, Strin
sb.append(name);
sb.append("\"; filename=\"");
sb.append(filename);
+sb.append("\"");
Review Comment:
Issue Time Tracking
---
Worklog Id: (was: 895709)
Time Spent: 8h 10m (was: 8h)
> Support for JEE 9+
> ---
>
> Key: WW-5141
> URL: https://issues.apache.org/jira/browse/WW-5141
> Project: Struts 2
> Issue Type: New Feature
> Components: Core
>Reporter: Daniel Le Berre
>Priority: Major
> Labels: M1
> Fix For: 7.0.0
>
> Attachments: pom.xml
>
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895707=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895707
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 14/Dec/23 18:32
Start Date: 14/Dec/23 18:32
Worklog Time Spent: 10m
Work Description: sepe81 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1427122866
##
core/src/test/java/org/apache/struts2/dispatcher/mapper/Restful2ActionMapperTest.java:
##
@@ -61,11 +62,11 @@ public Configuration getConfiguration() {
}
public void testGetIndex() throws Exception {
-req.setupGetRequestURI("/my/namespace/foo/");
-req.setupGetServletPath("/my/namespace/foo/");
-req.setupGetAttribute(null);
-req.addExpectedGetAttributeName("javax.servlet.include.servlet_path");
-req.setupGetMethod("GET");
+req.setRequestURI("/my/namespace/foo/");
+req.setServletPath("/my/namespace/foo/");
+//
Review Comment:
remove empty comments or is something missing?
Issue Time Tracking
---
Worklog Id: (was: 895707)
Time Spent: 8h (was: 7h 50m)
> Support for JEE 9+
> ---
>
> Key: WW-5141
> URL: https://issues.apache.org/jira/browse/WW-5141
> Project: Struts 2
> Issue Type: New Feature
> Components: Core
>Reporter: Daniel Le Berre
>Priority: Major
> Labels: M1
> Fix For: 7.0.0
>
> Attachments: pom.xml
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895706=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895706
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 14/Dec/23 18:30
Start Date: 14/Dec/23 18:30
Worklog Time Spent: 10m
Work Description: sepe81 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1427112376
##
core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java:
##
@@ -356,7 +362,11 @@ public void cleanUp() {
for (FileItem item : items) {
LOG.debug("Removing file {} {}", name, item);
if (!item.isInMemory()) {
-item.delete();
+try {
+item.delete();
+} catch (IOException e) {
+throw new RuntimeException(e);
Review Comment:
Maybe use more specific
https://docs.oracle.com/javase/8/docs/api/java/io/UncheckedIOException.html ?
Issue Time Tracking
---
Worklog Id: (was: 895706)
Time Spent: 7h 50m (was: 7h 40m)
> Support for JEE 9+
> ---
>
> Key: WW-5141
> URL: https://issues.apache.org/jira/browse/WW-5141
> Project: Struts 2
> Issue Type: New Feature
> Components: Core
>Reporter: Daniel Le Berre
>Priority: Major
> Labels: M1
> Fix For: 7.0.0
>
> Attachments: pom.xml
>
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895704=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895704
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 14/Dec/23 18:27
Start Date: 14/Dec/23 18:27
Worklog Time Spent: 10m
Work Description: sepe81 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1427104760
##
core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java:
##
@@ -72,16 +73,16 @@ public void parse(HttpServletRequest request, String
saveDir) throws IOException
} catch (FileUploadException e) {
LOG.debug("Request exceeded size limit!", e);
LocalizedMessage errorMessage;
-if (e instanceof FileUploadBase.SizeLimitExceededException) {
-FileUploadBase.SizeLimitExceededException ex =
(FileUploadBase.SizeLimitExceededException) e;
-errorMessage = buildErrorMessage(e, new
Object[]{ex.getPermittedSize(), ex.getActualSize()});
-} else if (e instanceof
FileUploadBase.FileSizeLimitExceededException) {
-FileUploadBase.FileSizeLimitExceededException ex =
(FileUploadBase.FileSizeLimitExceededException) e;
-errorMessage = buildErrorMessage(e, new
Object[]{ex.getFileName(), ex.getPermittedSize(), ex.getActualSize()});
-} else if (e instanceof FileCountLimitExceededException) {
-FileCountLimitExceededException ex =
(FileCountLimitExceededException) e;
-errorMessage = buildErrorMessage(e, new
Object[]{ex.getLimit()});
-} else {
+if (e instanceof FileUploadByteCountLimitException) {
+FileUploadByteCountLimitException ex =
(FileUploadByteCountLimitException) e;
+errorMessage = buildErrorMessage(e, new
Object[]{ex.getFileName(), ex.getPermitted(), ex.getActualSize()});
+} else if (e instanceof FileUploadFileCountLimitException) {
+FileUploadFileCountLimitException ex =
(FileUploadFileCountLimitException) e;
+errorMessage = buildErrorMessage(e, new
Object[]{ex.getPermitted()});
+} else if (e instanceof FileUploadSizeException) {
+FileUploadSizeException ex = (FileUploadSizeException) e;
+errorMessage = buildErrorMessage(e, new
Object[]{ex.getPermitted(), ex.getActualSize()});
+} else {
Review Comment:
```suggestion
} else {
```
revert indentation
Issue Time Tracking
---
Worklog Id: (was: 895704)
Time Spent: 7h 40m (was: 7.5h)
> Support for JEE 9+
> ---
>
> Key: WW-5141
> URL: https://issues.apache.org/jira/browse/WW-5141
> Project: Struts 2
> Issue Type: New Feature
> Components: Core
>Reporter: Daniel Le Berre
>Priority: Major
> Labels: M1
> Fix For: 7.0.0
>
> Attachments: pom.xml
>
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895703=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895703 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 14/Dec/23 18:25 Start Date: 14/Dec/23 18:25 Worklog Time Spent: 10m Work Description: sepe81 commented on code in PR #778: URL: https://github.com/apache/struts/pull/778#discussion_r1427102252 ## core/pom.xml: ## @@ -89,9 +89,8 @@ true - + Review Comment: ```suggestion ``` revert indentation Issue Time Tracking --- Worklog Id: (was: 895703) Time Spent: 7.5h (was: 7h 20m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Labels: M1 > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 7.5h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895522=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895522 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 13/Dec/23 18:39 Start Date: 13/Dec/23 18:39 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1854514238 Last call ... I'm going to merge this PR in a few days and push M1 release Issue Time Tracking --- Worklog Id: (was: 895522) Time Spent: 7h 20m (was: 7h 10m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Labels: M1 > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 7h 20m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895083=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895083
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 11/Dec/23 19:19
Start Date: 11/Dec/23 19:19
Worklog Time Spent: 10m
Work Description: yasserzamani commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1423018930
##
core/src/test/java/org/apache/struts2/views/jsp/BeanTagTest.java:
##
@@ -51,8 +51,8 @@ public void testSimple() {
fail();
}
-request.verify();
-pageContext.verify();
Review Comment:
Thanks for clarification @jdyer1 ! Yes you're right! I also couldn't find
their usage. Those lines are old from 2006. Maybe underlying dependencies get
updated making these left behind and why they don't make sense anymore.
Issue Time Tracking
---
Worklog Id: (was: 895083)
Time Spent: 7h 10m (was: 7h)
> Support for JEE 9+
> ---
>
> Key: WW-5141
> URL: https://issues.apache.org/jira/browse/WW-5141
> Project: Struts 2
> Issue Type: New Feature
> Components: Core
>Reporter: Daniel Le Berre
>Priority: Major
> Labels: M1
> Fix For: 7.0.0
>
> Attachments: pom.xml
>
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=895024=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-895024
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 11/Dec/23 14:21
Start Date: 11/Dec/23 14:21
Worklog Time Spent: 10m
Work Description: jdyer1 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1422533854
##
core/src/test/java/org/apache/struts2/views/jsp/BeanTagTest.java:
##
@@ -51,8 +51,8 @@ public void testSimple() {
fail();
}
-request.verify();
-pageContext.verify();
Review Comment:
@yasserzamani Thank you for your review. I can say for sure that
"pageContext.verify()" is a no-op. As for the request, my belief is the mock
is designed to let the tester set up a series of expectations, then call
"verify" when the test is ready to check them. However, this test seems to set
no expectations, so my belief is the "verify" method here also would do nothing.
You touch here on what I consider to be the most risky of these changes:
The "mockobjects" library for the servlet api could no longer be used so I
replaced them with the Spring library's mocks. However, the Spring mocks do
not support this "set/verify" pattern so in the few places our code uses it, I
had to make a judgement as to what I thought the original intent was. I cannot
say for sure I got this right 100% of the time!
Issue Time Tracking
---
Worklog Id: (was: 895024)
Time Spent: 7h (was: 6h 50m)
> Support for JEE 9+
> ---
>
> Key: WW-5141
> URL: https://issues.apache.org/jira/browse/WW-5141
> Project: Struts 2
> Issue Type: New Feature
> Components: Core
>Reporter: Daniel Le Berre
>Priority: Major
> Labels: M1
> Fix For: 7.0.0
>
> Attachments: pom.xml
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=894918=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894918
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 10/Dec/23 18:54
Start Date: 10/Dec/23 18:54
Worklog Time Spent: 10m
Work Description: yasserzamani commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1421798565
##
core/src/test/java/org/apache/struts2/views/jsp/BeanTagTest.java:
##
@@ -51,8 +51,8 @@ public void testSimple() {
fail();
}
-request.verify();
-pageContext.verify();
Review Comment:
Doesn't removing them skip some verifications that might fail with these
changes? sorry I don't remember.
Issue Time Tracking
---
Worklog Id: (was: 894918)
Time Spent: 6h 50m (was: 6h 40m)
> Support for JEE 9+
> ---
>
> Key: WW-5141
> URL: https://issues.apache.org/jira/browse/WW-5141
> Project: Struts 2
> Issue Type: New Feature
> Components: Core
>Reporter: Daniel Le Berre
>Priority: Major
> Labels: M1
> Fix For: 7.0.0
>
> Attachments: pom.xml
>
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=894432=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894432 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 07/Dec/23 06:30 Start Date: 07/Dec/23 06:30 Worklog Time Spent: 10m Work Description: lukaszlenart commented on code in PR #778: URL: https://github.com/apache/struts/pull/778#discussion_r1418452454 ## apps/showcase/pom.xml: ## @@ -145,6 +146,48 @@ + + org.apache.maven.plugins + maven-dependency-plugin + + + + copy-dependencies + package + +copy Review Comment: It should be possible to play with `` and explicitly defining the re-packaged jakarta libs, but this can be done after merge Issue Time Tracking --- Worklog Id: (was: 894432) Time Spent: 6h 40m (was: 6.5h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Labels: M1 > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 6h 40m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=894076=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894076 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 05/Dec/23 14:27 Start Date: 05/Dec/23 14:27 Worklog Time Spent: 10m Work Description: jdyer1 commented on code in PR #778: URL: https://github.com/apache/struts/pull/778#discussion_r1415702842 ## apps/showcase/pom.xml: ## @@ -145,6 +146,48 @@ + + org.apache.maven.plugins + maven-dependency-plugin + + + + copy-dependencies + package + +copy Review Comment: @kusalk I struggled when doing this to figure out how the jetty-maven-plugin was building its classpath. It was not including the 4 jars we generate from the Eclipse Transformer, so the showcase integration tests all would fail. The solution I found was to use the Jetty "extraclasspath" feature (see same pom.xml lines 236ff) in conjunction with copying the jars as you see here. In my ignorance I may have passed up a more-elegant solution! Issue Time Tracking --- Worklog Id: (was: 894076) Time Spent: 6.5h (was: 6h 20m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 6.5h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=894032=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-894032 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 05/Dec/23 10:12 Start Date: 05/Dec/23 10:12 Worklog Time Spent: 10m Work Description: kusalk commented on code in PR #778: URL: https://github.com/apache/struts/pull/778#discussion_r1415291209 ## apps/showcase/pom.xml: ## @@ -145,6 +146,48 @@ + + org.apache.maven.plugins + maven-dependency-plugin + + + + copy-dependencies + package + +copy Review Comment: I'm probably missing something here but why do we need to explicitly copy these jars? Issue Time Tracking --- Worklog Id: (was: 894032) Time Spent: 6h 20m (was: 6h 10m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 6h 20m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=893545=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893545 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 02/Dec/23 14:14 Start Date: 02/Dec/23 14:14 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1837158390 Ok done [WW-5366](https://issues.apache.org/jira/browse/WW-5366) Issue Time Tracking --- Worklog Id: (was: 893545) Time Spent: 6h 10m (was: 6h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 6h 10m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=893420=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893420 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 01/Dec/23 13:43 Start Date: 01/Dec/23 13:43 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1836142398 @lukaszlenart Thank you for the confirmation about uploading a file. I'd prefer we get a new ticket for dropping support for empty files. I'm fairly new to the struts code base and I am not fully sure the best way to introduce a new error message, etc. Issue Time Tracking --- Worklog Id: (was: 893420) Time Spent: 6h (was: 5h 50m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 6h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=893308=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893308 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 01/Dec/23 07:20 Start Date: 01/Dec/23 07:20 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1835600707 I think you are right, after re-reviewing the related issues I'm confident we should drop support for _upload an empty file_ - it would be good to introduce a proper error message instead and that's all :) If you want you can do it in your patch or we can create a ticket and do it afterwards. https://issues.apache.org/jira/browse/FILEUPLOAD-295 https://issues.apache.org/jira/browse/WW-5088 Issue Time Tracking --- Worklog Id: (was: 893308) Time Spent: 5h 50m (was: 5h 40m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 5h 50m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=893226=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893226 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 30/Nov/23 16:53 Start Date: 30/Nov/23 16:53 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1834158198 @lukaszlenart We still have a test failure `it.org.apache.struts2.showcase.FileUploadTest`, currently @Ignore'd. It is odd to me that none of the file upload unit tests fail. I wonder if we are checking something invalid here, that is, if it is trying to determine the difference between a missing file and a zero-length file? If this is all that is lost, is this really functionality we need to support? Issue Time Tracking --- Worklog Id: (was: 893226) Time Spent: 5h 40m (was: 5.5h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 5h 40m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=893214=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-893214
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 30/Nov/23 15:59
Start Date: 30/Nov/23 15:59
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1410882608
##
core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java:
##
@@ -186,13 +191,14 @@ protected ServletFileUpload
createServletFileUpload(DiskFileItemFactory fac) {
}
protected DiskFileItemFactory createDiskFileItemFactory(String saveDir) {
-DiskFileItemFactory fac = new DiskFileItemFactory();
+DiskFileItemFactory.Builder fac = DiskFileItemFactory.builder();
// Make sure that the data is written to file, even if the file is
empty.
-fac.setSizeThreshold(-1);
+//setting 0 or -1 no longer seems to work for fileupload buffer size,
so using 1 instead.
+fac.setBufferSize(1);
if (saveDir != null) {
-fac.setRepository(new File(saveDir));
+fac.setPath(saveDir);
Review Comment:
is it resolved?
Issue Time Tracking
---
Worklog Id: (was: 893214)
Time Spent: 5.5h (was: 5h 20m)
> Support for JEE 9+
> ---
>
> Key: WW-5141
> URL: https://issues.apache.org/jira/browse/WW-5141
> Project: Struts 2
> Issue Type: New Feature
> Components: Core
>Reporter: Daniel Le Berre
>Priority: Major
> Fix For: 7.0.0
>
> Attachments: pom.xml
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=892358=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892358 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 27/Nov/23 14:27 Start Date: 27/Nov/23 14:27 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1827941506 @kusalk I synced my fork again with "release/struts-7-0-x". I also think I solved all the whitespace issues you were seeing. @lukaszlenart I invited you as a "collaborator" on my fork. I am not so skilled with github, but I think that will give you +w access to the fork once you accept. Issue Time Tracking --- Worklog Id: (was: 892358) Time Spent: 5h 20m (was: 5h 10m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 5h 20m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=892120=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892120 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 24/Nov/23 16:03 Start Date: 24/Nov/23 16:03 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1825860957 @jdyer1 could you grant me access to your fork? Issue Time Tracking --- Worklog Id: (was: 892120) Time Spent: 5h 10m (was: 5h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 5h 10m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=892027=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-892027 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 23/Nov/23 12:44 Start Date: 23/Nov/23 12:44 Worklog Time Spent: 10m Work Description: kusalk commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1824370783 @jdyer1 Please merge `release/struts-7-0-x` into your feature branch once more and this PR should go green and be ready for review Also I did noticed there's mixed indents in your PR, can we please standardise on spaces instead of tabs as that is what the majority of files in this repo are using :) Issue Time Tracking --- Worklog Id: (was: 892027) Time Spent: 5h (was: 4h 50m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 5h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=891978=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891978 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 23/Nov/23 09:18 Start Date: 23/Nov/23 09:18 Worklog Time Spent: 10m Work Description: kusalk commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1824045446 Looks like the assembly job is failing due to some missed deletions - I threw up #799 to try and rectify Issue Time Tracking --- Worklog Id: (was: 891978) Time Spent: 4h 50m (was: 4h 40m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 4h 50m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=891885=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891885 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 22/Nov/23 16:57 Start Date: 22/Nov/23 16:57 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1823147956 ok @lukaszlenart this branch is now in sync with `release/struts-7-0-x`. What are the next steps in getting this moved to the release branch? Issue Time Tracking --- Worklog Id: (was: 891885) Time Spent: 4h 40m (was: 4.5h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 4h 40m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=891865=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891865
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 22/Nov/23 16:33
Start Date: 22/Nov/23 16:33
Worklog Time Spent: 10m
Work Description: jdyer1 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1402380551
##
core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java:
##
@@ -186,13 +191,14 @@ protected ServletFileUpload
createServletFileUpload(DiskFileItemFactory fac) {
}
protected DiskFileItemFactory createDiskFileItemFactory(String saveDir) {
-DiskFileItemFactory fac = new DiskFileItemFactory();
+DiskFileItemFactory.Builder fac = DiskFileItemFactory.builder();
// Make sure that the data is written to file, even if the file is
empty.
-fac.setSizeThreshold(-1);
+//setting 0 or -1 no longer seems to work for fileupload buffer size,
so using 1 instead.
+fac.setBufferSize(1);
if (saveDir != null) {
-fac.setRepository(new File(saveDir));
+fac.setPath(saveDir);
Review Comment:
Maybe this is a question for the commons-upload dev list? I wonder, also,
is it vital that Struts be able to tell the difference between a missing file
and an empty file? This is the only problem we are having here, correct?
Issue Time Tracking
---
Worklog Id: (was: 891865)
Time Spent: 4.5h (was: 4h 20m)
> Support for JEE 9+
> ---
>
> Key: WW-5141
> URL: https://issues.apache.org/jira/browse/WW-5141
> Project: Struts 2
> Issue Type: New Feature
> Components: Core
>Reporter: Daniel Le Berre
>Priority: Major
> Fix For: 7.0.0
>
> Attachments: pom.xml
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=891630=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891630 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 21/Nov/23 18:27 Start Date: 21/Nov/23 18:27 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1821440220 _time to rebase_ Issue Time Tracking --- Worklog Id: (was: 891630) Time Spent: 4h 20m (was: 4h 10m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 4h 20m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=891455=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891455
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 21/Nov/23 06:37
Start Date: 21/Nov/23 06:37
Worklog Time Spent: 10m
Work Description: tyme-dev commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1400086935
##
core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java:
##
@@ -186,13 +191,14 @@ protected ServletFileUpload
createServletFileUpload(DiskFileItemFactory fac) {
}
protected DiskFileItemFactory createDiskFileItemFactory(String saveDir) {
-DiskFileItemFactory fac = new DiskFileItemFactory();
+DiskFileItemFactory.Builder fac = DiskFileItemFactory.builder();
// Make sure that the data is written to file, even if the file is
empty.
-fac.setSizeThreshold(-1);
+//setting 0 or -1 no longer seems to work for fileupload buffer size,
so using 1 instead.
+fac.setBufferSize(1);
if (saveDir != null) {
-fac.setRepository(new File(saveDir));
+fac.setPath(saveDir);
Review Comment:
@jdyer1 so the test is failing here.
i did make a mistake, this should be` fac.setPath(new File(saveDir))` i
believe. But even when doing that, you're still not able to get the path back
at all.
This seems like a bug with the M1 release of fileupload2, I'm never able to
get a path back for files made with the DiskFileItemFactory, but i could be
overlooking something too.
Issue Time Tracking
---
Worklog Id: (was: 891455)
Time Spent: 4h 10m (was: 4h)
> Support for JEE 9+
> ---
>
> Key: WW-5141
> URL: https://issues.apache.org/jira/browse/WW-5141
> Project: Struts 2
> Issue Type: New Feature
> Components: Core
>Reporter: Daniel Le Berre
>Priority: Major
> Fix For: 7.0.0
>
> Attachments: pom.xml
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> JEE 9 breaks the JEE API by replacing javax domain by jakarta.
> Tomcat 10 implements some specifications of JEE 9.
> Struts 2.5 has some dependencies with the javax servlet API.
> Struts would require some changes to run on Tomcat 10+.
> Is there any plan to support JEE 9+ in the future?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=891453=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891453 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 21/Nov/23 06:28 Start Date: 21/Nov/23 06:28 Worklog Time Spent: 10m Work Description: kusalk commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1820314307 My browser keeps freezing trying to load the diff - I'll have to load it in my IDE instead Probably better to split this one up a bit anyway, maybe do the deprecated plugins removals in a separate preliminary PR? Issue Time Tracking --- Worklog Id: (was: 891453) Time Spent: 4h (was: 3h 50m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 4h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=891445=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891445 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 21/Nov/23 05:35 Start Date: 21/Nov/23 05:35 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1820271576 @jdyer1 this looks very good, we can merge it and continue work on improving the other parts. Also I can prepare a new release, let say `M1` (this what Tomcat team is using) Issue Time Tracking --- Worklog Id: (was: 891445) Time Spent: 3h 50m (was: 3h 40m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 3h 50m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=891417=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891417 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 20/Nov/23 23:33 Start Date: 20/Nov/23 23:33 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1819973394 @lukaszlenart I think I have solved the problems with Velocity-Tools, once again, by using the Eclipse Transformer. Besides this there is one remaining failing unit test (Ignored for now) in the Struts Showcase package around File Uploads. I also would like to figure out a better way for IDEs to work seamlessly with these Eclipse Transformer jar files. Do you think we are at a good place to merge this into the "release/struts-7-0-x" branch and close out this PR. I think it will help with collaboration if it were in an official release branch. I'd also like to know what the roadmap is for a first "alpha" release? Issue Time Tracking --- Worklog Id: (was: 891417) Time Spent: 3h 40m (was: 3.5h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 3h 40m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=891391=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891391 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 20/Nov/23 17:46 Start Date: 20/Nov/23 17:46 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1819535581 @lukaszlenart I believe I resolved most of the problems with "struts-showcase". Before I saw your entire comment about adding a dependency exclusion, I instead added the 2 modified jars using the "extra classpath" Jetty feature. This seems to work. I also got rid of DWR and, for now, commented-out the velocity plugin. @tyme-dev There is one test failure, however, `it.org.apache.struts2.showcase.FileUploadTest`. Is this something you can look at? Issue Time Tracking --- Worklog Id: (was: 891391) Time Spent: 3.5h (was: 3h 20m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 3.5h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=891188=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891188 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 18/Nov/23 10:06 Start Date: 18/Nov/23 10:06 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1817465771 The plugin doesn't run the war by default, it uses target & src so you can edit JSP files and update them in-flight. Temporally we can use `mvn jetty:run-war` instead of `mvn jetty:run` when running the workflow. Issue Time Tracking --- Worklog Id: (was: 891188) Time Spent: 3h 20m (was: 3h 10m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 3h 20m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=891031=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-891031 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 17/Nov/23 00:26 Start Date: 17/Nov/23 00:26 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1815541116 @lukaszlenart Ok, I merged in the "release/struts-7-0-x" branch and now we have a "no conflicts" green check. I also upgraded to the latest jetty-maven plugin. Unfortunately it still fails. It cannot seem to find the Freemarker classes, no doubt related to the Eclipse Transformer usage versus the actual Freemarker jar. But I cannot figure out what is wrong. I see in the Struts Showcase "target" directory a "struts2-showcase.war" file and there is a WEB-INF/lib and sure enough the "struts2-freemarker-jakarta.jar" is present. Opening up this jar, everything appears to be packaged correctly. But I am not so sure this is where the jetty-maven-plugin is getting its classpath? It doesn't seem to be running the web application contained in that .war file, does it? (If it did, it would not be having classloading issues for Freemarker?) Issue Time Tracking --- Worklog Id: (was: 891031) Time Spent: 3h 10m (was: 3h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 3h 10m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890854=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890854 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 16/Nov/23 05:43 Start Date: 16/Nov/23 05:43 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1813823678 @jdyer1 looks good, and switch base for this PR to `release/struts-7-0-x` and it show some conflicts, as far I understand is about deleted plugins so it should be easy to rebase again. About Showcase it uses Maven Jetty Plugin to run Jetty container, this plugin need to be updated to the latest version which supports JakaratEE and should be fine. Issue Time Tracking --- Worklog Id: (was: 890854) Time Spent: 3h (was: 2h 50m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 3h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890758=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890758 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 15/Nov/23 18:42 Start Date: 15/Nov/23 18:42 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1813071460 @tyme-dev Yes, I did see that blog before and it was helpful. I followed instructions from this other, more detailed post [1]. (I did not do the additional step involving the shade plugin, because to my knowledge neither Freemarker nor Sitemesh2 have transitive dependencies that need to be converted.) To be clear here, the build does work correctly with `mvn clean install` at the command line. The issue here is Eclipse IDE does not seem to want to use the local repo artifact but instead uses what is currently in the workspace. Of course there is no code actually in the workspace. - https://omnifish.ee/2023/08/04/upgrade-to-jakarta-ee-10-transform-incompatible-dependencies/ Issue Time Tracking --- Worklog Id: (was: 890758) Time Spent: 2h 50m (was: 2h 40m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 2h 50m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890756=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890756 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 15/Nov/23 18:33 Start Date: 15/Nov/23 18:33 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1813053394 @lukaszlenart I think I successfully rebased my branch on "release/struts-7-0-x". I see however this PR still says it wants to merge to "apache:master". I wonder if I need a new PR to make it want to merge to the release branch? Please double check me, I have not done a rebase like this before. Also, I am not entirely sure how to get the struts showcase tests to pass. It seems to want to spin up a server and make requests to it, but it might need some kind of conversion now that we are on JEE 9+? Issue Time Tracking --- Worklog Id: (was: 890756) Time Spent: 2h 40m (was: 2.5h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 2h 40m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890627=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890627 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 15/Nov/23 05:22 Start Date: 15/Nov/23 05:22 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1811828131 @jdyer1 could you rebase your branch onto `release/struts-7-0-x`? Thanks in advance! Issue Time Tracking --- Worklog Id: (was: 890627) Time Spent: 2.5h (was: 2h 20m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 2.5h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890590=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890590 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 15/Nov/23 00:14 Start Date: 15/Nov/23 00:14 Worklog Time Spent: 10m Work Description: tyme-dev commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1811595974 > I think I have solved the problems with Freemarker and Sitemesh by using the eclipse transformer maven plugin [1]. To make it work, I added two new projects that transform the jars to Jakarta EE 9+ compliant versions. Downstream projects then depend on these new projects. As far as I can tell, this works a lot like the shade plugin. > > Unfortunately, eclipse is not able to recognize the transformed jars so it shows many compile errors. I spent a lot of time today trying to find a good solution to no avail. It seems IntelliJ has the same issue. > > As a workaround, I can select "Maven > Disable Workspace Resolution" on the struts2-core, struts2-tiles-plugin and struts2-sitemesg-plugin. Clearly this is a bad permanent solution. > > Perhaps someone reading this has encountered a similar situation before and they can improve on my work here and make it work seamlessly for everyone. Seamless is the key especially for an open source project! > > One final note, Struts uses Sitemesh2 which is stuck forever it seems on "javax.". There is a Sitemesh3 that supports "Jakarta." but it seems the migration would be non-trivial. > > [1] https://github.com/eclipse/transformer/tree/main/maven-plugins/transformer-maven-plugin can you give this link a look and see if it fixes the problem? https://blog.payara.fish/how-to-use-the-eclipse-transformer-project-to-convert-a-3rd-party-library looks like we should be able to use the transformer, and then put that artifact into local maven repo for build to pick up. Issue Time Tracking --- Worklog Id: (was: 890590) Time Spent: 2h 20m (was: 2h 10m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 2h 20m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890589=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890589 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 14/Nov/23 23:13 Start Date: 14/Nov/23 23:13 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1811540288 Thank you @sepe81 for the review. I think I have fixed all the formatting errors you pointed out. Issue Time Tracking --- Worklog Id: (was: 890589) Time Spent: 2h 10m (was: 2h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 2h 10m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890588=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890588 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 14/Nov/23 22:54 Start Date: 14/Nov/23 22:54 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1811521489 I think I have solved the problems with Freemarker and Sitemesh by using the eclipse transformer maven plugin [1]. To make it work, I added two new projects that transform the jars to Jakarta EE 9+ compliant versions. Downstream projects then depend on these new projects. As far as I can tell, this works a lot like the shade plugin. Unfortunately, eclipse is not able to recognize the transformed jars so it shows many compile errors. I spent a lot of time today trying to find a good solution to no avail. It seems IntelliJ has the same issue. As a workaround, I can select "Maven > Disable Workspace Resolution" on the struts2-core, struts2-tiles-plugin and struts2-sitemesg-plugin. Clearly this is a bad permanent solution. Perhaps someone reading this has encountered a similar situation before and they can improve on my work here and make it work seamlessly for everyone. Seamless is the key especially for an open source project! One final note, Struts uses Sitemesh2 which is stuck forever it seems on "javax.". There is a Sitemesh3 that supports "Jakarta." but it seems the migration would be non-trivial. - [1] https://github.com/eclipse/transformer/tree/main/maven-plugins/transformer-maven-plugin Issue Time Tracking --- Worklog Id: (was: 890588) Time Spent: 2h (was: 1h 50m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 2h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[
https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890355=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890355
]
ASF GitHub Bot logged work on WW-5141:
--
Author: ASF GitHub Bot
Created on: 13/Nov/23 21:40
Start Date: 13/Nov/23 21:40
Worklog Time Spent: 10m
Work Description: sepe81 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1391731445
##
plugins/velocity/pom.xml:
##
@@ -54,7 +54,7 @@
mockobjects-core
test
-
+
Review Comment:
```suggestion
```
revert change
##
apps/showcase/pom.xml:
##
@@ -99,8 +94,8 @@
-javax.servlet
-javax.servlet-api
+jakarta.servlet
+ jakarta.servlet-api
Review Comment:
```suggestion
jakarta.servlet-api
```
##
pom.xml:
##
@@ -792,50 +748,56 @@
-javax.servlet
-javax.servlet-api
-3.1.0
+jakarta.servlet
+ jakarta.servlet-api
+ 6.0.0
provided
-org.glassfish
-javax.el
-3.0.1-b12
+ org.glassfish
+ jakarta.el
+ 5.0.0-M1
-taglibs
-standard
-1.1.2
+org.glassfish.web
+jakarta.servlet.jsp.jstl
+3.0.1
test
-javax.servlet
-jstl
-1.2
+jakarta.servlet.jsp.jstl
+
jakarta.servlet.jsp.jstl-api
+3.0.0
test
+
+
+jakarta.el
+jakarta.el-api
+5.0.0
+
org.apache.tomcat
tomcat-jasper
-8.5.53
+10.1.15
provided
org.apache.tomcat
tomcat-api
-8.5.53
+10.1.15
provided
-javax.servlet.jsp
-jsp-api
-2.1
+jakarta.servlet.jsp
+
jakarta.servlet.jsp-api
+ 3.1.0
Review Comment:
```suggestion
3.1.0
```
##
pom.xml:
##
@@ -946,38 +908,12 @@
spring-web
${spring.platformVersion}
-
-
+
Review Comment:
revert line
##
pom.xml:
##
@@ -792,50 +748,56 @@
-javax.servlet
-javax.servlet-api
-3.1.0
+jakarta.servlet
+ jakarta.servlet-api
+ 6.0.0
provided
-org.glassfish
-javax.el
-3.0.1-b12
+ org.glassfish
+ jakarta.el
+ 5.0.0-M1
-taglibs
-standard
-1.1.2
+org.glassfish.web
+jakarta.servlet.jsp.jstl
+3.0.1
test
-javax.servlet
-jstl
-1.2
+jakarta.servlet.jsp.jstl
+
jakarta.servlet.jsp.jstl-api
+3.0.0
test
+
+
+jakarta.el
+jakarta.el-api
+5.0.0
+
org.apache.tomcat
tomcat-jasper
-8.5.53
+10.1.15
provided
org.apache.tomcat
tomcat-api
-8.5.53
+10.1.15
provided
-javax.servlet.jsp
-jsp-api
-2.1
+jakarta.servlet.jsp
+
jakarta.servlet.jsp-api
Review Comment:
```suggestion
jakarta.servlet.jsp-api
```
tabs2spaces
##
bundles/pom.xml:
##
@@ -51,9 +51,9 @@
-
-javax.servlet
-
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890336=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890336 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 13/Nov/23 19:25 Start Date: 13/Nov/23 19:25 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1808880263 Thank you @tyme-dev I merged your changes. Issue Time Tracking --- Worklog Id: (was: 890336) Time Spent: 1h 40m (was: 1.5h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 1h 40m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890134=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890134 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 12/Nov/23 19:29 Start Date: 12/Nov/23 19:29 Worklog Time Spent: 10m Work Description: tyme-dev commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1807217384 @jdyer1 I've went ahead and got Commons-Upload tests working and converted over to Fileupload2-jakarta. since your pr is the reference one, I've went ahead and did a pull request on your branch in order to get it over here. Only a few things were trip-ups : - fileupload doesn't seem to be reporting actual size of files if they are larger than size limit, so i had to change error messages. - setting threshold for writing file to disk, using -1 no longer seems to work, neither does 0. Got it working with a threshold of 1 though. - had to reorder exception instance check since FileSize exceptions have changed which exception classes they inherit Issue Time Tracking --- Worklog Id: (was: 890134) Time Spent: 1.5h (was: 1h 20m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 1.5h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=890106=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-890106 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 12/Nov/23 10:07 Start Date: 12/Nov/23 10:07 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1807078997 Astonish work and feel free to remove the `EmbeddedJSP` and `OVal` plugins. Issue Time Tracking --- Worklog Id: (was: 890106) Time Spent: 1h 20m (was: 1h 10m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 1h 20m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=889326=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-889326 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 07/Nov/23 19:00 Start Date: 07/Nov/23 19:00 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1799585096 I added several new commits to my fork. Now all code compiles and all unit tests pass, with these 5 new caveats. 1. I ignored freemarker tests (REVERT these commits) - 8d465c66a871cb5f7df4781c556f7d71e2932af1 - 1c43fd1dc77f0478823c668bca8a0a31f7e9dd6b - 908d06483906c50d448795cf99547da9f91a9ef8 2. I ignored Commons-Upload tests (REVERT these commits) - e4fa6e40ef99190a82e071900e937886e7f1a381 - f0df35f2e4d3fd1939f58a425729640a4d612ce9 3. I ignored "embedded jsp plugin" test. Possibly remove this deprecated plugin? Or, fix and REVERT this commit. - 7f12f15d92177b5776255aee2e315e5cc55e9ffc 4. I Removed deprcated OVAL plugin. Dependency "net.sf.oval" depends on javax.persistence, no "jakarta" compatible release available. 5. The "Struts 2 Showcase Webapp" integration test does not work. I do not know how to fix it, but it seems the web server is not starting. Probably "Struts 2 Rest Showcase Webapp" has the same issue. - I think these are the next TODO's: 1. Fix common-uploads to work with newer version 2. Figure out what to do about freemarker/sitemesh (perhaps use eclipse transformer? https://github.com/eclipse/transformer) 3. Fix tests for "embedded jsp plugin" or remove this deprecated plugin 4. Fix the "Struts 2 Showcase Webapp" integration tests If anyone can give input as to if you feel this is the right track, I would appreciate it. I will continue to work on some of these things as my time allows. It would be wonderful to also see some activity from seasoned Struts developers! I think having a Jakarta EE 9+ version of Struts to be important as we all need to eventually migrate our applications to stay on supported runtimes. Issue Time Tracking --- Worklog Id: (was: 889326) Time Spent: 1h 10m (was: 1h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 1h 10m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=888239=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-888239 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 01/Nov/23 10:03 Start Date: 01/Nov/23 10:03 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1788701274 @jdyer1 I will prepare the branch in a few days, and then we can consider how to merge/rebase changes from the master branch. @eschulma we will have to release some RC versions first to allow other plugins (like jQuery or Bootstrap) to follow Issue Time Tracking --- Worklog Id: (was: 888239) Time Spent: 1h (was: 50m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 1h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=888143=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-888143 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 31/Oct/23 20:20 Start Date: 31/Oct/23 20:20 Worklog Time Spent: 10m Work Description: eschulma commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1787974120 @jdyer1 when the time comes I am happy to help test the struts-bootstrap plugin Issue Time Tracking --- Worklog Id: (was: 888143) Time Spent: 50m (was: 40m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 50m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=888118=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-888118 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 31/Oct/23 16:35 Start Date: 31/Oct/23 16:35 Worklog Time Spent: 10m Work Description: jdyer1 commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1787578604 @lukaszlenart I have been checking that thread, and look forward to an official start to 7.x soon! My worry here is this is a very big PR and I do not know how you will want to incorporate any of this into the official branch. I agree JDK 17 is a good idea. @eschulma I am not sure about the struts-bootstrap plugin. Like everything else, someone needs to validate everything before a release is cut to be sure we aren't leaving things broken. To that end, the next task on this line of work I think is to get the tests to compile and run. I was stuck on the old servlet api mocks from "com.mockobjects" I was hoping that the Spring mocks would be a drop-in replacement, but many of the tests use methods that are only on "com.mockobjects". I couldn't find source code for that library, so it was difficult to know what those methods do. Issue Time Tracking --- Worklog Id: (was: 888118) Time Spent: 40m (was: 0.5h) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 40m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=888100=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-888100 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 31/Oct/23 15:00 Start Date: 31/Oct/23 15:00 Worklog Time Spent: 10m Work Description: eschulma commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1787394970 I would like to see JDK 17 rather than 11. Thank you for working on this! Will the struts-bootsrap plugin still work? Hopefully yes. Issue Time Tracking --- Worklog Id: (was: 888100) Time Spent: 0.5h (was: 20m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 0.5h > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=887998=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887998 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 31/Oct/23 05:59 Start Date: 31/Oct/23 05:59 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1786501114 Also I plan to use JDK17 as base version for Struts 7.x Issue Time Tracking --- Worklog Id: (was: 887998) Time Spent: 20m (was: 10m) > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 20m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (WW-5141) Support for JEE 9+
[ https://issues.apache.org/jira/browse/WW-5141?focusedWorklogId=887997=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-887997 ] ASF GitHub Bot logged work on WW-5141: -- Author: ASF GitHub Bot Created on: 31/Oct/23 05:58 Start Date: 31/Oct/23 05:58 Worklog Time Spent: 10m Work Description: lukaszlenart commented on PR #778: URL: https://github.com/apache/struts/pull/778#issuecomment-1786500506 This is astonishing work Thanks for taking time and looking into it it. I was planning to prepare a dedicated branch to start working on the Struts 7.x, see this [thread](https://lists.apache.org/thread/lt6pfhzmv1jojd8f1q5mcnzp7d00wcdf) in the dev@ mailing list. And the very first step would be dropping all the deprecated plugins to simplify work. Issue Time Tracking --- Worklog Id: (was: 887997) Remaining Estimate: 0h Time Spent: 10m > Support for JEE 9+ > --- > > Key: WW-5141 > URL: https://issues.apache.org/jira/browse/WW-5141 > Project: Struts 2 > Issue Type: New Feature > Components: Core >Reporter: Daniel Le Berre >Priority: Major > Fix For: 7.0.0 > > Attachments: pom.xml > > Time Spent: 10m > Remaining Estimate: 0h > > JEE 9 breaks the JEE API by replacing javax domain by jakarta. > Tomcat 10 implements some specifications of JEE 9. > Struts 2.5 has some dependencies with the javax servlet API. > Struts would require some changes to run on Tomcat 10+. > Is there any plan to support JEE 9+ in the future? > -- This message was sent by Atlassian Jira (v8.20.10#820010)
