[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[ https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360639#comment-14360639 ] Hitesh Shah commented on TEZ-2189: -- +1. Test failure is unrelated. > Tez UI live AM tracking url only works for localhost addresses > -- > > Key: TEZ-2189 > URL: https://issues.apache.org/jira/browse/TEZ-2189 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch, > TEZ-2189.4.patch, TEZ-2189.5.patch, TEZ-2189.6.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[
https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360598#comment-14360598
]
Hadoop QA commented on TEZ-2189:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12704452/TEZ-2189.6.patch
against master revision 55d7fce.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.client.TestTezClient
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/299//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/299//console
This message is automatically generated.
> Tez UI live AM tracking url only works for localhost addresses
> --
>
> Key: TEZ-2189
> URL: https://issues.apache.org/jira/browse/TEZ-2189
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch,
> TEZ-2189.4.patch, TEZ-2189.5.patch, TEZ-2189.6.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[
https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360295#comment-14360295
]
Hitesh Shah commented on TEZ-2189:
--
Minor nit:
{code}
if (!historyUrl.isEmpty() && !historyUrl.startsWith("http://";)) {
{code}
- above doesn't handle https
- we should either just check startsWith "http" instead of "http://"; or
convert to URI, check for presence/absence of a scheme before prefixing http as
a default?
Future jira:
- AM webapp tracking url does not account for running with https enabled. We
hardcode the tracking url to use http.
> Tez UI live AM tracking url only works for localhost addresses
> --
>
> Key: TEZ-2189
> URL: https://issues.apache.org/jira/browse/TEZ-2189
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch,
> TEZ-2189.4.patch, TEZ-2189.5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[ https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359885#comment-14359885 ] Jonathan Eagles commented on TEZ-2189: -- [~hitesh], [~pramachandran] any other comments on version 5 of this patch? > Tez UI live AM tracking url only works for localhost addresses > -- > > Key: TEZ-2189 > URL: https://issues.apache.org/jira/browse/TEZ-2189 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch, > TEZ-2189.4.patch, TEZ-2189.5.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[
https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359659#comment-14359659
]
Hadoop QA commented on TEZ-2189:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12704286/TEZ-2189.5.patch
against master revision 55d7fce.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/291//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/291//console
This message is automatically generated.
> Tez UI live AM tracking url only works for localhost addresses
> --
>
> Key: TEZ-2189
> URL: https://issues.apache.org/jira/browse/TEZ-2189
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch,
> TEZ-2189.4.patch, TEZ-2189.5.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[
https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359576#comment-14359576
]
Hadoop QA commented on TEZ-2189:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12704280/TEZ-2189.4.patch
against master revision 63e985d.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.dag.app.rm.TestTaskSchedulerEventHandler
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/290//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/290//console
This message is automatically generated.
> Tez UI live AM tracking url only works for localhost addresses
> --
>
> Key: TEZ-2189
> URL: https://issues.apache.org/jira/browse/TEZ-2189
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch,
> TEZ-2189.4.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[
https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359097#comment-14359097
]
Hitesh Shah commented on TEZ-2189:
--
Even in that case, shouldn't we be using:
{code}
trackingUrl = "http://"; + bindAddress.getAddress().getCanonicalHostName() + ":"
+ bindAddress.getPort();
{code}
instead of
{code}
trackingUrl = "http://"; + bindAddress.getHostName() + ":" +
bindAddress.getPort();
{code}
> Tez UI live AM tracking url only works for localhost addresses
> --
>
> Key: TEZ-2189
> URL: https://issues.apache.org/jira/browse/TEZ-2189
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[ https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358984#comment-14358984 ] Prakash Ramachandran commented on TEZ-2189: --- [~hitesh] the issue is not with getCanonicalHostName. WebApp allows to bind to a particular ip address, however by default it binds to 0.0.0.0. this means the address.getAddress().getCanonicalHostName(); will try to reverse resolve 0.0.0.0 and will not be able to. hence the tracking url will be set to http://0.0.0.0:. > Tez UI live AM tracking url only works for localhost addresses > -- > > Key: TEZ-2189 > URL: https://issues.apache.org/jira/browse/TEZ-2189 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[ https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358880#comment-14358880 ] Hitesh Shah commented on TEZ-2189: -- Also, [~jeagles], I have used this functionality earlier on a multi-node setup and http://docs.oracle.com/javase/7/docs/api/java/net/InetAddress.html#getCanonicalHostName() seemed to work fine. Could you clarify what was the error that you were seeing? > Tez UI live AM tracking url only works for localhost addresses > -- > > Key: TEZ-2189 > URL: https://issues.apache.org/jira/browse/TEZ-2189 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[ https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358845#comment-14358845 ] Jonathan Eagles commented on TEZ-2189: -- I'll do a little more testing based to verify this is correct. Will update in a few hours. > Tez UI live AM tracking url only works for localhost addresses > -- > > Key: TEZ-2189 > URL: https://issues.apache.org/jira/browse/TEZ-2189 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[
https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358066#comment-14358066
]
Jonathan Eagles commented on TEZ-2189:
--
Yes. According to the documentation, a static address could be substituted (i.e
localhost, or fakehost-> ip mapping) or on clusters whose use_ip setting is
true, an ip address will be returned.
{quote}
/**
* Create a socket address with the given host and port. The hostname
* might be replaced with another host that was set via
* {@link #addStaticResolution(String, String)}. The value of
* hadoop.security.token.service.use_ip will determine whether the
* standard java host resolver is used, or if the fully qualified resolver
* is used.
{quote}
> Tez UI live AM tracking url only works for localhost addresses
> --
>
> Key: TEZ-2189
> URL: https://issues.apache.org/jira/browse/TEZ-2189
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[ https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357801#comment-14357801 ] Hitesh Shah commented on TEZ-2189: -- bq. Is this sufficient for our scenario? I believe so but just wanted to check whether there is any situation in which "bindAddress.getHostName()" will return a different value from that of "appContext.getNMHost()"? > Tez UI live AM tracking url only works for localhost addresses > -- > > Key: TEZ-2189 > URL: https://issues.apache.org/jira/browse/TEZ-2189 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[ https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357657#comment-14357657 ] Jonathan Eagles commented on TEZ-2189: -- [~hitesh], I have based my code on MRClientService:serviceStart which is performing that same function as what we are doing here. https://github.com/apache/hadoop/blob/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/client/MRClientService.java#L134 Is this sufficient for our scenario? > Tez UI live AM tracking url only works for localhost addresses > -- > > Key: TEZ-2189 > URL: https://issues.apache.org/jira/browse/TEZ-2189 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[
https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357572#comment-14357572
]
Hitesh Shah commented on TEZ-2189:
--
[~jeagles] With respect to:
{code}
trackingUrl = "http://"; + bindAddress.getHostName() + ":" +
bindAddress.getPort();
{code}
Should the above be using getNMHost() and not the bind address hostname? Not
sure if that can change underneath.
> Tez UI live AM tracking url only works for localhost addresses
> --
>
> Key: TEZ-2189
> URL: https://issues.apache.org/jira/browse/TEZ-2189
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[
https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357514#comment-14357514
]
Hadoop QA commented on TEZ-2189:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12704002/TEZ-2189.3.patch
against master revision 59529ab.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.dag.app.rm.TestTaskSchedulerEventHandler
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/280//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/280//console
This message is automatically generated.
> Tez UI live AM tracking url only works for localhost addresses
> --
>
> Key: TEZ-2189
> URL: https://issues.apache.org/jira/browse/TEZ-2189
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch, TEZ-2189.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[ https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356952#comment-14356952 ] Prakash Ramachandran commented on TEZ-2189: --- hi [~jeagles] the patch looks fine. just wanted to verify - the getAppNMHost seems to be derived from NM_HOST, is this always the FQDN/ip address? cant find any docs on what the NM_HOST has (short hostname vs FQDN). > Tez UI live AM tracking url only works for localhost addresses > -- > > Key: TEZ-2189 > URL: https://issues.apache.org/jira/browse/TEZ-2189 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-2189.1.patch, TEZ-2189.2.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[ https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355586#comment-14355586 ] Jonathan Eagles commented on TEZ-2189: -- Actually, you can ignore my comment above. > Tez UI live AM tracking url only works for localhost addresses > -- > > Key: TEZ-2189 > URL: https://issues.apache.org/jira/browse/TEZ-2189 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-2189.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[
https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355573#comment-14355573
]
Jonathan Eagles commented on TEZ-2189:
--
Here is the logic from TimelineClientImpl.java we should duplicate
{code}
if (YarnConfiguration.useHttps(conf)) {
resURI = URI
.create(JOINER.join("https://";, conf.get(
YarnConfiguration.TIMELINE_SERVICE_WEBAPP_HTTPS_ADDRESS,
YarnConfiguration.DEFAULT_TIMELINE_SERVICE_WEBAPP_HTTPS_ADDRESS),
RESOURCE_URI_STR));
} else {
resURI = URI.create(JOINER.join("http://";, conf.get(
YarnConfiguration.TIMELINE_SERVICE_WEBAPP_ADDRESS,
YarnConfiguration.DEFAULT_TIMELINE_SERVICE_WEBAPP_ADDRESS),
RESOURCE_URI_STR));
{code}
> Tez UI live AM tracking url only works for localhost addresses
> --
>
> Key: TEZ-2189
> URL: https://issues.apache.org/jira/browse/TEZ-2189
> Project: Apache Tez
> Issue Type: Bug
> Components: UI
>Reporter: Jonathan Eagles
>Assignee: Jonathan Eagles
> Attachments: TEZ-2189.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2189) Tez UI live AM tracking url only works for localhost addresses
[ https://issues.apache.org/jira/browse/TEZ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355421#comment-14355421 ] Hitesh Shah commented on TEZ-2189: -- [~jeagles] I think there may need to be add a check whether historyUrl has already been configured with "http" within it. Currently, most of the testing I have done, I have configured historyUrl with http in it and it seems to work fine. > Tez UI live AM tracking url only works for localhost addresses > -- > > Key: TEZ-2189 > URL: https://issues.apache.org/jira/browse/TEZ-2189 > Project: Apache Tez > Issue Type: Bug > Components: UI >Reporter: Jonathan Eagles >Assignee: Jonathan Eagles > Attachments: TEZ-2189.1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
