[jira] [Commented] (TEZ-2591) Remove unneeded methods from EdgeManagerPludinOnDemand
[ https://issues.apache.org/jira/browse/TEZ-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619058#comment-14619058 ] Bikas Saha commented on TEZ-2591: - Legacy routing is legacy for all intents and purposes. [~hitesh] Can you please comment on the cleanup? > Remove unneeded methods from EdgeManagerPludinOnDemand > -- > > Key: TEZ-2591 > URL: https://issues.apache.org/jira/browse/TEZ-2591 > Project: Apache Tez > Issue Type: Bug >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2591.1.patch, TEZ-2591.2.patch, TEZ-2591.3.patch > > > EdgeManagerPluginOnDemand inherits from EdgeManager (legacy) due to some > common methods. Removing this dependency would be cleaner for the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2591) Remove unneeded methods from EdgeManagerPludinOnDemand
[ https://issues.apache.org/jira/browse/TEZ-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618507#comment-14618507 ] Rajesh Balamohan commented on TEZ-2591: --- lgtm from patch perspective. Only concern is - Patch pushes legacy API to EdgeManagerPlugin, but also removes the routing logic from existing code as a part of cleanup/separation. In case (for any reason) the legacy routing needs to be looked at, this calls for new implementation. Would be good to get other folk's pov as well. > Remove unneeded methods from EdgeManagerPludinOnDemand > -- > > Key: TEZ-2591 > URL: https://issues.apache.org/jira/browse/TEZ-2591 > Project: Apache Tez > Issue Type: Bug >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2591.1.patch, TEZ-2591.2.patch, TEZ-2591.3.patch > > > EdgeManagerPluginOnDemand inherits from EdgeManager (legacy) due to some > common methods. Removing this dependency would be cleaner for the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2591) Remove unneeded methods from EdgeManagerPludinOnDemand
[ https://issues.apache.org/jira/browse/TEZ-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617771#comment-14617771 ] Bikas Saha commented on TEZ-2591: - The base class has all common methods that are shared. The routing methods have been isolated into their specific routing impls. EdgeManagerPlugin has the legacy API's for routing. EdgeManagerOnDemand has the on-demand API's. Any new routing policy will create its own routing API's and inherit the common (non-routing) API's from the base class. Does that make sense? > Remove unneeded methods from EdgeManagerPludinOnDemand > -- > > Key: TEZ-2591 > URL: https://issues.apache.org/jira/browse/TEZ-2591 > Project: Apache Tez > Issue Type: Bug >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2591.1.patch, TEZ-2591.2.patch, TEZ-2591.3.patch > > > EdgeManagerPluginOnDemand inherits from EdgeManager (legacy) due to some > common methods. Removing this dependency would be cleaner for the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2591) Remove unneeded methods from EdgeManagerPludinOnDemand
[ https://issues.apache.org/jira/browse/TEZ-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617646#comment-14617646 ] Rajesh Balamohan commented on TEZ-2591: --- Earlier it was handling both cases (i.e routing model & onDemand). Now EdgeManagerPluginBase becomes the base which is extended by EdgeManagerPlugin and EdgeManagerPluginOnDemand. However, almost all impls except OneToOneEdgeManager are based on EdgeManagerPluginOnDemand. Would this be a problem for other jiras? (e.g TEZ-2255). For example, do we need to have separate set of impls for EdgeManagerPlugin based approach? > Remove unneeded methods from EdgeManagerPludinOnDemand > -- > > Key: TEZ-2591 > URL: https://issues.apache.org/jira/browse/TEZ-2591 > Project: Apache Tez > Issue Type: Bug >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2591.1.patch, TEZ-2591.2.patch, TEZ-2591.3.patch > > > EdgeManagerPluginOnDemand inherits from EdgeManager (legacy) due to some > common methods. Removing this dependency would be cleaner for the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2591) Remove unneeded methods from EdgeManagerPludinOnDemand
[
https://issues.apache.org/jira/browse/TEZ-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616127#comment-14616127
]
TezQA commented on TEZ-2591:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12743857/TEZ-2591.3.patch
against master revision cb59851.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/886//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/886//console
This message is automatically generated.
> Remove unneeded methods from EdgeManagerPludinOnDemand
> --
>
> Key: TEZ-2591
> URL: https://issues.apache.org/jira/browse/TEZ-2591
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Bikas Saha
>Assignee: Bikas Saha
> Attachments: TEZ-2591.1.patch, TEZ-2591.2.patch, TEZ-2591.3.patch
>
>
> EdgeManagerPluginOnDemand inherits from EdgeManager (legacy) due to some
> common methods. Removing this dependency would be cleaner for the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2591) Remove unneeded methods from EdgeManagerPludinOnDemand
[
https://issues.apache.org/jira/browse/TEZ-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615907#comment-14615907
]
TezQA commented on TEZ-2591:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12743817/TEZ-2591.2.patch
against master revision cb59851.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in :
org.apache.tez.dag.library.vertexmanager.TestShuffleVertexManager
Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/885//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/885//console
This message is automatically generated.
> Remove unneeded methods from EdgeManagerPludinOnDemand
> --
>
> Key: TEZ-2591
> URL: https://issues.apache.org/jira/browse/TEZ-2591
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Bikas Saha
>Assignee: Bikas Saha
> Attachments: TEZ-2591.1.patch, TEZ-2591.2.patch
>
>
> EdgeManagerPluginOnDemand inherits from EdgeManager (legacy) due to some
> common methods. Removing this dependency would be cleaner for the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TEZ-2591) Remove unneeded methods from EdgeManagerPludinOnDemand
[ https://issues.apache.org/jira/browse/TEZ-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615785#comment-14615785 ] Bikas Saha commented on TEZ-2591: - Refreshed patch. [~hitesh] [~rajesh.balamohan] [~pramachandran] Please review. I tested compatibility by replacing tez-runtime-library jar in tez-full.tar.gz with tez-runtime-library jar build from master. then I ran a local sortmergejoin example with auto-reduce triggered. This would use custom edge manager built from master with dag/edge built with TEZ-2591 changes. Everything passed. > Remove unneeded methods from EdgeManagerPludinOnDemand > -- > > Key: TEZ-2591 > URL: https://issues.apache.org/jira/browse/TEZ-2591 > Project: Apache Tez > Issue Type: Bug >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2591.1.patch, TEZ-2591.2.patch > > > EdgeManagerPluginOnDemand inherits from EdgeManager (legacy) due to some > common methods. Removing this dependency would be cleaner for the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2591) Remove unneeded methods from EdgeManagerPludinOnDemand
[ https://issues.apache.org/jira/browse/TEZ-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611533#comment-14611533 ] Rajesh Balamohan commented on TEZ-2591: --- [~bikassaha] EdgeManagerPluginBase.java missed out in earlier patch? > Remove unneeded methods from EdgeManagerPludinOnDemand > -- > > Key: TEZ-2591 > URL: https://issues.apache.org/jira/browse/TEZ-2591 > Project: Apache Tez > Issue Type: Bug >Reporter: Bikas Saha >Assignee: Bikas Saha > Attachments: TEZ-2591.1.patch > > > EdgeManagerPluginOnDemand inherits from EdgeManager (legacy) due to some > common methods. Removing this dependency would be cleaner for the code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TEZ-2591) Remove unneeded methods from EdgeManagerPludinOnDemand
[
https://issues.apache.org/jira/browse/TEZ-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611485#comment-14611485
]
TezQA commented on TEZ-2591:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12743236/TEZ-2591.1.patch
against master revision 2073351.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified test files.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/873//console
This message is automatically generated.
> Remove unneeded methods from EdgeManagerPludinOnDemand
> --
>
> Key: TEZ-2591
> URL: https://issues.apache.org/jira/browse/TEZ-2591
> Project: Apache Tez
> Issue Type: Bug
>Reporter: Bikas Saha
>Assignee: Bikas Saha
> Attachments: TEZ-2591.1.patch
>
>
> EdgeManagerPluginOnDemand inherits from EdgeManager (legacy) due to some
> common methods. Removing this dependency would be cleaner for the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
