[jira] [Commented] (TEZ-3313) ATSFileParser : Wrong args passed in VersionInfo

2016-07-03 Thread Tsuyoshi Ozawa (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360817#comment-15360817
 ] 

Tsuyoshi Ozawa commented on TEZ-3313:
-

+1(non-binding), 

We can implement TEZ-3319 after this issue.

> ATSFileParser : Wrong args passed in VersionInfo
> 
>
> Key: TEZ-3313
> URL: https://issues.apache.org/jira/browse/TEZ-3313
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Rajesh Balamohan
>Assignee: Rajesh Balamohan
>Priority: Minor
> Attachments: TEZ-3313.1.patch, TEZ-3313.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-3313) ATSFileParser : Wrong args passed in VersionInfo

2016-07-03 Thread TezQA (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360719#comment-15360719
 ] 

TezQA commented on TEZ-3313:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12815967/TEZ-3313.2.patch
  against master revision d7b6eb5.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 3.0.1) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/1828//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1828//console

This message is automatically generated.

> ATSFileParser : Wrong args passed in VersionInfo
> 
>
> Key: TEZ-3313
> URL: https://issues.apache.org/jira/browse/TEZ-3313
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Rajesh Balamohan
>Priority: Minor
> Attachments: TEZ-3313.1.patch, TEZ-3313.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-3313) ATSFileParser : Wrong args passed in VersionInfo

2016-07-03 Thread Rajesh Balamohan (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15360702#comment-15360702
 ] 

Rajesh Balamohan commented on TEZ-3313:
---

[~ozawa] - Thanks for the review. 

1. What's the difference between revision and version? We should write it down 
on docs.
>> version would be something like "version=0.7.0" and revision would be the 
>> git_commit_id "revision=46301d87cd9aaffaee17a6a14c51e97cd9e9313d".

2. Why not making the order of arguments for constructors same as 
org.apache.tez.common.VersionInfo? (String version, String revision, String 
buildTime) looks to be better since it's more consistent with 
org.apache.tez.common.VersionInfo.
>> Agreed, that can be done. Btw, reusing common.VersionInfo would call for 
>> relaxing the constructor to public in org.apache.tez.common.VersionInfo. 
>> When tez parser was created, it was created as an independent module and not 
>> make any changes in existing tez. Hence, POJO was created as it is just an 
>> internal representation.



> ATSFileParser : Wrong args passed in VersionInfo
> 
>
> Key: TEZ-3313
> URL: https://issues.apache.org/jira/browse/TEZ-3313
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Rajesh Balamohan
>Priority: Minor
> Attachments: TEZ-3313.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-3313) ATSFileParser : Wrong args passed in VersionInfo

2016-06-27 Thread Tsuyoshi Ozawa (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352204#comment-15352204
 ] 

Tsuyoshi Ozawa commented on TEZ-3313:
-

Thanks [~rajesh.balamohan] for your contribution.

I have 2 comments:

1. What's the difference between revision and version? We should write it down 
on docs.
2. Why not making the order of arguments for constructors same as 
org.apache.tez.common.VersionInfo?  (String version, String revision, String 
buildTime) looks to be better since it's more consistent with 
org.apache.tez.common.VersionInfo.

Thoughts?




> ATSFileParser : Wrong args passed in VersionInfo
> 
>
> Key: TEZ-3313
> URL: https://issues.apache.org/jira/browse/TEZ-3313
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Rajesh Balamohan
>Priority: Minor
> Attachments: TEZ-3313.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TEZ-3313) ATSFileParser : Wrong args passed in VersionInfo

2016-06-27 Thread TezQA (JIRA) 

[ 
https://issues.apache.org/jira/browse/TEZ-3313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352176#comment-15352176
 ] 

TezQA commented on TEZ-3313:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12813987/TEZ-3313.1.patch
  against master revision d2b9222.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 3.0.1) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-TEZ-Build/1817//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1817//console

This message is automatically generated.

> ATSFileParser : Wrong args passed in VersionInfo
> 
>
> Key: TEZ-3313
> URL: https://issues.apache.org/jira/browse/TEZ-3313
> Project: Apache Tez
>  Issue Type: Bug
>Reporter: Rajesh Balamohan
>Priority: Minor
> Attachments: TEZ-3313.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)