Build failed in Jenkins: incubator-trafficcontrol-PR-rat #785

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1502
originally caused by:
 GitHub pull request #2212 of commit d22b8586a5580694f27ea3fff945b91fe6cb4f18, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H26 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins2759929865551694750.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins4020664628337606873.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ awk -F '"' '{print $2}'
++ grep -ve md5 -e sha1
++ head -n 1
++ sort -r
++ cut -d / -f 12
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.Uvvt00o4Y2
+ ratjar=/tmp/tmp.Uvvt00o4Y2/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.Uvvt00o4Y2/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
1587k  100 1587k0 0  1541k  0  0:00:01  0:00:01 --:--:-- 1542k
+ curl -L -o /tmp/tmp.Uvvt00o4Y2/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
   40  100400 0 75  0 --:--:-- --:--:-- --:--:--75
++ sha1sum /tmp/tmp.Uvvt00o4Y2/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.Uvvt00o4Y2/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.Uvvt00o4Y2/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.Uvvt00o4Y2
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=56
+ [[ 56 != 0 ]]
+ echo '56 Unknown Licenses'
56 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes_test.go
  

[GitHub] asfgit commented on issue #2212: revendor all dependencies under traffic_ops to remove package duplication bug

[GitBox]

asfgit commented on issue #2212: revendor all dependencies under traffic_ops to 
remove package duplication bug
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2212#issuecomment-385860385
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1502/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DylanVolz commented on issue #2212: revendor all dependencies under traffic_ops to remove package duplication bug

[GitBox]

DylanVolz commented on issue #2212: revendor all dependencies under traffic_ops 
to remove package duplication bug
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2212#issuecomment-385859213
 
 
   Note: jmoirion/sqlx is tied to commit: 
[d9bd385d68c068f1fabb5057e3dedcbcbb039d0f](https://github.com/jmoiron/sqlx/commit/d9bd385d68c068f1fabb5057e3dedcbcbb039d0f)
   and
   lib/pq is tied to commit: 
[dd1fe2071026ce53f36a39112e645b4d4f5793a4](https://github.com/lib/pq/commit/dd1fe2071026ce53f36a39112e645b4d4f5793a4)
   using govendor to allow all libraries to build until we upgrade our go env.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DylanVolz opened a new pull request #2212: revendor all dependencies under traffic_ops to remove package duplication bug

[GitBox]

DylanVolz opened a new pull request #2212: revendor all dependencies under 
traffic_ops to remove package duplication bug
URL: https://github.com/apache/incubator-trafficcontrol/pull/2212
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2102: Add TO all 1.2 CDNs routes, remove perl

[GitBox]

asfgit commented on issue #2102: Add TO all 1.2 CDNs routes, remove perl
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2102#issuecomment-385836234
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1501/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #784

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1500
originally caused by:
 GitHub pull request #2149 of commit 52f46362166145d83f9d77bb88c9cd6fd7ca2fe1, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H29 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins7740815204014311882.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins8395866057150236868.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ grep -ve md5 -e sha1
++ awk -F '"' '{print $2}'
++ sort -r
++ head -n 1
++ cut -d / -f 12
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.LKQi4lPmpe
+ ratjar=/tmp/tmp.LKQi4lPmpe/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.LKQi4lPmpe/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
3 1587k3 487680 0  73376  0  0:00:22 --:--:--  0:00:22 73335100 
1587k  100 1587k0 0  1587k  0 --:--:-- --:--:-- --:--:-- 1587k
+ curl -L -o /tmp/tmp.LKQi4lPmpe/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
010040  100400 0 76  0 --:--:-- --:--:-- --:--:--76
++ sha1sum /tmp/tmp.LKQi4lPmpe/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.LKQi4lPmpe/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.LKQi4lPmpe/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.LKQi4lPmpe
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=2
+ [[ 2 != 0 ]]
+ echo '2 Unknown Licenses'
2 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/infrastructure/cdn-in-a-box/traffic_portal/server.crt
  
apache-trafficcontrol-2.3.0-incubating/infrastructure/cdn-in-a-box/traffic_portal/server.key

*
+ exit 1
Build step 'Execute shell' marked build as failure
Archiving 

Build failed in Jenkins: incubator-trafficcontrol-rat #695

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-master-build" build 
number 739
originally caused by:
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
 Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H30 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-rat] $ /bin/bash -xe 
/tmp/jenkins4780103424271412641.sh
+ rm -rf ' 
'
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-master-build
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-master-build:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-rat] $ /bin/bash -xe 
/tmp/jenkins1671552422978961135.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ awk -F '"' '{print $2}'
++ grep -ve md5 -e sha1
++ cut -d / -f 12
++ sort -r
++ head -n 1
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.y3SU5vTnev
+ ratjar=/tmp/tmp.y3SU5vTnev/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.y3SU5vTnev/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
1587k  100 1587k0 0  1708k  0 --:--:-- --:--:-- --:--:-- 1708k
+ curl -L -o /tmp/tmp.y3SU5vTnev/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0100 
   40  100400 0 73  0 --:--:-- --:--:-- --:--:--73
++ sha1sum /tmp/tmp.y3SU5vTnev/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.y3SU5vTnev/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.y3SU5vTnev/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.y3SU5vTnev
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=56
+ [[ 56 != 0 ]]
+ echo '56 Unknown Licenses'
56 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  

[GitHub] asfgit commented on issue #2149: TO and TODB in docker front-to-back

[GitBox]

asfgit commented on issue #2149: TO and TODB in docker front-to-back
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2149#issuecomment-385824443
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1500/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #783

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1499
originally caused by:
 GitHub pull request #2124 of commit 30f6ded312e421c93663685679fb5bb608cc3da2, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H29 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins1847833376778406984.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins7871887735420426016.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ grep -ve md5 -e sha1
++ sort -r
++ head -n 1
++ awk -F '"' '{print $2}'
++ cut -d / -f 12
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.Sjl8jcXF39
+ ratjar=/tmp/tmp.Sjl8jcXF39/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.Sjl8jcXF39/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
3 1587k3 487680 0  70772  0  0:00:22 --:--:--  0:00:22 70780100 
1587k  100 1587k0 0  1529k  0  0:00:01  0:00:01 --:--:-- 1530k
+ curl -L -o /tmp/tmp.Sjl8jcXF39/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
010040  100400 0 75  0 --:--:-- --:--:-- --:--:--75
++ sha1sum /tmp/tmp.Sjl8jcXF39/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.Sjl8jcXF39/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.Sjl8jcXF39/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.Sjl8jcXF39
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=133
+ [[ 133 != 0 ]]
+ echo '133 Unknown Licenses'
133 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes_test.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/formatters_suite_test.go
  

[GitHub] rob05c opened a new pull request #2211: Fix TO Go CRConfig endpoints to wrap response obj

[GitBox]

rob05c opened a new pull request #2211: Fix TO Go CRConfig endpoints to wrap 
response obj
URL: https://github.com/apache/incubator-trafficcontrol/pull/2211
 
 
   Fixes #2210


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2124: Add TO Go deliveryservices routes

[GitBox]

asfgit commented on issue #2124: Add TO Go deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-385812789
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1499/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-PR-rat #782

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-PR" build number 1498
originally caused by:
 GitHub pull request #2124 of commit 731b4de96f8b9b6bd859b1f98afe3dbc132a0565, 
no merge conflicts.
[EnvInject] - Loading node environment variables.
Building remotely on H21 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins7014488682041187708.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-PR:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-PR-rat] $ /bin/bash -xe 
/tmp/jenkins8795323261011301630.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ grep jar
++ grep -ve md5 -e sha1
++ cut -d / -f 12
++ sort -r
++ head -n 1
++ awk -F '"' '{print $2}'
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.Xm9UpjTls1
+ ratjar=/tmp/tmp.Xm9UpjTls1/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.Xm9UpjTls1/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0 68 
1587k   68 1080k0 0  1038k  0  0:00:01  0:00:01 --:--:-- 1038k100 
1587k  100 1587k0 0  1516k  0  0:00:01  0:00:01 --:--:-- 1516k
+ curl -L -o /tmp/tmp.Xm9UpjTls1/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
010040  100400 0 72  0 --:--:-- --:--:-- --:--:--72
++ sha1sum /tmp/tmp.Xm9UpjTls1/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.Xm9UpjTls1/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.Xm9UpjTls1/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.Xm9UpjTls1
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=56
+ [[ 56 != 0 ]]
+ echo '56 Unknown Licenses'
56 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes_test.go
  

[GitHub] dangogh opened a new issue #2210: TO go - snapshot/new differences between Perl and Go implementations

[GitBox]

dangogh opened a new issue #2210: TO go - snapshot/new differences between Perl 
and Go implementations
URL: https://github.com/apache/incubator-trafficcontrol/issues/2210
 
 
   Comparing the `/api/1.3/cdns/xxx/snapshot/new` endpoints between the Perl 
and Go versions revealed some differences.   The most obvious was that the Perl 
version has a top-level "response" object and the Go version does not:
   
   ```{ "response": ... }```
   
   I saw other differences,  but none seemed to be structural.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh opened a new pull request #2209: TO test - add snapshot to compare tool

[GitBox]

dangogh opened a new pull request #2209: TO test - add snapshot to compare tool
URL: https://github.com/apache/incubator-trafficcontrol/pull/2209
 
 
   1. adds comparison of snapshot and snapshot/new for each CDN
   2. adds .../about to compared routes


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on issue #2176: When creating a mid header rewrite using traffic portal the "location" parameter isn't created

[GitBox]

mitchell852 commented on issue #2176: When creating a mid header rewrite using 
traffic portal the "location" parameter isn't created
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2176#issuecomment-385804396
 
 
   Looking at this file:
   
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L344-L372
   
   It looks like 6 config files could be dynamically created based on the 
existence of certain values of a delivery service:
   
   1. url_sig_*.config
   2. uri_signing_*.config
   3. cacheurl*.config
   4. hdr_rw_*.config
   5. regex_remap_*.config
   6. set_dscp_*.config
   
   therefore each of these files will need a location parameter so ORT knows 
where to put the config file.
   
   This is the bug. When setting edge header rewrite or mid header rewrite 
values on a deliveryservice through the API (or thru TP)
   
   POST /api/deliveryservices
   PUT /api/deliveryservices/:id
   
   apparently the required location parameter is not being created as such:
   
   name=location, 
   value=/opt/trafficserver/etc/trafficserver
   config_file=hdr_rw_xml-id.config
   
   which causes ORT to fail as it has no idea where to put the hdr_rw_*.config 
file.
   
   When fixing this bug, check that a location parameter is also being created 
for the other 4 files.
   

   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on issue #2176: When creating a mid header rewrite using traffic portal the "location" parameter isn't created

[GitBox]

mitchell852 commented on issue #2176: When creating a mid header rewrite using 
traffic portal the "location" parameter isn't created
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2176#issuecomment-385804396
 
 
   Looking at this file:
   
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L344-L372
   
   It looks like 6 config files could be dynamically created based on the 
existence of certain values of a delivery service:
   
   1. url_sig_*.config
   2. uri_signing_*.config
   3. cacheurl*.config
   4. hdr_rw_*.config
   5. regex_remap_*.config
   6. set_dscp_*.config
   
   therefore each of these files will need a location parameter so ORT knows 
where to put the config file.
   
   This is the bug. When setting edge header rewrite or mid header rewrite 
values on a deliveryservice through the API
   
   POST /api/deliveryservices
   PUT /api/deliveryservices/:id
   
   apparently the required location parameter is not being created as such:
   
   name=location, 
   value=/opt/trafficserver/etc/trafficserver
   config_file=hdr_rw_xml-id.config
   
   which causes ORT to fail as it has no idea where to put the hdr_rw_*.config 
file.
   
   When fixing this bug, check that a location parameter is also being created 
for the other 4 files.
   

   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c closed issue #2206: Add Grove logrotate to RPM

[GitBox]

rob05c closed issue #2206: Add Grove logrotate to RPM
URL: https://github.com/apache/incubator-trafficcontrol/issues/2206
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2206: Add Grove logrotate to RPM

[GitBox]

rob05c commented on issue #2206: Add Grove logrotate to RPM
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2206#issuecomment-385802914
 
 
   Fixed in https://github.com/apache/incubator-trafficcontrol/pull/2208


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c closed pull request #2208: Add Grove logrotate rules to rpm.

[GitBox]

rob05c closed pull request #2208: Add Grove logrotate rules to rpm.  
URL: https://github.com/apache/incubator-trafficcontrol/pull/2208
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/grove/build/build_rpm.sh b/grove/build/build_rpm.sh
index f6111009f..e22e2352a 100755
--- a/grove/build/build_rpm.sh
+++ b/grove/build/build_rpm.sh
@@ -25,7 +25,7 @@ echo "$BUILDDIR" > ~/.rpmmacros
 go build -v -ldflags "-X main.Version=$VERSION"
 
 # tar
-tar -cvzf $BUILDDIR/SOURCES/grove-${VERSION}.tgz grove conf/grove.cfg 
build/grove.init
+tar -cvzf $BUILDDIR/SOURCES/grove-${VERSION}.tgz grove conf/grove.cfg 
build/grove.init build/grove.logrotate
 
 # build RPM
 rpmbuild --define "version ${VERSION}" -ba build/grove.spec
diff --git a/grove/build/grove.spec b/grove/build/grove.spec
index ec3389d15..abe34d2ee 100644
--- a/grove/build/grove.spec
+++ b/grove/build/grove.spec
@@ -48,6 +48,9 @@ mkdir -p -m 777 %{buildroot}/var/log/%{name}
 mkdir -p -m 777 %{buildroot}/etc/init.d/
 cp -p  build/%{name}.init %{buildroot}/etc/init.d/%{name}
 
+mkdir -p -m 777 %{buildroot}/etc/logrotate.d/
+cp -p build/%{name}.logrotate %{buildroot}/etc/logrotate.d/%{name}
+
 %clean
 echo "cleaning"
 rm -r -f %{buildroot}
@@ -56,4 +59,5 @@ rm -r -f %{buildroot}
 /usr/sbin/%{name}
 /var/log/%{name}
 %config(noreplace) /etc/%{name}
+%config(noreplace) /etc/logrotate.d/%{name}
 /etc/init.d/%{name}
diff --git a/grove/grove.cfg b/grove/grove.cfg
index e9ca358ed..3f0a3fedb 100644
--- a/grove/grove.cfg
+++ b/grove/grove.cfg
@@ -3,4 +3,7 @@
   "port": 8080,
   "cache_size_bytes": 5,
   "remap_rules_file": "./remap.json"
+  "log_location_error": "/var/log/grove/grove.log",
+  "log_location_event": "/var/log/grove/access.log",
+  "log_location_warn": "/var/log/grove/grove.log"
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jrushford opened a new pull request #2208: Add Grove logrotate rules to rpm.

[GitBox]

jrushford opened a new pull request #2208: Add Grove logrotate rules to rpm.  
URL: https://github.com/apache/incubator-trafficcontrol/pull/2208
 
 
   This PR updates the grove.spec file and the build_rpm.sh so that an rpm 
install will add the grove log rotation rules to log rotate.  Also updates the 
grove.cfg to define loggers that match the log rotation rules.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2102: Add TO all 1.2 CDNs routes, remove perl

[GitBox]

rob05c commented on a change in pull request #2102: Add TO all 1.2 CDNs routes, 
remove perl
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2102#discussion_r180471719
 
 

 ##
 File path: traffic_ops/traffic_ops_golang/cdn/cdns.go
 ##
 @@ -368,3 +371,109 @@ func deleteQuery() string {
 WHERE id=:id`
return query
 }
+
+func DeleteNameHandler(db *sql.DB) http.HandlerFunc {
 
 Review comment:
   @DylanVolz How opposed are you to this? So, I started trying to use the 
abstraction stuff, and it had a pretty steep learning curve. It looked like it 
would have to be nontrivially extended to support named deletes, too (Or maybe 
I just didn't understand it well enough).
   
   This was a lot easier to write, using helper funcs instead of abstraction, 
interfaces, reflection, etc. It'll be a lot easier to extend too, I think.
   
   With the helper funcs, it's 55 lines, versus 40 for the Delete func. We 
could probably make a few more helper funcs, too (maybe one to get all the 
commonly-needed objects, context, handleErrs, user, etc in one line).
   
   How would you feel about going forward with this style, with helper funcs 
instead of interfaces & reflection? I know it's a little more duplication, but 
IMO it'd be a lot easier for new people to get in and start working on the 
codebase. I think it'd be easier for us to extend when necessary too.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new issue #2207: Add Etag support

[GitBox]

rob05c opened a new issue #2207: Add Etag support
URL: https://github.com/apache/incubator-trafficcontrol/issues/2207
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2206: Add logrotate to RPM

[GitBox]

rob05c commented on issue #2206: Add logrotate to RPM
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2206#issuecomment-385798770
 
 
   @jrushford 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new issue #2205: Document plugins_shared Remap Key

[GitBox]

rob05c opened a new issue #2205: Document plugins_shared Remap Key
URL: https://github.com/apache/incubator-trafficcontrol/issues/2205
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2204: Document plugin using both global and local config data

[GitBox]

rob05c commented on issue #2204: Document plugin using both global and local 
config data
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2204#issuecomment-385798206
 
 
   This is effectively implemented, since the startup hook gets the global 
config. So, plugins that want to use both can create a startup hook, and put 
the global config it gets in the Context for use by other hooks.
   
   That behavior should be documented though, so I'm leaving this open until 
docs exist explaining that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new issue #2204: Document plugin using both global and local config data

[GitBox]

rob05c opened a new issue #2204: Document plugin using both global and local 
config data
URL: https://github.com/apache/incubator-trafficcontrol/issues/2204
 
 
   Currently, the plugin system works like other remap config fields, the 
config for a rule is used if it exists, or from the outside object if not.
   
   Plugins should be changed to be passed both.
   
   While most plugins probably want to work the same way rules work, for some 
plugins it may make sense to apply both, or even to prioritize the global.
   
   An example of this is ModHeaders. The header modification plugins should 
apply both, so it's possible to specify headers to be added to all remaps, as 
well as headers only added to specific remaps, without the specific having to 
duplicate the global. This is the reason a duplicate modify_headers_global 
plugin exists, and fixing this will obviate the need for that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new issue #2203: Add ModHdr "add" Field

[GitBox]

rob05c opened a new issue #2203: Add ModHdr "add" Field
URL: https://github.com/apache/incubator-trafficcontrol/issues/2203
 
 
   Currently the ModHdr plugins can set, but not add. There's a distinction, 
setting overrides existing values. It should be possible to add.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new issue #2202: Add Range Request handling

[GitBox]

rob05c opened a new issue #2202: Add Range Request handling
URL: https://github.com/apache/incubator-trafficcontrol/issues/2202
 
 
   Currently, Range headers are ignored. (Though dropping range headers via a 
plugin is trivial.)
   
   Grove should respect Range requests, ideally:
   
   * make Range requests upstream to the parent/origin
   * store only the received range, indicating the range of the stored bytes in 
the CacheObj
   * merge successive ranges for the same object
   * when a request comes in for the entire object, request only the un-held 
bytes (considering whether held bytes are Fresh, response Last-Modified, etc)
   * only loading the requested bytes from the cache (this probably doesn't 
matter for memory, but does for disk, especially for massive objects requested 
via successive small range requests [for example, by storing objects in the 
cache in chunks])
   
   This ideal doesn't have to be implemented all at once. For example, a first 
step would be returning the requested range; but requesting, storing, loading, 
etc the full object as normal.
   
   See https://tools.ietf.org/html/rfc7233


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new issue #2201: Add Integration Tests

[GitBox]

rob05c opened a new issue #2201: Add Integration Tests
URL: https://github.com/apache/incubator-trafficcontrol/issues/2201
 
 
   We should add integration tests for Grove.
   
   Most of the code arguably can't be usefully unit tested, but integration 
tests are very valuable, to verify HTTP requests to the app respond as expected.
   
   Specifically, we should add tests which start the app with a given config, 
and then verify that curls return the expected responses.
   
   This probably requires an integration test framework, which doesn't 
currently exist.
   
   I recommend Docker. Create a Dockerfile for the Grove app, then a simple 
Bash script can drop test files on a container in the same Docker Network and 
run them against it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new issue #2200: Add Grove MoneyTrace Manipulation on Miss

[GitBox]

rob05c opened a new issue #2200: Add Grove MoneyTrace Manipulation on Miss
URL: https://github.com/apache/incubator-trafficcontrol/issues/2200
 
 
   Like we do in 
https://docs.trafficserver.apache.org/en/latest/admin-guide/plugins/money_trace.en.html
   
   (issue created by @knutsel )


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2199: Add Grove In-Place Upgrades

[GitBox]

rob05c commented on issue #2199: Add Grove In-Place Upgrades
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2199#issuecomment-385796967
 
 
   Idea: halve the cache size during Upgrade.
   
   So, upgrading looks like:
   
   1. Halve the cache size of the old running app
   2. Bring up the new app, with the same halved cache size
   3, Serialize the old app's cache and load it into the new cache
   4. The new app starts listening on the same socket, and the old app is 
killed.
   5. Once the old app dies, and its memory is free, change the new app's cache 
max size back to the real maximum.
   
   This results in more upstream requests than strictly necessary, but far 
fewer than if the new app had no cache, and had to re-request everything. And 
because it's an LRU, hopefully less than half, hopefully more like 15% more 
requests.
   
   Idea: Combine Memory Halving with previous Serialize idea.
   
   For example: Serialize the half of the LRU which is being purged on the old 
app, and make the old app use the serialized cache while its memory is halved. 
Likewise, the new app loads its half-size-cache, and also uses a disk cache for 
the other half, until the old app is terminated and the full memory cache size 
is restored, whereupon the new app loads the rest of the serialized disk cache 
into memory.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2199: Add Grove In-Place Upgrades

[GitBox]

rob05c commented on issue #2199: Add Grove In-Place Upgrades
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2199#issuecomment-385796967
 
 
   Idea: halve the cache size during Upgrade.
   
   So, upgrading looks like:
   
   Halve the cache size of the old running app
   Bring up the new app, with the same halved cache size
   Serialize the old app's cache and load it into the new cache
   The new app starts listening on the same socket, and the old app is 
killed.
   Once the old app dies, and its memory is free, change the new app's 
cache max size back to the real maximum.
   
   This results in more upstream requests than strictly necessary, but far 
fewer than if the new app had no cache, and had to re-request everything. And 
because it's an LRU, hopefully less than half, hopefully more like 15% more 
requests.
   
   Idea: Combine Memory Halving with previous Serialize idea.
   
   For example: Serialize the half of the LRU which is being purged on the old 
app, and make the old app use the serialized cache while its memory is halved. 
Likewise, the new app loads its half-size-cache, and also uses a disk cache for 
the other half, until the old app is terminated and the full memory cache size 
is restored, whereupon the new app loads the rest of the serialized disk cache 
into memory.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on issue #2199: Add Grove In-Place Upgrades

[GitBox]

rob05c commented on issue #2199: Add Grove In-Place Upgrades
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2199#issuecomment-385796896
 
 
   Idea: serialize the cache to a file, using pointers to quickly lock and copy.
   
   So, the cache under the hood is a standard Go map.
   
   The map must be locked while copying. Copying the actual values takes a long 
time, but simply copying the pointers should be fast enough to globally lock 
while we do it.
   
   Currently, Cache Objects aren't changed, they're inserted, and if they're 
modified, a copy is made. This is probably necessary anyway, since concurrent 
requests for the same object may modify concurrently.
   
   As long as we guarantee CacheObj objects in the map are immutable, we can 
copy the pointers quickly, then serialize the actual objects to a file, which 
takes much longer, in a separate thread.
   
   Then, the upgraded binary can start, read the serialized cache to fill its 
own in memory.
   
   The problem with this, is that the cache can then only be half the size of 
memory, since we'll be briefly holding two copies of it.
   
   We really need a way to reuse the same memory, or to move objects out of the 
old and into the new one-at-a-time, while at the same time, making new requests 
for objects go to the right cache.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new issue #2199: Add Grove In-Place Upgrades

[GitBox]

rob05c opened a new issue #2199: Add Grove In-Place Upgrades
URL: https://github.com/apache/incubator-trafficcontrol/issues/2199
 
 
   In-place upgrades would be a great feature, to continue serving clients, and 
keep the same cache, without dropping connections or cached content.
   
   The two biggest requirements of this are setting the socket option on the 
serving port to allow multiple processes to bind (SO_REUSEPORT), and somehow 
transferring the cache.
   
   To reuse the port, the socket option could be manually set, or via a library 
like https://github.com/kavu/go_reuseport . We'll also probably need a script 
to read the log from the new binary, and once it indicates it's accepting 
connections, then terminate the old.
   
   To transfer the cache, there are several methods we could use. We could look 
into operating system shared memory. That's likely to be faster, but painful in 
Go, figuring out how to map allocated shared memory to a Go object, or 
alternatively using Cgo and writing the object in C. We could also create a way 
to signal the running cache to serialize to disk, and make the new binary 
populate its cache from the serialized file before startup.
   
   This isn't a high priority at the moment, this case mostly exists to 
document the idea right now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new issue #2198: Add Grove Generic Traffic Ops Config Endpoint

[GitBox]

rob05c opened a new issue #2198: Add Grove Generic Traffic Ops Config Endpoint
URL: https://github.com/apache/incubator-trafficcontrol/issues/2198
 
 
   Currently, the Grove config generator (grovetccfg) uses generic API 
endpoints, which have far more data than it needs, and are far slower than 
necessary. A new endpoint in traffic_ops_golang getting only the data needed to 
configure the cache will be significantly faster, and use significantly less 
bandwidth.
   
   Generic endpoints are slow and use unnecessary bandwidth, which makes 
Delivery Service updates more expensive and slower.
   
   This should be part of making Traffic Control more cache-agonstic, and this 
endpoint should be extended to include everything necessary to configure both 
ATS and Grove


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2124: Add TO Go deliveryservices routes

[GitBox]

asfgit commented on issue #2124: Add TO Go deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-385796440
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1498/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jhg03a commented on issue #2176: When creating a mid header rewrite using traffic portal the "location" parameter isn't created

[GitBox]

jhg03a commented on issue #2176: When creating a mid header rewrite using 
traffic portal the "location" parameter isn't created
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2176#issuecomment-385796166
 
 
   This also effects the edge header rewrite rule field as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c opened a new issue #2197: Test Grove Memory Cache Performance

[GitBox]

rob05c opened a new issue #2197: Test Grove Memory Cache Performance
URL: https://github.com/apache/incubator-trafficcontrol/issues/2197
 
 
   Grove hasn't been performance tested, since the memory cache swapped out 
hashicorp/lru for its own.
   
   There's no reason to believe the new LRU is slow, but it's a fundamental 
change in the request pipeline. Grove should be performance tested again, with 
clonetraffic multiplying production traffic x10 to x20, to verify it can still 
saturate a 20gig NIC.
   
   Labelling bug, because it's not really a bug or feature, and bug will get 
the attention it deserves.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-rat #694

[Apache Jenkins Server]

See 


--
Started by upstream project "incubator-trafficcontrol-master-build" build 
number 738
originally caused by:
 Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H24 (ubuntu xenial) in workspace 

[incubator-trafficcontrol-rat] $ /bin/bash -xe 
/tmp/jenkins8488574094089123416.sh
+ rm -rf 

 

 '
[operations-center-context] Requesting copy of artifacts matching '**/*.tar.gz' 
from 'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-master-build
[operations-center-context] Copied 1 artifacts matching '**/*.tar.gz' from 
'Last successful build (either stable or unstable)' of 
incubator-trafficcontrol-master-build:
[operations-center-context]   apache-trafficcontrol-2.3.0-incubating.tar.gz
[incubator-trafficcontrol-rat] $ /bin/bash -xe 
/tmp/jenkins5243411274073674689.sh
+ set -exu
++ ls apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tarball=apache-trafficcontrol-2.3.0-incubating.tar.gz
+ tar xzf apache-trafficcontrol-2.3.0-incubating.tar.gz
++ pwd
++ basename apache-trafficcontrol-2.3.0-incubating.tar.gz .tar.gz
+ 
tcdir=
+ cd 

++ date +%Y
+ egrep 'Copyright .*-?2018 The Apache Software Foundation' NOTICE
Copyright 2016-2018 The Apache Software Foundation
+ set +x
Searching for class files:
PASSED: No class files found.
Searching for jar files:
PASSED: No jar files found.
Searching for tar files:
PASSED: No tar files found.
Searching for tgz files:
PASSED: No tgz files found.
Searching for zip files:
PASSED: No zip files found.
++ curl 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/
 -sN
++ awk -F '"' '{print $2}'
++ grep jar
++ sort -r
++ grep -ve md5 -e sha1
++ head -n 1
++ cut -d / -f 12
+ ratver=apache-rat-0.13-20180329.151017-101.jar
++ mktemp -d
+ ratdir=/tmp/tmp.kUlF0Gslze
+ ratjar=/tmp/tmp.kUlF0Gslze/apache-rat-0.13.SNAPSHOT.jar
+ curl -L -o /tmp/tmp.kUlF0Gslze/apache-rat-0.13.SNAPSHOT.jar 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 0  
0 1587k0 156660 0  25306  0  0:01:04 --:--:--  0:01:04 25308100 
1587k  100 1587k0 0  1534k  0  0:00:01  0:00:01 --:--:-- 1535k
+ curl -L -o /tmp/tmp.kUlF0Gslze/apache-rat-0.13.SNAPSHOT.jar.sha1 
https://repository.apache.org/content/repositories/snapshots/org/apache/rat/apache-rat/0.13-SNAPSHOT/apache-rat-0.13-20180329.151017-101.jar.sha1
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
  0 00 00 0  0  0 --:--:-- --:--:-- --:--:-- 
010040  100400 0 78  0 --:--:-- --:--:-- --:--:--78
++ sha1sum /tmp/tmp.kUlF0Gslze/apache-rat-0.13.SNAPSHOT.jar
++ awk '{print $1}'
++ cat /tmp/tmp.kUlF0Gslze/apache-rat-0.13.SNAPSHOT.jar.sha1
+ [[ 635c5eccad31cff1d713c12144eaae7fc9f10cf4 == 
635c5eccad31cff1d713c12144eaae7fc9f10cf4 ]]
++ pwd
++ pwd
+ java -jar /tmp/tmp.kUlF0Gslze/apache-rat-0.13.SNAPSHOT.jar -E 

 -d 

+ rm -rf /tmp/tmp.kUlF0Gslze
++ perl -lne 'print $1 if /(\d+) Unknown Licenses/' ratreport.txt
+ unknown=56
+ [[ 56 != 0 ]]
+ echo '56 Unknown Licenses'
56 Unknown Licenses
+ perl -lne 'print if /Files with unapproved licenses:/ .. /^\*\*\*/' 
ratreport.txt
+ sed s:::
Files with unapproved licenses:

  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/bytes_test.go
  
apache-trafficcontrol-2.3.0-incubating/grove/vendor/code.cloudfoundry.org/bytefmt/formatters_suite_test.go
  

[GitHub] rob05c commented on issue #2124: Add TO Go deliveryservices routes

[GitBox]

rob05c commented on issue #2124: Add TO Go deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-385772835
 
 
   @dangogh Fixed the merge conflicts, vendored miekg/dns


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh commented on issue #2124: Add TO Go deliveryservices routes

[GitBox]

dangogh commented on issue #2124: Add TO Go deliveryservices routes
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2124#issuecomment-385760163
 
 
   just checking this out to help with crconfig testing -- routes.go has 
conflicts on rebasing,  but got this after fixing that:
   ```
   deliveryservice/dnssec.go:34:2: cannot find package "github.com/miekg/dns" 
in any of:

/home/dkirkw202/go/src/github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/vendor/github.com/miekg/dns
 (vendor tree)
   ```
   so,  looks like you're missing a dependency in vendor/...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on issue #2196: Links in TP help hover text are unclickable

[GitBox]

mitchell852 commented on issue #2196: Links in TP help hover text are 
unclickable
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2196#issuecomment-385759954
 
 
   Just leaving a note for later
   
   on the deliveryservice form, each field has a label that you can hover over 
to get a tooltip to describe the field. The label and tooltip description are 
defined in traffic_portal_properties.json
   
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_portal/app/src/traffic_portal_properties.json#L177
   
   Currently, the tooltip show/hides on mouseover/out which is a problem if the 
description contains a link as the mouseout event fires (closing the tooltip) 
before you can click the link
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jhg03a opened a new issue #2196: Links in TP help hover text are unclickable

[GitBox]

jhg03a opened a new issue #2196: Links in TP help hover text are unclickable
URL: https://github.com/apache/incubator-trafficcontrol/issues/2196
 
 
   In traffic portal when you move the mouse from the help hovertext to the 
link, the hovertext box automatically closes.  The hovertext help I was testing 
with was in a delivery service.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2108: create roles crud endpoints in golang

[GitBox]

asfgit commented on issue #2108: create roles crud endpoints in golang
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2108#issuecomment-385758333
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1497/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #596

[Apache Jenkins Server]

See 


Changes:

[jvd] Grove Initial commit

[jvd] Grove Add initial caching handler Grove Grove Adds initial HTTP Cache

[jvd] Grove WIP Add origin request limiting Grove Grove This adds origin

[jvd] Grove Add rule(origin) concurrent req limiter and config

[jvd] Grove Add Readme instructions

[jvd] Grove Add cfg to ignore request no-cache Grove Grove This violates RFC

[jvd] Grove Fix fetching getters after the last

[jvd] Grove Add remap rule query string handling config

[jvd] Grove Add HTTPS

[jvd] Grove Add stats endpoint and collection interface

[jvd] Grove Add stats for remap rule in and out bytes

[jvd] Grove Add stats for statuses

[jvd] Grove Add per rule request limits

[jvd] Grove Add per rule IP allow and deny

[jvd] Grove Add LRU string keys

[jvd] Grove Add cache handler pointer indirect Grove Grove This is designed to

[jvd] Grove Add sighup config reloading

[jvd] Grove Add connection close config

[jvd] Grove Add per-rule connection close config

[jvd] Grove Add HTTP/2 support

[jvd] Grove Add logging via Traffic Control common/log

[jvd] Grove Fix connmap functions to pointers Grove Grove Must be pointers, so

[jvd] Grove Fix removing connmap dropped conns.

[jvd] Grove Change remap printf to string concat Grove Grove From profiling:

[jvd] Grove Add profile func, change null log to nil for speed

[jvd] Grove Add test origin

[jvd] Grove Add Revalidate

[jvd] Grove Add Consistent Hashing Grove Grove Adds Consistent Hashing for

[jvd] Grove Add ProxyURL, add config generator tool

[jvd] Grove Fix swapped for vars, add rule loading messages

[jvd] Grove Fix request headers not being set on cache object

[jvd] Grove Fix proxy hashing, retry limit

[jvd] Grove Fix cfg gen scheme, port

[jvd] Grove Add config generator new API Grove Grove Adds funcs to use the new

[jvd] Grove Fix slow hash insert, cfg gen parent CDN filter

[jvd] Grove Fix parent hash strings not matching ATS

[jvd] Grove Vendor dchest/siphash

[jvd] Grove Change parent hash to use dhash/siphash

[jvd] Grove Fix debug log msg type

[jvd] Grove Fix debug log msg type

[jvd] Grove Add request timeout configs, transport reuse

[jvd] Grove Fix broken merge

[jvd] Grove Add pprof flag

[jvd] Grove Remove unused files

[jvd] Grove Change even log to EventRaw for speed

[jvd] Grove Fix astats ats nesting Grove Grove Also changes string

[jvd] Grove Fix astats proc.net.dev

[jvd] Grove Fix astats proc.loadavg trailing \n

[jvd] Grove Fix astats remap stats to match ATS

[jvd] Grove Fix Astats inf.speed to be a number

[jvd] Grove Add stats for connection count

[jvd] Grove Rename config parent request options to be obvious

[jvd] Grove Fix parent errors to log to error log

[jvd] Grove Add Server configurable read,write,idle timeouts Grove Grove This

[jvd] Grove Fix ProxyURL for empty proxy strings

[jvd] Grove Fix rules issue with serving stale content

[jvd] Grove Change pkg structure to make app main pkg Grove Grove The main

[jvd] Grove Add service, RPM

[jvd] Grove Vendor LRU

[jvd] Grove Vendor golang.org/x/sys/unix

[jvd] Grove Fix RPM, Service path issues

[jvd] Grove Add grovetccfg service, RPM

[jvd] Grove Fix grovetccfg import

[jvd] Grove Remove grovetccfg service

[jvd] Grove Add per--delivery service certificates

[jvd] Grove Add tccfg getting certs

[jvd] Grove Fix listener InterceptConn bytes Grove Grove Fixes the ConnMap to

[jvd] Grove Fix event logging not not matching exactly ATS

[jvd] Grove Remove duplicate event log

[jvd] Grove Fix duplicate stat and log code

[jvd] Grove Fix statAndLog to permit a null remapper

[jvd] Grove Fix grovetccfg to base64decode certs

[jvd] Grove Fix InterceptListen for multiple certs Grove Grove Also fixes to

[jvd] Grove Change statAndLog to struct

[jvd] Grove Rename TryServe to Serve

[jvd] Grove Add web.CopyHeaderTo

[jvd] Grove Remove commented code

[jvd] Grove Move retryingGet to a struct

[jvd] Grove Updated readme

[jvd] Grove Add grovetccfg readme

[jvd] Grove Remove commented code

[jvd] Grove Remove unused To parent_selection, fix log imports

[jvd] Grove Remove unused grovetccfg To parent_selection

[jvd] Grove Fix grovetccfg IP allow to set stats only

[jvd] Grove Add stats endpoint IP allow

[jvd] Grove Commented grovetccfg new API code

[jvd] Grove Change grovetccfg retry codes to []

[jvd] Grove Add grovetccfg setting DSCP in rules, from DSes

[jvd] Grove Add Grove setting DSCP from Remap Rules

[jvd] Grove Add RPM Version, auto-incrementing from git

[jvd] Grove Fix rules reversed strictRFC, missing fresh heur. Grove Grove

[jvd] Grove Add rules tests for strictRFC and no-cache reqs

[jvd] Grove Add rules min-fresh, proxy-revalidate

[jvd] Grove Add rules tests

[jvd] Grove Fix rules defaultCacheable codes Grove Grove Also adds tests for

[jvd] Grove Fix grovetccfg for TC API Changes Grove Grove Also comments the

[jvd] Grove Add grovetccfg build 

[GitHub] dangogh opened a new pull request #2195: change go download location -- other seems to be failing intermittently

[GitBox]

dangogh opened a new pull request #2195: change go download location -- other 
seems to be failing intermittently
URL: https://github.com/apache/incubator-trafficcontrol/pull/2195
 
 
   (cherry picked from commit eb927a448a55b8d944c5832eece121ee57c4a29c)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c closed pull request #2194: change go download location -- other seems to be failing intermittently

[GitBox]

rob05c closed pull request #2194: change go download location -- other seems to 
be failing intermittently
URL: https://github.com/apache/incubator-trafficcontrol/pull/2194
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/install/bin/install_go.sh 
b/traffic_ops/install/bin/install_go.sh
index 313547f47..d141bef8a 100755
--- a/traffic_ops/install/bin/install_go.sh
+++ b/traffic_ops/install/bin/install_go.sh
@@ -14,7 +14,7 @@
 # limitations under the License.
 #
 
-GO_DOWNLOADS_URL=https://storage.googleapis.com/golang
+GO_DOWNLOADS_URL=https://dl.google.com/go
 GO_TARBALL_VERSION=go1.8.3.linux-amd64.tar.gz
 GO_TARBALL_URL=$GO_DOWNLOADS_URL/$GO_TARBALL_VERSION
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dangogh opened a new pull request #2194: change go download location -- other seems to be failing intermittently

[GitBox]

dangogh opened a new pull request #2194: change go download location -- other 
seems to be failing intermittently
URL: https://github.com/apache/incubator-trafficcontrol/pull/2194
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 closed issue #2035: TO API - Provide ability to associate roles w/ capabilities

[GitBox]

mitchell852 closed issue #2035: TO API - Provide ability to associate roles w/ 
capabilities
URL: https://github.com/apache/incubator-trafficcontrol/issues/2035
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mitchell852 commented on issue #2035: TO API - Provide ability to associate roles w/ capabilities

[GitBox]

mitchell852 commented on issue #2035: TO API - Provide ability to associate 
roles w/ capabilities
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2035#issuecomment-385706578
 
 
   I'm going to close this because this functionality is captured with #2033 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] limited opened a new issue #2193: VOD delivery services are cached in RAM on Live-Only servers

[GitBox]

limited opened a new issue #2193: VOD delivery services are cached in RAM on 
Live-Only servers
URL: https://github.com/apache/incubator-trafficcontrol/issues/2193
 
 
   For "Live only" server profiles (profiles w/o a Drive_Letter_Prefix), VOD 
Delivery Services can be assigned. These delivery services are silently 
(without warning the user) cached in RAM, rather than disk as would be 
expected. 
   
   I would expect Traffic Ops validation to warn users or block this 
configuration when:
   a) A VOD DS is assigned to a server profile without a disk storage volume 
or 
   b) The parameters defining a disk storage volume are deleted from a profile. 
   
   
   @PeterRyder 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #594

[Apache Jenkins Server]

See 


Changes:

[dewrich] revert perl changes from crconfig PR

[dewrich] add back needed parts for go crconfig

--
[...truncated 3.08 MB...]
integration_1  | #  var d = new Date();
integration_1  | #  var hours = d.getUTCHours();
integration_1  | #  var suffix = '';
integration_1  | #  var str = "UTC: " + hours + ":" + 
(d.getMinutes() < 10 ? '0' : '') + d.getMinutes() + ":" + (d.getSeconds() < 10 
? '0' : '') + d.getSeconds() + suffix;
integration_1  | #  $("#utcclock").html(str);
integration_1  | # 
integration_1  | #  if (startsec == -1) 
integration_1  | #  startsec = d.getSeconds();
integration_1  | #  if (d.getSeconds() == startsec ) {
integration_1  | #  $.get("/newlogcount", function(data){
integration_1  | #  if ( (0 + data['newlogcount']) 
> 0 ) {
integration_1  | #  
$("#newlogindicator").html("Change Log (" + data['newlogcount'] + ")");
integration_1  | #  } else {
integration_1  | #  
$("#newlogindicator").html("Change Log");
integration_1  | #  }
integration_1  | #  }, "json");
integration_1  | #  }
integration_1  | #  }, 1000);
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | #  $.extend( true, $.fn.dataTable.defaults, {
integration_1  | #  column: {
integration_1  | #  render: $.fn.dataTable.render.text()
integration_1  | #  }
integration_1  | #  });
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | #  $(function(){
integration_1  | #  // Accordion
integration_1  | #  $("#accordion").accordion({
integration_1  | #  header: "h3",
integration_1  | #  autoHeight: false
integration_1  | #  });
integration_1  | # 
integration_1  | # 
integration_1  | #  // Dialog
integration_1  | #  $('#dialog').dialog({
integration_1  | #  autoOpen: false,
integration_1  | #  width: 600,
integration_1  | #  buttons: {
integration_1  | #  "Ok": function() {
integration_1  | #  $(this).dialog("close");
integration_1  | #  },
integration_1  | #  "Cancel": function() {
integration_1  | #  $(this).dialog("close");
integration_1  | #  }
integration_1  | #  }
integration_1  | #  });
integration_1  | # 
integration_1  | #  // Dialog Link
integration_1  | #  $('#dialog_link').click(function(){
integration_1  | #  $('#dialog').dialog('open');
integration_1  | #  return false;
integration_1  | #  });
integration_1  | # 
integration_1  | #  //hover states on the static widgets
integration_1  | #  $('#dialog_link, ul#icons li').hover(
integration_1  | #  function() { 
$(this).addClass('ui-state-hover'); },
integration_1  | #  function() { 
$(this).removeClass('ui-state-hover'); }
integration_1  | #  );
integration_1  | #  });
integration_1  | # 
integration_1  | # 
integration_1  | #  /*demo page css*/
integration_1  | #  body{ font: 62.5% "Trebuchet MS", sans-serif; 
margin: 10px; }
integration_1  | #  .demoHeaders { margin-top: 2em; }
integration_1  | #  #dialog_link {padding: .4em 1em .4em 
20px;text-decoration: none;position: relative;}
integration_1  | #  #dialog_link span.ui-icon {margin: 0 5px 0 
0;position: absolute;left: .2em;top: 50%;margin-top: -8px;}
integration_1  | #  ul#icons {margin: 0; padding: 0;}
integration_1  | #  ul#icons li {margin: 2px; position: relative; 
padding: 4px 0; cursor: pointer; float: left;  list-style: none;}
integration_1  | #  ul#icons span.ui-icon {float: left; margin: 0 
4px;}
integration_1  | #  a.whitebg:link {color:#369acc;}
integration_1  | #  a.whitebg:visited {color:#369acc;}
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | # 
integration_1  | #   
integration_1  | #   
integration_1  | #   

[GitHub] dewrich closed pull request #2191: revert changes that broke perl unit tests

[GitBox]

dewrich closed pull request #2191: revert changes that broke perl unit tests
URL: https://github.com/apache/incubator-trafficcontrol/pull/2191
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/app/lib/API/Topology.pm 
b/traffic_ops/app/lib/API/Topology.pm
new file mode 100644
index 0..ff72b57dd
--- /dev/null
+++ b/traffic_ops/app/lib/API/Topology.pm
@@ -0,0 +1,103 @@
+package API::Topology;
+#
+##
+## Licensed under the Apache License, Version 2.0 (the "License");
+## you may not use this file except in compliance with the License.
+## You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+##
+##
+##
+#
+## JvD Note: you always want to put Utils as the first use. Sh*t don't work if 
it's after the Mojo lines.
+#
+
+
+use Mojo::Base 'Mojolicious::Controller';
+use JSON;
+use MojoPlugins::Response;
+use UI::Utils;
+use UI::Topology;
+use Data::Dumper;
+
+sub SnapshotCRConfig {
+my $self = shift;
+my $cdn_id = $self->param('id');
+my $cdn_name = $self->param('cdn_name');
+my $cdn;
+
+if ( !_oper($self) ) {
+return $self->forbidden("You must be an ADMIN or OPER to perform this 
operation!");
+}
+
+if ( defined $cdn_id ) {
+$cdn = $self->db->resultset("Cdn")->find( { id => $cdn_id } );
+$cdn_name = $cdn->name if defined $cdn;
+}
+
+if ( !defined $cdn ) {
+$cdn = $self->db->resultset('Cdn')->find( { name => $cdn_name } );
+if ( !defined($cdn) ) {
+return $self->not_found();
+}
+}
+
+my @cdn_names = $self->db->resultset('Server')->search({ 'type.name' => 
'EDGE' }, { prefetch => [ 'cdn', 'type' ], group_by => 'cdn.name' } 
)->get_column('cdn.name')->all();
+my $num = grep /^$cdn_name$/, @cdn_names;
+if ($num <= 0) {
+return $self->alert("CDN_name [" . $cdn_name. "] is not found in edge 
server cdn");
+}
+
+my $json = ::Topology::gen_crconfig_json($self, $cdn_name);
+::Topology::write_crconfig_json_to_db($self, $cdn_name, $json);
+::Utils::log($self, "Snapshot of CRConfig performed for $cdn_name", 
"APICHANGE");
+return $self->success("SUCCESS");
+}
+
+sub get_snapshot {
+my $self= shift;
+my $cdn_name= $self->param('name');
+
+if ( !_oper($self) ) {
+return $self->forbidden();
+}
+
+my $cdn = $self->db->resultset('Cdn')->find( { name => $cdn_name } );
+if ( !defined($cdn) ) {
+return $self->not_found();
+}
+
+my $snapshot = $self->db->resultset('Snapshot')->search( { cdn => 
$cdn_name } )->get_column('content')->single();
+if ( !defined($snapshot) ) {
+return $self->success( {} );
+}
+
+$self->success( decode_json($snapshot) );
+}
+
+sub get_new_snapshot {
+my $self= shift;
+my $cdn_name= $self->param('name');
+
+if ( !_oper($self) ) {
+return $self->forbidden();
+}
+
+my $cdn = $self->db->resultset('Cdn')->find( { name => $cdn_name } );
+if ( !defined($cdn) ) {
+return $self->not_found();
+}
+
+my $json = ::Topology::gen_crconfig_json($self, $cdn_name);
+
+$self->success( $json );
+}
+
+1;
diff --git a/traffic_ops/app/lib/TrafficOpsRoutes.pm 
b/traffic_ops/app/lib/TrafficOpsRoutes.pm
index 81bf55bce..5c944b957 100644
--- a/traffic_ops/app/lib/TrafficOpsRoutes.pm
+++ b/traffic_ops/app/lib/TrafficOpsRoutes.pm
@@ -449,6 +449,13 @@ sub api_routes {
# -- CDNS: ROUTING
$r->get("/api/$version/cdns/routing")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Cdn#routing', namespace => $namespace );
 
+   # -- CDNS: SNAPSHOT
+   $r->get("/api/$version/cdns/:name/snapshot")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#get_snapshot', namespace => $namespace );
+   $r->get("/api/$version/cdns/:name/snapshot/new")->over( authenticated 
=> 1, not_ldap => 1 )->to( 'Topology#get_new_snapshot', namespace => $namespace 
);
+   $r->put( "/api/$version/cdns/:id/snapshot" => [ id => qr/\d+/ ] 
)->over( authenticated => 1, not_ldap => 1 )
+   ->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
+   $r->put("/api/$version/snapshot/:cdn_name")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
+
# -- CDNS: METRICS
#WARNING: this is an intentionally "unauthenticated" route.

[GitHub] rob05c commented on a change in pull request #2191: revert changes that broke perl unit tests

[GitBox]

rob05c commented on a change in pull request #2191: revert changes that broke 
perl unit tests
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2191#discussion_r185237001
 
 

 ##
 File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
 ##
 @@ -449,6 +449,13 @@ sub api_routes {
# -- CDNS: ROUTING
$r->get("/api/$version/cdns/routing")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Cdn#routing', namespace => $namespace );
 
+   # -- CDNS: SNAPSHOT
+   $r->get("/api/$version/cdns/:name/snapshot")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#get_snapshot', namespace => $namespace );
+   $r->get("/api/$version/cdns/:name/snapshot/new")->over( authenticated 
=> 1, not_ldap => 1 )->to( 'Topology#get_new_snapshot', namespace => $namespace 
);
+   $r->put( "/api/$version/cdns/:id/snapshot" => [ id => qr/\d+/ ] 
)->over( authenticated => 1, not_ldap => 1 )
+   ->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
+   $r->put("/api/$version/snapshot/:cdn_name")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
 
 Review comment:
   Alternatively: the Go CRConfig does have unit tests, which verify creating 
and getting it succeeds from database data properly, and that it contains the 
proper data (which again, is more than the Perl tests do). 
   
   If you all are willing to consider the unit tests good enough for now, until 
API Tests exist, we could just remove the Perl test lines right now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: incubator-trafficcontrol-traffic_ops-test #593

[Apache Jenkins Server]

See 


Changes:

[dewrich] return profiles without cdns by using left join

--
[...truncated 1.32 MB...]
unit_1 | Use of uninitialized value in string eq at 
/opt/traffic_ops/app/lib/API/Iso.pm line 278.
unit_1 | /opt/traffic_ops/app/t/api/1.2/iso.t 
. ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/job.t 
. ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/log.t 
. ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/parameter.t 
... ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/physlocation.t 
 ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | DBIx::Class::ResultSet::search_rs(): search( %condition ) is 
deprecated, use search( \%condition ) instead at 
/opt/traffic_ops/app/lib/API/Parameter.pm line 137
unit_1 | /opt/traffic_ops/app/t/api/1.2/profile.t 
. ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/profile_parameter.t 
... ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/region.t 
.. ok
unit_1 | "my" variable $server_id masks earlier declaration in same 
scope at /opt/traffic_ops/app/t/api/1.2/server.t line 656.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | DBIx::Class::Storage::DBI::select_single(): Query returned 
more than one row.  SQL that returns multiple rows is DEPRECATED for ->find and 
->single at /opt/traffic_ops/app/lib/API/Deliveryservice.pm line 933
unit_1 | Use of uninitialized value $offline_reason in concatenation 
(.) or string at /opt/traffic_ops/app/lib/API/Server.pm line 877.
unit_1 | /opt/traffic_ops/app/t/api/1.2/server.t 
.. ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/stats_summary.t 
... ok
unit_1 | Useless use of a constant ("Is the steering target returned?") 
in void context at /opt/traffic_ops/app/t/api/1.2/steering_target.t line 78.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/steering_target.t 
. ok
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | Subroutine TrafficOps::has redefined at 
/opt/traffic_ops/app/local/lib/perl5/Mojo/Base.pm line 38.
unit_1 | /opt/traffic_ops/app/t/api/1.2/tenant.t 
.. ok
unit_1 | "my" variable $is_login_tenant_active masks earlier 
declaration in same scope at 

[GitHub] rob05c commented on a change in pull request #2191: revert changes that broke perl unit tests

[GitBox]

rob05c commented on a change in pull request #2191: revert changes that broke 
perl unit tests
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2191#discussion_r185235867
 
 

 ##
 File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
 ##
 @@ -449,6 +449,13 @@ sub api_routes {
# -- CDNS: ROUTING
$r->get("/api/$version/cdns/routing")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Cdn#routing', namespace => $namespace );
 
+   # -- CDNS: SNAPSHOT
+   $r->get("/api/$version/cdns/:name/snapshot")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#get_snapshot', namespace => $namespace );
+   $r->get("/api/$version/cdns/:name/snapshot/new")->over( authenticated 
=> 1, not_ldap => 1 )->to( 'Topology#get_new_snapshot', namespace => $namespace 
);
+   $r->put( "/api/$version/cdns/:id/snapshot" => [ id => qr/\d+/ ] 
)->over( authenticated => 1, not_ldap => 1 )
+   ->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
+   $r->put("/api/$version/snapshot/:cdn_name")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
 
 Review comment:
   It looks like all those tests are doing is, after doing their own 
cdn/ds/config stuff, is getting or setting the snapshot.
   
   The CRConfig doesn't have API tests, only unit tests, because API Test DSes 
and Servers didn't exist when I wrote it; but they do now.
   
   For the Perl tests, for cdns and deliveryservices, all they're doing is 
trying to snapshot and get the snapshot, after posting their own data. Which, 
the CRConfig API Tests will already do, creating DSes and CDNS and other things 
(and in fact, actually verify the things it created are in the CRConfig, which 
is more than the Perl tests do).
   
   For the config tests, all they're doing is GETs of config files, no POSTs, 
and then getting the CRConfig. So, they're not actually changing data, so 
there's really no reason to verify the CRConfig GET succeeds there, we'll 
already be verifying that in the CRConfig's own tests.
   
   So, I'd vote we write API Tests for the CRConfig, and once those exist, 
remove the CRConfig calls in all the Perl tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2191: revert changes that broke perl unit tests

[GitBox]

rob05c commented on a change in pull request #2191: revert changes that broke 
perl unit tests
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2191#discussion_r185235867
 
 

 ##
 File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
 ##
 @@ -449,6 +449,13 @@ sub api_routes {
# -- CDNS: ROUTING
$r->get("/api/$version/cdns/routing")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Cdn#routing', namespace => $namespace );
 
+   # -- CDNS: SNAPSHOT
+   $r->get("/api/$version/cdns/:name/snapshot")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#get_snapshot', namespace => $namespace );
+   $r->get("/api/$version/cdns/:name/snapshot/new")->over( authenticated 
=> 1, not_ldap => 1 )->to( 'Topology#get_new_snapshot', namespace => $namespace 
);
+   $r->put( "/api/$version/cdns/:id/snapshot" => [ id => qr/\d+/ ] 
)->over( authenticated => 1, not_ldap => 1 )
+   ->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
+   $r->put("/api/$version/snapshot/:cdn_name")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
 
 Review comment:
   It looks like all those tests are doing is, after doing their own 
cdn/ds/config stuff, is getting or setting the snapshot.
   
   The Go CRConfig doesn't have API tests, only unit tests, because API Test 
DSes and Servers didn't exist when I wrote it; but they do now.
   
   For the Perl tests, for cdns and deliveryservices, all they're doing is 
trying to snapshot and get the snapshot, after posting their own data. Which, 
the CRConfig API Tests will already do, creating DSes and CDNS and other things 
(and in fact, actually verify the things it created are in the CRConfig, which 
is more than the Perl tests do).
   
   For the config tests, all they're doing is GETs of config files, no POSTs, 
and then getting the CRConfig. So, they're not actually changing data, so 
there's really no reason to verify the CRConfig GET succeeds there, we'll 
already be verifying that in the CRConfig's own tests.
   
   So, I'd vote we write API Tests for the CRConfig, and once those exist, 
remove the CRConfig calls in all the Perl tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich commented on a change in pull request #2191: revert changes that broke perl unit tests

[GitBox]

dewrich commented on a change in pull request #2191: revert changes that broke 
perl unit tests
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2191#discussion_r185233069
 
 

 ##
 File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
 ##
 @@ -449,6 +449,13 @@ sub api_routes {
# -- CDNS: ROUTING
$r->get("/api/$version/cdns/routing")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Cdn#routing', namespace => $namespace );
 
+   # -- CDNS: SNAPSHOT
+   $r->get("/api/$version/cdns/:name/snapshot")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#get_snapshot', namespace => $namespace );
+   $r->get("/api/$version/cdns/:name/snapshot/new")->over( authenticated 
=> 1, not_ldap => 1 )->to( 'Topology#get_new_snapshot', namespace => $namespace 
);
+   $r->put( "/api/$version/cdns/:id/snapshot" => [ id => qr/\d+/ ] 
)->over( authenticated => 1, not_ldap => 1 )
+   ->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
+   $r->put("/api/$version/snapshot/:cdn_name")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
 
 Review comment:
   gimme a few and I'll figure out what we can remove surgically


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich commented on a change in pull request #2191: revert changes that broke perl unit tests

[GitBox]

dewrich commented on a change in pull request #2191: revert changes that broke 
perl unit tests
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2191#discussion_r185232851
 
 

 ##
 File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
 ##
 @@ -449,6 +449,13 @@ sub api_routes {
# -- CDNS: ROUTING
$r->get("/api/$version/cdns/routing")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Cdn#routing', namespace => $namespace );
 
+   # -- CDNS: SNAPSHOT
+   $r->get("/api/$version/cdns/:name/snapshot")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#get_snapshot', namespace => $namespace );
+   $r->get("/api/$version/cdns/:name/snapshot/new")->over( authenticated 
=> 1, not_ldap => 1 )->to( 'Topology#get_new_snapshot', namespace => $namespace 
);
+   $r->put( "/api/$version/cdns/:id/snapshot" => [ id => qr/\d+/ ] 
)->over( authenticated => 1, not_ldap => 1 )
+   ->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
+   $r->put("/api/$version/snapshot/:cdn_name")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
 
 Review comment:
   The key one being the `config_files_apache_traffic_server`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich commented on a change in pull request #2191: revert changes that broke perl unit tests

[GitBox]

dewrich commented on a change in pull request #2191: revert changes that broke 
perl unit tests
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2191#discussion_r185232797
 
 

 ##
 File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
 ##
 @@ -449,6 +449,13 @@ sub api_routes {
# -- CDNS: ROUTING
$r->get("/api/$version/cdns/routing")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Cdn#routing', namespace => $namespace );
 
+   # -- CDNS: SNAPSHOT
+   $r->get("/api/$version/cdns/:name/snapshot")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#get_snapshot', namespace => $namespace );
+   $r->get("/api/$version/cdns/:name/snapshot/new")->over( authenticated 
=> 1, not_ldap => 1 )->to( 'Topology#get_new_snapshot', namespace => $namespace 
);
+   $r->put( "/api/$version/cdns/:id/snapshot" => [ id => qr/\d+/ ] 
)->over( authenticated => 1, not_ldap => 1 )
+   ->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
+   $r->put("/api/$version/snapshot/:cdn_name")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
 
 Review comment:
   @rob05c 
   ```Test Summary Report
   ---
   t/api/1.2/cdn.t   (Wstat: 768 Tests: 59 Failed: 
3)
 Failed tests:  13, 16, 18
 Non-zero exit status: 3
   t/api/1.2/config_files_apache_traffic_server.t (Wstat: 256 Tests: 54 Failed: 
1)
 Failed test:  50
 Non-zero exit status: 1
   t/api/1.2/deliveryservice.t   (Wstat: 768 Tests: 378 Failed: 
3)
 Failed tests:  119, 245, 371
 Non-zero exit status: 3```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rob05c commented on a change in pull request #2191: revert changes that broke perl unit tests

[GitBox]

rob05c commented on a change in pull request #2191: revert changes that broke 
perl unit tests
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2191#discussion_r185231007
 
 

 ##
 File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
 ##
 @@ -449,6 +449,13 @@ sub api_routes {
# -- CDNS: ROUTING
$r->get("/api/$version/cdns/routing")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Cdn#routing', namespace => $namespace );
 
+   # -- CDNS: SNAPSHOT
+   $r->get("/api/$version/cdns/:name/snapshot")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#get_snapshot', namespace => $namespace );
+   $r->get("/api/$version/cdns/:name/snapshot/new")->over( authenticated 
=> 1, not_ldap => 1 )->to( 'Topology#get_new_snapshot', namespace => $namespace 
);
+   $r->put( "/api/$version/cdns/:id/snapshot" => [ id => qr/\d+/ ] 
)->over( authenticated => 1, not_ldap => 1 )
+   ->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
+   $r->put("/api/$version/snapshot/:cdn_name")->over( authenticated => 1, 
not_ldap => 1 )->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
 
 Review comment:
   What tests are relying on these endpoints? If it's only the CRConfig tests, 
we can remove those, right?
   
   I'm wondering what else, to know if we should do those endpoints in Go next.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich closed issue #2185: Profiles without a cdn are not returned

[GitBox]

dewrich closed issue #2185: Profiles without a cdn are not returned
URL: https://github.com/apache/incubator-trafficcontrol/issues/2185
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] dewrich closed pull request #2192: return profiles without cdns by using left join

[GitBox]

dewrich closed pull request #2192: return profiles without cdns by using left 
join
URL: https://github.com/apache/incubator-trafficcontrol/pull/2192
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_ops/traffic_ops_golang/profile/profiles.go 
b/traffic_ops/traffic_ops_golang/profile/profiles.go
index d848c6e5a..4e3a00f98 100644
--- a/traffic_ops/traffic_ops_golang/profile/profiles.go
+++ b/traffic_ops/traffic_ops_golang/profile/profiles.go
@@ -160,7 +160,7 @@ prof.type,
 c.id as cdn,
 c.name as cdn_name
 FROM profile prof
-JOIN cdn c ON prof.cdn = c.id`
+LEFT JOIN cdn c ON prof.cdn = c.id`
 
return query
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2010: Go login

[GitBox]

asfgit commented on issue #2010: Go login
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2010#issuecomment-385665384
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1496/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit commented on issue #2192: return profiles without cdns by using left join

[GitBox]

asfgit commented on issue #2192: return profiles without cdns by using left join
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2192#issuecomment-385660760
 
 
   
   Refer to this link for build results (access rights to CI server needed): 
   https://builds.apache.org/job/incubator-trafficcontrol-PR/1495/
   Test PASSed.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DylanVolz opened a new pull request #2192: return profiles without cdns by using left join

[GitBox]

DylanVolz opened a new pull request #2192: return profiles without cdns by 
using left join
URL: https://github.com/apache/incubator-trafficcontrol/pull/2192
 
 
   fixes #2185 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services