[jira] [Work logged] (TS-4728) Null pointer error in LogHost.cc.

2016-11-08 Thread ASF GitHub Bot (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-4728?focusedWorklogId=31828=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31828
 ]

ASF GitHub Bot logged work on TS-4728:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 23:34
Start Date: 08/Nov/16 23:34
Worklog Time Spent: 10m 
  Work Description: GitHub user pbchou opened a pull request:

https://github.com/apache/trafficserver/pull/1213

TS-4728 Null pointer error in LogHost.cc (backport 6.2.x)

@PSUdaemon -- As requested, this is a PR to backport the commits for this 
issue to 6.2.x. However, I'm not sure that I can fully vouch for this because 
IIRC the crash bug that I reported in the Jira was present in 7.0.x but not in 
6.1.x or 6.2.x.

It was @zwoop who requested the back-port originally and @jpeach who wrote 
the commits in this PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pbchou/trafficserver TS-4728-backport-6.2.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1213


commit e2d746871d0fc05d280e74585289a14c5570dfdd
Author: James Peach 
Date:   2016-08-10T21:10:17Z

TS-4728: Return bool from LogHost boolean functions.

(cherry picked from commit 0a12b2682cc718057ee33d0642dfe009c5574004)

Conflicts:
proxy/logging/LogHost.cc

commit 8ec7dcd922493ec41318c989102717b555454a68
Author: James Peach 
Date:   2016-08-10T21:16:16Z

TS-4728: Remove invalid LogHost assertion.

(cherry picked from commit f502718abc09c66830d9dececf596e039daec422)

Conflicts:
proxy/logging/LogHost.cc




Issue Time Tracking
---

Worklog Id: (was: 31828)
Time Spent: 1h 40m  (was: 1.5h)

> Null pointer error in LogHost.cc.
> -
>
> Key: TS-4728
> URL: https://issues.apache.org/jira/browse/TS-4728
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Logging
>Affects Versions: 7.0.0
>Reporter: Peter Chou
>Assignee: James Peach
> Fix For: 7.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> [~jpe...@apache.org] I am getting a null pointer access error with the 
> following assertion at the time of traffic_server start-up with log collation 
> enabled (client-side). I was able to get around it by just commenting it out, 
> but perhaps a better fix is required.
> {noformat}
> LogHost::create_orphan_LogFile_object()
> {
>   // We expect that no-one else is holding any refcounts on the
>   // orphan file so that is will be releases when we replace it
>   // below.
>   ink_assert(m_orphan_file->refcount() == 1);
> {noformat}
> Back-trace --
> {noformat}
> #0  0x0053e772 in RefCountObj::refcount (this=0x8) at 
> ../lib/ts/Ptr.h:80
> #1  0x00692f9f in LogHost::create_orphan_LogFile_object 
> (this=0x2268d80) at LogHost.cc:235
> #2  0x00692a45 in LogHost::set_ipstr_port (this=0x2268d80, 
> ipstr=0x2265d40 "127.0.0.1", pt=8085) at LogHost.cc:135
> #3  0x00692b92 in LogHost::set_name_or_ipstr (this=0x2268d80, 
> name_or_ip=0x2265d40 "127.0.0.1") at LogHost.cc:155
> #4  0x00684046 in LogConfig::read_xml_log_config (this=0x21e4110) at 
> LogConfig.cc:1472
> #5  0x0067ff73 in LogConfig::setup_log_objects (this=0x21e4110) at 
> LogConfig.cc:510
> #6  0x0067f858 in LogConfig::init (this=0x21e4110, prev_config=0x0) 
> at LogConfig.cc:395
> #7  0x006721fe in Log::init (flags=0) at Log.cc:925
> #8  0x00542552 in main (argv=0x7ffcc853abd8) at Main.cc:1828
> {noformat}
> I made minimal changes to logs_xml.config to set as client --
> {noformat}
> 
> 
>  : % : %"/>
> 
> 
> 
> 
> 
> 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] trafficserver pull request #1213: TS-4728 Null pointer error in LogHost.cc (...

2016-11-08 Thread pbchou
GitHub user pbchou opened a pull request:

https://github.com/apache/trafficserver/pull/1213

TS-4728 Null pointer error in LogHost.cc (backport 6.2.x)

@PSUdaemon -- As requested, this is a PR to backport the commits for this 
issue to 6.2.x. However, I'm not sure that I can fully vouch for this because 
IIRC the crash bug that I reported in the Jira was present in 7.0.x but not in 
6.1.x or 6.2.x.

It was @zwoop who requested the back-port originally and @jpeach who wrote 
the commits in this PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pbchou/trafficserver TS-4728-backport-6.2.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1213


commit e2d746871d0fc05d280e74585289a14c5570dfdd
Author: James Peach 
Date:   2016-08-10T21:10:17Z

TS-4728: Return bool from LogHost boolean functions.

(cherry picked from commit 0a12b2682cc718057ee33d0642dfe009c5574004)

Conflicts:
proxy/logging/LogHost.cc

commit 8ec7dcd922493ec41318c989102717b555454a68
Author: James Peach 
Date:   2016-08-10T21:16:16Z

TS-4728: Remove invalid LogHost assertion.

(cherry picked from commit f502718abc09c66830d9dececf596e039daec422)

Conflicts:
proxy/logging/LogHost.cc




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Work logged] (TS-1257) Replace Tcl_Hash* with lib/ts/Map

2016-11-08 Thread ASF GitHub Bot (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-1257?focusedWorklogId=31803=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31803
 ]

ASF GitHub Bot logged work on TS-1257:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 19:23
Start Date: 08/Nov/16 19:23
Worklog Time Spent: 10m 
  Work Description: Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1212
  
I think the goal is to remove all TCL dependencies, not necessarily to 
improve performance.


Issue Time Tracking
---

Worklog Id: (was: 31803)
Time Spent: 1h  (was: 50m)

> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have 
> already discussed looking into removing the old Tcl cruft by replacing it 
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the 
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly 
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be 
> discussed/decided/evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] trafficserver issue #1212: TS-1257: [ssl_cipher_table] replace TCL HashTable...

2016-11-08 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1212
  
I think the goal is to remove all TCL dependencies, not necessarily to 
improve performance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (TS-5046) SEGV HttpSM::tunnel_handler_server(int event, HttpTunnelProducer *p)

2016-11-08 Thread Leif Hedstrom (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leif Hedstrom updated TS-5046:
--
Component/s: Network
 HTTP

> SEGV HttpSM::tunnel_handler_server(int event, HttpTunnelProducer *p) 
> -
>
> Key: TS-5046
> URL: https://issues.apache.org/jira/browse/TS-5046
> Project: Traffic Server
>  Issue Type: Bug
>  Components: HTTP, Network
>Reporter: Masa Sekimura
> Fix For: 6.2.1
>
>
> one of servers running 6.2.x (729c60b) got a SIGSEGV
> {code}
> (gdb) thread 42
> [Switching to thread 42 (Thread 0x2aaab460d700 (LWP 4145))]
> #0  0x2d6bd37d in __libc_waitpid (pid=, 
> stat_loc=, options=) at 
> ../sysdeps/unix/sysv/linux/waitpid.c:41
> 41../sysdeps/unix/sysv/linux/waitpid.c: No such file or directory.
> (gdb) bt
> #0  0x2d6bd37d in __libc_waitpid (pid=, 
> stat_loc=, options=) at 
> ../sysdeps/unix/sysv/linux/waitpid.c:41
> #1  0x2ab81ec7 in crash_logger_invoke (signo=11, info=0x2aaab460bcf0, 
> ctx=0x2aaab460bbc0) at Crash.cc:164
> #2  
> #3  0x2ac83358 in HttpSM::tunnel_handler_server (this=0x2ab9b4efac00, 
> event=, p=) at HttpSM.cc:3108
> #4  0x2ace1d72 in HttpTunnel::producer_handler 
> (this=this@entry=0x2ab9b4efbf28, event=102, event@entry=100, 
> p=p@entry=0x2ab9b4efc128) at HttpTunnel.cc:1240
> #5  0x2ace3343 in HttpTunnel::producer_run 
> (this=this@entry=0x2ab9b4efbf28, p=p@entry=0x2ab9b4efc128) at 
> HttpTunnel.cc:1020
> #6  0x2ace3d71 in HttpTunnel::tunnel_run (this=0x2ab9b4efbf28, 
> p_arg=0x2ab9b4efc128) at HttpTunnel.cc:787
> #7  0x2ac96f8b in HttpSM::state_api_callout 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1534
> #8  0x2ac9e0d3 in HttpSM::state_api_callback 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1331
> #9  0x2abad6ad in TSHttpTxnReenable (txnp=0x2ab9b4efac00, 
> event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
> #10 0x2aaabe845c05 in XInjectResponseHeaders (event=, 
> edata=0x2ab9b4efac00) at xdebug.cc:295
> #11 0x2ab98c04 in INKContInternal::handle_event (this=0x2aaab6bf9dc0, 
> event=60007, edata=0x2ab9b4efac00) at InkAPI.cc:1006
> #12 0x2ac96d10 in HttpSM::state_api_callout 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1452
> #13 0x2ac9e0d3 in HttpSM::state_api_callback 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1331
> #14 0x2abad6ad in TSHttpTxnReenable (txnp=0x2ab9b4efac00, 
> event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
> #15 0x2aaabe01ea45 in cont_rewrite_headers (contp=0x2aaab6bf9ee0, 
> event=, edata=0x2ab9b4efac00) at header_rewrite.cc:307
> #16 0x2ab98c04 in INKContInternal::handle_event (this=0x2aaab6bf9ee0, 
> event=60007, edata=0x2ab9b4efac00) at InkAPI.cc:1006
> #17 0x2ac96d10 in HttpSM::state_api_callout (this=0x2ab9b4efac00, 
> event=, data=) at HttpSM.cc:1452
> #18 0x2ac9c910 in HttpSM::set_next_state (this=0x2ab9b4efac00) at 
> HttpSM.cc:7296
> #19 0x2ac96f8b in HttpSM::state_api_callout 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1534
> #20 0x2ac9e0d3 in HttpSM::state_api_callback 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1331
> #21 0x2abad6ad in TSHttpTxnReenable (txnp=0x2ab9b4efac00, 
> event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
> #22 0x2aaabf4038d5 in cont_handle_response (contp=, 
> event=, edata=0x2ab9b4efac00) at background_fetch.cc:544
> #23 0x2ab98c04 in INKContInternal::handle_event (this=0x2aaab6bf9d00, 
> event=60006, edata=0x2ab9b4efac00) at InkAPI.cc:1006
> #24 0x2ac96d10 in HttpSM::state_api_callout 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1452
> #25 0x2ac9e0d3 in HttpSM::state_api_callback 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1331
> #26 0x2abad6ad in TSHttpTxnReenable (txnp=0x2ab9b4efac00, 
> event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
> #27 0x2aaabe01ea45 in cont_rewrite_headers (contp=0x2aaab6bf9ee0, 
> event=, edata=0x2ab9b4efac00) at header_rewrite.cc:307
> #28 0x2ab98c04 in INKContInternal::handle_event (this=0x2aaab6bf9ee0, 
> event=60006, edata=0x2ab9b4efac00) at InkAPI.cc:1006
> #29 0x2ac96d10 in HttpSM::state_api_callout (this=0x2ab9b4efac00, 
> event=, data=) at HttpSM.cc:1452
> #30 0x2ac97b6f in HttpSM::state_read_server_response_header 
> (this=0x2ab9b4efac00, event=100, data=0x2aaaf59b3a98) at 

[jira] [Updated] (TS-5046) SEGV HttpSM::tunnel_handler_server(int event, HttpTunnelProducer *p)

2016-11-08 Thread Masa Sekimura (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Masa Sekimura updated TS-5046:
--
Fix Version/s: 6.2.1

> SEGV HttpSM::tunnel_handler_server(int event, HttpTunnelProducer *p) 
> -
>
> Key: TS-5046
> URL: https://issues.apache.org/jira/browse/TS-5046
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Masa Sekimura
> Fix For: 6.2.1
>
>
> one of servers running 6.2.x (729c60b) got a SIGSEGV
> {code}
> (gdb) thread 42
> [Switching to thread 42 (Thread 0x2aaab460d700 (LWP 4145))]
> #0  0x2d6bd37d in __libc_waitpid (pid=, 
> stat_loc=, options=) at 
> ../sysdeps/unix/sysv/linux/waitpid.c:41
> 41../sysdeps/unix/sysv/linux/waitpid.c: No such file or directory.
> (gdb) bt
> #0  0x2d6bd37d in __libc_waitpid (pid=, 
> stat_loc=, options=) at 
> ../sysdeps/unix/sysv/linux/waitpid.c:41
> #1  0x2ab81ec7 in crash_logger_invoke (signo=11, info=0x2aaab460bcf0, 
> ctx=0x2aaab460bbc0) at Crash.cc:164
> #2  
> #3  0x2ac83358 in HttpSM::tunnel_handler_server (this=0x2ab9b4efac00, 
> event=, p=) at HttpSM.cc:3108
> #4  0x2ace1d72 in HttpTunnel::producer_handler 
> (this=this@entry=0x2ab9b4efbf28, event=102, event@entry=100, 
> p=p@entry=0x2ab9b4efc128) at HttpTunnel.cc:1240
> #5  0x2ace3343 in HttpTunnel::producer_run 
> (this=this@entry=0x2ab9b4efbf28, p=p@entry=0x2ab9b4efc128) at 
> HttpTunnel.cc:1020
> #6  0x2ace3d71 in HttpTunnel::tunnel_run (this=0x2ab9b4efbf28, 
> p_arg=0x2ab9b4efc128) at HttpTunnel.cc:787
> #7  0x2ac96f8b in HttpSM::state_api_callout 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1534
> #8  0x2ac9e0d3 in HttpSM::state_api_callback 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1331
> #9  0x2abad6ad in TSHttpTxnReenable (txnp=0x2ab9b4efac00, 
> event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
> #10 0x2aaabe845c05 in XInjectResponseHeaders (event=, 
> edata=0x2ab9b4efac00) at xdebug.cc:295
> #11 0x2ab98c04 in INKContInternal::handle_event (this=0x2aaab6bf9dc0, 
> event=60007, edata=0x2ab9b4efac00) at InkAPI.cc:1006
> #12 0x2ac96d10 in HttpSM::state_api_callout 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1452
> #13 0x2ac9e0d3 in HttpSM::state_api_callback 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1331
> #14 0x2abad6ad in TSHttpTxnReenable (txnp=0x2ab9b4efac00, 
> event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
> #15 0x2aaabe01ea45 in cont_rewrite_headers (contp=0x2aaab6bf9ee0, 
> event=, edata=0x2ab9b4efac00) at header_rewrite.cc:307
> #16 0x2ab98c04 in INKContInternal::handle_event (this=0x2aaab6bf9ee0, 
> event=60007, edata=0x2ab9b4efac00) at InkAPI.cc:1006
> #17 0x2ac96d10 in HttpSM::state_api_callout (this=0x2ab9b4efac00, 
> event=, data=) at HttpSM.cc:1452
> #18 0x2ac9c910 in HttpSM::set_next_state (this=0x2ab9b4efac00) at 
> HttpSM.cc:7296
> #19 0x2ac96f8b in HttpSM::state_api_callout 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1534
> #20 0x2ac9e0d3 in HttpSM::state_api_callback 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1331
> #21 0x2abad6ad in TSHttpTxnReenable (txnp=0x2ab9b4efac00, 
> event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
> #22 0x2aaabf4038d5 in cont_handle_response (contp=, 
> event=, edata=0x2ab9b4efac00) at background_fetch.cc:544
> #23 0x2ab98c04 in INKContInternal::handle_event (this=0x2aaab6bf9d00, 
> event=60006, edata=0x2ab9b4efac00) at InkAPI.cc:1006
> #24 0x2ac96d10 in HttpSM::state_api_callout 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1452
> #25 0x2ac9e0d3 in HttpSM::state_api_callback 
> (this=this@entry=0x2ab9b4efac00, event=event@entry=6, 
> data=data@entry=0x0) at HttpSM.cc:1331
> #26 0x2abad6ad in TSHttpTxnReenable (txnp=0x2ab9b4efac00, 
> event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
> #27 0x2aaabe01ea45 in cont_rewrite_headers (contp=0x2aaab6bf9ee0, 
> event=, edata=0x2ab9b4efac00) at header_rewrite.cc:307
> #28 0x2ab98c04 in INKContInternal::handle_event (this=0x2aaab6bf9ee0, 
> event=60006, edata=0x2ab9b4efac00) at InkAPI.cc:1006
> #29 0x2ac96d10 in HttpSM::state_api_callout (this=0x2ab9b4efac00, 
> event=, data=) at HttpSM.cc:1452
> #30 0x2ac97b6f in HttpSM::state_read_server_response_header 
> (this=0x2ab9b4efac00, event=100, data=0x2aaaf59b3a98) at HttpSM.cc:1953
> #31 0x2ac9e2bd in 

[jira] [Created] (TS-5046) SEGV HttpSM::tunnel_handler_server(int event, HttpTunnelProducer *p)

2016-11-08 Thread Masa Sekimura (JIRA)
Masa Sekimura created TS-5046:
-

 Summary: SEGV HttpSM::tunnel_handler_server(int event, 
HttpTunnelProducer *p) 
 Key: TS-5046
 URL: https://issues.apache.org/jira/browse/TS-5046
 Project: Traffic Server
  Issue Type: Bug
Reporter: Masa Sekimura


one of servers running 6.2.x (729c60b) got a SIGSEGV

{code}
(gdb) thread 42
[Switching to thread 42 (Thread 0x2aaab460d700 (LWP 4145))]
#0  0x2d6bd37d in __libc_waitpid (pid=, 
stat_loc=, options=) at 
../sysdeps/unix/sysv/linux/waitpid.c:41
41  ../sysdeps/unix/sysv/linux/waitpid.c: No such file or directory.
(gdb) bt
#0  0x2d6bd37d in __libc_waitpid (pid=, 
stat_loc=, options=) at 
../sysdeps/unix/sysv/linux/waitpid.c:41
#1  0x2ab81ec7 in crash_logger_invoke (signo=11, info=0x2aaab460bcf0, 
ctx=0x2aaab460bbc0) at Crash.cc:164
#2  
#3  0x2ac83358 in HttpSM::tunnel_handler_server (this=0x2ab9b4efac00, 
event=, p=) at HttpSM.cc:3108
#4  0x2ace1d72 in HttpTunnel::producer_handler 
(this=this@entry=0x2ab9b4efbf28, event=102, event@entry=100, 
p=p@entry=0x2ab9b4efc128) at HttpTunnel.cc:1240
#5  0x2ace3343 in HttpTunnel::producer_run 
(this=this@entry=0x2ab9b4efbf28, p=p@entry=0x2ab9b4efc128) at HttpTunnel.cc:1020
#6  0x2ace3d71 in HttpTunnel::tunnel_run (this=0x2ab9b4efbf28, 
p_arg=0x2ab9b4efc128) at HttpTunnel.cc:787
#7  0x2ac96f8b in HttpSM::state_api_callout 
(this=this@entry=0x2ab9b4efac00, event=event@entry=6, data=data@entry=0x0) 
at HttpSM.cc:1534
#8  0x2ac9e0d3 in HttpSM::state_api_callback 
(this=this@entry=0x2ab9b4efac00, event=event@entry=6, data=data@entry=0x0) 
at HttpSM.cc:1331
#9  0x2abad6ad in TSHttpTxnReenable (txnp=0x2ab9b4efac00, 
event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
#10 0x2aaabe845c05 in XInjectResponseHeaders (event=, 
edata=0x2ab9b4efac00) at xdebug.cc:295
#11 0x2ab98c04 in INKContInternal::handle_event (this=0x2aaab6bf9dc0, 
event=60007, edata=0x2ab9b4efac00) at InkAPI.cc:1006
#12 0x2ac96d10 in HttpSM::state_api_callout 
(this=this@entry=0x2ab9b4efac00, event=event@entry=6, data=data@entry=0x0) 
at HttpSM.cc:1452
#13 0x2ac9e0d3 in HttpSM::state_api_callback 
(this=this@entry=0x2ab9b4efac00, event=event@entry=6, data=data@entry=0x0) 
at HttpSM.cc:1331
#14 0x2abad6ad in TSHttpTxnReenable (txnp=0x2ab9b4efac00, 
event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
#15 0x2aaabe01ea45 in cont_rewrite_headers (contp=0x2aaab6bf9ee0, 
event=, edata=0x2ab9b4efac00) at header_rewrite.cc:307
#16 0x2ab98c04 in INKContInternal::handle_event (this=0x2aaab6bf9ee0, 
event=60007, edata=0x2ab9b4efac00) at InkAPI.cc:1006
#17 0x2ac96d10 in HttpSM::state_api_callout (this=0x2ab9b4efac00, 
event=, data=) at HttpSM.cc:1452
#18 0x2ac9c910 in HttpSM::set_next_state (this=0x2ab9b4efac00) at 
HttpSM.cc:7296
#19 0x2ac96f8b in HttpSM::state_api_callout 
(this=this@entry=0x2ab9b4efac00, event=event@entry=6, data=data@entry=0x0) 
at HttpSM.cc:1534
#20 0x2ac9e0d3 in HttpSM::state_api_callback 
(this=this@entry=0x2ab9b4efac00, event=event@entry=6, data=data@entry=0x0) 
at HttpSM.cc:1331
#21 0x2abad6ad in TSHttpTxnReenable (txnp=0x2ab9b4efac00, 
event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
#22 0x2aaabf4038d5 in cont_handle_response (contp=, 
event=, edata=0x2ab9b4efac00) at background_fetch.cc:544
#23 0x2ab98c04 in INKContInternal::handle_event (this=0x2aaab6bf9d00, 
event=60006, edata=0x2ab9b4efac00) at InkAPI.cc:1006
#24 0x2ac96d10 in HttpSM::state_api_callout 
(this=this@entry=0x2ab9b4efac00, event=event@entry=6, data=data@entry=0x0) 
at HttpSM.cc:1452
#25 0x2ac9e0d3 in HttpSM::state_api_callback 
(this=this@entry=0x2ab9b4efac00, event=event@entry=6, data=data@entry=0x0) 
at HttpSM.cc:1331
#26 0x2abad6ad in TSHttpTxnReenable (txnp=0x2ab9b4efac00, 
event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5652
#27 0x2aaabe01ea45 in cont_rewrite_headers (contp=0x2aaab6bf9ee0, 
event=, edata=0x2ab9b4efac00) at header_rewrite.cc:307
#28 0x2ab98c04 in INKContInternal::handle_event (this=0x2aaab6bf9ee0, 
event=60006, edata=0x2ab9b4efac00) at InkAPI.cc:1006
#29 0x2ac96d10 in HttpSM::state_api_callout (this=0x2ab9b4efac00, 
event=, data=) at HttpSM.cc:1452
#30 0x2ac97b6f in HttpSM::state_read_server_response_header 
(this=0x2ab9b4efac00, event=100, data=0x2aaaf59b3a98) at HttpSM.cc:1953
#31 0x2ac9e2bd in HttpSM::main_handler (this=0x2ab9b4efac00, event=100, 
data=0x2aaaf59b3a98) at HttpSM.cc:2658
#32 0x2ae6956b in Continuation::handleEvent (data=0x2aaaf59b3a98, 
event=100, this=) at 
../../iocore/eventsystem/I_Continuation.h:153
#33 read_signal_and_update (vc=0x2aaaf59b3980, vc@entry=0x1, 
event=event@entry=100) at UnixNetVConnection.cc:148
#34 UnixNetVConnection::readSignalAndUpdate 

[jira] [Work logged] (TS-1257) Replace Tcl_Hash* with lib/ts/Map

2016-11-08 Thread ASF GitHub Bot (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-1257?focusedWorklogId=31795=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31795
 ]

ASF GitHub Bot logged work on TS-1257:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 16:12
Start Date: 08/Nov/16 16:12
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1212#discussion_r87022320
  
--- Diff: iocore/net/SSLUtils.cc ---
@@ -141,8 +142,9 @@ static int ssl_vc_index = -1;
 static ink_mutex *mutex_buf  = nullptr;
 static bool open_ssl_initialized = false;
 
-RecRawStatBlock *ssl_rsb   = nullptr;
-static InkHashTable *ssl_cipher_name_table = nullptr;
+RecRawStatBlock *ssl_rsb = nullptr;
+typedef std::unordered_map cipherTable;
--- End diff --

This hashes on the pointer value, not on the string value. I'm not sure 
that OpenSSL guarantees to give the same pointer values when you fish them out 
of the SSL context.


Issue Time Tracking
---

Worklog Id: (was: 31795)
Time Spent: 50m  (was: 40m)

> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have 
> already discussed looking into removing the old Tcl cruft by replacing it 
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the 
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly 
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be 
> discussed/decided/evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] trafficserver pull request #1212: TS-1257: [ssl_cipher_table] replace TCL Ha...

2016-11-08 Thread jpeach
Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1212#discussion_r87022320
  
--- Diff: iocore/net/SSLUtils.cc ---
@@ -141,8 +142,9 @@ static int ssl_vc_index = -1;
 static ink_mutex *mutex_buf  = nullptr;
 static bool open_ssl_initialized = false;
 
-RecRawStatBlock *ssl_rsb   = nullptr;
-static InkHashTable *ssl_cipher_name_table = nullptr;
+RecRawStatBlock *ssl_rsb = nullptr;
+typedef std::unordered_map cipherTable;
--- End diff --

This hashes on the pointer value, not on the string value. I'm not sure 
that OpenSSL guarantees to give the same pointer values when you fish them out 
of the SSL context.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Work logged] (TS-1257) Replace Tcl_Hash* with lib/ts/Map

2016-11-08 Thread ASF GitHub Bot (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-1257?focusedWorklogId=31791=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31791
 ]

ASF GitHub Bot logged work on TS-1257:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 15:55
Start Date: 08/Nov/16 15:55
Worklog Time Spent: 10m 
  Work Description: GitHub user persiaAziz opened a pull request:

https://github.com/apache/trafficserver/pull/1212

TS-1257: [ssl_cipher_table] replace TCL HashTable by unordered_map

Replace the underlying TCL hash table implementation of 
ssl_cipher_name_table by STL unordered_map. This PR partially addresses 
TS-1257. There are many places where TCL hash table is being used. I plan to 
replace these one by one.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/persiaAziz/trafficserver TS-1257

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1212.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1212


commit da93bfb47b205a9d732f56c480631bd927f17316
Author: Persia Aziz 
Date:   2016-11-04T18:18:06Z

TS-1257: [ssl_cipher_table] replace TCL HashTable by unordered_map




Issue Time Tracking
---

Worklog Id: (was: 31791)
Time Spent: 40m  (was: 0.5h)

> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have 
> already discussed looking into removing the old Tcl cruft by replacing it 
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the 
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly 
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be 
> discussed/decided/evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] trafficserver pull request #1212: TS-1257: [ssl_cipher_table] replace TCL Ha...

2016-11-08 Thread persiaAziz
GitHub user persiaAziz opened a pull request:

https://github.com/apache/trafficserver/pull/1212

TS-1257: [ssl_cipher_table] replace TCL HashTable by unordered_map

Replace the underlying TCL hash table implementation of 
ssl_cipher_name_table by STL unordered_map. This PR partially addresses 
TS-1257. There are many places where TCL hash table is being used. I plan to 
replace these one by one.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/persiaAziz/trafficserver TS-1257

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1212.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1212


commit da93bfb47b205a9d732f56c480631bd927f17316
Author: Persia Aziz 
Date:   2016-11-04T18:18:06Z

TS-1257: [ssl_cipher_table] replace TCL HashTable by unordered_map




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver pull request #1197: TS-1257: replace TCL_HashTable with unorde...

2016-11-08 Thread persiaAziz
Github user persiaAziz closed the pull request at:

https://github.com/apache/trafficserver/pull/1197


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Work logged] (TS-1257) Replace Tcl_Hash* with lib/ts/Map

2016-11-08 Thread ASF GitHub Bot (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-1257?focusedWorklogId=31789=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31789
 ]

ASF GitHub Bot logged work on TS-1257:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 15:48
Start Date: 08/Nov/16 15:48
Worklog Time Spent: 10m 
  Work Description: Github user persiaAziz closed the pull request at:

https://github.com/apache/trafficserver/pull/1197


Issue Time Tracking
---

Worklog Id: (was: 31789)
Time Spent: 0.5h  (was: 20m)

> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have 
> already discussed looking into removing the old Tcl cruft by replacing it 
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the 
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly 
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be 
> discussed/decided/evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] trafficserver issue #1208: TS-4514: Transaction hangs when no_dns_just_forwa...

2016-11-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1208
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1087/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Work logged] (TS-4514) Transaction hangs when no_dns_just_forward is configured but parent proxy is unresolvable

2016-11-08 Thread ASF GitHub Bot (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-4514?focusedWorklogId=31774=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31774
 ]

ASF GitHub Bot logged work on TS-4514:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 15:27
Start Date: 08/Nov/16 15:27
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1208
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1194/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31774)
Time Spent: 40m  (was: 0.5h)

> Transaction hangs when no_dns_just_forward is configured but parent proxy is 
> unresolvable
> -
>
> Key: TS-4514
> URL: https://issues.apache.org/jira/browse/TS-4514
> Project: Traffic Server
>  Issue Type: Bug
>  Components: DNS, Parent Proxy
>Reporter: Uri Shachar
>Assignee: Uri Shachar
> Fix For: 7.0.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> When ATS is configured with:
> {code}
> CONFIG proxy.config.http.no_dns_just_forward_to_parent INT 1
> {code}
> And a transaction comes in that has an unresolvable parent in parents.config 
> ATS will keep retrying to resolve the same parent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Work logged] (TS-4514) Transaction hangs when no_dns_just_forward is configured but parent proxy is unresolvable

2016-11-08 Thread ASF GitHub Bot (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-4514?focusedWorklogId=31781=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31781
 ]

ASF GitHub Bot logged work on TS-4514:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 15:29
Start Date: 08/Nov/16 15:29
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1208
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1087/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 31781)
Time Spent: 50m  (was: 40m)

> Transaction hangs when no_dns_just_forward is configured but parent proxy is 
> unresolvable
> -
>
> Key: TS-4514
> URL: https://issues.apache.org/jira/browse/TS-4514
> Project: Traffic Server
>  Issue Type: Bug
>  Components: DNS, Parent Proxy
>Reporter: Uri Shachar
>Assignee: Uri Shachar
> Fix For: 7.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> When ATS is configured with:
> {code}
> CONFIG proxy.config.http.no_dns_just_forward_to_parent INT 1
> {code}
> And a transaction comes in that has an unresolvable parent in parents.config 
> ATS will keep retrying to resolve the same parent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] trafficserver issue #1208: TS-4514: Transaction hangs when no_dns_just_forwa...

2016-11-08 Thread atsci
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1208
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1194/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver issue #1197: TS-1257_ssl_cipher_name_table: replace TCL_HashTa...

2016-11-08 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1197
  
We get complaints about huge PRs and now we get complaints about small ones 
:-(. I think for a change like this starting small is the best approach 
especially given how contentious this is likely to be. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver pull request #1208: TS-4514: Transaction hangs when no_dns_jus...

2016-11-08 Thread jrushford
GitHub user jrushford reopened a pull request:

https://github.com/apache/trafficserver/pull/1208

TS-4514: Transaction hangs when no_dns_just_forward is configured but…

… parent proxy is unresolvable (#699)

It doesn't really make sense for the parent selection layer to be aware of 
the no_dns flag.
Calling code handles takes the flag into account.
(cherry picked from commit 52843c023800370781e69fec45c3952edf8a307b)

Conflicts:
proxy/ParentRoundRobin.cc
proxy/ParentSelection.cc

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jrushford/trafficserver TS-4514

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1208


commit 9b9b2a30f5fb6331a9ba3e9df2d1a46bb8aa015e
Author: Uri Shachar 
Date:   2016-06-09T07:11:18Z

TS-4514: Transaction hangs when no_dns_just_forward is configured but 
parent proxy is unresolvable (#699)

It doesn't really make sense for the parent selection layer to be aware of 
the no_dns flag.
Calling code handles takes the flag into account.
(cherry picked from commit 52843c023800370781e69fec45c3952edf8a307b)

Conflicts:
proxy/ParentRoundRobin.cc
proxy/ParentSelection.cc




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Failed: trafficserver (9d11d6f2)

2016-11-08 Thread Read the Docs

Build Failed for trafficserver (latest)



You can find out more about this failure here:
https://readthedocs.org/projects/trafficserver/builds/4632121/

If you have questions, a good place to start is the FAQ:
https://docs.readthedocs.org/en/latest/faq.html



Keep documenting,
Read the Docs
--
http://readthedocs.org


[GitHub] trafficserver pull request #1207: Remove unneeded malloc from url_rewrite de...

2016-11-08 Thread SolidWallOfCode
Github user SolidWallOfCode closed the pull request at:

https://github.com/apache/trafficserver/pull/1207


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---