[GitHub] trafficserver issue #1401: Segfault in write_to_net_io with 7.1.x

[PSUdaemon]

Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/issues/1401
  
I think I am [seeing 
this](https://ci.trafficserver.apache.org/job/ubuntu_14_04-6.2.x/compiler=clang,label=ubuntu_14_04,type=release/143/console)
 in 6.2.x as well:
```
traffic_server: Segmentation fault (Address not mapped to object [0x18])
traffic_server - STACK TRACE: 

/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server(_Z19crash_logger_invokeiP9siginfo_tPv+0x8e)[0x4a234e]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x10330)[0x7fb6fa205330]

/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server(_Z15write_to_net_ioP10NetHandlerP18UnixNetVConnectionP7EThread+0xa1e)[0x6bb3ae]

/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x686)[0x6b4606]

/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x123)[0x6d7af3]

/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server(_ZN7EThread7executeEv+0x560)[0x6d8210]

/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server(main+0x1de0)[0x4c8bd0]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)[0x7fb6f93ccf45]

/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server[0x49218d]
/home/jenkins/bin/regression.sh: line 24: 21351 Segmentation fault  
(core dumped) "${WORKSPACE}/${BUILD_NUMBER}/install/bin/traffic_server" -k -K 
-R 1
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1401: Segfault in write_to_net_io with 7.1.x

[shinrich]

Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/issues/1401
  
I've finally got my environment running and I see the same stack very 
quickly as well.  In the cases I've seen it looks like there was a write error, 
but for some reason the write vio has been cleared out (or was never set?)

```
(gdb) frame 2
#2  0x00788350 in write_to_net_io (nh=0x2af588003e60, 
vc=0x2aad1401b800, thread=0x2af58810) at UnixNetVConnection.cc:440
440 UnixNetVConnection.cc: No such file or directory.
in UnixNetVConnection.cc
(gdb) print *s
$1 = {enabled = 0, error = 1, vio = {_cont = 0x0, nbytes = 0, ndone = 0, op 
= 0, buffer = {mbuf = 0x0, entry = 0x0}, vc_server = 0x0, mutex = {m_ptr = 
0x0}}, 
  ready_link = { = {next = 0x0}, prev = 0x0}, 
enable_link = {next = 0x0}, in_enabled_list = 0, triggered = 1}
```
The write.error stuff was added by Thomas in TS-4796, but if this just 
showed up between 7.0 and 7.1, it is unlikely that this was the culprit.  I 
think it has been a while (since 9/3/2016).  

Seems more likely that someone has cleared the vio, or we are bouncing an 
error.

In the short term I'm adding a NULL check at the begining of 
write_to_net_io, but that just seems to be masking the failure case rather than 
identifying the root cause. 

```
+  if (!s->vio.mutex) {
+ink_release_assert(s->vio._cont == NULL && vc->write.error);
+return;
+  }
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1442: Doc: Add an example of disabled HTTP/2 over TLS

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1442
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/106/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1442: Doc: Add an example of disabled HTTP/2 over TLS

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1442
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1435/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1442: Doc: Add an example of disabled HTTP/2 over TLS

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1442
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1542/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1442: Doc: Add an example of disabled HTTP/2 ove...

[masaori335]

GitHub user masaori335 opened a pull request:

https://github.com/apache/trafficserver/pull/1442

Doc: Add an example of disabled HTTP/2 over TLS



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/masaori335/trafficserver doc-proto

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1442


commit 51c74aa2c33398b3960d52995320c3d0df31824e
Author: Masaori Koshiba 
Date:   2017-02-14T00:59:57Z

Doc: Add an example of disabled HTTP/2 over TLS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1331: MemView is a utility to create read only views of...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1331
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1434/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1331: MemView is a utility to create read only views of...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1331
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1541/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1331: MemView is a utility to create read only views of...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1331
  
clang-analyzer build *failed*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/105/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1441: Mark the new span metrics as gauges in Epi...

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1441


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1427: Crash in ATSConsistentHash::lookup_by_hashval

[jrushford]

Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/issues/1427
  
Randall, I'm unable to duplicate in my environment, CentOS 7.2 and gcc 
4.8.5-4.  What OS are you using and can you attach your parent.config?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1441: Mark the new span metrics as gauges in Epic plugi...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1441
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/104/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1441: Mark the new span metrics as gauges in Epic plugi...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1441
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1433/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1441: Mark the new span metrics as gauges in Epic plugi...

[gtenev]

Github user gtenev commented on the issue:

https://github.com/apache/trafficserver/pull/1441
  
👍 looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1441: Mark the new span metrics as gauges in Epic plugi...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1441
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1540/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1441: Mark the new span metrics as gauges in Epi...

[zwoop]

GitHub user zwoop opened a pull request:

https://github.com/apache/trafficserver/pull/1441

Mark the new span metrics as gauges in Epic plugin



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zwoop/trafficserver EpicSpanMetrics

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1441.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1441


commit 61f1e8ed76ffef9ddba8b7a6866ae9e32a3ca700
Author: Leif Hedstrom 
Date:   2017-02-13T21:13:13Z

Mark the new span metrics as gauges in Epic plugin




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1440: Remove nullptr instances that were introdu...

[PSUdaemon]

Github user PSUdaemon closed the pull request at:

https://github.com/apache/trafficserver/pull/1440


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1440: Remove nullptr instances that were introdu...

[PSUdaemon]

Github user PSUdaemon commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1440#discussion_r100867264
  
--- Diff: lib/raft/raft_impl.h ---
@@ -338,8 +338,8 @@ template  class RaftImpl : public 
Raft
 if (!i_am_leader())
   return;
 // Attempt to pass leadership to a worthy successor.
-const ::std::string *best_node = nullptr;
-NodeState *best= nullptr;
+const ::std::string *best_node = NULL;
+NodeState *best= NULL;
--- End diff --

Yeah, but I figured just to be complete. Perhaps @SolidWallOfCode or @zwoop 
has a different opinion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1331: MemView is a utility to create read only views of...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1331
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/103/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1331: MemView is a utility to create read only views of...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1331
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/101/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1331: MemView is a utility to create read only views of...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1331
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/linux-github/1432/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1331: MemView is a utility to create read only views of...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1331
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/linux-github/1430/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1331: MemView is a utility to create read only views of...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1331
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1539/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1331: MemView is a utility to create read only views of...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1331
  
clang-analyzer build *failed*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/102/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1331: MemView is a utility to create read only views of...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1331
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/linux-github/1431/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1440: Remove nullptr instances that were introduced fro...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1440
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/100/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1331: MemView is a utility to create read only views of...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1331
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1538/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1331: MemView is a utility to create read only views of...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1331
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1537/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1440: Remove nullptr instances that were introdu...

[jablko]

Github user jablko commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1440#discussion_r100845545
  
--- Diff: lib/raft/raft_impl.h ---
@@ -338,8 +338,8 @@ template  class RaftImpl : public 
Raft
 if (!i_am_leader())
   return;
 // Attempt to pass leadership to a worthy successor.
-const ::std::string *best_node = nullptr;
-NodeState *best= nullptr;
+const ::std::string *best_node = NULL;
+NodeState *best= NULL;
--- End diff --

NBD, but this instance isn't from an upstream backport, right? This has 
been nullptr since inception in 38e1d741f2056a7893a0a90452d37a29ae9bf707, which 
goes back to 6.0.x?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1440: Remove nullptr instances that were introduced fro...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1440
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1429/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1440: Remove nullptr instances that were introduced fro...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1440
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1536/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1440: Remove nullptr instances that were introdu...

[PSUdaemon]

GitHub user PSUdaemon opened a pull request:

https://github.com/apache/trafficserver/pull/1440

Remove nullptr instances that were introduced from upstream backports…

… and replace them with NULL.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PSUdaemon/trafficserver remove_nullptr

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1440


commit bb146e2b8484fd051bd7176c9b5e6f64cfa1b732
Author: Phil Sorber 
Date:   2017-02-13T16:54:39Z

Remove nullptr instances that were introduced from upstream backports and 
replace them with NULL.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1420: Improve error message for custom log field...

[SolidWallOfCode]

Github user SolidWallOfCode commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1420#discussion_r100805070
  
--- Diff: proxy/logging/LogBuffer.cc ---
@@ -615,10 +618,14 @@ LogBuffer::resolve_custom_entry(LogFieldList 
*fieldlist, char *printf_str, char
 }
 
 bytes_written += res;
-field = fieldlist->next(field);
+lastField = field;
+field = fieldlist->next(field);
   } else {
 Note("There are more field markers than fields;"
- " cannot process log entry");
+ " cannot process log entry '%.*s'. Last field = '%s' 
printf_str='%s' pos=%d/%d count=%d alt_printf_str='%s'",
+ bytes_written, write_to, lastField == nullptr ? "*" : 
lastField->symbol(),
--- End diff --

Yes. Which is why there is a check for that case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---