[jira] [Reopened] (TS-827) TSMimeHdrFieldValueStringInsert() can use freed memory to edit headers
[ https://issues.apache.org/jira/browse/TS-827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom reopened TS-827: -- > TSMimeHdrFieldValueStringInsert() can use freed memory to edit headers > -- > > Key: TS-827 > URL: https://issues.apache.org/jira/browse/TS-827 > Project: Traffic Server > Issue Type: Bug > Components: MIME >Affects Versions: 2.1.9, 2.1.8, 2.1.7, 2.1.6, 2.1.5, 2.1.4 >Reporter: William Bardwell >Assignee: Leif Hedstrom > Fix For: 3.1.4, 3.1.0, 3.0.0 > > Attachments: headers-prealloc.diff > > > TSMimeHdrFieldValueStringInsert() and other TSMimeHdrFieldValue*() APIs can > use freed memory to edit headers > due to calling HdrHeap::coalesce_str_heaps() from HdrHeap::allocate_str() from > mime_field_value_insert_comma_val() and other mime_field_value_*comma_val() > functions while holding pointers > into the HdrHeap. > I have a hacky but functional patch for this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TS-841) support TLS NextProtocol negotiation
[ https://issues.apache.org/jira/browse/TS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom reopened TS-841: -- It seems when accept threads are disabled, the VC is not properly reset? It used to be, I'm pretty sure, that when we accept on the net thread, we use a proxy allocator for allocating the VC. I remember adding some code around that case, to assure we release the VC on the correct freelist (proy allocator without accept thread, global freelist when accept threads are enabled). Perhaps this somehow got reverted ? I can definitely trigger the assert after a few requests with accept threads disabled. > support TLS NextProtocol negotiation > > > Key: TS-841 > URL: https://issues.apache.org/jira/browse/TS-841 > Project: Traffic Server > Issue Type: New Feature > Components: HTTP, SSL >Reporter: Leif Hedstrom >Assignee: James Peach > Fix For: 3.1.3 > > Attachments: > 0001-TS-841-Move-SSLNetAccept-and-SSLNetProcessor-into-ep.patch, > 0002-TS-841-Sprinkle-some-const-pixie-dust-on-the-SSL-cla.patch, > 0003-TS-841-Propagate-zero-length-read-events-through-SSL.patch, > 0004-TS-841-Load-plugins-after-opening-sockets.patch, > 0005-TS-841-support-TLS-NextProtocol-negotiation.patch > > > In order to make it possible to write protocol handlers like SPDY, we need to > negotiate NPN protocol before entering the HTTP SM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TS-1102) Cleanup obsolete debugging code
[
https://issues.apache.org/jira/browse/TS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom reopened TS-1102:
---
Getting this on Solaris build-bot:
{code}
CC -DHAVE_CONFIG_H -I. -I../../lib/ts -I../../iocore/eventsystem
-I../../iocore/net -I../../iocore/aio -I../../iocore/hostdb
-I../../iocore/cache -I../../iocore/cluster -I../../iocore/utils
-I../../iocore/dns -I../../lib -I../../lib/records -I../../proxy
-I../../proxy/hdrs -I../../mgmt -I../../mgmt/preparse -I../../mgmt/utils
-I/export/home/buildbot/tcl/include/amd64
-I/export/home/buildbot/pcre/include/amd64 -D_LARGEFILE64_SOURCE=1
-D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_REENTRANT -Dsolaris
-I/usr/local/ssl/include -I/opt/omni/include/amd64 -I/opt/expat-2.0.1/include
-I/export/home/buildbot/pcre/include -g -mt -m64 -D__WORDSIZE=64 -O3
-library=stlport4 -erroff -c -o Connection.o Connection.cc
"P_NetAccept.h", line 75: Error: Trailing comma in a parameter list.
"Connection.cc", line 250: Error: Trailing comma in a parameter list.
"Connection.cc", line 370: Error: Trailing comma in a parameter list.
3 Error(s) detected.
*** Error code 2
make: Fatal error: Command failed for target `Connection.o'
Current working directory
/export/home/buildbot/slave5/tserver-solaris-trunk/build/iocore/net
{code}
I'll look at it tomorrow (but input welcome :).
> Cleanup obsolete debugging code
> ---
>
> Key: TS-1102
> URL: https://issues.apache.org/jira/browse/TS-1102
> Project: Traffic Server
> Issue Type: Bug
> Components: Core, Logging, Performance
>Affects Versions: 3.0.2
> Environment: Any
>Reporter: Uri Shachar
>Assignee: Leif Hedstrom
>Priority: Minor
> Fix For: 3.1.3
>
> Attachments: diags_cleanup.patch, remove_prefix_arg.patch,
> remove_prefix_arg_v2.patch, remove_prefix_arg_v3.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current Diags.h D/EClosure mechanism is obsolete. ATS requires gcc >= 4.1
> for all compilation environments, and it includes variadic argument macro
> support with ##_VA_ARGS_ that deletes the final comma if no arguments are
> provided.
> Removing the added layer should also improve performance when high volume
> debugging is turned on.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TS-993) Add OpenBSD support.
[ https://issues.apache.org/jira/browse/TS-993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom reopened TS-993: -- > Add OpenBSD support. > > > Key: TS-993 > URL: https://issues.apache.org/jira/browse/TS-993 > Project: Traffic Server > Issue Type: Improvement > Environment: OpenBSD >Reporter: Piotr Sikora >Assignee: Leif Hedstrom > Fix For: 3.1.2 > > Attachments: 0001-Add-OpenBSD-support.patch > > > Add OpenBSD support. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TS-857) Crash Report: HttpTunnel::chain_abort_all -> HttpServerSession::do_io_close -> UnixNetVConnection::do_io_close
[
https://issues.apache.org/jira/browse/TS-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom reopened TS-857:
--
> Crash Report: HttpTunnel::chain_abort_all -> HttpServerSession::do_io_close
> -> UnixNetVConnection::do_io_close
> --
>
> Key: TS-857
> URL: https://issues.apache.org/jira/browse/TS-857
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP, Network
>Affects Versions: 3.1.0
> Environment: in my branch that is something same as 3.0.x
>Reporter: Zhao Yongming
>Assignee: weijin
> Fix For: 3.1.1
>
> Attachments: ts-857.diff, ts-857.diff
>
>
> here is the bt from the crash, some of the information is missing due to we
> have not enable the --enable-debug configure options.
> {code}
> [New process 7532]
> #0 ink_stack_trace_get (stack=, len= out>, signalhandler_frame=)
> at ink_stack_trace.cc:68
> 68fp = (void **) (*fp);
> (gdb) bt
> #0 ink_stack_trace_get (stack=, len= out>, signalhandler_frame=)
> at ink_stack_trace.cc:68
> #1 0x2ba641dccef1 in ink_stack_trace_dump (sighandler_frame= optimized out>) at ink_stack_trace.cc:114
> #2 0x004df020 in signal_handler (sig=) at
> signals.cc:225
> #3
> #4 0x006a1ea9 in UnixNetVConnection::do_io_close (this=0x1cc9bd20,
> alerrno=)
> at ../../iocore/eventsystem/I_Lock.h:297
> #5 0x0051f1d0 in HttpServerSession::do_io_close
> (this=0x2aaab0042c80, alerrno=20600) at HttpServerSession.cc:127
> #6 0x0056d1e9 in HttpTunnel::chain_abort_all (this=0x2aabeeffdd70,
> p=0x2aabeeffdf68) at HttpTunnel.cc:1300
> #7 0x005269ca in HttpSM::tunnel_handler_ua (this=0x2aabeeffc070,
> event=104, c=0x2aabeeffdda8) at HttpSM.cc:2987
> #8 0x00571dfc in HttpTunnel::consumer_handler (this=0x2aabeeffdd70,
> event=104, c=0x2aabeeffdda8) at HttpTunnel.cc:1232
> #9 0x00572032 in HttpTunnel::main_handler (this=0x2aabeeffdd70,
> event=1088608784, data=)
> at HttpTunnel.cc:1456
> #10 0x006a6307 in write_to_net_io (nh=0x2b12d688, vc=0x1cc876e0,
> thread=)
> at ../../iocore/eventsystem/I_Continuation.h:146
> #11 0x0069ce97 in NetHandler::mainNetEvent (this=0x2b12d688,
> event=, e=0x171c1ed0) at UnixNet.cc:405
> #12 0x006cddaf in EThread::process_event (this=0x2b12c010,
> e=0x171c1ed0, calling_code=5) at I_Continuation.h:146
> #13 0x006ce6bc in EThread::execute (this=0x2b12c010) at
> UnixEThread.cc:262
> #14 0x006cd0ee in spawn_thread_internal (a=0x171b58f0) at Thread.cc:88
> #15 0x003c33c064a7 in start_thread () from /lib64/libpthread.so.0
> #16 0x003c330d3c2d in clone () from /lib64/libc.so.6
> (gdb) info f
> Stack level 0, frame at 0x40e2b790:
> rip = 0x2ba641dccdf3 in ink_stack_trace_get(void**, int, int)
> (ink_stack_trace.cc:68); saved rip 0x2ba641dccef1
> called by frame at 0x40e2bbe0
> source language c++.
> Arglist at 0x40e2b770, args: stack=, len= optimized out>, signalhandler_frame=
> Locals at 0x40e2b770, Previous frame's sp is 0x40e2b790
> Saved registers:
> rbx at 0x40e2b778, rbp at 0x40e2b780, rip at 0x40e2b788
> (gdb)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TS-984) LogFile::roll crash at Machine::instance
[
https://issues.apache.org/jira/browse/TS-984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom reopened TS-984:
--
This seems to break reverse proxy for me, reopening.
> LogFile::roll crash at Machine::instance
>
>
> Key: TS-984
> URL: https://issues.apache.org/jira/browse/TS-984
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
>Affects Versions: 3.1.0
>Reporter: Zhao Yongming
>Assignee: Alan M. Carroll
> Labels: crash
> Fix For: 3.1.1
>
> Attachments: ts-984.diff
>
>
> this is a strange error when I testing the current trunk with logging
> colation server enabled:
> {code}
> [Oct 16 01:24:48.643] Server {0x2b4967f51760} WARNING: File
> /var/log/trafficserver/ex_squid.log will be rolled because a LogObject with
> different format is requesting the same filename
> FATAL: Machine.cc:37: failed assert `_instance || !"Machine instance accessed
> before initialization"`
> /usr/bin/traffic_server - STACK TRACE:
> /usr/lib64/trafficserver/libtsutil.so.3(ink_fatal_va+0xc5)[0x2b49651a5109]
> /usr/lib64/trafficserver/libtsutil.so.3(ink_fatal+0xa3)[0x2b49651a51bb]
> /usr/lib64/trafficserver/libtsutil.so.3(_ink_assert+0xc2)[0x2b49651a3aee]
> /usr/bin/traffic_server(Machine::instance()+0x24)[0x634a04]
> /usr/bin/traffic_server(LogFile::roll(long, long)+0x230)[0x5f8138]
> /usr/bin/traffic_server(LogObjectManager::_solve_filename_conflicts(LogObject*,
> int)+0x489)[0x603263]
> /usr/bin/traffic_server(LogObjectManager::_manage_object(LogObject*, bool,
> int)+0x126)[0x6029ea]
> /usr/bin/traffic_server(LogObjectManager::manage_object(LogObject*,
> int)+0x2d)[0x5e9e27]
> /usr/bin/traffic_server(LogConfig::read_xml_log_config(int)+0x3189)[0x5f28c9]
> /usr/bin/traffic_server(LogConfig::setup_log_objects()+0x229)[0x5edd63]
> /usr/bin/traffic_server(LogConfig::init(LogConfig*)+0x254)[0x5ec3ea]
> /usr/bin/traffic_server(Log::init(int)+0x30c)[0x5e8134]
> /usr/bin/traffic_server(main+0xb6a)[0x5161a4]
> /lib64/libc.so.6(__libc_start_main+0xfd)[0x2b49673b4ebd]
> /usr/bin/traffic_server[0x4cc789]
> {code}
> there is two problem here:
> 1, why the machine is not initialized?
> 2, what does "WARNING: File /var/log/trafficserver/ex_squid.log will be
> rolled because a LogObject with different format is requesting the same
> filename" mean? is that harm?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TS-988) Upgrade ICP support for IPv6
[ https://issues.apache.org/jira/browse/TS-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom reopened TS-988: -- > Upgrade ICP support for IPv6 > > > Key: TS-988 > URL: https://issues.apache.org/jira/browse/TS-988 > Project: Traffic Server > Issue Type: Improvement > Components: Clustering >Affects Versions: 3.1.0 >Reporter: Alan M. Carroll >Assignee: Alan M. Carroll >Priority: Minor > Labels: icp, ipv6 > Fix For: 3.1.2 > > > Make ICP compatible with IPv6. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TS-948) do not reload bad remap.config
[ https://issues.apache.org/jira/browse/TS-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom reopened TS-948: -- Reopen to deal with plugins failing to reinstatiate, > do not reload bad remap.config > -- > > Key: TS-948 > URL: https://issues.apache.org/jira/browse/TS-948 > Project: Traffic Server > Issue Type: Improvement > Components: Configuration, Management >Affects Versions: 3.1.0, 3.0.1 >Reporter: Conan Wang >Assignee: Leif Hedstrom >Priority: Critical > Fix For: 3.1.1 > > > traffic_server will exit if exists bad rules in remap.config, whenever > startup or reload ( traffic_line -x ). > If remap.config is not edited correctly, the server/cluster will crash when > reloading. > It's better to pre-check the remap table and not switch to the new table if > remap.config is not enough correct. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
