[
https://issues.apache.org/jira/browse/TS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom reopened TS-1102:
-------------------------------
Getting this on Solaris build-bot:
{code}
CC -DHAVE_CONFIG_H -I. -I../../lib/ts -I../../iocore/eventsystem
-I../../iocore/net -I../../iocore/aio -I../../iocore/hostdb
-I../../iocore/cache -I../../iocore/cluster -I../../iocore/utils
-I../../iocore/dns -I../../lib -I../../lib/records -I../../proxy
-I../../proxy/hdrs -I../../mgmt -I../../mgmt/preparse -I../../mgmt/utils
-I/export/home/buildbot/tcl/include/amd64
-I/export/home/buildbot/pcre/include/amd64 -D_LARGEFILE64_SOURCE=1
-D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_REENTRANT -Dsolaris
-I/usr/local/ssl/include -I/opt/omni/include/amd64 -I/opt/expat-2.0.1/include
-I/export/home/buildbot/pcre/include -g -mt -m64 -D__WORDSIZE=64 -O3
-library=stlport4 -erroff -c -o Connection.o Connection.cc
"P_NetAccept.h", line 75: Error: Trailing comma in a parameter list.
"Connection.cc", line 250: Error: Trailing comma in a parameter list.
"Connection.cc", line 370: Error: Trailing comma in a parameter list.
3 Error(s) detected.
*** Error code 2
make: Fatal error: Command failed for target `Connection.o'
Current working directory
/export/home/buildbot/slave5/tserver-solaris-trunk/build/iocore/net
{code}
I'll look at it tomorrow (but input welcome :).
> Cleanup obsolete debugging code
> -------------------------------
>
> Key: TS-1102
> URL: https://issues.apache.org/jira/browse/TS-1102
> Project: Traffic Server
> Issue Type: Bug
> Components: Core, Logging, Performance
> Affects Versions: 3.0.2
> Environment: Any
> Reporter: Uri Shachar
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.3
>
> Attachments: diags_cleanup.patch, remove_prefix_arg.patch,
> remove_prefix_arg_v2.patch, remove_prefix_arg_v3.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current Diags.h D/EClosure mechanism is obsolete. ATS requires gcc >= 4.1
> for all compilation environments, and it includes variadic argument macro
> support with ##_VA_ARGS_ that deletes the final comma if no arguments are
> provided.
> Removing the added layer should also improve performance when high volume
> debugging is turned on.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
