[GitHub] trafficserver pull request #1541: retry safe requests
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1541 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1543: Remove nullptr instance that was introduce...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1543: Remove nullptr instance that was introduce...
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/1543 Remove nullptr instance that was introduced from upstream backport an⦠â¦d replace it with NULL. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PSUdaemon/trafficserver nullptr_part_deux Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1543.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1541: retry safe requests
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1541 @vmamidi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1513: TS-4747: make marking parent proxies down ...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1513 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1539: Signals fix
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1509: TS-5106: Create ParentRoundRobin object as...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1509 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1276: TS-5105: Do vc->con.setRemote(target) befo...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1276 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1539: Signals fix
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1539#discussion_r104324677
--- Diff: iocore/eventsystem/I_EThread.h ---
@@ -56,7 +56,7 @@ enum ThreadType {
DEDICATED,
};
-extern volatile bool shutdown_event_system;
+extern bool shutdown_event_system;
--- End diff --
That's part of the revert that was done on master by @zwoop. Perhaps we
should address that there and then maybe add any changes that come out of that
to this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1539: Signals fix
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/1539 Signals fix This fixed Ubuntu builds but also reverts a commit I just backported because it was also reverted in master by @zwoop. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PSUdaemon/trafficserver signals_fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1539.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1539 commit a4726dd49afba39328f9faabc4b8c8b43f342180 Author: Alan M. Carroll <a...@apache.org> Date: 2017-02-25T06:48:45Z Fix for ignored return value in Ubuntu builds. (cherry picked from commit bae599dba5e92d9e503b4c908576a540c38a3614) commit aac01bc678c30ca068842e045b40ff0e872a7700 Author: Alan M. Carroll <a...@apache.org> Date: 2017-02-26T00:15:47Z Ubuntu build problem fix. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425 For the record, I think (void) not suppressing "warning unused" is a poor choice. (cherry picked from commit 222ea02ed938733abec4079c2a3d050c9df6d938) commit d3793956bf69ffcaacc458df7f5f5a57195c1b92 Author: Leif Hedstrom <zw...@apache.org> Date: 2017-02-28T20:14:01Z Revert "fix TS-4195: double free when stop trafficserver" This reverts commit e0e39fc5026f0f5bcd6c0884adde91bcccab6bf8. (cherry picked from commit 23e8dd026a4064b0bff7f8e5a813ca898550e8a2) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1509: TS-5106: Create ParentRoundRobin object as Parent...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1509 Can you rebase this so we can get the Intel build clear? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1513 Can you rebase this so we can get the Intel build clear? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1485: back port "fix TS-4195: double free when s...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1485 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1276 @oknet I think these have been fixed in 6.2.x upstream and you need to rebase. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1485: back port "fix TS-4195: double free when stop tra...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1485 Is the double free related to ICC build issues too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1485: back port "fix TS-4195: double free when stop tra...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1485 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1401: Segfault in write_to_net_io with 7.1.x
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/issues/1401 I'm not sure there is a core to look at in the case I pasted. It was on a build host. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1401: Segfault in write_to_net_io with 7.1.x
Github user PSUdaemon commented on the issue:
https://github.com/apache/trafficserver/issues/1401
I think I am [seeing
this](https://ci.trafficserver.apache.org/job/ubuntu_14_04-6.2.x/compiler=clang,label=ubuntu_14_04,type=release/143/console)
in 6.2.x as well:
```
traffic_server: Segmentation fault (Address not mapped to object [0x18])
traffic_server - STACK TRACE:
/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server(_Z19crash_logger_invokeiP9siginfo_tPv+0x8e)[0x4a234e]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x10330)[0x7fb6fa205330]
/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server(_Z15write_to_net_ioP10NetHandlerP18UnixNetVConnectionP7EThread+0xa1e)[0x6bb3ae]
/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x686)[0x6b4606]
/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server(_ZN7EThread13process_eventEP5Eventi+0x123)[0x6d7af3]
/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server(_ZN7EThread7executeEv+0x560)[0x6d8210]
/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server(main+0x1de0)[0x4c8bd0]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)[0x7fb6f93ccf45]
/var/jenkins/workspace/ubuntu_14_04-6.2.x/compiler/clang/label/ubuntu_14_04/type/release/143/install/bin/traffic_server[0x49218d]
/home/jenkins/bin/regression.sh: line 24: 21351 Segmentation fault
(core dumped) "${WORKSPACE}/${BUILD_NUMBER}/install/bin/traffic_server" -k -K
-R 1
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1440: Remove nullptr instances that were introdu...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1440 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1440: Remove nullptr instances that were introdu...
Github user PSUdaemon commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1440#discussion_r100867264 --- Diff: lib/raft/raft_impl.h --- @@ -338,8 +338,8 @@ template class RaftImpl : public Raft if (!i_am_leader()) return; // Attempt to pass leadership to a worthy successor. -const ::std::string *best_node = nullptr; -NodeState *best= nullptr; +const ::std::string *best_node = NULL; +NodeState *best= NULL; --- End diff -- Yeah, but I figured just to be complete. Perhaps @SolidWallOfCode or @zwoop has a different opinion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1440: Remove nullptr instances that were introdu...
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/1440 Remove nullptr instances that were introduced from upstream backports⦠⦠and replace them with NULL. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PSUdaemon/trafficserver remove_nullptr Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1440.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1440 commit bb146e2b8484fd051bd7176c9b5e6f64cfa1b732 Author: Phil Sorber <sor...@apache.org> Date: 2017-02-13T16:54:39Z Remove nullptr instances that were introduced from upstream backports and replace them with NULL. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1276 @oknet What is the plan with this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1395: Update client streams count in Http2Connec...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1395 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1395: Update client streams count in Http2ConnectionSta...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1395 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1410: 6.2.x: TS-4665: H2 not terminating stream ...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1410 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1410: 6.2.x: TS-4665: H2 not terminating stream with sh...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1410 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1436: Backport f71b75e and 734aa31 from master t...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1436 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1430: backport f71b75e and 734aa31 from master to 6.2.x
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1430 @shenzhang920 you need to rebase, not merge. I don't want to back port a merge commit. I think your mistake is that you did this directly on the 6.2.x branch. You really should use a feature branch off of 6.2.x. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1321: 6.2.x TS-4435 and TS-5059: Fixes for build...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1321 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1430: backport f71b75e and 734aa31 from master to 6.2.x
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1430 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1406: Fix Assertion failure in the regex_revalid...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1406 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1321: 6.2.x TS-4435 and TS-5059: Fixes for building wit...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1321 @jablko can you please rebase this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1395: Update client streams count in Http2ConnectionSta...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1395 @jaaju can you please rebase this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1321: 6.2.x TS-4435 and TS-5059: Fixes for building wit...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1321 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1395: Update client streams count in Http2ConnectionSta...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1395 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1410 @maskit can you please rebase this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1430: backport f71b75e and 734aa31 from master to 6.2.x
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1430 @shenzhang920 can you rebase this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1406 @jrushford Can you rebase this to 6.2.x? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1430: backport f71b75e and 734aa31 from master to 6.2.x
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1430 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1406 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1434: Clang fixes
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1434: Clang fixes
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/1434 Clang fixes This is a back-port PR of various clang-analyzer fixes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PSUdaemon/trafficserver clang_fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1434.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1434 commit 5dd8bffbb8bb39c4f0fc89e853bab1c747e7d0a9 Author: Bryan Call <bc...@apache.org> Date: 2016-05-25T17:43:46Z TS-4367: Failed clang-analyzer, memory leak in mgmt/api (cherry picked from commit 1cff52240584e5e6dccee63a02ab70ce61a961a2) commit 1ea2edc222fd3e65bca61a6afc2555d86ba24b6d Author: Gancho Tenev <gtte...@gmail.com> Date: 2016-04-26T19:30:24Z TS-4366 Uninitialized stack value used in mp4 plugin It is possible that there are cases where IOBufferReaderCopy() does not modify the input buffer (copy 0 bytes) which leaves the buffer uninitialized which is undesirable since the buffers are always allocated on the stack. Addressed it in one of 2 ways: (1) memset(buffer, 0, sizeof(buffer)) or (2) check IOBufferReaderCopy() return value and handle accordingly. These changes are meant to only address using uninitialized values allocated on the stack, avoiding bigger changes since regression tests are not available to properly verify functionality. This closes #656 (cherry picked from commit 77bd40ba19f29b11873c1709485b64840d137dde) Conflicts: plugins/experimental/mp4/mp4_meta.cc commit a15bbe1bb7c1358f7b709b32a4c810b49e3d1ad5 Author: Bryan Call <bc...@apache.org> Date: 2016-05-26T17:15:51Z TS-4479: Clang-analyzer failure, Potential memory leak (cherry picked from commit 87d1fc5d17d82ebb8f06f4138ca82b6e3b57179c) commit 9ab713edd958db3f02526664423a7e4894ffa567 Author: James Peach <jpe...@apache.org> Date: 2016-06-21T00:21:17Z Remove dead store. (cherry picked from commit 67efb389b890919237248ed437c7af1d01559bf1) commit d5b6a5f1d393cb1541004de3c8368dbffb8f02ab Author: shinrich <shinr...@ieee.org> Date: 2016-08-10T20:00:43Z TS-4729: Fix dead assignment. (cherry picked from commit 29bc28a713463eb815524a91e03be95fe3aeedb1) Conflicts: proxy/http2/Http2Stream.cc proxy/http2/Http2Stream.h --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1293: TS-5059: SSL_set_rbio() renamed SSL_set0_rbio()
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1293 Yes, it's essentially the same build process, it just catches bad commits from getting into the tree instead of fixing them afterward. Makes things like `git bisect` work better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1293: TS-5059: SSL_set_rbio() renamed SSL_set0_rbio()
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1293 No, that is correct. Though I noticed that CI never properly ran. We usually make sure that runs successfully before merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1294#discussion_r94471863
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -27,13 +27,26 @@
#include "BIO_fastopen.h"
+#if OPENSSL_VERSION_NUMBER < 0x1010L
+#define BIO_set_data(a, ptr) ((a)->ptr = (ptr))
+#define BIO_get_data(a) ((a)->ptr)
+#define BIO_set_init(a, init) ((a)->init = (init))
+#define BIO_set_shutdown(a, shut) ((a)->shutdown = (shut))
+#define BIO_get_shutdown(a) ((a)->shutdown)
+#endif
+
+struct Data {
--- End diff --
I'm not picky. Something like `BIOData` would be fine with me, just to
remind people what it is when looking at it in the code. I'm sure someone else
might have a better idea. Perhaps @shinrich, @SolidWallOfCode, or @jpeach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1294#discussion_r94472934
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -27,13 +27,26 @@
#include "BIO_fastopen.h"
+#if OPENSSL_VERSION_NUMBER < 0x1010L
+#define BIO_set_data(a, ptr) ((a)->ptr = (ptr))
+#define BIO_get_data(a) ((a)->ptr)
+#define BIO_set_init(a, init) ((a)->init = (init))
+#define BIO_set_shutdown(a, shut) ((a)->shutdown = (shut))
+#define BIO_get_shutdown(a) ((a)->shutdown)
+#endif
+
+struct Data {
+ Data() : fd(NO_FD), dst(nullptr) {}
+ int fd;
+ const sockaddr *dst;
+};
+
static int
fastopen_create(BIO *bio)
{
- bio->init = 0;
- bio->num = NO_FD;
- bio->flags = 0;
- bio->ptr = nullptr;
+ Data *data = new Data;
--- End diff --
TBH, I am a bit confused by the original code. For example, why was
`fastopen_create` called in `fastopen_destroy`? Then why did you remove that?
It also seems like we were previously overloading these values in the `BIO`
struct out of convenience, and maybe we can just use a pointer to an existing
data structure? I'm not really familiar with how these BIO's were meant to be
used before or not.
It looks like @jpeach wrote this code originally so maybe it'd be good for
him to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1295: TS-5059: OpenSSL 1.1 EVP_MD_CTX and HMAC_CTX
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1295 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1294 [approve ci] @zwoop shouldn't these be auto-running the CI for @jablko? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1293: TS-5059: SSL_set_rbio() renamed SSL_set0_rbio()
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1293 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1294#discussion_r94357370
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -27,13 +27,26 @@
#include "BIO_fastopen.h"
+#if OPENSSL_VERSION_NUMBER < 0x1010L
+#define BIO_set_data(a, ptr) ((a)->ptr = (ptr))
+#define BIO_get_data(a) ((a)->ptr)
+#define BIO_set_init(a, init) ((a)->init = (init))
+#define BIO_set_shutdown(a, shut) ((a)->shutdown = (shut))
+#define BIO_get_shutdown(a) ((a)->shutdown)
+#endif
+
+struct Data {
--- End diff --
Don't mean to bike shed, but this seems like we could have a better name
for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1050: TS-4897: Unbound growth of number of memor...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1050 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1050: TS-4897: Unbound growth of number of memory maps ...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1050 We feel this has been solved by #1097. Please open a new PR if you feel this is not the case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/981 What was the underlying OS? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/981 I'll try to rebase this soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #981: TS-4821: Make hwloc a required dependency
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/981 @jpeach can you elaborate on which platform it was that didn't have hwloc? If not, we are going to try to get this in still. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #966: TS-4026: Remove Clustering
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/966 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #776: TS-4553: Brotli plugin
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/776 @caricaturecm Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1266: TS-5087: Updates the AL2 license on all .p...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1266: TS-5087: Updates the AL2 license on all .p...
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/1266 TS-5087: Updates the AL2 license on all .po files Fixes for 6.2.x branch that were not upstream. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PSUdaemon/trafficserver rat-fixes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1266.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1266 commit ce4a5600d4b219632909bca2e7bdda6dfa774603 Author: Phil Sorber <sor...@apache.org> Date: 2016-12-15T17:32:10Z TS-5087: Updates the AL2 license on all .po files Fixes for 6.2.x branch that were not upstream. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1265: TS-5087: Updates the AL2 license on all .p...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1265 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1244: TS-5076: Test and set the in_enabled_list ...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1258: TS-5089: Add money_trace plugin.
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1258 @jpeach, that doesn't sound like a bad idea, but I don't think it should be a requirement to get this in. The Comcast implementation is entirely open source as well, so this isn't a plugin that only Comcast can use. https://github.com/Comcast/money --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1242: TS-5060: Switch to NS_MAXDNAME
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1242 I followed this into a rat hole trying to do it the right way. Seems like an #ifdef hack is the best option at this point. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1242: TS-5060: Switch to NS_MAXDNAME
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1242 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1242: TS-5060: Switch to NS_MAXDNAME
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/1242 TS-5060: Switch to NS_MAXDNAME This is a followup to #1241 that fixes a compile issue on OSX. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PSUdaemon/trafficserver fix_maxdname Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1242.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1242 commit d3b0193d32079712e7494c976e67f2792856ce51 Author: Phil Sorber <sor...@apache.org> Date: 2016-12-02T16:51:10Z TS-5060: Switch to NS_MAXDNAME --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1050: TS-4897: Unbound growth of number of memory maps ...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1050 @zwoop: #1097 addresses it as best I think we can. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1050: TS-4897: Unbound growth of number of memory maps ...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1050 Should we close this now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1236: TS-5067 Fix required action for http2.enab...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1236 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1241: TS-5060: Add support for DNAME record type...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1241 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1241: TS-5060: Add support for DNAME record type.
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1241 I'd squash these commits, but this looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1221: TS-5046: Guard against the server_session server_...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1221 Ok, sounds good. I'll hold off on cutting 6.2.1 for a bit longer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1221: TS-5046: Guard against the server_session server_...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1221 Do we still need this now that #1232 is merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1232: TS-4938: Avoid crashes due to NULL vc dere...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1232: TS-4938: Avoid crashes due to NULL vc dereference...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1232 [approve ci] @shinrich can you give this a look over and check to see if you think it looks ok as a backport? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1231: TS-4720 back port
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1231: TS-4720 back port
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/1231 TS-4720 back port HttpTransact defaults content length to `-1`, meaning that if the request has no content length header it will be `-1`. These checks weren't taking that into consideration -- meaning client aborts during requests with no content length (GET for example) would leave the origin session open until another timeout kicked in. (cherry picked from commit a075556602d77d79f5a02e2a36053abfa92703f0) You can merge this pull request into a Git repository by running: $ git pull https://github.com/PSUdaemon/trafficserver ts-4720-cp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1231.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1231 commit a17b851427696aa40b3ade46d66a1235f6bef9f9 Author: Thomas Jackson <jacksontj...@gmail.com> Date: 2016-08-05T00:55:59Z TS-4720 correctly check if requests have a body HttpTransact defaults content length to `-1`, meaning that if the request has no content length header it will be `-1`. These checks weren't taking that into consideration -- meaning client aborts during requests with no content length (GET for example) would leave the origin session open until another timeout kicked in. (cherry picked from commit a075556602d77d79f5a02e2a36053abfa92703f0) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1215: TS-5027: Replace readdir_r with readdir.
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1213: TS-4728 Null pointer error in LogHost.cc (...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1208: TS-4514: Transaction hangs when no_dns_jus...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1208 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1213: TS-4728 Null pointer error in LogHost.cc (backpor...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1213 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1215: TS-5027: Replace readdir_r with readdir.
Github user PSUdaemon commented on the issue:
https://github.com/apache/trafficserver/pull/1215
@zwoop & @jpeach - can you guys give this a thumbs up if it looks like I
did the backport correctly? Mostly `nullptr` and `{}` that was providing
conflicts.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1215: TS-5027: Replace readdir_r with readdir.
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/1215 TS-5027: Replace readdir_r with readdir. Glibc deprecated readdir_r(3), so replace it with readdir(3). We were already using readdir(3) in many places so this is just accepting the inevitable. (cherry picked from commit 25b16f763267546c0585fb15f43da4a7803ac984) Conflicts: mgmt/FileManager.cc mgmt/MultiFile.cc mgmt/Rollback.cc mgmt/WebMgmtUtils.cc proxy/http/HttpBodyFactory.cc proxy/logging/LogConfig.cc You can merge this pull request into a Git repository by running: $ git pull https://github.com/PSUdaemon/trafficserver ts-5027-bp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1215.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1215 commit 94708ff7ad1b4fe74d6f37b47d3d298e3e926c26 Author: James Peach <jpe...@apache.org> Date: 2016-11-03T04:30:47Z TS-5027: Replace readdir_r with readdir. Glibc deprecated readdir_r(3), so replace it with readdir(3). We were already using readdir(3) in many places so this is just accepting the inevitable. (cherry picked from commit 25b16f763267546c0585fb15f43da4a7803ac984) Conflicts: mgmt/FileManager.cc mgmt/MultiFile.cc mgmt/Rollback.cc mgmt/WebMgmtUtils.cc proxy/http/HttpBodyFactory.cc proxy/logging/LogConfig.cc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1205: TS-4879: NetVC leaks while hyper emergency...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1205 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1204: TS-4885: Correct the calculation of fds_th...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1203: TS-2482: Should use target_addr instead of...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1200: TS-4697: Free MIOBuffer if the ipallow che...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1199: TS-4614: avoid e->schedule_in for dummy ev...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1199 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1206: TS-4838: CONNECT requests get forgotten ac...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1206 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1206: TS-4838: CONNECT requests get forgotten ac...
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/1206 TS-4838: CONNECT requests get forgotten across threads. What happens here is that ProxyClientTransaction::adjust_thread reschedules the transaction onto a new thread at the start of HttpSM::do_http_server_open. Unfortunately, at this point the default handler is HttpSM::state_raw_http_server_open. When the transaction is rescheduled, the default handler runs, and receives the EVENT_INTERVAL that it so fortuitously logs an error for. We have never actually completed do_http_server_open, so we never make any more progress on this transaction. (cherry picked from commit 8fddd77c085d1a64f11de61bb42a50562cd23229) You can merge this pull request into a Git repository by running: $ git pull https://github.com/PSUdaemon/trafficserver bp-1002 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1206 commit c5ab2e686ac0dad4ebe89573cdcc0b2d2a6359a4 Author: James Peach <jpe...@apache.org> Date: 2016-09-09T22:29:05Z TS-4838: CONNECT requests get forgotten across threads. What happens here is that ProxyClientTransaction::adjust_thread reschedules the transaction onto a new thread at the start of HttpSM::do_http_server_open. Unfortunately, at this point the default handler is HttpSM::state_raw_http_server_open. When the transaction is rescheduled, the default handler runs, and receives the EVENT_INTERVAL that it so fortuitously logs an error for. We have never actually completed do_http_server_open, so we never make any more progress on this transaction. (cherry picked from commit 8fddd77c085d1a64f11de61bb42a50562cd23229) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1200: TS-4697: Free MIOBuffer if the ipallow check fail...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1200 I mean don't add `(backport for 6.2.x)` to the existing commit message. It's superfluous. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1200: TS-4697: Free MIOBuffer if the ipallow check fail...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1200 When you do the backports can you leave the commit messages the same except for the cherry pick comment and the conflicts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1198: Add failcount and threshold values in parent sele...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1198 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1189: Backport TS-4537, TS-4605, TS-4953, and TS...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1183: TS-4724: Added new server_request APIs to ...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1196: TS-4217: Change stream state after sending...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1195: TS-4934: Remove invalid assert
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1194: TS-4905: Set parent NULL after destroy() i...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1091: TS-4952: Improve abort messages for mutex failure...
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/1091 @jpeach you planning on doing any more with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1182: TS-4911: ts_lua plugin is modified to clea...
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1188: TS-4717: Http2 stack explosion.
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/1188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
