[GitHub] trafficserver issue #1365: TS-4896: TSHttp***ClientAddrGet/TSHttp***Incoming...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1365 Nit picky, and too late, but I kinda wish these two new variables would have been named "saved_XXX" instead of "cached_XXX". Cached make it sounds like it's an optimization of some sort, but as far as I can tell, this is to save way the IP addresses since the VC goes away. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1393: Trivial Autoconf cleanup
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1393 Nice catch on AC_SEARCH_LIBS! Question, i wonder if we do this wrong in other places? Are we adding things to LIBS when we shouldn't? There are several places where we do things like: ``` AC_SEARCH_LIBS([lzma_code], [lzma], [lzma_have_libs=1]) if test "$lzma_have_libs" != "0"; then AC_CHECK_HEADERS(lzma.h, [lzma_have_headers=1]) fi if test "$lzma_have_headers" != "0"; then AC_SUBST(LIBLZMA, [-llzma]) else enable_lzma=no CPPFLAGS=$saved_cppflags LDFLAGS=$saved_ldflags fi ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1395: Update client streams count in Http2ConnectionSta...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1395 Giving to @PSUdaemon, this is for him to consider for backport. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1386: ATS hangs, possibly because of OpenSSL 1.1.0
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1386 ATS hangs, possibly because of OpenSSL 1.1.0 Seeing very, very deep stack traces, like ``` ... #1602 0x00792a94 in ssl_rm_cached_session (ctx=0x2b6b0bd23400, sess=0x2b6b0f468600) at SSLUtils.cc:284 #1603 0x2b6b08b4d1da in SSL_CTX_remove_session () from /opt/openssl/lib/libssl.so.1.1 #1604 0x00792a94 in ssl_rm_cached_session (ctx=0x2b6b0bd23400, sess=0x2b6b0f468600) at SSLUtils.cc:284 #1605 0x2b6b08b4d1da in SSL_CTX_remove_session () from /opt/openssl/lib/libssl.so.1.1 #1606 0x00792a94 in ssl_rm_cached_session (ctx=0x2b6b0bd23400, sess=0x2b6b0f468600) at SSLUtils.cc:284 #1607 0x2b6b08b4d1da in SSL_CTX_remove_session () from /opt/openssl/lib/libssl.so.1.1 #1608 0x00792a94 in ssl_rm_cached_session (ctx=0x2b6b0bd23400, sess=0x2b6b0f468600) at SSLUtils.cc:284 #1609 0x2b6b08b4d1da in SSL_CTX_remove_session () from /opt/openssl/lib/libssl.so.1.1 #1610 0x00792a94 in ssl_rm_cached_session (ctx=0x2b6b0bd23400, sess=0x2b6b0f468600) at SSLUtils.cc:284 #1611 0x2b6b08b4d1da in SSL_CTX_remove_session () from /opt/openssl/lib/libssl.so.1.1 #1612 0x00792a94 in ssl_rm_cached_session (ctx=0x2b6b0bd23400, sess=0x2b6b0f468600) at SSLUtils.cc:284 ... ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1385: sslheaders plugin fails with OpenSSL v1.1.0d
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1385
sslheaders plugin fails with OpenSSL v1.1.0d
```
CXX
experimental/sslheaders/experimental_sslheaders_libsslhdr_la-expand.lo
experimental/sslheaders/expand.cc: In function 'void
x509_expand_signature(X509*, BIO*)':
experimental/sslheaders/expand.cc:73:30: error: invalid use of incomplete
type 'X509 {aka struct x509_st}'
ASN1_BIT_STRING *sig = x509->signature;
^
In file included from experimental/sslheaders/expand.cc:19:0:
experimental/sslheaders/sslheaders.h:26:16: note: forward declaration of
'X509 {aka struct x509_st}'
typedef struct x509_st X509;
^
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1384: Warnings when compiling against OpenSSL 1.1.0d
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1384 Warnings when compiling against OpenSSL 1.1.0d ``` SSLUtils.cc: In function âvoid SSLInitializeLibrary()â: SSLUtils.cc:863:57: warning: statement has no effect [-Wunused-value] CRYPTO_THREADID_set_callback(SSL_pthreads_thread_id); ^ In file included from ../../lib/ts/SimpleTokenizer.h:30:0, from SSLUtils.cc:23: SSLUtils.cc: In function âchar* asn1_strdup(ASN1_STRING*)â: SSLUtils.cc:1344:36: warning: âunsigned char* ASN1_STRING_data(ASN1_STRING*)â is deprecated [-Wdeprecated-declarations] return ats_strndup((const char *)ASN1_STRING_data(s), ASN1_STRING_length(s)); ^ ../../lib/ts/ink_memory.h:123:37: note: in definition of macro âats_strndupâ #define ats_strndup(p, n) _xstrdup((p), n, nullptr) ^ In file included from /opt/openssl/include/openssl/bn.h:31:0, from /opt/openssl/include/openssl/asn1.h:24, from /opt/openssl/include/openssl/objects.h:916, from /opt/openssl/include/openssl/evp.h:27, from /opt/openssl/include/openssl/x509.h:23, from /opt/openssl/include/openssl/ssl.h:50, from P_SSLNetVConnection.h:41, from P_Net.h:106, from SSLUtils.cc:26: /opt/openssl/include/openssl/asn1.h:553:35: note: declared here DEPRECATEDIN_1_1_0(unsigned char *ASN1_STRING_data(ASN1_STRING *x)) ^ /opt/openssl/include/openssl/opensslconf.h:102:35: note: in definition of macro âDECLARE_DEPRECATEDâ # define DECLARE_DEPRECATED(f)f __attribute__ ((deprecated)); ^ /opt/openssl/include/openssl/asn1.h:553:1: note: in expansion of macro âDEPRECATEDIN_1_1_0â DEPRECATEDIN_1_1_0(unsigned char *ASN1_STRING_data(ASN1_STRING *x)) ^ In file included from ../../lib/ts/SimpleTokenizer.h:30:0, from SSLUtils.cc:23: SSLUtils.cc:1344:36: warning: âunsigned char* ASN1_STRING_data(ASN1_STRING*)â is deprecated [-Wdeprecated-declarations] return ats_strndup((const char *)ASN1_STRING_data(s), ASN1_STRING_length(s)); ^ ../../lib/ts/ink_memory.h:123:37: note: in definition of macro âats_strndupâ #define ats_strndup(p, n) _xstrdup((p), n, nullptr) ^ In file included from /opt/openssl/include/openssl/bn.h:31:0, from /opt/openssl/include/openssl/asn1.h:24, from /opt/openssl/include/openssl/objects.h:916, from /opt/openssl/include/openssl/evp.h:27, from /opt/openssl/include/openssl/x509.h:23, from /opt/openssl/include/openssl/ssl.h:50, from P_SSLNetVConnection.h:41, from P_Net.h:106, from SSLUtils.cc:26: /opt/openssl/include/openssl/asn1.h:553:35: note: declared here DEPRECATEDIN_1_1_0(unsigned char *ASN1_STRING_data(ASN1_STRING *x)) ^ /opt/openssl/include/openssl/opensslconf.h:102:35: note: in definition of macro âDECLARE_DEPRECATEDâ # define DECLARE_DEPRECATED(f)f __attribute__ ((deprecated)); ^ /opt/openssl/include/openssl/asn1.h:553:1: note: in expansion of macro âDEPRECATEDIN_1_1_0â DEPRECATEDIN_1_1_0(unsigned char *ASN1_STRING_data(ASN1_STRING *x)) ^ In file included from ../../lib/ts/SimpleTokenizer.h:30:0, from SSLUtils.cc:23: SSLUtils.cc:1344:54: warning: âunsigned char* ASN1_STRING_data(ASN1_STRING*)â is deprecated [-Wdeprecated-declarations] return ats_strndup((const char *)ASN1_STRING_data(s), ASN1_STRING_length(s)); ^ ../../lib/ts/ink_memory.h:123:37: note: in definition of macro âats_strndupâ #define ats_strndup(p, n) _xstrdup((p), n, nullptr) ^ In file included from /opt/openssl/include/openssl/bn.h:31:0, from /opt/openssl/include/openssl/asn1.h:24, from /opt/openssl/include/openssl/objects.h:916, from /opt/openssl/include/openssl/evp.h:27, from /opt/openssl/include/openssl/x509.h:23, from /opt/openssl/include/openssl/ssl.h:50, from P_SSLNetVConnection.h:41, from P_Net.h:106, from SSLUtils.cc:26: /opt/openssl/include/openssl/asn1.h:553:35: note: declared here
[GitHub] trafficserver pull request #1383: This fixes build problems when using non-s...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1383: This fixes build problems when using non-s...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1383 This fixes build problems when using non-standard OpenSSL You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver Fix40310af Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1383.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1383 commit 42609c506446c0348461486fde1cae6f387ba768 Author: Leif Hedstrom Date: 2017-01-27T19:51:28Z This fixes build problems when using non-standard OpenSSL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1382: TS-993: OpenBSD sbindir should be ${exec_prefix}/...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1382 Ah wth, it seems safe, cherry-picking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1313: Use Autoconf checks vs. OPENSSL_VERSION_NUMBER
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1313 Cherry-picked to 7.1.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1382: TS-993: OpenBSD sbindir should be ${exec_prefix}/...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1382 You want this for 7.1.x? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1313: Use Autoconf checks vs. OPENSSL_VERSION_NUMBER
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1313 You need this for 7.1.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1378: 7.1.x TS-5107: Changes to autolinking in D...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1378 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1378 I saw what happened, the reverts makes sense now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1368: Issue #1367: HdrHeap potential corruption
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1368 @maskit @shinrich ping? Should we back port to 7.1.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1380: Fixed issue where somaxconn was being set to 0 on...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1380 ink_inet.cc:613:10: error: unused variable 'value_size' [-Werror=unused-variable] size_t value_size = sizeof(value); --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1368: Issue #1367: HdrHeap potential corruption
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1368 @shinrich Should we cherry-pick this back to 7.1.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1375: Incorrectly freeing Http1ClientSession setting up...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1375 Is this a 7.1.x candidate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1378 Also, please remember to add Milestone, Label's etc. on each Issue / PR, otherwise @bryancall gets all pissy. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1378: 7.1.x TS-5107: Changes to autolinking in Docutils...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1378 Why are there 4 commits on this? Can you squash those? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1303 This doesn't merge cleanly into 7.1.x branch (conflicts on the python script). @jablko Can you make a new PR, for the 7.1.x branch please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1374: Fix CID 1369398: Null pointer dereferences
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1374 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1303 Status on this? is thing going to land for 7.1.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1357 @shinrich @SolidWallOfCode Is this landing for 7.1.x? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1350: TS-5080: log when remap.config is successf...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1350 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1328: Replace gethostbyname_r() with getaddrinfo()
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1328 Are you guys comfortable with cherry-picking this to 7.1.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1355: TS-4716: OpenBSD mandir should be ${prefix}/man
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1355 Question: Why is this PR also modifying the Debian layout? That seems slightly non-intuitive considering the Summary from the PR (OpenBSD). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1350: TS-5080: log when remap.config is successfully re...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1350 Seems FreeBSD / clang is finicky on one of the strings. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1366: Issue #1360: REGRESSION_TEST(SDK_API_OVERRIDABLE_...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1366 7.1.0 candidate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1355: TS-4716: OpenBSD mandir should be ${prefix}/man
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1355 I'm marking this for 7.1.0, since it's mostly benign, and generally useful. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1364: Issue #1359: Flaw in TS-2157 port in server addre...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1364 Is this a 7.1.0 back port candidate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1357 This has to go into 7.1.0 as well, since we already landed previous tries :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1350: TS-5080: log when remap.config is successfully re...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1350 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1350: TS-5080: log when remap.config is successfully re...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1350 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1349: TS-5079: logging enhancements around OCSP
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1349 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1336: cache promote plugin takes too much calculating s...
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1336 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1337: This avoids some badness around some STL i...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1352: Documentation for volume.config is confusing and ...
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1352 Documentation for volume.config is confusing and obsolete In particular, the example with scheme=http / scheme=https is invalid, there's only one protocol that's supported, http (for all HTTP versions). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1327: get_creation_time() takes *time_t, not *long
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1327 Merged this to the 7.1.x branch as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1347: TS-5022: nullptr check
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1347 Merged this to the 7.1.x branch as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1343: Change connect_attempts_rr_retries test to match ...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1343 Merged this to the 7.1.x branch as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1334: Do not reschedule the periodic inactive_event and...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1334 Merged this to the 7.1.x branch as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1332 As we discussed, this ought to go into the "cmd" directory, and renamed traffic_cachetool or some such. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1340: new warning running 7.1
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1340 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1343: Change connect_attempts_rr_retries test to...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1343: Change connect_attempts_rr_retries test to match ...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1343 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1341: openssl errors for every request
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1341
Looking at 63b924e8, it seems we produce this error, and do these expensive
lookups / additions on every request?
```C++
@@ -4018,7 +4020,7 @@ HttpSM::do_remap_request(bool run_inline)
{
DebugSM("http_seq", "[HttpSM::do_remap_request] Remapping request");
DebugSM("url_rewrite", "Starting a possible remapping for request [%"
PRId64 "]", sm_id);
-
+ SSLConfig::scoped_config params;
bool ret = false;
if (t_state.cop_test_page == false) {
ret = remapProcessor.setup_for_remap(&t_state);
@@ -4059,6 +4061,16 @@ HttpSM::do_remap_request(bool run_inline)
pending_action = remap_action_handle;
}
+ // check if the overridden client cert filename is already attached to
an existing ssl context
+ ats_scoped_str
clientCert(Layout::relative_to(t_state.txn_conf->client_cert_filepath,
t_state.txn_conf->client_cert_filename));
+ auto tCTX = params->getCTX(clientCert);
+
+ if (tCTX == nullptr) {
+// make new client ctx and add it to the ctx list
+auto tctx = params->getNewCTX(clientCert);
+params->InsertCTX(clientCert, tctx);
+ }
+
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 Not going to do the reverts here, but please be careful going forward with squashing commits that are fixes / review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1339: Revert "Modify TSHttpTxnHookAdd to add hoo...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1339: Revert "Modify TSHttpTxnHookAdd to add hoo...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1339 Revert "Modify TSHttpTxnHookAdd to add hook only once" Reverts apache/trafficserver#1320 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/trafficserver revert-1320-TS-5024 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1339.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1339 commit 833f176b60ca24a6c98d6019306b3cb93e705285 Author: Leif Hedstrom Date: 2017-01-18T22:36:52Z Revert "Modify TSHttpTxnHookAdd to add hook only once" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1338: Revert "Modify TSHttpTxnHookAdd to add hoo...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1338 Revert "Modify TSHttpTxnHookAdd to add hook only once" Reverts apache/trafficserver#1320 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/trafficserver revert-1320-TS-5024 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1338.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1338 commit 833f176b60ca24a6c98d6019306b3cb93e705285 Author: Leif Hedstrom Date: 2017-01-18T22:36:52Z Revert "Modify TSHttpTxnHookAdd to add hook only once" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1338: Revert "Modify TSHttpTxnHookAdd to add hoo...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 Well, dammit, I screwed up, this really shouldn't have been merged, you really must squash multiple commits like this into one commit (now I landed one commit that is not correct). :-/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1320: Modify TSHttpTxnHookAdd to add hook only o...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1320 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1337: This avoids some badness around some STL i...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1337 This avoids some badness around some STL implementations Where the complexity of ::size is not O(1) Can someone please carefully review that I did the ++'s and --'s in all the right places? This fixes #1336. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver #1336 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1337.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1337 commit 11d7789a0522568598a76782aae140db641764aa Author: Leif Hedstrom Date: 2017-01-18T20:02:44Z This avoids some badness around some STL implementations, where the complexity of ::size is not O(1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1335: Deadlock in HostDB
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1335 Deadlock in HostDB We have some 7.0.0 boxes, which ends up completely wedged, where all ET_NET threads get stuck on the same lock (so, a deadlock): ``` #6 HostDBProcessor::getbyname_imm (this=, cont=cont@entry=0x2ab037b1d420, process_hostdb_info=, hostname=, len=, opt=...) at HostDB.cc:816 #6 HostDBProcessor::getbyname_imm (this=, cont=cont@entry=0x2aabc1e66a00, process_hostdb_info=, hostname=, len=, opt=...) at HostDB.cc:816 ... ``` The trace is always the same in every thread: ``` #0 __lll_lock_wait () at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:136 #1 0x2d73e5d8 in _L_lock_854 () from /lib64/libpthread.so.0 #2 0x2d73e4a7 in __pthread_mutex_lock (mutex=0x2aaab098a290) at pthread_mutex_lock.c:61 #3 0x2adca986 in ink_mutex_acquire (m=0x2aaab098a290) at ../../lib/ts/ink_mutex.h:90 #4 Mutex_lock (t=0x2aaab160db40, m=0x2aaab098a280) at ../../iocore/eventsystem/I_Lock.h:410 #5 MutexLock::MutexLock (t=0x2aaab160db40, am=0x2aaab098a280, this=0x2aaab470a890) at ../../iocore/eventsystem/I_Lock.h:497 #6 HostDBProcessor::getbyname_imm (this=, cont=cont@entry=0x2aab91432580, process_hostdb_info=, hostname=, len=, opt=...) at HostDB.cc:816 #7 0x2acae21c in HttpSM::do_hostdb_lookup (this=this@entry=0x2aab91432580) at HttpSM.cc:4133 #8 0x2acc0093 in HttpSM::set_next_state (this=0x2aab91432580) at HttpSM.cc:7248 #9 0x2acad47a in HttpSM::call_transact_and_set_next_state (this=this@entry=0x2aab91432580, f=f@entry=0x0) at HttpSM.cc:7111 #10 0x2acb7baf in HttpSM::handle_api_return (this=0x2aab91432580) at HttpSM.cc:1604 #11 0x2acba5eb in HttpSM::state_api_callout (this=0x2aab91432580, event=0, data=0x0) at HttpSM.cc:1542 #12 0x2acbf62b in HttpSM::set_next_state (this=0x2aab91432580) at HttpSM.cc:7144 #13 0x2acad47a in HttpSM::call_transact_and_set_next_state (this=this@entry=0x2aab91432580, f=f@entry=0x0) at HttpSM.cc:7111 #14 0x2acb9910 in HttpSM::state_hostdb_lookup (this=0x2aab91432580, event=500, data=0x2aebe3144800) at HttpSM.cc:2217 #15 0x2acc165d in HttpSM::main_handler (this=0x2aab91432580, event=500, data=0x2aebe3144800) at HttpSM.cc:2661 #16 0x2adc7f37 in Continuation::handleEvent (data=0x2aebe3144800, event=500, this=0x2aab91432580) at ../../iocore/eventsystem/I_Continuation.h:153 #17 reply_to_cont (cont=0x2aab91432580, r=0x2aebe3144800, is_srv=) at HostDB.cc:474 #18 0x2adcc79d in HostDBContinuation::dnsEvent (this=, event=, e=) at HostDB.cc:1450 #19 0x2ade3821 in Continuation::handleEvent (data=, event=600, this=) at ../../iocore/eventsystem/I_Continuation.h:153 #20 DNSEntry::postEvent (this=this@entry=0x2aaab76b4e00) at DNS.cc:1269 #21 0x2ade880b in dns_result (h=h@entry=0x2aaabafc9ec0, e=e@entry=0x2aaab76b4e00, ent=, ent@entry=0x2aaaee3aa440, retry=retry@entry=false) at DNS.cc:1221 #22 0x2adeb189 in dns_process (len=, buf=0x2aaaee3aa440, handler=0x2aaabafc9ec0) at DNS.cc:1587 #23 DNSHandler::recv_dns (this=this@entry=0x2aaabafc9ec0) at DNS.cc:782 #24 0x2adebac9 in DNSHandler::mainEvent (this=0x2aaabafc9ec0, event=, e=) at DNS.cc:794 #25 0x2af0758e in Continuation::handleEvent (data=0x2aaab1788980, event=5, this=) at I_Continuation.h:153 #26 EThread::process_event (calling_code=5, e=0x2aaab1788980, this=0x2aaab160db40) at UnixEThread.cc:143 #27 EThread::execute (this=0x2aaab160db40) at UnixEThread.cc:270 #28 0x2af06136 in spawn_thread_internal (a=0x2aaab09981f0) at Thread.cc:84 #29 0x2d73caa1 in start_thread (arg=0x2aaab470c700) at pthread_create.c:301 #30 0x2e5f393d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:115 ``` We're not sure if this relates to HostDB sync or not, but the boxes we encountered this on, did have syncing on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 @meeramn Can you re-run clang-format and update the PR please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1323: NULL in records.config being interpreted as a str...
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1325: #1323 Restores the NULL string where appro...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1325: #1323 Restores the NULL string where appro...
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1325#discussion_r96107247
--- Diff: lib/records/RecUtils.cc ---
@@ -419,7 +419,7 @@ RecDataSetFromString(RecDataT data_type, RecData
*data_dst, const char *data_str
data_src.rec_float = atof(data_string);
break;
case RECD_STRING:
-if (data_string && strcmp((data_string), "nullptr") == 0) {
+if (data_string && (strlen(data_string) == 4) &&
strncmp((data_string), "NULL", 4) == 0) {
--- End diff --
Because amc wanted me to use strncmp(), so if you don't check the length,
then it'd also match any string starting with NULL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1325: #1323 Restores the NULL string where appropriate
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1325 Any takers on reviewing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1326: Core dump in SSLAccept / SSLNetVConnection::sslSe...
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1326 Core dump in SSLAccept / SSLNetVConnection::sslServerHandShakeEvent We (@randall) ran into an odd crashes that seems fairly similar (but not identical) to https://issues.apache.org/jira/browse/TS-4363. Since Jira is now read-only, I'm opening this up here as a new Issue (but, odds are that this is the same as the TS-4363 issue). Backtrace: ``` #0 0x2d74437d in __libc_waitpid (pid=, stat_loc=, options=) at ../sysdeps/unix/sysv/linux/waitpid.c:41 #1 0x2ab83297 in crash_logger_invoke (signo=11, info=0x2aaab610a8f0, ctx=0x2aaab610a7c0) at Crash.cc:164 #2 #3 0x2c715005 in ?? () from /opt/bazinga/lib/libcrypto.so.10 #4 0x2c7155cc in lh_retrieve () from /opt/bazinga/lib/libcrypto.so.10 #5 0x2c672c6f in ?? () from /opt/bazinga/lib/libcrypto.so.10 #6 0x2c67369b in ?? () from /opt/bazinga/lib/libcrypto.so.10 #7 0x2c700247 in DH_new_method () from /opt/bazinga/lib/libcrypto.so.10 #8 0x2c70170e in DHparams_dup () from /opt/bazinga/lib/libcrypto.so.10 #9 0x2c3d717a in ssl_cert_dup () from /opt/bazinga/lib/libssl.so.10 #10 0x2c3d56a4 in SSL_set_SSL_CTX () from /opt/bazinga/lib/libssl.so.10 #11 0x2aea3724 in set_context_cert (ssl=ssl@entry=0x2aea13f9f800) at SSLUtils.cc:361 #12 0x2aea3ad6 in ssl_cert_callback (ssl=0x2aea13f9f800) at SSLUtils.cc:398 #13 0x2c3abd40 in ssl3_get_client_hello () from /opt/bazinga/lib/libssl.so.10 #14 0x2c3b0f3f in ssl3_accept () from /opt/bazinga/lib/libssl.so.10 #15 0x2c3c0230 in ssl23_accept () from /opt/bazinga/lib/libssl.so.10 #16 0x2aeaa383 in SSLAccept (ssl=0x2aea13f9f800) at SSLUtils.cc:2265 #17 0x2ae97a4f in SSLNetVConnection::sslServerHandShakeEvent (this=this@entry=0x2aea3b4c23e0, err=@0x2aaab610b980: 0) at SSLNetVConnection.cc:1068 #18 0x2ae9a058 in SSLNetVConnection::sslServerHandShakeEvent (this=0x2aea3b4c23e0, err=) at SSLNetVConnection.cc:1014 #19 0x2ae9a4c9 in SSLNetVConnection::sslStartHandShake (this=0x2aea3b4c23e0, event=, err=@0x2aaab610b980: 0) at SSLNetVConnection.cc:979 #20 0x2ae9cfc3 in SSLNetVConnection::net_read_io (this=0x2aea3b4c23e0, nh=0x2aaab30116f0, lthread=0x2aaab300d9c0) at SSLNetVConnection.cc:451 #21 0x2aeaf254 in NetHandler::mainNetEvent (this=0x2aaab30116f0, event=, e=) at UnixNet.cc:526 #22 0x2af0758e in Continuation::handleEvent (data=0x2aaab17893a0, event=5, this=) at I_Continuation.h:153 #23 EThread::process_event (calling_code=5, e=0x2aaab17893a0, this=0x2aaab300d9c0) at UnixEThread.cc:143 #24 EThread::execute (this=0x2aaab300d9c0) at UnixEThread.cc:270 #25 0x2af06136 in spawn_thread_internal (a=0x2aaab0998460) at Thread.cc:84 #26 0x2d73caa1 in start_thread (arg=0x2aaab610c700) at pthread_create.c:301 #27 0x2e5f393d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:115 ``` I'm curious if @oknet recognizes this as well? This is running v7.0.0, with a small number of cherry picks: ``` * 0412dec (HEAD -> 7.0.x, origin/7.0.x) TS-5102 parent metrics * cd53220 Fix for: TS-5108-SSL requests might stall because enabled write is ignored * d908dc0 TS-5069: Fixes CID 1366771 and 1366771 * c95d0ff TS-5076: Test and set the in_enabled_list by atomic function * 486cc02 TS-4429: Fixes missing curly brackets with new option * eff5595 TS-4429: Adds a --concise (-C) option for logstats, excludes % metrics ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1320: Modify TSHttpTxnHookAdd to add hook only once
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1320 Marking this for 7.1.0, we really need this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1319: 7.0.x TS-5059: Fixes for building with OpenSSL 1....
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1319 Mr (!) The Oil Rig, ( :-) ) did you check with @bryancall if he's planning a 7.0.1 release? if not, this is a moot point, 7.1.x will hopefully be released in 4 weeks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1324: issue-1323: fix RecDataset
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1324 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver pull request #1325: #1323 Restores the NULL string where appro...
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1325 #1323 Restores the NULL string where appropriate You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver #1323 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1325.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1325 commit 03a69cf56428c284238e17212531d972a3974c7a Author: Leif Hedstrom Date: 2017-01-13T15:30:15Z #1323 Restores the NULL string where appropriate --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1324: issue-1323: fix RecDataset
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1324 Albeit reasonable, I don't think we should land this. There's a number of places from ced4da13279f834c381925f2ecd1649bfb459e8b which changes "NULL" to "nullptr" accidentally, and we should investigate each of those, and revert where appropriate. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1323: NULL in records.config being interpreted as a str...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1323 I think this got broken with ced4da13279f834c381925f2ecd1649bfb459e8b. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1322: Possibly crasher in HostDB serialization (disk sy...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1322 Pretty sure they had been running for a while (several days at least), but let me check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1322: Possibly crasher in HostDB serialization (disk sy...
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1322
Possibly crasher in HostDB serialization (disk sync)
Hi Thomas,
we're seeing this odd looking crash, fairly often:
```
#0 0x2d74337d in __libc_waitpid (pid=,
stat_loc=, options=)
at ../sysdeps/unix/sysv/linux/waitpid.c:41
#1 0x2ab83297 in crash_logger_invoke (signo=11,
info=0x2aaaf20007f0, ctx=0x2aaaf20006c0) at Crash.cc:164
#2
#3 0x in ?? ()
#4 0x2af06270 in Continuation::handleEvent (data=0x2ae608f1b140,
event=1, this=) at I_Continuation.h:153
#5 EThread::process_event (this=0x2aaaf1c0da00, e=0x2ae608f1b140,
calling_code=1) at UnixEThread.cc:143
#6 0x2af0727f in EThread::execute (this=0x2aaaf1c0da00) at
UnixEThread.cc:197
#7 0x2af05ba6 in spawn_thread_internal (a=0x2aaac51fccc0) at
Thread.cc:84
#8 0x2d73baa1 in start_thread (arg=0x2aaaf2001700) at
pthread_create.c:301
#9 0x2e5f293d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:115
```
Not particularly helpful, I know, but in frame #4, Randal found that the
data seems related to the serialization continuation:
```
(gdb) frame 4
#4 0x2af06270 in Continuation::handleEvent (data=0x2ae608f1b140,
event=1, this=) at I_Continuation.h:153
153 I_Continuation.h: No such file or directory.
(gdb) print *((Event*)data).continuation
$1 = { = {_vptr.force_VFPT_to_top = 0x2b1d9670
>+16>},
handler = (int (Continuation::*)(Continuation * const, int,
void *)) 0x2adcf7a0
>::initialize_storage(int,
Event*)>, mutex = {
m_ptr = 0x2aaaf0e46e40}, link = {> = {next = 0x0},
prev = 0x0}, control_flags = {raw_flags = 0}}
```
We're thinking of turning off HostDB sync again to see if that helps, but
let me know if you have any brilliant ideas as to why this would fail here
(unfortunately the above is all we got :-/).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1316: TS-5022: remove goto in SSLConfig : getnew...
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1276 Trying a new build [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1305: CID 1368316 Resource leak
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1305 Closing this as a dupe of #1308, since it has more details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1305: CID 1368316 Resource leak
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1308: CID 1368316 & 1368315: Leaks and NULL references
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1308
CID 1368316 & 1368315: Leaks and NULL references
I think this landed recently (TS-5092?), and we have to fix this for 7.1.x.
clang-analyzer also detects the NULL pointer reference.
```C
** CID 1368316: Resource leaks (RESOURCE_LEAK)
/proxy/http/HttpSM.cc: 5049 in HttpSM::do_http_server_open(bool)()
*** CID 1368316: Resource leaks (RESOURCE_LEAK)
/proxy/http/HttpSM.cc: 5049 in HttpSM::do_http_server_open(bool)()
5043 int len = 0;
5044 const char *host =
t_state.hdr_info.server_request.host_get(&len);
5045 if (host && len > 0) {
5046 opt.set_sni_servername(host, len);
5047 }
5048
CID 1368316: Resource leaks (RESOURCE_LEAK)
Failing to save or free storage allocated by
"Layout::relative_to(this->t_state.txn_conf->client_cert_filepath,
this->t_state.txn_conf->client_cert_filename)" leaks it.
5049 ats_scoped_str clientCert(
5050
ats_strdup((Layout::relative_to(t_state.txn_conf->client_cert_filepath,
t_state.txn_conf->client_cert_filename;
5051 opt.set_client_certname(clientCert);
5052 connect_action_handle = sslNetProcessor.connect_re(this,
// state machine
5053
&t_state.current.server->dst_addr.sa, // addr + port
5054&opt);
** CID 1368315: Null pointer dereferences (FORWARD_NULL)
/proxy/http2/Http2ConnectionState.cc: 217 in
rcv_headers_frame(Http2ConnectionState &, const Http2Frame &)()
*** CID 1368315: Null pointer dereferences (FORWARD_NULL)
/proxy/http2/Http2ConnectionState.cc: 217 in
rcv_headers_frame(Http2ConnectionState &, const Http2Frame &)()
211 if (!stream) {
212 return error;
213 }
214 }
215
216 // keep track of how many bytes we get in the frame
CID 1368315: Null pointer dereferences (FORWARD_NULL)
Dereferencing null pointer "stream".
217 stream->request_header_length += payload_length;
218 if (stream->request_header_length >
Http2::max_request_header_size) {
219 return Http2Error(HTTP2_ERROR_CLASS_STREAM,
HTTP2_ERROR_PROTOCOL_ERROR,
220 "recv headers payload for headers greater
than header length");
221 }
222
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1303 We need into 7.1.x as well, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1306: [openbsd] pthread_np.h needs to be included
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1306 Yeh, I agree with peach, it seems very odd that it's not picking it up properly. It'd be better to fix that, instead of ifdef on openbsd IMO. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1301: Can trafficserver proxy to another proxy?
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1301 This really belongs on the us...@trafficserver.apache.org mailing list. I'm going to close this, but the short answer is that you could use the parent.config instead of remap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1301: Can trafficserver proxy to another proxy?
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1302: CID 1368306 & 1368305: NULLPTR and security BP in...
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1302
CID 1368306 & 1368305: NULLPTR and security BP in logical.cc
```c
** CID 1368306: Security best practices violations (TOCTOU)
/proxy/logcat.cc: 299 in main()
*** CID 1368306: Security best practices violations (TOCTOU)
/proxy/logcat.cc: 299 in main()
293
294 if (n_file_arguments) {
295 int bin_ext_len =
strlen(LOG_FILE_BINARY_OBJECT_FILENAME_EXTENSION);
296 int ascii_ext_len =
strlen(LOG_FILE_ASCII_OBJECT_FILENAME_EXTENSION);
297
298 for (unsigned i = 0; i < n_file_arguments; ++i) {
CID 1368306: Security best practices violations (TOCTOU)
Calling function "open" that uses "file_arguments[i]" after a check
function. This can cause a time-of-check, time-of-use race condition.
299 int in_fd = open(file_arguments[i], O_RDONLY);
300 if (in_fd < 0) {
301 fprintf(stderr, "Error opening input file %s: ",
file_arguments[i]);
302 perror(0);
303 error = DATA_PROCESSING_ERROR;
304 } else {
** CID 1368305: Null pointer dereferences (REVERSE_INULL)
/plugins/experimental/money_trace/money_trace.cc: 129 in
mt_check_request_header(tsapi_httptxn *)()
*** CID 1368305: Null pointer dereferences (REVERSE_INULL)
/plugins/experimental/money_trace/money_trace.cc: 129 in
mt_check_request_header(tsapi_httptxn *)()
123 txn_data =
allocTransactionData();
124 txn_data->client_request_mt_header =
TSstrndup(hdr_value, length);
125 txn_data->client_request_mt_header[length] = '\0'; //
workaround for bug in core.
126 LOG_DEBUG("found money trace header: %s, length: %d",
txn_data->client_request_mt_header, length);
127 if (nullptr == (contp = TSContCreate(transaction_handler,
nullptr))) {
128 LOG_ERROR("failed to create the transaction handler
continuation");
CID 1368305: Null pointer dereferences (REVERSE_INULL)
Null-checking "txn_data" suggests that it may be null, but it has
already been dereferenced on all paths leading to the check.
129 if (nullptr != txn_data) {
130 TSfree(txn_data->client_request_mt_header);
131 TSfree(txn_data);
132 }
133 } else {
134 TSContDataSet(contp, txn_data);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1257: TS-5053 const char **argv passed to TSPluginInit ...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1257 [add to whitelist] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1299 [add to whitelist] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1276 Marking this for 6.2.2 for now, unless we need to respond 6.2.1? Also, this has build issues I think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1298: traffic_server deadlocked after config reload
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1298 @randall We only saw this once so far, right? It might be worth trying turning off HostDB syncing again, now that we can do that (supposedly safely) in 7.x ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1294 I'm seeing e.g. ``` BIO_fastopen.cc: In function 'int fastopen_create(BIO*)': BIO_fastopen.cc:48:11: error: 'BIO' has no member named 'data' BIO_set_data(bio, data); ^ BIO_fastopen.cc:49:11: error: expected unqualified-id before numeric constant BIO_set_init(bio, 1); ^ ``` On the build bots. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1294 [add to whitelist] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1297: ISSUE 1283: Fix CID 1367526 and CID 1367525 in mo...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1297 I think the Jenkins master was wedged, trying a new build [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1282: CID 1367527: Program hangs (SLEEP): cluster/Clust...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1282 Do we just ignore /kill all clustering issues? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1292: CID 1367515, CID 1367514, CID 1367513: ts_lua plu...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1292 Meh, there's already a PR for this, nm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1292: CID 1367515, CID 1367514, CID 1367513: ts_lua plu...
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1292: CID 1367515, CID 1367514, CID 1367513: ts_lua plu...
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1292 CID 1367515, CID 1367514, CID 1367513: ts_lua plugin ``` *** CID 1367515: Error handling issues (CHECKED_RETURN) /plugins/experimental/ts_lua/ts_lua_server_response.c: 354 in ts_lua_server_response_set_version() 348 GET_HTTP_CONTEXT(http_ctx, L); 349 350 TS_LUA_CHECK_SERVER_RESPONSE_HDR(http_ctx); 351 352 version = luaL_checklstring(L, 1, &len); 353 CID 1367515: Error handling issues (CHECKED_RETURN) Calling "sscanf" without checking return value (as is done elsewhere 61 out of 67 times). 354 sscanf(version, "%2u.%2u", &major, &minor); 355 356 TSHttpHdrVersionSet(http_ctx->server_response_bufp, http_ctx->server_response_hdrp, TS_HTTP_VERSION(major, minor)); 357 358 return 0; ``` and ``` *** CID 1367514: Error handling issues (CHECKED_RETURN) /plugins/experimental/ts_lua/ts_lua_client_request.c: 903 in ts_lua_client_request_set_version() 897 ts_lua_http_ctx *http_ctx; 898 899 GET_HTTP_CONTEXT(http_ctx, L); 900 901 version = luaL_checklstring(L, 1, &len); 902 CID 1367514: Error handling issues (CHECKED_RETURN) Calling "sscanf" without checking return value (as is done elsewhere 61 out of 67 times). 903 sscanf(version, "%2u.%2u", &major, &minor); 904 905 TSHttpHdrVersionSet(http_ctx->client_request_bufp, http_ctx->client_request_hdrp, TS_HTTP_VERSION(major, minor)); 906 907 return 0; 908 } ``` and ``` *** CID 1367513: Error handling issues (CHECKED_RETURN) /plugins/experimental/ts_lua/ts_lua_client_response.c: 370 in ts_lua_client_response_set_version() 364 GET_HTTP_CONTEXT(http_ctx, L); 365 366 TS_LUA_CHECK_CLIENT_RESPONSE_HDR(http_ctx); 367 368 version = luaL_checklstring(L, 1, &len); 369 CID 1367513: Error handling issues (CHECKED_RETURN) Calling "sscanf" without checking return value (as is done elsewhere 61 out of 67 times). 370 sscanf(version, "%2u.%2u", &major, &minor); 371 372 TSHttpHdrVersionSet(http_ctx->client_response_bufp, http_ctx->client_response_hdrp, TS_HTTP_VERSION(major, minor)); 373 374 return 0; 375 } ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1291: CID 1196420: Error handling issues (CHECKED_RETUR...
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1291
CID 1196420: Error handling issues (CHECKED_RETURN): proxy/CoreUtils.cc
```
*** CID 1196420: Error handling issues (CHECKED_RETURN)
/proxy/CoreUtils.cc: 482 in CoreUtils::print_http_hdr(HTTPHdr *, const char
*)()
476 if (h->m_heap && h->m_http) {
477 int r = load_http_hdr(h, &new_handle);
478
479 if (r > 0) {
480 printf("--- %s \n", name);
481 new_handle.m_mime = new_handle.m_http->m_fields_impl;
CID 1196420: Error handling issues (CHECKED_RETURN)
Calling "print" without checking return value (as is done elsewhere 26
out of 28 times).
482 new_handle.print(nullptr, 0, nullptr, nullptr);
483 printf("-\n\n");
484 }
485 }
486 }
487
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1290: CID 1367516: Null pointer dereferences (FORWARD_N...
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1290
CID 1367516: Null pointer dereferences (FORWARD_NULL): wccp/WccpConfig.cc
```
*** CID 1367516: Null pointer dereferences (FORWARD_NULL)
/lib/wccp/WccpConfig.cc: 528 in wccp::CacheImpl::loadServicesFromFile(const
char *)()
522 zret.pull(load_routers(prop, Seed_Router).doNotLog());
523 }
524
525 int idx, nsvc;
526 for (idx = 0, nsvc = svc_list.childCount(); idx < nsvc; ++idx) {
527 int x; // scratch int.
CID 1367516: Null pointer dereferences (FORWARD_NULL)
Assigning: "md5_key" = "NULL".
528 const char *md5_key = 0;
529 ts::ConstBuffer text;
530 SecurityOption security_style = SECURITY_NONE;
531 bool use_group_local_security = false;
532 Value const &svc_cfg = svc_list[idx];
533 int svc_line = svc_cfg.getSourceLine();
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1289: CID 1367517: API usage errors (LOCK): mgmt/FileMa...
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1289 CID 1367517: API usage errors (LOCK): mgmt/FileManager.cc ``` *** CID 1367517: API usage errors (LOCK) /mgmt/FileManager.cc: 97 in FileManager::~FileManager()() 91 92 delete rb; 93 } 94 95 ink_hash_table_destroy(bindings); 96 CID 1367517: API usage errors (LOCK) "ink_mutex_destroy" destroys "this->accessLock" while it is locked. 97 ink_mutex_destroy(&accessLock); 98 ink_mutex_destroy(&cbListLock); 99 } 100 101 // void FileManager::registerCallback(FileCallbackFunc func) 102 // ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1288: CID 1367518: (LOCK): records/P_RecCore.cc
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1288
CID 1367518:(LOCK): records/P_RecCore.cc
```
*** CID 1367518:(LOCK)
/lib/records/P_RecCore.cc: 751 in RecSyncConfigToTB(textBuffer *, bool *)()
745 break;
746 default:
747 ink_assert(!"Unexpected RecD type");
748 break;
749 }
750 tb->copyFrom("\n", 1);
CID 1367518:(LOCK)
"rec_mutex_release" unlocks "r->lock.the_mutex" while it is unlocked.
751 rec_mutex_release(&(r->lock));
752 }
753 }
754 llq_rec = llq_rec->next;
755 }
756 ink_rwlock_unlock(&g_records_rwlock);
/lib/records/P_RecCore.cc: 751 in RecSyncConfigToTB(textBuffer *, bool *)()
745 break;
746 default:
747 ink_assert(!"Unexpected RecD type");
748 break;
749 }
750 tb->copyFrom("\n", 1);
CID 1367518:(LOCK)
"rec_mutex_release" unlocks "r->lock.the_mutex" while it is unlocked.
751 rec_mutex_release(&(r->lock));
752 }
753 }
754 llq_rec = llq_rec->next;
755 }
756 ink_rwlock_unlock(&g_records_rwlock);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1287: CID 1367519: Low impact quality (MISSING_MOVE_ASS...
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1287
CID 1367519: Low impact quality (MISSING_MOVE_ASSIGNMENT): ts/ink_memory.h
```
*** CID 1367519: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/lib/ts/ink_memory.h: 242 in ()
236 assignment operator. This will be easier with C++ eleventy.
237
238 */
239
240 template
CID 1367519: Low impact quality (MISSING_MOVE_ASSIGNMENT)
Class "ats_scoped_resource >" may
benefit from adding a move assignment operator. See other events which show the
copy assignment operator being applied to rvalue(s), where a move assignment
may be faster.
242 class ats_scoped_resource
243 {
244 public:
245 typedef TRAITS Traits; ///< Make
template arg available.
246 typedef typename TRAITS::value_type value_type; ///< Import value
type.
247 typedef ats_scoped_resource self; ///< Self
reference type.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1286: CID 1367521: Low impact quality (MISSING_MOVE_ASS...
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1286
CID 1367521: Low impact quality (MISSING_MOVE_ASSIGNMENT):
tsconfig/Errata.h and tsconfig/TsValue.h
```
*** CID 1367521: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/lib/tsconfig/Errata.h: 82 in ()
76
77 /** Class to hold a stack of error messages (the "errata").
78 This is a smart handle class, which wraps the actual data
79 and can therefore be treated a value type with cheap copy
80 semantics. Default construction is very cheap.
81 */
CID 1367521: Low impact quality (MISSING_MOVE_ASSIGNMENT)
Class "ts::Errata" may benefit from adding a move assignment operator.
See other events which show the copy assignment operator being applied to
rvalue(s), where a move assignment may be faster.
82 class Errata {
83 protected:
84 /// Implementation class.
85 struct Data;
86 /// Handle for implementation class instance.
87 typedef IntrusivePtr ImpPtr;
```
and
```
*** CID 1367520: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/lib/tsconfig/TsValue.h: 420 in ()
414
415 /** This holds a value from the configuration.
416
417 @internal It is critical that none of the type specific
subclasses define any data members
418 so that instances can be freely converted to and from this base
class.
419 */
CID 1367520: Low impact quality (MISSING_MOVE_ASSIGNMENT)
Class "ts::config::Value" may benefit from adding a move assignment
operator. See other events which show the copy assignment operator being
applied to rvalue(s), where a move assignment may be faster.
420 class Value {
421 friend class Configuration;
422 public:
423 typedef Value self; ///< Self reference type.
424 /// Default constructors.
425 /// Creates an @c NULL instance.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1285: CID 1367522: (MISSING_MOVE_ASSIGNMENT): /ts/Ptr.h
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1285
CID 1367522:(MISSING_MOVE_ASSIGNMENT): /ts/Ptr.h
```
*** CID 1367522:(MISSING_MOVE_ASSIGNMENT)
/lib/ts/Ptr.h: 101 in ()
95
96
97 //
98 // class Ptr
99 //
100
CID 1367522:(MISSING_MOVE_ASSIGNMENT)
Class "Ptr" may benefit from adding a move assignment
operator. See other events which show the copy assignment operator being
applied to rvalue(s), where a move assignment may be faster.
101 template class Ptr
102 {
103 //
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0W45MESkt7QSpvBKPCpfGg0EsS4CE-2BsucoA-2Bh5sNd9pMEAb7uIMmByan8uZ59B7ORHJPmtAdxHf-2B8vORfhUKU34-3D_3VE9LA9cRpyFj86bhmsMYTy9sYYkQM91aQkNph4gHbXkGRWVX6Y7-2BgNOjPK-2Feq5oj4AF-2FfiTCfDhIFPLYPA5maqlar3DtcXLDMevYyHoNond8zOHE6yUK6SAWNH0X9fXb-2FdeKmNgn1ZaYENzUdZPdmHX8B00b8hrDYppf7MJUzJm2OUOTa0eQEZVzQhPuxwaTpn6pR9oWSWj-2B6C-2BX0vK1w-3D-3D
104 typedef void (Ptr::*bool_type)() const;
105 void
106 this_type_does_not_support_comparisons() const
/lib/ts/Ptr.h: 101 in ()
95
96
97 //
98 // class Ptr
99 //
100
CID 1367522:(MISSING_MOVE_ASSIGNMENT)
Class "Ptr" may benefit from adding a move assignment
operator. See other events which show the copy assignment operator being
applied to rvalue(s), where a move assignment may be faster.
101 template class Ptr
102 {
103 //
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0W45MESkt7QSpvBKPCpfGg0EsS4CE-2BsucoA-2Bh5sNd9pMEAb7uIMmByan8uZ59B7ORHJPmtAdxHf-2B8vORfhUKU34-3D_3VE9LA9cRpyFj86bhmsMYTy9sYYkQM91aQkNph4gHbXkGRWVX6Y7-2BgNOjPK-2Feq5oJw3BetWxAOU-2B5T0N6CLRuD5JIZr7iaXdmIM8db3DvT7HDD4Lk9bctbunI99yTFLPPFBxy1BpxG7SILZd1aPYcwg-2F7jXuTWyNeHRZHnu6b1XjTxlfXUjJDk2XiQdeIpAcmkk6wy1Zv2djzDU1UjY1Pw-3D-3D
104 typedef void (Ptr::*bool_type)() const;
105 void
106 this_type_does_not_support_comparisons() const
/lib/ts/Ptr.h: 101 in ()
95
96
97 //
98 // class Ptr
99 //
100
CID 1367522:(MISSING_MOVE_ASSIGNMENT)
Class "Ptr" may benefit from adding a move assignment
operator. See other events which show the copy assignment operator being
applied to rvalue(s), where a move assignment may be faster.
101 template class Ptr
102 {
103 //
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0W45MESkt7QSpvBKPCpfGg0EsS4CE-2BsucoA-2Bh5sNd9pMEAb7uIMmByan8uZ59B7ORHJPmtAdxHf-2B8vORfhUKU34-3D_3VE9LA9cRpyFj86bhmsMYTy9sYYkQM91aQkNph4gHbXkGRWVX6Y7-2BgNOjPK-2Feq5oU0SsS59AOD6tr1dderDaUQeOghEgVOzWoqqKs-2BIK-2F-2Bj795lyrUxxQqwWFVu0wzLf5eH1Fj6cjTF3YYcxBJTA6IJPhmUQhXZ3p21FswJ9FKgyW9ZmaS-2FAvi-2BtkFHvt4G3lBDuQMzT-2BBIhMJekozu2Vw-3D-3D
104 typedef void (Ptr::*bool_type)() const;
105 void
106 this_type_does_not_support_comparisons() const
/lib/ts/Ptr.h: 101 in ()
95
96
97 //
98 // class Ptr
99 //
100
CID 1367522:(MISSING_MOVE_ASSIGNMENT)
Class "Ptr" may benefit from adding a move assignment operator.
See other events which show the copy assignment operator being applied to
rvalue(s), where a move assignment may be faster.
101 template class Ptr
102 {
103 //
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0W45MESkt7QSpvBKPCpfGg0EsS4CE-2BsucoA-2Bh5sNd9pMEAb7uIMmByan8uZ59B7ORHJPmtAdxHf-2B8vORfhUKU34-3D_3VE9LA9cRpyFj86bhmsMYTy9sYYkQM91aQkNph4gHbXkGRWVX6Y7-2BgNOjPK-2Feq5owEAlkpEylvOeLgjNWeAM6CsvrumvSwZCQx9yoyG539fA3nT6OyyoHnhWwSmJhJ9Arw6C7dgniEN-2Fj-2BuvNmo8TjWFIitO50lMPs7w82TWD3Uac-2FJayiiIyBqRfU9sH0nSqpLtz7IHiOnKhlpH4Ozqlw-3D-3D
104 typedef void (Ptr::*bool_type)() const;
105 void
106 this_type_does_not_support_comparisons() const
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
