[jira] [Work logged] (TS-1257) Replace Tcl_Hash* with lib/ts/Map

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-1257?focusedWorklogId=31933=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31933
 ]

ASF GitHub Bot logged work on TS-1257:
--

Author: ASF GitHub Bot
Created on: 10/Nov/16 15:32
Start Date: 10/Nov/16 15:32
Worklog Time Spent: 10m 
  Work Description: Github user zwoop commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1212#discussion_r87417967
  
--- Diff: iocore/net/SSLUtils.cc ---
@@ -141,8 +142,9 @@ static int ssl_vc_index = -1;
 static ink_mutex *mutex_buf  = nullptr;
 static bool open_ssl_initialized = false;
 
-RecRawStatBlock *ssl_rsb   = nullptr;
-static InkHashTable *ssl_cipher_name_table = nullptr;
+RecRawStatBlock *ssl_rsb = nullptr;
+typedef std::unordered_map cipherTable;
--- End diff --

That's what I thought too (we provide custom hashing functions for this in 
a few places), but then I tested this on a modern compiler, and it seemed to do 
it right. I assume C++11 had added support for hashing the char*, but now that 
you say this, it's quite possible my tests were wrong.


Issue Time Tracking
---

Worklog Id: (was: 31933)
Time Spent: 1h 10m  (was: 1h)

> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have 
> already discussed looking into removing the old Tcl cruft by replacing it 
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the 
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly 
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be 
> discussed/decided/evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-1257) Replace Tcl_Hash* with lib/ts/Map

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-1257?focusedWorklogId=31803=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31803
 ]

ASF GitHub Bot logged work on TS-1257:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 19:23
Start Date: 08/Nov/16 19:23
Worklog Time Spent: 10m 
  Work Description: Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1212
  
I think the goal is to remove all TCL dependencies, not necessarily to 
improve performance.


Issue Time Tracking
---

Worklog Id: (was: 31803)
Time Spent: 1h  (was: 50m)

> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have 
> already discussed looking into removing the old Tcl cruft by replacing it 
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the 
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly 
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be 
> discussed/decided/evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-1257) Replace Tcl_Hash* with lib/ts/Map

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-1257?focusedWorklogId=31795=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31795
 ]

ASF GitHub Bot logged work on TS-1257:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 16:12
Start Date: 08/Nov/16 16:12
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1212#discussion_r87022320
  
--- Diff: iocore/net/SSLUtils.cc ---
@@ -141,8 +142,9 @@ static int ssl_vc_index = -1;
 static ink_mutex *mutex_buf  = nullptr;
 static bool open_ssl_initialized = false;
 
-RecRawStatBlock *ssl_rsb   = nullptr;
-static InkHashTable *ssl_cipher_name_table = nullptr;
+RecRawStatBlock *ssl_rsb = nullptr;
+typedef std::unordered_map cipherTable;
--- End diff --

This hashes on the pointer value, not on the string value. I'm not sure 
that OpenSSL guarantees to give the same pointer values when you fish them out 
of the SSL context.


Issue Time Tracking
---

Worklog Id: (was: 31795)
Time Spent: 50m  (was: 40m)

> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have 
> already discussed looking into removing the old Tcl cruft by replacing it 
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the 
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly 
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be 
> discussed/decided/evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-1257) Replace Tcl_Hash* with lib/ts/Map

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-1257?focusedWorklogId=31791=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31791
 ]

ASF GitHub Bot logged work on TS-1257:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 15:55
Start Date: 08/Nov/16 15:55
Worklog Time Spent: 10m 
  Work Description: GitHub user persiaAziz opened a pull request:

https://github.com/apache/trafficserver/pull/1212

TS-1257: [ssl_cipher_table] replace TCL HashTable by unordered_map

Replace the underlying TCL hash table implementation of 
ssl_cipher_name_table by STL unordered_map. This PR partially addresses 
TS-1257. There are many places where TCL hash table is being used. I plan to 
replace these one by one.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/persiaAziz/trafficserver TS-1257

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1212.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1212


commit da93bfb47b205a9d732f56c480631bd927f17316
Author: Persia Aziz 
Date:   2016-11-04T18:18:06Z

TS-1257: [ssl_cipher_table] replace TCL HashTable by unordered_map




Issue Time Tracking
---

Worklog Id: (was: 31791)
Time Spent: 40m  (was: 0.5h)

> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have 
> already discussed looking into removing the old Tcl cruft by replacing it 
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the 
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly 
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be 
> discussed/decided/evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-1257) Replace Tcl_Hash* with lib/ts/Map

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-1257?focusedWorklogId=31789=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31789
 ]

ASF GitHub Bot logged work on TS-1257:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 15:48
Start Date: 08/Nov/16 15:48
Worklog Time Spent: 10m 
  Work Description: Github user persiaAziz closed the pull request at:

https://github.com/apache/trafficserver/pull/1197


Issue Time Tracking
---

Worklog Id: (was: 31789)
Time Spent: 0.5h  (was: 20m)

> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have 
> already discussed looking into removing the old Tcl cruft by replacing it 
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the 
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly 
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be 
> discussed/decided/evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-1257) Replace Tcl_Hash* with lib/ts/Map

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-1257?focusedWorklogId=31763=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31763
 ]

ASF GitHub Bot logged work on TS-1257:
--

Author: ASF GitHub Bot
Created on: 08/Nov/16 05:37
Start Date: 08/Nov/16 05:37
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/1197
  
Please reformat the PR and commit subject to the convention:
```
TS-1257: Replace TCL hash table with unordered_map.
```


Issue Time Tracking
---

Worklog Id: (was: 31763)
Time Spent: 20m  (was: 10m)

> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have 
> already discussed looking into removing the old Tcl cruft by replacing it 
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the 
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly 
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be 
> discussed/decided/evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-1257) Replace Tcl_Hash* with lib/ts/Map

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-1257?focusedWorklogId=31649=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31649
 ]

ASF GitHub Bot logged work on TS-1257:
--

Author: ASF GitHub Bot
Created on: 04/Nov/16 18:27
Start Date: 04/Nov/16 18:27
Worklog Time Spent: 10m 
  Work Description: GitHub user persiaAziz opened a pull request:

https://github.com/apache/trafficserver/pull/1197

TS-1257_ssl_cipher_name_table: replace TCL_HashTable with unordered_map

Replacement of InkHashTable with unordered_map. This PR  partially 
addresses TS-1257. I plan to gradually replace other instances of InkHashTable 
in ATS as well. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/persiaAziz/trafficserver 
TS-1257-ssl_cipher_name_table

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1197


commit ebe4270bebed8958bba0f136d93284a8d4fe98d3
Author: Persia Aziz 
Date:   2016-11-04T18:18:06Z

TS-1257_ssl_cipher_name_table: replace TCL_HashTable with unordered_map




Issue Time Tracking
---

Worklog Id: (was: 31649)
Time Spent: 10m
Remaining Estimate: 0h

> Replace Tcl_Hash* with lib/ts/Map
> -
>
> Key: TS-1257
> URL: https://issues.apache.org/jira/browse/TS-1257
> Project: Traffic Server
>  Issue Type: Improvement
>  Components: Cleanup, Core
>Reporter: Igor Galić
>Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> We have our own implementation of maps that we use in most new code. We have 
> already discussed looking into removing the old Tcl cruft by replacing it 
> with {{Map}}, but have neither followed up on the ML nor Jira - or in the 
> code ;)
> This ticket is a reminder that this task exists and wants to be done!
> As to whether we simply replace the Tcl Implementation underneath, or visibly 
> to all developers, replace {{InkHashTable}} with {{Map}}, remains to be 
> discussed/decided/evaluated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)