[jira] [Work logged] (TRAFODION-3329) Remove unused code in T2 driver
[ https://issues.apache.org/jira/browse/TRAFODION-3329?focusedWorklogId=322364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322364 ] ASF GitHub Bot logged work on TRAFODION-3329: - Author: ASF GitHub Bot Created on: 02/Oct/19 23:41 Start Date: 02/Oct/19 23:41 Worklog Time Spent: 10m Work Description: selvaganesang commented on pull request #1859: [TRAFODION-3329] Code cleanup in Type 2 driver URL: https://github.com/apache/trafodion/pull/1859#discussion_r330815443 ## File path: core/sql/sqlmxevents/logmxevent_traf.h ## @@ -189,4 +190,7 @@ class SQLMXLoggingArea }; +void logAnMXEventForError( ComCondition & condition, SQLMXLoggingArea::ExperienceLevel emsEventEL); Review comment: The implementation was already available at cli/CliExtern.cpp. The corresponding include file will be sqlcli.h that contains the interface to be used by the clients to Trafodion SQL engine. Hence, I added this declaration in logmxevent_traf.h This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322364) Time Spent: 40m (was: 0.5h) > Remove unused code in T2 driver > --- > > Key: TRAFODION-3329 > URL: https://issues.apache.org/jira/browse/TRAFODION-3329 > Project: Apache Trafodion > Issue Type: Sub-task > Components: client-jdbc-t2 >Reporter: Selvaganesan Govindarajan >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3329) Remove unused code in T2 driver
[ https://issues.apache.org/jira/browse/TRAFODION-3329?focusedWorklogId=322363=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322363 ] ASF GitHub Bot logged work on TRAFODION-3329: - Author: ASF GitHub Bot Created on: 02/Oct/19 23:34 Start Date: 02/Oct/19 23:34 Worklog Time Spent: 10m Work Description: DaveBirdsall commented on pull request #1859: [TRAFODION-3329] Code cleanup in Type 2 driver URL: https://github.com/apache/trafodion/pull/1859#discussion_r330813852 ## File path: core/sql/sqlmxevents/logmxevent_traf.h ## @@ -189,4 +190,7 @@ class SQLMXLoggingArea }; +void logAnMXEventForError( ComCondition & condition, SQLMXLoggingArea::ExperienceLevel emsEventEL); Review comment: Is there a function body somewhere that goes with this? I don't see it in this pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322363) Time Spent: 0.5h (was: 20m) > Remove unused code in T2 driver > --- > > Key: TRAFODION-3329 > URL: https://issues.apache.org/jira/browse/TRAFODION-3329 > Project: Apache Trafodion > Issue Type: Sub-task > Components: client-jdbc-t2 >Reporter: Selvaganesan Govindarajan >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3329) Remove unused code in T2 driver
[ https://issues.apache.org/jira/browse/TRAFODION-3329?focusedWorklogId=322360=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322360 ] ASF GitHub Bot logged work on TRAFODION-3329: - Author: ASF GitHub Bot Created on: 02/Oct/19 23:27 Start Date: 02/Oct/19 23:27 Worklog Time Spent: 10m Work Description: Traf-Jenkins commented on issue #1859: [TRAFODION-3329] Code cleanup in Type 2 driver URL: https://github.com/apache/trafodion/pull/1859#issuecomment-537722843 Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/3267/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322360) Time Spent: 20m (was: 10m) > Remove unused code in T2 driver > --- > > Key: TRAFODION-3329 > URL: https://issues.apache.org/jira/browse/TRAFODION-3329 > Project: Apache Trafodion > Issue Type: Sub-task > Components: client-jdbc-t2 >Reporter: Selvaganesan Govindarajan >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3329) Remove unused code in T2 driver
[ https://issues.apache.org/jira/browse/TRAFODION-3329?focusedWorklogId=322359=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322359 ] ASF GitHub Bot logged work on TRAFODION-3329: - Author: ASF GitHub Bot Created on: 02/Oct/19 23:27 Start Date: 02/Oct/19 23:27 Worklog Time Spent: 10m Work Description: selvaganesang commented on pull request #1859: [TRAFODION-3329] Code cleanup in Type 2 driver URL: https://github.com/apache/trafodion/pull/1859 Remove unused static module related code from T2 driver. Cleanup of T2 code exposed an issue with cleanup of volatile schema at the time of drop session and t2 disconnect. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322359) Remaining Estimate: 0h Time Spent: 10m > Remove unused code in T2 driver > --- > > Key: TRAFODION-3329 > URL: https://issues.apache.org/jira/browse/TRAFODION-3329 > Project: Apache Trafodion > Issue Type: Sub-task > Components: client-jdbc-t2 >Reporter: Selvaganesan Govindarajan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TRAFODION-3328) Code cleanup in Trafodion
[ https://issues.apache.org/jira/browse/TRAFODION-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Selvaganesan Govindarajan updated TRAFODION-3328: - Description: Trafodion code base has many code paths that are unused due to legacy reasons. This Jira will be used to track all the tasks associated with this cleanup effort was: With embedded compiler, there is a need to have many cmpContexts to compile the query because the compile code is not re-entrant. With many cmpContext, there is a need to ensure the elements of cmpContext are managed in an optimal way. This Jira is created to track all the improvements that can be done in this area. > Code cleanup in Trafodion > - > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Trafodion code base has many code paths that are unused due to legacy > reasons. This Jira will be used to track all the tasks associated with this > cleanup effort > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TRAFODION-3330) Cleanup of NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Selvaganesan Govindarajan updated TRAFODION-3330: - Description: With embedded compiler, there is a need to have many cmpContexts to compile the query because the compile code is not re-entrant. With many cmpContext, there is a need to ensure the elements of cmpContext are managed in an optimal way. This Jira is created to track all the improvements that can be done in this area. > Cleanup of NADefaults > - > > Key: TRAFODION-3330 > URL: https://issues.apache.org/jira/browse/TRAFODION-3330 > Project: Apache Trafodion > Issue Type: Sub-task > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TRAFODION-3330) Cleanup of NADefaults
Selvaganesan Govindarajan created TRAFODION-3330: Summary: Cleanup of NADefaults Key: TRAFODION-3330 URL: https://issues.apache.org/jira/browse/TRAFODION-3330 Project: Apache Trafodion Issue Type: Sub-task Components: sql-cmp Reporter: Selvaganesan Govindarajan Assignee: Selvaganesan Govindarajan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (TRAFODION-3329) Remove unused code in T2 driver
Selvaganesan Govindarajan created TRAFODION-3329: Summary: Remove unused code in T2 driver Key: TRAFODION-3329 URL: https://issues.apache.org/jira/browse/TRAFODION-3329 Project: Apache Trafodion Issue Type: Sub-task Components: client-jdbc-t2 Reporter: Selvaganesan Govindarajan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TRAFODION-3328) Code cleanup in Trafodion
[ https://issues.apache.org/jira/browse/TRAFODION-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Selvaganesan Govindarajan updated TRAFODION-3328: - Summary: Code cleanup in Trafodion (was: Code cleanup in NADefaults) > Code cleanup in Trafodion > - > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=322262=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322262 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 02/Oct/19 21:02 Start Date: 02/Oct/19 21:02 Worklog Time Spent: 10m Work Description: Traf-Jenkins commented on issue #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#issuecomment-537679358 Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/3266/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322262) Time Spent: 1.5h (was: 1h 20m) > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=322148=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322148 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 02/Oct/19 18:50 Start Date: 02/Oct/19 18:50 Worklog Time Spent: 10m Work Description: DaveBirdsall commented on pull request #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#discussion_r330712806 ## File path: core/sql/sqlcomp/nadefaults.cpp ## @@ -3629,11 +3622,12 @@ void NADefaults::initCurrentDefaultsWithDefaultDefaults() } // End: Temporary workaround for SQL build regressions to pass - // Cache all the default keywords up front, // leaving other non-keyword token to be cached on demand. Review comment: Should this comment line (line 3625 in the new file) be deleted also? It doesn't make sense by itself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322148) Time Spent: 1h 20m (was: 1h 10m) > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=322147=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322147 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 02/Oct/19 18:50 Start Date: 02/Oct/19 18:50 Worklog Time Spent: 10m Work Description: DaveBirdsall commented on pull request #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#discussion_r330710014 ## File path: core/sql/generator/GenRelUpdate.cpp ## @@ -779,6 +779,7 @@ short HbaseDelete::codeGen(Generator * generator) NABoolean isAlignedFormat = getTableDesc()->getNATable()->isAlignedFormat(getIndexDesc()); NABoolean isHbaseMapFormat = getTableDesc()->getNATable()->isHbaseMapTable(); + NABoolean isTrafMDTable = getTableDesc()->getNATable()->isSeabaseMDTable(); Review comment: Not sure why this change is here. We don't seem to use isTrafMDTable anywhere? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322147) Time Spent: 1h 10m (was: 1h) > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=322146=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322146 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 02/Oct/19 18:50 Start Date: 02/Oct/19 18:50 Worklog Time Spent: 10m Work Description: DaveBirdsall commented on pull request #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#discussion_r330711433 ## File path: core/sql/generator/GenRelUpdate.cpp ## @@ -2449,6 +2450,7 @@ short HbaseInsert::codeGen(Generator *generator) } const NATable *naTable = getTableDesc()->getNATable(); + NABoolean isTrafMDTable = getTableDesc()->getNATable()->isSeabaseMDTable(); Review comment: Same observation here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322146) Time Spent: 1h 10m (was: 1h) > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3327) LOB support in T2 driver
[ https://issues.apache.org/jira/browse/TRAFODION-3327?focusedWorklogId=322136=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322136 ] ASF GitHub Bot logged work on TRAFODION-3327: - Author: ASF GitHub Bot Created on: 02/Oct/19 18:42 Start Date: 02/Oct/19 18:42 Worklog Time Spent: 10m Work Description: selvaganesang commented on pull request #1857: [TRAFODION-3327] LOB support in T2 driver URL: https://github.com/apache/trafodion/pull/1857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322136) Time Spent: 1h (was: 50m) > LOB support in T2 driver > > > Key: TRAFODION-3327 > URL: https://issues.apache.org/jira/browse/TRAFODION-3327 > Project: Apache Trafodion > Issue Type: New Feature > Components: client-jdbc-t2 >Reporter: Selvaganesan Govindarajan >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > LOB support in T2 driver doesn't use the concepts of LOB in Trafodion SQL > engine. The existing code used the legacy code that was inherited from HP > that couldn't be used with new CLOB/BLOB concepts in Trafodion SQL engine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3327) LOB support in T2 driver
[ https://issues.apache.org/jira/browse/TRAFODION-3327?focusedWorklogId=322135=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322135 ] ASF GitHub Bot logged work on TRAFODION-3327: - Author: ASF GitHub Bot Created on: 02/Oct/19 18:41 Start Date: 02/Oct/19 18:41 Worklog Time Spent: 10m Work Description: selvaganesang commented on issue #1857: [TRAFODION-3327] LOB support in T2 driver URL: https://github.com/apache/trafodion/pull/1857#issuecomment-537626395 Thanks @DaveBirdsall . Yes. Lob support is still not functional. I will be making another round of changes with more testing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322135) Time Spent: 50m (was: 40m) > LOB support in T2 driver > > > Key: TRAFODION-3327 > URL: https://issues.apache.org/jira/browse/TRAFODION-3327 > Project: Apache Trafodion > Issue Type: New Feature > Components: client-jdbc-t2 >Reporter: Selvaganesan Govindarajan >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > LOB support in T2 driver doesn't use the concepts of LOB in Trafodion SQL > engine. The existing code used the legacy code that was inherited from HP > that couldn't be used with new CLOB/BLOB concepts in Trafodion SQL engine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3328) Code cleanup in NADefaults
[ https://issues.apache.org/jira/browse/TRAFODION-3328?focusedWorklogId=322134=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322134 ] ASF GitHub Bot logged work on TRAFODION-3328: - Author: ASF GitHub Bot Created on: 02/Oct/19 18:40 Start Date: 02/Oct/19 18:40 Worklog Time Spent: 10m Work Description: DaveBirdsall commented on issue #1858: [TRAFODION-3328] Code cleanup in NADefaults URL: https://github.com/apache/trafodion/pull/1858#issuecomment-537625819 jenkins, retest This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 322134) Time Spent: 40m (was: 0.5h) > Code cleanup in NADefaults > -- > > Key: TRAFODION-3328 > URL: https://issues.apache.org/jira/browse/TRAFODION-3328 > Project: Apache Trafodion > Issue Type: Improvement > Components: sql-cmp >Reporter: Selvaganesan Govindarajan >Assignee: Selvaganesan Govindarajan >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > With embedded compiler, there is a need to have many cmpContexts to compile > the query because the compile code is not re-entrant. > With many cmpContext, there is a need to ensure the elements of cmpContext > are managed in an optimal way. This Jira is created to track all the > improvements that can be done in this area. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (TRAFODION-3327) LOB support in T2 driver
[
https://issues.apache.org/jira/browse/TRAFODION-3327?focusedWorklogId=322131=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-322131
]
ASF GitHub Bot logged work on TRAFODION-3327:
-
Author: ASF GitHub Bot
Created on: 02/Oct/19 18:38
Start Date: 02/Oct/19 18:38
Worklog Time Spent: 10m
Work Description: DaveBirdsall commented on pull request #1857:
[TRAFODION-3327] LOB support in T2 driver
URL: https://github.com/apache/trafodion/pull/1857#discussion_r330703710
##
File path: core/conn/jdbc_type2/native/SrvrOthers.cpp
##
@@ -1529,3 +1529,127 @@ odbc_SQLSvc_CloseUsingLabel_sme_(
}
FUNCTION_RETURN_VOID((NULL));
}
+
+extern "C" void
+odbc_SQLSrvr_ExtractLob_sme_(
+/* In*/ void *objtag_
+ , /* In*/ const CEE_handle_def *call_id_
+ , /* Out */ odbc_SQLsrvr_ExtractLob_exc_ *exception_
+ , /* In*/ long dialogueId
+ , /* In*/ IDL_short extractLobAPI
+ , /* In*/ IDL_string lobHandle
+ , /* In*/ IDL_long_long
+ , /* Out */ IDL_long_long
+ , /* Out */ BYTE *& extractData
+ )
+{
+char lobExtractQuery[1000] = {0};
+long sqlcode;
+SRVR_STMT_HDL *QryLobExtractSrvrStmt = NULL;
+
+if ((QryLobExtractSrvrStmt = createSrvrStmt(dialogueId,
"MXOSRVR_EXTRACTLOB", ,
+ NULL, 0, 0, TYPE_UNKNOWN, false,false)) == NULL)
+{
+ exception_->exception_nr = odbc_SQLSvc_ExtractLob_SQLInvalidhandle_exn_;
+ return;
+}
+switch (extractLobAPI) {
+case 0:
+snprintf(lobExtractQuery, sizeof(lobExtractQuery), "EXTRACT
LOBLENGTH(LOB'%s') LOCATION %llu", lobHandle, (Int64));
Review comment:
Is there a maximum size on strlen(lobHandle)? If not, then long lobHandle
values (on the order of 980 characters or so) will cause truncation of
lobExtractQuery, resulting in a SQL error. One way to work around this is to
use a dynamic array size when declaring the lobExtractQuery array, so we can
guarantee enough space.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 322131)
Time Spent: 40m (was: 0.5h)
> LOB support in T2 driver
>
>
> Key: TRAFODION-3327
> URL: https://issues.apache.org/jira/browse/TRAFODION-3327
> Project: Apache Trafodion
> Issue Type: New Feature
> Components: client-jdbc-t2
>Reporter: Selvaganesan Govindarajan
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> LOB support in T2 driver doesn't use the concepts of LOB in Trafodion SQL
> engine. The existing code used the legacy code that was inherited from HP
> that couldn't be used with new CLOB/BLOB concepts in Trafodion SQL engine.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
