[jira] [Commented] (TRAFODION-2886) fix the null pointer Critical error checked by TScanCode
[ https://issues.apache.org/jira/browse/TRAFODION-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334445#comment-16334445 ] ASF GitHub Bot commented on TRAFODION-2886: --- Github user asfgit closed the pull request at: https://github.com/apache/trafodion/pull/1380 > fix the null pointer Critical error checked by TScanCode > > > Key: TRAFODION-2886 > URL: https://issues.apache.org/jira/browse/TRAFODION-2886 > Project: Apache Trafodion > Issue Type: Bug >Reporter: xiaozhong.wang >Priority: Critical > Attachments: Critical_trafodion_tscancode_codecheck.xml > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TRAFODION-2886) fix the null pointer Critical error checked by TScanCode
[
https://issues.apache.org/jira/browse/TRAFODION-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324239#comment-16324239
]
ASF GitHub Bot commented on TRAFODION-2886:
---
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1380#discussion_r161273985
--- Diff: core/sql/executor/cluster.cpp ---
@@ -2395,7 +2395,7 @@ NABoolean Cluster::checkAndSplit(ExeErrorCode * rc)
rc);
if ( !next_ || *rc ) {
--- End diff --
OK, I see.
> fix the null pointer Critical error checked by TScanCode
>
>
> Key: TRAFODION-2886
> URL: https://issues.apache.org/jira/browse/TRAFODION-2886
> Project: Apache Trafodion
> Issue Type: Bug
>Reporter: xiaozhong.wang
>Priority: Critical
> Attachments: Critical_trafodion_tscancode_codecheck.xml
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TRAFODION-2886) fix the null pointer Critical error checked by TScanCode
[
https://issues.apache.org/jira/browse/TRAFODION-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324226#comment-16324226
]
ASF GitHub Bot commented on TRAFODION-2886:
---
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1380#discussion_r161272011
--- Diff: core/sql/executor/cluster.cpp ---
@@ -2395,7 +2395,7 @@ NABoolean Cluster::checkAndSplit(ExeErrorCode * rc)
rc);
if ( !next_ || *rc ) {
--- End diff --
You are correct, In that case you can change it if *(!next) || (*rc !=
EXE_OK)). I wish we got this right this time.
> fix the null pointer Critical error checked by TScanCode
>
>
> Key: TRAFODION-2886
> URL: https://issues.apache.org/jira/browse/TRAFODION-2886
> Project: Apache Trafodion
> Issue Type: Bug
>Reporter: xiaozhong.wang
>Priority: Critical
> Attachments: Critical_trafodion_tscancode_codecheck.xml
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TRAFODION-2886) fix the null pointer Critical error checked by TScanCode
[
https://issues.apache.org/jira/browse/TRAFODION-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324148#comment-16324148
]
ASF GitHub Bot commented on TRAFODION-2886:
---
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1380#discussion_r161255440
--- Diff: core/sql/executor/cluster.cpp ---
@@ -2395,7 +2395,7 @@ NABoolean Cluster::checkAndSplit(ExeErrorCode * rc)
rc);
if ( !next_ || *rc ) {
--- End diff --
I cann't understand.
Why remove the || *rc,
I think there are two type results：
1、 First, if there are no memory, next_ will get NULL value.
2、 Second, there are some wrong happened in Cluster::Cluster
In the second case, next_ will get a value, but *rc will is not EXE_OK.
If we remove the || *rc, this check will pass, but there was an error
happened.
My understanding is wrong?
> fix the null pointer Critical error checked by TScanCode
>
>
> Key: TRAFODION-2886
> URL: https://issues.apache.org/jira/browse/TRAFODION-2886
> Project: Apache Trafodion
> Issue Type: Bug
>Reporter: xiaozhong.wang
>Priority: Critical
> Attachments: Critical_trafodion_tscancode_codecheck.xml
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TRAFODION-2886) fix the null pointer Critical error checked by TScanCode
[
https://issues.apache.org/jira/browse/TRAFODION-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324132#comment-16324132
]
ASF GitHub Bot commented on TRAFODION-2886:
---
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1380#discussion_r161252479
--- Diff: core/sql/executor/cluster.cpp ---
@@ -2395,7 +2395,7 @@ NABoolean Cluster::checkAndSplit(ExeErrorCode * rc)
rc);
if ( !next_ || *rc ) {
--- End diff --
Oops. Please remove the || *rc,
> fix the null pointer Critical error checked by TScanCode
>
>
> Key: TRAFODION-2886
> URL: https://issues.apache.org/jira/browse/TRAFODION-2886
> Project: Apache Trafodion
> Issue Type: Bug
>Reporter: xiaozhong.wang
>Priority: Critical
> Attachments: Critical_trafodion_tscancode_codecheck.xml
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TRAFODION-2886) fix the null pointer Critical error checked by TScanCode
[
https://issues.apache.org/jira/browse/TRAFODION-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321882#comment-16321882
]
ASF GitHub Bot commented on TRAFODION-2886:
---
Github user xiaozhongwang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1380#discussion_r160870920
--- Diff: core/sql/executor/cluster.cpp ---
@@ -2395,7 +2395,7 @@ NABoolean Cluster::checkAndSplit(ExeErrorCode * rc)
rc);
if ( !next_ || *rc ) {
-if ( ! rc ) * rc = EXE_NO_MEM_TO_EXEC;
+* rc = EXE_NO_MEM_TO_EXEC;
--- End diff --
the last code is:
if (!next_ || rc)
if ( NULL != rc ) *rc = EXE_NO_MEM_TO_EXEC;
the next line is wrong, because the condition !rc is TRUE when rc = NULL,
so the *rc is incorrect:
if ( !rc ) *rc = EXE_NO_MEM_TO_EXEC;
> fix the null pointer Critical error checked by TScanCode
>
>
> Key: TRAFODION-2886
> URL: https://issues.apache.org/jira/browse/TRAFODION-2886
> Project: Apache Trafodion
> Issue Type: Bug
>Reporter: xiaozhong.wang
>Priority: Critical
> Attachments: Critical_trafodion_tscancode_codecheck.xml
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TRAFODION-2886) fix the null pointer Critical error checked by TScanCode
[
https://issues.apache.org/jira/browse/TRAFODION-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16321718#comment-16321718
]
ASF GitHub Bot commented on TRAFODION-2886:
---
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1380#discussion_r160866708
--- Diff: core/sql/executor/cluster.cpp ---
@@ -2395,7 +2395,7 @@ NABoolean Cluster::checkAndSplit(ExeErrorCode * rc)
rc);
if ( !next_ || *rc ) {
-if ( ! rc ) * rc = EXE_NO_MEM_TO_EXEC;
+* rc = EXE_NO_MEM_TO_EXEC;
--- End diff --
The deleted code is correct. In the new code rc could be NULL
> fix the null pointer Critical error checked by TScanCode
>
>
> Key: TRAFODION-2886
> URL: https://issues.apache.org/jira/browse/TRAFODION-2886
> Project: Apache Trafodion
> Issue Type: Bug
>Reporter: xiaozhong.wang
>Priority: Critical
> Attachments: Critical_trafodion_tscancode_codecheck.xml
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
