Re: [JBoss-dev] Fixed very small problem with ConnectionFactoryLoader
Thanks, I was really not sure what was needed to get this together. It looks like the main jboss branch did not get the latest unversioned jbosscx.jar, so I took the liberty to fix that. Thanks for updating the documentation too. --jason On Thu, 21 Jun 2001, Scott M Stark wrote: I updated the cvs admin doc to describe the steps for making a change in a non-jboss module and incorporating the module jars into the jboss release branch. I went through them for the jbosscx changes and this is what was done: Make a 2.4 branch for the jbosscx module: 1. cvs co jbosscx 2. cd jbosscx 3. cvs tag Rel_2_5_0_0 4. cvs tag -b Branch_2_4 5. cvs update -r Branch_2_4 6. cvs tag Rel_2_4_0_0 7. Make the required changes. All code changes had been made but the version portion of the jbosscx.jar needed to be removed so I did that. 8. Commit the changes 9. Tag the jbosscx 2.4 branch with the next beta release tag in the jboss module(not the jbosscx module). This happens to be Rel_2_4_0_1. From within the root jbosscx working directory: cvs tag Rel_2_4_0_1 10. Built the jbosscx.jar 11. Copied the jbosscx.jar into the jboss/src/lib directory 12. Removed the old jbosscx-0.2.jar 13. Added the new jbosscx.jar 14. Committed the changes 15. Tag the jboss module with Rel_2_4_0_1. From within the root jboss working directory: cvs tag Rel_2_4_0_1 16. Merge the change to build.xml made on the 2.4 branch to main. From within a working directory created by cvs co jbosscx: bash-2.04$ cvs update -j Rel_2_4_0_1 cvs server: Updating . RCS file: /cvsroot/jboss/jbosscx/src/build/build.xml,v retrieving revision 1.4 retrieving revision 1.4.2.1 Merging differences between 1.4 and 1.4.2.1 into build.xml ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Fixed very small problem with ConnectionFactoryLoader
Get rid of the version number. Make sure that the CVS tags are in synch between the jboss and jbosscx modules. Whenever you update the jbosscx.jar in jboss, there should be a tag in both modules so that you can always obtain the jbosscx source from which the jbosscx.jar was created. Do you have a suggested scheme for the tags, or a system for tagging? --jason ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Fixed very small problem with ConnectionFactoryLoader
On Wed, Jun 20, 2001 at 02:22:16PM -0700, Jason Dillon wrote: Get rid of the version number. Make sure that the CVS tags are in synch between the jboss and jbosscx modules. Whenever you update the jbosscx.jar in jboss, there should be a tag in both modules so that you can always obtain the jbosscx source from which the jbosscx.jar was created. Do you have a suggested scheme for the tags, or a system for tagging? Follow the steps detailed on the web site, i.e. add a tag to the jboss module when you update the jar file. Add a tag with the same name to the jbosscx module when you do this. Toby. ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Fixed very small problem with ConnectionFactoryLoader
See: http://www.jboss.org/CVSAdmin.jsp - Original Message - From: Jason Dillon [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, June 20, 2001 2:22 PM Subject: Re: [JBoss-dev] Fixed very small problem with ConnectionFactoryLoader Get rid of the version number. Make sure that the CVS tags are in synch between the jboss and jbosscx modules. Whenever you update the jbosscx.jar in jboss, there should be a tag in both modules so that you can always obtain the jbosscx source from which the jbosscx.jar was created. Do you have a suggested scheme for the tags, or a system for tagging? --jason ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Fixed very small problem with ConnectionFactoryLoader
Follow the steps detailed on the web site, i.e. add a tag to the jboss module when you update the jar file. Add a tag with the same name to the jbosscx module when you do this. Please excuse me if I am missing something obvious, but I don't quite get what I need to do. I looked at the tags on a file in jbosscx: cvs status -v build.sh === File: build.sh Status: Up-to-date Working revision:1.1.1.1 Repository revision: 1.1.1.1 /cvsroot/jboss/jbosscx/src/build/build.sh,v Sticky Tag: (none) Sticky Date: (none) Sticky Options: (none) Existing Tags: JBoss_2_2_1 (revision: 1.1.1.1) Branch_2_2 (branch: 1.1.1.1.2) JBoss_2_2_0_Final (revision: 1.1.1.1) JBOSSCX_0_2 (revision: 1.1.1.1) start (revision: 1.1.1.1) jboss (branch: 1.1.1) And I seed a JBOSSCS_0_2 tag, thats fine, but I don't see any tag on the jbosscx-0.2.jar file in jboss: cvs status -v jbosscx-0.2.jar === File: jbosscx-0.2.jar Status: Up-to-date Working revision:1.7 Repository revision: 1.7 /cvsroot/jboss/jboss/src/lib/jbosscx-0.2.jar,v Sticky Tag: (none) Sticky Date: (none) Sticky Options: -kb Existing Tags: Rel_3_0_0_0 (revision: 1.7) Rel_2_5_0_0 (revision: 1.7) Rel_2_4_0_0 (revision: 1.7) Branch_2_4 (branch: 1.7.4) Rel_2_3_1 (revision: 1.7) RabbitHole (branch: 1.7.2) JBoss_2_2_2 (revision: 1.3.2.2) JBoss_2_2_1 (revision: 1.3) Rel_2_2_1 (revision: 1.3) JBoss_2_2_0_Final (revision: 1.3) Rel_2_2_0 (revision: 1.3) Branch_2_2 (branch: 1.3.2) Rel_2_3_0 (revision: 1.3) So, what I *think* I should do is to either update the JBOSSCX_0_2 tag to the current HEAD of jbosscx, or create a JBOSSCX_0_2_1, though it seams like this number will grow as minor changes are added. Either way, tag the entire jbosscx module, then check the jbosscx.jar into jboss, and tag only that file with the same tag. Is this about it, or am I am missing something? I briefly scanned CVSAdmin.jsp for information/examples about modules but did not see anything. --jason ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development
Re: [JBoss-dev] Fixed very small problem with ConnectionFactoryLoader
On Tue, Jun 19, 2001 at 07:55:05PM -0700, Jason Dillon wrote: Hello, I ran into a problem with ConnectionFactoryLoader PrincipalMappingProperties was not set or when it was set like this: attribute name=PrincipalMappingProperties/attribute This would cause the princMapProps to remain a null, and cause a NullPointerException when loading. I set it to default to which fixes this problem. Fair enough. I think I did domething similar for another attribute a while back. I am sending this because I am not really sure what the procedure is for updating the jbosscx-*.jar in the jboss module. There is some versioning there and I am not really sure if that should change or not. Ah, yes. The version number really shouldn't be there, I've decided (or been persuaded). If you want to replace the versioned jar with just plain jbosscx.jar I'd be grateful. Anyways, the change is small and if folks set PrincipalMappingProperties to a non-null or something with a new line it will work fine. I am currious if the ConfigurationService should be modified to deal with this. I think so, but I am not 100% sure. It seems to me that if there is an attribute/ in jboss.jcml that the service should call the setter even if the value is . Currently if the value is , the attribute's setter will not be called. It seems like a good idea to call the setter even if the value is the empty string, like you say. Should I update the jbosscx-*.jar in jboss or leave it for the name major integration? Get rid of the version number. Make sure that the CVS tags are in synch between the jboss and jbosscx modules. Whenever you update the jbosscx.jar in jboss, there should be a tag in both modules so that you can always obtain the jbosscx source from which the jbosscx.jar was created. Toby. ___ Jboss-development mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/jboss-development
