Re: Backporting for LTS 2.164.3 started

2019-04-29 Thread Baptiste Mathus 
I agree with the rationale. I do not think users renaming agents is that
common, and yes, it is said to have been introduced in Jenkins 2.8, so it
would have exploded earlier if this was that problematic.

Thanks for considering this request in any case.

Le mar. 23 avr. 2019 à 10:05, Oliver Gondža  a écrit :

> Baptiste, thanks for the suggestion but I lean towards skipping this for
> 2.164.3.
>
> To the best of my understanding, this issues was present for 6 entire
> LTS lines (possibly without being reported). Given the consequences are
> duplication of a renamed agent after restart, I dare to dispute this is
> a blocker issue to begin with.
>
> Or do I miss something?
>
> On 19/04/2019 09.53, Baptiste Mathus wrote:
> > Just added lts-candidate on
> > https://issues.jenkins-ci.org/browse/JENKINS-56403 merged yesterday.
> > I think it could be considered given the regression fix PR is fairly
> > small and has had dedicated tests added:
> > https://github.com/jenkinsci/jenkins/pull/3925
> >
> > Do you think it would be eligible to backporting in upcoming .3?
> >
> > Thanks
> >
> > Le lun. 15 avr. 2019 à 11:54, Oliver Gondža  > > a écrit :
> >
> > Backporting has started and the RC is scheduled for 2019-04-24.
> >
> > Candidates: https://issues.jenkins-ci.org/issues/?filter=12146
> > Fixed:
> >
> https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%202.164.3-fixed
> > Rejected:
> >
> https://issues.jenkins-ci.org/issues/?jql=labels%20%3D%202.164.3-rejected
> > --
> > oliver
> >
> > --
> > You received this message because you are subscribed to the Google
> > Groups "Jenkins Developers" group.
> > To unsubscribe from this group and stop receiving emails from it,
> > send an email to jenkinsci-dev+unsubscr...@googlegroups.com
> > .
> > To view this discussion on the web visit
> >
> https://groups.google.com/d/msgid/jenkinsci-dev/845a8da6-c20e-1f50-e69e-319fe283b1f7%40gmail.com
> .
> > For more options, visit https://groups.google.com/d/optout.
> >
> > --
> > You received this message because you are subscribed to the Google
> > Groups "Jenkins Developers" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> > an email to jenkinsci-dev+unsubscr...@googlegroups.com
> > .
> > To view this discussion on the web visit
> >
> https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS5kQG7s-Ex1PQhO%3DUYxC_Hb3fNXtKGjhgrC6k%3Df8afOVA%40mail.gmail.com
> > <
> https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS5kQG7s-Ex1PQhO%3DUYxC_Hb3fNXtKGjhgrC6k%3Df8afOVA%40mail.gmail.com?utm_medium=email&utm_source=footer
> >.
> > For more options, visit https://groups.google.com/d/optout.
>
>
> --
> oliver
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/2deacef6-a160-936a-3b41-d523f97f2fa2%40gmail.com
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS6yN06EOfo62Ujqa2Tdz7rRk%3D%2BSNCDnL6tP0bY9Gj4jXQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: JEP-200? azure-vm-agents PR issue

2019-04-29 Thread Tim Jacomb 
Sorted

Jessie pointed me in the right direction (Thanks!)

WARNING o.jvnet.hudson.test.JenkinsRule#before: Jenkins.theInstance
was not cleared by a previous test, doing that now


This commit fixed it:
https://github.com/jenkinsci/azure-vm-agents-plugin/pull/144/commits/9c94fb0dafee9e60a7424345810295a9ad4142c6


Tim

On Mon, 29 Apr 2019 at 16:57, Tim Jacomb  wrote:

> Hi
>
> I'm having an issue adding configuration-as-code support to the
> azure-vm-agents plugin
> (On Mac, linux all tests pass, and on windows when run through intellij
> they also pass)
> On windows when run on the command line a couple of unit tests fail with:
>
> "Refusing to marshal com.microsoft.azure.vmagent.AzureVMCloud for security
> reasons; see https://jenkins.io/redirect/class-filter/";
>
> Gist with stacktrace:
> https://gist.github.com/timja/1bb1976ae2637088ee2f0ed13ef078a7
>
> stack:
> Caused by: java.io.IOException: java.lang.RuntimeException: Failed to
> serialize jenkins.model.Jenkins#clouds for class hudson.model.Hudson
> at hudson.XmlFile.write(XmlFile.java:200)
> at jenkins.model.Jenkins.save(Jenkins.java:3221)
> at hudson.BulkChange.commit(BulkChange.java:98)
> at
> io.jenkins.plugins.casc.BaseConfigurator.configure(BaseConfigurator.java:266)
> ... 11 more
> Caused by: java.lang.RuntimeException: Failed to serialize
> jenkins.model.Jenkins#clouds for class hudson.model.Hudson
> at
> hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
> at
> hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
> at
> com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
> at
> hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
> at
> hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
> at
> com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
> at
> com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
> at
> com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
> at
> com.thoughtworks.xstream.core.TreeMarshaller.start(TreeMarshaller.java:82)
> at
> com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.marshal(AbstractTreeMarshallingStrategy.java:37)
> at com.thoughtworks.xstream.XStream.marshal(XStream.java:1026)
> at com.thoughtworks.xstream.XStream.marshal(XStream.java:1015)
> at com.thoughtworks.xstream.XStream.toXML(XStream.java:988)
> at hudson.XmlFile.write(XmlFile.java:193)
> ... 14 more
> Caused by: java.lang.UnsupportedOperationException: Refusing to marshal
> com.microsoft.azure.vmagent.AzureVMCloud for security reasons; see
> https://jenkins.io/redirect/class-filter/
> at
> hudson.util.XStream2$BlacklistedTypesConverter.marshal(XStream2.java:546)
> at
> com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
> at
> com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
> at
> com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
> at
> com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88)
> at
> com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64)
> at
> hudson.util.DescribableList$ConverterImpl.marshal(DescribableList.java:269)
> at
> com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
> at
> com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
> at
> com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
> at
> hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
> at
> hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
> ... 27 more
>
> Full test output:
>
> https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fazure-vm-agents-plugin/detail/PR-144/13/tests
>
> The PR:
> https://github.com/jenkinsci/azure-vm-agents-plugin/pull/144
>
> Anyone got any idea or tips?
> I've read through  https://jenkins.io/redirect/class-filter/ but can't
> see what's wrong
>
> The core version and parent pom weren't changed in this PR, some data
> model changes though.
>
> Any help much appreciated
> Thanks
> Tim
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/356bd0f7-88a7-4934-bdb5-faf442ea4b25%40googlegroups.com
>

Re: Wrapping Gitlab API into a separate plugin

2019-04-29 Thread Jesse Glick 
On Mon, Apr 29, 2019 at 12:38 PM Matt Sicker  wrote:
> The main advantage to using an API plugin is to allow the library to
> be reused by other plugins

Technical details if you are interested:

https://jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/#using-library-wrapper-plugins

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr19ARXbqwGXemvc5%3D5WG0hz_kA6vU98adpg%2BQi6f24vkQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Wrapping Gitlab API into a separate plugin

2019-04-29 Thread Parichay Barpanda 
Thanks Matt that was helpful. :)

On Mon, Apr 29, 2019 at 10:08 PM Matt Sicker  wrote:

> The main advantage to using an API plugin is to allow the library to
> be reused by other plugins without each plugin needing to maintain
> updates to the dependencies manually. Instead, the API plugin is used
> for those libraries which reduces maintenance burden, especially
> whenever CVEs are discovered.
>
> On Sun, Apr 28, 2019 at 12:34 AM  wrote:
> >
> > Hi all,
> >
> > I am working on improving the Gitlab Plugins. The first plan is to move
> to a gitlab-api-plugin which provides Gitlab Java Apis rather than using
> the ones implemented inside the plugins codebase. This will be similar to
> github-api-plugin.
> >
> > What is the advantage of wrapping an API inside a plugin over using Apis
> directly as a dependency?
> >
> > If someone experienced with development of Github Api Plugin or similar,
> please take a look at our gitlab-api-plugin:
> > https://github.com/jenkins-gitlab/gitlab-api-plugin
> >
> > Your review will be higly appreciated.
> >
> > Regards,
> > Parichay (baymac)
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "Jenkins Developers" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
> > To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/c162286c-924e-4ea8-9f10-358d0c9000c6%40googlegroups.com
> .
> > For more options, visit https://groups.google.com/d/optout.
>
>
>
> --
> Matt Sicker
> Senior Software Engineer, CloudBees
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAEot4ow4Sr1hXZ%3D9mT82%3DVYe6sS3N70d1HJ2G10RwP3NXLp1kA%40mail.gmail.com
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAD0DWAPACQccYq-DE-d4GKx0m6PGD1o%3DOc%2BFfEEH64Nb8QwC5Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: Wrapping Gitlab API into a separate plugin

2019-04-29 Thread Matt Sicker 
The main advantage to using an API plugin is to allow the library to
be reused by other plugins without each plugin needing to maintain
updates to the dependencies manually. Instead, the API plugin is used
for those libraries which reduces maintenance burden, especially
whenever CVEs are discovered.

On Sun, Apr 28, 2019 at 12:34 AM  wrote:
>
> Hi all,
>
> I am working on improving the Gitlab Plugins. The first plan is to move to a 
> gitlab-api-plugin which provides Gitlab Java Apis rather than using the ones 
> implemented inside the plugins codebase. This will be similar to 
> github-api-plugin.
>
> What is the advantage of wrapping an API inside a plugin over using Apis 
> directly as a dependency?
>
> If someone experienced with development of Github Api Plugin or similar, 
> please take a look at our gitlab-api-plugin:
> https://github.com/jenkins-gitlab/gitlab-api-plugin
>
> Your review will be higly appreciated.
>
> Regards,
> Parichay (baymac)
>
> --
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/c162286c-924e-4ea8-9f10-358d0c9000c6%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.



-- 
Matt Sicker
Senior Software Engineer, CloudBees

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAEot4ow4Sr1hXZ%3D9mT82%3DVYe6sS3N70d1HJ2G10RwP3NXLp1kA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

JEP-200? azure-vm-agents PR issue

2019-04-29 Thread Tim Jacomb 
Hi

I'm having an issue adding configuration-as-code support to the 
azure-vm-agents plugin
(On Mac, linux all tests pass, and on windows when run through intellij 
they also pass)
On windows when run on the command line a couple of unit tests fail with:

"Refusing to marshal com.microsoft.azure.vmagent.AzureVMCloud for security 
reasons; see https://jenkins.io/redirect/class-filter/";

Gist with stacktrace:
https://gist.github.com/timja/1bb1976ae2637088ee2f0ed13ef078a7

stack:
Caused by: java.io.IOException: java.lang.RuntimeException: Failed to 
serialize jenkins.model.Jenkins#clouds for class hudson.model.Hudson
at hudson.XmlFile.write(XmlFile.java:200)
at jenkins.model.Jenkins.save(Jenkins.java:3221)
at hudson.BulkChange.commit(BulkChange.java:98)
at 
io.jenkins.plugins.casc.BaseConfigurator.configure(BaseConfigurator.java:266)
... 11 more
Caused by: java.lang.RuntimeException: Failed to serialize 
jenkins.model.Jenkins#clouds for class hudson.model.Hudson
at 
hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
at 
hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
at 
com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
at 
hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
at 
hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
at 
com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
at 
com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
at 
com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
at 
com.thoughtworks.xstream.core.TreeMarshaller.start(TreeMarshaller.java:82)
at 
com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.marshal(AbstractTreeMarshallingStrategy.java:37)
at com.thoughtworks.xstream.XStream.marshal(XStream.java:1026)
at com.thoughtworks.xstream.XStream.marshal(XStream.java:1015)
at com.thoughtworks.xstream.XStream.toXML(XStream.java:988)
at hudson.XmlFile.write(XmlFile.java:193)
... 14 more
Caused by: java.lang.UnsupportedOperationException: Refusing to marshal 
com.microsoft.azure.vmagent.AzureVMCloud for security reasons; see 
https://jenkins.io/redirect/class-filter/
at hudson.util.XStream2$BlacklistedTypesConverter.marshal(XStream2.java:546)
at 
com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
at 
com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
at 
com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
at 
com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88)
at 
com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64)
at 
hudson.util.DescribableList$ConverterImpl.marshal(DescribableList.java:269)
at 
com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
at 
com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
at 
com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
at 
hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
at 
hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
... 27 more

Full test output:
https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fazure-vm-agents-plugin/detail/PR-144/13/tests

The PR:
https://github.com/jenkinsci/azure-vm-agents-plugin/pull/144

Anyone got any idea or tips?
I've read through  https://jenkins.io/redirect/class-filter/ but can't see 
what's wrong

The core version and parent pom weren't changed in this PR, some data model 
changes though.

Any help much appreciated
Thanks
Tim

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/356bd0f7-88a7-4934-bdb5-faf442ea4b25%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.