Re: warnings-ng-plugin-devenv/analysis-model/bin/go.sh missing a step?

2022-06-07 Thread Simon Matthews


On Tuesday, June 7, 2022 at 12:10:22 PM UTC-7 ullrich...@gmail.com wrote:

> Workaround 1: use a pipeline and not a Freestyle Job
>
> Workaround 2: register your parser in the warnings plugin, see:
> - documentation: 
> https://github.com/jenkinsci/warnings-ng-plugin/blob/master/doc/Custom-Plugin.md#register-the-tool
> - examples: 
> https://github.com/jenkinsci/warnings-ng-plugin/tree/master/plugin/src/main/java/io/jenkins/plugins/analysis/warnings
>


I tried to follow  Workaround 2. 

I created a file to register the tool in warnings-ng by creating the file: 
warnings-ng-plugin/plugin/src/main/java/io/jenkins/plugins/analysis/warnings/.java 

I copied another file from the same directory and modified to reference my 
parser.  I note that almost all the other files in this directory extend 
AnalysisModelParser, not ReportScanningTool, as the documentation example 
does, so I copied one that extends AnalysisModelParser and modified this. 

The documentation also talks about a pom.xml file, but I could not find a 
similar example of a similar file. I am not sure if this is relevant to 
what I am trying to do. 

I  started docker in the warnings-ng-plug-devenv directory using the 
"jenkins.sh" script and then ran "./go.sh" in this directory. It appeared 
to finish, although there is an error right at the end:
...
removed 
'docker/volumes/jenkins-home/plugins/warnings-ng.jpi.version_from_image'
'analysis-model-api-plugin/target/analysis-model-api.hpi' -> 
'docker/volumes/jenkins-home/plugins/analysis-model-api.jpi'
cp: cannot stat 'code-coverage-api-plugin/target/*hpi': No such file or 
directory

I have noticed that I appear to have 2 docker containers running:

simon@jenkins-u:/jenkins/warnings-ng-plugin-devenv$ docker container list
CONTAINER ID   IMAGE  COMMAND   
   CREATEDSTATUS  PORTS 
NAMES
bd4d0076d1eb   warnings-ng-plugin-devenv_java11-agent 
"/docker-entrypoint.…"   26 hours ago   Up 35 minutes   22/tcp, 
0.0.0.0:8001->8001/tcp, :::8001->8001/tcp   
  warnings-ng-plugin-devenv-java11-agent-1
4e87949d4ec7   warnings-ng-plugin-devenv_jenkins-controller   "/sbin/tini 
-- /usr/…"   26 hours ago   Up 35 minutes   0.0.0.0:8000->8000/tcp, 
:::8000->8000/tcp, 0.0.0.0:8080->8080/tcp, :::8080->8080/tcp, 5/tcp   
warnings-ng-plugin-devenv-jenkins-controller-1

For good measure, I restarted the container with "docker-compose restart", 
but I still don't see my parser in the list. 

Any ideas what I might have missed? Or is my mistake to extend 
AnalysisModelParser instead of ReportScanningTool?

My work on the analysis-model can be found in 
https://github.com/SimonMatthews-BP/analysis-model






>
>
> Am 07.06.2022 um 19:54 schrieb Simon Matthews :
>
>
>
> On Tuesday, June 7, 2022 at 2:45:58 AM UTC-7 ullrich...@gmail.com wrote:
>
>> In your Jenkinsfile of your job where you want to use the parser. Or are 
>> you using a Freestyle project? 
>>
>> I think in Freestyle projects I forgot to add a dynamic selection of the 
>> parser ID in the UI up to now. I should file an issue for this bug. In this 
>> case you need to register your parser in the warnings plugin as well...
>>
>
> Can you tell me how to work around this? At least to show that my parser 
> is working?
>
> Simon 
>
>>
>> Am 07.06.2022 um 03:03 schrieb Simon Matthews :
>>
>>
>> On Monday, June 6, 2022 at 2:46:19 PM UTC-7 ullrich...@gmail.com wrote:
>>
>> Thanks for your reply. 
>>
>> To update on progress, I had not previously added the 
>> analysis-model/src/test/java/edu/hm/hafner/analysis/parser/> parser>ParserTest.java file. I have now added that and the unit tests are 
>> passing. 
>>
>> The parser is not listed in the UI, because the parser is not registered 
>>> in the warnings plugin yet. 
>>> But you can invoke the parser already using:
>>>
>>> recordIssues tool: analysisParser(pattern: 'your-report-file.xml', 
>>> analysisModelId: 'your-id')
>>>
>>> Does that work?
>>>
>>
>>
>> It's not clear to me how I run that command, or what file I add it to. 
>>
>> Simon
>>
>>
>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com.
>>
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/e1d2aaa9-a418-431d-80ef-2a7b26b96643n%40googlegroups.com
>>  
>> 
>> .
>>
>>
>>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to 

Re: Backporting for LTS 2.346.1 started

2022-06-07 Thread Tim Jacomb
Fine to delay the extra week

On Tue, 7 Jun 2022 at 12:01, Alexander Brandes  wrote:

> Hey Wadeck,
>
> thanks for the clarification from the views of the security team, that
> sounds reasonable. I'd want to go ahead and merge the PR later today,
> considering nobody expressed blocking reviews in over a week.
>
> To 1), that's a call Tim has to agree to as well. But like you already
> stated, delaying them might not be the best solution, however, I have no
> strong objections about it, if the security team needs a bit more time in
> advance.
>
> ~ Alex
>
> On Tuesday, 7 June 2022 at 18:20:52 UTC+2 wfoll...@cloudbees.com wrote:
>
>> Hey there, especially Alex,
>>
>> Usually we have a two weeks period for the RC, once the backports are
>> merged. In this case, we have a PR that is still pending, ~one week after
>> the expected delay.
>> PR in question: https://github.com/jenkinsci/jenkins/pull/6618
>>
>> So, two questions:
>> 1) Is it OK if we are *postponing the release by one additional week*?
>> a) to have two weeks of test for the RC, b) to get more time for the
>> security release that requires to have that PR merged. It would mean that
>> the LTS will be released on June 22. (and thus the Java 11 should be
>> postponed again)
>> 2) When do you plan to merge the PR?
>>
>> The second wave of backports seems to contain important fixes, so
>> postponing those seems to be not really an option.
>>
>> Best regards,
>>
>> Wadeck
>> On Tuesday, May 31, 2022 at 8:37:24 PM UTC+2 m...@basilcrow.com wrote:
>>
>>> On Fri, May 27, 2022 at 3:03 AM Alexander Brandes 
>>> wrote:
>>> >
>>> > If there are no objections against it, I'd like to use the additional
>>> time and start a secondary backporting process from past weekly releases to
>>> integrate the new LTS candidates.
>>>
>>> +1
>>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/5c711ab6-94ba-446d-bf30-e1659fa82368n%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidocRQoDFsq4%3DQBBeMRftnh-V55eUSLUN8t5YtMC3Tf8w%40mail.gmail.com.


Re: warnings-ng-plugin-devenv/analysis-model/bin/go.sh missing a step?

2022-06-07 Thread Ullrich Hafner
Workaround 1: use a pipeline and not a Freestyle Job

Workaround 2: register your parser in the warnings plugin, see:
- documentation: 
https://github.com/jenkinsci/warnings-ng-plugin/blob/master/doc/Custom-Plugin.md#register-the-tool
 

- examples: 
https://github.com/jenkinsci/warnings-ng-plugin/tree/master/plugin/src/main/java/io/jenkins/plugins/analysis/warnings
 




> Am 07.06.2022 um 19:54 schrieb Simon Matthews :
> 
> 
> 
> On Tuesday, June 7, 2022 at 2:45:58 AM UTC-7 ullrich...@gmail.com wrote:
> In your Jenkinsfile of your job where you want to use the parser. Or are you 
> using a Freestyle project? 
> 
> I think in Freestyle projects I forgot to add a dynamic selection of the 
> parser ID in the UI up to now. I should file an issue for this bug. In this 
> case you need to register your parser in the warnings plugin as well...
> 
> Can you tell me how to work around this? At least to show that my parser is 
> working?
> 
> Simon 
> 
> 
>> Am 07.06.2022 um 03:03 schrieb Simon Matthews > >:
>> 
> 
>> 
>> On Monday, June 6, 2022 at 2:46:19 PM UTC-7 ullrich...@gmail.com 
>>  wrote:
>> 
>> Thanks for your reply. 
>> 
>> To update on progress, I had not previously added the 
>> analysis-model/src/test/java/edu/hm/hafner/analysis/parser/> parser>ParserTest.java file. I have now added that and the unit tests are 
>> passing. 
>> 
>> The parser is not listed in the UI, because the parser is not registered in 
>> the warnings plugin yet. 
>> But you can invoke the parser already using:
>> 
>> recordIssues tool: analysisParser(pattern: 'your-report-file.xml', 
>> analysisModelId: 'your-id')
>> Does that work?
>> 
>> 
>> It's not clear to me how I run that command, or what file I add it to. 
>> 
>> Simon
>> 
>> 
>> 
> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com 
>> .
> 
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/e1d2aaa9-a418-431d-80ef-2a7b26b96643n%40googlegroups.com
>>  
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/ef235a57-19bf-48e5-b875-a9aa24106f50n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/693F946D-E2C3-407C-9B78-3B053F5EA81A%40gmail.com.


Re: warnings-ng-plugin-devenv/analysis-model/bin/go.sh missing a step?

2022-06-07 Thread Simon Matthews


On Tuesday, June 7, 2022 at 2:45:58 AM UTC-7 ullrich...@gmail.com wrote:

> In your Jenkinsfile of your job where you want to use the parser. Or are 
> you using a Freestyle project? 
>
> I think in Freestyle projects I forgot to add a dynamic selection of the 
> parser ID in the UI up to now. I should file an issue for this bug. In this 
> case you need to register your parser in the warnings plugin as well...
>

Can you tell me how to work around this? At least to show that my parser is 
working?

Simon 

>
> Am 07.06.2022 um 03:03 schrieb Simon Matthews :
>
>
> On Monday, June 6, 2022 at 2:46:19 PM UTC-7 ullrich...@gmail.com wrote:
>
> Thanks for your reply. 
>
> To update on progress, I had not previously added the 
> analysis-model/src/test/java/edu/hm/hafner/analysis/parser/ parser>ParserTest.java file. I have now added that and the unit tests are 
> passing. 
>
> The parser is not listed in the UI, because the parser is not registered 
>> in the warnings plugin yet. 
>> But you can invoke the parser already using:
>>
>> recordIssues tool: analysisParser(pattern: 'your-report-file.xml', 
>> analysisModelId: 'your-id')
>>
>> Does that work?
>>
>
>
> It's not clear to me how I run that command, or what file I add it to. 
>
> Simon
>
>
>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-de...@googlegroups.com.
>
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/e1d2aaa9-a418-431d-80ef-2a7b26b96643n%40googlegroups.com
>  
> 
> .
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/ef235a57-19bf-48e5-b875-a9aa24106f50n%40googlegroups.com.


Re: Backporting for LTS 2.346.1 started

2022-06-07 Thread Alexander Brandes
Hey Wadeck,

thanks for the clarification from the views of the security team, that 
sounds reasonable. I'd want to go ahead and merge the PR later today, 
considering nobody expressed blocking reviews in over a week.

To 1), that's a call Tim has to agree to as well. But like you already 
stated, delaying them might not be the best solution, however, I have no 
strong objections about it, if the security team needs a bit more time in 
advance.

~ Alex

On Tuesday, 7 June 2022 at 18:20:52 UTC+2 wfoll...@cloudbees.com wrote:

> Hey there, especially Alex,
>
> Usually we have a two weeks period for the RC, once the backports are 
> merged. In this case, we have a PR that is still pending, ~one week after 
> the expected delay.
> PR in question: https://github.com/jenkinsci/jenkins/pull/6618
>
> So, two questions:
> 1) Is it OK if we are *postponing the release by one additional week*? a) 
> to have two weeks of test for the RC, b) to get more time for the security 
> release that requires to have that PR merged. It would mean that the LTS 
> will be released on June 22. (and thus the Java 11 should be postponed 
> again)
> 2) When do you plan to merge the PR?
>
> The second wave of backports seems to contain important fixes, so 
> postponing those seems to be not really an option.
>
> Best regards,
>
> Wadeck
> On Tuesday, May 31, 2022 at 8:37:24 PM UTC+2 m...@basilcrow.com wrote:
>
>> On Fri, May 27, 2022 at 3:03 AM Alexander Brandes  
>> wrote: 
>> > 
>> > If there are no objections against it, I'd like to use the additional 
>> time and start a secondary backporting process from past weekly releases to 
>> integrate the new LTS candidates. 
>>
>> +1 
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/5c711ab6-94ba-446d-bf30-e1659fa82368n%40googlegroups.com.


Re: Backporting for LTS 2.346.1 started

2022-06-07 Thread 'wfoll...@cloudbees.com' via Jenkins Developers
Hey there, especially Alex,

Usually we have a two weeks period for the RC, once the backports are 
merged. In this case, we have a PR that is still pending, ~one week after 
the expected delay.
PR in question: https://github.com/jenkinsci/jenkins/pull/6618

So, two questions:
1) Is it OK if we are *postponing the release by one additional week*? a) 
to have two weeks of test for the RC, b) to get more time for the security 
release that requires to have that PR merged. It would mean that the LTS 
will be released on June 22. (and thus the Java 11 should be postponed 
again)
2) When do you plan to merge the PR?

The second wave of backports seems to contain important fixes, so 
postponing those seems to be not really an option.

Best regards,

Wadeck
On Tuesday, May 31, 2022 at 8:37:24 PM UTC+2 m...@basilcrow.com wrote:

> On Fri, May 27, 2022 at 3:03 AM Alexander Brandes  
> wrote:
> >
> > If there are no objections against it, I'd like to use the additional 
> time and start a secondary backporting process from past weekly releases to 
> integrate the new LTS candidates.
>
> +1
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/2f425abe-e8e9-4002-bb3c-1f4219d8a344n%40googlegroups.com.


Re: warnings-ng-plugin-devenv/analysis-model/bin/go.sh missing a step?

2022-06-07 Thread Ullrich Hafner
In your Jenkinsfile of your job where you want to use the parser. Or are you 
using a Freestyle project? 

I think in Freestyle projects I forgot to add a dynamic selection of the parser 
ID in the UI up to now. I should file an issue for this bug. In this case you 
need to register your parser in the warnings plugin as well...

> Am 07.06.2022 um 03:03 schrieb Simon Matthews :
> 
> 
> On Monday, June 6, 2022 at 2:46:19 PM UTC-7 ullrich...@gmail.com wrote:
> 
> Thanks for your reply. 
> 
> To update on progress, I had not previously added the 
> analysis-model/src/test/java/edu/hm/hafner/analysis/parser/ parser>ParserTest.java file. I have now added that and the unit tests are 
> passing. 
> 
> The parser is not listed in the UI, because the parser is not registered in 
> the warnings plugin yet. 
> But you can invoke the parser already using:
> 
> recordIssues tool: analysisParser(pattern: 'your-report-file.xml', 
> analysisModelId: 'your-id')
> Does that work?
> 
> 
> It's not clear to me how I run that command, or what file I add it to. 
> 
> Simon
> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to jenkinsci-dev+unsubscr...@googlegroups.com 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/e1d2aaa9-a418-431d-80ef-2a7b26b96643n%40googlegroups.com
>  
> .

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/640FA544-D6B8-42B9-82A1-39A9E85FB446%40gmail.com.